Re: [meta-intel] [PATCH] ledmon: control hard disk led for RAID arrays

2019-03-25 Thread Burton, Ross 
On Mon, 25 Mar 2019 at 05:24, Liwei Song  wrote:
> >> +EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"
> >
> > Are these needed, as they're exported.  If we need to pass LDFLAGS
> > like this, why not CFLAGS?
>
> This is used to fix an QA WARNING:
>
> WARNING: ledmon-0.90-git do_package_qa: QA Issue: No GNU_HASH in the ELF 
> binary 
> /project/tmp-glibc/work/corei7-64-wrs-linux/ledmon/0.90-git/packages-split/ledmon/usr/sbin/ledmon,
>  didn't pass LDFLAGS?

So you'll need to pass CFLAGS CPPFLAGS too then.

Ross
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel

Re: [meta-intel] [PATCH] ledmon: control hard disk led for RAID arrays

2019-03-24 Thread Liwei Song 



On 03/22/2019 10:13 PM, Burton, Ross wrote:
> On Fri, 22 Mar 2019 at 02:24, Liwei Song  wrote:
>> +PARALLEL_MAKE = ""
> 
> Is this really needed? How about at least filing a bug upstream.

If do not add this, we will got build error in a low rate about 1/10, due to an
parallel build for it, so we may need keep this until it is fixed.

I will try to file a bug to ledmon upstream.

> 
>> +SRC_URI = "git://github.com/intel/ledmon;branch=master"
>> +SRCREV = "8a5d9526e5666e75625427b85a2586436651e89c"
> 
> Upstream tags releases, so please set the filename to (for example)
> ledmon_0.90.git and then set SRCREV to the sha of that tag.

Got it, will modify according this format.


> 
>> +EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"
> 
> Are these needed, as they're exported.  If we need to pass LDFLAGS
> like this, why not CFLAGS?

This is used to fix an QA WARNING:

WARNING: ledmon-0.90-git do_package_qa: QA Issue: No GNU_HASH in the ELF binary 
/project/tmp-glibc/work/corei7-64-wrs-linux/ledmon/0.90-git/packages-split/ledmon/usr/sbin/ledmon,
 didn't pass LDFLAGS?

> 
>> +do_compile() {
>> +oe_runmake SYSROOT="${STAGING_DIR_TARGET}"
>> +}
> 
> ross@blackadder ~/Downloads/Holding/ledmon (master)
> $ git grep SYSROOT|wc -l
>0
> 
> Why are you passing SYSROOT?

Will delete it.


> 
>> +do_install() {
>> +   oe_runmake install DESTDIR=${D}
>> +   cd ${S}/systemd
>> +   oe_runmake install DESTDIR=${D}
>> +}
> 
> There's an install-systemd target so you could just do:
> 
> oe_runmake DESTDIR=${D}  install install-systemd

Thanks, will use install-systemd target

Liwei.


> 
> Ross
> 
> 
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel

Re: [meta-intel] [PATCH] ledmon: control hard disk led for RAID arrays

2019-03-22 Thread Burton, Ross 
On Fri, 22 Mar 2019 at 02:24, Liwei Song  wrote:
> +PARALLEL_MAKE = ""

Is this really needed? How about at least filing a bug upstream.

> +SRC_URI = "git://github.com/intel/ledmon;branch=master"
> +SRCREV = "8a5d9526e5666e75625427b85a2586436651e89c"

Upstream tags releases, so please set the filename to (for example)
ledmon_0.90.git and then set SRCREV to the sha of that tag.

> +EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"

Are these needed, as they're exported.  If we need to pass LDFLAGS
like this, why not CFLAGS?

> +do_compile() {
> +oe_runmake SYSROOT="${STAGING_DIR_TARGET}"
> +}

ross@blackadder ~/Downloads/Holding/ledmon (master)
$ git grep SYSROOT|wc -l
   0

Why are you passing SYSROOT?

> +do_install() {
> +   oe_runmake install DESTDIR=${D}
> +   cd ${S}/systemd
> +   oe_runmake install DESTDIR=${D}
> +}

There's an install-systemd target so you could just do:

oe_runmake DESTDIR=${D}  install install-systemd

Ross
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel

[meta-intel] [PATCH] ledmon: control hard disk led for RAID arrays

2019-03-21 Thread Liwei Song 
Enable LED support for Intel Virtual RAID On CPU.

Signed-off-by: Liwei Song 
---
 recipes-bsp/ledmon/ledmon_git.bb | 32 
 1 file changed, 32 insertions(+)
 create mode 100644 recipes-bsp/ledmon/ledmon_git.bb

diff --git a/recipes-bsp/ledmon/ledmon_git.bb b/recipes-bsp/ledmon/ledmon_git.bb
new file mode 100644
index ..77a620860cab
--- /dev/null
+++ b/recipes-bsp/ledmon/ledmon_git.bb
@@ -0,0 +1,32 @@
+SUMMARY = "Intel(R) Enclosure LED Utilities"
+
+DESCRIPTION = "The utilities are designed primarily to be used on storage 
servers \
+ utilizing MD devices (aka Linux Software RAID) for RAID arrays.\
+"
+HOMEPAGE = "https://github.com/intel/ledmon;
+
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
+"
+
+DEPENDS = " udev sg3-utils"
+
+PARALLEL_MAKE = ""
+
+SRC_URI = "git://github.com/intel/ledmon;branch=master"
+SRCREV = "8a5d9526e5666e75625427b85a2586436651e89c"
+
+COMPATIBLE_HOST = "(i.86|x86_64).*-linux"
+
+S = "${WORKDIR}/git"
+EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"
+
+do_compile() {
+oe_runmake SYSROOT="${STAGING_DIR_TARGET}"
+}
+
+do_install() {
+   oe_runmake install DESTDIR=${D}
+   cd ${S}/systemd
+   oe_runmake install DESTDIR=${D}
+}
-- 
2.7.4

-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel