Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a multilib hack to build standalone components

[Manjukumar Harthikote Matha]

Hi Martin/Jean,


> -Original Message-
> From: meta-xilinx-boun...@yoctoproject.org [mailto:meta-xilinx-
> boun...@yoctoproject.org] On Behalf Of Martin Siegumfeldt
> Sent: Friday, December 14, 2018 11:58 AM
> To: Jean-Francois Dagenais 
> Cc: Alejandro Enedino Hernandez Samaniego ; meta-
> xil...@yoctoproject.org
> Subject: Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a
> multilib hack to build standalone components
> 
> Hi Jean-Francois,
> 
> Appreciate your input, however, since we don't use meta-xilinx-tools, the
> workaround of a dual dependency (from both image- and u-boot) towards PMUFW
> appears more feasible for us.
> 

This is something that should be fixed in OE-core, we are working on it

Thanks,
Manju

> Thanks,
> Martin
> 
> From: Jean-Francois Dagenais 
> Sent: Thursday, December 13, 2018 2:31:30 PM
> To: Martin Siegumfeldt
> Cc: Alejandro Enedino Hernandez Samaniego; meta-xilinx@yoctoproject.org
> Subject: Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a
> multilib hack to build standalone components
> 
> On Dec 12, 2018, at 3:21 AM, Martin Siegumfeldt
> mailto:m...@gomspace.com>> wrote:
> 
> It looks to me as Manju's proposal of adding it as an image dependency may 
> work
> when building the image, but appears to be subject to a race condition between
> pmu-firmware and virtual/bootloader.
> 
>  I instigated the idea to transform the fsbl build from a class to a proper 
> recipe and
> tying it the the wic stage using. I then had to resolve this same race and if 
> I
> remember correctly, the fix looked like this:
> 
> https://www.mail-archive.com/meta-xilinx@yoctoproject.org/msg02458.html
> 
> Not sure if it applies to your specific situation here. I have not invested 
> much time in
> the multi-config stuff. I resorted to meta-xilinx-tools a while back, managed 
> to
> "make it work" in our CI docker environment and have not looked back since.
> --
> ___
> meta-xilinx mailing list
> meta-xilinx@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-xilinx
-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx

Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a multilib hack to build standalone components

[Martin Siegumfeldt]

Hi Jean-Francois,

Appreciate your input, however, since we don't use meta-xilinx-tools, the 
workaround of a dual dependency (from both image- and u-boot) towards PMUFW 
appears more feasible for us.

Thanks,
Martin

From: Jean-Francois Dagenais 
Sent: Thursday, December 13, 2018 2:31:30 PM
To: Martin Siegumfeldt
Cc: Alejandro Enedino Hernandez Samaniego; meta-xilinx@yoctoproject.org
Subject: Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a 
multilib hack to build standalone components

On Dec 12, 2018, at 3:21 AM, Martin Siegumfeldt 
mailto:m...@gomspace.com>> wrote:

It looks to me as Manju's proposal of adding it as an image dependency may work 
when building the image, but appears to be subject to a race condition between 
pmu-firmware and virtual/bootloader.

 I instigated the idea to transform the fsbl build from a class to a proper 
recipe and tying it the the wic stage using. I then had to resolve this same 
race and if I remember correctly, the fix looked like this:

https://www.mail-archive.com/meta-xilinx@yoctoproject.org/msg02458.html

Not sure if it applies to your specific situation here. I have not invested 
much time in the multi-config stuff. I resorted to meta-xilinx-tools a while 
back, managed to "make it work" in our CI docker environment and have not 
looked back since.
-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx

Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a multilib hack to build standalone components

[Jean-Francois Dagenais]

> On Dec 12, 2018, at 3:21 AM, Martin Siegumfeldt  wrote:
> 
> It looks to me as Manju's proposal of adding it as an image dependency may 
> work when building the image, but appears to be subject to a race condition 
> between pmu-firmware and virtual/bootloader.

 I instigated the idea to transform the fsbl build from a class to a proper 
recipe and tying it the the wic stage using. I then had to resolve this same 
race and if I remember correctly, the fix looked like this:

https://www.mail-archive.com/meta-xilinx@yoctoproject.org/msg02458.html 


Not sure if it applies to your specific situation here. I have not invested 
much time in the multi-config stuff. I resorted to meta-xilinx-tools a while 
back, managed to "make it work" in our CI docker environment and have not 
looked back since.-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx

Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a multilib hack to build standalone components

[Martin Siegumfeldt]

From: meta-xilinx-boun...@yoctoproject.org 
 on behalf of Jean-Francois Dagenais 

Sent: Saturday, December 8, 2018 4:11 AM
To: Alejandro Enedino Hernandez Samaniego
Cc: meta-xilinx@yoctoproject.org
Subject: Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a 
multilib hack to build standalone components

On Dec 6, 2018, at 4:56 PM, Alejandro Enedino Hernandez Samaniego 
mailto:alejandro.enedino.hernandez-samani...@xilinx.com>>
 wrote:

diff --git a/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc 
b/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc
index 9cf09ff..6233bc8 100644
--- a/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc
+++ b/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc
@@ -65,7 +65,7 @@ python () {

if providesbin and d.getVar("SOC_FAMILY") in ["zynqmp"]:
# depend on the pmu-firmware build
-d.appendVar("DEPENDS", " virtual/pmu-firmware")
+#d.appendVar("DEPENDS", " virtual/pmu-firmware")

Just delete the line, let's not accumulate stale, commented code around.

I assume this dependency would need to be adapted into the multi-config setup, 
however I am surprised it is completely removed - it still exists (in case of 
SPL) right? Perhaps I am missing it, but I don't see it reintroduced anywhere? 
The multi-config setup (as described here: 
https://lists.yoctoproject.org/pipermail/meta-xilinx/2018-November/004087.html),
 fails to build 'virtual/bootloader' due to missing PMUFW file:

"Cannot read 
../../../../../../pmutmp/deploy/images/zynqmp-pmu/pmu-firmware-zynqmp-pmu.bin"

which is fair enough, since no one requested the build of it. This appears to 
be a regression since Sumo, where the dependency indeed was in place (because 
of the above definition):

bitbake virtual/bootloader -e | grep ^DEPENDS=
DEPENDS="virtual/aarch64-gomspace-linux-gcc 
virtual/aarch64-gomspace-linux-compilerlibs virtual/libc  swig-native 
python-native bc-native dtc-native openssl-native virtual/pmu-firmware"

It looks to me as Manju's proposal of adding it as an image dependency may work 
when building the image, but appears to be subject to a race condition between 
pmu-firmware and virtual/bootloader.

Br,
Martin

# determine the path relative to the source tree
relpath = 
os.path.relpath(d.expand("${DEPLOY_DIR_IMAGE}/pmu-${MACHINE}.bin"), 
d.getVar("S"))
# setup PMU Firmware path via MAKEFLAGS
--
2.7.4

-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx

Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a multilib hack to build standalone components

[Alejandro Enedino Hernandez Samaniego]

Hey Luca,


On 12/11/2018 07:45 AM, Luca Ceresoli wrote:

Hi Alejandro,

On 06/12/18 22:56, Alejandro Enedino Hernandez Samaniego wrote:

The zynqmp-pmu class was being used to build standalone components (PMU)
for several devices, with the introduction of the meta-xilinx-standalone
layer and the xilinx-standalone distro, this is not necessary anymore.

Signed-off-by: Alejandro Enedino Hernandez Samaniego 
Signed-off-by: Manjukumar Matha 

I appreciate the effort in building pmu-firmware without hacks! (even
though the alternative does not seem to come at a cheap cost)
Thanks!, sadly it does not, but I do believe that going in the right 
direction eventually pays off.


Alejandro



Reviewed-by: Luca Ceresoli 



--
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx

Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a multilib hack to build standalone components

[Luca Ceresoli]

Hi Alejandro,

On 06/12/18 22:56, Alejandro Enedino Hernandez Samaniego wrote:
> The zynqmp-pmu class was being used to build standalone components (PMU)
> for several devices, with the introduction of the meta-xilinx-standalone
> layer and the xilinx-standalone distro, this is not necessary anymore.
> 
> Signed-off-by: Alejandro Enedino Hernandez Samaniego 
> Signed-off-by: Manjukumar Matha 

I appreciate the effort in building pmu-firmware without hacks! (even
though the alternative does not seem to come at a cheap cost)

Reviewed-by: Luca Ceresoli 

-- 
Luca
-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx

Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a multilib hack to build standalone components

[Manjukumar Harthikote Matha]

Hi Jean-Francois,

The next patch series will clean the commented line including a change to 
provide user-path for PMU-FW
https://github.com/Xilinx/meta-xilinx/commit/e0c181b0963aabca581866b58123ef50f0b6b122

This is the tree for next release
https://github.com/Xilinx/meta-xilinx/commits/master-next

Thanks,
Manju

From: meta-xilinx-boun...@yoctoproject.org 
[mailto:meta-xilinx-boun...@yoctoproject.org] On Behalf Of Jean-Francois 
Dagenais
Sent: Friday, December 07, 2018 7:12 PM
To: Alejandro Enedino Hernandez Samaniego 
Cc: meta-xilinx@yoctoproject.org
Subject: Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a 
multilib hack to build standalone components




On Dec 6, 2018, at 4:56 PM, Alejandro Enedino Hernandez Samaniego 
mailto:alejandro.enedino.hernandez-samani...@xilinx.com>>
 wrote:

diff --git a/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc 
b/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc
index 9cf09ff..6233bc8 100644
--- a/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc
+++ b/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc
@@ -65,7 +65,7 @@ python () {

if providesbin and d.getVar("SOC_FAMILY") in ["zynqmp"]:
# depend on the pmu-firmware build
-d.appendVar("DEPENDS", " virtual/pmu-firmware")
+#d.appendVar("DEPENDS", " virtual/pmu-firmware")

Just delete the line, let's not accumulate stale, commented code around.

# determine the path relative to the source tree
relpath = 
os.path.relpath(d.expand("${DEPLOY_DIR_IMAGE}/pmu-${MACHINE}.bin"), 
d.getVar("S"))
# setup PMU Firmware path via MAKEFLAGS
--
2.7.4

-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx

Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a multilib hack to build standalone components

[Jean-Francois Dagenais]

> On Dec 6, 2018, at 4:56 PM, Alejandro Enedino Hernandez Samaniego 
>  wrote:
> 
> diff --git a/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc 
> b/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc
> index 9cf09ff..6233bc8 100644
> --- a/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc
> +++ b/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc
> @@ -65,7 +65,7 @@ python () {
> 
> if providesbin and d.getVar("SOC_FAMILY") in ["zynqmp"]:
> # depend on the pmu-firmware build
> -d.appendVar("DEPENDS", " virtual/pmu-firmware")
> +#d.appendVar("DEPENDS", " virtual/pmu-firmware")

Just delete the line, let's not accumulate stale, commented code around. 

> # determine the path relative to the source tree
> relpath = 
> os.path.relpath(d.expand("${DEPLOY_DIR_IMAGE}/pmu-${MACHINE}.bin"), 
> d.getVar("S"))
> # setup PMU Firmware path via MAKEFLAGS
> -- 
> 2.7.4

-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx