date:20150204

Re: [Mingw-w64-public] Small Header additions

2015-02-04 Thread Jacek Caban

Yes. I don't think it's a problem that one GUID would be different, it
would be just a good example for future improvements, but your patch is
fine as well.

On 02/04/15 17:13, Martell Malone wrote:
 Will I consider this reviewed?
 Just need the go ahead

 On Wed, Feb 4, 2015 at 3:23 PM, Martell Malone
 martellmal...@gmail.com mailto:martellmal...@gmail.com wrote:

 I know that it's not what we do in other cases, but something
 like that
 would avoid hardcoding this uuid in two places:

 DEFINE_GUID(KSCATEGORY_
 ENCODER, STATIC_KSCATEGORY_ENCODER);


 Yes I was going todo it that way but I saw that many of the others
 from that header were defined already and with the full string
 So I didn't want todo it just for this one GUID 

 On Wed, Feb 4, 2015 at 3:18 PM, Jacek Caban ja...@codeweavers.com
 mailto:ja...@codeweavers.com wrote:

 Hi Martell,

 Those patches look good to me now. I just have one suggestion.

 On 02/04/15 16:14, Martell Malone wrote:
  
 
 DEFINE_GUID(KSCATEGORY_DATADECOMPRESSOR,0x2721ae20,0x7e70,0x11d0,0xa5,0xd6,0x28,0xdb,0x4,0xc1,0,0);
  
 
 DEFINE_GUID(KSCATEGORY_DATATRANSFORM,0x2eb07ea0,0x7e70,0x11d0,0xa5,0xd6,0x28,0xdb,0x4,0xc1,0,0);
 
 
 +DEFINE_GUID(KSCATEGORY_ENCODER,0x19689bf6,0xc384,0x48fd,0xad,0x51,0x90,0xe5,0x8c,0x79,0xf7,0xb);

 I know that it's not what we do in other cases, but something
 like that
 would avoid hardcoding this uuid in two places:

 DEFINE_GUID(KSCATEGORY_ENCODER, STATIC_KSCATEGORY_ENCODER);

 Thanks,
 Jacek


 
 --
 Dive into the World of Parallel Programming. The Go Parallel
 Website,
 sponsored by Intel and developed in partnership with Slashdot
 Media, is your
 hub for all things parallel software development, from weekly
 thought
 leadership blogs to news, videos, case studies, tutorials and
 more. Take a
 look and join the conversation now.
 http://goparallel.sourceforge.net/
 ___
 Mingw-w64-public mailing list
 Mingw-w64-public@lists.sourceforge.net
 mailto:Mingw-w64-public@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/mingw-w64-public





 --
 Dive into the World of Parallel Programming. The Go Parallel Website,
 sponsored by Intel and developed in partnership with Slashdot Media, is your
 hub for all things parallel software development, from weekly thought
 leadership blogs to news, videos, case studies, tutorials and more. Take a
 look and join the conversation now. http://goparallel.sourceforge.net/


 ___
 Mingw-w64-public mailing list
 Mingw-w64-public@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Small Header additions

2015-02-04 Thread Martell Malone

Will I consider this reviewed?
Just need the go ahead

On Wed, Feb 4, 2015 at 3:23 PM, Martell Malone martellmal...@gmail.com
wrote:

 I know that it's not what we do in other cases, but something like that
 would avoid hardcoding this uuid in two places:

 DEFINE_GUID(KSCATEGORY_
 ENCODER, STATIC_KSCATEGORY_ENCODER);


 Yes I was going todo it that way but I saw that many of the others from
 that header were defined already and with the full string
 So I didn't want todo it just for this one GUID

 On Wed, Feb 4, 2015 at 3:18 PM, Jacek Caban ja...@codeweavers.com wrote:

 Hi Martell,

 Those patches look good to me now. I just have one suggestion.

 On 02/04/15 16:14, Martell Malone wrote:
 
 DEFINE_GUID(KSCATEGORY_DATADECOMPRESSOR,0x2721ae20,0x7e70,0x11d0,0xa5,0xd6,0x28,0xdb,0x4,0xc1,0,0);
 
 DEFINE_GUID(KSCATEGORY_DATATRANSFORM,0x2eb07ea0,0x7e70,0x11d0,0xa5,0xd6,0x28,0xdb,0x4,0xc1,0,0);
 
 +DEFINE_GUID(KSCATEGORY_ENCODER,0x19689bf6,0xc384,0x48fd,0xad,0x51,0x90,0xe5,0x8c,0x79,0xf7,0xb);

 I know that it's not what we do in other cases, but something like that
 would avoid hardcoding this uuid in two places:

 DEFINE_GUID(KSCATEGORY_ENCODER, STATIC_KSCATEGORY_ENCODER);

 Thanks,
 Jacek



 --
 Dive into the World of Parallel Programming. The Go Parallel Website,
 sponsored by Intel and developed in partnership with Slashdot Media, is
 your
 hub for all things parallel software development, from weekly thought
 leadership blogs to news, videos, case studies, tutorials and more. Take a
 look and join the conversation now. http://goparallel.sourceforge.net/
 ___
 Mingw-w64-public mailing list
 Mingw-w64-public@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/mingw-w64-public



--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH] memory.h: Merged memory_s.h into memory.h.

2015-02-04 Thread Jacek Caban

---
 mingw-w64-headers/crt/memory.h   |  1 +
 mingw-w64-headers/crt/sec_api/memory_s.h | 26 --
 mingw-w64-headers/crt/sec_api/string_s.h |  5 -
 mingw-w64-headers/crt/string.h   |  1 +
 4 files changed, 2 insertions(+), 31 deletions(-)
 delete mode 100644 mingw-w64-headers/crt/sec_api/memory_s.h


diff --git a/mingw-w64-headers/crt/memory.h b/mingw-w64-headers/crt/memory.h
index 2afc51f..5699be5 100644
--- a/mingw-w64-headers/crt/memory.h
+++ b/mingw-w64-headers/crt/memory.h
@@ -27,6 +27,7 @@ extern C {
   _CRTIMP int __cdecl _memicmp_l(const void *_Buf1,const void *_Buf2,size_t _Size,_locale_t _Locale);
   int __cdecl memcmp(const void *_Buf1,const void *_Buf2,size_t _Size);
   void * __cdecl memcpy(void * __restrict__ _Dst,const void * __restrict__ _Src,size_t _Size) __MINGW_ATTRIB_DEPRECATED_SEC_WARN;
+  _CRTIMP errno_t __cdecl memcpy_s (void *_dest,size_t _numberOfElements,const void *_src,size_t _count);
   void * __cdecl mempcpy (void *_Dst, const void *_Src, size_t _Size);
   void * __cdecl memset(void *_Dst,int _Val,size_t _Size);
 
diff --git a/mingw-w64-headers/crt/sec_api/memory_s.h b/mingw-w64-headers/crt/sec_api/memory_s.h
deleted file mode 100644
index 53196d0..000
--- a/mingw-w64-headers/crt/sec_api/memory_s.h
+++ /dev/null
@@ -1,26 +0,0 @@
-/**
- * This file has no copyright assigned and is placed in the Public Domain.
- * This file is part of the mingw-w64 runtime package.
- * No warranty is given; refer to the file DISCLAIMER.PD within this package.
- */
-#ifndef _INC_MEMORY_S
-#define _INC_MEMORY_S
-
-#if defined(MINGW_HAS_SECURE_API)
-#include memory.h
-
-#ifdef __cplusplus
-extern C {
-#endif /*__cplusplus*/
-
-#ifndef _MEMORY_S_DEFINED
-#define _MEMORY_S_DEFINED
- errno_t __cdecl memcpy_s (void *_dest,size_t _numberOfElements,const void *_src,size_t _count);
-#endif /*_MEMORY_S_DEFINED*/
-
-#ifdef __cplusplus
-}
-#endif /*__cplusplus*/
-
-#endif /*MINGW_HAS_SECURE_API*/
-#endif /*_INC_MEMORY_S*/
diff --git a/mingw-w64-headers/crt/sec_api/string_s.h b/mingw-w64-headers/crt/sec_api/string_s.h
index 1eac92e..7d36d91 100644
--- a/mingw-w64-headers/crt/sec_api/string_s.h
+++ b/mingw-w64-headers/crt/sec_api/string_s.h
@@ -65,11 +65,6 @@ extern C {
   }
 #endif
 
-#ifndef _MEMORY_S_DEFINED
-#define _MEMORY_S_DEFINED
-  _CRTIMP errno_t __cdecl memcpy_s (void *_dest,size_t _numberOfElements,const void *_src,size_t _count);
-#endif /*_MEMORY_S_DEFINED*/
-
 #ifdef __cplusplus
 }
 #endif
diff --git a/mingw-w64-headers/crt/string.h b/mingw-w64-headers/crt/string.h
index 16831e3..84c8d71 100644
--- a/mingw-w64-headers/crt/string.h
+++ b/mingw-w64-headers/crt/string.h
@@ -39,6 +39,7 @@ extern C {
   _CRTIMP int __cdecl _memicmp_l(const void *_Buf1,const void *_Buf2,size_t _Size,_locale_t _Locale);
   int __cdecl memcmp(const void *_Buf1,const void *_Buf2,size_t _Size);
   void * __cdecl memcpy(void * __restrict__ _Dst,const void * __restrict__ _Src,size_t _Size) __MINGW_ATTRIB_DEPRECATED_SEC_WARN;
+  _CRTIMP errno_t __cdecl memcpy_s (void *_dest,size_t _numberOfElements,const void *_src,size_t _count);
   void * __cdecl mempcpy (void *_Dst, const void *_Src, size_t _Size);
   void * __cdecl memset(void *_Dst,int _Val,size_t _Size);
 #ifndef	NO_OLDNAMES

--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH] New Discovery Keys file

2015-02-04 Thread Martell Malone

Please Review :)


0001-added-new-file-functiondiscoverykeys_devpkey.h-and-k.patch
Description: Binary data
--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Small Header additions

2015-02-04 Thread Jacek Caban

Hi Martell,

On 02/04/15 12:10, Martell Malone wrote:
 +#warning COM interfaces layout in this header has not been verified.
 +#warning COM interfaces with incorrect layout may not work at all.
 +__MINGW_BROKEN_INTERFACE(INTERFACE)

The interface seems correct, why do you add this warning? Same for
IMPEG2PIDMap.

+OUR_GUID_ENTRY(MEDIASUBTYPE_RAW_AAC1,0x00FF,0x,0x0010,0x80,0x00,0x00,0xaa,0x00,0x38,0x9b,0x71)
+OUR_GUID_ENTRY(MEDIASUBTYPE_DVM,0x2000,0x,0x0010,0x80,0x00,0x00,0xaa,0x00,0x38,0x9b,0x71)


Those two should be in wmcodecdsp.idl AFAICS.

diff --git a/mingw-w64-crt/libsrc/uuid.c b/mingw-w64-crt/libsrc/uuid.c
index 22d806d..79d0c3e 100644
--- a/mingw-w64-crt/libsrc/uuid.c
+++ b/mingw-w64-crt/libsrc/uuid.c
@@ -23,6 +23,7 @@
 #include oleacc.h
 #include uiautomation.h
 #include urlmon.h
+#include ksmedia.h


What do you need this for? Those UUIDs don't seem to belong to libuuid.a. 
libksuser.a may be what you're looking for.

Jacek



--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [Patch] - Hardening libssp against malicious local processes

2015-02-04 Thread Jacek Caban

Hi Georg,

On 02/03/15 11:53, Georg Koppen wrote:
 Hi,

 I am putting a patch inline (not sure if attachments are allowed on this
 mailing list) that does not make it possible for a local process anymore
 to replace canaries which in turn might disable SSP. Comments and/or
 review are much appreciated.

 The problem it is trying to solve is outlined in
 https://trac.torproject.org/13169#comment:4:

 (Quoting a cypherpunk)

 In Windows you can to create any directories for any disks(C:, D:, ..
 Z:), only system directories (Windows directory, Program files, etc) are
 protected. Any process with privileges of any standard user can to
 create C:\dev\urandom file and to fill it by any stuff.

 And now the patch (arguably the subject can be a bit more elaborate):

Thanks for the patch, but it belongs to GCC and as such gcc-patches ML
is the right place to send it.

I have nothing to do with libssp nor have much experience with GCC
patches, but I have some suggestions:

 From 83e3ea38a5720df52bd5f78dcd3c7b7b842ddc3b Mon Sep 17 00:00:00 2001
 From: Erinn Clark er...@torproject.org
 Date: Wed, 12 Mar 2014 16:09:10 +0100
 Subject: [PATCH] skruffy patch

 ---
  libssp/ssp.c |   16 
  1 file changed, 16 insertions(+)

 diff --git a/libssp/ssp.c b/libssp/ssp.c
 index aaa5a32..37f4e27 100644
 --- a/libssp/ssp.c
 +++ b/libssp/ssp.c
 @@ -55,6 +55,7 @@ see the files COPYING3 and COPYING.RUNTIME
 respectively.  If not, see
  /* Native win32 apps don't know about /dev/tty but can print directly
 to the console using  CONOUT$   */
  #if defined (_WIN32)  !defined (__CYGWIN__)
 +#include windows.h
  # define _PATH_TTY CONOUT$
  #else
  # define _PATH_TTY /dev/tty
 @@ -75,6 +76,20 @@ __guard_setup (void)
if (__stack_chk_guard != 0)
  return;

 +#if defined (_WIN32)  !defined (__CYGWIN__)
 +  HCRYPTPROV hprovider = 0;

Looking at the rest of the file, it seems that it maintains C89
compatibility or at least coding style uses declarations in the
beginning of the block.

 +  if (CryptAcquireContext(hprovider, NULL, NULL, PROV_RSA_FULL,
 +  CRYPT_VERIFYCONTEXT | CRYPT_SILENT))
 +{
 +  if (CryptGenRandom(hprovider, sizeof (__stack_chk_guard),
 +  (BYTE *)__stack_chk_guard)   __stack_chk_guard != 0)
 +{
 +   CryptReleaseContext(hprovider, 0);
 +   return;
 +}
 +  CryptReleaseContext(hprovider, 0);
 +}

Did you consider using RtlGenRandom instead? This would simplify the code.

Another alternative would be using rand_s, which is a variant of rand
that doesn't require srand (see Wine implementation for an example [1]).
Its problem is, however, that it returns int, which is inconvenient for
64-bit arch in this case.

 +#else
fd = open (/dev/urandom, O_RDONLY);
if (fd != -1)
  {
 @@ -85,6 +100,7 @@ __guard_setup (void)
  return;
  }

 +#endif
/* If a random generator can't be used, the protector switches the guard
   to the terminator canary.  */
p = (unsigned char *) __stack_chk_guard;
 --
 1.7.10.4

Thanks,
Jacek

[1] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/msvcrt/misc.c#l68

--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] Small Header additions

2015-02-04 Thread Martell Malone

Small header changes for various missing uuid's and 2 classes

Please Review


0001-Added-IEnumPIDMap-and-IMPEG2PIDMap-to-bdaiface.h.patch
Description: Binary data


0001-Add-some-missing-uuid-s.patch
Description: Binary data


0001-include-ksmedia-uuids-in-libuuid.patch
Description: Binary data
--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Small Header additions

2015-02-04 Thread Martell Malone


 The interface seems correct, why do you add this warning? Same for
 IMPEG2PIDMap

All the other interfaces in the file also have this warning so I didn't
want to remove it.
Attached updated patch :)


Those two should be in wmcodecdsp.idl AFAICS.

Yes as discussed on IRC there are a few uuid's in the wrong place already.
Updated patch to put these 2 and more in the correct place :)

What do you need this for? Those UUIDs don't seem to belong to libuuid.a.
 libksuser.a may be what you're looking for.

Added a missing GUID to libksuser.a :)

On Wed, Feb 4, 2015 at 11:46 AM, Jacek Caban ja...@codeweavers.com wrote:

 Hi Martell,

 On 02/04/15 12:10, Martell Malone wrote:
  +#warning COM interfaces layout in this header has not been verified.
  +#warning COM interfaces with incorrect layout may not work at all.
  +__MINGW_BROKEN_INTERFACE(INTERFACE)

 The interface seems correct, why do you add this warning? Same for
 IMPEG2PIDMap.


 +OUR_GUID_ENTRY(MEDIASUBTYPE_RAW_AAC1,0x00FF,0x,0x0010,0x80,0x00,0x00,0xaa,0x00,0x38,0x9b,0x71)

 +OUR_GUID_ENTRY(MEDIASUBTYPE_DVM,0x2000,0x,0x0010,0x80,0x00,0x00,0xaa,0x00,0x38,0x9b,0x71)


 Those two should be in wmcodecdsp.idl AFAICS.

 diff --git a/mingw-w64-crt/libsrc/uuid.c b/mingw-w64-crt/libsrc/uuid.c
 index 22d806d..79d0c3e 100644
 --- a/mingw-w64-crt/libsrc/uuid.c
 +++ b/mingw-w64-crt/libsrc/uuid.c
 @@ -23,6 +23,7 @@
  #include oleacc.h
  #include uiautomation.h
  #include urlmon.h
 +#include ksmedia.h


 What do you need this for? Those UUIDs don't seem to belong to libuuid.a.
 libksuser.a may be what you're looking for.

 Jacek




 --
 Dive into the World of Parallel Programming. The Go Parallel Website,
 sponsored by Intel and developed in partnership with Slashdot Media, is
 your
 hub for all things parallel software development, from weekly thought
 leadership blogs to news, videos, case studies, tutorials and more. Take a
 look and join the conversation now. http://goparallel.sourceforge.net/
 ___
 Mingw-w64-public mailing list
 Mingw-w64-public@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

From 0b800b7531278cbde1f4bb0096fd219a53b72305 Mon Sep 17 00:00:00 2001
From: Martell Malone martellmal...@gmail.com
Date: Wed, 4 Feb 2015 09:52:04 +
Subject: [PATCH] Added IEnumPIDMap and IMPEG2PIDMap to bdaiface.h

---
 mingw-w64-headers/include/bdaiface.h | 79 
 1 file changed, 79 insertions(+)

diff --git a/mingw-w64-headers/include/bdaiface.h 
b/mingw-w64-headers/include/bdaiface.h
index ec57204..50908cb 100644
--- a/mingw-w64-headers/include/bdaiface.h
+++ b/mingw-w64-headers/include/bdaiface.h
@@ -10,6 +10,75 @@
 #include bdatypes.h
 #include dshow.h
 
+#if (_WIN32_WINNT = 0x0600)
+
+#ifndef __IEnumPIDMap_FWD_DEFINED__
+#define __IEnumPIDMap_FWD_DEFINED__
+typedef interface IEnumPIDMap IEnumPIDMap;
+#endif
+
+#ifndef __IMPEG2PIDMap_FWD_DEFINED__
+#define __IMPEG2PIDMap_FWD_DEFINED__
+typedef interface IMPEG2PIDMap IMPEG2PIDMap;
+#endif
+
+#undef  INTERFACE
+#define INTERFACE IEnumPIDMap
+DECLARE_INTERFACE_(IEnumPIDMap,IUnknown)
+{
+BEGIN_INTERFACE
+
+/* IUnknown methods */
+STDMETHOD(QueryInterface)(THIS_ REFIID riid, void **ppvObject) PURE;
+STDMETHOD_(ULONG, AddRef)(THIS) PURE;
+STDMETHOD_(ULONG, Release)(THIS) PURE;
+/* IEnumPIDMap methods */
+STDMETHOD_(HRESULT,Next)(THIS_ ULONG req, PID_MAP *map, ULONG count) PURE;
+STDMETHOD_(HRESULT,Skip)(THIS_ ULONG rec) PURE;
+STDMETHOD_(HRESULT,Reset)(THIS) PURE;
+STDMETHOD_(HRESULT,Clone)(THIS_ IEnumPIDMap **pIEnumPIDMap) PURE;
+
+END_INTERFACE
+};
+#ifdef COBJMACROS
+#define IEnumPIDMap_QueryInterface(This,riid,ppvObject) 
(This)-lpVtbl-QueryInterface(This,riid,ppvObject)
+#define IEnumPIDMap_AddRef(This) (This)-lpVtbl-AddRef(This)
+#define IEnumPIDMap_Release(This) (This)-lpVtbl-Release(This)
+#define IEnumPIDMap_Next(This,req,map,count) 
(This)-lpVtbl-Next(This,req,map,count)
+#define IEnumPIDMap_Skip(This,rec) (This)-lpVtbl-Skip(This,rec)
+#define IEnumPIDMap_Reset(This) (This)-lpVtbl-Reset(This)
+#define IEnumPIDMap_Clone(This,pIEnumPIDMap) 
(This)-lpVtbl-Clone(This,pIEnumPIDMap)
+#endif /*COBJMACROS*/
+
+#undef  INTERFACE
+#define INTERFACE IMPEG2PIDMap
+DECLARE_INTERFACE_(IMPEG2PIDMap,IUnknown)
+{
+BEGIN_INTERFACE
+
+/* IUnknown methods */
+STDMETHOD(QueryInterface)(THIS_ REFIID riid, void **ppvObject) PURE;
+STDMETHOD_(ULONG, AddRef)(THIS) PURE;
+STDMETHOD_(ULONG, Release)(THIS) PURE;
+
+/* IMPEG2PIDMap methods */
+STDMETHOD_(HRESULT,MapPID)(THIS_ ULONG numPid,ULONG 
*pPid,MEDIA_SAMPLE_CONTENT MediaSampleContent) PURE;
+STDMETHOD_(HRESULT,UnmapPID)(THIS_ ULONG numPid,ULONG *pPid) PURE;
+STDMETHOD_(HRESULT,EnumPIDMap)(THIS_ IEnumPIDMap **pIEnumPIDMap) PURE;
+
+END_INTERFACE
+};
+#ifdef COBJMACROS
+#define

Re: [Mingw-w64-public] Small Header additions

2015-02-04 Thread Jacek Caban

Hi Martell,

Those patches look good to me now. I just have one suggestion.

On 02/04/15 16:14, Martell Malone wrote:
  
 DEFINE_GUID(KSCATEGORY_DATADECOMPRESSOR,0x2721ae20,0x7e70,0x11d0,0xa5,0xd6,0x28,0xdb,0x4,0xc1,0,0);
  
 DEFINE_GUID(KSCATEGORY_DATATRANSFORM,0x2eb07ea0,0x7e70,0x11d0,0xa5,0xd6,0x28,0xdb,0x4,0xc1,0,0);
 +DEFINE_GUID(KSCATEGORY_ENCODER,0x19689bf6,0xc384,0x48fd,0xad,0x51,0x90,0xe5,0x8c,0x79,0xf7,0xb);

I know that it's not what we do in other cases, but something like that
would avoid hardcoding this uuid in two places:

DEFINE_GUID(KSCATEGORY_ENCODER, STATIC_KSCATEGORY_ENCODER);

Thanks,
Jacek


--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Small Header additions

2015-02-04 Thread Martell Malone


 I know that it's not what we do in other cases, but something like that
 would avoid hardcoding this uuid in two places:

 DEFINE_GUID(KSCATEGORY_
 ENCODER, STATIC_KSCATEGORY_ENCODER);


Yes I was going todo it that way but I saw that many of the others from
that header were defined already and with the full string
So I didn't want todo it just for this one GUID

On Wed, Feb 4, 2015 at 3:18 PM, Jacek Caban ja...@codeweavers.com wrote:

 Hi Martell,

 Those patches look good to me now. I just have one suggestion.

 On 02/04/15 16:14, Martell Malone wrote:
 
 DEFINE_GUID(KSCATEGORY_DATADECOMPRESSOR,0x2721ae20,0x7e70,0x11d0,0xa5,0xd6,0x28,0xdb,0x4,0xc1,0,0);
 
 DEFINE_GUID(KSCATEGORY_DATATRANSFORM,0x2eb07ea0,0x7e70,0x11d0,0xa5,0xd6,0x28,0xdb,0x4,0xc1,0,0);
 
 +DEFINE_GUID(KSCATEGORY_ENCODER,0x19689bf6,0xc384,0x48fd,0xad,0x51,0x90,0xe5,0x8c,0x79,0xf7,0xb);

 I know that it's not what we do in other cases, but something like that
 would avoid hardcoding this uuid in two places:

 DEFINE_GUID(KSCATEGORY_ENCODER, STATIC_KSCATEGORY_ENCODER);

 Thanks,
 Jacek



 --
 Dive into the World of Parallel Programming. The Go Parallel Website,
 sponsored by Intel and developed in partnership with Slashdot Media, is
 your
 hub for all things parallel software development, from weekly thought
 leadership blogs to news, videos, case studies, tutorials and more. Take a
 look and join the conversation now. http://goparallel.sourceforge.net/
 ___
 Mingw-w64-public mailing list
 Mingw-w64-public@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Small Header additions

Re: [Mingw-w64-public] Small Header additions

[Mingw-w64-public] [PATCH] memory.h: Merged memory_s.h into memory.h.

[Mingw-w64-public] [PATCH] New Discovery Keys file

Re: [Mingw-w64-public] Small Header additions

Re: [Mingw-w64-public] [Patch] - Hardening libssp against malicious local processes

[Mingw-w64-public] Small Header additions

Re: [Mingw-w64-public] Small Header additions

Re: [Mingw-w64-public] Small Header additions

Re: [Mingw-w64-public] Small Header additions

10 matches

Site Navigation

Mail list logo

Footer information