Re: [Mingw-w64-public] [PATCH] headers: Add missing names in winsvc.h
在 2021-06-30 12:29, Biswapriyo Nath 写道:
Same mistake as previous. How did you catch those warnings? I copied
the modified header to /mingw64/x86_64-w43-mingw32/include folder then
compile a simple file with `#include `. But gcc and clang
shows nothing. I did something wrong but can't figure it out.
GCC does not warn about code in system paths. I usually use this command to
examine headers:
/mingw32/bin/gcc -xc++ -fsyntax-only -ansi -Wall -Wextra \
-D_WIN32_WINNT=0x -Wno-{long-long,expansion-to-defined} \
-Imingw-w64-headers/include/ -include windows.h \
mingw-w64-headers/include/winsvc.h
Hope it helps.
I pushed this patch, following a commit that removed those two erroneous macros.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] headers: Add missing names in winsvc.h
在 6/30/21 12:29 PM, Biswapriyo Nath 写道:
Same mistake as previous. How did you catch those warnings? I copied
the modified header to /mingw64/x86_64-w43-mingw32/include folder then
compile a simple file with `#include `. But gcc and clang
shows nothing. I did something wrong but can't figure it out.
I did that by hand; not sure whether you would like it each time:
```
gcc -E -D_WIN32_WINNT=0x 'C:\Program Files (x86)\Windows
Kits\10\Include\10.0.19041.0\um\winsvc.h' -Wp,-dM -include minwindef.h | sort -u > ~/Desktop/winsdk.i
gcc -E -D_WIN32_WINNT=0x 'mingw-w64-headers/include/winsvc.h' -Wp,-dM -include minwindef.h |
sort -u > ~/Desktop/mingw-w64.i
git diff --no-index ~/Desktop/{winsdk,mingw-w64}.i
```
Our headers are left behind Windows SDK a bit, so it's fine for there to be a few deletions. OTOH
additions usually indicate mismatches, which are sometimes mistakes.
--
Best regards,
LIU Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] headers: Add missing names in winsvc.h
Same mistake as previous. How did you catch those warnings? I copied the modified header to /mingw64/x86_64-w43-mingw32/include folder then compile a simple file with `#include `. But gcc and clang shows nothing. I did something wrong but can't figure it out. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] headers: Add missing names in winsvc.h
在 2021-06-29 18:13, Biswapriyo Nath 写道: From 152155ec38dd68f1a59880dd4f7b410756325eb0 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Tue, 29 Jun 2021 15:41:41 +0530 Subject: [PATCH] headers: Add missing names in winsvc.h Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/winsvc.h | 113 + 1 file changed, 113 insertions(+) This patch looks good itself, but I have discovered some old, incorrect definitions. Should they be removed at the same time? ``` In file included from mingw-w64-headers/include/windows.h:122, from : mingw-w64-headers/include/winsvc.h:482: warning: "SERVICE_STOP_REASON_MINOR_NONE" redefined 482 | #define SERVICE_STOP_REASON_MINOR_NONE 0x0006 | mingw-w64-headers/include/winsvc.h:171: note: this is the location of the previous definition 171 | #define SERVICE_STOP_REASON_MINOR_NONE 0x0017 | mingw-w64-headers/include/winsvc.h:492: warning: "SERVICE_STOP_REASON_MINOR_SOFTWARE_UPDATE_UNINSTALL" redefined 492 | #define SERVICE_STOP_REASON_MINOR_SOFTWARE_UPDATE_UNINSTALL 0x000e | mingw-w64-headers/include/winsvc.h:168: note: this is the location of the previous definition 168 | #define SERVICE_STOP_REASON_MINOR_SOFTWARE_UPDATE_UNINSTALL 0x0014 | ``` -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
