Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces
> Could you please elaborate on that? "copy" may mean different things in this > context. Your previous statement answered it: "You're free to read it all you want, APIs are not copyrightable." ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces
On 02/11/2019 15:46, Biswapriyo Nath wrote: Thank you for the help. I've sent the patch in Wine devel mailing list. Two questions: 1. If I want to improve a file which is in wine-import.sh shell script, should I send patch twice -- one for mingw-w64 and one for wine-devel? Sending to wine-devel is fine. It will be imported to mingw-w64 the next time I do imports. If there is a rush, for some reason, you may ping me or run the script yourself. 2. Why doesn't that wine-import.sh shell script conatin all header file that mingw-w64 or wine has? If both projects already have different versions of the same file, we can't just blindly replace one version with the other. They may not be compatible. There is, however, a number of files that could be imported from Wine that are not present in mingw-w64. Those should be relatively easy to add to the script. The only reason it's not done yet is that no one did that so far. Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces
On 03/11/2019 02:01, Liu Hao wrote: 在 2019/11/3 2:06, Jacek Caban 写道: No, only if you touch files imported from Wine. See wine-import.sh script if you're unsure if it's from Wine. How do we know whether a specific header is imported from Wine or not? By checking Git logs I presume? Yes, git log or just looking at wine-import.sh script. Also LGPL license is a good hint, but it's not precise (eg. some files like dinput.h were imported from Wine without using the import script). Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces
在 2019/11/3 2:06, Jacek Caban 写道: > > No, only if you touch files imported from Wine. See wine-import.sh > script if you're unsure if it's from Wine. > > How do we know whether a specific header is imported from Wine or not? By checking Git logs I presume? -- Best regards, LH_Mouse signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces
Thank you for the help. I've sent the patch in Wine devel mailing list. Two questions: 1. If I want to improve a file which is in wine-import.sh shell script, should I send patch twice -- one for mingw-w64 and one for wine-devel? 2. Why doesn't that wine-import.sh shell script conatin all header file that mingw-w64 or wine has? Also it may be helpful for new contributors if these information is written in some contribution guidelines. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces
On 02/11/2019 10:08, Biswapriyo Nath wrote: Apology for any mistake. I didn't know any upstream-downstream relationship between wine and mingw-w64 repository. Some points: * If there any improvement need for mingw-w64 should I **always** send a patch to wine then mingw-w64? No, only if you touch files imported from Wine. See wine-import.sh script if you're unsure if it's from Wine. * Why don't wine or mingw-w64, one of them make other repsitory as a git module? Will not it be more easy to maintain? Remember our previous wine and mingw-w64 co-operation. Making it a git module wouldn't really improve the workflow. Tightening projects closer could help with that and it was brought up earlier this year, but based on the feedback, it doesn't seem to be what community wants. We currently have a script-based import of a large chunk of Wine headers and widl. It's not perfect, but it's good enough so far. The thing about it is that once you modify a file on mingw-w64 side, those changes will be overwritten by the import script. This time I caught it and manually reverted that part. * I am not familiar with how to send patch in wine. Once I want to contribute to wine, one of my daydream :) but once I read the source code, read the guidelines, chat with others, there are too many restrictions. I really have no idea what are you talking about. Esp. if you change a header or IDL file, it's trivial to locate in the source code. Preparing a patch is identical to mingw-w64. You send it to wine-devel mailing list, just like you sent it to mingw-w64 mailing list. The process is identical except for git URL and mailing list address. I copy all the code from Windows SDK to mingw-w64, does wine allow it? Uh, I hope that you meant looking at Windows SDK while writing your patch. You're free to read it all you want, APIs are not copyrightable. Doing a blind copy&past is Windows SDK license violation and that's not welcomed in either project. * Anyone can copy my patch to wine. No restriction. Sure. Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces
Apology for any mistake. I didn't know any upstream-downstream relationship between wine and mingw-w64 repository. Some points: * If there any improvement need for mingw-w64 should I **always** send a patch to wine then mingw-w64? * Why don't wine or mingw-w64, one of them make other repsitory as a git module? Will not it be more easy to maintain? Remember our previous wine and mingw-w64 co-operation. * I am not familiar with how to send patch in wine. Once I want to contribute to wine, one of my daydream :) but once I read the source code, read the guidelines, chat with others, there are too many restrictions. I copy all the code from Windows SDK to mingw-w64, does wine allow it? * Anyone can copy my patch to wine. No restriction. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces
Hi Biswapriyo, This patch is for a file imported from Wine. We have a script importing things from Wine and such changes would ideally go to Wine and be imported back to mingw-w64. Please consider upstreaming your changes to Wine. This was already committed to mingw-w64, so until they are in Wine and I can't use the import script for that file. I may need to eventually disable importing it, meaning that we will lose future Wine improvements. It would be great if reviewers could pay more attention to such cases. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces
在 2019/10/28 13:13, Biswapriyo Nath 写道: > Update 1. > > > > Thanks. I pushed this one. -- Best regards, LH_Mouse signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces
Update 1.
From bc5513d7b725afe9be405cefacb7c1e63031af01 Mon Sep 17 00:00:00 2001
From: Biswapriyo Nath
Date: Mon, 28 Oct 2019 10:39:23 +0530
Subject: [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces
Signed-off-by: Biswapriyo Nath
---
mingw-w64-headers/include/netfw.idl | 58 +
1 file changed, 58 insertions(+)
diff --git a/mingw-w64-headers/include/netfw.idl b/mingw-w64-headers/include/netfw.idl
index 7c5d3d40..013f2bfb 100644
--- a/mingw-w64-headers/include/netfw.idl
+++ b/mingw-w64-headers/include/netfw.idl
@@ -431,6 +431,59 @@ interface INetFwRule : IDispatch
HRESULT Action( [in] NET_FW_ACTION action );
}
+[
+ local,
+ object,
+ uuid(9C27C8DA-189B-4DDE-89F7-8B39A316782C),
+ dual
+]
+interface INetFwRule2 : INetFwRule
+{
+ [id(19), propget]
+ HRESULT EdgeTraversalOptions( [out, retval] long* lOptions );
+ [id(19), propput]
+ HRESULT EdgeTraversalOptions( [in] long lOptions );
+}
+
+[
+ local,
+ object,
+ uuid(B21563FF-D696-4222-AB46-4E89B73AB34A),
+ dual
+]
+interface INetFwRule3 : INetFwRule2
+{
+ [id(20), propget]
+ HRESULT LocalAppPackageId( [out, retval] BSTR* wszPackageId );
+ [id(20), propput]
+ HRESULT LocalAppPackageId( [in] BSTR wszPackageId );
+
+ [id(21), propget]
+ HRESULT LocalUserOwner( [out, retval] BSTR* wszUserOwner );
+ [id(21), propput]
+ HRESULT LocalUserOwner( [in] BSTR wszUserOwner );
+
+ [id(22), propget]
+ HRESULT LocalUserAuthorizedList( [out, retval] BSTR* wszUserAuthList );
+ [id(22), propput]
+ HRESULT LocalUserAuthorizedList( [in] BSTR wszUserAuthList );
+
+ [id(23), propget]
+ HRESULT RemoteUserAuthorizedList( [out, retval] BSTR* wszUserAuthList );
+ [id(23), propput]
+ HRESULT RemoteUserAuthorizedList( [in] BSTR wszUserAuthList );
+
+ [id(24), propget]
+ HRESULT RemoteMachineAuthorizedList( [out, retval] BSTR* wszUserAuthList );
+ [id(24), propput]
+ HRESULT RemoteMachineAuthorizedList( [in] BSTR wszUserAuthList );
+
+ [id(25), propget]
+ HRESULT SecureFlags( [out, retval] long* lOptions );
+ [id(25), propput]
+ HRESULT SecureFlags( [in] long lOptions );
+}
+
[
local,
object,
@@ -703,10 +756,15 @@ library NetFwPublicTypeLib
interface INetFwServices;
interface INetFwAuthorizedApplication;
interface INetFwAuthorizedApplications;
+interface INetFwServiceRestriction;
+interface INetFwRule;
+interface INetFwRules;
interface INetFwProfile;
interface INetFwPolicy;
interface INetFwPolicy2;
interface INetFwMgr;
+interface INetFwProduct;
+interface INetFwProducts;
[
uuid(0CA545C6-37AD-4A6C-BF92-9F7610067EF5)
--
2.23.0
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Re: [Mingw-w64-public] [PATCH] include/netfw: add INetFwRule2 and INetFwRule3 interfaces
在 2019/10/28 3:25, Biswapriyo Nath 写道:
> ...
>
>
>
> +interface INetFwProduct;
> +interface INetFwProducts;
> +
> +[
> +uuid(2C5BC43E-3369-4C33-AB0C-BE9469677AF4)
> +]
> +coclass NetFwRule
> +{
> +[default] interface INetFwRule;
> +}
Seems this hunk causes a redefinition error:
```
mingw-w64-headers/include/netfw.idl:812: error: NetFwRule: redefinition
error; original definition was at mingw-w64-headers/include/netfw.idl:772
```
--
Best regards,
LH_Mouse
signature.asc
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
