Re: [PATCH 4/4] Support selecting the right lua version
> Am 31.05.2015 um 18:27 schrieb Gilles Chehade : > >> On Sun, May 31, 2015 at 06:28:02PM +0200, Jason A. Donenfeld wrote: >>> On May 31, 2015 6:10 PM, "Gilles Chehade" wrote: >>> >>> What's the final decision on this ? >> >> Roll with what I've put, and if there are any serious objections, someone >> will submit a pull request. I suspect, though, nobody will take objection, >> because I implement the correct and expected behavior: >> >> * A deliberate sysadmin can explicitly choose what's desired via >> --with-lua-type= >> * Most everyone who has Lua installed has the mainline version, in spite of >> whatever other versions they add later. >> * That means, for people who just have mainline installed, autodetection >> will choose mainline. But, for people who have explicitly added another lua >> version, such as luajit, they'll get the behavior they expect: luajit in >> autodetection. Principle of least surprise. >> * But again, for anyone who actually cares: --with-lua-type= > > Yes, I have rolled what you've proposed because it improves the situation > no matter the decision wrt luajit, I was just curious if there was some > debate taking place off-list ;-) Nope, nothing off-list. Yes, the proposed solution using --with-lua-type is fine. I have overseen this on the first sight. Sorry for the noise. Regards, Joerg -- You received this mail because you are subscribed to misc@opensmtpd.org To unsubscribe, send a mail to: misc+unsubscr...@opensmtpd.org
Re: [PATCH 4/4] Support selecting the right lua version
On Sun, May 31, 2015 at 06:28:02PM +0200, Jason A. Donenfeld wrote: > On May 31, 2015 6:10 PM, "Gilles Chehade" wrote: > > > > What's the final decision on this ? > > > > Roll with what I've put, and if there are any serious objections, someone > will submit a pull request. I suspect, though, nobody will take objection, > because I implement the correct and expected behavior: > > * A deliberate sysadmin can explicitly choose what's desired via > --with-lua-type= > * Most everyone who has Lua installed has the mainline version, in spite of > whatever other versions they add later. > * That means, for people who just have mainline installed, autodetection > will choose mainline. But, for people who have explicitly added another lua > version, such as luajit, they'll get the behavior they expect: luajit in > autodetection. Principle of least surprise. > * But again, for anyone who actually cares: --with-lua-type= Yes, I have rolled what you've proposed because it improves the situation no matter the decision wrt luajit, I was just curious if there was some debate taking place off-list ;-) -- Gilles Chehade https://www.poolp.org @poolpOrg -- You received this mail because you are subscribed to misc@opensmtpd.org To unsubscribe, send a mail to: misc+unsubscr...@opensmtpd.org
Re: [PATCH 4/4] Support selecting the right lua version
On May 31, 2015 6:10 PM, "Gilles Chehade" wrote: > > What's the final decision on this ? > Roll with what I've put, and if there are any serious objections, someone will submit a pull request. I suspect, though, nobody will take objection, because I implement the correct and expected behavior: * A deliberate sysadmin can explicitly choose what's desired via --with-lua-type= * Most everyone who has Lua installed has the mainline version, in spite of whatever other versions they add later. * That means, for people who just have mainline installed, autodetection will choose mainline. But, for people who have explicitly added another lua version, such as luajit, they'll get the behavior they expect: luajit in autodetection. Principle of least surprise. * But again, for anyone who actually cares: --with-lua-type=
Re: [PATCH 4/4] Support selecting the right lua version
On Sat, May 30, 2015 at 11:18:15AM +0200, Jason A. Donenfeld wrote: > On May 30, 2015 8:59 AM, "Joerg Jung" wrote: > > > > > Am 29.05.2015 um 15:17 schrieb Jason A. Donenfeld : > > > > > > I took some of your ideas into consideration with this pull request: > > > https://github.com/OpenSMTPD/OpenSMTPD-extras/pull/20 > > > This succeeds this earlier patch. > > > > I still think that luajit should not be the first in the row > > (as long as not specified explicitly with config option). > > From sysadmin point of view, if Lua is requested as > > dependency, one expects to get Lua as default, not > > LuaJit, no matter which has the better performance. > > That's what --with-lua-type=lua is for -- avoiding autodetection for the > sysadmin to choose the best one. > > For autodetection, if luajit is installed on a system, it's probably been > done so deliberately, and so should be used if available. > > > > > Regards, > > Joerg > > What's the final decision on this ? -- Gilles Chehade https://www.poolp.org @poolpOrg -- You received this mail because you are subscribed to misc@opensmtpd.org To unsubscribe, send a mail to: misc+unsubscr...@opensmtpd.org
Re: [PATCH 00/10] Massive build system and include cleanup
Erf so I just realized that this was a huge pull request rather than several small ones, it is painful to process for me I'll do it this time but for future contributions, please split them into individual pull requests so they can be reviewed, merged and tested independantely. On Fri, May 29, 2015 at 10:04:26PM +0200, Gilles Chehade wrote: > Thanks, I'll review and merge tomorrow ! > > On Fri, May 29, 2015 at 03:59:07PM +0200, Jason A. Donenfeld wrote: > > This is https://github.com/OpenSMTPD/OpenSMTPD-extras/pull/20 > > > > This pull request addresses these mailing list posts: > > > > http://thread.gmane.org/gmane.mail.opensmtpd.general/2673 > > http://thread.gmane.org/gmane.mail.opensmtpd.general/2674 > > http://thread.gmane.org/gmane.mail.opensmtpd.general/2675 > > http://thread.gmane.org/gmane.mail.opensmtpd.general/2678 > > http://thread.gmane.org/gmane.mail.opensmtpd.general/2679 > > http://thread.gmane.org/gmane.mail.opensmtpd.general/2681 > > http://thread.gmane.org/gmane.mail.opensmtpd.general/2688 > > > > Gentoo is currently shipping with all patches in this patch set, > > with its opensmtpd-extras-5.4.5.201505291521.ebuild. > > > > Jason A. Donenfeld (10): > > Simplify README since there is only a single branch > > Fix help text of python > > Move perl checking logic to same place as python > > Support selecting the right lua version > > Use compat's base64 implementation > > dkim-signer: use OpenSSL/LibreSSL's sha256 > > compat: add util.h > > table-passwd: include includes.h > > filter-dnsbl: properly check for libasr in libc > > filter-lua: also support 5.1 and luajit > > > > README.md | 52 - > > api/util.c | 2 +- > > configure.ac | 129 > > +++-- > > .../filter-dkim-signer/filter_dkim_signer.c| 26 ++--- > > extras/wip/filters/filter-dnsbl/Makefile.am| 2 +- > > extras/wip/filters/filter-lua/Makefile.am | 5 +- > > extras/wip/filters/filter-lua/filter_lua.c | 17 +++ > > extras/wip/filters/filter-perl/Makefile.am | 5 +- > > extras/wip/tables/table-passwd/table_passwd.c | 1 + > > openbsd-compat/Makefile.am | 2 +- > > openbsd-compat/includes.h | 2 + > > openbsd-compat/openbsd-compat.h| 8 -- > > openbsd-compat/util.h | 36 ++ > > 13 files changed, 219 insertions(+), 68 deletions(-) > > create mode 100644 openbsd-compat/util.h > > > > -- > > 2.4.2 > > > > > > -- > > You received this mail because you are subscribed to misc@opensmtpd.org > > To unsubscribe, send a mail to: misc+unsubscr...@opensmtpd.org > > > > -- > Gilles Chehade > > https://www.poolp.org @poolpOrg > > -- > You received this mail because you are subscribed to misc@opensmtpd.org > To unsubscribe, send a mail to: misc+unsubscr...@opensmtpd.org > -- Gilles Chehade https://www.poolp.org @poolpOrg -- You received this mail because you are subscribed to misc@opensmtpd.org To unsubscribe, send a mail to: misc+unsubscr...@opensmtpd.org
