Re: [Mixxx-devel] beta deadline suggestion
Lets continue to think the another beta idea. What do wee need for it to make it real? I think we need to adopt the sound source branch as 1.12.1 alpha. We need to provide test build for all targets. A desired schedule could be a beta releasecontemporaneous with the 1.12.0 release. There might be a misconception here. Owen wants to do a beta and not a alpha release. If we now do another alpha release it will only delay 1.12 further. @rryan: When do you think you find the time to fix the build server? This is the real blocker for a 1.12 release for about a year now. For some reason everytime we want to cut a beta release the build-server shuts down. Unfortunately there is not much sense in discussing anything about a release-date until we have a working build-server back to ship out beta-builds on all platforms. There is a pending optimization issue. Can you setup a 1.12.1 alpha branch as well? Thank you! I hope we find a significant number of beta tester that is willing to test 1.12.0 beta and short after 1.12.1. @Owen: Do you have access to a Mac build environment? If yes it would be nice if you jump in until RJ finds time to setup the build server. You may verify that the Uwes branch compiles an works for you. I think this is also the best way to get a feeling about the state of quality of the branch. Any other ideas or comments? Kind regards, Daniel Am 17.04.2015 um 18:12 schrieb RJ Ryan: On Fri, Apr 17, 2015 at 12:10 PM, Owen Williams owilli...@mixxx.org mailto:owilli...@mixxx.org wrote: Uwe, I truly appreciate the work that you have done on the sound source API. It's an important change and it does fix some long-standing issues. The choice has never been between merging the code or throwing it away. Based on the risks and benefits and our experience with long debugging periods after major feature merges, the prudent choice is to keep the current soundsource API for the 1.12 release. Once it's out the door, then we can immediately look at merging the new API. And as far as I'm concerned, as soon as it's stable, we can do another beta right away. I know it's frustrating to have a feature not make it into a release, but it's a self-perpetuating problem. Because releases are rare, we all want everything we do in the next release. Merging everything in slows down the release cycle, and the cycle repeats. If we released more often, it'd be easier to allow a feature to miss a release, and releases would speed up. Therefore, to stop the current cycle of non-releases, we have to agree to hold off on merging this code until after 1.12. I honestly believe that not merging this code now will make it possible to release this code *sooner*! +1 Owen On Fri, 2015-04-17 at 10:55 +0200, Uwe Klotz wrote: Just some words from my side. I really don't want to give any recommendations to you, because I'm biased ;) The NewSoundSourceAPI branch has gone through many iterations and Daniel spent a LOT of time reviewing my code very thoroughly. He also provided the key ideas to fix the MP3 decoding issues! During the last months the code base has become pretty stable and we have not discovered any severe defects lately. It is secured by new tests for many codecs and moreover the critical parts of the code are guarded by lots of debug assertions that should indicate potential issues or wrong assumptions early during development in debug builds. Of course, I would feel much safer if the new code had been tested by experienced developers first before rushing it out to the public. On the other hand, I personally never switched back to master without any regrets after what I have found there! Main features: * API: Floating-point sample processing * API: Explicit notion of #channels instead of implicitly assuming always stereo * Update, optimization or even re-implementation (MP3, FLAC, AAC/M4A, ...) of audio decoding * Many metadata improvements (parsing, character encoding) Open issues: * Windows build with SoundSourceMediaFoundation * OS X build with SoundSourceCoreAudio Uwe On 04/17/2015 09:25 AM, Daniel Schürmann wrote: Hi Owen, We have collected some test results, they are proving that the new sound source branch is more reliable then the master solution. We have no hints for the opposite. So IMHO is worth to consider the 1.12 merge again. Yes, master the sound source api has not changed since 1.11, but Mixxx 1.12
Re: [Mixxx-devel] Sound Source API test.
Should be fixed now. 3 source files were missing in the build script. Uwe On 04/18/2015 07:39 PM, Ryan Kramer wrote: Thanks. It compiles, but now I get some link errors. It looks like some .obj files are not being fed to the linker. For example, soundsourceplugin.obj seems to be missing. link /nologo /MACHINE:X86 /DEBUG /LTCG:NOSTATUS /OPT:REF /OPT:ICF /MANIFEST /nod efaultlib:LIBCMT.lib /nodefaultlib:LIBCMTd.lib /manifest /dll /out:win32_build\p lugins\win32_build\mediafoundation\soundsourcemediafoundation.dll /implib:win32_ build\plugins\win32_build\mediafoundation\soundsourcemediafoundation.lib /LIBPAT H:C:\code\github\mixxx\buildserver /LIBPATH:C:\code\github\mixxx\buildserver\lib /LIBPATH:C:\code\github\mixxx\buildserver\build\qt-everywhere-opensource-src-4. 8.6\lib shell32.lib portaudio.lib porttime.lib portmidi.lib qtmaind.lib QtCored4 .lib QtGuid4.lib QtOpenGLd4.lib QtXmld4.lib QtSvgd4.lib QtSqld4.lib QtScriptd4.l ib QtXmlPatternsd4.lib QtNetworkd4.lib QtTestd4.lib QtScriptToolsd4.lib opengl32 .lib libsndfile.lib libFLAC.lib libvorbisfile.lib libvorbis.lib libogg.lib openg l32.lib glu32.lib tag.lib libprotobuf-lite.lib chromaprint.lib rubberband.lib li bmad.lib libid3tag.lib Ole32.lib Mfuuid.lib Mfplat.lib Mfreadwrite.lib libhss139 4.lib setupapi.lib libshout.lib win32_build\plugins\win32_build\mediafoundation\ metadata\trackmetadata.obj win32_build\plugins\win32_build\mediafoundation\metad ata\trackmetadatataglib.obj win32_build\plugins\win32_build\mediafoundation\soun dsourcemediafoundation.obj win32_build\plugins\win32_build\mediafoundation\sourc es\audiosource.obj win32_build\plugins\win32_build\mediafoundation\sources\sound source.obj Creating library win32_build\plugins\win32_build\mediafoundation\soundsourcem ediafoundation.lib and object win32_build\plugins\win32_build\mediafoundation\so undsourcemediafoundation.exp soundsourcemediafoundation.obj : error LNK2001: unresolved external symbol publ ic: static void __cdecl Mixxx::SoundSourcePlugin::freeFileExtensions(char * *) (?freeFileExtensions@SoundSourcePlugin@Mixxx@@SAXPAPAD@Z) soundsourcemediafoundation.obj : error LNK2001: unresolved external symbol publ ic: static char * * __cdecl Mixxx::SoundSourcePlugin::allocFileExtensions(class QListclass QString const ) (?allocFileExtensions@SoundSourcePlugin@Mixxx@@SA PAPADABV?$QList@VQString@Z) audiosource.obj : error LNK2001: unresolved external symbol public: virtual __t hiscall SampleBuffer::~SampleBuffer(void) (??1SampleBuffer@@UAE@XZ) audiosource.obj : error LNK2001: unresolved external symbol public: __thiscall SampleBuffer::SampleBuffer(int) (??0SampleBuffer@@QAE@H@Z) audiosource.obj : error LNK2001: unresolved external symbol public: static void __cdecl SampleUtil::copyMultiToStereo(float *,float const *,int,int) (?copyMul tiToStereo@SampleUtil@@SAXPAMPBMHH@Z) audiosource.obj : error LNK2001: unresolved external symbol public: static void __cdecl SampleUtil::doubleMonoToDualMono(float *,int) (?doubleMonoToDualMono@S ampleUtil@@SAXPAMH@Z) win32_build\plugins\win32_build\mediafoundation\soundsourcemediafoundation.dll : fatal error LNK1120: 6 unresolved externals On Fri, Apr 17, 2015 at 1:25 AM, Uwe Klotz uwe_kl...@web.de mailto:uwe_kl...@web.de wrote: Thanks, Ryan. I've pushed a commit (together with some cosmetic changes) that should fix the compile errors. Uwe On 04/17/2015 06:18 AM, Ryan Kramer wrote: Good news everyone - I'm actually on the right friggin' branch now! Bad new is that, no, SoundSourceMediaFoundation.cpp does not currently compile on Windows. So the couple of bugs I've reported are actually against the master branch. It will be interesting to see if the new branch fixes them. Here are the compile errors. I will try to fix them this weekend if no one beats me to it. plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(251) : error C 2664: 'void SoundSourceMediaFoundation::copyFrames(CSAMPLE *,size_t *,const CSAM PLE *,size_t)' : cannot convert argument 2 from 'SINT *' to 'size_t *' Types pointed to are unrelated; conversion requires reinterpret_cast, C- style cast or function-style cast plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(393) : error C 2664: 'void SoundSourceMediaFoundation::copyFrames(CSAMPLE *,size_t *,const CSAM PLE *,size_t)' : cannot convert argument 2 from 'SINT *' to 'size_t *' Types pointed to are unrelated; conversion requires reinterpret_cast, C- style cast or function-style cast plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(580) : error C 2065: 'kNumChannels' : undeclared identifier plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(584) : error C 2065: 'kNumChannels' : undeclared identifier
Re: [Mixxx-devel] beta deadline suggestion
There might be a misconception here. Owen wants to do a beta and not a alpha release. If we now do another alpha release it will only delay 1.12 further. We already have two branches, master and the sound source API branch. When I go this right, the idea was to lift the API branch to beta once the master is release. However, I like the idea, because there is no extra delay for the 1.12.0. We will finally just have a 1.12.1 release including the API changes short after the 1.12.0 release. To make it real, we need to cut out the 1.12.0 beta branch merge the API changes to the new master and release it as 1.12.1 alpha. This allows us to ask for comprehensive test on the new API on all platforms. Am 19.04.2015 um 14:49 schrieb Max Linke: Lets continue to think the another beta idea. What do wee need for it to make it real? I think we need to adopt the sound source branch as 1.12.1 alpha. We need to provide test build for all targets. A desired schedule could be a beta releasecontemporaneous with the 1.12.0 release. There might be a misconception here. Owen wants to do a beta and not a alpha release. If we now do another alpha release it will only delay 1.12 further. @rryan: When do you think you find the time to fix the build server? This is the real blocker for a 1.12 release for about a year now. For some reason everytime we want to cut a beta release the build-server shuts down. Unfortunately there is not much sense in discussing anything about a release-date until we have a working build-server back to ship out beta-builds on all platforms. There is a pending optimization issue. Can you setup a 1.12.1 alpha branch as well? Thank you! I hope we find a significant number of beta tester that is willing to test 1.12.0 beta and short after 1.12.1. @Owen: Do you have access to a Mac build environment? If yes it would be nice if you jump in until RJ finds time to setup the build server. You may verify that the Uwes branch compiles an works for you. I think this is also the best way to get a feeling about the state of quality of the branch. Any other ideas or comments? Kind regards, Daniel Am 17.04.2015 um 18:12 schrieb RJ Ryan: On Fri, Apr 17, 2015 at 12:10 PM, Owen Williams owilli...@mixxx.org mailto:owilli...@mixxx.org wrote: Uwe, I truly appreciate the work that you have done on the sound source API. It's an important change and it does fix some long-standing issues. The choice has never been between merging the code or throwing it away. Based on the risks and benefits and our experience with long debugging periods after major feature merges, the prudent choice is to keep the current soundsource API for the 1.12 release. Once it's out the door, then we can immediately look at merging the new API. And as far as I'm concerned, as soon as it's stable, we can do another beta right away. I know it's frustrating to have a feature not make it into a release, but it's a self-perpetuating problem. Because releases are rare, we all want everything we do in the next release. Merging everything in slows down the release cycle, and the cycle repeats. If we released more often, it'd be easier to allow a feature to miss a release, and releases would speed up. Therefore, to stop the current cycle of non-releases, we have to agree to hold off on merging this code until after 1.12. I honestly believe that not merging this code now will make it possible to release this code *sooner*! +1 Owen On Fri, 2015-04-17 at 10:55 +0200, Uwe Klotz wrote: Just some words from my side. I really don't want to give any recommendations to you, because I'm biased ;) The NewSoundSourceAPI branch has gone through many iterations and Daniel spent a LOT of time reviewing my code very thoroughly. He also provided the key ideas to fix the MP3 decoding issues! During the last months the code base has become pretty stable and we have not discovered any severe defects lately. It is secured by new tests for many codecs and moreover the critical parts of the code are guarded by lots of debug assertions that should indicate potential issues or wrong assumptions early during development in debug builds. Of course, I would feel much safer if the new code had been tested by experienced developers first before rushing it out to the public. On the other hand, I personally never switched back to master without any regrets after what I have found there! Main features: * API: Floating-point sample processing * API: Explicit notion of #channels instead of implicitly assuming always stereo * Update, optimization or even
Re: [Mixxx-devel] beta deadline suggestion
On Sun, Apr 19, 2015 at 8:49 AM, Max Linke max_li...@gmx.de wrote: @rryan: When do you think you find the time to fix the build server? This is the real blocker for a 1.12 release for about a year now. For some reason everytime we want to cut a beta release the build-server shuts down. Unfortunately there is not much sense in discussing anything about a release-date until we have a working build-server back to ship out beta-builds on all platforms. I'm working on this... release environment for x86/x64 is building right now (all alpha builds are built with a debug environment, not release). Hopefully it'll be done in the morning (Qt takes forever). The main blocker for the Windows environment is the portaudio segfaults we've seen in alpha testing. -- BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15utm_medium=emailutm_campaign=VA_SF___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
