[Mixxx-devel] 1.11.0 source code release

2013-05-12 Thread Steven Boswell II
So is the source code release in http://downloads.mixxx.org/mixxx-1.11.0/ 
stable now?

The issue is that I'd like to get an updated mixxx package onto rpmfusion.org, 
and want to know if I can refer to that source release in the .spec file, e.g. 
"Source0: 
http://downloads.mixxx.org/mixxx-%{version}/%{name}-%{version}-src.tar.gz";.

I'll of course apply any updates in the current version of the release branch, 
and call the package "mixxx-1.11.0-20130512bzr" (for whatever date I finally do 
this).

Steven Boswell
--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

[Mixxx-devel] Pending changes, blueprints

2013-05-12 Thread Steven Boswell II
Now that the release is out the door and we all have some breathing room, can I 
get some opinions on my pending changes and blueprints?

https://bugs.launchpad.net/mixxx/+bug/1051106 is a simple implementation of an 
incremental/pausable library-scan, to allow the locked-database problem during 
library-rescan to be worked around until such time (if any) that this problem 
is handled on an architectural level. Daniel Schürmann added a comment that 
seemed to imply that it had multithreading issues, but as far as I can tell, my 
change doesn't have any multithreaded database-access implications that the 
original code didn't have.  Can someone please tell me if there's any reason 
this change shouldn't be committed?

Also, https://bugs.launchpad.net/mixxx/+bug/1179098 contains a bug fix for a 
data-loss problem I found with the set-log's "Join with previous" menu-item.  
Any thoughts?

Finally, please look at 
https://blueprints.launchpad.net/mixxx/+spec/auto-dj-crates -- I just made it 
more sophisticated, by allowing the tracks to be prioritized (in addition to # 
of times played) by the last time it was played!  Until my bug fix for "Join 
with previous", I didn't realize that this info was stored in 
PlaylistTracks.pl_datetime_added for set-log playlists.
Also, I believe I handled RJ Ryan's objection to this feature, namely that the 
original concept made Mixxx too much like a media player.  Now, there's an "Add 
random" button, which allows the DJ to accept, remove, or move around any 
randomly-added track, which should take care of the objection.

I appreciate any time you're willing to put into this.  There are a lot of 
other improvements to Mixxx that I'd like to do, but only if there's a chance 
they'll make it into the master branch.

Steven Boswell
--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] Mixxx and FFMPEG/Libav status update

2013-05-12 Thread Steven Boswell II
Since I've done a little ffmpeg programming in the past, I thought I'd take a 
look at this.

Hopefully I'm doing my comparison right; inside of a checkout of Mixxx's trunk, 
I did "bzr update -r 3365", since that seems to be the last version that was 
merged into the ffmpeg branch.


Assuming my comparison is right, my first question is...is there any particular 
reason that there are so many unrelated changes?  It appears that support for 
preview decks has been totally munged (src/engine/enginechannel.[cpp,h], 
src/library/baseexternalplaylistmodel.cpp, 
src/library/baseexternaltrackmodel.cpp, src/library/cratetablemodel.cpp, and 
many many others), that some files have been copied 
(src/library/previewbuttondelegate.[cpp,h].moved and 
src/previewdeck.cpp.moved), ConfigObject::exists() has been removed, 
src/mathstuff.h now has Apple-only definitions for functions that exist in Qt 
(i.e. qIsNaN() and qIsInf()), etc.

Some clarifications on this would be appreciated.
Now I'll dig into the actual FFMPEG changes :-)

Steven Boswell




 From: Tuukka Pasanen 
To: mixxx-devel@lists.sourceforge.net 
Sent: Wednesday, May 8, 2013 11:52 AM
Subject: [Mixxx-devel] Mixxx and FFMPEG/Libav status update
 

[...]
FFMPEG/Libav support is now in state it can be used drop-in placement in 
playing and recording.
[...]
--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

[Mixxx-devel] Hello and some bad news

2013-05-12 Thread Stefan Hinkel
Hello at all,

I'm following this developers newsletter for some time and was very
excited seeing 1.11 growing up. As I read that it is released I was so
excited to see the result and installed it immediately on my laptop.
Unfortunately there is a huge bug and I first want to ask if anyone had
this bug too until now. I describe the situation and the things I've done:

I had 1.10 already on my computer and installed 1.11 (without
uninstalling 1.10). I started Mixxx and tested it with some music from
my internal hard drive. I loaded a file into the left deck and started
it. All good, the file played and I heard the music. After that I wanted
so search another song and load it into the right deck. While browsing
in the file browser (to be correct: while changing the folder) the left
deck didn't play anymore. So, the waveform kept moving, but there was no
sound at all. The right deck played without any problems. OK, maybe a
problem with the file itself, so I tried loading another one into the
left deck. But trying this I only get the message that the song is
loading and nothing happens. This state continues until I restart Mixxx.
The problem still exists after restarting. I thought maybe it's a
problem the arises because of installing 1.11 over an existing 1.10. So
I uninstalled all Mixxx stuff I had on my computer, deleted the user
config files from the windows user folder and reinstalled Mixxx. But,
the problem still exists.
So I wanted to ask if I did something wrong?! Is there anything that I
can try which I didn't tried until now? Does anyone of you had or have
this problem too?

Best regards,
Stefan Hinkel
<>

signature.asc
Description: OpenPGP digital signature
--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] Hello and some bad news

2013-05-12 Thread RJ Ryan
HI Stefan,

Does this happen every time or just intermittently?  Can you file a bug
please?
http://bugs.launchpad.net/mixxx/+filebug

Thanks,
RJ


On Sun, May 12, 2013 at 5:16 PM, Stefan Hinkel wrote:

> Hello at all,
>
> I'm following this developers newsletter for some time and was very
> excited seeing 1.11 growing up. As I read that it is released I was so
> excited to see the result and installed it immediately on my laptop.
> Unfortunately there is a huge bug and I first want to ask if anyone had
> this bug too until now. I describe the situation and the things I've done:
>
> I had 1.10 already on my computer and installed 1.11 (without
> uninstalling 1.10). I started Mixxx and tested it with some music from
> my internal hard drive. I loaded a file into the left deck and started
> it. All good, the file played and I heard the music. After that I wanted
> so search another song and load it into the right deck. While browsing
> in the file browser (to be correct: while changing the folder) the left
> deck didn't play anymore. So, the waveform kept moving, but there was no
> sound at all. The right deck played without any problems. OK, maybe a
> problem with the file itself, so I tried loading another one into the
> left deck. But trying this I only get the message that the song is
> loading and nothing happens. This state continues until I restart Mixxx.
> The problem still exists after restarting. I thought maybe it's a
> problem the arises because of installing 1.11 over an existing 1.10. So
> I uninstalled all Mixxx stuff I had on my computer, deleted the user
> config files from the windows user folder and reinstalled Mixxx. But,
> the problem still exists.
> So I wanted to ask if I did something wrong?! Is there anything that I
> can try which I didn't tried until now? Does anyone of you had or have
> this problem too?
>
> Best regards,
> Stefan Hinkel
>
>
> --
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] RPMFusion Bug 2413 - mixxx doesn't understand arm arches

2013-05-12 Thread RJ Ryan
Hmm, yea this is just a problem with the list of valid arch's in
build/mixxx.py. Mixxx runs fine on ARM. We should probably just get rid of
that check, all it does it prevent distros from building us on different
architectures. What it really intends to do is tell you when you mis-typed
an arch by hand or typed a variant of amd64 we don't understand (like
"EM64T" before we added that).


On Fri, May 10, 2013 at 9:12 PM, Steven Boswell II wrote:

> Has anyone seen this?
>
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=2413
>
> I don't own any computers with an ARM arch, so I can't help with this, but
> for anyone that knows ARM arches, this sounds like an easy fix...
>
> Steven Boswell
>
>
>
> --
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] Mixxx and FFMPEG/Libav status update

2013-05-12 Thread Steven Boswell II
Tuukka:

So far, all I've noticed wrong is the Unicode handling for metadata (artist, 
title, etc.)
The enclosed patch fixes that.

I also noticed that you're apparently having problems with Unicode paths under 
MS Windows.  After digging around for a while, it appears that this is a known 
bug, though ff_win32_open() in libavformat/os_support.c (at least in my version 
of ffmpeg, i.e. 1.0.5) seems to be doing the right thing for UTF-8.  So it's 
still a mystery.  But maybe this will help you track down the problem.

Steven Boswell--- mixxx-cleaned/src/soundsourceffmpeg.cpp	2013-05-12 11:34:19.268383000 -0700
+++ mixxx/src/soundsourceffmpeg.cpp	2013-05-12 14:59:54.378017031 -0700
@@ -29,6 +29,7 @@
 //#endif
 
 #include 
+#include 
 
 static QMutex ffmpegmutex;
 static bool ffmpeginit = false;
@@ -161,6 +162,8 @@
  * The method toLocal8Bit() returns the local 8-bit representation of the string as a QByteArray.
  * The returned byte array is undefined if the string contains characters not supported
  * by the local 8-bit encoding.
+	 *
+	 * See https://ffmpeg.org/trac/ffmpeg/ticket/819 for relevant bug report.
  */
 QByteArray qBAFilename = m_qFilename.toLocal8Bit();
 #else
@@ -691,6 +694,8 @@
  * The method toLocal8Bit() returns the local 8-bit representation of the string as a QByteArray.
  * The returned byte array is undefined if the string contains characters not supported
  * by the local 8-bit encoding.
+	 *
+	 * See https://ffmpeg.org/trac/ffmpeg/ticket/819 for relevant bug report.
  */
 QByteArray qBAFilename = m_qFilename.toLocal8Bit();
 #else
@@ -729,23 +734,32 @@
 
 //qDebug() << "ffmpeg: Parse HEADER [MP3,WMA]";
 
+	// Prepare to decode UTF-8.
+	QTextCodec* pUtf8Decoder = QTextCodec::codecForName("UTF-8");
+
 while ((FmtTag = av_dict_get(FmtCtx->metadata, "", FmtTag, AV_DICT_IGNORE_SUFFIX))) {
+		// Convert the value.
+		QString strValue;
+		if (pUtf8Decoder != NULL)
+			strValue = pUtf8Decoder->toUnicode (FmtTag->value);
+		else
+			strValue = FmtTag->value;
 
 if( !strncmp( FmtTag->key, "artist", 7) ) {
-//qDebug() << "ffmpeg: HEADER [MP3,WMA] artist: " << FmtTag->key << " = "<< FmtTag->value;
-this->setArtist(FmtTag->value);
+//qDebug() << "ffmpeg: HEADER [MP3,WMA] artist: " << FmtTag->key << " = "<< strValue;
+this->setArtist(strValue);
 } else if( !strncmp( FmtTag->key, "album", 5) ) {
-//qDebug() << "ffmpeg: HEADER [MP3,WMA] album: " << FmtTag->key << " = "<< FmtTag->value;
-this->setAlbum(FmtTag->value);
+//qDebug() << "ffmpeg: HEADER [MP3,WMA] album: " << FmtTag->key << " = "<< strValue;
+this->setAlbum(strValue);
 } else if( !strncmp( FmtTag->key, "date", 4) ) {
-//qDebug() << "ffmpeg: HEADER [MP3,WMA] date: " << FmtTag->key << " = "<< FmtTag->value;
-this->setYear(FmtTag->value);
+//qDebug() << "ffmpeg: HEADER [MP3,WMA] date: " << FmtTag->key << " = "<< strValue;
+this->setYear(strValue);
 } else if( !strncmp( FmtTag->key, "genre", 5) ) {
-//qDebug() << "ffmpeg: HEADER [MP3,WMA] genre: " << FmtTag->key << " = "<< FmtTag->value;
-this->setGenre(FmtTag->value);
+//qDebug() << "ffmpeg: HEADER [MP3,WMA] genre: " << FmtTag->key << " = "<< strValue;
+this->setGenre(strValue);
 } else if( !strncmp( FmtTag->key, "title", 5) ) {
-//qDebug() << "ffmpeg: HEADER [MP3,WMA] genre: " << FmtTag->key << " = "<< FmtTag->value;
-this->setTitle(FmtTag->value);
+//qDebug() << "ffmpeg: HEADER [MP3,WMA] genre: " << FmtTag->key << " = "<< strValue;
+this->setTitle(strValue);
 }
 
 
@@ -754,30 +768,37 @@
 //qDebug() << "ffmpeg: Parse HEADER [OGG, FLAC]";
 
 while ((FmtTag = av_dict_get(FmtCtx->streams[m_iAudioStream]->metadata, "", FmtTag, AV_DICT_IGNORE_SUFFIX))) {
+		// Convert the value.
+		QString strValue;
+		if (pUtf8Decoder != NULL)
+			strValue = pUtf8Decoder->toUnicode (FmtTag->value);
+		else
+			strValue = FmtTag->value;
+
 if( !strncmp( FmtTag->key, "ARTIST", 7) ) {
-//qDebug() << "ffmpeg: HEADER [OGG] artist: " << FmtTag->key << " = "<< FmtTag->value;
-this->setArtist(FmtTag->value);
+//qDebug() << "ffmpeg: HEADER [OGG] artist: " << FmtTag->key << " = "<< strValue;
+this->setArtist(strValue);
 } else if( !strncmp( FmtTag->key, "ALBUM", 5) ) {
-//qDebug() << "ffmpeg: HEADER [OGG] album: " << FmtTag->key << " = "<< FmtTag->value;
-this->setAlbum(FmtTag->value);
+//qDebug() << "ffmpeg: HEADER [OGG] album: " << FmtTag->key << " = "<< strValue;
+this->setAlbum(strValue);
 } else if( !strncmp( FmtTag->key, "YEAR", 4) ) {
-//qDebug() << "ffmpeg: HEADER [OGG] year: " << FmtTag->key << " = "<< FmtTag->value;
-this->setYear(FmtT

Re: [Mixxx-devel] Mixxx and FFMPEG/Libav status update

2013-05-12 Thread Steven Boswell II
Wait...it's easier than that...instead of having to fetch a QTextCodec, I can 
just call QString::fromUtf8().
New patch. :-)

Steven Boswell




 From: Steven Boswell II 
To: "mixxx-devel@lists.sourceforge.net"  
Sent: Sunday, May 12, 2013 3:35 PM
Subject: Re: [Mixxx-devel] Mixxx and FFMPEG/Libav status update
 


Tuukka:

So far, all I've noticed wrong is the Unicode handling for metadata (artist, 
title, etc.)
The enclosed patch fixes that.

I also noticed that you're apparently having problems with Unicode paths under 
MS Windows.  After digging around for a while, it appears that this is a known 
bug, though ff_win32_open() in libavformat/os_support.c (at least in my version 
of ffmpeg, i.e. 1.0.5) seems to be doing the right thing for UTF-8.  So it's 
still a mystery.  But maybe this will help you track down the problem.

Steven Boswell


--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-develdiff -ur mixxx-cleaned/src/soundsourceffmpeg.cpp mixxx/src/soundsourceffmpeg.cpp
--- mixxx-cleaned/src/soundsourceffmpeg.cpp	2013-05-12 11:34:19.268383000 -0700
+++ mixxx/src/soundsourceffmpeg.cpp	2013-05-12 15:45:37.682676947 -0700
@@ -29,6 +29,7 @@
 //#endif
 
 #include 
+#include 
 
 static QMutex ffmpegmutex;
 static bool ffmpeginit = false;
@@ -161,6 +162,8 @@
  * The method toLocal8Bit() returns the local 8-bit representation of the string as a QByteArray.
  * The returned byte array is undefined if the string contains characters not supported
  * by the local 8-bit encoding.
+ *
+ * See https://ffmpeg.org/trac/ffmpeg/ticket/819 for relevant bug report.
  */
 QByteArray qBAFilename = m_qFilename.toLocal8Bit();
 #else
@@ -408,10 +411,10 @@
 #else
 uint8_t **l_pIn = (uint8_t **)inframe->extended_data;
 #endif
-	
+
 
 #else
-	int64_t l_lInReadBytes = av_samples_get_buffer_size(NULL, m_pCodecCtx->channels,
+int64_t l_lInReadBytes = av_samples_get_buffer_size(NULL, m_pCodecCtx->channels,
  inframe->nb_samples,
  m_pCodecCtx->sample_fmt, 1);
 #endif
@@ -422,7 +425,7 @@
 
 int l_iOutSamplesLines = 0;
 
-	// Alloc too much.. if not enough we are in trouble!
+// Alloc too much.. if not enough we are in trouble!
 av_samples_alloc(&m_pOut, &l_iOutSamplesLines, 2, l_iOutSamples, AV_SAMPLE_FMT_S16, 0);
 #else
 int l_iOutSamples = av_rescale_rnd(inframe->nb_samples, m_pCodecCtx->sample_rate, m_pCodecCtx->sample_rate, AV_ROUND_UP);
@@ -691,6 +694,8 @@
  * The method toLocal8Bit() returns the local 8-bit representation of the string as a QByteArray.
  * The returned byte array is undefined if the string contains characters not supported
  * by the local 8-bit encoding.
+ *
+ * See https://ffmpeg.org/trac/ffmpeg/ticket/819 for relevant bug report.
  */
 QByteArray qBAFilename = m_qFilename.toLocal8Bit();
 #else
@@ -730,22 +735,24 @@
 //qDebug() << "ffmpeg: Parse HEADER [MP3,WMA]";
 
 while ((FmtTag = av_dict_get(FmtCtx->metadata, "", FmtTag, AV_DICT_IGNORE_SUFFIX))) {
+// Convert the value from UTF-8.
+QString strValue (QString::fromUtf8 (FmtTag->value));
 
 if( !strncmp( FmtTag->key, "artist", 7) ) {
-//qDebug() << "ffmpeg: HEADER [MP3,WMA] artist: " << FmtTag->key << " = "<< FmtTag->value;
-this->setArtist(FmtTag->value);
+//qDebug() << "ffmpeg: HEADER [MP3,WMA] artist: " << FmtTag->key << " = "<< strValue;
+this->setArtist(strValue);
 } else if( !strncmp( FmtTag->key, "album", 5) ) {
-//qDebug() << "ffmpeg: HEADER [MP3,WMA] album: " << FmtTag->key << " = "<< FmtTag->value;
-this->setAlbum(FmtTag->value);
+//qDebug() << "ffmpeg: HEADER [MP3,WMA] album: " << FmtTag->key << " = "<< strValue;
+this->setAlbum(strValue);
 } else if( !strncmp( FmtTag->key, "date", 4) ) {
-//qDebug() << "ffmpeg: HEADER [MP3,WMA] date: " << FmtTag->key << " = "<< FmtTag->value;
-this->setYear(FmtTag->value);
+//qDebug() << "ffmpeg: HEADER [MP3,WMA] date: " << FmtTag->key << " = "<< strValue;
+this->setYear(strValue);
 } else if( !strncmp( FmtTag->key, "genre", 5) ) {
-//qDebug() << "ffmpeg: HEADER [MP3,WMA] genre: " << FmtTag->key << " = "<< FmtTag->value;
-this-

Re: [Mixxx-devel] Nature of Version 1.11.1

2013-05-12 Thread RJ Ryan
I agree only bug fixes should go in the 1.11.1 branch. String/GUI changes
make sense to delay.

We haven't looked too closely at 1.11.1, it's just a handy place to punt a
bug to when you know it isn't suitable for 1.11.0. Also we didn't have a
1.12.0 milestone created until recently so some bugs may have been booted
to 1.11.1 so we don't lose track of them when they ought to have been
marked 1.12.0.

I wonder if we should switch to organizing bugs by series and make a rule
that nobody should mark a bug for a milestone until there is a patch in
hand or it is assigned to someone. Otherwise, just leave it in the series.
I think Launchpad doesn't have as good support for browsing bugs by series
but this would help with the issue we keep having of every milestone
carrying along a few dozen bugs that are unassigned and with every release
we just move them one milestone into the future.

Thoughts?

Also, +1 to maintaining a preview build throughout the development process.
We got a lot of bugs discovered by bleeding edge testers that way.

RJ



On Sat, May 11, 2013 at 5:34 PM, Owen Williams  wrote:

> I agree.  Glancing through the list, I think almost everything marked
> "low" or "wishlist" could be bulk-moved to 1.12.  (Something like
> 1138316 Vinyl Indicator might be important enough to fix).
>
> Other issues, like "stutter at start of vbr," have been with us for a
> while and will probably require a lot of code changes to fix.  That
> should punt.
>
> I think it's more a matter of going through and doing the triage than
> making a mistake of trying to "do too much" for 1.11.1.
>
> Owen
>
> On Sat, 2013-05-11 at 23:23 +0200, Daniel Schürmann wrote:
> > Hallo,
> >
> > Fist of all, THANK YOU for your work on great 1.11.0 :-)
> >
> > --
> >
> > I wander, what will be the nature of 1.11.1?
> >
> > Currently we have 75 bugs from different kind scheduled:
> > https://launchpad.net/mixxx/+milestone/1.11.1
> >
> > For me, a possible nature of 1.11.1 is a kind of hot-fix release.
> > We may focus on 1.12.0. In the 1.11 branch we may fix only critical and
> > the most annoying issues, depending on user feedback.
> > We should avoid GUI, API and use case changes, so that we don't need to
> > update screen shots, manuals, skins and scripts.
> >
> > For my feeling our pre release strategy from 1.110 was successful. We
> > had always stable versions for bleeding edge users. So I would like to
> > continue like that, providing always a preview version, without the
> > production overhead.
> >
> > With this strategy, we have to postpone many 1.11.1 bugs to 1.12.0.
> >
> > This is only one of many possible release strategies.
> > What do You think?
> >
> > Kind regards,
> >
> > Daniel
> >
> >
> >
> >
> --
> > Learn Graph Databases - Download FREE O'Reilly Book
> > "Graph Databases" is the definitive new guide to graph databases and
> > their applications. This 200-page book is written by three acclaimed
> > leaders in the field. The early access version is available now.
> > Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> > ___
> > Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> > http://mixxx.org
> >
> >
> > Mixxx-devel mailing list
> > Mixxx-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/mixxx-devel
> >
>
>
>
>
> --
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

[Mixxx-devel] MS WIndows build problem, forum problem

2013-05-12 Thread Steven Boswell II
The build problem I just ran into was reported on the forums; see 
http://www.mixxx.org/forums/viewtopic.php?f=3&t=4382 .
Unfortunately, no one ever answered him.
The "problem" is that the source code being built from wasn't part of a Bazaar 
checkout, and src/SConscript doesn't handle that gracefully.
The enclosed patch takes care of the problem.

I tried to register for the forums, so that I could tell the user what to do, 
but it keeps telling me "You have provided an invalid answer to the question."  
So the first and last letter in "equalizer" isn't "er"?

Steven Boswell
--- mixxx-orig/src/SConscript	2013-05-10 16:13:51.0 -0700
+++ mixxx/src/SConscript	2013-05-12 21:17:21.883028714 -0700
@@ -38,11 +38,15 @@
 str_list.append('#define VER_FILEVERSION ')
 # Remove anything after ~ or - in the version number and replace the dots with commas
 str_list.append(mixxx_version.partition('~')[0].partition('-')[0].replace('.',','))
-str_list.append(','+str(bazaar_revision)+'\n')
+if bazaar_revision:
+str_list.append(','+str(bazaar_revision))
+str_list.append('\n')
 
 str_list.append('#define VER_PRODUCTVERSION  ')
 str_list.append(mixxx_version.partition('~')[0].partition('-')[0].replace('.',','))
-str_list.append(','+str(bazaar_revision)+'\n')
+if bazaar_revision:
+str_list.append(','+str(bazaar_revision))
+str_list.append('\n')
 
 import datetime
 now = datetime.datetime.now()
--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] Mixxx and FFMPEG/Libav status update

2013-05-12 Thread Tuukka Pasanen
Hello,
Thank you for trying this out! I'm in somekind of bzr merge limbo/hell. I
didn't get right what to merge first (I merged lp:mixxx/1.11) after that
someone remind me that correct merge should be lp:mixxx. After that I
merged from lp:mixxx but I didn't do as smooth I liked it to go..
I suck at bzr so I just made what I could to make this build again that
meaned to copy stuff from lp:mixxx and hope that nothing broke down.. it
seems that patch is again in horrible condition..

Really changed files are:
* build/features.py
* src/soundsourceffmpeg.cpp
* src/soundsourceffmpeg.h
* src/recording/
encoderffmpegcore.cpp
* src/recording/encoderffmpegcore.h
* src/recording/encoderffmpegmp3.cpp
* src/recording/encoderffmpegmp3.h
* src/recording/encoderffmpegvorbis.cpp
* src/recording/encoderffmpegvorbis.h
* src/recording/encoderffmpegmp4.cpp
* src/recording/encoderffmpegmp4.h
* src/recording/encoderffmpegopus.cpp
* src/recording/encoderffmpegopus.h
* src/recording/enginerecord.cpp

I'll probable have to solve patch problems by hand.. again or try to rebase
my work if I just find that doc that I was reading other day,
Tuukka


2013/5/12 Steven Boswell II 

> Since I've done a little ffmpeg programming in the past, I thought I'd
> take a look at this.
>
> Hopefully I'm doing my comparison right; inside of a checkout of Mixxx's
> trunk, I did "bzr update -r 3365", since that seems to be the last version
> that was merged into the ffmpeg branch.
>
> Assuming my comparison is right, my first question is...is there any
> particular reason that there are so many unrelated changes?  It appears
> that support for preview decks has been totally munged
> (src/engine/enginechannel.[cpp,h],
> src/library/baseexternalplaylistmodel.cpp,
> src/library/baseexternaltrackmodel.cpp, src/library/cratetablemodel.cpp,
> and many many others), that some files have been copied
> (src/library/previewbuttondelegate.[cpp,h].moved and
> src/previewdeck.cpp.moved), ConfigObject::exists() has been removed,
> src/mathstuff.h now has Apple-only definitions for functions that exist in
> Qt (i.e. qIsNaN() and qIsInf()), etc.
>
> Some clarifications on this would be appreciated.
> Now I'll dig into the actual FFMPEG changes :-)
>
> Steven Boswell
>
>   --
>  *From:* Tuukka Pasanen 
> *To:* mixxx-devel@lists.sourceforge.net
> *Sent:* Wednesday, May 8, 2013 11:52 AM
> *Subject:* [Mixxx-devel] Mixxx and FFMPEG/Libav status update
>
> [...]
>
> FFMPEG/Libav support is now in state it can be used drop-in placement in
> playing and recording.
> [...]
>
>
> --
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] Mixxx and FFMPEG/Libav status update

2013-05-12 Thread Tuukka Pasanen
2013/5/8 Tuukka Pasanen 

> Hello,
> There is so much happening currently in Mixxx world that I have dropped
> happily from the horse. Marvelous 1.11 release is coming and SoC is
> currently running, huh!
> Still I just wanted to make humble announcement that FFMPEG/Libav support
> is now in state it can be used drop-in placement in playing and recording.
> It compiles Libav 0.8.x/9.x (http://libav.org) and FFMPEG
> 0.11/1.0/1.1/1.2 (http://ffmpeg.org). Recording and playing works. It
> support mostly all audio formats that FFMPEG/Libav can handle. Recording
> just have mp3 and Ogg Vorbis working and tested.It's also merged with
> lp:mixxx today so it shoud have all the 1.11 goodies also.
>
> If you are on Linux (Ubuntu, Mint, openSUSE, Gentoo, Fedora or Your best
> distro here)/Mac Os X (Windows FFMPEG/Libav anyone?) and are in adventurous
> mood you can crap the code from:
>
> bzr branch lp:~pasanen-tuukka/mixxx/**mixxx-ffmpeg-0.11
>
> and compile it after you have fetched ffmpeg devel or libav devel packages
> (I'm using mac ports FFMPEG by myself)
>
> scons ffmpeg=1
>
> It'll probably eat you fishes from fish tank and won't pay your rent.. so
> you are warned but if sun flares are in right spot you'll get faster
> experience with little bit lower latency. There is some bugs that should be
> pushed out and some things in my TODO before i'll call it mature. Code is
> full of #ifdef hell.. so there is somethings to do.. but before getting
> into that i'll make some kick ass mixxxes!
>
> Sincerly,
> Tuukka
>
--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Re: [Mixxx-devel] Mixxx and FFMPEG/Libav status update

2013-05-12 Thread Tuukka Pasanen
Hello,
Seems to work. I removed unneeded QTextCodec and commited change. I also
made up query for FFMPEG/Libav codec so now it assembles ad-hoc list for
format it understands.. pushing them later on when I have tested these..

Thanks,
Tuukka


2013/5/13 Steven Boswell II 

> Wait...it's easier than that...instead of having to fetch a QTextCodec, I
> can just call QString::fromUtf8().
> New patch. :-)
>
> Steven Boswell
>
>   --
>  *From:* Steven Boswell II 
> *To:* "mixxx-devel@lists.sourceforge.net" <
> mixxx-devel@lists.sourceforge.net>
> *Sent:* Sunday, May 12, 2013 3:35 PM
> *Subject:* Re: [Mixxx-devel] Mixxx and FFMPEG/Libav status update
>
> Tuukka:
>
> So far, all I've noticed wrong is the Unicode handling for metadata
> (artist, title, etc.)
> The enclosed patch fixes that.
>
> I also noticed that you're apparently having problems with Unicode paths
> under MS Windows.  After digging around for a while, it appears that this
> is a known bug, though ff_win32_open() in libavformat/os_support.c (at
> least in my version of ffmpeg, i.e. 1.0.5) seems to be doing the right
> thing for UTF-8.  So it's still a mystery.  But maybe this will help you
> track down the problem.
>
> Steven Boswell
>
>
>
> --
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
>
>
> --
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> ___
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
--
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel