Re: Cannot send message: QMI service 'pdc' version '1.15' required, got version '1.0'

2019-12-16 Thread Aleksander Morgado
> >
> > See
> > https://gitlab.freedesktop.org/mobile-broadband/libqmi/merge_requests/80
> >
> > Comments welcome
>
> I see you merged it 6 hours ago, but FWIW it looks good to me :)
>

Thanks for checking! :) Yes, I merged it without asking too much
because all that logic has been truly broken for a very long time
really...
I also flagged as deprecated in 1.26 the method in libqmi that loaded
the version info of each message.

We should probably do a .so version bump one of these days and release
libqmi 2 with all the deprecated stuff removed... :)

-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel


Re: Cannot send message: QMI service 'pdc' version '1.15' required, got version '1.0'

2019-12-16 Thread Dan Williams
On Fri, 2019-12-13 at 18:37 +0100, Aleksander Morgado wrote:
> > > I’m testing mm 1.12.2 + libqmi 1.24.2 on sierra EM7565 (openwrt).
> > > Please see last line of log. Is this ok?
> > > 
> > > 
> > > 
> > > I do not see this in mm 1.12.0 + libqmi 1.24.0
> > > 
> > > 
> > > 
> > > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Enabling QMI
> > > indications via MBIM...
> > > 
> > > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] enabled QMI
> > > indications via MBIM
> > > 
> > > Dec 13 15:51:38 OpenWrt [5904]:   [cdc-wdm0] MBIM device is
> > > QMI capable
> > > 
> > > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new
> > > client ID...
> > > 
> > > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'dms'
> > > (version 1.0) client with ID '1'
> > > 
> > > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new
> > > client ID...
> > > 
> > > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'nas'
> > > (version 1.25) client with ID '2'
> > > 
> > > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new
> > > client ID...
> > > 
> > > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'loc'
> > > (version 2.0) client with ID '1'
> > > 
> > > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new
> > > client ID...
> > > 
> > > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'pdc'
> > > (version 1.0) client with ID '1'
> > > 
> > > Dec 13 15:51:39 OpenWrt [5904]:   QMI-based capability and
> > > mode switching support enabled
> > > 
> > > Dec 13 15:51:39 OpenWrt [5904]:   couldn't load carrier
> > > config: 'Cannot send message: QMI service 'pdc' version '1.15'
> > > required, got version '1.0''
> > > 
> > 
> > I believe the issue is unrelated to the MM/libqmi version. It would
> > be
> > very strange that the modem replies differnet things when using
> > different libqmi versions really.
> > 
> > The problem, though, is something we should fix. The version checks
> > done by libqmi are truly broken, because they rely on the version
> > info
> > for each message that is defined in our message database, and that
> > information is far from good or up to date. If the message is not
> > supported by the device, we'll get an error when trying to use it.
> > Trying to return an early error before sending the request assuming
> > our information of when it was introduced is good is not the way to
> > go.
> > 
> 
> See 
> https://gitlab.freedesktop.org/mobile-broadband/libqmi/merge_requests/80
> 
> Comments welcome

I see you merged it 6 hours ago, but FWIW it looks good to me :)

Dan

> 

___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel


RE: Cannot send message: QMI service 'pdc' version '1.15' required, got version '1.0'

2019-12-13 Thread Amol Lad
Looks good to me.

Thanks!


The information in this email communication (inclusive of attachments) is 
confidential to 4RF Limited and the intended recipient(s). If you are not the 
intended recipient(s), please note that any use, disclosure, distribution or 
copying of this information or any part thereof is strictly prohibited and that 
the author accepts no liability for the consequences of any action taken on the 
basis of the information provided. If you have received this email in error, 
please notify the sender immediately by return email and then delete all 
instances of this email from your system. 4RF Limited will not accept 
responsibility for any consequences associated with the use of this email 
(including, but not limited to, damages sustained as a result of any viruses 
and/or any action or lack of action taken in reliance on it).-Original 
Message-
From: Aleksander Morgado 
Sent: Friday, 13 December 2019 11:07 PM
To: Amol Lad 
Cc: modemmanager-devel@lists.freedesktop.org
Subject: Re: Cannot send message: QMI service 'pdc' version '1.15' required, 
got version '1.0'

>
> > I’m testing mm 1.12.2 + libqmi 1.24.2 on sierra EM7565 (openwrt). Please 
> > see last line of log. Is this ok?
> >
> >
> >
> > I do not see this in mm 1.12.0 + libqmi 1.24.0
> >
> >
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Enabling QMI indications 
> > via MBIM...
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] enabled QMI
> > indications via MBIM
> >
> > Dec 13 15:51:38 OpenWrt [5904]:   [cdc-wdm0] MBIM device is
> > QMI capable
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'dms' (version 
> > 1.0) client with ID '1'
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'nas' (version 
> > 1.25) client with ID '2'
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'loc' (version 
> > 2.0) client with ID '1'
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'pdc' (version 
> > 1.0) client with ID '1'
> >
> > Dec 13 15:51:39 OpenWrt [5904]:   QMI-based capability and
> > mode switching support enabled
> >
> > Dec 13 15:51:39 OpenWrt [5904]:   couldn't load carrier config: 
> > 'Cannot send message: QMI service 'pdc' version '1.15' required, got 
> > version '1.0''
> >
>
> I believe the issue is unrelated to the MM/libqmi version. It would be
> very strange that the modem replies differnet things when using
> different libqmi versions really.
>
> The problem, though, is something we should fix. The version checks
> done by libqmi are truly broken, because they rely on the version info
> for each message that is defined in our message database, and that
> information is far from good or up to date. If the message is not
> supported by the device, we'll get an error when trying to use it.
> Trying to return an early error before sending the request assuming
> our information of when it was introduced is good is not the way to
> go.
>

See https://gitlab.freedesktop.org/mobile-broadband/libqmi/merge_requests/80

Comments welcome


--
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel


Re: Cannot send message: QMI service 'pdc' version '1.15' required, got version '1.0'

2019-12-13 Thread Aleksander Morgado
>
> > I’m testing mm 1.12.2 + libqmi 1.24.2 on sierra EM7565 (openwrt). Please 
> > see last line of log. Is this ok?
> >
> >
> >
> > I do not see this in mm 1.12.0 + libqmi 1.24.0
> >
> >
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Enabling QMI indications 
> > via MBIM...
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] enabled QMI indications via 
> > MBIM
> >
> > Dec 13 15:51:38 OpenWrt [5904]:   [cdc-wdm0] MBIM device is QMI 
> > capable
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'dms' (version 
> > 1.0) client with ID '1'
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'nas' (version 
> > 1.25) client with ID '2'
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'loc' (version 
> > 2.0) client with ID '1'
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
> >
> > Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'pdc' (version 
> > 1.0) client with ID '1'
> >
> > Dec 13 15:51:39 OpenWrt [5904]:   QMI-based capability and mode 
> > switching support enabled
> >
> > Dec 13 15:51:39 OpenWrt [5904]:   couldn't load carrier config: 
> > 'Cannot send message: QMI service 'pdc' version '1.15' required, got 
> > version '1.0''
> >
>
> I believe the issue is unrelated to the MM/libqmi version. It would be
> very strange that the modem replies differnet things when using
> different libqmi versions really.
>
> The problem, though, is something we should fix. The version checks
> done by libqmi are truly broken, because they rely on the version info
> for each message that is defined in our message database, and that
> information is far from good or up to date. If the message is not
> supported by the device, we'll get an error when trying to use it.
> Trying to return an early error before sending the request assuming
> our information of when it was introduced is good is not the way to
> go.
>

See https://gitlab.freedesktop.org/mobile-broadband/libqmi/merge_requests/80

Comments welcome


-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel


Re: Cannot send message: QMI service 'pdc' version '1.15' required, got version '1.0'

2019-12-13 Thread Aleksander Morgado
Hey!


> I’m testing mm 1.12.2 + libqmi 1.24.2 on sierra EM7565 (openwrt). Please see 
> last line of log. Is this ok?
>
>
>
> I do not see this in mm 1.12.0 + libqmi 1.24.0
>
>
>
> Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Enabling QMI indications via 
> MBIM...
>
> Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] enabled QMI indications via 
> MBIM
>
> Dec 13 15:51:38 OpenWrt [5904]:   [cdc-wdm0] MBIM device is QMI capable
>
> Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
>
> Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'dms' (version 
> 1.0) client with ID '1'
>
> Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
>
> Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'nas' (version 
> 1.25) client with ID '2'
>
> Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
>
> Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'loc' (version 
> 2.0) client with ID '1'
>
> Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
>
> Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'pdc' (version 
> 1.0) client with ID '1'
>
> Dec 13 15:51:39 OpenWrt [5904]:   QMI-based capability and mode 
> switching support enabled
>
> Dec 13 15:51:39 OpenWrt [5904]:   couldn't load carrier config: 'Cannot 
> send message: QMI service 'pdc' version '1.15' required, got version '1.0''
>

I believe the issue is unrelated to the MM/libqmi version. It would be
very strange that the modem replies differnet things when using
different libqmi versions really.

The problem, though, is something we should fix. The version checks
done by libqmi are truly broken, because they rely on the version info
for each message that is defined in our message database, and that
information is far from good or up to date. If the message is not
supported by the device, we'll get an error when trying to use it.
Trying to return an early error before sending the request assuming
our information of when it was introduced is good is not the way to
go.

-- 
Aleksander
https://aleksander.es
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel


Cannot send message: QMI service 'pdc' version '1.15' required, got version '1.0'

2019-12-13 Thread Amol Lad
Hi,

I'm testing mm 1.12.2 + libqmi 1.24.2 on sierra EM7565 (openwrt). Please see 
last line of log. Is this ok?

I do not see this in mm 1.12.0 + libqmi 1.24.0

Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Enabling QMI indications via 
MBIM...
Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] enabled QMI indications via MBIM
Dec 13 15:51:38 OpenWrt [5904]:   [cdc-wdm0] MBIM device is QMI capable
Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'dms' (version 1.0) 
client with ID '1'
Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'nas' (version 1.25) 
client with ID '2'
Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'loc' (version 2.0) 
client with ID '1'
Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Allocating new client ID...
Dec 13 15:51:38 OpenWrt [5904]: [/dev/cdc-wdm0] Registered 'pdc' (version 1.0) 
client with ID '1'
Dec 13 15:51:39 OpenWrt [5904]:   QMI-based capability and mode switching 
support enabled
Dec 13 15:51:39 OpenWrt [5904]:   couldn't load carrier config: 'Cannot 
send message: QMI service 'pdc' version '1.15' required, got version '1.0''

Thanks
Amol

The information in this email communication (inclusive of attachments) is 
confidential to 4RF Limited and the intended recipient(s). If you are not the 
intended recipient(s), please note that any use, disclosure, distribution or 
copying of this information or any part thereof is strictly prohibited and that 
the author accepts no liability for the consequences of any action taken on the 
basis of the information provided. If you have received this email in error, 
please notify the sender immediately by return email and then delete all 
instances of this email from your system. 4RF Limited will not accept 
responsibility for any consequences associated with the use of this email 
(including, but not limited to, damages sustained as a result of any viruses 
and/or any action or lack of action taken in reliance on it).
___
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel