Re: libapreq-1.1 Release Candidate 1
Joe Schaefer wrote:
The apreq developers are planning a maintenance release of
libapreq-1.1. This version does not include support for
modperl-2, but it does address some outstanding problems in
1.0:
I have made the below patch to make Apache::Request behave like CGI.pm
when parsing multi-valued http POST data. Without the patch the matching
of the variable names is case insensitive this results in a multi valued
list instead of two separate hash entries if the following fragment is
posted.
input type=hidden name=GOTO value=up
input type=hidden name=goto value=down
Since the keys in perl hashes are case sensitive it makes no sense to
believe that the above two keys should create a multivalued enty and not
two entries, one with key 'GOTO' and the other with 'goto'.
To make matters worse actual case used for the resulting multivalued key
is only dependent on which field that was parsed first!
/Martin
--
Martin Nilsson, Civilingenjör M.Sc. CSE
Svenska Butiker AB,
S:t Larsväg 44, 222 70 Lund, Sweden
[EMAIL PROTECTED]
Phone: +46-46-304130
http://www.svenskabutiker.se
--- Request/Request.xs.org Sun Jan 20 18:27:35 2002
+++ Request/Request.xs Wed Sep 11 18:11:11 2002
@@ -400,7 +400,7 @@
array_header *arr = ap_table_elts(req-parms);
table_entry *elts = (table_entry *)arr-elts;
for (i = 0; i arr-nelts; ++i) {
- if (elts[i].key strcaseEQ(elts[i].key, key))
+ if (elts[i].key strEQ(elts[i].key, key))
XPUSHs(sv_2mortal(newSVpv(elts[i].val,0)));
}
}
@@ -429,7 +429,7 @@
if (!elts[i].key) continue;
/* simple but inefficient uniqueness check */
for (j = 0; j i; ++j) {
- if (strcaseEQ(elts[i].key, elts[j].key))
+ if (strEQ(elts[i].key, elts[j].key))
break;
}
if ( i == j )
Re: libapreq-1.1 Release Candidate 1
:11: header file 'util_script.h' not found apache_request.h:38: undefined type, found `table' apache_request.h:47: undefined type, found `request_rec' apache_request.h:55: undefined type, found `table' apache_request.h:56: undefined type, found `FILE' apache_request.h:89: undefined type, found `request_rec' apache_request.h:95: undefined type, found `array_header' apache_request.h:101: undefined type, found `FILE' apache_request.h:121: undefined type, found `pool' apache_cookie.h:6: undefined type, found `array_header' apache_cookie.h:9: undefined type, found `request_rec' apache_cookie.h:11: undefined type, found `array_header' apache_cookie.h:44: undefined type, found `request_rec' apache_cookie.h:45: undefined type, found `request_rec' apache_cookie.c:113: undefined type, found `request_rec' apache_cookie.c:115: undefined type, found `va_list' apache_cookie.c:132: illegal expression, found `char' apache_cookie.c:136: illegal expression, found `char' apache_cookie.c:144: undefined type, found `request_rec' apache_cookie.c:196: undefined type, found `pool' apache_cookie.c:232: undefined type, found `array_header' apache_cookie.c:233: undefined type, found `pool' cpp-precomp: warning: errors during smart preprocessing, retrying in basic mode make[1]: *** [apache_cookie.lo] Error 1 make: *** [all-recursive] Error 1 [honeycrisp:~/src/httpd-apreq] em% On 25 Nov 2002, Joe Schaefer wrote: Date: 25 Nov 2002 18:34:15 -0500 From: Joe Schaefer [EMAIL PROTECTED] To: modperl list [EMAIL PROTECTED], macosx list [EMAIL PROTECTED], apreq list [EMAIL PROTECTED] Subject: libapreq-1.1 Release Candidate 1 The apreq developers are planning a maintenance release of libapreq-1.1. This version does not include support for modperl-2, but it does address some outstanding problems in 1.0: * OS X support * perl 5.8 segfaults related to file uploads. Please give the tarball at http://www.apache.org/~joes/libapreq-1.1_rc1.tar.gz a try and report comments/problems/etc. to the apreq-dev list at [EMAIL PROTECTED] There are special build instructions for OS X, so be sure to have a look at http://www.apache.org/~joes/ for details on OS X support. We'll be patching the INSTALL README documents based on OS X user feedback. Note: We really could use more volunteers participating in apreq-dev, especially folks with OS X experience. Even though libapreq is a small (ASF) project, there's plenty of work to be done- both in improving/supporting the libapreq-1.x codebase as well as porting apreq to modperl-2. Thanks. -- Joe Schaefer
libapreq-1.1 Release Candidate 1
The apreq developers are planning a maintenance release of libapreq-1.1. This version does not include support for modperl-2, but it does address some outstanding problems in 1.0: * OS X support * perl 5.8 segfaults related to file uploads. Please give the tarball at http://www.apache.org/~joes/libapreq-1.1_rc1.tar.gz a try and report comments/problems/etc. to the apreq-dev list at [EMAIL PROTECTED] There are special build instructions for OS X, so be sure to have a look at http://www.apache.org/~joes/ for details on OS X support. We'll be patching the INSTALL README documents based on OS X user feedback. Note: We really could use more volunteers participating in apreq-dev, especially folks with OS X experience. Even though libapreq is a small (ASF) project, there's plenty of work to be done- both in improving/supporting the libapreq-1.x codebase as well as porting apreq to modperl-2. Thanks. -- Joe Schaefer
Re: libapreq-1.1 Release Candidate 1
Hi Joe APReq, I'm glad this is receiving attention, Apache::Request has had some trouble on OS X as I'm sure you're aware. I just tested the RC, using: perl 5.6.1 Apache/1.3.26 (as shipped with the OS, uses dso) OS X 10.1.5 and I get this error in 'make test': dyld: t/httpd multiple definitions of symbol _ApacheRequest___parse blib/arch/auto/Apache/Request/Request.bundle definition of _ApacheRequest___parse blib/arch/auto/Apache/Cookie/Cookie.bundle definition of _ApacheRequest___parse make: *** [start_httpd] Error 66 I believe this was the same error from several months ago, that the binary namespaces of Apache::Request and Apache::Cookie are conflicting. I've attached the full output. -Ken On Tuesday, November 26, 2002, at 10:34 AM, Joe Schaefer wrote: The apreq developers are planning a maintenance release of libapreq-1.1. This version does not include support for modperl-2, but it does address some outstanding problems in 1.0: * OS X support * perl 5.8 segfaults related to file uploads. Please give the tarball at http://www.apache.org/~joes/libapreq-1.1_rc1.tar.gz a try and report comments/problems/etc. to the apreq-dev list at [EMAIL PROTECTED] There are special build instructions for OS X, so be sure to have a look at http://www.apache.org/~joes/ for details on OS X support. We'll be patching the INSTALL README documents based on OS X user feedback. Note: We really could use more volunteers participating in apreq-dev, especially folks with OS X experience. Even though libapreq is a small (ASF) project, there's plenty of work to be done- both in improving/supporting the libapreq-1.x codebase as well as porting apreq to modperl-2. Thanks. -- Joe Schaefer libapreq-out Description: application/applefile libapreq-out Description: Binary data
Re: libapreq-1.1 Release Candidate 1
Ken Williams [EMAIL PROTECTED] writes: [...] I've attached the full output. Thanks, Ken. I looked over the result, but didn't see any indication that you used the ./configure - make - make install instructions from the web page. Did the libtool-based build of libapreq install successfully before you tried doing the perl build? -- Joe Schaefer
Re: libapreq-1.1 Release Candidate 1
: undefined type, found `array_header' apache_request.h:101: undefined type, found `FILE' apache_request.h:121: undefined type, found `pool' apache_cookie.h:6: undefined type, found `array_header' apache_cookie.h:9: undefined type, found `request_rec' apache_cookie.h:11: undefined type, found `array_header' apache_cookie.h:44: undefined type, found `request_rec' apache_cookie.h:45: undefined type, found `request_rec' apache_cookie.c:113: undefined type, found `request_rec' apache_cookie.c:115: undefined type, found `va_list' apache_cookie.c:132: illegal expression, found `char' apache_cookie.c:136: illegal expression, found `char' apache_cookie.c:144: undefined type, found `request_rec' apache_cookie.c:196: undefined type, found `pool' apache_cookie.c:232: undefined type, found `array_header' apache_cookie.c:233: undefined type, found `pool' cpp-precomp: warning: errors during smart preprocessing, retrying in basic mode make[1]: *** [apache_cookie.lo] Error 1 make: *** [all-recursive] Error 1 [honeycrisp:~/src/httpd-apreq] em% On 25 Nov 2002, Joe Schaefer wrote: Date: 25 Nov 2002 18:34:15 -0500 From: Joe Schaefer [EMAIL PROTECTED] To: modperl list [EMAIL PROTECTED], macosx list [EMAIL PROTECTED], apreq list [EMAIL PROTECTED] Subject: libapreq-1.1 Release Candidate 1 The apreq developers are planning a maintenance release of libapreq-1.1. This version does not include support for modperl-2, but it does address some outstanding problems in 1.0: * OS X support * perl 5.8 segfaults related to file uploads. Please give the tarball at http://www.apache.org/~joes/libapreq-1.1_rc1.tar.gz a try and report comments/problems/etc. to the apreq-dev list at [EMAIL PROTECTED] There are special build instructions for OS X, so be sure to have a look at http://www.apache.org/~joes/ for details on OS X support. We'll be patching the INSTALL README documents based on OS X user feedback. Note: We really could use more volunteers participating in apreq-dev, especially folks with OS X experience. Even though libapreq is a small (ASF) project, there's plenty of work to be done- both in improving/supporting the libapreq-1.x codebase as well as porting apreq to modperl-2. Thanks. -- Joe Schaefer
Re: libapreq-1.1 Release Candidate 1
a try and report comments/problems/etc. to the apreq-dev list at [EMAIL PROTECTED] I have a comment :) I've been building nightly from CVS for almost a year now, but when you added the Apache::test stuff I had to stop doing it - the prompt for the Apache path when building the makefile makes it hang indefinitely. I caught the discussion on apreq-dev about Apache::Test v Apache::test and have a rather strong opinion on that but, as I'm not actually contributing anything to the project, I'll keep quiet :) at any rate, figuring out a logic other than ! to skip would be nice. $0.02 --Geoff
Re: libapreq-1.1 Release Candidate 1
On Tuesday, November 26, 2002, at 12:22 PM, Joe Schaefer wrote:
Ken Williams [EMAIL PROTECTED] writes:
[...]
I've attached the full output.
Thanks, Ken. I looked over the result, but didn't see any
indication that you used the ./configure - make - make install
instructions from the web page.
D'oh! I just looked at the INSTALL file, despite your
admonitions to the contrary. Sorry to overlook it.
I got through ./configure - make - make install
successfully, installing to /usr/local/lib/ and
/usr/local/include/. However, there doesn't seem to be a
ldconfig on my system ('locate' couldn't find one anywhere,
and I checked manually in /sbin/ and /usr/sbin/).
Did the libtool-based build
of libapreq install successfully before you tried doing the perl
build?
This time around, I installed libapreq and then did 'perl
Makefile.PL; make test;' and got a different error. Looks like
the server didn't start properly.
I've attached the terminal output, and the httpd.conf in case
it's helpful. The t/error_log is unremarkable (just a bunch of
stuff like [warn] module mod_log_config.c is already added,
skipping).
-Ken
libapreq-out
Description: application/applefile
libapreq-out
Description: Binary data
httpd.conf
Description: Binary data
Re: libapreq-1.1 Release Candidate 1
Ken Williams [EMAIL PROTECTED] writes:
[...]
I got through ./configure - make - make install
successfully, installing to /usr/local/lib/ and
/usr/local/include/. However, there doesn't seem to be a
ldconfig on my system ('locate' couldn't find one anywhere,
and I checked manually in /sbin/ and /usr/sbin/).
According to
http://fink.sourceforge.net/doc/porting/porting.html
OS X doesn't have/need an ldconfig binary (I'll update the web page).
Try running the BUILD.sh script first. It'll rebuild the libtool/
autoconf/automake utilities by using to your machine's version,
instead of the ones I included in the tarball (which are based on
my linux box). You might try running that first, and then doing
the ./configure - make - make install mojo before building
the perl tests.
If you still have trouble, I think it'll help apreq-dev to see
the transcript of the full process, from sh BUILD.sh through
make test.
--
Joe Schaefer
Re: libapreq-1.1 Release Candidate 1
On Tuesday, November 26, 2002, at 05:24 PM, Joe Schaefer wrote:
Ken Williams [EMAIL PROTECTED] writes:
[...]
I got through ./configure - make - make install
successfully, installing to /usr/local/lib/ and
/usr/local/include/. However, there doesn't seem to be a
ldconfig on my system ('locate' couldn't find one anywhere,
and I checked manually in /sbin/ and /usr/sbin/).
According to
http://fink.sourceforge.net/doc/porting/porting.html
OS X doesn't have/need an ldconfig binary (I'll update the web page).
Try running the BUILD.sh script first. It'll rebuild the libtool/
autoconf/automake utilities by using to your machine's version,
instead of the ones I included in the tarball (which are based on
my linux box). You might try running that first, and then doing
the ./configure - make - make install mojo before building
the perl tests.
Promising, but several errors ensue:
[pe-242:~/Downloads/perl/httpd-apreq] ken% ./BUILD.sh
./BUILD.sh: command not found: libtoolize [4]
./BUILD.sh: command not found: aclocal [5]
FATAL ERROR: Autoconf version 2.52 or higher is required for this script
./BUILD.sh: command not found: automake [7]
[pe-242:~/Downloads/perl/httpd-apreq] ken% which autoconf
/usr/bin/autoconf
[pe-242:~/Downloads/perl/httpd-apreq] ken% autoconf --version
Autoconf version 2.13
Is it possible to backport the process to older autoconfs, or
are new features required?
-Ken
