Re: Question on Changes to the Version Plugin

2017-08-13 Thread Oliver B. Fischer 

Hi Sergei,

thank you. This is execatly what I am looking for.

Oliver


Am 13.08.17 um 02:41 schrieb 'Sergei Ivanov' via mojohaus-dev:

Hi Oliver,

If you are writing your test as part of the invoker-driven ITs, then 
you can build your additional jar as one of the IT "setup" modules.
http://maven.apache.org/plugins/maven-invoker-plugin/run-mojo.html#setupIncludes 


You can then refer to that jar in your IT POMs.
The main advantage is that this won't require any substantial change 
to the project structure.


Kind regards,
--
Sergei Ivanov

Суббота, 12 августа 2017, 18:23 +01:00 от "Oliver B. Fischer"
:

I am only asking as it will be a more or less hughe change to the
directory layout of the repository. Already existing PR might fail
because of the changed directory structures. Ok, Git is quite
smart but is it smart enough?

Oliver

Am 10.08.17 um 01:39 schrieb Manfred Moser:


--
You received this message because you are subscribed to the Google 
Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send 
an email to mojohaus-dev+unsubscr...@googlegroups.com 
.
To post to this group, send email to mojohaus-dev@googlegroups.com 
.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mojohaus-dev/1502584862.216697686%40f482.i.mail.ru 
.

For more options, visit https://groups.google.com/d/optout.


--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fisc...@swe-blog.net
S oliver.b.fischer
J oliver.b.fisc...@jabber.org
X http://xing.to/obf

--
You received this message because you are subscribed to the Google Groups 
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojohaus-dev+unsubscr...@googlegroups.com.
To post to this group, send email to mojohaus-dev@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mojohaus-dev/2192fc32-5a43-ea7e-3783-1092a5b40d9e%40swe-blog.net.
For more options, visit https://groups.google.com/d/optout.

Re[2]: Question on Changes to the Version Plugin

2017-08-12 Thread 'Sergei Ivanov' via mojohaus-dev 
Hi Oliver,

If you are writing your test as part of the invoker-driven ITs, then you can 
build your additional jar as one of the IT "setup" modules.
http://maven.apache.org/plugins/maven-invoker-plugin/run-mojo.html#setupIncludes
  
You can then refer to that jar in your IT POMs.
The main advantage is that this won't require any substantial change to the 
project structure.

Kind regards,
--
Sergei Ivanov

>Суббота, 12 августа 2017, 18:23 +01:00 от "Oliver B. Fischer" 
>:
>
>I am only asking as it will be a more or less hughe change to the
>  directory layout of the repository. Already existing PR might fail
>  because of the changed directory structures. Ok, Git is quite
>  smart but is it smart enough?
>Oliver
>Am 10.08.17 um 01:39 schrieb Manfred
>  Moser:
>>Why not? That will work best.. 
>>
>>
>>On Wed, Aug 9, 2017 at 12:14 PM, Oliver
>>  B. Fischer  < o.b.fisc...@swe-blog.net > wrote:
>>>Dear all,
>>>
>>>I am working on a PR for  
>>>https://github.com/mojohaus/versions-maven-plugin/issues/193 .
>>>
>>>The support for loading a rules file from the classpath is
>>>one thing. The other challange is to write a good test case.
>>>So I would like to write also a test which fetches the rules
>>>file from a jar.
>>>
>>>I would like to build the jar also during the build of the
>>>plugin but I need it already during the tests. How to
>>>accomplish this in an easy way? I dont want to turn it in a
>>>multi module project only to build a jar for the IT.
>>>
>>>Oliver

-- 
You received this message because you are subscribed to the Google Groups 
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojohaus-dev+unsubscr...@googlegroups.com.
To post to this group, send email to mojohaus-dev@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mojohaus-dev/1502584862.216697686%40f482.i.mail.ru.
For more options, visit https://groups.google.com/d/optout.

Re: Question on Changes to the Version Plugin

2017-08-12 Thread Oliver B. Fischer 
I am only asking as it will be a more or less hughe change to the 
directory layout of the repository. Already existing PR might fail 
because of the changed directory structures. Ok, Git is quite smart but 
is it smart enough?


Oliver

Am 10.08.17 um 01:39 schrieb Manfred Moser:

Why not? That will work best..


On Wed, Aug 9, 2017 at 12:14 PM, Oliver B. Fischer 
mailto:o.b.fisc...@swe-blog.net>> wrote:


Dear all,

I am working on a PR for
https://github.com/mojohaus/versions-maven-plugin/issues/193
.

The support for loading a rules file from the classpath is one
thing. The other challange is to write a good test case. So I
would like to write also a test which fetches the rules file from
a jar.

I would like to build the jar also during the build of the plugin
but I need it already during the tests. How to accomplish this in
an easy way? I dont want to turn it in a multi module project only
to build a jar for the IT.

Oliver

-- 
N Oliver B. Fischer

A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251 
M +49 178 7903538 
E o.b.fisc...@swe-blog.net 
S oliver.b.fischer
J oliver.b.fisc...@jabber.org 
X http://xing.to/obf

-- 
You received this message because you are subscribed to the Google

Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to mojohaus-dev+unsubscr...@googlegroups.com
.
To post to this group, send email to mojohaus-dev@googlegroups.com
.
To view this discussion on the web visit

https://groups.google.com/d/msgid/mojohaus-dev/79fc6d52-8544-fcc9-5e2a-b70138cabb51%40swe-blog.net

.
For more options, visit https://groups.google.com/d/optout
.


--
You received this message because you are subscribed to the Google 
Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send 
an email to mojohaus-dev+unsubscr...@googlegroups.com 
.
To post to this group, send email to mojohaus-dev@googlegroups.com 
.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mojohaus-dev/CABffhO735p7Jk16iLVZGvcmt55QaoTpc8YRZXgJKpXzrAPw-Wg%40mail.gmail.com 
.

For more options, visit https://groups.google.com/d/optout.


--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fisc...@swe-blog.net
S oliver.b.fischer
J oliver.b.fisc...@jabber.org
X http://xing.to/obf

--
You received this message because you are subscribed to the Google Groups 
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojohaus-dev+unsubscr...@googlegroups.com.
To post to this group, send email to mojohaus-dev@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mojohaus-dev/7ad8b1b1-9d8c-5362-5516-521b8a33ce22%40swe-blog.net.
For more options, visit https://groups.google.com/d/optout.

Re: Question on Changes to the Version Plugin

2017-08-09 Thread Manfred Moser 
Why not? That will work best..


On Wed, Aug 9, 2017 at 12:14 PM, Oliver B. Fischer  wrote:

> Dear all,
>
> I am working on a PR for https://github.com/mojohaus/ve
> rsions-maven-plugin/issues/193.
>
> The support for loading a rules file from the classpath is one thing. The
> other challange is to write a good test case. So I would like to write also
> a test which fetches the rules file from a jar.
>
> I would like to build the jar also during the build of the plugin but I
> need it already during the tests. How to accomplish this in an easy way? I
> dont want to turn it in a multi module project only to build a jar for the
> IT.
>
> Oliver
>
> --
> N Oliver B. Fischer
> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> P +49 30 44793251
> M +49 178 7903538
> E o.b.fisc...@swe-blog.net
> S oliver.b.fischer
> J oliver.b.fisc...@jabber.org
> X http://xing.to/obf
>
> --
> You received this message because you are subscribed to the Google Groups
> "mojohaus-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to mojohaus-dev+unsubscr...@googlegroups.com.
> To post to this group, send email to mojohaus-dev@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/ms
> gid/mojohaus-dev/79fc6d52-8544-fcc9-5e2a-b70138cabb51%40swe-blog.net.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojohaus-dev+unsubscr...@googlegroups.com.
To post to this group, send email to mojohaus-dev@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mojohaus-dev/CABffhO735p7Jk16iLVZGvcmt55QaoTpc8YRZXgJKpXzrAPw-Wg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Question on Changes to the Version Plugin

2017-08-09 Thread Oliver B. Fischer 

Dear all,

I am working on a PR for 
https://github.com/mojohaus/versions-maven-plugin/issues/193.


The support for loading a rules file from the classpath is one thing. 
The other challange is to write a good test case. So I would like to 
write also a test which fetches the rules file from a jar.


I would like to build the jar also during the build of the plugin but I 
need it already during the tests. How to accomplish this in an easy way? 
I dont want to turn it in a multi module project only to build a jar for 
the IT.


Oliver

--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fisc...@swe-blog.net
S oliver.b.fischer
J oliver.b.fisc...@jabber.org
X http://xing.to/obf

--
You received this message because you are subscribed to the Google Groups 
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojohaus-dev+unsubscr...@googlegroups.com.
To post to this group, send email to mojohaus-dev@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mojohaus-dev/79fc6d52-8544-fcc9-5e2a-b70138cabb51%40swe-blog.net.
For more options, visit https://groups.google.com/d/optout.