Re: [Mono-dev] Pull request 1977 (socket functions for Mono.Posix)
Hello, On 2015-08-14 18:47, Steffen Kieß wrote: Hello, I've created a pull request which adds socket-related functions and data structures to Mono.Posix. https://github.com/mono/mono/pull/1977 The first part of this pull request has been merged. For the second and third part I've created updated pull requests at https://github.com/mono/mono/pull/2006 and https://github.com/mono/mono/pull/2097 Can someone take a look at these pull requests? Best regards, Steffen Kieß ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] Pull request 1977 (socket functions for Mono.Posix)
Hello, I've created a pull request which adds socket-related functions and data structures to Mono.Posix. https://github.com/mono/mono/pull/1977 This is evertything from sys/socket.h and the structures sockaddr_in, sockaddr_in6 and sockaddr_un. A few comments regarding the implementation: - sockaddr_* is passed into and out of the functions as a byte[] (+ a long for the length of the data). This is because the actual type of the data is unknown, as it depends on the address family. The Sockaddr* structures can be used to create or inspect such a byte[]. - control messages are also treated as an opaque byte sequence, which can be created or inspected with the CMSG_* macros. The unit tests contain an example for sending file descriptors over a socket using SCM_RIGHTS - The enums (e.g. SockType) have been named in a way to avoid conflicts when importing the namespaces System.Net or System.Net.Sockets and Mono.Unix.Native. (Several files in the mono repository do this, probably also projects outside the mono repository do the same thing.) If you have any questions / comments or want me to change something please tell me so. Best regards, Steffen Kieß ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] pull request 980 [MWF bugfix]
I've updated https://github.com/mono/mono/pull/980 to remove an unwanted merge as far as I can tell. -- Steve McConnel ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] Pull Request #1244 Review
Could someone please review (and approve) PR #1244? It is a small change that corrects a mistake I made in the initial implementation. The initial implementation was incorrect and I don't believe we should have to worry about anyone having used it. ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] pull request, implement System.Threading.Thread.Priority get and set methods
Hi, guys, I really want to be helpful. .Hzj_jie From: 何子杰 Sent: Friday, September 12, 2014 10:33 PM To: Mono Develop Mailing List thank you for Robert's comment, Internals calls must not return structs. This is not supported across all platforms. Hzj_jie: but i see GetName_internal and SetName_internal are all using string and InternalThread, do you mean ThreadPriority enum? but i really cannot understand the reason, since the implementation is similar with other internal functions, so anyone can give me more hints on the change? .Hzj_jie From: hzj_...@hotmail.com To: mono-devel-list@lists.ximian.com Date: Thu, 11 Sep 2014 07:36:11 + Subject: [Mono-dev] pull request, implement System.Threading.Thread.Priority get and set methods hi, all, can anyone from the collaborators help to look at the change https://github.com/mono/mono/pull/1272? it's an implementation of System.Threading.Thread.Priority property. thank you. .Hzj_jie ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] pull request, implement System.Threading.Thread.Priority get and set methods
thank you for Robert's comment, Internals calls must not return structs. This is not supported across all platforms. Hzj_jie: but i see GetName_internal and SetName_internal are all using string and InternalThread, do you mean ThreadPriority enum? but i really cannot understand the reason, since the implementation is similar with other internal functions, so anyone can give me more hints on the change? .Hzj_jie From: hzj_...@hotmail.com To: mono-devel-list@lists.ximian.com Date: Thu, 11 Sep 2014 07:36:11 + Subject: [Mono-dev] pull request, implement System.Threading.Thread.Priority get and set methods hi, all,can anyone from the collaborators help to look at the change https://github.com/mono/mono/pull/1272? it's an implementation of System.Threading.Thread.Priority property. thank you. .Hzj_jie ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] pull request, implement System.Threading.Thread.Priority get and set methods
hi, all,can anyone from the collaborators help to look at the change https://github.com/mono/mono/pull/1272? it's an implementation of System.Threading.Thread.Priority property. thank you. .Hzj_jie ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] Pull Request
I submitted a pull request 10 days ago that fixes a showstopping bug for using SslStream as a server. The latest comment was 7 days ago, Need maintainer approval to build this pull request. Reply with approve to approve a build of this pull request, I assume I'm not authorized to approve my own pull request. For the heck of it, I replied approve today. I don't expect that to go anywhere. Can anybody comment on the status of this? From rahvee Fixed bugs related to SslStream server sending intermediate certs to SslStream clients #1004 ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] Pull Request
Those are CI bots automatic replies. It's still experimental. You can ignore
those comments.
Edward Ned Harvey (mono) edward.harvey.m...@clevertrove.com wrote:
!-- /* Font Definitions */ @font-face {font-family:Cambria Math;
panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;} /* Style Definitions */ p.MsoNormal,
li.MsoNormal, div.MsoNormal{margin:0in;margin-bottom:.0001pt;
font-size:11.0pt; font-family:Calibri,sans-serif;} a:link,
span.MsoHyperlink {mso-style-priority:99; color:#0563C1;
text-decoration:underline;} a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99; color:#954F72; text-decoration:underline;}
span.EmailStyle17 {mso-style-type:personal-compose;
font-family:Calibri,sans-serif; color:windowtext;} .MsoChpDefault
{mso-style-type:export-only;font-family:Calibri,sans-serif;} @page
WordSection1 {size:8.5in 11.0in; margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1 {page:WordSection1;} --
I submitted a pull request 10 days ago that fixes a showstopping bug for using
SslStream as a server. The latest comment was 7 days ago, Need maintainer
approval to build this pull request. Reply with approve to approve a build
of this pull request,
I assume I'm not authorized to approve my own pull request. For the heck of
it, I replied approve today. I don't expect that to go anywhere.
Can anybody comment on the status of this?
From rahvee
Fixed bugs related to SslStream server sending intermediate certs to SslStream
clients #1004
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] Pull request testing
Hey folks! If you're subscribed to notifications for mono/mono you may have just noticed a flood of comments coming your way. We're testing a Jenkins setup for building pull requests, and it will ask explicitly for approval to build pull requests. I didn't expect it to comment on every already-open pull request, though. Sorry for the noise! I'll keep this thread updated on progress in setting all this up. Regards, Alex ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] Pull request for I18N: Fix ByteEncoding crashes when using EncoderFallback
Hi, I have opened a new pull request for mono here: https://github.com/mono/mono/pull/558 I'll be awaiting comments on what to improve. The encoders will need much more testing, I'd be surprised if this doesn't cause any regressions. Thanks. -Mikko Mikko Korkalo mi...@korkalo.fi skype: keitsi- +358509104329 ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
