Re: [Monotone-devel] Time for a release
Am 05.06.10 01:26, schrieb Zack Weinberg: On Fri, Jun 4, 2010 at 3:53 PM, Thomas Keller m...@thomaskeller.biz wrote: So, what should we do here? The addition of -E for all other unices would mean that we'd tamper the test. I distinctly remember having to add -E on SunOS, and I would not be at all surprised if, well, anyone else who doesn't use GNU patch had the same behavior. Therefore I think we should unconditionally add -E. (change a test diff to use /dev/nul instead of /dev/nul, f.e., to see the effect - the file is no longer removed on compliant systems). I assume you meant /dev/nul instead of /dev/null there? No, I meant /dev/nul - try GNU patch and tamper the patch file to +++ /dev/nul (which is of course wrong) - then you'll see that empty files are kept and are only removed explicitely with -E. This is what I mean - we'd tamper the test if we add -E, because then we just test GNU patch to correctly interpret the -E option, but not to automatically remove the file if it is empty _and_ has the target /dev/null. By the way, standard English is e.g. not f.e. It expands to exempli gratia. Yes, that's Latin. I blame the French. I remember somebody has told me that a couple of years ago (was it you?) - I forget it from time to time - I should remember it now for the next couple of months, though :) Thomas. -- GPG-Key 0x160D1092 | tommyd3...@jabber.ccc.de | http://thomaskeller.biz Please note that according to the EU law on data retention, information on every electronic information exchange might be retained for a period of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en signature.asc Description: OpenPGP digital signature ___ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel
Re: [Monotone-devel] Time for a release
Am 05.06.10 18:26, schrieb Zack Weinberg: On Sat, Jun 5, 2010 at 4:59 AM, Thomas Keller m...@thomaskeller.biz wrote: I assume you meant /dev/nul instead of /dev/null there? No, I meant /dev/nul - try GNU patch and tamper the patch file to +++ /dev/nul (which is of course wrong) - then you'll see that empty files are kept and are only removed explicitely with -E. This is what I mean - we'd tamper the test if we add -E, because then we just test GNU patch to correctly interpret the -E option, but not to automatically remove the file if it is empty _and_ has the target /dev/null. Oh, I see what you mean. Well, is the exact behavior of the system 'patch' utility the focus of the test? I'm kinda inclined to doubt it, but I have lost the message that says which test we're talking about here... The test is diff_patch_drop and IMHO it exactly tests the proper removal of the files at the end. If not we could / should probably just remove the last two checks. Thomas. -- GPG-Key 0x160D1092 | tommyd3...@jabber.ccc.de | http://thomaskeller.biz Please note that according to the EU law on data retention, information on every electronic information exchange might be retained for a period of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en signature.asc Description: OpenPGP digital signature ___ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel
[Monotone-devel] checking for stray characters when parsing dates
I made a slight change to the date parsing code in ff193643616656b62a465d043676e3faf83418b7 to re-add the check for stray characters following the date that aren't matched by the specified format. I also added a simple check for this condition to the associated unit tests to make it clear what the problem is. I assume that this was removed inadvertently in a8147b11ee2d598835a4e1cec0e9782e4388e679 when the fixes for the lack of strptime (or anything seemingly equivalent) in win32 went in. Thanks for dealing with the win32 side of this Stephen, please let me know if that check was removed intentionally. Cheers, Derek ___ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel
