Re: [Mutt] #3681: Cannot use IPv6 literal address in IMAP/POP3 URL

[Mutt]

#3681: Cannot use IPv6 literal address in IMAP/POP3 URL
--+--
  Reporter:  evgeni   |  Owner:  kevin8t8
  Type:  enhancement  | Status:  assigned
  Priority:  minor|  Milestone:
 Component:  mutt |Version:
Resolution:   |   Keywords:
--+--
Changes (by kevin8t8):

 * Attachment "ticket-3681-v2.patch" added.


--
Ticket URL: 
Mutt 
The Mutt mail user agent

Re: [Mutt] #3681: Cannot use IPv6 literal address in IMAP/POP3 URL

[Mutt]

#3681: Cannot use IPv6 literal address in IMAP/POP3 URL
--+--
  Reporter:  evgeni   |  Owner:  kevin8t8
  Type:  enhancement  | Status:  assigned
  Priority:  minor|  Milestone:
 Component:  mutt |Version:
Resolution:   |   Keywords:
--+--

Comment (by kevin8t8):

 After thinking about it some more, I don't think it's correct to leave the
 "[]" delimiters in the ciss.host field.

 The reason this was done is because mutt converts it back and forth
 between a URL string, so instead the delimiters were removed inside
 raw_socket_open.  However there are other places in the code that use the
 host field, and they shouldn't all have the responsibility of stripping
 the "[]" off.

 I'm attaching v2 patch that removes the delimiter inside
 ciss_parse_userhost() but puts them back on inside url_ciss_tostring() if
 the host name contains a ':'.  This version of the patch therefor doesn't
 need to touch raw_socket_open().

--
Ticket URL: 
Mutt 
The Mutt mail user agent

Re: [Mutt] #3681: Cannot use IPv6 literal address in IMAP/POP3 URL

[Mutt]

#3681: Cannot use IPv6 literal address in IMAP/POP3 URL
--+--
  Reporter:  evgeni   |  Owner:  kevin8t8
  Type:  enhancement  | Status:  assigned
  Priority:  minor|  Milestone:
 Component:  mutt |Version:
Resolution:   |   Keywords:
--+--
Changes (by kevin8t8):

 * Attachment "ticket-3681.patch" added.


--
Ticket URL: 
Mutt 
The Mutt mail user agent

Re: [Mutt] #3681: Cannot use IPv6 literal address in IMAP/POP3 URL

[Mutt]

#3681: Cannot use IPv6 literal address in IMAP/POP3 URL
--+--
  Reporter:  evgeni   |  Owner:  kevin8t8
  Type:  enhancement  | Status:  closed
  Priority:  minor|  Milestone:
 Component:  mutt |Version:
Resolution:  fixed|   Keywords:
--+--
Changes (by Kevin McCarthy ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2a6bfdb9f869d8f07b453f6697c8de0246e24755"
 6817:2a6bfdb9f869]:
 {{{
 #!CommitTicketReference repository=""
 revision="2a6bfdb9f869d8f07b453f6697c8de0246e24755"
 Allow IPv6 literal addresses in URLs. (closes #3681)

 RFCs 2732 and 3986 specify a literal IPv6 address be surrounded by
 "[]".

 This patch removes the "[]" delimiters when parsing the URL, but adds
 them back in url_ciss_tostring() if the host name contains a ':'.

 Thanks to Evgeni Golov for the original patch.
 }}}

--
Ticket URL: 
Mutt 
The Mutt mail user agent

Re: [Mutt] #3681: Cannot use IPv6 literal address in IMAP/POP3 URL

[Mutt]

#3681: Cannot use IPv6 literal address in IMAP/POP3 URL
--+--
  Reporter:  evgeni   |  Owner:  kevin8t8
  Type:  enhancement  | Status:  assigned
  Priority:  minor|  Milestone:
 Component:  mutt |Version:
Resolution:   |   Keywords:
--+--

Comment (by kevin8t8):

 Thanks for the ping, Antonio.

 One problem with the original patch is that the mutt_socket.c changes
 corrupt the conn->account.host ifndef HAVE_LIBIDN.

 I'm attaching a modified version of the patch that simplifies the url.c
 changes and adds a strdup in mutt_socket.c.  I'll test it some more this
 weekend before pushing it.

--
Ticket URL: 
Mutt 
The Mutt mail user agent

Re: [Mutt] #3681: Cannot use IPv6 literal address in IMAP/POP3 URL

[Mutt]

#3681: Cannot use IPv6 literal address in IMAP/POP3 URL
--+--
  Reporter:  evgeni   |  Owner:  kevin8t8
  Type:  enhancement  | Status:  assigned
  Priority:  minor|  Milestone:
 Component:  mutt |Version:
Resolution:   |   Keywords:
--+--
Changes (by kevin8t8):

 * owner:  mutt-dev => kevin8t8
 * status:  new => assigned


--
Ticket URL: 
Mutt 
The Mutt mail user agent

Re: [Mutt] #3681: Cannot use IPv6 literal address in IMAP/POP3 URL

[Mutt]

#3681: Cannot use IPv6 literal address in IMAP/POP3 URL
--+--
  Reporter:  evgeni   |  Owner:  mutt-dev
  Type:  enhancement  | Status:  new
  Priority:  minor|  Milestone:
 Component:  mutt |Version:
Resolution:   |   Keywords:
--+--
Changes (by antonio@…):

 * cc: antonio@… (added)


--
Ticket URL: 
Mutt 
The Mutt mail user agent

Re: [Mutt] #3681: Cannot use IPv6 literal address in IMAP/POP3 URL

[Mutt]

#3681: Cannot use IPv6 literal address in IMAP/POP3 URL
--+--
  Reporter:  evgeni   |  Owner:  mutt-dev
  Type:  enhancement  | Status:  new
  Priority:  minor|  Milestone:
 Component:  mutt |Version:
Resolution:   |   Keywords:
--+--

Comment (by antonio@…):

 This seems simple enough, would you mind looking into it? thanks!

--
Ticket URL: 
Mutt 
The Mutt mail user agent

[Mutt] #3681: Cannot use IPv6 literal address in IMAP/POP3 URL

[Mutt]

#3681: Cannot use IPv6 literal address in IMAP/POP3 URL
-+--
 Reporter:  evgeni   |  Owner:  mutt-dev
 Type:  enhancement  | Status:  new
 Priority:  minor|  Milestone:
Component:  mutt |Version:
 Keywords:   |
-+--
 From Debian: https://bugs.debian.org/644992

 

 For tests with newly installed servers I usually access IMAP and/or
 POP3 Servers directly in the URL like this:

 mutt -fimap://user:pass@127.0.0.1
 mutt -fpop://user:pass@127.0.0.1

 This works correctly as expected.  Now I tried the same with an IPv6
 address like

 mutt -fimap://user:pass@'[::1]'
 mutt -fpop://user:pass@'[::1]'

 but with this I run into error messages and mutt terminates with the
 following messages:

 imap://user:pass@[::1] is an invalid IMAP path
 pop://user:pass@[::1] is an invalid POP path

 I also tried the same without brackets, but this also fails (as
 expected, because isn't defined whether the last colon is part of the
 IP or the separator of the port number).

 Maybe there is some other syntax expected, but I didn't find a hint in
 the manual...

 

 Attaching a (pretty ugly, IMHO) patch, that solves this issue for me.

-- 
Ticket URL: http://dev.mutt.org/trac/ticket/3681
Mutt http://www.mutt.org/
The Mutt mail user agent