Re: QRESYNC and CONDSTORE just pushed
On Mon, Aug 13, 2018 at 08:21:50AM -0700, Kevin J. McCarthy wrote: > On Sat, Aug 11, 2018 at 09:00:10PM -0700, Kevin J. McCarthy wrote: > > I've just pushed CONDSTORE and (experimental) QRESYNC IMAP support into > > master. > > > > If you run against an IMAP server that supports QRESYNC, I would > > greatly appreciate help testing. > > I just realized I left a stupid mistake in the code, so please hold off > on testing until I push a fix later this morning. I'll post when it's > fixed. Okay, I've pushed up a fix. Testers, please pull and rebuild asap. The brain is a strange thing. I meant to include that guard quite a while ago, but forgot in the midst of the refactor. Then last night I suddenly woke up and realized I had forgotten! :-o Anyway, I'm sure this won't be the last issue, but I'll try to get fixes pushed as quickly as I can for testers. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA signature.asc Description: PGP signature
Re: QRESYNC and CONDSTORE just pushed
On Sat, Aug 11, 2018 at 09:00:10PM -0700, Kevin J. McCarthy wrote: > I've just pushed CONDSTORE and (experimental) QRESYNC IMAP support into > master. > > If you run against an IMAP server that supports QRESYNC, I would > greatly appreciate help testing. I just realized I left a stupid mistake in the code, so please hold off on testing until I push a fix later this morning. I'll post when it's fixed. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA signature.asc Description: PGP signature
Re: QRESYNC and CONDSTORE just pushed
On 08:40 Sun 12 Aug, Kevin J. McCarthy wrote: > On Sun, Aug 12, 2018 at 12:08:34PM +0300, Consus wrote: > > On 21:00 Sat 11 Aug, Kevin J. McCarthy wrote: > > > I've just pushed CONDSTORE and (experimental) QRESYNC IMAP support into > > > master. > > > > > > If you run against an IMAP server that supports QRESYNC, I would > > > greatly appreciate help testing. > > > > > > (Note that Gmail doesn't seem to benefit from either of these > > > extensions. Enabling CONDSTORE in fact seems to slow Gmail down.) > > > > Performance boost is a second or two on 33k+ mailbox (I use lmdb and M.2 > > SSD for caching). Thank you for this patch, it improves things. > > Thanks Consus! With sleep_time set to 0 the switch is almost instant now ^_^
Re: QRESYNC and CONDSTORE just pushed
On Sun, Aug 12, 2018 at 12:08:34PM +0300, Consus wrote: > On 21:00 Sat 11 Aug, Kevin J. McCarthy wrote: > > I've just pushed CONDSTORE and (experimental) QRESYNC IMAP support into > > master. > > > > If you run against an IMAP server that supports QRESYNC, I would > > greatly appreciate help testing. > > > > (Note that Gmail doesn't seem to benefit from either of these > > extensions. Enabling CONDSTORE in fact seems to slow Gmail down.) > > Performance boost is a second or two on 33k+ mailbox (I use lmdb and M.2 > SSD for caching). Thank you for this patch, it improves things. Thanks Consus! By the way (for the list), I neglected to mention the extensions are enabled by the config vars $imap_condstore and $imap_qresync, which default unset. For CONDSTORE, Mutt is only using the FETCH CHANGEDSINCE extension, not the conditional store or other features. On servers which don't include MODSEQ in the initial UID FETCH (where it is not required), this can result in a slight speedup due to the flags not being included. QRESYNC can result in a larger speedup because it can completely skip the initial UID FETCH. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA signature.asc Description: PGP signature
Re: QRESYNC and CONDSTORE just pushed
On 21:00 Sat 11 Aug, Kevin J. McCarthy wrote: > I've just pushed CONDSTORE and (experimental) QRESYNC IMAP support into > master. > > If you run against an IMAP server that supports QRESYNC, I would > greatly appreciate help testing. > > (Note that Gmail doesn't seem to benefit from either of these > extensions. Enabling CONDSTORE in fact seems to slow Gmail down.) Performance boost is a second or two on 33k+ mailbox (I use lmdb and M.2 SSD for caching). Thank you for this patch, it improves things.
