Re: [nant-dev] Formatting, #Regions, and CVS Keywords
Title: Message Or perhaps we can start porting http://checkstyle.sourceforge.net/to .NET :-) - Original Message - From: Jeff McManus To: Nant-Developers (E-mail) Sent: Friday, March 14, 2003 6:55 PM Subject: RE: [nant-dev] Formatting, #Regions, and CVS Keywords Hmm, would it be meaningful to have a NAnt task to call Artistic Style automatically at build time? Has this been done already? -J. -Original Message-From: John Barstow [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 12, 2003 12:23 PMTo: 'Scott Hernandez'; Nant-Developers (E-mail)Subject: RE: [nant-dev] Formatting, #Regions, and CVS Keywords 2.) Reformat all files removing tabs and following the guidelines in the nant coding conventions. (http://sourceforge.net/docman/display_doc.php?docid=6080group_id=31650). Whoever is commiting changes may want to run Artistic Style (http://astyle.sourceforge.net/) on the source files to enforce code formattingconventions.
Re: [nant-dev] Formatting, #Regions, and CVS Keywords
Title: Message That would be pretty cool. Anyone who has time on their hands, please raise them... c'mon somebody has got to have some free time! I'd be happy to help too... :) - Original Message - From: Gert Driesen To: Jeff McManus ; Nant-Developers (E-mail) Sent: Friday, March 14, 2003 10:05 AM Subject: Re: [nant-dev] Formatting, #Regions, and CVS Keywords Or perhaps we can start porting http://checkstyle.sourceforge.net/to .NET :-)
Re: [nant-dev] Formatting, #Regions, and CVS Keywords
Jeff McManus wrote: Hmm, would it be meaningful to have a NAnt task to call Artistic Style automatically at build time? Has this been done already? I'm not so sure thats a good idea. Its nice to be able to do this automatically but on every build seems excessive. Ian -J. -Original Message- *From:* John Barstow [mailto:[EMAIL PROTECTED] *Sent:* Wednesday, March 12, 2003 12:23 PM *To:* 'Scott Hernandez'; Nant-Developers (E-mail) *Subject:* RE: [nant-dev] Formatting, #Regions, and CVS Keywords 2.) Reformat all files removing tabs and following the guidelines in the nant coding conventions. (http://sourceforge.net/docman/display_doc.php?docid=6080group_id=31650 http://sourceforge.net/docman/display_doc.php?docid=6080group_id=31650). Whoever is commiting changes may want to run Artistic Style (http://astyle.sourceforge.net/) on the source files to enforce code formatting conventions. --- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] Formatting, #Regions, and CVS Keywords
Well sure. Checkstyle does this with Ant today, though. I bet it's less tedious if it's only going to go through and mangle the file if the file was changed since the last build (the way you'd expect), but I'm only guessing here. -J. -Original Message- From: Ian MacLean [mailto:[EMAIL PROTECTED] Sent: Friday, March 14, 2003 12:19 PM To: Jeff McManus Cc: Nant-Developers (E-mail) Subject: Re: [nant-dev] Formatting, #Regions, and CVS Keywords Jeff McManus wrote: Hmm, would it be meaningful to have a NAnt task to call Artistic Style automatically at build time? Has this been done already? I'm not so sure thats a good idea. Its nice to be able to do this automatically but on every build seems excessive. Ian -J. -Original Message- *From:* John Barstow [mailto:[EMAIL PROTECTED] *Sent:* Wednesday, March 12, 2003 12:23 PM *To:* 'Scott Hernandez'; Nant-Developers (E-mail) *Subject:* RE: [nant-dev] Formatting, #Regions, and CVS Keywords 2.) Reformat all files removing tabs and following the guidelines in the nant coding conventions. (http://sourceforge.net/docman/display_doc.php?docid=6080grou p_id=31650 http://sourceforge.net/docman/display_doc.php?docid=6080group_id=31650 ). Whoever is commiting changes may want to run Artistic Style (http://astyle.sourceforge.net/) on the source files to enforce code formatting conventions. --- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] Formatting, #Regions, and CVS Keywords
I want to reformat all the filesand do the following: 1.) Wrap the license info at the top of the filein a #region, which will make editing with vs.net (and others I believe). 2.) Reformat all files removing tabs and following the guidelines in the nant coding conventions.(http://sourceforge.net/docman/display_doc.php?docid=6080group_id=31650). 3.) Insert cvs substitutionkeywords that will help build ahistory log in each file. (http://www.cvshome.org/docs/manual/cvs_12.html) (I will look into making this part of the xml docs for revision history.) So, beforewe go through this work, any one have any moreideas? If this doesn't happen now, I would like to see it happen before a .9 release. Is there anything else we should do (other than coding, code reviews, testing, and releases :) along these lines?
Re: [nant-dev] Formatting, #Regions, and CVS Keywords
Scott Hernandez wrote: I want to reformat all the files and do the following: 1.) Wrap the license info at the top of the file in a #region, which will make editing with vs.net (and others I believe). +1 2.) Reformat all files removing tabs and following the guidelines in the nant coding conventions.(http://sourceforge.net/docman/display_doc.php?docid=6080group_id=31650 http://sourceforge.net/docman/display_doc.php?docid=6080group_id=31650). I went thru and did this for a bunch of files in the core recently. It was mostly pretty good. A lot of the files in the test directories still have tabs in them. 3.) Insert cvs substitution keywords that will help build a history log in each file. (http://www.cvshome.org/docs/manual/cvs_12.html) (I will look into making this part of the xml docs for revision history.) Can you give an example of what this will look like in a source file. I didn't find the reference too clear on that. So, before we go through this work, any one have any more ideas? If this doesn't happen now, I would like to see it happen before a .9 release. Is there anything else we should do (other than coding, code reviews, testing, and releases :) along these lines? I've been going thru making each assembly CLS compliant as per Gerts suggestion. Its just a matter of setting the CLSCompliant attribute assemblyinfo and then fixing the resulting compiler errors. Ian --- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Formatting, #Regions, and CVS Keywords
For 1 and 2: This is a great idea. What about having a tool in CVS that would use the RegEx classes to ensure that the file structure matches (roughly) the structure we're expecting, ie: replace all tabs w/spaces, replace all text before the first using keyword with the #region-wrapped license, etc. Just a comment about the $Log$ keyword - the CVS in-line version log is a little bit of a pain to handle sometimes. I think it would be okay if wrapped in a #region, but some issues may crop up (especially with regards to merging/branching). This page mentions some of the issues with the $Log$ keyword: http://developer.apple.com/darwin/tools/cvs/cederquist/cvs_96.html On Wed, 2003-03-12 at 02:24, Scott Hernandez wrote: I want to reformat all the files and do the following: 1.) Wrap the license info at the top of the file in a #region, which will make editing with vs.net (and others I believe). 2.) Reformat all files removing tabs and following the guidelines in the nant coding conventions.(http://sourceforge.net/docman/display_doc.php?docid=6080group_id=31650). 3.) Insert cvs substitution keywords that will help build a history log in each file. (http://www.cvshome.org/docs/manual/cvs_12.html) (I will look into making this part of the xml docs for revision history.) So, before we go through this work, any one have any more ideas? If this doesn't happen now, I would like to see it happen before a .9 release. Is there anything else we should do (other than coding, code reviews, testing, and releases :) along these lines? -- Matthew Mastracci [EMAIL PROTECTED] --- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Formatting, #Regions, and CVS Keywords
Matthew Mastracci wrote: Just a comment about the $Log$ keyword - the CVS in-line version log is a little bit of a pain to handle sometimes. I think it would be okay if wrapped in a #region, but some issues may crop up (especially with regards to merging/branching). This page mentions some of the issues with the $Log$ keyword: http://developer.apple.com/darwin/tools/cvs/cederquist/cvs_96.html I have a concern with this too. What do we gain thats not in the logs ? The docs imply that its only useful if you move the file out of CVS - which we aren't going to do in a hurry I wouldn't have thought. I'd prefer not to have that information in the source file if it is already stored alsewhere. Ian --- This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] Formatting, #Regions, and CVS Keywords
2.) Reformat all files removing tabs and following the guidelines in the nant coding conventions. (http://sourceforge.net/docman/display_doc.php?docid=6080group_id=31650). Whoever is commiting changes may want to run Artistic Style (http://astyle.sourceforge.net/) on the source files to enforce code formattingconventions.
