Re: [nant-dev] Trivial modifications to ConsoleRunner.cs
After seeing new Scott's latest changes it looks like that code has been moved to ConsoleDriver.cs. So I'll look at adding the changes there. Ian Brian, thanks for your contribution I just had a brief skim thru the code and it looks OK. As for style conventions just the usual. 1. open braces on the same line 2. use spaces not tabs for indenting. Visual studio will by default get both of these wrong if thats what you're using. one other thing. I notice you changed if(project != null) to if(null != project) This isn't really necessary in C# as the expression (project = null) does not evaluate to bool as it would in C++. I'll commit this later today Ian This was purely motivated by me wanting to be able to use -f: instead of -buildfile:. Bold! :) options: -help print this message -projecthelpprint project help information -buildfile:file use given buildfile -file:file'' -f:file '' -find search parent directories for buildfile -D:property=value use value for given property -verbose, -vdisplays more information during build process -logger:use given class name as logger -logfile:, -l: use value as name of log output file I also did some thoroughly anal-retentive refactoring. (Made a CommandLineOption enum, moved the above console output into its own function.) Don't know that these changes warrant any additions to Nant.Console.Tests, but if the Council of Elders feels it appropriate, I'd be happy to oblige. :) Oh, and I would appreciate being alerted to any style/convention violations I may have committed. Brian Deacon _ MSN 8: advanced junk mail protection and 2 months FREE*. http://join.msn.com/?page=features/junkmail --- This SF.NET email is sponsored by: Take your first step towards giving your online business a competitive advantage. Test-drive a Thawte SSL certificate - our easy online guide will show you how. Click here to get started: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0027en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers --- This SF.NET email is sponsored by: Take your first step towards giving your online business a competitive advantage. Test-drive a Thawte SSL certificate - our easy online guide will show you how. Click here to get started: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0027en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Trivial modifications to ConsoleRunner.cs
Is new Scott an improvement on the old Scott? :) Yah, I thought maybe Scott and I had crossed paths based on his e-mail... but I'm still in the process of beating cvs into submission on my work box and sf's web-based CVS browser has been finicky of late. (Anybody know what the deal is with that, btw?) Question re: the echo task. I noticed echo message=foo / rather than echofoo/echo. Was this a design decision, or a quick and dirty to take advantage of TaskAtrributeAttribute? (Can you tell I'm porting my ant script?) :) How do folks feel about supporting either/or? echo message=This is still supported. / echoThis would then be supported./echo echo message=Naughty ScriptThis would cause a BuildException./echo (I'm volunteering, btw, not feature nagging.) Personally, I'm fond of the echo task as the poor-man's online help, and being able to preserve the whitespace inside echo/echo comes in handy for that. Brian (Oh, and thanks for the tips on style, Ian. 'preciated.) From: Ian MacLean [EMAIL PROTECTED] CC: Brian Deacon [EMAIL PROTECTED], [EMAIL PROTECTED] Subject: Re: [nant-dev] Trivial modifications to ConsoleRunner.cs Date: Wed, 15 Jan 2003 12:43:15 +1100 After seeing new Scott's latest changes it looks like that code has been moved to ConsoleDriver.cs. So I'll look at adding the changes there. Ian Brian, thanks for your contribution I just had a brief skim thru the code and it looks OK. As for style conventions just the usual. 1. open braces on the same line 2. use spaces not tabs for indenting. Visual studio will by default get both of these wrong if thats what you're using. one other thing. I notice you changed if(project != null) to if(null != project) This isn't really necessary in C# as the expression (project = null) does not evaluate to bool as it would in C++. I'll commit this later today Ian This was purely motivated by me wanting to be able to use -f: instead of -buildfile:. Bold! :) options: -help print this message -projecthelpprint project help information -buildfile:file use given buildfile -file:file'' -f:file '' -find search parent directories for buildfile -D:property=value use value for given property -verbose, -vdisplays more information during build process -logger:use given class name as logger -logfile:, -l: use value as name of log output file I also did some thoroughly anal-retentive refactoring. (Made a CommandLineOption enum, moved the above console output into its own function.) Don't know that these changes warrant any additions to Nant.Console.Tests, but if the Council of Elders feels it appropriate, I'd be happy to oblige. :) Oh, and I would appreciate being alerted to any style/convention violations I may have committed. Brian Deacon _ MSN 8: advanced junk mail protection and 2 months FREE*. http://join.msn.com/?page=features/junkmail --- This SF.NET email is sponsored by: Take your first step towards giving your online business a competitive advantage. Test-drive a Thawte SSL certificate - our easy online guide will show you how. Click here to get started: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0027en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers --- This SF.NET email is sponsored by: Take your first step towards giving your online business a competitive advantage. Test-drive a Thawte SSL certificate - our easy online guide will show you how. Click here to get started: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0027en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers _ The new MSN 8: smart spam protection and 2 months FREE* http://join.msn.com/?page=features/junkmail --- This SF.NET email is sponsored by: Take your first step towards giving your online business a competitive advantage. Test-drive a Thawte SSL certificate - our easy online guide will show you how. Click here to get started: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0027en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Trivial modifications to ConsoleRunner.cs
Scott Hernandez wrote: +1 on echo supporting inline (text node) text. yeah me too. Good idea. Ian I don't use the web based browser much, but it seems to work for me today when I was checking on my changes. - Original Message - From: Brian Deacon [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Sent: Tuesday, January 14, 2003 6:11 PM Subject: Re: [nant-dev] Trivial modifications to ConsoleRunner.cs Is new Scott an improvement on the old Scott? :) Yah, I thought maybe Scott and I had crossed paths based on his e-mail... but I'm still in the process of beating cvs into submission on my work box and sf's web-based CVS browser has been finicky of late. (Anybody know what the deal is with that, btw?) Question re: the echo task. I noticed echo message=foo / rather than echofoo/echo. Was this a design decision, or a quick and dirty to take advantage of TaskAtrributeAttribute? (Can you tell I'm porting my ant script?) :) How do folks feel about supporting either/or? echo message=This is still supported. / echoThis would then be supported./echo echo message=Naughty ScriptThis would cause a BuildException./echo (I'm volunteering, btw, not feature nagging.) Personally, I'm fond of the echo task as the poor-man's online help, and being able to preserve the whitespace inside echo/echo comes in handy for that. Brian (Oh, and thanks for the tips on style, Ian. 'preciated.) --- This SF.NET email is sponsored by: Take your first step towards giving your online business a competitive advantage. Test-drive a Thawte SSL certificate - our easy online guide will show you how. Click here to get started: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0027en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
RE: [nant-dev] Trivial modifications to ConsoleRunner.cs
Well, that's enough approval for me to take a whack at it. :) (Appears to be a network issue with cvs.sourceforge.net... can't connect on 80 and a traceroute dies at the last hop. Curious... you'd think that would hurt generic cvs access as well.) :shrug Brian -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] On Behalf Of Ian MacLean Sent: Tuesday, January 14, 2003 7:39 PM To: Scott Hernandez Cc: Brian Deacon; [EMAIL PROTECTED] Subject: Re: [nant-dev] Trivial modifications to ConsoleRunner.cs Scott Hernandez wrote: +1 on echo supporting inline (text node) text. yeah me too. Good idea. Ian I don't use the web based browser much, but it seems to work for me today when I was checking on my changes. - Original Message - From: Brian Deacon [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Sent: Tuesday, January 14, 2003 6:11 PM Subject: Re: [nant-dev] Trivial modifications to ConsoleRunner.cs Is new Scott an improvement on the old Scott? :) Yah, I thought maybe Scott and I had crossed paths based on his e-mail... but I'm still in the process of beating cvs into submission on my work box and sf's web-based CVS browser has been finicky of late. (Anybody know what the deal is with that, btw?) Question re: the echo task. I noticed echo message=foo / rather than echofoo/echo. Was this a design decision, or a quick and dirty to take advantage of TaskAtrributeAttribute? (Can you tell I'm porting my ant script?) :) How do folks feel about supporting either/or? echo message=This is still supported. / echoThis would then be supported./echo echo message=Naughty ScriptThis would cause a BuildException./echo (I'm volunteering, btw, not feature nagging.) Personally, I'm fond of the echo task as the poor-man's online help, and being able to preserve the whitespace inside echo/echo comes in handy for that. Brian (Oh, and thanks for the tips on style, Ian. 'preciated.) --- This SF.NET email is sponsored by: Take your first step towards giving your online business a competitive advantage. Test-drive a Thawte SSL certificate - our easy online guide will show you how. Click here to get started: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0027en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers --- This SF.NET email is sponsored by: Take your first step towards giving your online business a competitive advantage. Test-drive a Thawte SSL certificate - our easy online guide will show you how. Click here to get started: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0027en ___ Nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
