Re: Summary of meeting between NET-SNMP devs and ICEI
Bart Van Assche <bvanass...@acm.org>: > Which of the following files under include/net-snmp/system do you think are > still relevant today? No changes other than trivial changes have been made > to these files in the past ten years: > > dynix.h irix.h osf5.h svr5.h ultrix.h LOL. I've seen this movie before. It's very common in codebases of this age and size range. Nuke them from orbit, sez I. -- http://www.catb.org/~esr/;>Eric S. Raymond My work is funded by the Internet Civil Engineering Institute: https://icei.org Please visit their site and donate: the civilization you save might be your own. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Summary of meeting between NET-SNMP devs and ICEI
Robert Story <rst...@freesnmp.com>:
>And as far as supported configurations, we're
> very big on backwards compatibility.
I think you are spending more effort on this than field conditions justify.
And there is a cost you probably have not audited.
I learned my Unix programming chops back in the 1980s when having thickets
of portability #ifdefs was definitely the right thing to do because there
was so much variation in platform APIs. I too acquired the reflex of never
throwing any of those out, just in case
This attitude has been obsolete for at least 9 years.
The reason I'm that precise about it is because of a learning
experience I had while maintaining GPSD in 2009. The important fact
about GPSD in this context is that it is deployed on a *huge* breadth
of hardware, not just datacenter machines but laptops and smartphones
and embedded gear of all sorts.
Came the day I was doing some routine cleanup, I tripped over a port
#ifdef for a species of big-iron Unix that will never again walk the
earth, and the following thought intruded: "What? Is this really needed?"
Slightly amazed at my own heresy, I continued to think "You know, this
is a build variant I can no longer test. Why am I letting it clutter
up my code and complicate my build recipe?"
*blink*
Because I have a reflex about these things. I screen out their complexity
cost by habit.
So I went on an #ifdef hunt. I had never really totaled up the number of
LOC added by alternate build options before. It was significant.
My next step was to ask how I could reduce this. The obvious thing to
try was to assume that the standards people won the war - anywhere I
found an #ifdef where one of the paths assumed SuSv2+C99 and rip out
all the other paths.
When I did that, the resulting patch was large but obviously reversible.
So I tried the bold thing. I removed all that code and shipped a point release.
My reasoning was thus: point releases are cheap. This change, if it's
bad, will throw an error at compile time well before it disrupts any
runtime behavior. I can put back the pieces I actually need when the
build failures hit my bugtracker.
I never saw even one.
And that's how I learned that the standards people had succeeded.
Six years later I preformed a similar cruftectomy on the NTP code.
Again, never a peep of complaint from anyone downstream.
The benefits: (1) fewer LOC of more readable code, (2) fewer test paths,
(3) simpler build recipe.
> As 5.8 is getting really close to going out the door, this type of
> cleanup likely won't make it into that release.
>
>
> Got any cmake experts? One of the planned items for 5.9 is moving
> to cmake. The bulk of the work is done (patches from VMware against
> 5.7), but work will be needed to integrate to master and put on the
> finishing touches.
I occasionally used cmake when I was on the Battle for Wesnoth project.
I don't like it. Not so much because cmake is bad in itself, it isn't.
It's a reasonable implementation of its design premises.
The problem is that one of cmake's premises is being a two-phase builder,
generating makefiles, rather than a one-phase builder that directly executes
its recipe. This repeats the autoconf tragedy, making buld-failure
diagnosis *far* more complex and gnarly than it needs to be.
I have come to believe that all two-phase build engines should be shot
with silver bullets and buried at crossroads with stakes through
their hearts.
--
http://www.catb.org/~esr/;>Eric S. Raymond
My work is funded by the Internet Civil Engineering Institute: https://icei.org
Please visit their site and donate: the civilization you save might be your own.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: IRC chat to help our new guard get on board?
Keith Mendoza <panthe...@gmail.com>:
> So far, this is the time that may work for everyone if we do it the
> week of April 8 (UTC and US time zones): 5:30 AM PDT/6:30 AM MDT/7:30
> AM CDT/8:30 AM EDT/12:30 PM UTC--6:00 AM PDT/7:00 AM MDT/8:00 AM
> CDT/9:00 AM EDT/1:00 PM UTC.
>
> Eric,
> How do you feel about having the meeting the week of April 16 to see
> if we can get better timing and more people to come?
I don't have a preference. I think you're collecting better information
to base a decision on than I am.
--
http://www.catb.org/~esr/;>Eric S. Raymond
My work is funded by the Internet Civil Engineering Institute: https://icei.org
Please visit their site and donate: the civilization you save might be your own.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
IRC chat to help our new guard get on board?
ICEI has a #newguard channel on freenode where its "new guard" - programmers who want to get involved in infrastructure work - hang out. Some of them are interested in contributing to net-snmp. Joining Ian on the bug triage would be an obvious way to on-board them, but that will work better if they have more sense of the scope and direction of the project and feel like they know its key people. We'd like to set up a time for a short IRC conference for them to get to know your project's senior devs and vice-versa. Ian and Keith and I will be there, of course. We can talk about what needs to be done and recruit you some more help. We'd like to especially invite your project owner and release manager and tech lead (understanding that those might be the same person) but any net-snmp dev would be welcome and the more the better If you're willing to attend, please respond with your name, your project role, and some indication of when you could be free for a 45-minute IRC chat within the next ten days. -- http://www.catb.org/~esr/;>Eric S. Raymond It would be thought a hard government that should tax its people one tenth part. -- Benjamin Franklin -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Fix patch for SF bug 2833
Bart Van Assche <bvanass...@acm.org>: > I think that variable.magic is only needed if the old MIB registration API is > used (register_mib() etc.). That API was deprecated more than ten years ago. > I think that we should tell users to move away from that API rather than > helping them with fixing the shortcomings of that API. 2833 should probably be maeked WONTFIX abd closed with that exolamation, then. -- http://www.catb.org/~esr/;>Eric S. Raymond My work is funded by the Internet Civil Engineering Institute: https://icei.org Please visit their site and donate: the civilization you save might be your own. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Patch for build instructions
Bill Fenner <fen...@gmail.com>:
> On Thu, Mar 22, 2018 at 3:26 PM, Eric S. Raymond <e...@thyrsus.com> wrote:
>
> > Or possibly it might have but your build system messed me over. I don't
> > trust
> > autoconf as far as I can throw it.
> >
>
> I understand someone's done a conversion to cmake. Does that make you
> happier or vomityer?
Very slightly happier - at least cmake's implementation isn't nasty crocks
and kludges all the way down like autoconf's is.
Alas, cmake shares one of autoconf's fundamental design flaws:
It's two-phase system that works by generating Makefiles. This makes
good diagnostics basically impossible - any point of failure in the make
execution is too decoupled from the originating recipe.
Two-phase systems have other flaws too. They make it much harder,
maybe impossible, to parallelize a build in a way that's provably
correct with respect to dependencies. (I think this could be done in
theory but all two-phase systems I know of seem incapable of getting
it right in practice.)
I greatly prefer one-phase systems like scons or waf that directly
interpret the recipe. They easily avoid both of the practical
problems I just mentioned - in particular, if you know what you're
doing you can get provably correct parallelism from a toposort
of the dependency graph.
I think waf is currently the best of breed - it's what we've been
using on NTPsec and I find its speed and parallelization performance
is unmatched - but I acknowledge one serious problem with it; the
documentation is terrible. Very comprehensive if you can think like
the designer but for anyone else it might as well be written in
Sanskrit mixed with tensor calculus. Makes the learning curve a bit
rough.
--
http://www.catb.org/~esr/;>Eric S. Raymond
My work is funded by the Internet Civil Engineering Institute: https://icei.org
Please visit their site and donate: the civilization you save might be your own.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Patch for build instructions
Bill Fenner <fen...@gmail.com>: > Not to mention that "install libperl-dev" means nothing on Solaris, or > FreeBSD, or MacOS, or other supported systems. OK, but are you going to let the better be the enemy of the good, or merge that patch and improve on it based on your experience? I'm not throwing these doc patches at you with a belief that they're in themselves final answers. Rather, they're to point out exactly where the defect is and hopefully stimulate a response. (I'd be much more careful about what I sent as a code patch.) -- http://www.catb.org/~esr/;>Eric S. Raymond My work is funded by the Internet Civil Engineering Institute: https://icei.org Please visit their site and donate: the civilization you save might be your own. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Patch for build instructions
Bart Van Assche <bvanass...@acm.org>: > On 03/21/18 19:47, Eric S. Raymond wrote: > >>From 2ffbdd9e8f15eb3e3dc985ab3aa0a12d798e4b78 Mon Sep 17 00:00:00 2001 > >From: "Eric S. Raymond" <e...@thyrsus.com> > >Date: Wed, 21 Mar 2018 20:24:40 -0400 > >Subject: [PATCH] INSTALL: Fix for build instructions. > > > >Mention a prerequisite that will trip people up under Ubuntu. > >--- > > INSTALL | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > >diff --git a/INSTALL b/INSTALL > >index 24f8d6c..aad9099 100644 > >--- a/INSTALL > >+++ b/INSTALL > >@@ -27,7 +27,8 @@ QUICK INSTRUCTIONS > > (due to prompting done by the configure script, this is very rarely > >necessary.) > >- 3) make > >+ 3) Run make. If the build fails with a complaint that it can't resolve > >+ -lperl, install libperl-dev and try again. > >4) Run the next command as root: > >5) make install > > This should be elaborated further: another alternative is to pass > --disable-embedded-perl to the configure script. I actually tried that before installing libperl-dev. It didn't seem to work. Or possibly it might have but your build system messed me over. I don't trust autoconf as far as I can throw it. -- http://www.catb.org/~esr/;>Eric S. Raymond My work is funded by the Internet Civil Engineering Institute: https://icei.org Please visit their site and donate: the civilization you save might be your own. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Unstable tests
Bart Van Assche <bvanass...@acm.org>: > Hello Eric, > > These are the only two tests that sometimes fail on my test setup. Whether > or not these tests pass depends on your DNS server. If I e.g. add > "nameserver 8.8.8.8" as the first entry in /etc/resolv.conf then these tests > pass on my setup. I think the reason is that the domain names used by that > test resolve into 127.0.0.x and because some DNS servers filter these > results. > > Bart. You guys have been at this too long. You're failing to document your assumptions. >From 6cd949342a65ff2260253bca234bfa08f8e3b5c2 Mon Sep 17 00:00:00 2001 From: "Eric S. Raymond" <e...@thyrsus.com> Date: Thu, 22 Mar 2018 15:20:21 -0400 Subject: [PATCH] INSTALL: explain workaround for comsec test failures. --- INSTALL | 11 +++ 1 file changed, 11 insertions(+) diff --git a/INSTALL b/INSTALL index aad9099..9bcd65a 100644 --- a/INSTALL +++ b/INSTALL @@ -6,6 +6,7 @@ TABLE OF CONTENTS * Net-SNMP Specific Information Long (but you should read these) Instructions Installing the Perl/SNMP Module + Tests * Compilers and Options Compiling For Multiple Architectures Installation Names @@ -155,6 +156,16 @@ Net-SNMP libraries and demon applications. make test make install (as root) +Tests += + +The ordinary self-test sequence can be invoked with "make test". There +are more comprehensive options. + +Spurious failures on the "comsec" tests can be due to misconfigured +DNS upstream of you. A workaround is to point your DNS server at a +non-broken one. Adding "nameserver 8.8.8.8" as the first entry in +/etc/resolv.conf will do. Compilers and Options ===== -- 2.7.4 -- http://www.catb.org/~esr/;>Eric S. Raymond My work is funded by the Internet Civil Engineering Institute: https://icei.org Please visit their site and donate: the civilization you save might be your own. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Unstable tests
Bill Fenner <fen...@gmail.com>: > So before, you meant you failed test 31 of the "com2sec directive" suite? I'm not even sure that's what I saw. My apologies, I'm new to this code and the test output is somwhat confusing. > Try "cd testing; SNMP_VERBOSE=2 ./RUNFULLTESTS -v -r T070com2sec" to get > more detail about why it failed. > > Test 30 and 31 could fail if your DNS resolver performs "helpful" NXDOMAIN > remapping - e.g., does > > ping no.such.address. > return > ping: unknown host no.such.address. > or does it return something like > PING no.such.address (92.242.140.21) 56(84) bytes of data. The latter. I guess that's the problem. > There's an assumption in the test suite that the DNS server is not insane, > but of course most home ISPs provide insane DNS servers by default. Most > providers give you the option to use a sane one, or of course you could > change your /etc/resolv.conf to point to a sane public DNS provider. I have a Verizon FIOS business account. The rot has spread to more than "home" service. This problem should be documented where people running the tests will see it. -- http://www.catb.org/~esr/;>Eric S. Raymond My work is funded by the Internet Civil Engineering Institute: https://icei.org Please visit their site and donate: the civilization you save might be your own. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Fix patch for SF bug 2833
Bart Van Assche <bvanass...@acm.org>: > This patch changes a data structure in a public header file and hence breaks > the ABI. This is something we could do for Net-SNMP 5.8 since there has not > yet been any 5.8 release but it's something we can't do for older Net-SNMP > versions. I withdraw the suggestion. Procedurally, do you have an official queue of patches deferred to the next major release, or a repository branch for them? Putting the patch there would be a reasonable way to close 2833. -- http://www.catb.org/~esr/;>Eric S. Raymond My work is funded by the Internet Civil Engineering Institute: https://icei.org Please visit their site and donate: the civilization you save might be your own. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
C99 (was: Re: Fix patch for SF bug 2833)
Bill Fenner <fen...@gmail.com>: > On Thu, Mar 22, 2018 at 9:16 AM, Eric S. Raymond <e...@thyrsus.com> wrote: > > > On the other hand, I question whether the extra overhead is a real > > issue in 2018. > > > I have the same question, but know that I have no useful opinion here - my > "embedded system" ships with 4 gigs minimum, but the project has more use > cases than mine. Bart's objection about changing the public ABI is a showstopper and I wihdraw the suggestion. On the other hand... >For example, the project did decide to back off from introducing c99 >constructs. *This* is an issue about which I know something important that does not seem to have percolated into general knowledge yet. I lead the GPSD project, a daemon for handling GPSes and other geolocation sources. It's deployed *everywhere* - smartphones, driverless cars, marine navigation systems, main battle tanks, drones and UAVs, first-responder comm gear, you name it. If GPSD makes an assumption that breaks any Unix build chain or portability anywhere, I get a complaint right quick. I've fielded dozens of these. Maybe the weirdest one was due to actual signed chars on a 360 mainframe. There came a point at which I got tired of seeing legacy ifdefs from ancient big iron in my codebase. Thought about my options, decided to move to assuming C99 and SuSv2. I shipped a point release on this premise expecting at least some minor pushback from some odd legacy environment. I heard not a peep, and never have since. And this was in 2009. If that's not enough, since 2015 I have led the NTPsec project. Based on GPSD experience we made the same decision to assume a C99/SuSv2 base. With no problems whatsoever except that on old versions of MacOS one of the time primitives is broken. That's how I learned that the standards people won. Our traditional twitchiness about tossing out any portability shim back to the year zero is obsolete. And bear in mind that GPSD/NTPsec probably exercises a wider swathe of the host API than snmpd does, so the test has been more stringent. GPSD has to get deep into odd corners of the tty driver and kernel PPS; NTPsec gets even further into system clock handling. I can say with confidence that assuming C99 is *very* safe in 2018. -- http://www.catb.org/~esr/;>Eric S. Raymond My work is funded by the Internet Civil Engineering Institute: https://icei.org Please visit their site and donate: the civilization you save might be your own. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Fix patch for SF bug 2833
Bill Fenner <fen...@gmail.com>:
> I don't think the patch is the issue. There are two questions to be
> addressed first:
>
> 1. For the embedded environment, is it acceptable to use an extra several
> bytes for this (or is there a way to rearrange the struct so that padding
> reduces the extra cost)?
A couple of instances I looked at could be repacked to avoid the 1 char of slop
using techniques I described in
http://www.catb.org/esr/structure-packing/
On the other hand, I question whether the extra overhead is a real
issue in 2018. I have old-school reflexes about this myself, but
even embedded systems are shipping with a lot more RAM than they used to.
Unless variable instances are being spawned by the tens of thousands
it's hard to imagine this being a real problem. And how likely is
that on a resource-constrained system?
I actually did think about repacking the struct (see: old-school reflexes)
but decided not to in order to avoid compromising the readability by
separating the two elements that seem to be in all variants. Also to make
the patch itself easy to understand.
> 2. Is it reasonable to have more than 255 variables in a single
> registration, or should the reporter just split up his registration into
> multiple groups, each with less than 255 variables?
That I have no opinion on. My domain knowledge of SNMP and its usage is
very limited.
--
http://www.catb.org/~esr/;>Eric S. Raymond
My work is funded by the Internet Civil Engineering Institute: https://icei.org
Please visit their site and donate: the civilization you save might be your own.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: Unstable tests
Bill Fenner <fen...@gmail.com>:
> The configure script test can fail if you've regenerated it using autoconf
> but not using 2.68.
Running 2.69.
I never ran autoconf explicitly, just configure as per instructions.
> By "test 31" do you mean "snmpv1 traps are sent by snmpd API"?
Now I'm getting a different result, which is a little disturbing in itself:
com2sec directive (Wstat:
256 Tests: 31 Failed: 1)
Failed test: 30
Non-zero exit status: 1
Files=76, Tests=327, 109 wallclock secs ( 0.28 usr 0.07 sys + 13.58 cusr 4.74
csys = 18.67 CPU)
Result: FAIL
We failed these 1 tests:
com2sec directive (
/home/esr/software/net-snmp-code/testing/fulltests/default/T070com2sec_simple )
> What branch did you use to run your tests?
master
--
http://www.catb.org/~esr/;>Eric S. Raymond
My work is funded by the Internet Civil Engineering Institute: https://icei.org
Please visit their site and donate: the civilization you save might be your own.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Unstable tests
Ian and I note that the test suite seems a bit compromised. On current Ubuntu, Intel x86_64, stock build, two tests - 1 and 31 fail out of the box. We see those same failures on ARM (a RasPi 3). But Ian's laptop gives a diffeent and larger list of errors. Are there known pastform dependencies in the tests? Is it known that 1 and 31 can fail on a stock build? -- http://www.catb.org/~esr/;>Eric S. Raymond All forms of government are pernicious, including good government. -- Edward Abbey -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Patch for build instructions
>From 2ffbdd9e8f15eb3e3dc985ab3aa0a12d798e4b78 Mon Sep 17 00:00:00 2001 From: "Eric S. Raymond" <e...@thyrsus.com> Date: Wed, 21 Mar 2018 20:24:40 -0400 Subject: [PATCH] INSTALL: Fix for build instructions. Mention a prerequisite that will trip people up under Ubuntu. --- INSTALL | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/INSTALL b/INSTALL index 24f8d6c..aad9099 100644 --- a/INSTALL +++ b/INSTALL @@ -27,7 +27,8 @@ QUICK INSTRUCTIONS (due to prompting done by the configure script, this is very rarely necessary.) - 3) make + 3) Run make. If the build fails with a complaint that it can't resolve + -lperl, install libperl-dev and try again. 4) Run the next command as root: 5) make install -- 2.7.4 -- http://www.catb.org/~esr/;>Eric S. Raymond "You have taught us much. Come with us and join the movement." "This movement of yours, does it have slogans?" inquired the Chink. "Right on!" they cried. And they quoted him some. "Your movement, does it have a flag?" asked the Chink. "You bet!" and they described their emblem. "And does your movement have leaders?" "Great leaders." "Then shove it up your butts," said the Chink. "I have taught you nothing." -- Tom Robbins, "Even Cowgirls Get The Blues" -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Fix patch for SF bug 2833
>From 54e79ba66327bdb54f97f457d76531f657ec546d Mon Sep 17 00:00:00 2001
From: "Eric S. Raymond" <e...@thyrsus.com>
Date: Wed, 21 Mar 2018 22:22:29 -0400
Subject: [PATCH] include/net-snmp/agent/{snmp_vars.h,var_struct.h}: address SF
bug 2833.
Tests pass,
---
include/net-snmp/agent/snmp_vars.h | 2 +-
include/net-snmp/agent/var_struct.h | 12 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/net-snmp/agent/snmp_vars.h
b/include/net-snmp/agent/snmp_vars.h
index bd27eeb..b2f2f8f 100644
--- a/include/net-snmp/agent/snmp_vars.h
+++ b/include/net-snmp/agent/snmp_vars.h
@@ -101,7 +101,7 @@ PERFORMANCE OF THIS SOFTWARE.
#define INST 0x /* used to fill out the instance field of the
variables table */
struct variable {
-u_char magic; /* passed to function as a hint */
+u_short magic; /* passed to function as a hint */
chartype; /* type of variable */
/*
* See important comment in snmp_vars.c relating to acl
diff --git a/include/net-snmp/agent/var_struct.h
b/include/net-snmp/agent/var_struct.h
index 15b5770..10bf4ae 100644
--- a/include/net-snmp/agent/var_struct.h
+++ b/include/net-snmp/agent/var_struct.h
@@ -52,7 +52,7 @@ typedef struct netsnmp_subtree_s {
* application. The first 5 elements of the structure must remain constant.
*/
struct variable1 {
-u_char magic; /* passed to function as a hint */
+u_short magic; /* passed to function as a hint */
u_char type; /* type of variable */
u_short acl;/* access control list for variable */
FindVarMethod *findVar;/* function that finds variable */
@@ -61,7 +61,7 @@ struct variable1 {
};
struct variable2 {
-u_char magic; /* passed to function as a hint */
+u_short magic; /* passed to function as a hint */
u_char type; /* type of variable */
u_short acl;/* access control list for variable */
FindVarMethod *findVar;/* function that finds variable */
@@ -79,7 +79,7 @@ struct variable3 {
};
struct variable4 {
-u_char magic; /* passed to function as a hint */
+u_short magic; /* passed to function as a hint */
u_char type; /* type of variable */
u_short acl;/* access control list for variable */
FindVarMethod *findVar;/* function that finds variable */
@@ -88,7 +88,7 @@ struct variable4 {
};
struct variable7 {
-u_char magic; /* passed to function as a hint */
+u_short magic; /* passed to function as a hint */
u_char type; /* type of variable */
u_short acl;/* access control list for variable */
FindVarMethod *findVar;/* function that finds variable */
@@ -97,7 +97,7 @@ struct variable7 {
};
struct variable8 {
-u_char magic; /* passed to function as a hint */
+u_short magic; /* passed to function as a hint */
u_char type; /* type of variable */
u_short acl;/* access control list for variable */
FindVarMethod *findVar;/* function that finds variable */
@@ -106,7 +106,7 @@ struct variable8 {
};
struct variable13 {
-u_char magic; /* passed to function as a hint */
+u_short magic; /* passed to function as a hint */
u_char type; /* type of variable */
u_short acl;/* access control list for variable */
FindVarMethod *findVar;/* function that finds variable */
--
2.7.4
--
http://www.catb.org/~esr/;>Eric S. Raymond
As war and government prove, insanity is the most contagious of
diseases. -- Edward Abbey
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: ICEI asks what help you need
Bart Van Assche <bvanass...@acm.org>: > Thank you for reaching out. There is a huge backlog w.r.t. addressing bug > reports and the patch tracker. Help with reviewing and addressing all these > tickets would definitely be welcome. Wow. 722 open bugs. OK, we'll get on that. Expect some MRs soon. -- http://www.catb.org/~esr/;>Eric S. Raymond My work is funded by the Internet Civil Engineering Institute: https://icei.org Please visit their site and donate: the civilization you save might be your own. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
ICEI asks what help you need
I've been asked to approach the net-snmp dev team on behalf of the Internet Civil Engneering Institute. ICEI tries to identify important infrastructure that is undermaintained and help out. What does your project need? Where we can find a match between your needs and the skills of our staff and volunteers, we'll cheerfully pitch in. -- http://www.catb.org/~esr/;>Eric S. Raymond -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
*beep* Take me to your leaders! *beep*
I've landed my flying saucer on this particular White House lawn because I think your documentation needs some fixing. I have no designs on your strikeoutEarth females/strikeoutsource code, I'd just like to get write access to your repo long enough to fix a large number of small documentation-markup problems. Then I'll happily tootle off to another solar system and leave you to your Mr. Kangaroo reruns. Explanation: I've written a tool called doclifter that lifts manual pages to XML-Docbook. It's gotten good enough at the job that the most efficient way for me to handle the 4% of cases where it still throws errors and warnings is to go to individual projects that ship lots of problematic pages and clean them up. I did netpbm a couple weeks ago and I'm working on groff now; the X documentation is probably next after you guys. Yes, normally I would do this sort of thing by pushing patches through your tracker or mailing list. But a few projects, like yours, need lots and lots of little patches that I know are really annoying and boring to review. It saves hassle and everybody's time (including mine) if I can just go in and fix things. (I think I may have sent a couple of patches here in the past. If I did, the reason I've showed up in person is because my validator is turning up a lot of warnings it did not formerly -- things like attenmpts to use .ta and .ti in laying out code examples.) Besides liftability to DocBook, your benefit from letting me do this is that it will fix a lot of little things that may result in bad page rendering by non-groff viewers like the GNOME yelp program and KDE help center. You could opt to learn strikeoutalien star drive technology/strikeout how to migrate your masters to DocBook and set up your build'n'ship machinery to make both man pages and web pages from those. A lot of advanced strikeoutspecies/strikeout projects are doing that these days; I can show you how, I've got the plans stashed inside my giant robot sidekick right here It's all part of my master plan for strikeoutgalactic conquest/strikeout a better open-source documentation infrastructure. -- a href=http://www.catb.org/~esr/;Eric S. Raymond/a - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: problems in snmpd.conf.5
Wes Hardaker [EMAIL PROTECTED]: Actually, you should submit things like this to our patch tracker rather than by email. I suspect your automated system won't do this for you though. Furthermore, you should actually send a against the correct file (we have many man pages which are generated from definition files which are processed by sed and other tools). But I doubt your automated system can handle this either. Alas, both your conjectures are correct. -- a href=http://www.catb.org/~esr/;Eric S. Raymond/a --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ ___ Net-snmp-coders mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: problems in one or more man pages you maintain
Dave Shield [EMAIL PROTECTED]: I note that the normal man pages that doxygen spits out look reasonable (though I'd like to tweak the descriptions at some point). It's just these specials (todo, deprecated and probably bug) that seem to be malformed in this manner. I'd suggest that the simplest thing would be either to drop these particular man pages from the distribution, or else have a special sed (or similar) script to paste in the missing formatting. I think those three pages would not be much of a loss. -- a href=http://www.catb.org/~esr/;Eric S. Raymond/a --- This SF.Net email is sponsored by OSTG. Have you noticed the changes on Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now, one more big change to announce. We are now OSTG- Open Source Technology Group. Come see the changes on the new OSTG site. www.ostg.com ___ Net-snmp-coders mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
