Re: net-snmp dumps core when snmpd.conf contains an incorrect logmatch parameter regex

2014-04-09 Thread Bill Fenner
Hi Mohan,

Thanks for the patch.  Can you please upload it at
http://www.net-snmp.org/patches/ so that it doesn't get lost?

Thanks,
  Bill



On Tue, Mar 18, 2014 at 8:11 AM, Mohan Gorai mohana.go...@oracle.comwrote:

 Hi,

 On Solaris, whenever there is a wrong regex as logmatch parameter, when
 the corresponding structures are being de-allocated, snmpd coredumps.

 This is because we are freeing the structures using regfree(), even when
 the corresponding regcomp() returns with an error. The attached patch fixes
 the issue.

 Can someone evaluate the patch?

 Thanks!
 -- Mohan.


 --
 Put Bad Developers to Shame
 Dominate Development with Jenkins Continuous Integration
 Continuously Automate Build, Test  Deployment
 Start a new project now. Try Jenkins in the cloud.
 http://p.sf.net/sfu/13600_Cloudbees
 ___
 Net-snmp-coders mailing list
 Net-snmp-coders@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


--
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test  Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


Re: Bugfix for bulk gets in SNMP.pm

2014-04-09 Thread Steinar H. Gunderson
On Tue, Apr 01, 2014 at 01:41:12PM +0200, Steinar H. Gunderson wrote:
 The attached patch (in context diff, because unified diff became unusually
 unreadable!) first rewrites _gettable_do_it to be a bit less $#{$ everywhere
 (so that I could understand it myself :-) ), and then fixes so that it
 properly deals with a truncated response: For each value returned, the right
 varbind is advanced, and the decision of which ones to keep querying is
 delayed until the very end.
 
 We've queried a variety of equipment we've got around (mostly Cisco and HP,
 though), and this seems to fix the issue for us. Would you consider this for
 inclusion in a future version?

Hi,

I don't think anyone picked up this. Bumping so it isn't forgotten.

/* Steinar */
-- 
Homepage: http://www.sesse.net/

--
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test  Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


Re: Bugfix for bulk gets in SNMP.pm

2014-04-09 Thread Bill Fenner
Hi Steinar,

Thanks for the patch.  In order to make sure that we don't lose track of
it, could you please upload it to http://www.net-snmp.org/patches/ ?

Thanks,
  Bill



On Wed, Apr 9, 2014 at 9:25 AM, Steinar H. Gunderson sgunder...@bigfoot.com
 wrote:

 On Tue, Apr 01, 2014 at 01:41:12PM +0200, Steinar H. Gunderson wrote:
  The attached patch (in context diff, because unified diff became
 unusually
  unreadable!) first rewrites _gettable_do_it to be a bit less $#{$
 everywhere
  (so that I could understand it myself :-) ), and then fixes so that it
  properly deals with a truncated response: For each value returned, the
 right
  varbind is advanced, and the decision of which ones to keep querying is
  delayed until the very end.
 
  We've queried a variety of equipment we've got around (mostly Cisco and
 HP,
  though), and this seems to fix the issue for us. Would you consider this
 for
  inclusion in a future version?

 Hi,

 I don't think anyone picked up this. Bumping so it isn't forgotten.

 /* Steinar */
 --
 Homepage: http://www.sesse.net/


 --
 Put Bad Developers to Shame
 Dominate Development with Jenkins Continuous Integration
 Continuously Automate Build, Test  Deployment
 Start a new project now. Try Jenkins in the cloud.
 http://p.sf.net/sfu/13600_Cloudbees
 ___
 Net-snmp-coders mailing list
 Net-snmp-coders@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

--
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test  Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


Re: Bugfix for bulk gets in SNMP.pm

2014-04-09 Thread Steinar H. Gunderson
On Wed, Apr 09, 2014 at 09:34:47AM -0400, Bill Fenner wrote:
 Thanks for the patch.  In order to make sure that we don't lose track of
 it, could you please upload it to http://www.net-snmp.org/patches/ ?

Done; thanks.

/* Steinar */
-- 
Homepage: http://www.sesse.net/

--
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test  Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders