Re: Java Editor Tribe Codefolding review

[jose . rodriguez]

March 21, 2018 8:46 PM, "Jiří Kovalský"  wrote:

> Dne 20.3.2018 v 19:22 José J. Rodriguez napsal(a):
>> BTW, there are a couple of issues linked there which referenced 8.0 and > are
>> marked resolved anyway, I figure they can be deleted from the 9.0 spec?
> 
> Yes, of course. Removing of obsolete issues should have been part of the TS 
> review exercise.
> 

Done. Didn't figure that removing the issues would also shift the order of test 
cases, sorry for that, but I don't have time to re-sort them again right now... 
:(

> ... create a
> test assignment for yourself in the test run for what you already tested and 
> formally execute these
> and record your work. This is actually very desired!
> 
> http://netbeans-vm.apache.org/synergy/client/app/#/run/28
> 

Done, first time creating issues on JIRA as well, got 2 of them now... :D

-
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: Java Editor Tribe Codefolding review

[José J . Rodriguez]

Jiří Kovalský wrote:
No need to enter your findings anywhere. Simply clone the old test 
specification for 9.0 version and do all edits in the new one. Then 
inform your tribe leader or me with Hermien and we will update your 
tribe accordingly to link the latest specification.




Ok, cloned the specs:
http://netbeans-vm.apache.org/synergy/client/app/#/specification/402/v/2

BTW, there are a couple of issues linked there which referenced 8.0 and 
are marked resolved anyway, I figure they can be deleted from the 9.0 spec?


Also, when I mentioned the test results, I meant I had actually gone and 
run thorugh all the code folding tests on Netbeans 9 beta already, but I 
see that actual testing is supposed to begin now, lol.


Regards,
Joe1962


-
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: Java Editor Tribe Codefolding review

[Jiří Kovalský]

One more thing. José, can you please update your UPDATE (MINOR) status 
to DONE in the Wiki [1] once you finish the updates?


https://cwiki.apache.org/confluence/display/NETBEANS/NetCAT+9.0+Test+Spec+Reviews#NetCAT9.0TestSpecReviews-JavaEditor

Thanks,
-Jirka

Dne 20.3.2018 v 15:00 Jiří Kovalský napsal(a):

Dne 19.3.2018 v 20:26 José J. Rodriguez napsal(a):

Well, I should have reported way back then that I had finished the 
edits, but this is my first time on netcat, so...


No worries, we like newcomers! :)

Anyway, i was wondering how we proceed from here, for example, the 
specs page says "Netbeans 8.0", shouldn't it be copied to a new page 
titled "9.0"? Also, was reporting my test results here enough, or do I 
need to input them somewhere...?


No need to enter your findings anywhere. Simply clone the old test 
specification for 9.0 version and do all edits in the new one. Then 
inform your tribe leader or me with Hermien and we will update your 
tribe accordingly to link the latest specification.


Thanks a lot for your work!

-Jirka

-
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.apache.org_confluence_display_NETBEANS_Mailing-2Blists=DwIDaQ=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE=8_Pz0x0SKeT5e3IehhQKCbQ2xl3tz40jnCU133NrdP4=i7ExqdyaX-Xnk9TgJu80_DV4l7creVuGqpYsOUE0rWU=wTjDDCoQkzKjtUWRccSHuks6aHMSFNXbyf7ZP_G6Zik= 





-
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: Java Editor Tribe Codefolding review

[José J . Rodriguez]

Well, I should have reported way back then that I had finished the 
edits, but this is my first time on netcat, so...


Anyway, i was wondering how we proceed from here, for example, the specs 
page says "Netbeans 8.0", shouldn't it be copied to a new page titled 
"9.0"? Also, was reporting my test results here enough, or do I need to 
input them somewhere...?


Regards,
Joe1962

-
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: Java Editor Tribe Codefolding review

[jose . rodriguez]

March 11, 2018 11:08 AM, "Hermien Pellissier"  wrote:

> Hi José,
> 
> Oops! I edited test case 1.1 (Code folding after opening a file) and after
> 
>> saving, it dropped to the bottom of it's test suite, so now it's 1.10...!!!
>> That's bad, as the test cases have a sort of logical order and sometimes
>> refer to the previous one. I don't see a way to fix the order, though.
> 
> You can fix it by using this workaround: edit all the other test suite 1
> test cases one by one, in order. I tried it out on "Add javadoc code",
> which now appears after "Code folding after opening a file" at the end of
> the list. Luckily there are only 10 of them...
> 

Thanks, I'd sort of figured that was one way, but I didn't have enough free 
time yesterday. I'll do the rest of the edits (and reshuffling today. There 
should be an easier way though, isn't technology supposed to work for us and 
not vice-versa... :D

Joe1962

-
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: Java Editor Tribe Codefolding review

[Hermien Pellissier]

Hi José,

Oops! I edited test case 1.1 (Code folding after opening a file) and after
> saving, it dropped to the bottom of it's test suite, so now it's 1.10...!!!
> That's bad, as the test cases have a sort of logical order and sometimes
> refer to the previous one. I don't see a way to fix the order, though.


You can fix it by using this workaround: edit all the other test suite 1
test cases one by one, in order. I tried it out on "Add javadoc code",
which now appears after "Code folding after opening a file" at the end of
the list. Luckily there are only 10 of them...

@Lada: Do you have any insight into why this would happen if one edits a
single test case in Synergy?

~ Hermien

Re: Java Editor Tribe Codefolding review

[jose . rodriguez]

March 10, 2018 1:26 PM, "Jiří Kovalský"  wrote:

> Yes, sure! If not you, nobody else will do it.
> 
> Thanks a lot!
> -Jirka
> 
> Dne 10.3.2018 v 19:05 jose.rodrig...@cenpalab.cu napsal(a):
> 
>> March 10, 2018 7:42 AM, "Jiří Kovalský"  wrote:
>> Did you modify the test specification accordingly?
>>> 
>> 
>> No, should I?


Oops! I edited test case 1.1 (Code folding after opening a file) and after 
saving, it dropped to the bottom of it's test suite, so now it's 1.10...!!! 
That's bad, as the test cases have a sort of logical order and sometimes refer 
to the previous one. I don't see a way to fix the order, though.

-
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: Java Editor Tribe Codefolding review

[Jiří Kovalský]

Great job José. Did you modify the test specification accordingly?

Thanks a lot,
-Jirka

Dne 9.3.2018 v 21:34 José J. Rodriguez napsal(a):

I'm not getting this back from the list since I sent it over 3 hours 
ago, so here it goes again, just in case. Sorry if it's turns out 
duplicate...


---

Here's my complete review (search for the word FAIL for quick access, 
there are 2 cases...):



netbeans netcat Editor - Codefolding review:

1. Basic Code Folding...

1.1. Code folding after opening a file:
     - OK. (Test Suite Note: there are initially no javadoc comments in 
MyClass.java)


1.2. Add javadoc code:
     - OK.

1.3. Add/Remove code (1):
     - OK

1.4. Add/Remove code (2):
     - OK

1.5. Collapse cases:
     - OK.

1.6. Options - Disable/Enable CF:
     - OK.

1.7. Display Options:
     - OK. (Test Suite Note: order of Results is different to order of 
Steps, this is confusing)


1.8. Options - Typing in editor:
     - OK.

1.9. Options - Scrolling:
     - FAIL: method A.a() is collapsed less than half the attempts. No 
pattern easily discernible.


1.10. Java Settings:
     - OK.



2. Code Folding Actions...

2.1. CF Mouse Actions:
     - OK.

2.2. Code Folding main menu:
     - OK.

2.3. Collapse and expand single code fold:
     - OK.

2.4. Collapse and expand all code folds :
     - OK.

2.5. CF Shortcut Actions:
     - OK.

2.6. Show Collapsed Code in Tooltip:
     - OK.

2.7. Open No Parsable File :
     - OK.

2.8. Empty File:
     - OK.



3. Defining Custom Code Folding ...

3.1. Add custom code fold:
     - OK.

3.2. Add custom code fold with description:
     - OK.

3.3. Add custom code fold (collapse by default):
     - OK.

3.4. Change custom code fold:
     - OK.

3.5. Remove custom code fold:
     - OK.



4. Overlapped or corrupted folds, edge cases:

4.1. Overlapped folds:
     - OK.

4.2. Corrupt Custom Folds 1:
     - OK.

4.3. Corrupt Custom Folds 2:
     - OK. (Test Suite Note: the example does not show the letter "a" at 
all)


4.4. Corrupt Custom Folds 3:
     - OK.

4.5. Comments after block:
     - OK.

4.6. Two methods on the same line:
     - OK.
     - There is one issue I found while testing this out, if first 
method takes several lines and you click the collapse mark, it will 
collapse and the minus sign will remain. Clicking it again will collapse 
the second method. From then on, you can only expand and collapse the 
second method with the ± sign.


4.7. JavaDoc / Normal comment:
     - OK.



5. Miscellaneous...

5.1. Deleting when CF is collapsed:
     - OK.

5.2. Interaction with Surrounding Features 1 - Basic:
     - OK.

5.3. Interactions with Surrounding Features 2 - Bookmarks
     - OK.

5.4. Interactions with Surrounding Features 3 - Breakpoints:
     - OK.

5.5. Interactions with Surrounding Features 4 - Find & Replace:
     - FAIL, each search/next/F3 action seems to expand only 1 fold, if 
string is nested deeper, you need to keep searching (actually, it has 
been this way in 8.2 and probably earlier versions, always hated it).


5.6. Background/Foreground color:
     - OK.



Regards,
Joe1962

-
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.apache.org_confluence_display_NETBEANS_Mailing-2Blists=DwIDaQ=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE=8_Pz0x0SKeT5e3IehhQKCbQ2xl3tz40jnCU133NrdP4=Ya27mQph-7RCx7oA42Arct7gnBPJpgy7aFTy3k7zNI8=dCtq-8VlbmnxJ2EYwbxiznUvVd9oipcLZS2LRLgjv20= 





-
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Java Editor Tribe Codefolding review

[José J . Rodriguez]

I'm not getting this back from the list since I sent it over 3 hours 
ago, so here it goes again, just in case. Sorry if it's turns out 
duplicate...


---

Here's my complete review (search for the word FAIL for quick access, 
there are 2 cases...):



netbeans netcat Editor - Codefolding review:

1. Basic Code Folding...

1.1. Code folding after opening a file:
- OK. (Test Suite Note: there are initially no javadoc comments in 
MyClass.java)


1.2. Add javadoc code:
- OK.

1.3. Add/Remove code (1):
- OK

1.4. Add/Remove code (2):
- OK

1.5. Collapse cases:
- OK.

1.6. Options - Disable/Enable CF:
- OK.

1.7. Display Options:
- OK. (Test Suite Note: order of Results is different to order of 
Steps, this is confusing)


1.8. Options - Typing in editor:
- OK.

1.9. Options - Scrolling:
- FAIL: method A.a() is collapsed less than half the attempts. No 
pattern easily discernible.


1.10. Java Settings:
- OK.



2. Code Folding Actions...

2.1. CF Mouse Actions:
- OK.

2.2. Code Folding main menu:
- OK.

2.3. Collapse and expand single code fold:
- OK.

2.4. Collapse and expand all code folds :
- OK.

2.5. CF Shortcut Actions:
- OK.

2.6. Show Collapsed Code in Tooltip:
- OK.

2.7. Open No Parsable File :
- OK.

2.8. Empty File:
- OK.



3. Defining Custom Code Folding ...

3.1. Add custom code fold:
- OK.

3.2. Add custom code fold with description:
- OK.

3.3. Add custom code fold (collapse by default):
- OK.

3.4. Change custom code fold:
- OK.

3.5. Remove custom code fold:
- OK.



4. Overlapped or corrupted folds, edge cases:

4.1. Overlapped folds:
- OK.

4.2. Corrupt Custom Folds 1:
- OK.

4.3. Corrupt Custom Folds 2:
- OK. (Test Suite Note: the example does not show the letter "a" at 
all)


4.4. Corrupt Custom Folds 3:
- OK.

4.5. Comments after block:
- OK.

4.6. Two methods on the same line:
- OK.
- There is one issue I found while testing this out, if first 
method takes several lines and you click the collapse mark, it will 
collapse and the minus sign will remain. Clicking it again will collapse 
the second method. From then on, you can only expand and collapse the 
second method with the ± sign.


4.7. JavaDoc / Normal comment:
- OK.



5. Miscellaneous...

5.1. Deleting when CF is collapsed:
- OK.

5.2. Interaction with Surrounding Features 1 - Basic:
- OK.

5.3. Interactions with Surrounding Features 2 - Bookmarks
- OK.

5.4. Interactions with Surrounding Features 3 - Breakpoints:
- OK.

5.5. Interactions with Surrounding Features 4 - Find & Replace:
- FAIL, each search/next/F3 action seems to expand only 1 fold, if 
string is nested deeper, you need to keep searching (actually, it has 
been this way in 8.2 and probably earlier versions, always hated it).


5.6. Background/Foreground color:
- OK.



Regards,
Joe1962

-
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Java Editor Tribe Codefolding review

[José J . Rodriguez]

Preliminary report, I'll get to the rest later today...

Java Editor Tribe Codefolding review:

1. Code folding after opening a file:
	- OK. (Test Suite Note: there are initially no javadoc comments in 
MyClass.java, though mentioned here)


2. Add javadoc code:
- OK.

3. Add/Remove code (1):
- OK

4. Add/Remove code (2):
- OK

5. Collapse cases:
- OK.


I am using:

http://www-eu.apache.org/dist/incubator/netbeans/incubating-netbeans-java/incubating-9.0-beta/incubating-netbeans-java-9.0-beta-bin.zip

with a clean user profile.


-
To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org
For additional commands, e-mail: netcat-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists