Re: [PATCH 2/3] netpoll: rework skb transmit queue
From: Dave Jones [EMAIL PROTECTED] Date: Sat, 21 Oct 2006 01:00:16 -0400 Practically no-one cared about it, so it bit-rotted really fast after we shipped RHEL4. That, along with the focus shifting to making kdump work seemed to kill it off over the last 12 months. Then we can truly kill off the -drop() callback as part of Stephen's patches. Stephen, I'll review your new set over the weekend. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 1/1] r8169 driver: corega support
I demand that Francois Romieu may or may not have written...
[EMAIL PROTECTED] [EMAIL PROTECTED] :
[Corega adapter support]
It's queued in the r8169 branch at:
git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git r8169
I have sent Jeff a pull request for it (and I'll probably send one
more for the patch below).
Darren, can you check if the patch below fixes you link detection
issue ?
It does, but the patch causes the module to report that the reset failed even
after reporting that it's done. A fix for this is attached.
--
| Darren Salt| linux or ds at | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
| + Generate power using sun, wind, water, nuclear. FORGET COAL AND OIL.
Life is what happens when you're busy making other plans.
Avoid reporting that the PHY reset has failed when it's just succeeded.
Signed-off-by: Darren Salt [EMAIL PROTECTED]
diff a/drivers/net/r8169.c b/drivers/net/r8169.c
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1452,7 +1452,7 @@ static void rtl8169_release_board(struct
for (i = 0; i 100; i++) {
if (!tp-phy_reset_pending(ioaddr)) {
printk(KERN_INFO %s: PHY reset done.\n, dev-name);
- break;
+ return;
}
msleep(1);
}
Re: [RFC] Ethernet Cheap Cryptography
Stephen J. Bevan wrote: However, in the above you note that MPPE is being used. I take this to mean that all the PPP traffic between the PPPoE client and PPPoE server is encrypted. However, if that's the case then I don't understand why there is a need to use ccrypt for the wireless link between the two Linux boxes. Thus perhaps I misunderstood where MPPE is being used? Or perhaps you meant this is only one example and in other scenarios MPPE is not used and so in that case the wireless traffic does need encrypting? For example because MPPE is optional and some sessions may be encrypted and some not. As I mentioned, we cannot influence the ISP in topic. More generally, I wanted to present an example of a layer-2 encapsulation that Linux does not know or (as in this case) can't modify the data in it, thus it cannot fix the TCP MSS value. -- Pawel Foremski [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC] Ethernet Cheap Cryptography
Stephen Hemminger wrote: Ethernet encrypted bridging is old stuff: http://kerneltrap.org/node/167 http://www.arnor.net/encryptingbridge/ It never got accepted, mostly for the same reasons this proposal is a dead end. From what I can see in the brief description is that ccrypt is more general as it is not limited to ethernet bridging code, UDP and AES. Unfortunately I cannot find any replies to the announcement you've mentioned and thus I am and was not aware of the objections to the encrypted bridging idea. I knew the encrypted bridging project before starting to think about ccrypt, BTW. -- Pawel Foremski [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: tg3 kernel bug in 2.6.18-mm3 and 2.6.19-rc2-mm2
cc's added.
On Sat, 21 Oct 2006 15:22:39 +0200
Norbert Preining [EMAIL PROTECTED] wrote:
Hi all!
I get the same bug again and again, always when ifplugd is started:
tg3: eth0: No firmware running.
BUG: soft lockup detected on CPU#0!
[c0103ec7] dump_trace+0x68/0x1b4
[c010402b] show_trace_log_lvl+0x18/0x2c
[c010463a] show_trace+0xf/0x11
[c010469d] dump_stack+0x12/0x14
[c0141cb3] softlockup_tick+0xaa/0xc1
[c0129bad] update_process_times+0x3b/0x5e
[c01362a1] handle_update_profile+0x14/0x1e
[c0115956] smp_apic_timer_interrupt+0x49/0x5b
[c0103998] apic_timer_interrupt+0x28/0x30
DWARF2 unwinder stuck at apic_timer_interrupt+0x28/0x30
Leftover inexact backtrace:
[c01d03af] delay_tsc+0xb/0x13
[c01d03e0] __delay+0x6/0x7
[c022ce12] tg3_readphy+0x6e/0xd5
[c022e0d1] tg3_setup_copper_phy+0x30b/0xa15
[c01064d9] profile_pc+0x24/0x53
[c022f475] tg3_setup_phy+0xc9a/0xd1f
[c0103998] apic_timer_interrupt+0x28/0x30
[c022c240] _tw32_flush+0x3f/0x51
[c022dc4a] tg3_write_mem+0xcf/0xe7
[c0231683] tg3_reset_hw+0x10ab/0x13a0
[c01d03e0] __delay+0x6/0x7
[c01d03e0] __delay+0x6/0x7
[c022c240] _tw32_flush+0x3f/0x51
[c01d03e0] __delay+0x6/0x7
[c022da97] tg3_switch_clocks+0x8f/0x93
[c0237673] tg3_open+0x250/0x520
[c02d3263] dev_open+0x2b/0x62
[c02d1dd8] dev_change_flags+0x47/0xe4
[c0307fcc] devinet_ioctl+0x252/0x556
[c02d2e5a] dev_ifsioc+0x113/0x38d
[c02d29c4] dev_load+0x24/0x4b
[c02c90c7] sock_ioctl+0x0/0x1c2
[c02c9265] sock_ioctl+0x19e/0x1c2
[c02ca151] sock_map_fd+0x41/0x4a
[c02c90c7] sock_ioctl+0x0/0x1c2
[c01684bb] do_ioctl+0x1f/0x62
[c0168743] vfs_ioctl+0x245/0x257
[c0168788] sys_ioctl+0x33/0x4b
[c0102f40] syscall_call+0x7/0xb
===
With 2.6.19-rc2 (no -mm) it does not happen.
Normal dmesg gives:
tg3.c:v3.66 (September 23, 2006)
PCI: Enabling device :03:00.0 ( - 0002)
ACPI: PCI Interrupt :03:00.0[A] - GSI 17 (level, low) - IRQ 18
PCI: Setting latency timer of device :03:00.0 to 64
eth0: Tigon3 [partno(BCM95789) rev 4101 PHY(5750)] (PCI Express)
10/100/1000Base
T Ethernet 00:16:36:1e:27:ad
eth0: RXcsums[1] LinkChgREG[0] MIirq[0] ASF[0] Split[0] WireSpeed[1]
TSOcap[1]
eth0: dma_rwctrl[7618] dma_mask[64-bit]
There are tg3 changes in -mm, but I doubt it they caused this hang.
Can you test 2.6.19-rc2 plus the below?
Thanks.
--- linux-2.6.19-rc2/drivers/net/tg3.c 2006-10-13 10:35:00.0 -0700
+++ devel/drivers/net/tg3.c 2006-10-21 09:34:42.0 -0700
@@ -68,8 +68,8 @@
#define DRV_MODULE_NAMEtg3
#define PFX DRV_MODULE_NAME:
-#define DRV_MODULE_VERSION 3.66
-#define DRV_MODULE_RELDATE September 23, 2006
+#define DRV_MODULE_VERSION 3.67
+#define DRV_MODULE_RELDATE October 18, 2006
#define TG3_DEF_MAC_MODE 0
#define TG3_DEF_RX_MODE0
@@ -129,7 +129,7 @@
#define RX_JUMBO_PKT_BUF_SZ(9046 + tp-rx_offset + 64)
/* minimum number of free TX descriptors required to wake up TX process */
-#define TG3_TX_WAKEUP_THRESH (TG3_TX_RING_SIZE / 4)
+#define TG3_TX_WAKEUP_THRESH(tp) ((tp)-tx_pending / 4)
/* number of ETHTOOL_GSTATS u64's */
#define TG3_NUM_STATS (sizeof(struct tg3_ethtool_stats)/sizeof(u64))
@@ -3075,10 +3075,10 @@ static void tg3_tx(struct tg3 *tp)
smp_mb();
if (unlikely(netif_queue_stopped(tp-dev)
-(tg3_tx_avail(tp) TG3_TX_WAKEUP_THRESH))) {
+(tg3_tx_avail(tp) TG3_TX_WAKEUP_THRESH(tp {
netif_tx_lock(tp-dev);
if (netif_queue_stopped(tp-dev)
- (tg3_tx_avail(tp) TG3_TX_WAKEUP_THRESH))
+ (tg3_tx_avail(tp) TG3_TX_WAKEUP_THRESH(tp)))
netif_wake_queue(tp-dev);
netif_tx_unlock(tp-dev);
}
@@ -3928,7 +3928,7 @@ static int tg3_start_xmit(struct sk_buff
tp-tx_prod = entry;
if (unlikely(tg3_tx_avail(tp) = (MAX_SKB_FRAGS + 1))) {
netif_stop_queue(dev);
- if (tg3_tx_avail(tp) TG3_TX_WAKEUP_THRESH)
+ if (tg3_tx_avail(tp) TG3_TX_WAKEUP_THRESH(tp))
netif_wake_queue(tp-dev);
}
@@ -4143,7 +4143,7 @@ static int tg3_start_xmit_dma_bug(struct
tp-tx_prod = entry;
if (unlikely(tg3_tx_avail(tp) = (MAX_SKB_FRAGS + 1))) {
netif_stop_queue(dev);
- if (tg3_tx_avail(tp) TG3_TX_WAKEUP_THRESH)
+ if (tg3_tx_avail(tp) TG3_TX_WAKEUP_THRESH(tp))
netif_wake_queue(tp-dev);
}
@@ -8106,7 +8106,10 @@ static int tg3_set_ringparam(struct net_
if ((ering-rx_pending TG3_RX_RING_SIZE - 1) ||
(ering-rx_jumbo_pending TG3_RX_JUMBO_RING_SIZE - 1) ||
- (ering-tx_pending TG3_TX_RING_SIZE - 1))
+ (ering-tx_pending TG3_TX_RING_SIZE - 1) ||
+ (ering-tx_pending = MAX_SKB_FRAGS) ||
+
Re: tg3 kernel bug in 2.6.18-mm3 and 2.6.19-rc2-mm2
On Saturday, 21 October 2006 19:02, Andrew Morton wrote: cc's added. On Sat, 21 Oct 2006 15:22:39 +0200 Norbert Preining [EMAIL PROTECTED] wrote: Hi all! I get the same bug again and again, always when ifplugd is started: tg3: eth0: No firmware running. BUG: soft lockup detected on CPU#0! [c0103ec7] dump_trace+0x68/0x1b4 [c010402b] show_trace_log_lvl+0x18/0x2c [c010463a] show_trace+0xf/0x11 [c010469d] dump_stack+0x12/0x14 [c0141cb3] softlockup_tick+0xaa/0xc1 [c0129bad] update_process_times+0x3b/0x5e [c01362a1] handle_update_profile+0x14/0x1e [c0115956] smp_apic_timer_interrupt+0x49/0x5b [c0103998] apic_timer_interrupt+0x28/0x30 DWARF2 unwinder stuck at apic_timer_interrupt+0x28/0x30 Leftover inexact backtrace: [c01d03af] delay_tsc+0xb/0x13 [c01d03e0] __delay+0x6/0x7 [c022ce12] tg3_readphy+0x6e/0xd5 [c022e0d1] tg3_setup_copper_phy+0x30b/0xa15 [c01064d9] profile_pc+0x24/0x53 [c022f475] tg3_setup_phy+0xc9a/0xd1f [c0103998] apic_timer_interrupt+0x28/0x30 [c022c240] _tw32_flush+0x3f/0x51 [c022dc4a] tg3_write_mem+0xcf/0xe7 [c0231683] tg3_reset_hw+0x10ab/0x13a0 [c01d03e0] __delay+0x6/0x7 [c01d03e0] __delay+0x6/0x7 [c022c240] _tw32_flush+0x3f/0x51 [c01d03e0] __delay+0x6/0x7 [c022da97] tg3_switch_clocks+0x8f/0x93 [c0237673] tg3_open+0x250/0x520 [c02d3263] dev_open+0x2b/0x62 [c02d1dd8] dev_change_flags+0x47/0xe4 [c0307fcc] devinet_ioctl+0x252/0x556 [c02d2e5a] dev_ifsioc+0x113/0x38d [c02d29c4] dev_load+0x24/0x4b [c02c90c7] sock_ioctl+0x0/0x1c2 [c02c9265] sock_ioctl+0x19e/0x1c2 [c02ca151] sock_map_fd+0x41/0x4a [c02c90c7] sock_ioctl+0x0/0x1c2 [c01684bb] do_ioctl+0x1f/0x62 [c0168743] vfs_ioctl+0x245/0x257 [c0168788] sys_ioctl+0x33/0x4b [c0102f40] syscall_call+0x7/0xb === With 2.6.19-rc2 (no -mm) it does not happen. Normal dmesg gives: tg3.c:v3.66 (September 23, 2006) PCI: Enabling device :03:00.0 ( - 0002) ACPI: PCI Interrupt :03:00.0[A] - GSI 17 (level, low) - IRQ 18 PCI: Setting latency timer of device :03:00.0 to 64 eth0: Tigon3 [partno(BCM95789) rev 4101 PHY(5750)] (PCI Express) 10/100/1000Base T Ethernet 00:16:36:1e:27:ad eth0: RXcsums[1] LinkChgREG[0] MIirq[0] ASF[0] Split[0] WireSpeed[1] TSOcap[1] eth0: dma_rwctrl[7618] dma_mask[64-bit] There are tg3 changes in -mm, but I doubt it they caused this hang. FWIW, I have a tg3 running just fine with 2.6.19-rc2-mm2, on x86-64. Greetings, Rafael -- You never change things by fighting the existing reality. R. Buckminster Fuller - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] e100_shutdown: netif_poll_disable hang
My machine annoyingly hangs while rebooting. I tracked it down to e100-fix-reboot-f-with-netconsole-enabled.patch in 2.6.18-rc2-mm2 I review the changes and it seemed to be calling netif_poll_disable one too many time. Once in e100_down(), and again in e100_shutdown(). The second one in e100_shutdown() caused the hang. So this patch removes it. * Auke Kok [EMAIL PROTECTED] [061020 23:09]: it doesn't even do harm to netif_poll_disable() twice as far as I can see, as it merely calls test_and_set_bit(), which will instantly succeed on the first attempt if the bit was already set. did this change actually fix it for you? I'm wondering if the netif_carrier_off might not be the culprit here... I can confirm the proposed original change of D. Walker fixed the problem for me. I did not test the change you proposed as a followup. -- Damien Wyart - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] e100_shutdown: netif_poll_disable hang
Damien Wyart wrote: My machine annoyingly hangs while rebooting. I tracked it down to e100-fix-reboot-f-with-netconsole-enabled.patch in 2.6.18-rc2-mm2 I review the changes and it seemed to be calling netif_poll_disable one too many time. Once in e100_down(), and again in e100_shutdown(). The second one in e100_shutdown() caused the hang. So this patch removes it. * Auke Kok [EMAIL PROTECTED] [061020 23:09]: it doesn't even do harm to netif_poll_disable() twice as far as I can see, as it merely calls test_and_set_bit(), which will instantly succeed on the first attempt if the bit was already set. did this change actually fix it for you? I'm wondering if the netif_carrier_off might not be the culprit here... I can confirm the proposed original change of D. Walker fixed the problem for me. I did not test the change you proposed as a followup. his change breaks something else (a reboot with netconsole, possibly suspend). Please give the latest version I sent a try. Daniel confirmed me that it works, but it's always nice to hear it from more people. Thanks Auke - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Please pull 'we21-fix' branch of wireless-2.6.git
John W. Linville wrote: Jeff, Here is my ugly patch to fix userland ABI compatibility for WE-21. It tries to detect WE = 20 by the request length or the inclusion of '\0' in the length for the ESSID and NICKN ioctls. If it finds that, it temporarily adjusts the length value and puts it back before reporting back to userland. It is possible that there are more elegant solutions that work, but I'm not totally convinced that they truly preserve the ABI as desired. Please see the discussion earlier in this thread if you are interested. I'm aware that checking for '\0' is problematic, since that technically is a valid SSID character even at the end of the SSID. I'm afraid we will just have to live with that limitation. I have the single patch on its own clean branch from Linus's tree of a few days ago. That way you can pull just this fix without concern about picking-up the other fixes which I posted a few days ago, in case you haven't reviewed them yet. Obviously, this is intended for 2.6.19. Thanks, John --- The following changes since commit 51018b0a3160d253283173c2f54f16746cee5852: Ulrich Drepper: make UML compile (FC6/x86-64) are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/wireless-2.6.git we21-fix pulled, after adding git/linville/ to the URL... Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Pull request for 'jg-20061012-00' tag
Francois Romieu wrote: Please pull from tag 'jg-20061012-00' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git jg-20061012-00 to get the changes below. Distance from 'upstream-fixes' - 733b736c91dd2c556f35dffdcf77e667cf10cefc 73f5e28b336772c4b08ee82e5bf28ab872898ee1 Diffstat drivers/net/r8169.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) Shortlog Andrew Morton: r8169: PCI ID for Corega Gigabit network card Arnaud Patard: r8169: fix infinite loop during hotplug pulled - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch] Add ethtool -i interface to Prism54
Kai Engert wrote: Attached is a small patch that will add support for ethtool -i to the prism54 driver. ethtool -i queries the specified ethernet device for associated driver information. This helps tools like Fedora's system-config-network to provide GUI management of network devices. I learned how to write this patch by reading the ipw2100 driver code. Thanks for considering to take it. Please include a Signed-off-by line at a minimum, to provide a legal release for your patch. Other details, like including the patch inline rather than as an attachment can found in http://linux.yyz.us/patch-format.html and Documentation/SubmittingPatches in the kernel tree. Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] ethtool: dump_registers post mortem
Stephen Hemminger wrote: This patch allows: ethtool -d eth0 raw on saved_regs and later ethtool -d eth0 file saved_regs Selfish motive is to be able to take register dumps from users and and decode later, possibly adding more output as needed. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Would you be kind enough to roll your ethtool patches into two patches: this patch, and 'more sky2 decode' patch. I now have three sky2 decode patches, two from 10/18 and one from 10/19. Also, please update the man page, and possibly the -h help info, to indicate this enhancement. Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Please pull 'upstream-fixes' branch of wireless-2.6
John W. Linville wrote: The following changes since commit 51018b0a3160d253283173c2f54f16746cee5852: Ulrich Drepper: make UML compile (FC6/x86-64) are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-fixes Dave Kleikamp: airo: check if need to freeze Eric Sesterhenn: zd1201: Possible NULL dereference Florin Malita: airo.c: check returned values Jean Tourrilhes: orinoco: fix WE-21 buffer overflow wireless: More WE-21 potential overflows... John W. Linville: zd1211rw: fix build-break caused by association race fix Larry Finger: bcm43xx-softmac: check returned value from pci_enable_device bcm43xx-softmac: Fix system hang for x86-64 with 1GB RAM Laurent Riffard: sotftmac: fix a slab corruption in WEP restricted key association Michael Buesch: bcm43xx: fix race condition in periodic work handler softmac: Fix WX and association related races pulled - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Please pull 'upstream' branch of wireless-2.6
John W. Linville wrote: The following changes since commit 41072a1be57f63bf83afc31c44d72de018d800fa: John W. Linville: zd1211rw: fix build-break caused by association race fix are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream Alexey Dobriyan: prism54: use BUILD_BUG_ON Daniel Drake: zd1211rw: Add 3 more device IDs ieee80211: Move IV/ICV stripping into ieee80211_rx Dmitry Torokhov: atmel: save on array initialization atmel: use ARRAY_SIZE() atmel: whitespace cleanup prism54: fix potential race in reset scheduling prism54: whitespace cleanup Holden Karau: atmel: output signal strength information Larry Finger: bcm43xx: output proper link quality with scans ieee80211: Drop and count duplicate data frames to remove 'replay detected' log messages matthieu castet: ieee80211: allow mtu bigger than 1500 Stefano Brivio: bcm43xx: add PCI-E code pulled - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/8] e100, e1000: Fixes for netdev-2.6#upstream-fixes
Kok, Auke wrote: Hi, The following fixes targeted to netdev-2.6#upstream-fixes are available through git: git pull git://lost.foo-projects.org/~ahkok/git/netdev-2.6 upstream-fixes hrm. since another e100 fixes got applied, can you either (a) update the above URL for that change, or (b) provide separate e100 and e1000 pull urls? Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[git patches] net driver fixes
[just sent this upstream] Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/Kconfig |2 drivers/net/e1000/e1000_main.c |4 drivers/net/ibmveth.c | 10 drivers/net/ioc3-eth.c |4 drivers/net/r8169.c |7 drivers/net/sb1250-mac.c|2 drivers/net/sky2.c | 33 - drivers/net/smc91x.h| 18 + drivers/net/ucc_geth.c | 633 --- drivers/net/ucc_geth.h | 248 - drivers/net/ucc_geth_phy.c | 26 - drivers/net/ucc_geth_phy.h |2 drivers/net/wan/pc300_drv.c | 24 + drivers/net/wireless/airo.c | 105 +++- drivers/net/wireless/atmel.c|2 drivers/net/wireless/bcm43xx/bcm43xx_dma.c | 28 + drivers/net/wireless/bcm43xx/bcm43xx_dma.h | 17 + drivers/net/wireless/bcm43xx/bcm43xx_leds.c |2 drivers/net/wireless/bcm43xx/bcm43xx_main.c | 34 - drivers/net/wireless/bcm43xx/bcm43xx_wx.c |2 drivers/net/wireless/orinoco.c | 16 - drivers/net/wireless/ray_cs.c |1 drivers/net/wireless/zd1201.c |6 drivers/net/wireless/zd1211rw/zd_mac.c |2 include/net/ieee80211softmac.h | 35 + net/core/wireless.c | 33 + net/ieee80211/softmac/ieee80211softmac_assoc.c | 56 +- net/ieee80211/softmac/ieee80211softmac_io.c | 11 net/ieee80211/softmac/ieee80211softmac_module.c |1 net/ieee80211/softmac/ieee80211softmac_wx.c | 71 ++- 30 files changed, 809 insertions(+), 626 deletions(-) Andrew Morton: r8169: PCI ID for Corega Gigabit network card Arnaud Patard: r8169: fix infinite loop during hotplug Dave Jones: Remove useless comment from sb1250 Dave Kleikamp: airo: check if need to freeze David Gibson: ibmveth: Fix index increment calculation Deepak Saxena: Update smc91x driver with ARM Versatile board info Eric Sesterhenn: zd1201: Possible NULL dereference Florin Malita: airo.c: check returned values Jean Tourrilhes: orinoco: fix WE-21 buffer overflow wireless: More WE-21 potential overflows... Jeff Garzik: WAN/pc300: handle, propagate minor errors John W. Linville: zd1211rw: fix build-break caused by association race fix wireless: WE-20 compatibility for ESSID and NICKN ioctls Larry Finger: bcm43xx-softmac: check returned value from pci_enable_device bcm43xx-softmac: Fix system hang for x86-64 with 1GB RAM Laurent Riffard: sotftmac: fix a slab corruption in WEP restricted key association Li Yang: ucc_geth: changes to ucc_geth driver as a result of qe_lib changes and bugfixes Linas Vepstas: e1000: Reset all functions after a PCI error Michael Buesch: bcm43xx: fix race condition in periodic work handler softmac: Fix WX and association related races Ralf Baechle: Fix timer race Stephen Hemminger: sky2: 88E803X transmit lockup - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] VIOC: Ethtool
Misha Tomushev wrote: The following is the ethtool patch for VIOC Device Driver. Signed-off-by: Misha Tomushev [EMAIL PROTECTED] ACK but does not apply to ethtool.git: Applying 'add VIOC support' Adds trailing whitespace. .dotest/patch:50:#define VIOC_REGS_LINE_SIZEsizeof(struct regs_line) error: patch failed: Makefile.am:7 error: Makefile.am: patch does not apply error: patch failed: ethtool-util.h:48 error: ethtool-util.h: patch does not apply error: patch failed: ethtool.c:945 error: ethtool.c: patch does not apply - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 1/1] r8169 driver: corega support
Darren Salt [EMAIL PROTECTED] :
[...]
It does, but the patch causes the module to report that the reset failed even
after reporting that it's done. A fix for this is attached.
Oops. Ok with the one below ?
r8169: perform a PHY reset before any other operation at boot time
Realtek's 8139/810x (0x8136) PCI-E comes with a touchy PHY.
A big heavy reset seems to calm it down.
Fix for http://bugzilla.kernel.org/show_bug.cgi?id=7378.
Signed-off-by: Francois Romieu [EMAIL PROTECTED]
Signed-off-by: Darren Salt [EMAIL PROTECTED]
---
drivers/net/r8169.c | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index c2c9a86..03c0dc5 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1442,6 +1442,22 @@ static void rtl8169_release_board(struct
free_netdev(dev);
}
+static void rtl8169_phy_reset(struct net_device *dev,
+ struct rtl8169_private *tp)
+{
+ void __iomem *ioaddr = tp-mmio_addr;
+ int i;
+
+ tp-phy_reset_enable(ioaddr);
+ for (i = 0; i 100; i++) {
+ if (!tp-phy_reset_pending(ioaddr))
+ return;
+ msleep(1);
+ }
+ if (netif_msg_link(tp))
+ printk(KERN_ERR %s: PHY reset failed.\n, dev-name);
+}
+
static void rtl8169_init_phy(struct net_device *dev, struct rtl8169_private
*tp)
{
void __iomem *ioaddr = tp-mmio_addr;
@@ -1470,6 +1486,8 @@ static void rtl8169_init_phy(struct net_
rtl8169_link_option(board_idx, autoneg, speed, duplex);
+ rtl8169_phy_reset(dev, tp);
+
rtl8169_set_speed(dev, autoneg, speed, duplex);
if ((RTL_R8(PHYstatus) TBI_Enable) netif_msg_link(tp))
--
1.4.2.3
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 1/2]d80211: hardware TKIP support for ipw3945
On Fri, 20 Oct 2006 17:19:36 +0800, Hong Liu wrote: ipw3945 TKIP hwcrypto only support RC4 encryption, so the stack needs to pre compute the michael MIC and the RC4key for it. I suppose the hw doesn't do any hardware mic for the RX path. It believe it should be also added. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] e100_shutdown: netif_poll_disable hang
* Auke Kok [EMAIL PROTECTED] [2006-10-21 10:54]: his change breaks something else (a reboot with netconsole, possibly suspend). Please give the latest version I sent a try. Daniel confirmed me that it works, but it's always nice to hear it from more people. Yes, your version works here too. -- Damien Wyart - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: tg3 kernel bug in 2.6.18-mm3 and 2.6.19-rc2-mm2
Hi Andrew, hi all! On Sam, 21 Okt 2006, Andrew Morton wrote: Can you test 2.6.19-rc2 plus the below? 2.6.19-rc2 works 2.6.19-rc2+patch does not work So it is this patch. hw: Acer TravelMate 3012WMi 03:00.0 Ethernet controller: Broadcom Corporation NetLink BCM5789 Gigabit Ethernet PCI Express (rev 11) If you need dmesg, .config, something else, no problem. Best wishes Norbert --- Dr. Norbert Preining [EMAIL PROTECTED]Università di Siena Debian Developer [EMAIL PROTECTED] Debian TeX Group gpg DSA: 0x09C5B094 fp: 14DF 2E6C 0307 BE6D AD76 A9C0 D2BF 4AA3 09C5 B094 --- DITHERINGTON (n) Sudden access to panic experienced by one who realises that he is being drawn inexorably into a clabby (q.v.) conversion, i.e. one he has no hope of enjoying, benefiting from or understanding. --- Douglas Adams, The Meaning of Liff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [IPv6] fib: initialize tb6_lock in common place to give lockdep a key
From: Thomas Graf [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 14:42:04 +0200 Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied, thanks a lot for this fix Thomas. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [NET] reduce sizeof(struct flowi) by 20 bytes
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 15:55:33 +0200 As suggested by David, just kill off some unused fields in dnports to reduce sizef(struct flowi). If they come back, they should be moved to nl_u.dn_u in order not to enlarge again struct flowi Signed-off-by: Eric Dumazet [EMAIL PROTECTED] Applied, except I changed the patch to really delete this stuff instead of using #if 0. Anyone can look into old trees of the code history to see the old stuff. :-) Thanks Eric. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4][CRYPTO][IPsec] pass the flags to the internal tfm allocation
On Wed, Oct 18, 2006 at 11:26:06AM +0900, Kazunori MIYAZAWA wrote:
XCBC needs to allocate the tfm as CBC mode to use
xor function in the tfm.
I'm sorry but this isn't going to fly. The mode argument is obsolete
and incompatible with the new bit-field flags setup. So I'm not going
to add any new code that uses it.
In the medium term this code should be converted to use the block-cipher
interface. For now, please either make a local copy of the xor function
or just export the one from crypto/cbc.c.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/4] add the algorithm to IPsec
On Wed, Oct 18, 2006 at 11:26:23AM +0900, Kazunori MIYAZAWA wrote:
diff --git a/net/xfrm/xfrm_algo.c b/net/xfrm/xfrm_algo.c
index 5a0dbeb..e03eadd 100644
--- a/net/xfrm/xfrm_algo.c
+++ b/net/xfrm/xfrm_algo.c
@@ -119,6 +119,24 @@ static struct xfrm_algo_desc aalg_list[]
.sadb_alg_maxbits = 160
}
},
+{
+ .name = xcbc(aes),
+ .compat = aes_xcbc_128,
BTW, new algorithms should not have a compat field. The whole point
of the compat field is to allow existing users to get the correct
algorithm without updating their configuration. This does not make
sense for new algorithms as there aren't any existing configurations
for us to worry about yet.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/6] [CRYPTO] added the code of Camellia cipher algorithm.
On Wed, Oct 18, 2006 at 07:16:47AM +, Noriaki TAKAMIYA wrote:
+static int
+camellia_set_key(struct crypto_tfm *tfm, const u8 *in_key,
+ unsigned int key_len, u32 *flags)
Ugh, this doesn't compile with the current tree since the flags
field no longer exists for set_key. I've fixed it up in my tree.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: tg3 kernel bug in 2.6.18-mm3 and 2.6.19-rc2-mm2
Norbert Preining wrote: On Sam, 21 Okt 2006, Andrew Morton wrote: Can you test 2.6.19-rc2 plus the below? 2.6.19-rc2works 2.6.19-rc2+patch does not work So it is this patch. It doesn't make any sense. This patch is totally benign and cannot cause the No firmware running and lockup that you reported. Can you please double-check? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
