Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race
From: Miklos Szeredi <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 08:41:30 +0200 > This may seem low priority and irrelevant, but it _is_ a bug, and it's > affecting a real world application. So please take that into > consideration. I'm not the only person who hasn't reviewed your latest patch yet. You may want to consider that this might have something to do with your attitude and behavior, rather than the importance of your patch. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race
> > But myself, nor any other developers, are going to review your work > > any faster if you do things like try to slip things in behind the > > maintainer's back as you attempted to do yesterday by asking Andrew to > > put your AF_UNIX garbage collector rewrite directly into his -mm tree. > > mmm... I didn't see it as a slip-behind-the-back thing. More a "park it > in -mm for a bit of concurrent testing and so it doesn't get lost and so I > don't have to worry about it any more" thing. Plenty of that goes on. Exactly. I have CC-ed everyone involved, and clearly stated that I do want it reviewed. There wasn't any evil intention. I _am_ slightly pissed off by still not having this bug fixed after two months, and after spending considerable effort at hunting it down and finding a solution for it (actually three different solutions by now). This may seem low priority and irrelevant, but it _is_ a bug, and it's affecting a real world application. So please take that into consideration. Thanks, Miklos - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [2.6.22] Remove unneeded pointer idev from addrconf_cleanup() in net/ipv6/addrconf.c
From: "Micah Gruber" <[EMAIL PROTECTED]> Date: Mon, 9 Jul 2007 11:30:46 +0800 > This trivial patch removes the unneeded pointer idev returned from > __in6_dev_get(), which is never used. The check for NULL can be simply > done by if (__in6_dev_get(dev) == NULL). > > Signed-off-by: Micah Gruber < [EMAIL PROTECTED]> Applied, but your patch was severely white-space damaged by your email client, please fix this up and test that the patches you email out can be applied by those receiving the posting in the future. Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 06 Jul 2007 15:31:56 +0200 > Rémi Denis-Courmont wrote: > > On Thursday 05 July 2007 20:25:50 ext James Chapman wrote: > > > >>Rémi Denis-Courmont wrote: > >> > >>>By the way, couldn't encap_type be remove altogether (using two slightly > >>>different callbacks for ESP) from udp_sock? > >> > >>The notion of encap_type is needed for the setsockopt call so it would > >>have to stay in the API. If it were removed from udp_sock, getsockopt > >>would have to derive the encap_type from encap_rcv funcptr values, which > >>would be messy. I think it might complicate the logic in ESP too. > > > > > > Right. By the way, shouldn't "len" rather be signed in there? > > > > unsigned int len; > > > > /* if we're overly short, let UDP handle it */ > > len = skb->len - sizeof(struct udphdr); > > if (len <= 0) > > goto udp; > > > It should, but the < 0 case can't happen since __udp4_lib_rcv > already makes sure that we have at least a complete UDP header. > > Anyways, this patch fixes it. > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets
Hi Joel, On Tue, 10 Jul 2007, Joel Becker wrote: > On Wed, Jul 11, 2007 at 03:47:09AM +0530, Satyam Sharma wrote: > > Hmm, I put it in there because I expected that the user must have had > > at least one target configured (added to target_list) if he's got the > > module loaded/built-in (and netconsole registered), which is when this > > function would be triggered anyway. > > Loading the module won't happen without a config, That's no longer the case (doesn't need to be enforced actually) now with being able to add logging targets _after_ the module has loaded and initialized / registered itself. It's plausible a user may simply want to load netconsole without any "netconsole=" option, and then specify/add targets later -- this wasn't possible previously, of course. > but there's no > requirement that a built-in netconsole has a kernel command-line > argument. The above is applicable for the built-in case too, with CONFIG_NETCONSOLE_DYNAMIC. So now built-in netconsole will initialize (configfs subsystem, etc) and register itself (register_console) even if no "netconsole=" was provided, again for the same reason. And I now notice that CONFIG_NETCONSOLE=y in the defconfig's of most arch's. So I think I did get the common case wrong there ... ok, I'll get rid of the unlikely() in that case. Satyam - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [NET]: Another unnecessary net/tcp.h inclusion in net/dn.h
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Sun, 8 Jul 2007 18:26:26 +0300 (EEST) > No longer needed. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Applied, thanks a lot! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] make all initialized struct seq_operations const
From: Philippe De Muyter <[EMAIL PROTECTED]> Date: Fri, 6 Jul 2007 15:25:43 +0200 > Make all initialized struct seq_operations in net/ const > > Signed-off-by: Philippe De Muyter <[EMAIL PROTECTED]> Applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Races in net_rx_action vs netpoll?
From: Olaf Kirch <[EMAIL PROTECTED]>
Date: Tue, 10 Jul 2007 12:44:31 +0200
> On Tuesday 10 July 2007 00:27, David Miller wrote:
> > I'm happy to entertain this kind of solution, but we really
> > need to first have an interface to change multiple bits
> > at a time in one atomic operation, because by itself this
> > patch doubles the number of atomices we do when starting
> > a NAPI poll.
>
> Understood. How about the patch below? It takes a similar
> approach, but it puts the onus on the netpoll code
> path rather than the general NAPI case.
Definitely looks more palatable.
> @@ -919,6 +921,14 @@ static inline void netif_rx_complete(str
> {
> unsigned long flags;
>
> +#ifdef CONFIG_NETPOLL
> + /* Prevent race with netpoll - yes, this is a kludge.
> + * But at least it doesn't penalize the non-netpoll
> + * code path. */
> + if (test_bit(__LINK_STATE_POLL_LIST_FROZEN, &dev->state))
> + return;
> +#endif
> +
> local_irq_save(flags);
> BUG_ON(!test_bit(__LINK_STATE_RX_SCHED, &dev->state));
> list_del(&dev->poll_list);
That new bit can be set in interrupt context can't it?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PATCH] Updates for RH0 deprecation.
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 07:25:01 +0900 (JST) > In article <[EMAIL PROTECTED]> (at Mon, 09 Jul 2007 14:28:30 -0700 (PDT)), > David Miller <[EMAIL PROTECTED]> says: > > > From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> > > Date: Tue, 10 Jul 2007 02:29:01 +0900 (JST) > > > > > Changesets are available at > > > git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git/ > > > on the branch named > > > linux-2.6.22_deprecate-rh0-20070710 > > > > [EMAIL PROTECTED]:~/src/GIT/ipv6-2.6$ git pull > > git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git > > linux-2.6.22_deprecate-rh0-20070710 > > error: no such remote ref refs/heads/linux-2.6.22_deprecate-rh0-20070710 > > fatal: Fetch failure: > > git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git > > ... Sorry, the repository was not synchronized appropriately... > (rsync has been stuck for several days; I do not know the reason...) > > Would you please try it again? It works now, thank you very much. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 -mm 4/9] netconsole: Add some useful tips to documentation
On Tue, 10 Jul 2007, Joel Becker wrote: > On Wed, Jul 11, 2007 at 03:40:22AM +0530, Satyam Sharma wrote: > > IMHO something that mentions /proc/sys/kernel/printk would be better. > > > > You don't need to have built with SysRq support for that, it's clearly > > more flexible than the ignore_loglevel option and wouldn't require a > > reboot either. I'll send out an updated patch shortly. > > Why not dmesg -n? We've been using that for years. Or is there > some extra change in /proc/sys/kernel/printk? Yes, "dmesg -n" sounds the most straightforward. There are multiple ways of course, for some reason I've always used /proc/sys/kernel/printk for this (which has the extra "feature" that it accepts values greater than 8 too :-) Satyam - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH][NET_SCHED] Make HTB scheduler work with TSO.
From: "Ranjit Manomohan" <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 15:02:16 -0700 > On 7/9/07, David Miller <[EMAIL PROTECTED]> wrote: > > From: Ranjit Manomohan <[EMAIL PROTECTED]> > > Date: Tue, 12 Jun 2007 16:53:21 -0700 (PDT) > > > > > Currently the HTB scheduler does not correctly account for TSO packets > > > which causes large inaccuracies in the bandwidth control when using TSO. > > > This patch allows the HTB scheduler to work with TSO enabled devices. > > > > > > Signed-off-by: Ranjit Manomohan <[EMAIL PROTECTED]> > > > > Your patch has much white-space damage and therefore won't apply, > > please fix this up and resubmit, thanks. > > > > patch based on net-2.6.23 attached. Patch applied, thank you. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [NET]: Update comments for skb checksums
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 09:33:53 +0800 > Hi Dave: > > [NET]: Update comments for skb checksums > > Rusty (whose comments we should all study and emulate :) pointed > out that our comments for skb checksums are no longer up-to-date. > So here is a patch to > > 1) add the case of partial checksums on input; > 2) update partial checksum case to mention csum_start/csum_offset; > 3) mention the new IPv6 feature bit. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Applied, thanks Herbert. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 2/8] Make some network-related proc files use seq_list_xxx helpers
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 17:20:52 -0700 > On Wed, 11 Jul 2007 09:05:13 +0900 (JST) > Yasuyuki KOZAKAI <[EMAIL PROTECTED]> wrote: > > > > > I've met compile error on net-2.6.23 tree. > > > > net/built-in.o: In function `proto_seq_next': > > sock.c:(.text+0x3008): undefined reference to `seq_list_next' > > net/built-in.o: In function `proto_seq_start': > > sock.c:(.text+0x3079): undefined reference to `seq_list_start_head' > > make: *** [.tmp_vmlinux1] Error 1 > > > > crap, that's my fault, sorry. Sending David patches which depend on things > which are in -mm. > > Let me send > make-common-helpers-for-seq_files-that-work-with-list_head-s.patch > Linuswards and it all should come good. I've rebased my tree at: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git now that this has been sorted out. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race
On Tue, 10 Jul 2007 22:12:24 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > But myself, nor any other developers, are going to review your work > any faster if you do things like try to slip things in behind the > maintainer's back as you attempted to do yesterday by asking Andrew to > put your AF_UNIX garbage collector rewrite directly into his -mm tree. mmm... I didn't see it as a slip-behind-the-back thing. More a "park it in -mm for a bit of concurrent testing and so it doesn't get lost and so I don't have to worry about it any more" thing. Plenty of that goes on. It wasn't done in a very subtle way though ;) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race
Just to make it clear Miklos. I have seen your patch as has everyone else. But myself, nor any other developers, are going to review your work any faster if you do things like try to slip things in behind the maintainer's back as you attempted to do yesterday by asking Andrew to put your AF_UNIX garbage collector rewrite directly into his -mm tree. If you read the netdev list, you'll see that I do not lose important postings often if at all, and it is frequently the case that you will in fact see me here replying to postings made weeks if not months ago. You just need to be patient, ok? I run my todo list in a prioritized way, and you need patience instead of annoying me and others over and over about your patch. Thanks in advance for your patience and understanding. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Cbe-oss-dev] [PATCH] spidernet: improve interrupt handling
Linas-san, > On Mon, Jul 09, 2007 at 05:48:08PM +0900, Ishizaki Kou wrote: > > We intend this patch to improve spidernet interrupt handling to be > > more strict. We had following problem and this patch solves it. > > Looks reasonable to me. I'll forward it upstream. In the future, Thank you. > could you use "diff -Nupr"? it adds some extra information > (the name of the subroutine) to the patch chunks; this makes > it easier to read. I see. I will do so next time. Best regards, Kou Ishizaki - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 (updated) -mm 4/9] netconsole: Add some useful tips to documentation
[4/9 (updated)] netconsole: Add some useful tips to documentation Add some useful general-purpose tips. Also suggest solution for the frequent problem of console_loglevel set too low numerically (i.e. for high priority messages only) on the sender. Cc: Matt Mackall <[EMAIL PROTECTED]> Cc: Jesper Juhl <[EMAIL PROTECTED]> Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> --- Documentation/networking/netconsole.txt | 24 1 file changed, 24 insertions(+) --- diff -ruNp a/Documentation/networking/netconsole.txt b/Documentation/networking/netconsole.txt --- a/Documentation/networking/netconsole.txt 2007-04-26 08:38:32.0 +0530 +++ b/Documentation/networking/netconsole.txt 2007-07-11 03:11:08.0 +0530 @@ -44,11 +44,35 @@ WARNING: the default target ethernet set ethernet address to send packets, which can cause increased load on other systems on the same ethernet segment. +TIP: some LAN switches may be configured to suppress ethernet broadcasts +so it is advised to explicitly specify the remote agents' MAC addresses +from the config parameters passed to netconsole. + +TIP: to find out the MAC address of, say, 10.0.0.2, you may try using: + + ping -c 1 10.0.0.2 ; /sbin/arp -n | grep 10.0.0.2 + +TIP: in case the remote logging agent is on a separate LAN subnet than +the sender, it is suggested to try specifying the MAC address of the +default gateway (you may use /sbin/route -n to find it out) as the +remote MAC address instead. + NOTE: the network device (eth1 in the above case) can run any kind of other network traffic, netconsole is not intrusive. Netconsole might cause slight delays in other traffic if the volume of kernel messages is high, but should have no other impact. +NOTE: if you find that the remote logging agent is not receiving or +printing all messages from the sender, it is likely that you have set the +"console_loglevel" parameter (on the sender) to only send high priority +messages to the console. You can change this at runtime by updating +/proc/sys/kernel/printk appropriately, say by: + + echo 9 > /proc/sys/kernel/printk + +which would send all kernel messages to the console. Refer the proc(5) +man page for more details. + Netconsole was designed to be as instantaneous as possible, to enable the logging of even the most critical kernel bugs. It works from IRQ contexts as well, and does not enable interrupts while - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets
On Wed, Jul 11, 2007 at 03:47:09AM +0530, Satyam Sharma wrote: > Hmm, I put it in there because I expected that the user must have had > at least one target configured (added to target_list) if he's got the > module loaded/built-in (and netconsole registered), which is when this > function would be triggered anyway. Loading the module won't happen without a config, but there's no requirement that a built-in netconsole has a kernel command-line argument. I always build netconsole for my kernels. Sure, I usually do it as a module, but if I build a monolithic kernel I compile it in. That doesn't mean I always have a server, let alone a netconsole= option :-) Joel -- "When choosing between two evils, I always like to try the one I've never tried before." - Mae West Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 -mm 4/9] netconsole: Add some useful tips to documentation
On Wed, Jul 11, 2007 at 03:40:22AM +0530, Satyam Sharma wrote: > IMHO something that mentions /proc/sys/kernel/printk would be better. > > You don't need to have built with SysRq support for that, it's clearly > more flexible than the ignore_loglevel option and wouldn't require a > reboot either. I'll send out an updated patch shortly. Why not dmesg -n? We've been using that for years. Or is there some extra change in /proc/sys/kernel/printk? Joel -- "Against stupidity the Gods themselves contend in vain." - Friedrich von Schiller Joel Becker Principal Software Developer Oracle E-mail: [EMAIL PROTECTED] Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 -mm 4/9] netconsole: Add some useful tips to documentation
Hi Jesper, On Tue, 10 Jul 2007, Jesper Juhl wrote: > On Tuesday 10 July 2007 11:41:43 Matt Mackall wrote: > > On Tue, Jul 10, 2007 at 02:49:41PM +0530, Satyam Sharma wrote: > > > From: Satyam Sharma <[EMAIL PROTECTED]> > > > > > > [4/9] netconsole: Add some useful tips to documentation > > > > > > Add some useful general-purpose tips. > > > > > > Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> > > > Cc: Keiichi Kii <[EMAIL PROTECTED]> > > > > Acked-by: Matt Mackall <[EMAIL PROTECTED]> > > > > As long as we're on the subject, I've been meaning to add a note > > telling people to set their console log level to something useful, as > > having that set too low is the most common problem people encounter. > > How about this? > [...] > +Some people forget to raise the kernels log_level to an > +appropriate level and thus don't see all the kernel log messages they > +expect. You can add the kernel boot option "ignore_loglevel" to see all > +messages or you can use SysRq to set the log level to a specific value. > + IMHO something that mentions /proc/sys/kernel/printk would be better. You don't need to have built with SysRq support for that, it's clearly more flexible than the ignore_loglevel option and wouldn't require a reboot either. I'll send out an updated patch shortly. Satyam - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets
Hi, On Tue, 10 Jul 2007, Duane Griffin wrote: > On 10/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > > + /* Avoid taking lock and disabling interrupts unnecessarily */ > > + if (unlikely(list_empty(&target_list))) > > + return; > > Is the unlikely a good idea here? Not having any targets may be > unusual but it isn't ridiculous. It might even be a sensible default > for distros. Hmm, I put it in there because I expected that the user must have had at least one target configured (added to target_list) if he's got the module loaded/built-in (and netconsole registered), which is when this function would be triggered anyway. > My (very limited) understanding of unlikely is that it > could impose a very large penalty in that case and would make a very > marginal difference at best in the common case. I wouldn't call it a large penalty, but yeah, probably the unlikely() there isn't all that important either. Satyam - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[ANNOUNCE] iproute2 2.6.22-070710
This is an update to iproute2 utilities including bug fixes and features related to 2.6.22 kernel. This package tries to be source compatible across releases. The same source should build on older systems, but obviously the newer kernel features won't be available. It can be downloaded from: http://developer.osdl.org/dev/iproute2/download/iproute2-2.6.22-070710.tar.gz Repository: git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git For more info on iproute2 see: http://linux-net.osdl.org/index.php/Iproute2 Changelog David Lamparter (1): iproute2: Format IPv6 tunnels endpoints nicely. Mike Frysinger (1): ip/routef lifesaver Patrick McHardy (1): Fwd: Re: more iproute2 issues (not critical) Pavel Roskin (1): ip: add support for displaying link types 802 and 803 Stephen Hemminger (11): Revert "Increase internal clock resolution to nsec" Add xt_tcpudp.h incorrect initialization headers update to 2.6.22 fix last change fix build warnings netem: static Add TC_LIB_DIR environment variable. ss: fix issues with signed inodes Thomas Graf (2): iproute2: support for goto/nop action and detached flag iproute2: Support IFF_LOWER_UP and IFF_DORMANT Yasuyuki KOZAKAI (1): Fix symbolic link to tc-bfifo.8 jamal (2): SAD info SPD info -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[NET]: Update comments for skb checksums
Hi Dave:
[NET]: Update comments for skb checksums
Rusty (whose comments we should all study and emulate :) pointed
out that our comments for skb checksums are no longer up-to-date.
So here is a patch to
1) add the case of partial checksums on input;
2) update partial checksum case to mention csum_start/csum_offset;
3) mention the new IPv6 feature bit.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -65,13 +65,20 @@
* is able to produce some skb->csum, it MUST use COMPLETE,
* not UNNECESSARY.
*
+ * PARTIAL: identical to the case for output below. This may occur
+ * on a packet received directly from another Linux OS, e.g.,
+ * a virtualised Linux kernel on the same host. The packet can
+ * be treated in the same way as UNNECESSARY except that on
+ * output (i.e., forwarding) the checksum must be filled in
+ * by the OS or the hardware.
+ *
* B. Checksumming on output.
*
* NONE: skb is checksummed by protocol or csum is not required.
*
* PARTIAL: device is required to csum packet as seen by hard_start_xmit
- * from skb->transport_header to the end and to record the checksum
- * at skb->transport_header + skb->csum.
+ * from skb->csum_start to the end and to record the checksum
+ * at skb->csum_start + skb->csum_offset.
*
* Device must show its capabilities in dev->features, set
* at device setup time.
@@ -82,6 +89,7 @@
* TCP/UDP over IPv4. Sigh. Vendors like this
* way by an unknown reason. Though, see comment above
* about CHECKSUM_UNNECESSARY. 8)
+ * NETIF_F_IPV6_CSUM about as dumb as the last one but does IPv6 instead.
*
* Any questions? No questions, good. --ANK
*/
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 2/8] Make some network-related proc files use seq_list_xxx helpers
I've met compile error on net-2.6.23 tree. net/built-in.o: In function `proto_seq_next': sock.c:(.text+0x3008): undefined reference to `seq_list_next' net/built-in.o: In function `proto_seq_start': sock.c:(.text+0x3079): undefined reference to `seq_list_start_head' make: *** [.tmp_vmlinux1] Error 1 -- Yasuyuki Kozakai From: David Miller <[EMAIL PROTECTED]> Date: Mon, 09 Jul 2007 13:15:23 -0700 (PDT) > From: [EMAIL PROTECTED] > Date: Mon, 09 Jul 2007 11:51:10 -0700 > > > From: Pavel Emelianov <[EMAIL PROTECTED]> > > > > This includes /proc/net/protocols, /proc/net/rxrpc_calls and > > /proc/net/rxrpc_connections files. > > > > All three need seq_list_start_head to show some header. > > > > Signed-off-by: Pavel Emelianov <[EMAIL PROTECTED]> > > Acked-by: David S. Miller <[EMAIL PROTECTED]> > > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> > > Applied, thanks. > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fwd: r8169 driver supporting the 8167 dev ID
The patchkit from 2.6.18 to (almost) current contains 47 patches.
git is a wonderful tool for endless nights of S&M backporting but
I'd appreciate to understand why you can not use a more recent kernel
before engaging.
Not a problem, sorry i didn't mention it before. i am using
smoothwall 3. it is using kernel 2.6.16.52.
i will also take a look at how to patch it currently using git. never
used git before so i'll download it and compile it in on the dev box.
once i get it working, would running
git format-patch v2.6.18..v2.6.23-rc1 -- drivers/net/r8169.c
update it so that it would compile a backwards port for me?
On 7/10/07, Francois Romieu <[EMAIL PROTECTED]> wrote:
Jonathan Larsen <[EMAIL PROTECTED]> :
> I've been looking for the r8169 driver that is for the 2.6.x kernel
> and also supports the device id 8167, 10ec. chipset is the 8110sc.
> im sure someone is familiar with this.
It is not the most used chipset in the 816x family but there are
some known users, yes.
> i noticed on the most latest kernel that such a driver exists. i
> downloaded a gentoo live cd and found out. im trying to compile a
> driver for a 2.6.16.52 kernel, it's for smoothwall.
> i was hoping someone could help me out in getting the source so i
> could compile it under the 2.6.16.52 kernel and have it work with my
> 8110sc chipset nic's.
The patchkit from 2.6.18 to (almost) current contains 47 patches.
git is a wonderful tool for endless nights of S&M backporting but
I'd appreciate to understand why you can not use a more recent kernel
before engaging.
> hope i've included enough info and description in what i am trying to
> accomplish. i just hope it's possible. thank you! :)
git format-patch v2.6.18..v2.6.23-rc1 -- drivers/net/r8169.c
gives a good summary of the changes in the r8169 driver.
One starts from a 2.6.16.something base and cycle through
{apply/ignore}/compile/fix {reject/api change} for each
patch until the r8169 driver reaches a decent state.
It is not difficult but it takes time.
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 2/8] Make some network-related proc files use seq_list_xxx helpers
On Wed, 11 Jul 2007 09:05:13 +0900 (JST) Yasuyuki KOZAKAI <[EMAIL PROTECTED]> wrote: > > I've met compile error on net-2.6.23 tree. > > net/built-in.o: In function `proto_seq_next': > sock.c:(.text+0x3008): undefined reference to `seq_list_next' > net/built-in.o: In function `proto_seq_start': > sock.c:(.text+0x3079): undefined reference to `seq_list_start_head' > make: *** [.tmp_vmlinux1] Error 1 > crap, that's my fault, sorry. Sending David patches which depend on things which are in -mm. Let me send make-common-helpers-for-seq_files-that-work-with-list_head-s.patch Linuswards and it all should come good. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/5] net: use numa_node in net_devcice->dev instead of parent
[PATCH 2/5] net: use numa_node in net_devcice->dev instead of parent
Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]>
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 27cfe5f..005cc1c 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -217,7 +217,7 @@ nodata:
struct sk_buff *__netdev_alloc_skb(struct net_device *dev,
unsigned int length, gfp_t gfp_mask)
{
- int node = dev->dev.parent ? dev_to_node(dev->dev.parent) : -1;
+ int node = dev_to_node(&dev->dev);
struct sk_buff *skb;
skb = __alloc_skb(length + NET_SKB_PAD, gfp_mask, 0, node);
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/5] more about numa_node with struct device
these are revised or new patch with numa_node in struct device in addition to andrew already sent to andi x86_64-get-mp_bus_to_node-as-early.patch it will make all pci_dev->dev.numa_node correctly. still in -mm, and andrew will re-review for 2.6.23 dma-make-dma-pool-to-use-kmalloc_node.patch in greg tree usb-make-the-usb_device-numa_node-get-assigned-from-controller.patch Thanks Yinghai Lu - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/5] net: show numa_node for net_device in /sys
[PATCH 4/5] net: show numa_node for net_device in /sys
Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]>
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 5c19b06..45b87a5 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -230,6 +230,14 @@ static ssize_t store_weight(struct device *dev, struct
device_attribute *attr,
return netdev_store(dev, attr, buf, len, change_weight);
}
+#ifdef CONFIG_NUMA
+static ssize_t
+numa_node_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+return sprintf (buf, "%d\n", dev->numa_node);
+}
+#endif
+
static struct device_attribute net_class_attributes[] = {
__ATTR(addr_len, S_IRUGO, show_addr_len, NULL),
__ATTR(iflink, S_IRUGO, show_iflink, NULL),
@@ -247,6 +255,9 @@ static struct device_attribute net_class_attributes[] = {
__ATTR(tx_queue_len, S_IRUGO | S_IWUSR, show_tx_queue_len,
store_tx_queue_len),
__ATTR(weight, S_IRUGO | S_IWUSR, show_weight, store_weight),
+#ifdef CONFIG_NUMA
+__ATTR_RO(numa_node),
+#endif
{}
};
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 5/5] dma: use dev_to_node to get node for device in dma_alloc_pages
[PATCH 5/5] dma: use dev_to_node to get node for device in dma_alloc_pages
Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]>
diff --git a/arch/x86_64/kernel/pci-dma.c b/arch/x86_64/kernel/pci-dma.c
index 9f80aad..6dbf1c9 100644
--- a/arch/x86_64/kernel/pci-dma.c
+++ b/arch/x86_64/kernel/pci-dma.c
@@ -52,11 +52,9 @@ dma_alloc_pages(struct device *dev, gfp_t gfp, unsigned
order)
{
struct page *page;
int node;
-#ifdef CONFIG_PCI
- if (dev->bus == &pci_bus_type)
- node = pcibus_to_node(to_pci_dev(dev)->bus);
- else
-#endif
+
+ node = dev_to_node(dev);
+ if (node == -1)
node = numa_node_id();
if (node < first_node(node_online_map))
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/5] try parent numa_node at first before using default
[PATCH 1/5] try parent numa_node at first before using default
For pci_device, pcibios_scan_root and pci_scan_root will call pci_device_add.
pci_device_add will call device_initialize and set_dev_node(&dev->dev,
pcibus_to_node(bus)).
other device such as netdev, and usb_device, set_dev_node is never be
used. So that field numa_node always is -1.
So for netdev, it will need to use dev->parent to get pci_device to
use it's numa_node. esp in netdev_alloc_skb()
not sure how other device such as infiniband do that.
Actually before patch
[PATCH 1/2] x86_64: get mp_bus_to_node as early
there is a bug about squence of bus->sysdata and using pcibus_to_node.
the numa_node of pci_dev->dev is never set correctly...always 0.
So some device have to use pcibus_to_node(to_pci_dev(dev)->bus) directly
such as dma_alloc_pages in arch/x86_64/kernel/pci-dma.c.
or hwif_to_node in include/linux/ide.h
with this patch, we could use device->numa_node direclty for all device.
Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]>
diff --git a/drivers/base/core.c b/drivers/base/core.c
index dd40d78..c344d82 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n)
void device_initialize(struct device *dev)
{
+ int node;
+
kobj_set_kset_s(dev, devices_subsys);
kobject_init(&dev->kobj);
klist_init(&dev->klist_children, klist_children_get,
@@ -557,7 +559,9 @@ void device_initialize(struct device *dev)
spin_lock_init(&dev->devres_lock);
INIT_LIST_HEAD(&dev->devres_head);
device_init_wakeup(dev, 0);
- set_dev_node(dev, -1);
+
+ node = dev->parent ? dev_to_node(dev->parent) : -1;
+ set_dev_node(dev, node);
}
#ifdef CONFIG_SYSFS_DEPRECATED
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: No network on Asus P5B (r8169)
Clemens Brunner <[EMAIL PROTECTED]> : [...] > I just found out that everything is working just fine with a 64-bit Linux > kernel. I hope this helps you hunt down the error in the 32-bit version. > https://bugzilla.novell.com/show_bug.cgi?id=288406 Does your setup exclude the "wake up" issue described in http://gentoo-wiki.com/HARDWARE_RTL8168 ? -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix kernel unaligned access with r8169 on sparc64
Francois Romieu <[EMAIL PROTECTED]> :
[...]
> - try http://www.fr.zoreil.com/people/francois/backport/r8169/20070604-00
> It is a backport against 2.6.18 which should bring you quite close to
> 2.6.23-git wrt r8169.
Regarding the backport option, it was initially more a compiled-ok-untested-
use-at-your-own-risk thing than anything else. I have given it a try with
2.6.18 and it does not blow up immediately. I suggest adding the attached
patch at the end of the serie to fix a locking bug though.
--
Ueimor
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index eaf5373..982a901 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -135,8 +135,8 @@ static const struct {
u32 RxConfigMask; /* Clears the bits supported by this chip */
} rtl_chip_info[] = {
_R("RTL8169", RTL_GIGA_MAC_VER_01, 0xff7e1880), // 8169
- _R("RTL8169s/8110s",RTL_GIGA_MAC_VER_02, 0xff7e1880), // 8169S
- _R("RTL8169s/8110s",RTL_GIGA_MAC_VER_03, 0xff7e1880), // 8110S
+ _R("RTL8169s", RTL_GIGA_MAC_VER_02, 0xff7e1880), // 8169S
+ _R("RTL8110s", RTL_GIGA_MAC_VER_03, 0xff7e1880), // 8110S
_R("RTL8169sb/8110sb", RTL_GIGA_MAC_VER_04, 0xff7e1880), // 8169SB
_R("RTL8169sc/8110sc", RTL_GIGA_MAC_VER_05, 0xff7e1880), // 8110SCd
_R("RTL8169sc/8110sc", RTL_GIGA_MAC_VER_06, 0xff7e1880), // 8110SCe
@@ -1391,22 +1380,26 @@ static void rtl8169_init_phy(struct net_device *dev,
struct rtl8169_private *tp)
printk(KERN_INFO PFX "%s: TBI auto-negotiating\n", dev->name);
}
-static void rtl8169_rar_set(struct rtl8169_private *tp, u8 *addr)
+static void rtl_rar_set(struct rtl8169_private *tp, u8 *addr)
{
void __iomem *ioaddr = tp->mmio_addr;
- u32 low;
u32 high;
+ u32 low;
low = addr[0] | (addr[1] << 8) | (addr[2] << 16) | (addr[3] << 24);
high = addr[4] | (addr[5] << 8);
+ spin_lock_irq(&tp->lock);
+
RTL_W8(Cfg9346, Cfg9346_Unlock);
RTL_W32(MAC0, low);
RTL_W32(MAC4, high);
RTL_W8(Cfg9346, Cfg9346_Lock);
+
+ spin_unlock_irq(&tp->lock);
}
-static int rtl8169_set_mac_address(struct net_device *dev, void *p)
+static int rtl_set_mac_address(struct net_device *dev, void *p)
{
struct rtl8169_private *tp = netdev_priv(dev);
struct sockaddr *addr = p;
@@ -1416,7 +1409,7 @@ static int rtl8169_set_mac_address(struct net_device
*dev, void *p)
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
- rtl8169_rar_set(tp, dev->dev_addr);
+ rtl_rar_set(tp, dev->dev_addr);
return 0;
}
@@ -1650,7 +1645,7 @@ rtl8169_init_one(struct pci_dev *pdev, const struct
pci_device_id *ent)
dev->irq = pdev->irq;
dev->base_addr = (unsigned long) ioaddr;
dev->change_mtu = rtl8169_change_mtu;
- dev->set_mac_address = rtl8169_set_mac_address;
+ dev->set_mac_address = rtl_set_mac_address;
#ifdef CONFIG_R8169_NAPI
dev->poll = rtl8169_poll;
Re: [PATCH][NET_SCHED] Make HTB scheduler work with TSO.
On 7/9/07, David Miller <[EMAIL PROTECTED]> wrote:
From: Ranjit Manomohan <[EMAIL PROTECTED]>
Date: Tue, 12 Jun 2007 16:53:21 -0700 (PDT)
> Currently the HTB scheduler does not correctly account for TSO packets
> which causes large inaccuracies in the bandwidth control when using TSO.
> This patch allows the HTB scheduler to work with TSO enabled devices.
>
> Signed-off-by: Ranjit Manomohan <[EMAIL PROTECTED]>
Your patch has much white-space damage and therefore won't apply,
please fix this up and resubmit, thanks.
patch based on net-2.6.23 attached.
-Thanks,
Ranjit
Currently the HTB scheduler does not correctly account for TSO packets
which causes large inaccuracies in the bandwidth control when using TSO.
This patch allows the HTB scheduler to work with TSO enabled devices.
Signed-off-by: Ranjit Manomohan <[EMAIL PROTECTED]>
diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index c031486..b417a95 100644
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -129,15 +129,12 @@ struct htb_class {
/* of un.leaf originals should be done. */
};
-/* TODO: maybe compute rate when size is too large .. or drop ? */
static inline long L2T(struct htb_class *cl, struct qdisc_rate_table *rate,
int size)
{
int slot = size >> rate->rate.cell_log;
- if (slot > 255) {
- cl->xstats.giants++;
- slot = 255;
- }
+ if (slot > 255)
+ return (rate->data[255]*(slot >> 8) + rate->data[slot & 0xFF]);
return rate->data[slot];
}
@@ -606,13 +603,14 @@ #endif
cl->qstats.drops++;
return NET_XMIT_DROP;
} else {
- cl->bstats.packets++;
+ cl->bstats.packets +=
+ skb_is_gso(skb)?skb_shinfo(skb)->gso_segs:1;
cl->bstats.bytes += skb->len;
htb_activate(q, cl);
}
sch->q.qlen++;
- sch->bstats.packets++;
+ sch->bstats.packets += skb_is_gso(skb)?skb_shinfo(skb)->gso_segs:1;
sch->bstats.bytes += skb->len;
return NET_XMIT_SUCCESS;
}
@@ -661,8 +659,9 @@ static int htb_requeue(struct sk_buff *s
* In such case we remove class from event queue first.
*/
static void htb_charge_class(struct htb_sched *q, struct htb_class *cl,
- int level, int bytes)
+ int level, struct sk_buff *skb)
{
+ int bytes = skb->len;
long toks, diff;
enum htb_cmode old_mode;
@@ -698,7 +697,8 @@ #define HTB_ACCNT(T,B,R) toks = diff + c
/* update byte stats except for leaves which are already updated */
if (cl->level) {
cl->bstats.bytes += bytes;
- cl->bstats.packets++;
+ cl->bstats.packets += skb_is_gso(skb)?
+ skb_shinfo(skb)->gso_segs:1;
}
cl = cl->parent;
}
@@ -882,7 +882,7 @@ next:
gives us slightly better performance */
if (!cl->un.leaf.q->q.qlen)
htb_deactivate(q, cl);
- htb_charge_class(q, cl, level, skb->len);
+ htb_charge_class(q, cl, level, skb);
}
return skb;
}
Re: Fwd: r8169 driver supporting the 8167 dev ID
Jonathan Larsen <[EMAIL PROTECTED]> :
> I've been looking for the r8169 driver that is for the 2.6.x kernel
> and also supports the device id 8167, 10ec. chipset is the 8110sc.
> im sure someone is familiar with this.
It is not the most used chipset in the 816x family but there are
some known users, yes.
> i noticed on the most latest kernel that such a driver exists. i
> downloaded a gentoo live cd and found out. im trying to compile a
> driver for a 2.6.16.52 kernel, it's for smoothwall.
> i was hoping someone could help me out in getting the source so i
> could compile it under the 2.6.16.52 kernel and have it work with my
> 8110sc chipset nic's.
The patchkit from 2.6.18 to (almost) current contains 47 patches.
git is a wonderful tool for endless nights of S&M backporting but
I'd appreciate to understand why you can not use a more recent kernel
before engaging.
> hope i've included enough info and description in what i am trying to
> accomplish. i just hope it's possible. thank you! :)
git format-patch v2.6.18..v2.6.23-rc1 -- drivers/net/r8169.c
gives a good summary of the changes in the r8169 driver.
One starts from a 2.6.16.something base and cycle through
{apply/ignore}/compile/fix {reject/api change} for each
patch until the r8169 driver reaches a decent state.
It is not difficult but it takes time.
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix kernel unaligned access with r8169 on sparc64
Philip Craig <[EMAIL PROTECTED]> : [...] > Try the patches at http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.22-rc6/ > I think patches 0012 and/or 0017 will fix this. They should but they will not apply directly against 2.6.18-something. Florian, can you consider one of the option below: - try current 2.6.23-git. It contains the changes which should fix your alignment issues. - try http://www.fr.zoreil.com/people/francois/backport/r8169/20070604-00 It is a backport against 2.6.18 which should bring you quite close to 2.6.23-git wrt r8169. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ata and netdev (was Re: -mm merge plans for 2.6.23)
On Wed, 11 Jul 2007 00:31:23 +0400 Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > Hello. > > Andrew Morton wrote: > > > 3x59x-fix-pci-resource-management.patch: you wrote it ;) I have a comment > > No, I did, almost a year ago already. :-) I thought that was odd. I fixed the attribution. > > here: > > > - I don't remember the story with cardbus either. Presumably once upon a > > time the cardbus layer was claiming IO regions on behalf of cardbus > > devices (?) > > IIRC, that's your own comment. yup, that's what "I have a comment" meant ;) The comment seems rather bogus actually. Let's just merge it. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ata and netdev (was Re: -mm merge plans for 2.6.23)
Hello. Andrew Morton wrote: 3x59x-fix-pci-resource-management.patch: you wrote it ;) I have a comment No, I did, almost a year ago already. :-) here: - I don't remember the story with cardbus either. Presumably once upon a time the cardbus layer was claiming IO regions on behalf of cardbus devices (?) IIRC, that's your own comment. Need to think about that. WBR, Sergei - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6 patch] the scheduled sk98lin removal
On Tue, 10 Jul 2007, Chris Stromsoe wrote: On Tue, 10 Jul 2007, Stephen Hemminger wrote: On Tue, 10 Jul 2007 12:44:35 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Adrian Bunk wrote: This patch contains the scheduled removal of the sk98lin driver. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Stephen -- ACK? Yes. Existing driver is dead, if there are any ancient boards that don't work with skge, I haven't heard any complaints in at least a year. As a fallback users, can always go with vendor driver. I have a several SK-9872s that do not work reliably with skge but work fine with sklin. The SK-9872 is a dual port card. Doing the following causes a hard lock: sorry - SK-9844, not 9872. modprobe bonding miimon=100 mode=active-backup modprobe skge ifup bond0 ifdown bond0 This happens with every version of skge I've tested, including whatever is in 2.6.22. /etc/network/interfaces contains: iface bond0 inet static network 192.168.1.0 address 192.168.1.1 broadcast 192.168.1.255 netmask 255.255.255.0 up ifenslave bond0 eth0 eth1 down ifenslave -d bond0 eth0 eth1 lspci -vv -s 02:01 02:01.0 Ethernet controller: SysKonnect SK-9872 Gigabit Ethernet Server Adapter (SK-NET GE-ZX dual link) (rev 11) Subsystem: SysKonnect SK-9844 Gigabit Ethernet Server Adapter (SK-NET GE-SX dual link) Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR+ FastB2B- Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- SERR- Latency: 64 (5750ns min, 7750ns max), Cache Line Size: 32 bytes Interrupt: pin A routed to IRQ 22 Region 0: Memory at febfc000 (32-bit, non-prefetchable) [size=16K] Region 1: I/O ports at e800 [size=256] Expansion ROM at febc [disabled] [size=128K] Capabilities: -Chris - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6 patch] the scheduled sk98lin removal
On Tue, 10 Jul 2007, Stephen Hemminger wrote: On Tue, 10 Jul 2007 12:44:35 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Adrian Bunk wrote: This patch contains the scheduled removal of the sk98lin driver. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Stephen -- ACK? Yes. Existing driver is dead, if there are any ancient boards that don't work with skge, I haven't heard any complaints in at least a year. As a fallback users, can always go with vendor driver. I have a several SK-9872s that do not work reliably with skge but work fine with sklin. The SK-9872 is a dual port card. Doing the following causes a hard lock: modprobe bonding miimon=100 mode=active-backup modprobe skge ifup bond0 ifdown bond0 This happens with every version of skge I've tested, including whatever is in 2.6.22. /etc/network/interfaces contains: iface bond0 inet static network 192.168.1.0 address 192.168.1.1 broadcast 192.168.1.255 netmask 255.255.255.0 up ifenslave bond0 eth0 eth1 down ifenslave -d bond0 eth0 eth1 lspci -vv -s 02:01 02:01.0 Ethernet controller: SysKonnect SK-9872 Gigabit Ethernet Server Adapter (SK-NET GE-ZX dual link) (rev 11) Subsystem: SysKonnect SK-9844 Gigabit Ethernet Server Adapter (SK-NET GE-SX dual link) Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR+ FastB2B- Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- SERR- -Chris - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ata and netdev (was Re: -mm merge plans for 2.6.23)
Hello. Jeff Garzik wrote: 3x59x-fix-pci-resource-management.patch Now that the fix for CONFIG_PCI=n has been merged, what's left is to test this on EISA (at least Andrew wanted it :-). netdev patches which are stuck in limbo land. ? I don't think I've seen these. You should have, I was sending it to you. WBR, Sergei - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan
On Tue, Jul 10, 2007 at 02:25:12PM -0500, Larry Finger wrote: > Jean, > > Jean Tourrilhes wrote: > > Hi, > > > > SoftMAC output the channel twice in the scan output. It should > >display frequency and channel, but only once for each. > > > > Cell 02 - Address: A2:00:04:XX:XX:XX > >ESSID:"TheESSID" > >Protocol:IEEE 802.11b > >Mode:Ad-Hoc > >-> Channel:5 > >-> Frequency:2.432 GHz (Channel 5) > > The frequency output is needed by NetworkManager, which is why I added it. > At that time, I thought that some tool or other might be scanning the > output looking for "Channel:", not "Channel "; therefore I left both in. All of the other drivers display only a single line, and SoftMAC is the odd one here. I think that have the info twice may confuse some tools. I know that there are scripts that parse iwlist output, however I'm not keen on the practice, as there are alternatives. > If we are sure that removing the channel-only line will not break > something, I'll be happy to send your patch upstream. Unfortunately, I can't guarantee that. I can only guarantee that it will be similar to what other drivers do. > Larry Have fun... Jean - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan
Jean, Jean Tourrilhes wrote: Hi, SoftMAC output the channel twice in the scan output. It should display frequency and channel, but only once for each. Cell 02 - Address: A2:00:04:XX:XX:XX ESSID:"TheESSID" Protocol:IEEE 802.11b Mode:Ad-Hoc -> Channel:5 -> Frequency:2.432 GHz (Channel 5) The frequency output is needed by NetworkManager, which is why I added it. At that time, I thought that some tool or other might be scanning the output looking for "Channel:", not "Channel "; therefore I left both in. If we are sure that removing the channel-only line will not break something, I'll be happy to send your patch upstream. Larry - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Please pull 'upstream-jgarzik' branch of wireless-2.6
The following changes since commit 71780f59e127bb281a9302d430495ca9586c14e7:
Linus Torvalds (1):
Merge branch 'for-linus' of
git://git.kernel.org/.../ieee1394/linux1394-2.6
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
upstream-jgarzik
Adrian Bunk (1):
drivers/net/wireless/libertas/wext.c: remove dead code
Dan Williams (1):
libertas: fix disabling WPA
Daniel Drake (4):
zd1211rw: Allow channels 1-11 for unrecognised regulatory domains
zd1211rw: Detect more AL2230S radios
zd1211rw: Add ID for Buffalo WLI-U2-KG54L
zd1211rw: Defer firmware load until first ifup
Holger Schurig (1):
libertas: fix use-after-free in rx path
Jean Tourrilhes (1):
softmac: Fix ESSID problem
Matthias Kaehlcke (1):
use list_for_each_entry() for iteration in Prism 54 driver
Michael Wu (1):
rtl8187: fix endianness issue in rtl8225 register writing
Michal Schmidt (5):
airo: disable the PCI device when unloading module
airo: delay some initialization until the netdev is up
airo: fix a race causing initialization failures
airo: simpler calling convention for enable_MAC()
airo: start with radio off
Robert P. J. Day (1):
WIRELESS: Remove clearly obsolete libertas/version.h file.
Stephen Hemminger (2):
ipw2200: rf kill switch polling power saving
ipw2100: RF kill switch timer power save
drivers/net/wireless/airo.c| 208
drivers/net/wireless/ipw2100.c | 11 +-
drivers/net/wireless/ipw2200.c |5 +-
drivers/net/wireless/libertas/cmd.c|2 +-
drivers/net/wireless/libertas/rx.c |1 -
drivers/net/wireless/libertas/version.h|1 -
drivers/net/wireless/libertas/wext.c |3 -
drivers/net/wireless/prism54/isl_ioctl.c | 22 +--
drivers/net/wireless/rtl8187_rtl8225.c |4 +-
drivers/net/wireless/zd1211rw/zd_chip.c| 88 ++-
drivers/net/wireless/zd1211rw/zd_chip.h| 13 +-
drivers/net/wireless/zd1211rw/zd_mac.c | 59 +---
drivers/net/wireless/zd1211rw/zd_mac.h |3 +-
drivers/net/wireless/zd1211rw/zd_rf.c |3 +-
drivers/net/wireless/zd1211rw/zd_rf.h |2 +-
drivers/net/wireless/zd1211rw/zd_rf_al2230.c | 12 +-
drivers/net/wireless/zd1211rw/zd_rf_al7230b.c |2 +-
drivers/net/wireless/zd1211rw/zd_rf_rf2959.c |2 +-
drivers/net/wireless/zd1211rw/zd_rf_uw2453.c |2 +-
drivers/net/wireless/zd1211rw/zd_usb.c | 98 ---
drivers/net/wireless/zd1211rw/zd_usb.h |3 +
net/ieee80211/softmac/ieee80211softmac_assoc.c |5 +-
22 files changed, 280 insertions(+), 269 deletions(-)
delete mode 100644 drivers/net/wireless/libertas/version.h
diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
index 2d3a180..1c54908 100644
--- a/drivers/net/wireless/airo.c
+++ b/drivers/net/wireless/airo.c
@@ -52,6 +52,8 @@
#include "airo.h"
+#define DRV_NAME "airo"
+
#ifdef CONFIG_PCI
static struct pci_device_id card_ids[] = {
{ 0x14b9, 1, PCI_ANY_ID, PCI_ANY_ID, },
@@ -71,7 +73,7 @@ static int airo_pci_suspend(struct pci_dev *pdev,
pm_message_t state);
static int airo_pci_resume(struct pci_dev *pdev);
static struct pci_driver airo_driver = {
- .name = "airo",
+ .name = DRV_NAME,
.id_table = card_ids,
.probe= airo_pci_probe,
.remove = __devexit_p(airo_pci_remove),
@@ -1092,7 +1094,7 @@ static int get_dec_u16( char *buffer, int *start, int
limit );
static void OUT4500( struct airo_info *, u16 register, u16 value );
static unsigned short IN4500( struct airo_info *, u16 register );
static u16 setup_card(struct airo_info*, u8 *mac, int lock);
-static int enable_MAC( struct airo_info *ai, Resp *rsp, int lock );
+static int enable_MAC(struct airo_info *ai, int lock);
static void disable_MAC(struct airo_info *ai, int lock);
static void enable_interrupts(struct airo_info*);
static void disable_interrupts(struct airo_info*);
@@ -1250,7 +1252,7 @@ static int flashputbuf(struct airo_info *ai);
static int flashrestart(struct airo_info *ai,struct net_device *dev);
#define airo_print(type, name, fmt, args...) \
- { printk(type "airo(%s): " fmt "\n", name, ##args); }
+ printk(type DRV_NAME "(%s): " fmt "\n", name, ##args)
#define airo_print_info(name, fmt, args...) \
airo_print(KERN_INFO, name, fmt, ##args)
@@ -1926,28 +1928,54 @@ static int readStatsRid(struct airo_info*ai, StatsRid
*sr, int rid, int lock) {
return rc;
}
+static void try_auto_wep(struct airo_info *ai)
+{
+ if (auto_wep && !(ai->flags & FLAG_RADIO_DOWN)) {
+ ai->expires = RUN_AT(3*HZ);
+ wake_up_interruptible(&ai->thr_wait);
+ }
+}
+
static int airo_open(struct net_device *dev) {
- st
Re: ata and netdev (was Re: -mm merge plans for 2.6.23)
Andrew Morton wrote: On Tue, 10 Jul 2007 13:42:16 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: (just to provide my indicator of status) Thanks. libata-add-irq_flags-to-struct-pata_platform_info-fix.patch are other pata_platform people happy with this? I don't know embedded well enough to know if adding this struct member will break things. This is just a silly remove-unneeded-cast-of-void* cleanup. I wrote this as a fixup against libata-add-irq_flags-to-struct-pata_platform_info.patch with the intention of folding it into that base patch, but you went and merged the submitter's original patch so this trivial fixup got stranded in -mm. Feel free to give it the piss-off-too-trivial treatment. I'm sorry, I didn't look closely enough. I was referring to the add-irq-flags patch itself, not your small fix. ata-ahci-alpm-store-interrupt-value.patch ata-ahci-alpm-expose-power-management-policy-option-to-users.patch ata-ahci-alpm-enable-link-power-management-for-ata-drivers.patch ata-ahci-alpm-enable-aggressive-link-power-management-for-ahci-controllers.patch These appear to need some work. seemed mostly OK to me. what comments did I miss? Oh, I thought these were the patches which affected scsi and which James had issues with. I guess I got confused. hrm. ISTR James wanted some cleanups, Kristen did some cleanups, then looking at the cleanups decided they were needed / appropriate at this time. Anyway, these are in my mbox queue and the libata portions (of which the code is the majority) seem OK. Need to give them a final review. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ata and netdev (was Re: -mm merge plans for 2.6.23)
On Tue, 2007-07-10 at 11:24 -0700, Andrew Morton wrote: > > > ata-ahci-alpm-store-interrupt-value.patch > > > ata-ahci-alpm-expose-power-management-policy-option-to-users.patch > > > ata-ahci-alpm-enable-link-power-management-for-ata-drivers.patch > > > ata-ahci-alpm-enable-aggressive-link-power-management-for-ahci-controllers.patch > > > > > > These appear to need some work. > > > > seemed mostly OK to me. what comments did I miss? > > Oh, I thought these were the patches which affected scsi and which James > had issues with. I guess I got confused. Well ... my concern was really how to make them more generic ... ahci isn't the only controller that can do phy power management, and it also seemed to me that the most generic entity for power management was the transport rather than the SCSI mid-layer, but that debate is still ongoing. James - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH re-resend] fix race in AF_UNIX garbage collector
> > On Tue, 10 Jul 2007 11:50:30 +0200 Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > > > > Can you please add this to -mm. Sometimes that has wonderful effect > > > on the willingness of people to look at a patch. > > > > sure ;) > > Andrew please don't, it's in my "to review" pile. Yeah, and I can guess, where it is sitting in that pile ;) Dave, if you are busy, just say so. But if you don't reply anything, I'm bound to think the patch is being ignored. I apologize for being annoying. Just let's get over this bloody bug ;) Thanks, Miklos - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/1] ixgbe: Support for Intel(R) 10GbE PCI Express adapters - Take #2
[EMAIL PROTECTED] wrote: This patch adds support for the Intel(R) 82598 based PCI Express 10GbE adapters. Please find the full driver as a patch to latest linus-2.6 tree here: git-pull git://lost.foo-projects.org/~aveerani/git/linux-2.6 ixgbe Andrew, I rebased this with the new driver code, so you might need to drop the old version. Cheers, Auke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2.6] SoftMAC : fix duplicate display of channel in scan
Hi, SoftMAC output the channel twice in the scan output. It should display frequency and channel, but only once for each. Cell 02 - Address: A2:00:04:XX:XX:XX ESSID:"TheESSID" Protocol:IEEE 802.11b Mode:Ad-Hoc -> Channel:5 -> Frequency:2.432 GHz (Channel 5) Encryption key:off Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s Quality=95/100 Signal level=-47 dBm Noise level=-65 dBm Extra: Last beacon: 120ms ago The fix is simple, patch attached, tested for 2.6.22 with bcm43xx. If you like it, send it to John. Regards, Jean Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]> --- --- linux/net/ieee80211/ieee80211_wx.j1.c 2007-07-10 11:28:55.0 -0700 +++ linux/net/ieee80211/ieee80211_wx.c 2007-07-10 11:31:18.0 -0700 @@ -90,14 +90,11 @@ static char *ieee80211_translate_scan(st } /* Add channel and frequency */ + /* Note : userspace automatically computes channel using iwrange */ iwe.cmd = SIOCGIWFREQ; - iwe.u.freq.m = network->channel; - iwe.u.freq.e = 0; - iwe.u.freq.i = 0; - start = iwe_stream_add_event(start, stop, &iwe, IW_EV_FREQ_LEN); - iwe.u.freq.m = ieee80211_channel_to_freq(ieee, network->channel); iwe.u.freq.e = 6; + iwe.u.freq.i = 0; start = iwe_stream_add_event(start, stop, &iwe, IW_EV_FREQ_LEN); /* Add encryption capability */ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: iproute2 showing wrong number of bytes on 64bit architectures.
From: "Chris Friesen" <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 12:17:12 -0600 > It's rather ironic that the "new-and-improved" way of doing things is > subject to rollover while the "old" way is not. Text is always more flexible, but is hard to extend. We can trivially add "u64" statistics to netlink. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: iproute2 showing wrong number of bytes on 64bit architectures.
David Miller wrote: It used unsigned long ages ago, and ifconfig gets the bits exported from /proc/net/dev output whereas we have to used fixed data types in whatever we use over netlink so u32 was choosen. It's rather ironic that the "new-and-improved" way of doing things is subject to rollover while the "old" way is not. Chris - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ata and netdev (was Re: -mm merge plans for 2.6.23)
On Tue, 10 Jul 2007 13:42:16 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > > (just to provide my indicator of status) Thanks. > > libata-add-irq_flags-to-struct-pata_platform_info-fix.patch > > are other pata_platform people happy with this? I don't know embedded > well enough to know if adding this struct member will break things. This is just a silly remove-unneeded-cast-of-void* cleanup. I wrote this as a fixup against libata-add-irq_flags-to-struct-pata_platform_info.patch with the intention of folding it into that base patch, but you went and merged the submitter's original patch so this trivial fixup got stranded in -mm. Feel free to give it the piss-off-too-trivial treatment. > > ata-ahci-alpm-store-interrupt-value.patch > > ata-ahci-alpm-expose-power-management-policy-option-to-users.patch > > ata-ahci-alpm-enable-link-power-management-for-ata-drivers.patch > > ata-ahci-alpm-enable-aggressive-link-power-management-for-ahci-controllers.patch > > > > These appear to need some work. > > seemed mostly OK to me. what comments did I miss? Oh, I thought these were the patches which affected scsi and which James had issues with. I guess I got confused. > > > libata-add-human-readable-error-value-decoding.patch > > still pondering; in my mbox queue > > > libata-fix-hopefully-all-the-remaining-problems-with.patch > > testing-patch-for-ali-pata-fixes-hopefully-for-the-problems-with-atapi-dma.patch > > pata_ali-more-work.patch > > No idea. I would poke Alan. Probably drop. > Alan: poke. > > > 8139too-force-media-setting-fix.patch > > blackfin-on-chip-ethernet-mac-controller-driver.patch > > atari_pamsnetc-old-declaration-ritchie-style-fix.patch > > sundance-phy-address-form-0-only-for-device-id-0x0200.patch > > Needs a bug fix, so that the newly modified loop doesn't scan the final > phy id, then loop back around to scan the first again. > > > > 3x59x-fix-pci-resource-management.patch > > update-smc91x-driver-with-arm-versatile-board-info.patch > > drivers-net-ns83820c-add-paramter-to-disable-auto.patch > > > > netdev patches which are stuck in limbo land. > > ? I don't think I've seen these. > 3x59x-fix-pci-resource-management.patch: you wrote it ;) I have a comment here: - I don't remember the story with cardbus either. Presumably once upon a time the cardbus layer was claiming IO regions on behalf of cardbus devices (?) Need to think about that. update-smc91x-driver-with-arm-versatile-board-info.patch: See comment from rmk in changelog: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc6/2.6.22-rc6-mm1/broken-out/update-smc91x-driver-with-arm-versatile-board-info.patch Deepak, can we move this along a bit please? drivers-net-ns83820c-add-paramter-to-disable-auto.patch: See comments in changelog: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc6/2.6.22-rc6-mm1/broken-out/drivers-net-ns83820c-add-paramter-to-disable-auto.patch Dan, Ben: is there any prospect of progress here? > > > bonding-bond_mainc-make-2-functions-static.patch > > FWIW bonding stuff should go to me, since it lives mostly in drivers/net > Ah, noted. > > x86-initial-fixmap-support.patch > > Andi material? > Spose so. But it's buried in the middle of a series of four patches. > > > mm-revert-kernel_ds-buffered-write-optimisation.patch > > revert-81b0c8713385ce1b1b9058e916edcf9561ad76d6.patch > > revert-6527c2bdf1f833cc18e8f42bd97973d583e4aa83.patch > > mm-clean-up-buffered-write-code.patch > > mm-debug-write-deadlocks.patch > > mm-trim-more-holes.patch > > mm-buffered-write-cleanup.patch > > mm-write-iovec-cleanup.patch > > mm-fix-pagecache-write-deadlocks.patch > > mm-buffered-write-iterator.patch > > fs-fix-data-loss-on-error.patch > > mm-restore-kernel_ds-optimisations.patch > > pagefault-in-write deadlock fixes. Will hold for 2.6.24. > > Any of the above worth 2.6.23? Just wondering if they were useful > cleanups / minor fixes prior to new aops patches? > The first few patches will a) fix up our writev performance regression and b) reintroduce the writev() deadlock which the writev()-regresion-adding patch fixed. So it's all a bit ugly. > > > oss-trident-massive-whitespace-removal.patch > > oss-trident-fix-locking-around-write_voice_regs.patch > > oss-trident-replace-deprecated-pci_find_device-with-pci_get_device.patch > > remove-options-depending-on-oss_obsolete.patch > > > > Merge > > what about just removing the OSS drivers in question? :) > Hey, I only work here. > > > intel-iommu-dmar-detection-and-parsing-logic.patch > > intel-iommu-pci-generic-helper-function.patch > > intel-iommu-clflush_cache_range-now-takes-size-param.patch > > intel-iommu-iova-allocation-and-management-routines.patch > > intel-iommu-intel-iommu-driver.patch > > intel-iommu-avoid-memory-allocation-failures-in-dma-map-api-calls.patch > > intel-iommu-intel-iommu-cmdline-option-forcedac.patch > > intel-iommu-dmar-fault-handling-support.patc
Re: [PATCH 0/1] ixgbe: Support for Intel(R) 10GbE PCI Express adapters - Take #2
Veeraiyan, Ayyappan wrote: On 7/10/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: [EMAIL PROTECTED] wrote: Doing both tends to signal that the author hasn't bothered to measure the differences between various approaches, and pick a clear winner. I did pick NAPI in our previous submission based on various tests. But to get 10Gig line rate we need to use multiple Rx queues which will need fake netdevs.. Since fake netdevs weren't acceptable, I added non-NAPI support which gets 10Gig line rate with multi-rx. I am ok with removing NAPI support till the work of separating the netdevs and NAPI work is done.. That sounds fine to me. Separating netdev and NAPI is the right way to go. Maybe note that in a TODO list at the top of the driver. With SW LRO, non-NAPI is better but without LRO, NAPI is better but NAPI needs multiple Rx queues. So given the limitations, non-NPAI is my preference now. On the subject of SW LRO: We are really looking for a generic implementation, hopefully authored by one or more interested parties. This is something we definitely do not want to reinvent over and over in new drivers -- and in the one or two drivers it exists today, should be removed once the generic code is in place. If Intel could assist with that effort, that would be very helpful. I will post the performance numbers later today.. Thanks, Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ps3: gigabit ethernet driver for PS3, take3
Masakazu Mokuno wrote: Hi, This is the third submission of the network driver for PS3. The differences from the previous one are: - renamed source file names so that their prefix can match with the module name - added [EMAIL PROTECTED] line for MAINTAINER file - changed some in copyright comments If there are no more comments, please apply for 2.6.23. Thank you -- Subject: PS3: Ethernet driver From: Masakazu Mokuno <[EMAIL PROTECTED]> Add Gigabit Ethernet support for the PS3 game console. The module will be called ps3_gelic. CC: Geoff Levand <[EMAIL PROTECTED]> Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]> --- MAINTAINERS |7 drivers/net/Kconfig | 10 drivers/net/Makefile|2 drivers/net/ps3_gelic_net.c | 1576 drivers/net/ps3_gelic_net.h | 239 ++ 5 files changed, 1834 insertions(+) applied I request that you fix the NETDEV_TX_LOCKED return value on error in ->hard_start_xmit(), which appears to be an incorrect return value for that condition, for your driver Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] IPv6: optionaly validate RAs on raw sockets
ICMPv6 Router Advertisements may now contain informations that is
mostly of interest to userland. This currently mostly consists of
recursive DNS server addresses (though one should expect other
stuff to come).
This patch adds a setsockopt to ICMPv6 sockets to only deliver Router
Advertisements if they pass the same set of checks as the kernel
IPv6 autoconfiguration does, so that userland can parse attributes it
is interested safely (otherwise, it would get and parse advertisements
that the kernel rejected).
N.B.: not too sure about the option name though...
Signed-off-by: Remi Denis-Courmont <[EMAIL PROTECTED]>
diff --git a/include/linux/icmpv6.h b/include/linux/icmpv6.h
index 7c5e981..8c96822 100644
--- a/include/linux/icmpv6.h
+++ b/include/linux/icmpv6.h
@@ -139,6 +139,7 @@ static inline struct icmp6hdr *icmp6_hdr(const struct
sk_buff *skb)
*/
#define ICMPV6_FILTER 1
+#define ICMPV6_VALID_ADVERT2
/*
* ICMPV6 filter
diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h
index 648bd1f..af72f02 100644
--- a/include/linux/ipv6.h
+++ b/include/linux/ipv6.h
@@ -343,7 +343,9 @@ struct ipv6_pinfo {
struct raw6_sock {
/* inet_sock has to be the first member of raw6_sock */
struct inet_sockinet;
- __u32 checksum; /* perform checksum */
+ __u16 unused;
+ __u8valid_advert; /* deliver valid RAs only */
+ __u8checksum; /* perform checksum */
__u32 offset; /* checksum offset */
struct icmp6_filter filter;
/* ipv6_pinfo has to be the last member of raw6_sock, see
inet6_sk_generic */
diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index a58459a..da6cb50 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -127,12 +127,35 @@ static __inline__ int icmpv6_filter(struct sock *sk,
struct sk_buff *skb)
if (pskb_may_pull(skb, sizeof(struct icmp6hdr))) {
__u32 *data = &rp->filter.data[0];
- int bit_nr;
+ int type;
icmph = (struct icmp6hdr *) skb->data;
- bit_nr = icmph->icmp6_type;
+ type = icmph->icmp6_type;
- return (data[bit_nr >> 5] & (1 << (bit_nr & 31))) != 0;
+ if (data[type >> 5] & (1 << (type & 31)))
+ return 1;
+
+ /* Userland only wants valid router advertisements? */
+ if (type == NDISC_ROUTER_ADVERTISEMENT &&
+ rp->valid_advert) {
+ struct inet6_dev *idev;
+
+ if (!pskb_may_pull(skb, sizeof(struct ra_msg)) ||
+ !(ipv6_addr_type(&ipv6_hdr(skb)->saddr) &
+ IPV6_ADDR_LINKLOCAL))
+ return 1;
+
+ idev = in6_dev_get(skb->dev);
+ if (!idev)
+ return 1;
+
+ /* Ignore RA when routing */
+ if (idev->cnf.forwarding || !idev->cnf.accept_ra) {
+ in6_dev_put(idev);
+ return 1;
+ }
+ in6_dev_put(idev);
+ }
}
return 0;
}
@@ -877,13 +900,26 @@ do_confirm:
static int rawv6_seticmpfilter(struct sock *sk, int level, int optname,
char __user *optval, int optlen)
{
+ struct raw6_sock *rp = raw6_sk(sk);
+
switch (optname) {
case ICMPV6_FILTER:
if (optlen > sizeof(struct icmp6_filter))
optlen = sizeof(struct icmp6_filter);
- if (copy_from_user(&raw6_sk(sk)->filter, optval, optlen))
+ if (copy_from_user(&rp->filter, optval, optlen))
return -EFAULT;
return 0;
+ case ICMPV6_VALID_ADVERT: {
+ int val;
+
+ if (optlen != sizeof(int))
+ return -EINVAL;
+ if (copy_from_user(&val, optval, sizeof(int)))
+ return -EFAULT;
+ /* -1 resets to default, which is actually 0 */
+ rp->valid_advert = (val > 0);
+ return 0;
+ }
default:
return -ENOPROTOOPT;
}
@@ -894,25 +930,38 @@ static int rawv6_seticmpfilter(struct sock *sk, int
level, int optname,
static int rawv6_geticmpfilter(struct sock *sk, int level, int optname,
char __user *optval, int __user *optlen)
{
+ struct raw6_sock *rp = raw6_sk(sk);
int len;
+ if (get_user(len, optlen))
+ return -EFAULT;
+ if (len < 0)
+ return -EINVAL;
+
switch (optname) {
case ICMPV6_FILTER:
- if (get_user(len, optlen))
- return -EFAULT;
-
RE: [PATCH 0/1] ixgbe: Support for Intel(R) 10GbE PCI Express adapters - Take #2
On 7/10/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > Doing both tends to signal that the author hasn't bothered to measure > the differences between various approaches, and pick a clear winner. > I did pick NAPI in our previous submission based on various tests. But to get 10Gig line rate we need to use multiple Rx queues which will need fake netdevs.. Since fake netdevs weren't acceptable, I added non-NAPI support which gets 10Gig line rate with multi-rx. I am ok with removing NAPI support till the work of separating the netdevs and NAPI work is done.. > I strongly prefer NAPI combined with hardware interrupt mitigation -- it > helps with multiple net interfaces balance load across the system, at > times of high load -- but I'm open to other solutions as well. > Majority of tests we did here, we saw NAPI is better. But for some specific test cases (especially if we add the SW RSC i.e. LRO), we saw better throughput and CPU utilization with non-NAPI. > So... what are your preferences? What is the setup that gets closest > to wire speed under Linux? :) With SW LRO, non-NAPI is better but without LRO, NAPI is better but NAPI needs multiple Rx queues. So given the limitations, non-NPAI is my preference now. I will post the performance numbers later today.. > > Jeff Thanks.. Ayyappan - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: iproute2 showing wrong number of bytes on 64bit architectures.
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 08:56:40 -0700 > Looks like net_device_stats should have always used u32? It used unsigned long ages ago, and ifconfig gets the bits exported from /proc/net/dev output whereas we have to used fixed data types in whatever we use over netlink so u32 was choosen. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/1] ixgbe: Support for Intel(R) 10GbE PCI Express adapters - Take #2
[EMAIL PROTECTED] wrote: 7. NAPI mode uses sigle Rx queue and so fake netdev usage is removed. 8. Non-NAPI mode is added. Honestly I'm not sure about drivers that have both NAPI and non-NAPI paths. Several existing drivers do this, and in almost every case, I tend to feel the driver would benefit from picking one approach, rather than doing both. Doing both tends to signal that the author hasn't bothered to measure the differences between various approaches, and pick a clear winner. I strongly prefer NAPI combined with hardware interrupt mitigation -- it helps with multiple net interfaces balance load across the system, at times of high load -- but I'm open to other solutions as well. So... what are your preferences? What is the setup that gets closest to wire speed under Linux? :) Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH re-resend] fix race in AF_UNIX garbage collector
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 03:04:43 -0700 > On Tue, 10 Jul 2007 11:50:30 +0200 Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > > Can you please add this to -mm. Sometimes that has wonderful effect > > on the willingness of people to look at a patch. > > sure ;) Andrew please don't, it's in my "to review" pile. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH re-resend] fix race in AF_UNIX garbage collector
From: Miklos Szeredi <[EMAIL PROTECTED]> Date: Tue, 10 Jul 2007 11:50:30 +0200 > Can you please add this to -mm. Sometimes that has wonderful effect > on the willingness of people to look at a patch. No, I will merge this into my networking tree when I get the chance to review your patch and it will automatically get into -mm that way. Please stop trying to rush this situation, it's driving me absolutely bananas, and you're serving to tick me off rather than make me want to review and go over your work. You do this continuously, and it hurts rather than helps your cause, so please cut it out. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
No network on Asus P5B (r8169)
Hi! I just found out that everything is working just fine with a 64-bit Linux kernel. I hope this helps you hunt down the error in the 32-bit version. https://bugzilla.novell.com/show_bug.cgi?id=288406 Clemens - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/1] ixgbe: Support for Intel(R) 10GbE PCI Express adapters - Take #2
This patch adds support for the Intel(R) 82598 based PCI Express 10GbE adapters. Please find the full driver as a patch to latest linus-2.6 tree here: git-pull git://lost.foo-projects.org/~aveerani/git/linux-2.6 ixgbe Changes from the last submission... 1. Suspend, resume support is added 2. PCI error recovery support 3. Bit fields usage is removed and replaced with #defines. 4. typedef boolean_t is replaced with bool. 5. Ethtool functionality for eeprom and regiters dump and adapter identification. 6. RxDescriptor, TxDescriptors and XsumRx parameters are removed from the module param list. They can be handled via ethtool. 7. NAPI mode uses sigle Rx queue and so fake netdev usage is removed. 8. Non-NAPI mode is added. 9. LLTX is not used and tx_lock usage in xmit_frame is cleand up. 10. Performance and bug fixes. thanks, Ayyappan - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
ata and netdev (was Re: -mm merge plans for 2.6.23)
(just to provide my indicator of status) Andrew Morton wrote: libata-config_pm=n-compile-fix.patch that's for a branch that you don't get via libata-dev#ALL, #mv-ahci-pata. pata_acpi-restore-driver.patch see Alan's comments. I've been ignoring pata_acpi for a while, because IMO it always needed work. libata-core-convert-to-use-cancel_rearming_delayed_work.patch will merge libata-implement-ata_wait_after_reset.patch I'm pretty much this is obsolete. Tejun? sata_promise-sata-hotplug-support.patch will merge libata-add-irq_flags-to-struct-pata_platform_info-fix.patch are other pata_platform people happy with this? I don't know embedded well enough to know if adding this struct member will break things. ata-add-the-sw-ncq-support-to-sata_nv-for-mcp51-mcp55-mcp61.patch sata_nv-allow-changing-queue-depth.patch should be combined, really. will merge eventually. basic concept OK, but need to review in depth. pata_hpt3x3-major-reworking-and-testing.patch iomap-sort-out-the-broken-address-reporting-caused-by-the-iomap-layer.patch ata-use-iomap_name.patch generally OK libata-check-for-an-support.patch scsi-expose-an-to-user-space.patch libata-expose-an-to-user-space.patch scsi-save-disk-in-scsi_device.patch libata-send-event-when-an-received.patch Am sitting on these due to confusion regarding the status of the ata-ahci patches. I will apply what I can, but it seems there are lifetime problems ata-ahci-alpm-store-interrupt-value.patch ata-ahci-alpm-expose-power-management-policy-option-to-users.patch ata-ahci-alpm-enable-link-power-management-for-ata-drivers.patch ata-ahci-alpm-enable-aggressive-link-power-management-for-ahci-controllers.patch These appear to need some work. seemed mostly OK to me. what comments did I miss? libata-add-human-readable-error-value-decoding.patch still pondering; in my mbox queue libata-fix-hopefully-all-the-remaining-problems-with.patch testing-patch-for-ali-pata-fixes-hopefully-for-the-problems-with-atapi-dma.patch pata_ali-more-work.patch No idea. I would poke Alan. Probably drop. 8139too-force-media-setting-fix.patch blackfin-on-chip-ethernet-mac-controller-driver.patch atari_pamsnetc-old-declaration-ritchie-style-fix.patch sundance-phy-address-form-0-only-for-device-id-0x0200.patch Needs a bug fix, so that the newly modified loop doesn't scan the final phy id, then loop back around to scan the first again. 3x59x-fix-pci-resource-management.patch update-smc91x-driver-with-arm-versatile-board-info.patch drivers-net-ns83820c-add-paramter-to-disable-auto.patch netdev patches which are stuck in limbo land. ? I don't think I've seen these. bonding-bond_mainc-make-2-functions-static.patch FWIW bonding stuff should go to me, since it lives mostly in drivers/net x86-initial-fixmap-support.patch Andi material? mm-revert-kernel_ds-buffered-write-optimisation.patch revert-81b0c8713385ce1b1b9058e916edcf9561ad76d6.patch revert-6527c2bdf1f833cc18e8f42bd97973d583e4aa83.patch mm-clean-up-buffered-write-code.patch mm-debug-write-deadlocks.patch mm-trim-more-holes.patch mm-buffered-write-cleanup.patch mm-write-iovec-cleanup.patch mm-fix-pagecache-write-deadlocks.patch mm-buffered-write-iterator.patch fs-fix-data-loss-on-error.patch mm-restore-kernel_ds-optimisations.patch pagefault-in-write deadlock fixes. Will hold for 2.6.24. Any of the above worth 2.6.23? Just wondering if they were useful cleanups / minor fixes prior to new aops patches? more-scheduled-oss-driver-removal.patch ACK oss-trident-massive-whitespace-removal.patch oss-trident-fix-locking-around-write_voice_regs.patch oss-trident-replace-deprecated-pci_find_device-with-pci_get_device.patch remove-options-depending-on-oss_obsolete.patch Merge what about just removing the OSS drivers in question? :) intel-iommu-dmar-detection-and-parsing-logic.patch intel-iommu-pci-generic-helper-function.patch intel-iommu-clflush_cache_range-now-takes-size-param.patch intel-iommu-iova-allocation-and-management-routines.patch intel-iommu-intel-iommu-driver.patch intel-iommu-avoid-memory-allocation-failures-in-dma-map-api-calls.patch intel-iommu-intel-iommu-cmdline-option-forcedac.patch intel-iommu-dmar-fault-handling-support.patch intel-iommu-iommu-gfx-workaround.patch intel-iommu-iommu-floppy-workaround.patch Don't know. I don't think there were any great objections, but I don't think much benefit has been demonstrated? Just the general march of progress on new hardware :) I would like to see this support merged in /some/ form. We've been telling Intel for years they were sillyheads for not bothering with an IOMMU. Now that they have, we should give them a cookie and support good technology. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ethtool: new ID to decode the registers of the 8101E (realtek)
Francois Romieu wrote: Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Rolf Eike Beer <[EMAIL PROTECTED]> --- realtek.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] PHY fixed driver: rework release path and update phy_id notation
Vitaly Bordug wrote:
device_bind_driver() error code returning has been fixed.
release() function has been written, so that to free resources
in correct way; the release path is now clean.
Before the rework, it used to cause
Device '[EMAIL PROTECTED]:1' does not have a release() function, it is broken
and must be fixed.
BUG: at drivers/base/core.c:104 device_release()
Call Trace:
[] kobject_cleanup+0x53/0x7e
[] kobject_release+0x0/0x9
[] kref_put+0x74/0x81
[] fixed_mdio_register_device+0x230/0x265
[] fixed_init+0x1f/0x35
[] init+0x147/0x2fb
[] schedule_tail+0x36/0x92
[] child_rip+0xa/0x12
[] acpi_ds_init_one_object+0x0/0x83
[] init+0x0/0x2fb
[] child_rip+0x0/0x12
Also changed the notation of the fixed phy definition on
mdio bus to the form of + to make it able to be used by
gianfar and ucc_geth that define phy_id strictly as "%d:%d"
Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]>
---
drivers/net/phy/Kconfig |4 ++
drivers/net/phy/fixed.c | 93 +++
2 files changed, 57 insertions(+), 40 deletions(-)
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 09b6f25..a938c48 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -71,4 +71,8 @@ config FIXED_MII_100_FDX
bool "Emulation for 100M Fdx fixed PHY behavior"
depends on FIXED_PHY
+config FIXED_MII_1000_FDX
+ bool "Emulation for 1000M Fdx fixed PHY behavior"
+ depends on FIXED_PHY
+
endif # PHYLIB
diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c
index 68c99b4..34b9111 100644
--- a/drivers/net/phy/fixed.c
+++ b/drivers/net/phy/fixed.c
@@ -187,12 +187,29 @@ static struct phy_driver fixed_mdio_driver = {
.driver = { .owner = THIS_MODULE,},
};
+static void fixed_mdio_release (struct device * dev)
+{
+ struct phy_device *phydev = container_of(dev, struct phy_device, dev);
+ struct mii_bus *bus = phydev->bus;
+ struct fixed_info *fixed = bus->priv;
+
+ kfree(phydev);
+ kfree(bus->dev);
+ kfree(bus);
+ kfree(fixed->regs);
+ kfree(fixed);
+}
+
/*-
* This func is used to create all the necessary stuff, bind
* the fixed phy driver and register all it on the mdio_bus_type.
- * speed is either 10 or 100, duplex is boolean.
+ * speed is either 10 or 100 or 1000, duplex is boolean.
* number is used to create multiple fixed PHYs, so that several devices can
* utilize them simultaneously.
+ *
+ * The device on mdio bus will look like :,
+ * bus_id = number
+ * phy_id = speed+duplex.
*-*/
static int fixed_mdio_register_device(int number, int speed, int duplex)
{
@@ -221,6 +238,12 @@ static int fixed_mdio_register_device(int number, int
speed, int duplex)
}
fixed->regs = kzalloc(MII_REGS_NUM*sizeof(int), GFP_KERNEL);
+ if (NULL == fixed->regs) {
+ kfree(dev);
+ kfree(new_bus);
+ kfree(fixed);
+ return -ENOMEM;
+ }
fixed->regs_num = MII_REGS_NUM;
fixed->phy_status.speed = speed;
fixed->phy_status.duplex = duplex;
@@ -249,57 +272,43 @@ static int fixed_mdio_register_device(int number, int
speed, int duplex)
fixed->phydev = phydev;
if(NULL == phydev) {
- err = -ENOMEM;
- goto device_create_fail;
+ kfree(dev);
+ kfree(new_bus);
+ kfree(fixed->regs);
+ kfree(fixed);
+ return -ENOMEM;
}
phydev->irq = PHY_IGNORE_INTERRUPT;
phydev->dev.bus = &mdio_bus_type;
- if(number)
- snprintf(phydev->dev.bus_id, BUS_ID_SIZE,
- "[EMAIL PROTECTED]:%d", number, speed, duplex);
- else
- snprintf(phydev->dev.bus_id, BUS_ID_SIZE,
- "[EMAIL PROTECTED]:%d", speed, duplex);
+ snprintf(phydev->dev.bus_id, BUS_ID_SIZE,
+ "%d:%d", number, speed + duplex);
+
phydev->bus = new_bus;
+ phydev->dev.driver = &fixed_mdio_driver.driver;
+ phydev->dev.release = fixed_mdio_release;
+
+ err = phydev->dev.driver->probe(&phydev->dev);
+ if(err < 0) {
+ printk(KERN_ERR "Phy %s: problems with fixed driver\n",
+ phydev->dev.bus_id);
+ kfree(phydev);
+ kfree(dev);
+ kfree(new_bus);
+ kfree(fixed->regs);
+ kfree(fixed);
+ return err;
+ }
+
err = device_register(&phydev->dev);
if(err) {
printk(KERN_ERR "Phy %s failed to register\n",
phydev->dev.bus_id);
- goto bus_register_fail;
- }
use the standard 'goto' style found in t
Re: [PATCH 2/2] eHEA: Receive SKB Aggregation
Jan-Bernd Themann wrote: This patch enables the receive side processing to aggregate TCP packets within the HEA device driver. It analyses the packets already received after an interrupt arrived and forwards these as chains of SKBs for the same TCP connection with modified header field. We have seen a lower CPU load and improved throughput for small numbers of parallel TCP connections. As this feature is considered as experimental it is switched off by default and can be activated via a module parameter. Some additional security checks have been added since the last posting. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> as noted in comments, we don't need to recreate this in every driver. do something more generic. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] eHEA: Capability flag for DLPAR support
Jan-Bernd Themann wrote: This patch introduces a capability flag that is used by the DLPAR userspace tool to check which DLPAR features are supported by the eHEA driver. Missing goto has been included. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6 patch] the scheduled sk98lin removal
On Tue, 10 Jul 2007 12:44:35 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Adrian Bunk wrote: > > This patch contains the scheduled removal of the sk98lin driver. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > Stephen -- ACK? Yes. Existing driver is dead, if there are any ancient boards that don't work with skge, I haven't heard any complaints in at least a year. As a fallback users, can always go with vendor driver. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 2/7] Blackfin: on-chip ethernet MAC controller driver
[EMAIL PROTECTED] wrote: From: "Wu, Bryan" <[EMAIL PROTECTED]> This patch implements the driver necessary use the Analog Devices Blackfin processor's on-chip ethernet MAC controller. Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/Kconfig| 44 + drivers/net/Makefile |1 drivers/net/bfin_mac.c | 981 +++ drivers/net/bfin_mac.h | 147 + 4 files changed, 1173 insertions(+) If I'm not mistaken, Bryan just said he was resending an updated version? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFT] via-velocity: use standard VLAN infrastructure
The via-velocity is using a non-standard VLAN acceleration interface.
This patch converts it to use standard API. Compile tested only.
The module parameter method of VLAN configuration is removed, use
vconfig instead.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/via-velocity.c | 68 +++--
drivers/net/via-velocity.h |3 +
2 files changed, 44 insertions(+), 27 deletions(-)
--- a/drivers/net/via-velocity.c2007-06-25 09:03:14.0 -0700
+++ b/drivers/net/via-velocity.c2007-07-10 09:38:05.0 -0700
@@ -72,6 +72,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -111,15 +112,6 @@ VELOCITY_PARAM(RxDescriptors, "Number of
#define TX_DESC_DEF 64
VELOCITY_PARAM(TxDescriptors, "Number of transmit descriptors");
-#define VLAN_ID_MIN 0
-#define VLAN_ID_MAX 4095
-#define VLAN_ID_DEF 0
-/* VID_setting[] is used for setting the VID of NIC.
- 0: default VID.
- 1-4094: other VIDs.
-*/
-VELOCITY_PARAM(VID_setting, "802.1Q VLAN ID");
-
#define RX_THRESH_MIN 0
#define RX_THRESH_MAX 3
#define RX_THRESH_DEF 0
@@ -147,13 +139,6 @@ VELOCITY_PARAM(rx_thresh, "Receive fifo
*/
VELOCITY_PARAM(DMA_length, "DMA length");
-#define TAGGING_DEF 0
-/* enable_tagging[] is used for enabling 802.1Q VID tagging.
- 0: disable VID seeting(default).
- 1: enable VID setting.
-*/
-VELOCITY_PARAM(enable_tagging, "Enable 802.1Q tagging");
-
#define IP_ALIG_DEF 0
/* IP_byte_align[] is used for IP header DWORD byte aligned
0: indicate the IP header won't be DWORD byte aligned.(Default) .
@@ -442,8 +427,7 @@ static void __devinit velocity_get_optio
velocity_set_int_opt(&opts->DMA_length, DMA_length[index],
DMA_LENGTH_MIN, DMA_LENGTH_MAX, DMA_LENGTH_DEF, "DMA_length", devname);
velocity_set_int_opt(&opts->numrx, RxDescriptors[index], RX_DESC_MIN,
RX_DESC_MAX, RX_DESC_DEF, "RxDescriptors", devname);
velocity_set_int_opt(&opts->numtx, TxDescriptors[index], TX_DESC_MIN,
TX_DESC_MAX, TX_DESC_DEF, "TxDescriptors", devname);
- velocity_set_int_opt(&opts->vid, VID_setting[index], VLAN_ID_MIN,
VLAN_ID_MAX, VLAN_ID_DEF, "VID_setting", devname);
- velocity_set_bool_opt(&opts->flags, enable_tagging[index], TAGGING_DEF,
VELOCITY_FLAGS_TAGGING, "enable_tagging", devname);
+
velocity_set_bool_opt(&opts->flags, txcsum_offload[index], TX_CSUM_DEF,
VELOCITY_FLAGS_TX_CSUM, "txcsum_offload", devname);
velocity_set_int_opt(&opts->flow_cntl, flow_control[index],
FLOW_CNTL_MIN, FLOW_CNTL_MAX, FLOW_CNTL_DEF, "flow_control", devname);
velocity_set_bool_opt(&opts->flags, IP_byte_align[index], IP_ALIG_DEF,
VELOCITY_FLAGS_IP_ALIGN, "IP_byte_align", devname);
@@ -465,6 +449,7 @@ static void __devinit velocity_get_optio
static void velocity_init_cam_filter(struct velocity_info *vptr)
{
struct mac_regs __iomem * regs = vptr->mac_regs;
+ unsigned short vid;
/* Turn on MCFG_PQEN, turn off MCFG_RTGOPT */
WORD_REG_BITS_SET(MCFG_PQEN, MCFG_RTGOPT, ®s->MCFG);
@@ -477,13 +462,19 @@ static void velocity_init_cam_filter(str
mac_set_cam_mask(regs, vptr->mCAMmask, VELOCITY_MULTICAST_CAM);
/* Enable first VCAM */
- if (vptr->flags & VELOCITY_FLAGS_TAGGING) {
- /* If Tagging option is enabled and VLAN ID is not zero, then
- turn on MCFG_RTGOPT also */
- if (vptr->options.vid != 0)
- WORD_REG_BITS_ON(MCFG_RTGOPT, ®s->MCFG);
+ if (vptr->vlgrp) {
+ for (vid = 0; vid < VLAN_VID_MASK; vid++) {
+ if (vlan_group_get_device(vptr->vlgrp, vid)) {
+ /* If Tagging option is enabled and
+ VLAN ID is not zero, then
+ turn on MCFG_RTGOPT also */
+ if (vid != 0)
+ WORD_REG_BITS_ON(MCFG_RTGOPT,
®s->MCFG);
- mac_set_cam(regs, 0, (u8 *) & (vptr->options.vid),
VELOCITY_VLAN_ID_CAM);
+ mac_set_cam(regs, 0, (u8 *) &vid,
+ VELOCITY_VLAN_ID_CAM);
+ }
+ }
vptr->vCAMmask[0] |= 1;
mac_set_cam_mask(regs, vptr->vCAMmask, VELOCITY_VLAN_ID_CAM);
} else {
@@ -494,6 +485,26 @@ static void velocity_init_cam_filter(str
}
}
+static void velocity_vlan_rx_add_vid(struct net_device *dev, unsigned short
vid)
+{
+ struct velocity_info *vptr = netdev_priv(dev);
+
+ spin_lock_irq(&vptr->lock);
+ velocity_init_cam_filter(vptr);
+ spin_unlock_irq(&vptr->lock);
+}
+
+static void velocity_vlan_rx_kill_vid(struct net_device *dev, unsigned short
vid)
+{
+ struct velocity_info *vptr = netdev_priv(dev);
+
+ spin_lock_irq(&vptr->lock);
+ vlan_group_set
Re: [linux-usb-devel] [PATCH]: cdc-subset to support new vendor/product ID
jing xiang wrote:
Hi,
This patch is for cdc subset to support Mavell vendor/product ID.
Jing Xiang
Signed-off-by: Jing Xiang<[EMAIL PROTECTED]>
diff -uNpr linux-2.6.21.5/driver/usb/net/cdc_subset.c
linux-2.6.21.5.t/driver/usb/net/cdc_subset.c
--- linux-2.6.21.5/driver/usb/net/cdc_subset.c 2007-06-14
18:34:05.0 +0800
+++ linux-2.6.21.5.t/driver/usb/net/cdc_subset.c2007-06-28
15:55:56.290598304 +0800
@@ -305,6 +305,9 @@ static const struct usb_device_id produc
USB_DEVICE (0x8086, 0x07d3),// "blob" bootloader
.driver_info = (unsigned long) &blob_info,
}, {
+ USB_DEVICE (0x1286, 0x8001),// "blob" bootloader
+ .driver_info = (unsigned long) &blob_info,
+}, {
// Linux Ethernet/RNDIS gadget on pxa210/25x/26x, second config
// e.g. Gumstix, current OpenZaurus, ...
USB_DEVICE_VER (0x0525, 0xa4a2, 0x0203, 0x0203),
patch failed to apply. Also, please move extra comments like "Hi," and
"Jing Xiang" after a "---" separator as described in
Documentation/SubmittingPatches, so that they are not copied verbatim
into the permanent kernel changelog.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2,6 patch] sunhme.c:quattro_pci_find() must be __devinit
Adrian Bunk wrote: This patch fixes the following section mismatch: <-- snip --> ... MODPOST vmlinux WARNING: drivers/built-in.o(.text+0x272f8b): Section mismatch: reference to .init.text:quattro_pci_find (between 'happy_meal_pci_probe' and 'happy_meal_pci_remove') ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6 patch] the scheduled sk98lin removal
Adrian Bunk wrote: This patch contains the scheduled removal of the sk98lin driver. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Stephen -- ACK? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] bonding / ipv6: no addrconf for slaves separately from master
Jay Vosburgh wrote: At present, when a device is enslaved to bonding, if ipv6 is active then addrconf will be initated on the slave (because it is closed then opened during the enslavement processing). This causes DAD and RS packets to be sent from the slave. These packets in turn can confuse switches that perform ipv6 snooping, causing them to incorrectly update their forwarding tables (if, e.g., the slave being added is an inactve backup that won't be used right away) and direct traffic away from the active slave to a backup slave (where the incoming packets will be dropped). This patch alters the behavior so that addrconf will only run on the master device itself. I believe this is logically correct, as it prevents slaves from having an IPv6 identity independent from the master. This is consistent with the IPv4 behavior for bonding. This is accomplished by (a) having bonding set IFF_SLAVE sooner in the enslavement processing than currently occurs (before open, not after), and (b) having ipv6 addrconf ignore UP and CHANGE events on slave devices. The eql driver also uses the IFF_SLAVE flag. I inspected eql, and I believe this change is reasonable for its usage of IFF_SLAVE, but I did not test it. Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] atl1: remove write-only var in tx handler
Alexey Dobriyan wrote: Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: macmace: use "unsigned long flags;"
Alexey Dobriyan wrote: Code will do local_irq_save() on it. Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- drivers/net/macmace.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/macmace.c +++ b/drivers/net/macmace.c @@ -577,7 +577,7 @@ static irqreturn_t mace_interrupt(int irq, void *dev_id) struct mace_data *mp = netdev_priv(dev); volatile struct mace *mb = mp->mace; int intr, fs; - unsigned int flags; + unsigned long flags; applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Cleanup usbnet_probe() return value handling
Peter Korsgaard wrote: "David" == David Brownell <[EMAIL PROTECTED]> writes: Hi, David> I'd rather see the later test updated to match this one. David> (Good catch!) David> The return convention is "negative means error". There's David> code in USB which has multiple nonnegative success codes. Ok, updated patch does that instead. David> In particular usb_control_msg(), which would very naturally David> used as the body of a bind() method, returns negative or David> the number of bytes transferred. Yeah, that was the original problem in my dm9601 driver. usbnet_probe() handles a positive return value from the driver bind() function as success, but will later only setup the status handler if the return value was zero, leading to confusion. Patch adjusts this to accept positive values as success in both checks. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/usb/usbnet.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2.6.22-rc7] 8139cp: dev->tx_timeout
[EMAIL PROTECTED] wrote: (Resending the patch against 2.6.22-rc7) This patch implements the missing dev->tx_timeout for 8139cp driver Signed-off-by: Mika Lansirinne <[EMAIL PROTECTED]> ACK but still fails to apply - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] netxen: deinline and sparse fix
Stephen Hemminger wrote: Get rid of dubious casts to (void *) which causes a sparse warning. And move largeish function from inline to the one file that uses the code, the compiler can then decide to inline it. Compile tested only. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [1/2] phylib: cleanup marvell.c a bit
Olof Johansson wrote: Simplify the marvell driver init a bit: Make the supported devices an array instead of explicitly registering each structure. This makes it considerably easier to add new devices down the road. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> applied 1-2 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] AX88796 network driver
Ben Dooks wrote: Support for the Asix AX88796 network controller, an NE2000 compatible 10/100 ethernet device with internal PHY. The driver supports PHY settings via either ioctl() or the ethtool driver ops. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] 7990 : Various fixes and cleanups
Philippe De Muyter wrote: This patch - avoids 7990 blocking when no tx buffer is available, [...] diff -r 6c0a10cc415a drivers/net/7990.c --- a/drivers/net/7990.cThu Jul 5 16:10:16 2007 -0700 +++ b/drivers/net/7990.cFri Jul 6 11:27:20 2007 +0200 [...] @@ -541,9 +546,6 @@ int lance_start_xmit (struct sk_buff *sk static int outs; unsigned long flags; -if (!TX_BUFFS_AVAIL) -return -1; - netif_stop_queue (dev); skblen = skb->len; @@ -565,9 +567,11 @@ int lance_start_xmit (struct sk_buff *sk ib->btx_ring [entry].length = (-len) | 0xf000; ib->btx_ring [entry].misc = 0; - if (skb->len < ETH_ZLEN) - memset((void *)&ib->tx_buf[entry][0], 0, ETH_ZLEN); skb_copy_from_linear_data(skb, (void *)&ib->tx_buf[entry][0], skblen); + if (skblen < ETH_ZLEN) + memset((char *)&ib->tx_buf[entry][0] + skblen, 0, ETH_ZLEN - skblen); + + lp->stats.tx_bytes += skblen; NAK It "avoids" by removing an overrun check in hard_start_xmit that should not be removed. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [IOC3] Switch to pci refcounting safe APIs
Ralf Baechle wrote:
From: Alan Cox <[EMAIL PROTECTED]>
Convert the IOC3 driver to use ref counting pci interfaces so that we can
obsolete the (usually unsafe) pci_find_{slot/device} interfaces and avoid
future authors writing hotplug-unsafe device drivers.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
Build fixes:
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] QE Ethernet driver writes to wrong register to mask interrupts
Timur Tabi wrote: The QE Ethernet driver was writing to the wrong register to mask interrupts. In ucc_geth_stop(), it was clearing UCCE instead of UCCM. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] e100: Fix Tyan motherboard e100 not receiving IPMI commands
Auke Kok wrote: From: David Graham <[EMAIL PROTECTED]> The 82550 & 51 parts have an extended configuration block that includes a bit "GMRC", required to enable the expected TCO behavior, in config byte offset 22d. The config block sent by the failing driver does include the extension area, but this bit is not initialised, and the downlaod only specifies 0x16 bytes to be sent to the NIC (thaht's bytes 00..21d). By initializing the GMRC bit, and extending the download size for D102+ MACs, the problem is resolved. Signed-off-by: David Graham <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e100.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6 patch] rrunner.c:rr_init() must be __devinit
Adrian Bunk wrote: This patch fixes the following section mismatch: <-- snip --> ... MODPOST vmlinux WARNING: drivers/built-in.o(.text+0x26e3f2): Section mismatch: reference to .init.text:rr_init (between 'rr_init_one' and 'rr_remove_one') ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6 patch] sis900_mii_probe() must be __devinit
Adrian Bunk wrote: This patch fixes the following section mismatch: <-- snip --> ... MODPOST vmlinux WARNING: drivers/built-in.o(.text+0x298170): Section mismatch: reference to .init.text:sis900_mii_probe (between 'sis900_probe' and 'sis900_default_phy') ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6 patch] tokenring/3c359.c:xl_init() must be __devinit
Adrian Bunk wrote: This patch fixes the following section mismatch: <-- snip --> ... MODPOST vmlinux WARNING: drivers/built-in.o(.text+0x361ef1): Section mismatch: reference to .init.text:xl_init (between 'xl_probe' and 'xl_hw_reset') ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix typo in drivers/net/s2io.c
Rolf Eike Beer wrote: Introduced in d796fdb708fc5b10112934cba43e832c36ce4923. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- commit 58056c2424917e90b86ca11c2c5d3fd35313d7b6 tree 854d63a14f96416aad64d12ea71cb331acfcc7db parent 87a2df362631d53fdc169a5d76969365aff69c10 author Rolf Eike Beer <[EMAIL PROTECTED]> Tue, 10 Jul 2007 11:55:46 +0200 committer Rolf Eike Beer <[EMAIL PROTECTED]> Tue, 10 Jul 2007 11:55:46 +0200 drivers/net/s2io.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c index 2d826ff..fa29a40 100644 --- a/drivers/net/s2io.c +++ b/drivers/net/s2io.c @@ -8036,7 +8036,7 @@ static void lro_append_pkt(struct s2io_nic *sp, struct lro *lro, /** * s2io_io_error_detected - called when PCI error is detected * @pdev: Pointer to PCI device - * @state: The current pci conneection state + * @state: The current pci connection state applied manually, patch was corrupted - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] spidernet: improve interrupt handling
Linas Vepstas wrote: From: Ishizaki Kou <[EMAIL PROTECTED]> We intend this patch to improve spidernet interrupt handling to be more strict. We had following problem and this patch solves it. -when CONFIG_DEBUG_SHIRQ=y, request_irq() calls handler(). -when spider_net_open() is called, it calls request_irq() which calls spider_net_interrupt(). -if some specific interrupt bit is set at this timing, it calls netif_rx_schedule() and spider_net_poll() is scheduled. -spider_net_open() calls netif_poll_enable() which clears the bit __LINK_STATE_RX_SCHED. -when spider_net_poll() is called, it calls netif_rx_complete() which causes BUG_ON() because __LINK_STATE_RX_SCHED is not set. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Jeff, please apply for 2.6.23 Linas. drivers/net/spider_net.c | 59 +++ 1 file changed, 45 insertions(+), 14 deletions(-) applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] PCMCIA: add Socket Ethernet card into pcnet_cs
Marcin Juszkiewicz wrote: From: Marcin Juszkiewicz <[EMAIL PROTECTED]> One card submitted by Ångström user. Signed-off-by: Marcin Juszkiewicz <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 3/7] atari_pamsnet.c: old declaration ritchie style fix
[EMAIL PROTECTED] wrote: From: Yoann Padioleau <[EMAIL PROTECTED]> Use consistent function declaration style. Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/atari_pamsnet.c | 62 -- 1 files changed, 22 insertions(+), 40 deletions(-) applied this, and patches 5-7 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Does the Netxen driver work?
On 07/10/2007 12:33 AM, Dhananjay Phadke wrote: > The MSI error wasn't fatal, so it was suppressed in recent fixes for > 2.6.22-rc7. The driver in 2.6.21 had many bugs, but I ain't sure if > recent fixes are going to be pulled in Fedora kernel. > Fedora 6/7 are moving to kernel 2.6.22 very soon. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/12] sky2: restore workarounds for lost interrupts
Stephen Hemminger wrote: This patch restores a couple of workarounds from 2.6.16: * restart transmit moderation timer in case it expires during IRQ routine * default to having 10 HZ watchdog timer. At this point it more important not to hang than to worry about the power cost. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied 1-12 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[IOC3] Switch to pci refcounting safe APIs
From: Alan Cox <[EMAIL PROTECTED]>
Convert the IOC3 driver to use ref counting pci interfaces so that we can
obsolete the (usually unsafe) pci_find_{slot/device} interfaces and avoid
future authors writing hotplug-unsafe device drivers.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
Build fixes:
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
Index: upstream-linus/drivers/net/ioc3-eth.c
===
--- upstream-linus.orig/drivers/net/ioc3-eth.c
+++ upstream-linus/drivers/net/ioc3-eth.c
@@ -352,13 +352,12 @@ static u64 nic_find(struct ioc3 *ioc3, i
static int nic_init(struct ioc3 *ioc3)
{
- const char *type;
+ const char *unknown = "unknown";
+ const char *type = unknown;
u8 crc;
u8 serial[6];
int save = 0, i;
- type = "unknown";
-
while (1) {
u64 reg;
reg = nic_find(ioc3, &save);
@@ -392,7 +391,7 @@ static int nic_init(struct ioc3 *ioc3)
}
printk("Found %s NIC", type);
- if (type != "unknown") {
+ if (type != unknown) {
printk (" registration number %02x:%02x:%02x:%02x:%02x:%02x,"
" CRC %02x", serial[0], serial[1], serial[2],
serial[3], serial[4], serial[5], crc);
@@ -1103,20 +1102,28 @@ static int ioc3_close(struct net_device
* MiniDINs; all other subdevices are left swinging in the wind, leave
* them disabled.
*/
-static inline int ioc3_is_menet(struct pci_dev *pdev)
+
+static int ioc3_adjacent_is_ioc3(struct pci_dev *pdev, int slot)
{
- struct pci_dev *dev;
+ struct pci_dev *dev = pci_get_slot(pdev->bus, PCI_DEVFN(slot, 0));
+ int ret = 0;
+
+ if (dev) {
+ if (dev->vendor == PCI_VENDOR_ID_SGI &&
+ dev->device == PCI_DEVICE_ID_SGI_IOC3)
+ ret = 1;
+ pci_dev_put(dev);
+ }
- return pdev->bus->parent == NULL
- && (dev = pci_find_slot(pdev->bus->number, PCI_DEVFN(0, 0)))
- && dev->vendor == PCI_VENDOR_ID_SGI
- && dev->device == PCI_DEVICE_ID_SGI_IOC3
- && (dev = pci_find_slot(pdev->bus->number, PCI_DEVFN(1, 0)))
- && dev->vendor == PCI_VENDOR_ID_SGI
- && dev->device == PCI_DEVICE_ID_SGI_IOC3
- && (dev = pci_find_slot(pdev->bus->number, PCI_DEVFN(2, 0)))
- && dev->vendor == PCI_VENDOR_ID_SGI
- && dev->device == PCI_DEVICE_ID_SGI_IOC3;
+ return ret;
+}
+
+static int ioc3_is_menet(struct pci_dev *pdev)
+{
+ return pdev->bus->parent == NULL &&
+ ioc3_adjacent_is_ioc3(pdev, 0) &&
+ ioc3_adjacent_is_ioc3(pdev, 1) &&
+ ioc3_adjacent_is_ioc3(pdev, 2);
}
#ifdef CONFIG_SERIAL_8250
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Fw: iproute2 showing wrong number of bytes on 64bit architectures.
Looks like net_device_stats should have always used u32?
Too late to change it now.
Begin forwarded message:
Date: Tue, 10 Jul 2007 13:58:51 +0200
From: Andreas Henriksson <[EMAIL PROTECTED]>
To: netdev@vger.kernel.org
Cc: [EMAIL PROTECTED]
Subject: iproute2 showing wrong number of bytes on 64bit architectures.
Hello!
While investigating the problems reported in Debian bug #199054
(http://bugs.debian.org/199054), stating that the RX/TX bytes differ between
ifconfig and ip(route2) I came across this:
include/linux/if_link.h (used in kernel and iproute2 source):
/* The struct should be in sync with struct net_device_stats */
struct rtnl_link_stats
{
__u32 ...;
__u32 ...;
__u32 ...;
__u32 ...;
...
include/linux/netdevice.h:
struct net_device_stats
{
unsigned long ...;
unsigned long ...;
unsigned long ...;
unsigned long ...;
unsigned long ...;
This will be a problem when unsigned long isn't 32bits, but I guess the
rtnetlink message size is static for good reason.
Can someone please advise on how to fix this?
--
Regards,
Andreas Henriksson
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Stephen Hemminger <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] e100: Fix Tyan motherboard e100 not receiving IPMI commands
From: David Graham <[EMAIL PROTECTED]>
The 82550 & 51 parts have an extended configuration block that
includes a bit "GMRC", required to enable the expected TCO behavior,
in config byte offset 22d. The config block sent by the failing driver
does include the extension area, but this bit is not initialised,
and the downlaod only specifies 0x16 bytes to be sent to the NIC
(thaht's bytes 00..21d). By initializing the GMRC bit, and extending
the download size for D102+ MACs, the problem is resolved.
Signed-off-by: David Graham <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---
drivers/net/e100.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 763810c..74ea637 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -159,7 +159,7 @@
#define DRV_NAME "e100"
#define DRV_EXT"-NAPI"
-#define DRV_VERSION"3.5.17-k4"DRV_EXT
+#define DRV_VERSION"3.5.23-k4"DRV_EXT
#define DRV_DESCRIPTION"Intel(R) PRO/100 Network Driver"
#define DRV_COPYRIGHT "Copyright(c) 1999-2006 Intel Corporation"
#define PFXDRV_NAME ": "
@@ -1024,10 +1024,16 @@ static void e100_configure(struct nic *nic, struct cb
*cb, struct sk_buff *skb)
config->mwi_enable = 0x1; /* 1=enable, 0=disable */
config->standard_tcb = 0x0; /* 1=standard, 0=extended */
config->rx_long_ok = 0x1; /* 1=VLANs ok, 0=standard */
- if(nic->mac >= mac_82559_D101M)
+ if (nic->mac >= mac_82559_D101M) {
config->tno_intr = 0x1; /* TCO stats enable */
- else
+ /* Enable TCO in extended config */
+ if (nic->mac >= mac_82551_10) {
+ config->byte_count = 0x20; /* extended bytes */
+ config->rx_d102_mode = 0x1; /* GMRC for TCO */
+ }
+ } else {
config->standard_stat_counter = 0x0;
+ }
}
DPRINTK(HW, DEBUG, "[00-07]=%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X\n",
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2.6] WE : Fix get 32 char ESSID
On Mon, Jul 09, 2007 at 03:13:22PM -0700, Jean Tourrilhes wrote:
> A little bug was introduced a few months ago that prevent
> reading ESSID with 32 character. Philippe Teuwen was the first one to
> report that, followed by the MadWifi team :
> http://madwifi.org/ticket/930
> The patch fix this bug by removing obsolete code. It also
> reenable setting the full range of ESSID, including ESSID with a final
> NUL which are valid. This was tested on 2.6.21 and 2.6.22.
> John : would you mind pushing that to 2.6.23 ? If you are
> happy with it, I can provide backport patches for earlier kernels.
Jean,
Thanks for the patch.
Iirc, I wrote this ugly little piece of code that you seek to remove.
It's purpose is/was to preserve userland ABI for older versions of
the wireless-tools package. I'll have to dig a little deeper if you
need a more detailed refresher -- let me know.
In that case, I believe the issue was that using older wireless-tools
w/ newer kernels would result in the SSID getting truncated by one
character. If we apply this patch (removing my hack/fix), won't we
be reintroducing that issue? If not, can you remind me as to why not?
Thanks,
John
>
> Signed-off-by: Jean Tourrilhes <[EMAIL PROTECTED]>
>
> ---
>
> --- linux/net/wireless/wext.j1.c 2007-07-09 13:19:22.0 -0700
> +++ linux/net/wireless/wext.c 2007-07-09 13:19:59.0 -0700
> @@ -741,39 +741,11 @@ static int ioctl_standard_call(struct ne
> int extra_size;
> int user_length = 0;
> int err;
> - int essid_compat = 0;
>
> /* Calculate space needed by arguments. Always allocate
>* for max space. Easier, and won't last long... */
> extra_size = descr->max_tokens * descr->token_size;
>
> - /* Check need for ESSID compatibility for WE < 21 */
> - switch (cmd) {
> - case SIOCSIWESSID:
> - case SIOCGIWESSID:
> - case SIOCSIWNICKN:
> - case SIOCGIWNICKN:
> - if (iwr->u.data.length == descr->max_tokens + 1)
> - essid_compat = 1;
> - else if (IW_IS_SET(cmd) && (iwr->u.data.length != 0)) {
> - char essid[IW_ESSID_MAX_SIZE + 1];
> -
> - err = copy_from_user(essid, iwr->u.data.pointer,
> - iwr->u.data.length *
> - descr->token_size);
> - if (err)
> - return -EFAULT;
> -
> - if (essid[iwr->u.data.length - 1] == '\0')
> - essid_compat = 1;
> - }
> - break;
> - default:
> - break;
> - }
> -
> - iwr->u.data.length -= essid_compat;
> -
> /* Check what user space is giving us */
> if (IW_IS_SET(cmd)) {
> /* Check NULL pointer */
> @@ -811,7 +783,6 @@ static int ioctl_standard_call(struct ne
> }
>
> /* Create the kernel buffer */
> - /*kzalloc ensures NULL-termination for essid_compat */
> extra = kzalloc(extra_size, GFP_KERNEL);
> if (extra == NULL)
> return -ENOMEM;
> @@ -830,8 +801,6 @@ static int ioctl_standard_call(struct ne
> /* Call the handler */
> ret = handler(dev, &info, &(iwr->u), extra);
>
> - iwr->u.data.length += essid_compat;
> -
> /* If we have something to return to the user */
> if (!ret && IW_IS_GET(cmd)) {
> /* Check if there is enough buffer up there */
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
John W. Linville
[EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: + gen_estimator-fix-locking-and-timer-related-bugs.patch added to -mm tree
On Tue, Jul 10, 2007 at 03:10:34PM +0200, Jarek Poplawski wrote: > On Tue, Jul 10, 2007 at 02:20:12PM +0200, Patrick McHardy wrote: > > Jarek Poplawski wrote: > > > On Tue, Jul 10, 2007 at 01:09:07PM +0300, Ranko Zivojnovic wrote: > > > > > >>However I decided not to use _rcu based iteration neither the > > >>rcu_read_lock() after going through the RCU documentation and a bunch of > > >>examples in kernel that iterate through the lists using non _rcu macros > > >>and do list_del_rcu() just fine. > > >> > > >>For readability, the reference to list_del_rcu as well as call_rcu, I > > >>believe, should be enough of the indication. Please do correct me if I > > >>am wrong here. > > > > > > > > > It's only my opinion, and it's probably not very popular at least > > > at net/ code, so it's more about general policy and not this > > > particular code. But: > > > - if somebody is looking after some rcu related problems, why can't > > > he/she spare some time by omitting lists without _rcu and not > > > analyzing why/how such lists are used and locked? > > > > > > RCU is used for the read-side, using it on the write-side just makes > > things *less* understandable IMO. It will look like the read-side > > but still do modifications. > > > > From Documentation/RCU/checklist: > > "9. All RCU list-traversal primitives, which include > list_for_each_rcu(), list_for_each_entry_rcu(), > list_for_each_continue_rcu(), and list_for_each_safe_rcu(), > must be within an RCU read-side critical section. RCU > read-side critical sections are delimited by rcu_read_lock() > and rcu_read_unlock(), or by similar primitives such as > rcu_read_lock_bh() and rcu_read_unlock_bh(). ...But, on the other hand, Ranko didn't use any of these primitives... So, first I said he should use this, and than I asked why there was no rcu_read_locks around... I really start to amaze with my consistency. I hope some day you'll forgive me (no hurry, I can wait). Cheers, Jarek P. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
iproute2 showing wrong number of bytes on 64bit architectures.
Hello!
While investigating the problems reported in Debian bug #199054
(http://bugs.debian.org/199054), stating that the RX/TX bytes differ between
ifconfig and ip(route2) I came across this:
include/linux/if_link.h (used in kernel and iproute2 source):
/* The struct should be in sync with struct net_device_stats */
struct rtnl_link_stats
{
__u32 ...;
__u32 ...;
__u32 ...;
__u32 ...;
...
include/linux/netdevice.h:
struct net_device_stats
{
unsigned long ...;
unsigned long ...;
unsigned long ...;
unsigned long ...;
unsigned long ...;
This will be a problem when unsigned long isn't 32bits, but I guess the
rtnetlink message size is static for good reason.
Can someone please advise on how to fix this?
--
Regards,
Andreas Henriksson
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
