Re: [PATCH net-next v3 1/3] netvsc: transparent VF management
On Tue, Aug 01, Stephen Hemminger wrote:
> static void netvsc_get_stats64(struct net_device *net,
> struct rtnl_link_stats64 *t)
> {
> struct net_device_context *ndev_ctx = netdev_priv(net);
> struct netvsc_device *nvdev = rcu_dereference_rtnl(ndev_ctx->nvdev);
> - int i;
> + struct netvsc_vf_pcpu_stats vf_tot;
> + int i;
This move of 'i' was probably not intended.
Olaf
signature.asc
Description: PGP signature
Re: nfs NULL-dereferencing in net-next
On Thu, Nov 03, Anna Schumaker wrote: > Aww, I was hoping that patch would work. It still seemed to fix some > issues for me when mounting multiple servers, so I'm planning to keep > it. Unfortunately I'm out of town this week, so I haven't had much of > a chance to keep poking at this issue. I should be able to get back > to it next week! Is this supposed to be fixed already? I get an oops in rpc_clnt_xprt_switch_has_addr+0xc/0x40 with 4.9.0-rc4. Olaf signature.asc Description: PGP signature
Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets
On Thu, Jun 30, Dexuan Cui wrote:
> +/* The MTU is 16KB per the host side's design. */
> +struct hvsock_recv_buf {
> + unsigned int data_len;
> + unsigned int data_offset;
> +
> + struct vmpipe_proto_header hdr;
> + u8 buf[PAGE_SIZE * 4];
Please use some macro related to the protocol rather than a Linux
compiletime macro.
> +/* We send at most 4KB payload per VMBus packet. */
> +struct hvsock_send_buf {
> + struct vmpipe_proto_header hdr;
> + u8 buf[PAGE_SIZE];
Same here.
> + * Copyright(c) 2016, Microsoft Corporation. All rights reserved.
Here the BSD license follows. I think its required/desired to also
include a GPL blurb like it is done in many other files:
...
* Alternatively, this software may be distributed under the terms of
* the GNU General Public License ("GPL") version 2 as published by the
* Free Software Foundation.
Otherwise the MODULE_LICENSE string might be incorrect.
> + /* Hyper-V Sockets requires at least VMBus 4.0 */
> + if ((vmbus_proto_version >> 16) < 4) {
> + pr_err("failed to load: VMBus 4 or later is required\n");
I guess this mens WS 2016+, and loading in earlier host versions will
trigger this path? I think a silent ENODEV is enough.
> + return -ENODEV;
Olaf
signature.asc
Description: PGP signature
Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets
On Thu, Jun 30, Olaf Hering wrote: > On Thu, Jun 30, Dexuan Cui wrote: > > > -#define AF_MAX 43 /* For now.. */ > > +#define AF_MAX 44 /* For now.. */ > > Should this patch also change the places where AF_MAX is used, > like all the arrays in net/core/sock.c? Also, there are appearently two competing changes for AF_MAX, one is yours and the other one is AF_SMC. I'm not subscribed to netdev, so its not clear which one gets applied first. Olaf. signature.asc Description: PGP signature
Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets
On Thu, Jun 30, Dexuan Cui wrote: > -#define AF_MAX 43 /* For now.. */ > +#define AF_MAX 44 /* For now.. */ Should this patch also change the places where AF_MAX is used, like all the arrays in net/core/sock.c? Olaf signature.asc Description: PGP signature
Re: [PATCH V6 8/8] hvsock: introduce Hyper-V Socket feature
On Tue, Jan 26, Dexuan Cui wrote: > +#define AF_MAX 42 /* For now.. */ Maybe net/core/sock.c needs additional strings for the new socket? Olaf
Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature
On Tue, Jul 07, Dexuan Cui wrote: OK, removing the line seems better than 'default n', though both reproduce the same # CONFIG_HYPERV_SOCK is not set. Perhaps default VMBUS (or whatever syntax is needed) may be the way to enable it conditionally. Olaf -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature
On Tue, Jul 07, Paul Bolle wrote: On ma, 2015-07-06 at 07:47 -0700, Dexuan Cui wrote: --- /dev/null +++ b/net/hv_sock/Kconfig +config HYPERV_SOCK + tristate Microsoft Hyper-V Socket (EXPERIMENTAL) + depends on HYPERV + default m It's a bit odd to advise to say N if one is unsure and set the default to 'm' at the same time. The 'default' line has to be removed IMO. Olaf -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] add modalias info to mv643xx_eth.ko
mv643xx_eth has an platform modalias file in sysfs. But the module itself has no alias: line. Autoloading fails without the alias info in the module. Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- drivers/net/mv643xx_eth.c |1 + 1 file changed, 1 insertion(+) --- a/drivers/net/mv643xx_eth.c +++ b/drivers/net/mv643xx_eth.c @@ -2099,6 +2099,7 @@ MODULE_LICENSE(GPL); MODULE_AUTHOR( Rabeeh Khoury, Assaf Hoffman, Matthew Dharm, Manish Lachwani and Dale Farnsworth); MODULE_DESCRIPTION(Ethernet driver for Marvell MV643XX); +MODULE_ALIAS(platform:mv643xx_eth); /* * The second part is the low level driver of the gigE ethernet ports. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] fix mace_handle_misc_intrs compilation
Fix compilation after incomplete struct net_device changes.
Signed-off-by: Olaf Hering [EMAIL PROTECTED]
---
drivers/net/mace.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/drivers/net/mace.c
+++ b/drivers/net/mace.c
@@ -633,7 +633,7 @@ static void mace_set_multicast(struct ne
spin_unlock_irqrestore(mp-lock, flags);
}
-static void mace_handle_misc_intrs(struct mace_data *mp, int intr)
+static void mace_handle_misc_intrs(struct mace_data *mp, int intr, struct
net_device *dev)
{
volatile struct mace __iomem *mb = mp-mace;
static int mace_babbles, mace_jabbers;
@@ -669,7 +669,7 @@ static irqreturn_t mace_interrupt(int ir
spin_lock_irqsave(mp-lock, flags);
intr = in_8(mb-ir); /* read interrupt register */
in_8(mb-xmtrc); /* get retries */
-mace_handle_misc_intrs(mp, intr);
+mace_handle_misc_intrs(mp, intr, dev);
i = mp-tx_empty;
while (in_8(mb-pr) XMTSV) {
@@ -682,7 +682,7 @@ static irqreturn_t mace_interrupt(int ir
*/
intr = in_8(mb-ir);
if (intr != 0)
- mace_handle_misc_intrs(mp, intr);
+ mace_handle_misc_intrs(mp, intr, dev);
if (mp-tx_bad_runt) {
fs = in_8(mb-xmtfs);
mp-tx_bad_runt = 0;
@@ -817,7 +817,7 @@ static void mace_tx_timeout(unsigned lon
goto out;
/* update various counters */
-mace_handle_misc_intrs(mp, in_8(mb-ir));
+mace_handle_misc_intrs(mp, in_8(mb-ir), dev);
cp = mp-tx_cmds + NCMDS_TX * mp-tx_empty;
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] bmac: add simple ethtool support for network manager
NetworkManager will not start dhcpd on an interface unless it reports
link-up state via ethtool.
Signed-off-by: Olaf Hering [EMAIL PROTECTED]
---
drivers/net/bmac.c | 13 +
1 file changed, 13 insertions(+)
--- a/drivers/net/bmac.c
+++ b/drivers/net/bmac.c
@@ -19,6 +19,7 @@
#include linux/spinlock.h
#include linux/crc32.h
#include linux/bitrev.h
+#include linux/ethtool.h
#include asm/prom.h
#include asm/dbdma.h
#include asm/io.h
@@ -1246,6 +1247,17 @@ static void bmac_reset_and_enable(struct
}
spin_unlock_irqrestore(bp-lock, flags);
}
+static void bmac_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo
*info)
+{
+ struct bmac_data *bp = netdev_priv(dev);
+ strcpy(info-driver, bmac);
+ strcpy(info-bus_info, bp-mdev-ofdev.dev.bus_id);
+}
+
+static const struct ethtool_ops bmac_ethtool_ops = {
+ .get_drvinfo= bmac_get_drvinfo,
+ .get_link = ethtool_op_get_link,
+};
static int __devinit bmac_probe(struct macio_dev *mdev, const struct
of_device_id *match)
{
@@ -1311,6 +1323,7 @@ static int __devinit bmac_probe(struct m
dev-open = bmac_open;
dev-stop = bmac_close;
+ dev-ethtool_ops = bmac_ethtool_ops;
dev-hard_start_xmit = bmac_output;
dev-get_stats = bmac_stats;
dev-set_multicast_list = bmac_set_multicast;
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: 2.6.22: ERROR: __ucmpdi2 [drivers/net/s2io.ko] undefined!
On Tue, Jun 19, Stephen Hemminger wrote:
On Tue, 19 Jun 2007 21:02:53 +0200
Olaf Hering [EMAIL PROTECTED] wrote:
What happend to __ucmpdi2 from David Woodhouse?
google has a few hits about stuff like this on 32bit powerpc with gcc 4.1.2:
ERROR: __ucmpdi2 [drivers/net/s2io.ko] undefined!
using the drivers/net/s2io* files from 2.6.21 with 2.6.22-rc5 fixes the
compile.
25805dcf9d83098cf5492117ad2669cd14cc9b24 adds two u64 = 48 followed by
a switch statement (line 2889 and 6816).
Probably the switch(err) { needs a cast to a smaller type (like u8).
This change removes the calls to __ucmpdi2.
---
drivers/net/s2io.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -2868,6 +2868,7 @@ static void tx_intr_handler(struct fifo_
struct tx_curr_get_info get_info, put_info;
struct sk_buff *skb;
struct TxD *txdlp;
+ u8 err_mask;
get_info = fifo_data-tx_curr_get_info;
memcpy(put_info, fifo_data-tx_curr_put_info, sizeof(put_info));
@@ -2886,8 +2887,8 @@ static void tx_intr_handler(struct fifo_
}
/* update t_code statistics */
- err = 48;
- switch(err) {
+ err_mask = err 48;
+ switch(err_mask) {
case 2:
nic-mac_control.stats_info-sw_stat.
tx_buf_abort_cnt++;
@@ -6805,6 +6806,7 @@ static int rx_osm_handler(struct ring_in
u16 l3_csum, l4_csum;
unsigned long long err = rxdp-Control_1 RXD_T_CODE;
struct lro *lro;
+ u8 err_mask;
skb-dev = dev;
@@ -6813,8 +6815,8 @@ static int rx_osm_handler(struct ring_in
if (err 0x1) {
sp-mac_control.stats_info-sw_stat.parity_err_cnt++;
}
- err = 48;
- switch(err) {
+ err_mask = err 48;
+ switch(err_mask) {
case 1:
sp-mac_control.stats_info-sw_stat.
rx_parity_err_cnt++;
@@ -6867,9 +6869,9 @@ static int rx_osm_handler(struct ring_in
* Note that in this case, since checksum will be incorrect,
* stack will validate the same.
*/
- if (err != 0x5) {
- DBG_PRINT(ERR_DBG, %s: Rx error Value: 0x%llx\n,
- dev-name, err);
+ if (err_mask != 0x5) {
+ DBG_PRINT(ERR_DBG, %s: Rx error Value: 0x%x\n,
+ dev-name, err_mask);
sp-stats.rx_crc_errors++;
sp-mac_control.stats_info-sw_stat.mem_freed
+= skb-truesize;
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] fix MCA when shutting down tulip quad-NIC
On Thu, Apr 05, Valerie Henson wrote: On Tue, Apr 03, 2007 at 11:19:16PM +0200, Olaf Hering wrote: From: [EMAIL PROTECTED] https://bugzilla.novell.com/show_bug.cgi?id=SUSE39204 Wow, registering for Novell's bugzilla is painful. And in the end I get Access denied on that bug. Can you give us this information some other way? I did not see an easy way to make the bug public other than moving it to the openSuSE category. Shutting down the network causes an MCA because of an IO TLB error when a DEC quad 10/100 card is in any slot. This problem was originally seen on an HP rx4640. I'm not clear on why pci_disable_device() would fix this bug. Do you have an explanation (or can copy one out of the bug report)? I'm hesitant to make even obviously correct changes to the tulip driver without good evidence, given the incredible variety of buggy hardware out there. The comments in the bug do not have an detailed analysis. One of the comments is: ... Comment #1 From Andrew Patterson 2004-04-20 19:47:32 MST [reply] 1. ifdown the interfaces; then ifup them 2. do this in a loop from a script and it generally MCA's within 2 minutes. ... The first version for 2.6.5 contained the pci_disable_device() and a version which was commited to mainline: http://git.kernel.org/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=commitdiff;h=6379dd571265528f3911b9deafe2a29af2e71a2b Later the patch contained just the pci_disable_device() call. Andrew, does your testscript still fail in SLES10 or mainline? This looks to me like another iteration of the shutdown DMA/irq race at first glance. Grant has a patch for it; I'm working on one I consider cleaner. Thats likely the same issue. http://www.linuxarkivet.se/mlists/linux-net/0409/msg00173.html - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] fix MCA when shutting down tulip quad-NIC
From: [EMAIL PROTECTED] https://bugzilla.novell.com/show_bug.cgi?id=SUSE39204 Shutting down the network causes an MCA because of an IO TLB error when a DEC quad 10/100 card is in any slot. This problem was originally seen on an HP rx4640. Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- Andrew: Why is it tp-pdev instead of pdev? drivers/net/tulip/tulip_core.c |1 + 1 file changed, 1 insertion(+) Index: b/drivers/net/tulip/tulip_core.c === --- a/drivers/net/tulip/tulip_core.c +++ b/drivers/net/tulip/tulip_core.c @@ -1798,6 +1798,7 @@ static void __devexit tulip_remove_one ( return; tp = netdev_priv(dev); + pci_disable_device(tp-pdev); unregister_netdev(dev); pci_free_consistent (pdev, sizeof (struct tulip_rx_desc) * RX_RING_SIZE + - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] mark non-compiling ISA network drivers i386 only
Provide drivers for the old toys only on i386 isa_bus_to_virt is defined only on i386, mips and arm isa_virt_to_bus is used for floppy.ko Add missing ' ISA_DMA_API' to NI52 WARNING: isa_bus_to_virt [drivers/net/ni65.ko] undefined! WARNING: isa_virt_to_bus [drivers/net/ni65.ko] undefined! WARNING: isa_bus_to_virt [drivers/net/ni52.ko] undefined! WARNING: isa_bus_to_virt [drivers/net/lance.ko] undefined! WARNING: isa_virt_to_bus [drivers/net/lance.ko] undefined! WARNING: isa_bus_to_virt [drivers/net/3c515.ko] undefined! WARNING: isa_virt_to_bus [drivers/net/3c515.ko] undefined! WARNING: isa_virt_to_bus [drivers/net/3c505.ko] undefined! I'm sure noone will miss the drivers. Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- drivers/net/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: linux-2.6/drivers/net/Kconfig === --- linux-2.6.orig/drivers/net/Kconfig +++ linux-2.6/drivers/net/Kconfig @@ -616,7 +616,7 @@ config EL2 config ELPLUS tristate 3c505 \EtherLink Plus\ support - depends on NET_VENDOR_3COM ISA ISA_DMA_API + depends on NET_VENDOR_3COM ISA ISA_DMA_API X86 ---help--- Information about this network (Ethernet) card can be found in file:Documentation/networking/3c505.txt. If you have a card of @@ -657,7 +657,7 @@ config EL3 config 3C515 tristate 3c515 ISA \Fast EtherLink\ - depends on NET_VENDOR_3COM (ISA || EISA) ISA_DMA_API + depends on NET_VENDOR_3COM (ISA || EISA) ISA_DMA_API X86 help If you have a 3Com ISA EtherLink XL Corkscrew 3c515 Fast Ethernet network card, say Y and read the Ethernet-HOWTO, available from @@ -735,7 +735,7 @@ config TYPHOON config LANCE tristate AMD LANCE and PCnet (AT1500 and NE2100) support - depends on NET_ETHERNET ISA ISA_DMA_API + depends on NET_ETHERNET ISA ISA_DMA_API X86 help If you have a network (Ethernet) card of this type, say Y and read the Ethernet-HOWTO, available from @@ -918,7 +918,7 @@ config NI5010 config NI52 tristate NI5210 support - depends on NET_VENDOR_RACAL ISA + depends on NET_VENDOR_RACAL ISA ISA_DMA_API X86 help If you have a network (Ethernet) card of this type, say Y and read the Ethernet-HOWTO, available from @@ -930,7 +930,7 @@ config NI52 config NI65 tristate NI6510 support - depends on NET_VENDOR_RACAL ISA ISA_DMA_API + depends on NET_VENDOR_RACAL ISA ISA_DMA_API X86 help If you have a network (Ethernet) card of this type, say Y and read the Ethernet-HOWTO, available from - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] mark non-compiling ISA network drivers i386 only
On Thu, Nov 09, Stephen Hemminger wrote: On Thu, 9 Nov 2006 19:40:21 +0100 (MET) Olaf Hering [EMAIL PROTECTED] wrote: Provide drivers for the old toys only on i386 isa_bus_to_virt is defined only on i386, mips and arm isa_virt_to_bus is used for floppy.ko Why not mark all of ISA as i386, mips, arm only? This patch is mainly for users of these 3 macros: '(isa_virt_to_bus|isa_page_to_bus|isa_bus_to_virt)' 3c505.c 3c515.c 3c523.c 3c527.c aha1542.c cs89x0.c esp.c ibmmca.c lance.c mca_53c9x.c ni52.c ni65.c ps2esdi.c ultrastor.c wd7000.c I did not enable all of them in a ppc32 pmac config. ppc32 PReP does have ISA slots on the motorola boards, no idea if anyone really cares about ISA cards today. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: revert mv643xx change from ubuntu tree
On Fri, Oct 20, Ben Collins wrote: On Thu, 2006-10-19 at 14:18 +0200, Olaf Hering wrote: Somehow the Ubuntu guys managed to sneak this compile error into the tree: commit ce9e3d9953c8cb67001719b5516da2928e956be4 [mv643xx] Add pci device table for auto module loading. drivers/net/mv643xx_eth.c:1560: error: array type has incomplete element type drivers/net/mv643xx_eth.c:1561: warning: implicit declaration of function ‘PCI_DEVICE’ drivers/net/mv643xx_eth.c:1561: error: ‘PCI_VENDOR_ID_MARVELL’ undeclared here (not in a function) drivers/net/mv643xx_eth.c:1561: error: ‘PCI_DEVICE_ID_MARVELL_MV64360’ undeclared here (not in a function) Correct, I missed the include for linux/pci.h. This patch has been trailing our tree since 2.6.12. Could you help me to understand what in this driver will cause it to be autoloaded by udev when compiled as a module? See commit ce9e3d9953c8cb67001719b5516da2928e956be4, platform devices have now a modalias entry in sysfs. The network card is not a PCI device. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] keep track of network interface renaming
Keep track about which network interface names were renamed after the
network device driver printed its banner. Previous kernel names will
be reused when new interfaces get registerd.
Recent udev scripts implement a stable kernel device name for network
interfaces.
This printk avoids confusion about what network hardware maps to what
kernel interface in later driver or network stack messages.
Signed-off-by: Olaf Hering [EMAIL PROTECTED]
---
net/core/dev.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Index: linux-2.6.18-rc4/net/core/dev.c
===
--- linux-2.6.18-rc4.orig/net/core/dev.c
+++ linux-2.6.18-rc4/net/core/dev.c
@@ -738,8 +738,11 @@ int dev_change_name(struct net_device *d
}
else if (__dev_get_by_name(newname))
return -EEXIST;
- else
+ else {
+ if (strcmp(newname, dev-name))
+ printk(KERN_INFO %s renamed to %s\n, dev-name,
newname);
strlcpy(dev-name, newname, IFNAMSIZ);
+ }
err = class_device_rename(dev-class_dev, dev-name);
if (!err) {
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
incorrect usage of UTS_RELEASE in bcm43xx_get_drvinfo
bcm43xx_get_drvinfo in 2.6.18-rc2 unfortunately uses UTS_RELEASE as driver version. I think this specific info can be obtained by other ways. Can you give bcm43xx a real version number and provide it via the ethtool ioctl? It will trigger a rebuild if the uname -r of the kernel to build changes. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: incorrect usage of UTS_RELEASE in bcm43xx_get_drvinfo
On Fri, Jul 21, Michael Buesch wrote: On Friday 21 July 2006 20:59, Olaf Hering wrote: bcm43xx_get_drvinfo in 2.6.18-rc2 unfortunately uses UTS_RELEASE as driver version. I think this specific info can be obtained by other ways. Can you give bcm43xx a real version number and provide it via the ethtool ioctl? I am not going to maintain a bogus version number. What about simply returning 1.0 and be done with it. I don't think it matters. 1.0 is as bogus as any other value. I'm less concerned about the actual number, just UTS_RELEASE should disappear, and the #include. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Linux v2.6.17-rc4
On Fri, May 12, Michael Buesch wrote: On Friday 12 May 2006 12:24, you wrote: On Thu, May 11, 2006 at 04:44:03PM -0700, Linus Torvalds wrote: Ok, I've let the release time between -rc's slide a bit too much again, but -rc4 is out there, and this is the time to hunker down for 2.6.17. If you know of any regressions, please holler now, so that we don't miss them. I got assertion failures in the bcm43xx driver: bcm43xx: Chip ID 0x4318, rev 0x2 That is expected an non-fatal. Is this one in the same category? [ 79.087115] bcm43xx: WARNING: Writing invalid LOpair (low: 46, high: 104, index: 123) [0.00] Using PowerMac machine description [0.00] Total memory = 768MB; using 2048kB for hash table (at cfe0) [0.00] Linux version 2.6.17-rc4-airport ([EMAIL PROTECTED]) (gcc version 4.1.0 (SUSE Linux)) #3 Fri May 12 13:12:42 CEST 2006 [0.00] Found initrd at 0xc410:0xc445d000 [0.00] Found UniNorth memory controller host bridge @ 0xf800 revision: 0xd2 [0.00] Mapped at 0xfdfc [0.00] Found a Intrepid mac-io controller, rev: 0, mapped at 0xfdf4 [0.00] Processor NAP mode on idle enabled. [0.00] PowerMac motherboard: iBook G4 [0.00] via-pmu: Server Mode is disabled [0.00] PMU driver v2 initialized for Core99, firmware: 0c [0.00] Found UniNorth PCI host bridge at 0xf000. Firmware bus number: 0-0 [0.00] Found UniNorth PCI host bridge at 0xf200. Firmware bus number: 0-0 [0.00] Found UniNorth PCI host bridge at 0xf400. Firmware bus number: 0-0 [0.00] Top of RAM: 0x3000, Total RAM: 0x3000 [0.00] Memory hole size: 0MB [0.00] On node 0 totalpages: 196608 [0.00] DMA zone: 196608 pages, LIFO batch:31 [0.00] Built 1 zonelists [0.00] Kernel command line: root=/dev/hda2 quiet time sysrq=1 [0.00] mpic: Setting up MPIC MPIC 1version 1.2 at 8004, max 4 CPUs [0.00] mpic: ISU size: 64, shift: 6, mask: 3f [0.00] mpic: Initializing for 64 sources [0.00] PID hash table entries: 4096 (order: 12, 16384 bytes) [0.00] time_init: decrementer frequency = 18.432000 MHz [0.00] time_init: processor frequency = 1333.30 MHz [ 23.809911] Console: colour dummy device 80x25 [ 23.810822] Dentry cache hash table entries: 131072 (order: 7, 524288 bytes) [ 23.812165] Inode-cache hash table entries: 65536 (order: 6, 262144 bytes) [ 23.854228] Memory: 767232k/786432k available (3160k kernel code, 18664k reserved, 448k data, 2177k bss, 160k init) [ 23.854480] Calibrating delay loop... 36.76 BogoMIPS (lpj=183808) [ 24.039729] Mount-cache hash table entries: 512 [ 24.040130] device-tree: Duplicate name in /cpus/PowerPC,[EMAIL PROTECTED], renamed to l2-cache#1 [ 24.043262] checking if image is initramfs... it is [ 24.734182] Freeing initrd memory: 3444k freed [ 24.735401] NET: Registered protocol family 16 [ 24.736061] KeyWest i2c @0xf8001003 irq 42 /[EMAIL PROTECTED]/[EMAIL PROTECTED] [ 24.736074] channel 1 bus /[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL PROTECTED] [ 24.736123] KeyWest i2c @0x80018000 irq 26 /[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL PROTECTED] [ 24.736134] channel 0 bus /[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL PROTECTED] [ 24.736161] PMU i2c /[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL PROTECTED]/pmu-i2c [ 24.736169] channel 1 bus multibus [ 24.736176] channel 2 bus multibus [ 24.736706] PCI: Probing PCI hardware [ 24.739527] PCI: Cannot allocate resource region 0 of device 0001:10:18.0 [ 24.739549] PCI: Cannot allocate resource region 0 of device 0001:10:19.0 [ 24.739583] Apple USB OHCI 0001:10:18.0 disabled by firmware [ 24.739596] Apple USB OHCI 0001:10:19.0 disabled by firmware [ 24.740556] usbcore: registered new driver usbfs [ 24.740655] usbcore: registered new driver hub [ 24.740917] TC classifier action (bugs to netdev@vger.kernel.org cc [EMAIL PROTECTED]) [ 24.741608] NET: Registered protocol family 2 [ 24.829781] IP route cache hash table entries: 32768 (order: 5, 131072 bytes) [ 24.830282] TCP established hash table entries: 131072 (order: 9, 2097152 bytes) [ 24.839978] TCP bind hash table entries: 65536 (order: 8, 1310720 bytes) [ 24.846243] TCP: Hash tables configured (established 131072 bind 65536) [ 24.846253] TCP reno registered [ 24.846361] Thermal assist unit not available [ 24.848508] VFS: Disk quotas dquot_6.5.1 [ 24.848561] Dquot-cache hash table entries: 1024 (order 0, 4096 bytes) [ 24.848760] Initializing Cryptographic API [ 24.848777] io scheduler noop registered [ 24.848792] io scheduler anticipatory registered [ 24.848806] io scheduler deadline registered [ 24.848833] io scheduler cfq registered (default) [ 24.849393] PCI: Enabling device :00:10.0 (0006 - 0007) [ 25.045487] radeonfb
kmalloc_node returns unaligned memory
kmalloc_node returns unaligned pointers on powerpc, when CONFIG_DEBUG_SLAB is enabled. This makes iptables very unhappy. It checks the alignment in net/ipv6/netfilter/ip6_tables.c:check_entry_size_and_hooks(). __alignof__(struct ip6t_entry) returns 8. But returned pointers from xt_alloc_table_info() are unaligned: Linux version 2.6.16-rc6-git1-default-iptables-slab ([EMAIL PROTECTED]) (gcc version 4.1.0 (SUSE Linux)) #2 Mon Mar 13 15:19:45 CET 2006 ... xt_alloc_table_info(250) modprobe(1687):c0,j4294904016 newinfo/size cfc82498/0x278 xt_alloc_table_info(265) modprobe(1687):c0,j4294904038 entries[0] c449611c ip_nat_init: can't setup rules. sys_init_module(1960) modprobe(1687):c0,j4294904071 iptable_nat returned -22 ... Any ideas how to fix that? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
slab corruption in tg3_alloc_rx_skb in 2.6.16-rc5-git2
No idea if tg3 is to blame. Its a JS20, root on ext3 on raid0 on qla23xx fibrechannel 16 hours uptime, it did some package building, no special workload, some ftp download, some nfs upload. Slab corruption: start=ca7c4e60, len=2048 Redzone: 0x5a2cf071/0x5a2cf071. Last user: [c022330c](.release_mem+0x120/0x2a0) 120: ff ff ff ff 00 00 00 00 6b 6b 6b 6b 6b 6b 6b 6b Prev obj: start=ca7c4648, len=2048 Redzone: 0x5a2cf071/0x5a2cf071. Last user: [c00eb454](.free_fdtable_rcu+0xa4/0x128) 000: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 010: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b Next obj: start=ca7c5678, len=2048 Redzone: 0x170fc2a5/0x170fc2a5. Last user: [d02e6330](.tg3_alloc_rx_skb+0xd8/0x1b8 [tg3]) 000: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 010: 5a 5a ff ff ff ff ff ff 00 0d 60 f6 15 eb 81 00 Page orders: linear mapping = 24, others = 12 Found initrd at 0xc230:0xc261d1a8 Starting Linux PPC64 #1 SMP Tue Feb 28 09:16:17 UTC 2006 - ppc64_pft_size= 0x19 ppc64_interrupt_controller= 0x2 platform = 0x101 physicalMemorySize= 0x5c00 ppc64_caches.dcache_line_size = 0x80 ppc64_caches.icache_line_size = 0x80 htab_address = 0x htab_hash_mask= 0x3 - [boot]0100 MM Init [boot]0100 MM Init Done Linux version 2.6.16-rc5-git2-20060228091617-ppc64 ([EMAIL PROTECTED]) (gcc version 4.1.0 20060223 (prerelease) (SUSE Linux)) #1 SMP Tue Feb 28 09:16:17 UTC 2006 [boot]0012 Setup Arch Top of RAM: 0x5c00, Total RAM: 0x5c00 Memory hole size: 0MB PPC64 nvram contains 16384 bytes Using default idle loop On node 0 totalpages: 376832 DMA zone: 376832 pages, LIFO batch:31 DMA32 zone: 0 pages, LIFO batch:0 Normal zone: 0 pages, LIFO batch:0 HighMem zone: 0 pages, LIFO batch:0 [boot]0015 Setup Done Built 1 zonelists Kernel command line: root=/dev/md0 sysrq=1 quiet [boot]0020 XICS Init xics: no ISA interrupt controller [boot]0021 XICS Done PID hash table entries: 4096 (order: 12, 131072 bytes) time_init: decrementer frequency = 199.836166 MHz time_init: processor frequency = 1600.00 MHz Console: colour dummy device 80x25 Dentry cache hash table entries: 262144 (order: 9, 2097152 bytes) Inode-cache hash table entries: 131072 (order: 8, 1048576 bytes) freeing bootmem node 0 Memory: 1464112k/1507328k available (4336k kernel code, 43216k reserved, 1956k data, 852k bss, 252k init) Calibrating delay loop... 398.95 BogoMIPS (lpj=1994752) Security Framework v1.0.0 initialized Mount-cache hash table entries: 256 checking if image is initramfs... it is Freeing initrd memory: 3188k freed Processor 1 found. Brought up 2 CPUs migration_cost=819 NET: Registered protocol family 16 Installing base platform functions... All base functions installed PCI: Probing PCI hardware IOMMU table initialized, virtual merging enabled IDE Fixup IRQ: Can't find IO-APIC ! mapping IO 100f400 - d800, size: 40 PCI: Probing PCI hardware done Registering pmac pic with sysfs... usbcore: registered new driver usbfs usbcore: registered new driver hub TC classifier action (bugs to netdev@vger.kernel.org cc [EMAIL PROTECTED]) IBM eBus Device Driver probe_bus_pseries: processing c0005bffcc48 RTAS daemon started RTAS: event: 20, Type: Unknown, Severity: 1 RTAS: event: 21, Type: Unknown, Severity: 1 probe_bus_pseries: processing c0005bffcda8 probe_bus_pseries: processing c0005bffcef0 audit: initializing netlink socket (disabled) audit(1141427449.409:1): initialized Total HugeTLB memory allocated, 0 VFS: Disk quotas dquot_6.5.1 Dquot-cache hash table entries: 512 (order 0, 4096 bytes) Initializing Cryptographic API io scheduler noop registered io scheduler anticipatory registered io scheduler deadline registered io scheduler cfq registered (default) vio_register_driver: driver hvc_console registering HVSI: registered 0 devices Generic RTC Driver v1.07 Serial: 8250/16550 driver $Revision: 1.90 $ 4 ports, IRQ sharing disabled pmac_zilog: 0.6 (Benjamin Herrenschmidt [EMAIL PROTECTED]) RAMDISK driver initialized: 16 RAM disks of 123456K size 1024 blocksize input: Macintosh mouse button emulation as /class/input/input0 Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx AMD8111: IDE controller at PCI slot :00:04.1 AMD8111: chipset revision 3 AMD8111: :00:04.1 (rev 03) UDMA133 controller AMD8111: 100% native mode on irq 32 ide0: BM-DMA at 0x7c00-0x7c07, BIOS settings: hda:pio, hdb:pio ide1: BM-DMA at 0x7c08-0x7c0f, BIOS settings: hdc:pio, hdd:pio Probing IDE interface ide0... hda: TOSHIBA MK6026GAXB, ATA DISK drive ide0 at 0x7400-0x7407,0x6c02 on irq 32 Probing IDE interface ide1... Probing IDE interface ide1... hda: max request size: 128KiB
Re: SLAB corruption with sungem
On Mon, Mar 06, Benjamin Herrenschmidt wrote: On Fri, 2006-03-03 at 09:06 +0100, Olaf Hering wrote: the RX errors I'm seeing every once in a while are still there in 2.6.16rc5. Maybe they happen if there is some IO load on the IDE disks, just upgraded openoffice.rpm Which machine is this ? Apple has several revs of Sungem, some of them supposedly fixing fifo bugs... I'd like to try to reproduce here :) PowerMac3,1, g4/450, which shows the slab corruption from time to time sungem.c:v0.98 8/24/03 David S. Miller (davem@redhat.com) PHY ID: 406212, addr: 0 eth0: Sun GEM (PCI) 10/100/1000BaseT Ethernet 00:0a:27:e2:f3:3e eth0: Found BCM5201 PHY eth0: Link is up at 100 Mbps, full-duplex. PowerMac7,2, G5/1.6, which did not show slab corruption yet sungem.c:v0.98 8/24/03 David S. Miller (davem@redhat.com) PHY ID: 2062e0, addr: 1 eth0: Sun GEM (PCI) 10/100/1000BaseT Ethernet 00:0a:95:a6:5d:66 eth0: Found BCM5421-K2 PHY eth0 renamed to gem - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)
On Fri, Mar 03, Jesse Brandeburg wrote: thanks for testing, I wonder if there is something wrong with my 630, oh well. You have them in SMP mode (non-partitioned)? Maybe that makes a difference. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
SLAB corruption with sungem
the RX errors I'm seeing every once in a while are still there in 2.6.16rc5. Maybe they happen if there is some IO load on the IDE disks, just upgraded openoffice.rpm Mar 3 08:56:35 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Mar 3 08:56:35 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Mar 3 08:57:51 nectarine last message repeated 45 times Mar 3 08:59:11 nectarine last message repeated 22 times Mar 3 08:59:11 nectarine kernel: eth0: RX MAC fifo overflow smac[00010400]. Mar 3 08:59:11 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Mar 3 08:59:11 nectarine last message repeated 108 times Mar 3 08:59:11 nectarine kernel: eth0: RX MAC fifo overflow smac[00810400]. Mar 3 08:59:11 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Mar 3 08:59:11 nectarine last message repeated 22 times Mar 3 08:59:11 nectarine kernel: eth0: RX MAC fifo overflow smac[02010400]. Mar 3 08:59:11 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Mar 3 08:59:21 nectarine last message repeated 600 times Mar 3 08:59:41 nectarine kernel: Slab corruption: start=db84f164, len=2048 Mar 3 08:59:41 nectarine kernel: Redzone: 0x5a2cf071/0x5a2cf071. Mar 3 08:59:41 nectarine kernel: Last user: [c0262a0c](skb_release_data+0xb8/0xcc) Mar 3 08:59:41 nectarine kernel: 010: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 1d 14 ff ff Mar 3 08:59:41 nectarine kernel: 020: ff ff ff ff 00 08 54 0a cf 94 08 06 00 01 08 00 Mar 3 08:59:41 nectarine kernel: 030: 06 04 00 01 00 08 54 0a cf 94 0a 0a 01 1d 00 00 Mar 3 08:59:41 nectarine kernel: 040: 00 00 00 00 0a 0a 00 08 00 00 00 00 00 00 00 00 Mar 3 08:59:41 nectarine kernel: 050: 00 00 00 00 00 00 00 00 00 00 ca 9f 17 b6 54 0a Mar 3 08:59:41 nectarine kernel: 060: cf 94 08 06 00 00 00 00 00 00 00 00 00 00 00 00 Mar 3 08:59:41 nectarine kernel: Prev obj: start=db84e958, len=2048 Mar 3 08:59:41 nectarine kernel: Redzone: 0x170fc2a5/0x170fc2a5. Mar 3 08:59:41 nectarine kernel: Last user: [c02976b4](tcp_sendmsg+0x164/0xc1c) Mar 3 08:59:41 nectarine kernel: 000: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a Mar 3 08:59:41 nectarine kernel: 010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a Mar 3 09:00:34 nectarine kernel: Slab corruption: start=db84f164, len=2048 Mar 3 09:00:34 nectarine kernel: Redzone: 0x5a2cf071/0x5a2cf071. Mar 3 09:00:34 nectarine kernel: Last user: [c0262a0c](skb_release_data+0xb8/0xcc) Mar 3 09:00:34 nectarine kernel: 010: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 1d 14 ff ff Mar 3 09:00:34 nectarine kernel: 020: ff ff ff ff 00 d0 b7 a9 e9 a0 08 06 00 01 08 00 Mar 3 09:00:34 nectarine kernel: 030: 06 04 00 01 00 d0 b7 a9 e9 a0 0a 0a 00 9f 00 00 Mar 3 09:00:34 nectarine kernel: 040: 00 00 00 00 0a 0a 00 08 00 00 00 00 00 00 00 00 Mar 3 09:00:34 nectarine kernel: 050: 00 00 00 00 00 00 00 00 00 00 b2 3b 8a 55 b7 a9 Mar 3 09:00:34 nectarine kernel: 060: e9 a0 08 06 00 00 00 00 00 00 00 00 00 00 00 00 Mar 3 09:00:34 nectarine kernel: Prev obj: start=db84e958, len=2048 Mar 3 09:00:34 nectarine kernel: Redzone: 0x170fc2a5/0x170fc2a5. Mar 3 09:00:34 nectarine kernel: Last user: [c02976b4](tcp_sendmsg+0x164/0xc1c) Mar 3 09:00:34 nectarine kernel: 000: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a Mar 3 09:00:34 nectarine kernel: 010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a Linux version 2.6.16-rc5-git2-20060228152604-default ([EMAIL PROTECTED]) (gcc version 4.1.0 20060223 (prerelease) (SUSE Linux)) #1 Tue Feb 28 15:26:04 UTC 2006 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)
On Mon, Feb 27, Jesse Brandeburg wrote: http://ozlabs.org/pipermail/linuxppc-dev/2006-February/021308.html Olaf I reproduced this problem on a 630 and this patch fixes it for me, please verify. Due to the new load ucode command the cb list must be allocated before calling e100_init_hw. Ignore the crazy paths on the files. (patch -p1 should take care of) Yes, this patch helps. Thanks. --- linux-2.6.16-rc5/drivers/net/e100.c 2006-02-26 21:09:35.0 -0800 +++ linux-2.6.15.1/drivers/net/e100.c 2006-02-27 17:03:34.0 -0800 @@ -2154,6 +2154,9 @@ static int e100_loopback_test(struct nic msleep(10); + pci_dma_sync_single_for_cpu(nic-pdev, nic-rx_to_clean-dma_addr, + RFD_BUF_LEN, PCI_DMA_FROMDEVICE); + if(memcmp(nic-rx_to_clean-skb-data + sizeof(struct rfd), skb-data, ETH_DATA_LEN)) err = -EAGAIN; @@ -2161,8 +2164,9 @@ static int e100_loopback_test(struct nic err_loopback_none: mdio_write(nic-netdev, nic-mii.phy_id, MII_BMCR, 0); nic-loopback = lb_none; - e100_hw_init(nic); e100_clean_cbs(nic); + e100_alloc_cbs(nic); + e100_hw_init(nic); err_clean_rx: e100_rx_clean_list(nic); return err; - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6 patch] make UNIX a bool
On Sat, Feb 25, Adrian Bunk wrote: CONFIG_UNIX=m doesn't make much sense. There is likely more code to support a modular unix.ko, this has to go as well. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] keep track of network interface renaming
On Sat, Feb 18, Jeff Garzik wrote: Fix Xen network support not to do such stupid stuff... No Xen due to lack of A20 gates. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] keep track of network interface renaming
Keep track about which network interface names were renamed after the
network device driver printed its banner. Example insanity:
honeydew:~ # dmesg| grep -Ew '(eth[0-9]|rename|renamed)'
e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection
e1000: eth1: e1000_probe: Intel(R) PRO/1000 Network Connection
e1000: eth2: e1000_probe: Intel(R) PRO/1000 Network Connection
e1000: eth3: e1000_probe: Intel(R) PRO/1000 Network Connection
dev_change_name: about to rename 'eth3' to 'eth0'
dev_change_name: about to rename 'eth3' to 'ethxx3'
eth3 renamed to ethxx3
dev_change_name: about to rename 'ethxx3' to 'eth0'
dev_change_name: about to rename 'eth0' to 'eth3'
eth0 renamed to eth3
dev_change_name: about to rename 'eth1' to 'eth2'
dev_change_name: about to rename 'eth1' to 'ethxx1'
eth1 renamed to ethxx1
dev_change_name: about to rename 'ethxx1' to 'eth2'
dev_change_name: about to rename 'eth2' to 'eth1'
eth2 renamed to eth1
dev_change_name: about to rename 'ethxx3' to 'eth0'
ethxx3 renamed to eth0
dev_change_name: about to rename 'ethxx1' to 'eth2'
ethxx1 renamed to eth2
e1000: eth0: e1000_watchdog_task: NIC Link is Up 100 Mbps Full Duplex
The KERN_DEBUG line can obviously go in the final version.
Signed-off-by: Olaf Hering [EMAIL PROTECTED]
net/core/dev.c |5 +
1 files changed, 5 insertions(+)
Index: linux-2.6.16-rc4-olh/net/core/dev.c
===
--- linux-2.6.16-rc4-olh.orig/net/core/dev.c
+++ linux-2.6.16-rc4-olh/net/core/dev.c
@@ -713,6 +713,7 @@ int dev_change_name(struct net_device *d
{
int err = 0;
+ printk(KERN_DEBUG %s: about to rename '%s' to '%s'\n, __FUNCTION__,
dev-name, newname);
ASSERT_RTNL();
if (dev-flags IFF_UP)
@@ -730,7 +731,11 @@ int dev_change_name(struct net_device *d
else if (__dev_get_by_name(newname))
return -EEXIST;
else
+ {
+ if (strncmp(newname, dev-name, IFNAMSIZ))
+ printk(KERN_INFO %s renamed to %s\n, dev-name,
newname);
strlcpy(dev-name, newname, IFNAMSIZ);
+ }
err = class_device_rename(dev-class_dev, dev-name);
if (!err) {
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: slab corruption after sungem recieve errors
On Fri, Feb 10, Olaf Hering wrote: I have seen this kind of error every once in a while on my G4/450 Mac. Linux version 2.6.13-20050921064541-default ([EMAIL PROTECTED]) (gcc version 4.0.2 20050901 (prerelease) (SUSE Linux)) #1 Wed Sep 21 06:45:41 UTC 2005 sungem.c:v0.98 8/24/03 David S. Miller (davem@redhat.com) PHY ID: 406212, addr: 0 eth0: Sun GEM (PCI) 10/100/1000BaseT Ethernet 00:0a:27:e2:f3:3e eth0: Found BCM5201 PHY eth0: Link is up at 100 Mbps, full-duplex. 86days uptime. Feb 10 10:28:24 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Feb 10 10:28:24 nectarine last message repeated 3 times Feb 10 10:28:24 nectarine kernel: eth0: RX MAC fifo overflow smac[00810400]. A G5 one the same switch had the same trouble, but no slab corruption. Feb 10 10:24:42 mac -- MARK -- Feb 10 10:28:25 mac kernel: gem: RX MAC fifo overflow smac[00910440]. Feb 10 10:28:26 mac kernel: gem: RX MAC fifo overflow smac[00810440]. Feb 10 10:44:42 mac -- MARK -- sungem.c:v0.98 8/24/03 David S. Miller (davem@redhat.com) PHY ID: 2062e0, addr: 1 ADDRCONF(NETDEV_UP): eth0: link is not ready eth0: Sun GEM (PCI) 10/100/1000BaseT Ethernet 00:0a:95:a6:5d:66 eth0: Found BCM5421-K2 PHY tg3.c:v3.49 (Feb 2, 2006) PCI: Enabling device: (0001:06:03.0), cmd 6 gem: Link is up at 100 Mbps, full-duplex. eth0: Tigon3 [partno(3C996B-T) rev 0105 PHY(5701)] (PCI:33MHz:64-bit) 10/100/1000BaseT Ethernet 00:04:76:f3:c2:4f eth0: RXcsums[1] LinkChgREG[0] MIirq[0] ASF[0] Split[0] WireSpeed[1] TSOcap[0] eth0: dma_rwctrl[76ff2d0f] ADDRCONF(NETDEV_UP): eth0: link is not ready ADDRCONF(NETDEV_UP): bcm: link is not ready gem: Link is up at 100 Mbps, full-duplex. gem: Pause is enabled (rxfifo: 10240 off: 7168 on: 5632) Linux version 2.6.16-rc2-git2-6-ppc64 ([EMAIL PROTECTED]) (gcc version 4.1.0 20060201 (prerelease) (SUSE Linux)) #1 SMP Wed Feb 8 02:56:22 UTC 2006 -- short story of a lazy sysadmin: alias appserv=wotan - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
slab corruption after sungem recieve errors
I have seen this kind of error every once in a while on my G4/450 Mac. Linux version 2.6.13-20050921064541-default ([EMAIL PROTECTED]) (gcc version 4.0.2 20050901 (prerelease) (SUSE Linux)) #1 Wed Sep 21 06:45:41 UTC 2005 sungem.c:v0.98 8/24/03 David S. Miller (davem@redhat.com) PHY ID: 406212, addr: 0 eth0: Sun GEM (PCI) 10/100/1000BaseT Ethernet 00:0a:27:e2:f3:3e eth0: Found BCM5201 PHY eth0: Link is up at 100 Mbps, full-duplex. Nov 15 15:01:55 nectarine -- MARK -- Nov 15 15:09:16 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:16 nectarine last message repeated 3 times Nov 15 15:09:16 nectarine kernel: eth0: RX MAC fifo overflow smac[00810400]. Nov 15 15:09:16 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:16 nectarine last message repeated 2 times Nov 15 15:09:16 nectarine kernel: eth0: RX MAC fifo overflow smac[00810400]. Nov 15 15:09:16 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:17 nectarine last message repeated 7 times Nov 15 15:09:17 nectarine kernel: eth0: RX MAC fifo overflow smac[00810400]. Nov 15 15:09:17 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:17 nectarine last message repeated 3 times Nov 15 15:09:17 nectarine kernel: eth0: RX MAC fifo overflow smac[04010400]. Nov 15 15:09:17 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:19 nectarine last message repeated 9 times Nov 15 15:09:19 nectarine kernel: eth0: RX MAC fifo overflow smac[00010400]. Nov 15 15:09:19 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:19 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:19 nectarine kernel: eth0: RX MAC fifo overflow smac[00810400]. Nov 15 15:09:19 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:19 nectarine last message repeated 2 times Nov 15 15:09:19 nectarine kernel: eth0: RX MAC fifo overflow smac[00810400]. Nov 15 15:09:19 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:21 nectarine last message repeated 11 times Nov 15 15:09:22 nectarine kernel: eth0: RX MAC fifo overflow smac[04010400]. Nov 15 15:09:22 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:22 nectarine last message repeated 4 times Nov 15 15:09:22 nectarine kernel: eth0: RX MAC fifo overflow smac[00010400]. Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:24 nectarine last message repeated 10 times Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[00010400]. Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:24 nectarine last message repeated 26 times Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[01010400]. Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:24 nectarine last message repeated 5 times Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[00810400]. Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:24 nectarine last message repeated 11 times Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[04010400]. Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:24 nectarine last message repeated 7 times Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[00010400]. Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:24 nectarine kernel: Slab corruption: start=ca0d64e8, len=2048 Nov 15 15:09:24 nectarine kernel: Redzone: 0x5a2cf071/0x5a2cf071. Nov 15 15:09:24 nectarine kernel: Last user: [c0241980](skb_release_data+0xf0/0x104) Nov 15 15:09:24 nectarine kernel: 010: 6b 6b 6b 6b 6b 6b 6b 6b 1d 14 ff ff ff ff ff ff Nov 15 15:09:24 nectarine kernel: 020: 00 e0 2b 5e c4 00 08 06 00 01 08 00 06 04 00 01 Nov 15 15:09:24 nectarine kernel: 030: 00 e0 2b 5e c4 00 0a 0a de 64 00 00 00 00 00 00 Nov 15 15:09:24 nectarine kernel: 040: 0a 0a 81 01 00 00 00 00 00 00 00 00 00 00 00 00 Nov 15 15:09:24 nectarine kernel: 050: 00 00 7e 31 7e 31 ab c8 51 b7 2b 89 70 00 08 06 Nov 15 15:09:24 nectarine kernel: 060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Nov 15 15:09:24 nectarine kernel: Next obj: start=ca0d6cf4, len=2048 Nov 15 15:09:24 nectarine kernel: Redzone: 0x170fc2a5/0x170fc2a5. Nov 15 15:09:24 nectarine kernel: Last user: [c023fff4](alloc_skb+0x44/0xd4) Nov 15 15:09:24 nectarine kernel: 000: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 1d 14 ff ff Nov 15 15:09:24 nectarine kernel: 010: ff ff ff ff 00 e0 2b 89 70 00 08 06 00 01 08 00 Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[03810400]. Nov 15 15:09:24 nectarine last message repeated 2 times Nov 15 15:09:24 nectarine kernel: eth0: RX MAC fifo overflow smac[00810400]. Nov 15 15:09:24 nectarine kernel: eth0: RX MAC
Re: [PATCH netdev-2.6 30/39] e1000: Added variable to handle return values for pci_enable_* functions
On Wed, Jan 11, Jeff Kirsher wrote:
Added variable to handle return values for pci_enable_* functions
This was to fix compilation warnings. Also added log messages when
pci_enable_* functions return with an error.
I object to this patch.
Useless error messages for unhandled return values. Please revert that
part.
No idea if every system in the world is supposed to implement D3 and
friends. But for me it always returns -22. Maybe because I'm short on
A20 gates.
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 75cd6df..8207db4 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -4382,6 +4382,7 @@ e1000_suspend(struct pci_dev *pdev, pm_m
struct e1000_adapter *adapter = netdev_priv(netdev);
uint32_t ctrl, ctrl_ext, rctl, manc, status;
uint32_t wufc = adapter-wol;
+ int retval = 0;
netif_device_detach(netdev);
@@ -4427,13 +4428,21 @@ e1000_suspend(struct pci_dev *pdev, pm_m
E1000_WRITE_REG(adapter-hw, WUC, E1000_WUC_PME_EN);
E1000_WRITE_REG(adapter-hw, WUFC, wufc);
- pci_enable_wake(pdev, 3, 1);
- pci_enable_wake(pdev, 4, 1); /* 4 == D3 cold */
+ retval = pci_enable_wake(pdev, PCI_D3hot, 1);
+ if (retval)
+ DPRINTK(PROBE, ERR, Error enabling D3 wake\n);
+ retval = pci_enable_wake(pdev, PCI_D3cold, 1);
+ if (retval)
+ DPRINTK(PROBE, ERR, Error enabling D3 cold wake\n);
} else {
E1000_WRITE_REG(adapter-hw, WUC, 0);
E1000_WRITE_REG(adapter-hw, WUFC, 0);
- pci_enable_wake(pdev, 3, 0);
- pci_enable_wake(pdev, 4, 0); /* 4 == D3 cold */
+ retval = pci_enable_wake(pdev, PCI_D3hot, 0);
+ if (retval)
+ DPRINTK(PROBE, ERR, Error enabling D3 wake\n);
+ retval = pci_enable_wake(pdev, PCI_D3cold, 0); /* 4 == D3 cold
*/
+ if (retval)
+ DPRINTK(PROBE, ERR, Error enabling D3 cold wake\n);
}
...
--
short story of a lazy sysadmin:
alias appserv=wotan
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tulip: Make ALi (ULi) integrated 100BaseTX Ethernet work
On Mon, Jan 23, Andrew Morton wrote:
Olaf Hering [EMAIL PROTECTED] wrote:
We carry this patch since 2005-03-13. Jiri, can you check if 2.6.16
still doesnt work for you on this sort of hardware? I did not find a
bugzilla nor a better description.
Doesn't compile.
+ if (tp-chip_id == ULI526X) {
ULI526X isn't defined and I can't see anything in there which looks like it.
It did compile at some point.
Jiri, please test SLES10!
--
short story of a lazy sysadmin:
alias appserv=wotan
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tulip: Make ALi (ULi) integrated 100BaseTX Ethernet work
On Mon, Jan 23, Andrew Morton wrote: Olaf Hering [EMAIL PROTECTED] wrote: We carry this patch since 2005-03-13. Jiri, can you check if 2.6.16 still doesnt work for you on this sort of hardware? I did not find a bugzilla nor a better description. Doesn't compile. Patch is obsolete, it can be dropped. -- short story of a lazy sysadmin: alias appserv=wotan - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] tulip: Make ALi (ULi) integrated 100BaseTX Ethernet work
We carry this patch since 2005-03-13. Jiri, can you check if 2.6.16
still doesnt work for you on this sort of hardware? I did not find a
bugzilla nor a better description.
Signed-off-by: Olaf Hering [EMAIL PROTECTED]
diff -ur linux-2.6.10/drivers/net/tulip/media.c
linux-2.6.10work/drivers/net/tulip/media.c
--- linux-2.6.10/drivers/net/tulip/media.c 2005-03-01 14:10:49.0
+0100
+++ linux-2.6.10work/drivers/net/tulip/media.c 2005-03-01 15:53:56.0
+0100
@@ -517,10 +517,11 @@
/* Enable autonegotiation: some boards default to off. */
if (tp-default_port == 0) {
new_bmcr = mii_reg0 | BMCR_ANENABLE;
- if (new_bmcr != mii_reg0) {
- new_bmcr |= BMCR_ANRESTART;
- ane_switch = 1;
- }
+ /* DM9161E PHY seems to need to restart
+* autonegotiation even if it defaults to enabled.
+*/
+ new_bmcr |= BMCR_ANRESTART;
+ ane_switch = 1;
}
/* ...or disable nway, if forcing media */
else {
diff -ur linux-2.6.10/drivers/net/tulip/tulip_core.c
linux-2.6.10work/drivers/net/tulip/tulip_core.c
--- linux-2.6.10/drivers/net/tulip/tulip_core.c 2005-03-01 14:11:21.0
+0100
+++ linux-2.6.10work/drivers/net/tulip/tulip_core.c 2005-03-01
15:54:31.0 +0100
@@ -383,6 +383,11 @@
goto media_picked;
}
}
+ if (tp-chip_id == ULI526X) {
+ for (i = tp-mtable-leafcount - 1; i = 0; i--)
+ if (tulip_media_cap[tp-mtable-mleaf[i].media]
MediaIsMII)
+ goto media_picked;
+ }
/* Start sensing first non-full-duplex media. */
for (i = tp-mtable-leafcount - 1;
(tulip_media_cap[tp-mtable-mleaf[i].media] MediaAlwaysFD)
i 0; i--)
--
short story of a lazy sysadmin:
alias appserv=wotan
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] sis900 and sis190 depend on CONFIG_ISA
isa_bridge is used in drivers/net/sis190.c and drivers/net/sis900.c include/linux/pci.h hides it in CONFIG_ISA. Let both drivers depend on ISA. Signed-off-by: Olaf Hering [EMAIL PROTECTED] drivers/net/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.16-rc1-olh/drivers/net/Kconfig === --- linux-2.6.16-rc1-olh.orig/drivers/net/Kconfig +++ linux-2.6.16-rc1-olh/drivers/net/Kconfig @@ -1609,7 +1609,7 @@ config 8139_OLD_RX_RESET config SIS900 tristate SiS 900/7016 PCI Fast Ethernet Adapter support - depends on NET_PCI PCI + depends on NET_PCI PCI (ISA || EISA) select CRC32 select MII ---help--- @@ -2000,7 +2000,7 @@ config R8169_VLAN config SIS190 tristate SiS190/SiS191 gigabit ethernet support - depends on PCI + depends on PCI (ISA || EISA) select CRC32 select MII ---help--- -- short story of a lazy sysadmin: alias appserv=wotan - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] sis900 and sis190 depend on CONFIG_ISA
On Wed, Jan 18, Patrick McHardy wrote: Olaf Hering wrote: isa_bridge is used in drivers/net/sis190.c and drivers/net/sis900.c include/linux/pci.h hides it in CONFIG_ISA. Let both drivers depend on ISA. But it includes a NOP definition for the !(CONFIG_ISA || CONFIG_EISA) case, in which case the driver will print an error message (Can not find ISA bridge). I don't really like the idea of having to enable ISA although it works perfectly fine without for me. How about adding something to the Kconfig help instead (If you have a SiS630E model, you need to enable CONFIG_ISA as well.)? argh, these are local variables... -- short story of a lazy sysadmin: alias appserv=wotan - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] fix mv643xx compilation
2.6.16 needs ip.h and in.h. linux-2.6.15/drivers/net/mv643xx_eth.c: In function `mv643xx_eth_start_xmit': linux-2.6.15/drivers/net/mv643xx_eth.c:1159: error: dereferencing pointer to incomplete type linux-2.6.15/drivers/net/mv643xx_eth.c:1161: error: dereferencing pointer to incomplete type linux-2.6.15/drivers/net/mv643xx_eth.c:1161: error: `IPPROTO_UDP' undeclared (first use in this function) linux-2.6.15/drivers/net/mv643xx_eth.c:1161: error: (Each undeclared identifier is reported only once linux-2.6.15/drivers/net/mv643xx_eth.c:1161: error: for each function it appears in.) linux-2.6.15/drivers/net/mv643xx_eth.c:1164: error: dereferencing pointer to incomplete type linux-2.6.15/drivers/net/mv643xx_eth.c:1164: error: `IPPROTO_TCP' undeclared (first use in this function) linux-2.6.15/drivers/net/mv643xx_eth.c:1222: error: dereferencing pointer to incomplete type linux-2.6.15/drivers/net/mv643xx_eth.c:1224: error: dereferencing pointer to incomplete type linux-2.6.15/drivers/net/mv643xx_eth.c:1227: error: dereferencing pointer to incomplete type Signed-off-by: Olaf Hering [EMAIL PROTECTED] drivers/net/mv643xx_eth.c |1 + 1 files changed, 1 insertion(+) Index: linux-2.6.15/drivers/net/mv643xx_eth.c === --- linux-2.6.15.orig/drivers/net/mv643xx_eth.c +++ linux-2.6.15/drivers/net/mv643xx_eth.c @@ -35,6 +35,8 @@ #include linux/tcp.h #include linux/udp.h #include linux/etherdevice.h +#include linux/in.h +#include linux/ip.h #include linux/bitops.h #include linux/delay.h -- short story of a lazy sysadmin: alias appserv=wotan - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/4] mv643xx: Don't call request_irq with a held lock
On Wed, Dec 28, Dale Farnsworth wrote: From: Dale Farnsworth [EMAIL PROTECTED] We can't call request_irq() while holding a spin lock. This still calls malloc with the lock held. What is the lock trying to protect anyway? Maybe the lock should be moved to the place where the lock is really required. I was able to ping with the locks removed, but ssh did not work for some reasons. MV-643xx 10/100/1000 Ethernet Driver eth1: port 1 with MAC address 00:2b:2f:de:ad:01 eth1: Scatter Gather Enabled eth1: TX TCP/IP Checksumming Supported eth1: RX TCP/UDP Checksum Offload ON eth1: RX NAPI Enabled eth1: Using SRAM Debug: sleeping function called from invalid context at mm/slab.c:2472 in_atomic():0, irqs_disabled():1 Call Trace: [C3E01D40] [C000BCAC] show_stack+0x54/0x184 (unreliable) [C3E01D60] [C0028E68] __might_sleep+0xbc/0xd0 [C3E01D70] [C005FD3C] __kmalloc+0x88/0x158 [C3E01D90] [D2281264] mv643xx_eth_real_open+0x15c/0x4b4 [mv643xx_eth] [C3E01DC0] [D22820C0] mv643xx_eth_open+0x68/0xb0 [mv643xx_eth] [C3E01DE0] [C025638C] dev_open+0x70/0xd8 [C3E01E00] [C02544F8] dev_change_flags+0x6c/0x13c ... -- short story of a lazy sysadmin: alias appserv=wotan - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] remove bouncing mail address of mv643xx_eth maintainer
Remove bouncing mail address of mv643xx maintainer. Signed-off-by: Olaf Hering [EMAIL PROTECTED] MAINTAINERS |1 - drivers/net/mv643xx_eth.c |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6.15-rc6-olh/MAINTAINERS === --- linux-2.6.15-rc6-olh.orig/MAINTAINERS +++ linux-2.6.15-rc6-olh/MAINTAINERS @@ -1695,7 +1695,6 @@ S: Maintained MARVELL MV64340 ETHERNET DRIVER P: Manish Lachwani -M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] L: netdev@vger.kernel.org S: Supported Index: linux-2.6.15-rc6-olh/drivers/net/mv643xx_eth.c === --- linux-2.6.15-rc6-olh.orig/drivers/net/mv643xx_eth.c +++ linux-2.6.15-rc6-olh/drivers/net/mv643xx_eth.c @@ -6,7 +6,7 @@ * Copyright (C) 2002 [EMAIL PROTECTED] * * Copyright (C) 2003 PMC-Sierra, Inc., - * written by Manish Lachwani ([EMAIL PROTECTED]) + * written by Manish Lachwani * * Copyright (C) 2003 Ralf Baechle [EMAIL PROTECTED] * -- short story of a lazy sysadmin: alias appserv=wotan - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] skge: get rid of warning on race
On Tue, Dec 06, Stephen Hemminger wrote: Get rid of warning in case of race with ring full and lockless tx on the skge driver. It is possible to be in the transmit routine with no available slots and already stopped. Where do I find that netif_stopped? -- short story of a lazy sysadmin: alias appserv=wotan - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] pcnet32: use MAC address from prom also on powerpc
The CSR contains garbage after a coldboot on RS/6000.
One some systems (like my 44p 270) the MAC address is all FF,
on others (like my B50) it is ff:ff:ff:fd:ff:6b.
It can eventually be fixed by loading pcnet32, set the interface
into the UP state, rmmod pcnet32 and load it again. But this worked
only on the 270.
Only netbooting after a cold start provides the correct MAC address
via prom and CSR. This makes it very unreliable.
I dont know why the MAC is stored in two different places. Remove
the special case for powerpc, which was added in early 2.4 development.
Signed-off-by: Olaf Hering [EMAIL PROTECTED]
drivers/net/pcnet32.c |5 -
1 files changed, 5 deletions(-)
Index: linux-2.6.14-rc3/drivers/net/pcnet32.c
===
--- linux-2.6.14-rc3.orig/drivers/net/pcnet32.c
+++ linux-2.6.14-rc3/drivers/net/pcnet32.c
@@ -1172,12 +1172,7 @@ pcnet32_probe1(unsigned long ioaddr, int
if (memcmp(promaddr, dev-dev_addr, 6)
|| !is_valid_ether_addr(dev-dev_addr)) {
-#ifndef __powerpc__
if (is_valid_ether_addr(promaddr)) {
-#else
- if (!is_valid_ether_addr(dev-dev_addr)
-is_valid_ether_addr(promaddr)) {
-#endif
if (pcnet32_debug NETIF_MSG_PROBE) {
printk( warning: CSR address invalid,\n);
printk(KERN_INFO using instead PROM address of);
--
short story of a lazy sysadmin:
alias appserv=wotan
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ieee80211_crypt_tkip depends on NET_RADIO
*** Warning: .wireless_send_event [net/ieee80211/ieee80211_crypt_tkip.ko] undefined! Signed-off-by: Olaf Hering [EMAIL PROTECTED] net/ieee80211/Kconfig |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.14/net/ieee80211/Kconfig === --- linux-2.6.14.orig/net/ieee80211/Kconfig +++ linux-2.6.14/net/ieee80211/Kconfig @@ -55,7 +55,7 @@ config IEEE80211_CRYPT_CCMP config IEEE80211_CRYPT_TKIP tristate IEEE 802.11i TKIP encryption - depends on IEEE80211 + depends on IEEE80211 NET_RADIO select CRYPTO select CRYPTO_MICHAEL_MIC ---help--- -- short story of a lazy sysadmin: alias appserv=wotan - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [LLC]: Fix TX window scaling
On Tue, Nov 15, Linux Kernel Mailing List wrote: tree 574e979829d3363c16c8c6d1fe624b206d8ce4f9 parent cb422c464bdaeeb3b9ad4539010e357bf1bd1745 author Jochen Friedrich [EMAIL PROTECTED] Tue, 15 Nov 2005 13:57:15 -0800 committer David S. Miller [EMAIL PROTECTED] Tue, 15 Nov 2005 13:57:15 -0800 [LLC]: Fix TX window scaling - if (llc-npta 127) - llc-npta = 127 ; + if (llc-npta ~LLC_2_SEQ_NBR_MODULO) + llc-npta = ~LLC_2_SEQ_NBR_MODULO ; This change causes this: net/llc/llc_c_ac.c: In function `llc_conn_ac_inc_npta_value': net/llc/llc_c_ac.c:998: warning: comparison is always true due to limited range of data type net/llc/llc_c_ac.c:999: warning: large integer implicitly truncated to unsigned type net/llc/llc_c_ac.c: In function `llc_conn_ac_inc_tx_win_size': net/llc/llc_c_ac.c:1089: warning: comparison is always true due to limited range of data type net/llc/llc_c_ac.c:1090: warning: large integer implicitly truncated to unsigned type -- short story of a lazy sysadmin: alias appserv=wotan - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: more ipsec crashes in 2.6.13
On Wed, Sep 07, Herbert Xu wrote: Olaf Hering [EMAIL PROTECTED] wrote: The patch 'p' which was posted by Herbert today doesnt fix it. Can you please double check? That bug would cause exactly what you're seeing here since it'll clobber the skb's shared section which contains the nr_frags. I checked it again. 2.6.12 with the patch from 2.6.13-rc2-git3 crashes, your posted patch on top of it fixes the crash. Same with 2.6.13, your patch fixes that crash as well. I probably forgot to run lilo, the testsystem has root on lvm. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
more ipsec crashes in 2.6.13
This happens after: ssh [EMAIL PROTECTED] rcipsec restart ssh [EMAIL PROTECTED] rcipsec restart ssh [EMAIL PROTECTED] ping -i 0.01 -s 4096 g167.suse.de The patch 'p' which was posted by Herbert today doesnt fix it. put_page gets NULL. Welcome to SUSE LINUX 10.0 (PPC) - Kernel 2.6.13-ppc64-vanilla (hvc0). cube login: cpu 0x1: Vector: 300 (Data Access) at [c0004d7daff0] pc: c00a76fc: .put_page+0xc/0x120 lr: c0333a30: .skb_release_data+0xd0/0xf0 sp: c0004d7db270 msr: 80009032 dar: bdf20d2efc7304a2 dsisr: 4000 current = 0xc252e7e0 paca= 0xc04e7800 pid = 6160, comm = ping enter ? for help [c0004d7db2f0] c0333a30 .skb_release_data+0xd0/0xf0 [c0004d7db380] c0339e24 .__skb_linearize+0x124/0x1d0 [c0004d7db420] c033c334 .dev_queue_xmit+0x264/0x380 [c0004d7db4c0] c036e20c .ip_finish_output+0x18c/0x380 [c0004d7db560] c036cba0 .ip_fragment+0x640/0x8d0 [c0004d7db640] c036d308 .ip_push_pending_frames+0x4d8/0x590 [c0004d7db700] c0390e3c .raw_sendmsg+0x67c/0x850 [c0004d7db830] c039cadc .inet_sendmsg+0x6c/0xb0 [c0004d7db8d0] c032b3ac .sock_sendmsg+0x16c/0x1c0 [c0004d7dbae0] c032c454 .sys_sendmsg+0x204/0x340 [c0004d7dbd10] c034eba4 .compat_sys_sendmsg+0x14/0x30 [c0004d7dbd90] c034f530 .compat_sys_socketcall+0x290/0x2b0 [c0004d7dbe30] c000d600 syscall_exit+0x0/0x18 --- Exception: c01 (System Call) at 07f518f8 SP (ffb458a0) is in userspace 1:mon - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: more ipsec crashes in 2.6.13
On Tue, Sep 06, Olaf Hering wrote: put_page gets NULL. dar: bdf20d2efc7304a2 No, it is garbage. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: more ipsec crashes in 2.6.13
On Tue, Sep 06, Olaf Hering wrote: This happens after: ssh [EMAIL PROTECTED] rcipsec restart ssh [EMAIL PROTECTED] rcipsec restart ssh [EMAIL PROTECTED] ping -i 0.01 -s 4096 g167.suse.de The patch 'p' which was posted by Herbert today doesnt fix it. put_page gets NULL. Welcome to SUSE LINUX 10.0 (PPC) - Kernel 2.6.13-ppc64-vanilla (hvc0). cube login: cpu 0x1: Vector: 300 (Data Access) at [c0004d7daff0] pc: c00a76fc: .put_page+0xc/0x120 lr: c0333a30: .skb_release_data+0xd0/0xf0 sp: c0004d7db270 msr: 80009032 dar: bdf20d2efc7304a2 This patch from patch-2.6.13-rc2-git3 causes the crash. tree abe25ec0577bd95128adb3f38609a09f0a3e2469 parent 8279dd748f9704b811e528b31304e2fab026abc5 author Herbert Xu [EMAIL PROTECTED] Thu, 07 Jul 2005 03:51:31 -0700 committer David S. Miller [EMAIL PROTECTED] Thu, 07 Jul 2005 03:51:31 -0700 [CRYPTO] Add plumbing for multi-block operations - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
