Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals
On 2018-04-05 15:51, Joe Perches wrote: >> You have to factor in >> not just the .text size, but the fact that referencing an exported >> symbol needs a .reloc entry as well, which also eats up some space (at >> least when the code is being built as module). > > Thanks, the modules I built got smaller. Please post some numbers to show this. By the way, on other architectures the numbers will probably be different, especially on ARM/MIPS. >> In my opinion, your series probably causes more bloat in common >> configurations instead of reducing it. >> >> You're also touching several places that could easily use >> eth_broadcast_addr and eth_zero_addr. I think making those changes would >> be more productive than what you did in this series. > > Doubtful. AFAIK: possible unaligned addresses. Those two are just memset calls, alignment does not matter. - Felix
Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals
On Thu, 2018-04-05 at 15:27 +0200, Felix Fietkau wrote: > On 2018-03-31 09:05, Joe Perches wrote: > > There are many local static and non-static arrays that are used for > > Ethernet broadcast address output or comparison. > > > > Centralize the array into a single separate file and remove the local > > arrays. > > I suspect that for many targets and configurations, the local arrays > might actually be smaller than exporting a global. I tried x86-64 allnoconfig and defconfig. Those both did not increase vmlinux size. The defconfig actually got smaller, but that might have been some object alignment oddity. > You have to factor in > not just the .text size, but the fact that referencing an exported > symbol needs a .reloc entry as well, which also eats up some space (at > least when the code is being built as module). Thanks, the modules I built got smaller. > In my opinion, your series probably causes more bloat in common > configurations instead of reducing it. > > You're also touching several places that could easily use > eth_broadcast_addr and eth_zero_addr. I think making those changes would > be more productive than what you did in this series. Doubtful. AFAIK: possible unaligned addresses.
Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals
On 2018-03-31 09:05, Joe Perches wrote: > There are many local static and non-static arrays that are used for > Ethernet broadcast address output or comparison. > > Centralize the array into a single separate file and remove the local > arrays. I suspect that for many targets and configurations, the local arrays might actually be smaller than exporting a global. You have to factor in not just the .text size, but the fact that referencing an exported symbol needs a .reloc entry as well, which also eats up some space (at least when the code is being built as module). In my opinion, your series probably causes more bloat in common configurations instead of reducing it. You're also touching several places that could easily use eth_broadcast_addr and eth_zero_addr. I think making those changes would be more productive than what you did in this series. - Felix
[PATCH 00/12] Ethernet: Add and use ether__addr globals
There are many local static and non-static arrays that are used for Ethernet broadcast address output or comparison. Centralize the array into a single separate file and remove the local arrays. Joe Perches (12): ethernet: Add generic ether__addr addresses treewide/net: Rename eth_stp_addr to ether_stp_addr net: mac80211: Use global ether_broadcast_addr bridge: netfilter: Use the new global ether__addr arrays net: atm: Use ether_broadcast_addr wireless: Convert simple uses of a static const Ethernet broadcast address brcmfmac: Convert ALLFFMAC to ether_broadcast_addr iwlegacy: Remove EXPORT_SYMBOL(il_bcast_addr) and use ether_broadcast_addr iwlwifi: Remove local iwl_bcast_addr and use ether_broadcast_addr mvpp2: Use ether_broadcast_addr instead of a local array qlogic: Convert local bcast_addr to global ether_broadcast_addr ethernet: Use ether_zero_addr instead of local statics drivers/net/dsa/lan9303-core.c| 4 ++-- drivers/net/ethernet/broadcom/b44.c | 5 ++--- drivers/net/ethernet/freescale/gianfar.c | 3 +-- drivers/net/ethernet/marvell/mvpp2.c | 4 +--- drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c| 5 + drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c| 6 ++ .../net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c | 6 ++ drivers/net/wireless/admtek/adm8211.c | 3 +-- drivers/net/wireless/ath/carl9170/mac.c | 4 +--- drivers/net/wireless/broadcom/b43/main.c | 3 +-- .../net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 -- .../net/wireless/broadcom/brcm80211/brcmfmac/common.h | 2 -- .../wireless/broadcom/brcm80211/brcmfmac/flowring.c | 8 drivers/net/wireless/intel/iwlegacy/3945-mac.c| 2 +- drivers/net/wireless/intel/iwlegacy/4965-mac.c| 2 +- drivers/net/wireless/intel/iwlegacy/common.c | 3 --- drivers/net/wireless/intel/iwlegacy/common.h | 1 - drivers/net/wireless/intel/iwlwifi/dvm/dev.h | 1 - drivers/net/wireless/intel/iwlwifi/dvm/scan.c | 2 +- drivers/net/wireless/intel/iwlwifi/dvm/sta.c | 4 +--- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 3 +-- drivers/net/wireless/realtek/rtlwifi/core.c | 5 ++--- drivers/net/wireless/rndis_wlan.c | 6 +- drivers/net/wireless/ti/wl1251/main.c | 5 + drivers/net/wireless/ti/wlcore/main.c | 5 + include/linux/etherdevice.h | 13 + net/atm/lec.c | 12 +--- net/bridge/br_device.c| 4 ++-- net/bridge/netfilter/ebt_stp.c| 6 ++ net/ethernet/Makefile | 2 +- net/ethernet/ether_addrs.c| 19 +++ net/mac80211/iface.c | 5 + net/mac80211/key.c| 6 ++ net/mac80211/mesh_hwmp.c | 19 ++- net/mac80211/mesh_pathtbl.c | 8 35 files changed, 83 insertions(+), 105 deletions(-) create mode 100644 net/ethernet/ether_addrs.c -- 2.15.0
