Re: [MM PATCH] novatel-lte: increase the wait after SIM unlock to 3 seconds
On 01/11/12 05:31, Ben Chan wrote: After repeated stress tests on a few Novatel E362 modems and SIM cards, it is revealed that a 3-second wait after SIM unlock is necessary for reliably reading ICCID and IMSI through the SIM interface. Pushed, thanks. BTW, Novatel LTE modems can now be handled by QMI as well, but I guess we can keep the AT-based novatel-lte plugin around as long as we allow `--without-qmi' in configure. --- plugins/novatel/mm-broadband-modem-novatel-lte.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/novatel/mm-broadband-modem-novatel-lte.c b/plugins/novatel/mm-broadband-modem-novatel-lte.c index da855fc..6f2e7e2 100644 --- a/plugins/novatel/mm-broadband-modem-novatel-lte.c +++ b/plugins/novatel/mm-broadband-modem-novatel-lte.c @@ -152,9 +152,9 @@ modem_after_sim_unlock (MMIfaceModem *self, user_data, modem_after_sim_unlock); -/* A 2-second wait is necessary for SIM to become ready. +/* A 3-second wait is necessary for SIM to become ready. * Otherwise, a subsequent AT+CRSM command will likely fail. */ -g_timeout_add_seconds (2, (GSourceFunc)after_sim_unlock_wait_cb, result); +g_timeout_add_seconds (3, (GSourceFunc)after_sim_unlock_wait_cb, result); } /*/ -- Aleksander ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [MM] CDMA base station location
I pushed a new 'cdma-location' branch to upstream MM git, which includes a new 'CDMA Base Station' location source which may give, if known, the Latitude and Longitude of the CDMA Base Station. This CDMA location is enabled by default when the CDMA modem is enabled. Once registered to the network, you can get the exposed location info using `mmcli': $ sudo mmcli -m 0 --get-location-cdma-bs NOTE: Currently, this is only implemented for QMI-based modems. It's completely untested, so it would be great if anyone could give it a try with a real CDMA network... anyone? Merged after Dan's tests. Cheers! -- Aleksander ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [MM PATCH] iface-modem: load own numbers after SIM initialization
On 01/11/12 05:23, Ben Chan wrote:
In 3GPP, own numbers are loaded from the SIM card, the loading of own
numbers should be scheduled after the SIM card is ready.
Pushed, thanks.
---
src/mm-iface-modem.c | 34 +-
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c
index 082846e..d25b03d 100644
--- a/src/mm-iface-modem.c
+++ b/src/mm-iface-modem.c
@@ -3128,10 +3128,10 @@ typedef enum {
INITIALIZATION_STEP_REVISION,
INITIALIZATION_STEP_EQUIPMENT_ID,
INITIALIZATION_STEP_DEVICE_ID,
-INITIALIZATION_STEP_OWN_NUMBERS,
INITIALIZATION_STEP_UNLOCK_REQUIRED,
INITIALIZATION_STEP_UNLOCK_RETRIES,
INITIALIZATION_STEP_SIM,
+INITIALIZATION_STEP_OWN_NUMBERS,
INITIALIZATION_STEP_SUPPORTED_MODES,
INITIALIZATION_STEP_SUPPORTED_BANDS,
INITIALIZATION_STEP_LAST
@@ -3649,22 +3649,6 @@ interface_initialization_step (InitializationContext
*ctx)
/* Fall down to next step */
ctx-step++;
-case INITIALIZATION_STEP_OWN_NUMBERS:
-/* Own numbers is meant to be loaded only once during the whole
- * lifetime of the modem. Therefore, if we already have them loaded,
- * don't try to load them again. */
-if (mm_gdbus_modem_get_own_numbers (ctx-skeleton) == NULL
-MM_IFACE_MODEM_GET_INTERFACE (ctx-self)-load_own_numbers
-MM_IFACE_MODEM_GET_INTERFACE
(ctx-self)-load_own_numbers_finish) {
-MM_IFACE_MODEM_GET_INTERFACE (ctx-self)-load_own_numbers (
-ctx-self,
-(GAsyncReadyCallback)load_own_numbers_ready,
-ctx);
-return;
-}
-/* Fall down to next step */
-ctx-step++;
-
case INITIALIZATION_STEP_UNLOCK_REQUIRED:
/* Only check unlock required if we were previously not unlocked */
if (mm_gdbus_modem_get_unlock_required (ctx-skeleton) !=
MM_MODEM_LOCK_NONE) {
@@ -3710,6 +3694,22 @@ interface_initialization_step (InitializationContext
*ctx)
return;
}
+case INITIALIZATION_STEP_OWN_NUMBERS:
+/* Own numbers is meant to be loaded only once during the whole
+ * lifetime of the modem. Therefore, if we already have them loaded,
+ * don't try to load them again. */
+if (mm_gdbus_modem_get_own_numbers (ctx-skeleton) == NULL
+MM_IFACE_MODEM_GET_INTERFACE (ctx-self)-load_own_numbers
+MM_IFACE_MODEM_GET_INTERFACE
(ctx-self)-load_own_numbers_finish) {
+MM_IFACE_MODEM_GET_INTERFACE (ctx-self)-load_own_numbers (
+ctx-self,
+(GAsyncReadyCallback)load_own_numbers_ready,
+ctx);
+return;
+}
+/* Fall down to next step */
+ctx-step++;
+
case INITIALIZATION_STEP_SUPPORTED_MODES:
g_assert (MM_IFACE_MODEM_GET_INTERFACE
(ctx-self)-load_supported_modes != NULL);
g_assert (MM_IFACE_MODEM_GET_INTERFACE
(ctx-self)-load_supported_modes_finish != NULL);
--
Aleksander
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: Initial integration of the new MM iface in NM
On 01/11/12 16:53, Aleksander Morgado wrote: The 'cs' mode (circuit switched) was carried from some plugins which allow configuring this kind of connection; instead of assuming 'cs' is suported when '2g' is supported, I'll remove the 'cs' mode from all those modems which don't really allow specifying it. It's actually something I meant to do this week. Done in git master now. Left CS mode reporting for the 'wavecom' and 'iridium' plugins. -- Aleksander ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] fix build: disable -Werror by default (Bug #679130)
On Thu, Nov 01, 2012 at 07:32:14PM -0400, Pavel Simerda wrote: What is it supposed to fix? This patch is for network-manager-pptp (should have mentioned that). It does not build against current GTK: $ ./configure make [...] gcc -Wall -Werror [...] vpn-password-dialog.c vpn-password-dialog.c: In function ‘add_row’: vpn-password-dialog.c:127:2: error: ‘gtk_table_attach_defaults’ is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtktable.h:120): Use 'GtkGrid' instead [-Werror=deprecated-declarations] The autoconf script enables -Werror by default. The original bug report https://bugzilla.gnome.org/show_bug.cgi?id=679130 is dated 2012-06-29. So this has been an issue for a while, and the -Werror flag does not help anything besides breaking the build. I therefore suggest that -Werror be disabled by default. It can be re-enabled on the command line by running ./configure --enable-more-warnings=error. Eventually, the deprecations should be fixed as well. But I do not see a point in disabling a software that is working just fine. Regards, Clemens --- Additional info: networkmanager-pptp 0.9.6.0-1 gtk3 3.6.1-1 gcc 4.7.2-2 ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] fix path to auth-dialog (Bug #679225)
On Thu, Nov 01, 2012 at 06:59:13PM +0100, Clemens Buchacher wrote: nm-pptp-service.name.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This patch is for network-manager-pptp. If accepted I can provide analogous patches for network-manager-vpnc and network-manager-openconnect. ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] fix build: disable -Werror by default (Bug #679130)
On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: So this has been an issue for a while, and the -Werror flag does not help anything besides breaking the build. You're going to have to learn how to pass options to configure if you're building software in general. It's really the maintainer's discretion what the defaults are. However, I just landed https://bugzilla.gnome.org/show_bug.cgi?id=687385 for GLib, and will shortly be attempting to do it in more of GNOME. I think it gives you a practical middle ground between -Werror and nothing. Were NM to consider changes here, it's worth a look. ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] fix build: disable -Werror by default (Bug #679130)
On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote: On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: So this has been an issue for a while, and the -Werror flag does not help anything besides breaking the build. You're going to have to learn how to pass options to configure if you're building software in general. It's really the maintainer's discretion what the defaults are. It is not the purpose of configure to work around platform-independent build failures. ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] fix build: disable -Werror by default (Bug #679130)
On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote: On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: So this has been an issue for a while, and the -Werror flag does not help anything besides breaking the build. You're going to have to learn how to pass options to configure if you're building software in general. It's really the maintainer's discretion what the defaults are. It is not the purpose of configure to work around platform-independent build failures. And? ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] fix build: disable -Werror by default (Bug #679130)
On Fri, Nov 02, 2012 at 10:32:25AM -0400, Pavel Simerda wrote: On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote: On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: So this has been an issue for a while, and the -Werror flag does not help anything besides breaking the build. You're going to have to learn how to pass options to configure if you're building software in general. It's really the maintainer's discretion what the defaults are. It is not the purpose of configure to work around platform-independent build failures. And? And it is therefore not a solution to do nothing and force the package maintainers to deal with this issue. ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] fix build: disable -Werror by default (Bug #679130)
And it is therefore not a solution to do nothing and force the package maintainers to deal with this issue. I still prefer a proper solution like the one from Dan Winship: https://bugzilla.gnome.org/show_bug.cgi?id=679130 ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] fix build: disable -Werror by default (Bug #679130)
On Fri, Nov 02, 2012 at 11:36:46AM -0400, Pavel Simerda wrote: And it is therefore not a solution to do nothing and force the package maintainers to deal with this issue. I still prefer a proper solution like the one from Dan Winship: https://bugzilla.gnome.org/show_bug.cgi?id=679130 Sure. No reason to be so curt about it. ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] fix build: disable -Werror by default (Bug #679130)
On Fri, Nov 2, 2012 at 3:43 PM, Clemens Buchacher dri...@aon.at wrote: On Fri, Nov 02, 2012 at 10:32:25AM -0400, Pavel Simerda wrote: On Fri, Nov 02, 2012 at 09:16:29AM -0400, Colin Walters wrote: On Fri, 2012-11-02 at 11:59 +0100, Clemens Buchacher wrote: So this has been an issue for a while, and the -Werror flag does not help anything besides breaking the build. You're going to have to learn how to pass options to configure if you're building software in general. It's really the maintainer's discretion what the defaults are. It is not the purpose of configure to work around platform-independent build failures. And? And it is therefore not a solution to do nothing and force the package maintainers to deal with this issue. This wasn't handled very nicely, there is that, but there is an actual point in making warnings errors and forcing anybody compiling to willingly change configure settings to avoid the build failure: we don't forget that there is work that needs to be done. I actually did the porting in Ubuntu. The patch probably doesn't apply quite as cleanly on git master; but see the attached file which migrates the calls to gtk_table_* to gtk_grid_*. Regards, Mathieu Trudel-Lapierre mathieu...@gmail.com Freenode: cyphermox, Jabber: mathieu...@gmail.com 4096R/EE018C93 1967 8F7D 03A1 8F38 732E FF82 C126 33E1 EE01 8C93 gtk_table_to_gtk_grid.patch Description: Binary data ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
