Re: [PATCH] nmcli: Made nmcli build optional

[Thomas Haller]

On Thu, 2015-11-19 at 00:02 +, Joel Holdsworth wrote:
> ---
>  clients/cli/Makefile.am |  4 
>  configure.ac| 13 ++---
>  2 files changed, 14 insertions(+), 3 deletions(-)
> 

merged to master as
http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=8051038b4d9b96788d9989127e00ead9e1524057

[I only reworded the commit-message]


Thank you for the patch!!
Thomas

signature.asc
Description: This is a digitally signed message part
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list

Re: [PATCH] nmcli: Made nmcli build optional

[Dan Williams]

On Fri, 2015-11-13 at 19:35 +, Joel Holdsworth wrote:
> Hi, here's a patch to make the nmcli build optional. In my use-case I
> need to cross-build NetworkManager, and I don't want to have to 
> cross-build GNU readline for a binary I don't need.

Thanks for the patch!  Would you mind making two quick fixes to it?

1) first, the patch will actually break the case where --with-nmcli is
not specified on the command-line, because build_nmcli doesn't get set
to 'yes' if not specified.  You could simply add:

 if test "$with_nmcli" != no; then
 AX_LIB_READLINE
+build_nmcli=yes
 else

2) We should put some log info near the bottom whether nmcli is enabled
or not, like is done for nmcli.  That would be something like:

 echo "  libnm-glib: $with_libnm_glib"
+echo "  nmcli: $build_nmcli"
 echo "  nmtui: $build_nmtui"
 echo

Any chance you could make those changes and resubmit?

Thanks!
Dan
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list

Re: [PATCH] nmcli: Made nmcli build optional

[Joel Holdsworth]

Sure. I'll do it tomorrow.
Thanks
Joel
On 15 Nov 2015 09:54, "Dan Williams"  wrote:

> On Fri, 2015-11-13 at 19:35 +, Joel Holdsworth wrote:
> > Hi, here's a patch to make the nmcli build optional. In my use-case I
> > need to cross-build NetworkManager, and I don't want to have to
> > cross-build GNU readline for a binary I don't need.
>
> Thanks for the patch!  Would you mind making two quick fixes to it?
>
> 1) first, the patch will actually break the case where --with-nmcli is
> not specified on the command-line, because build_nmcli doesn't get set
> to 'yes' if not specified.  You could simply add:
>
>  if test "$with_nmcli" != no; then
>  AX_LIB_READLINE
> +build_nmcli=yes
>  else
>
> 2) We should put some log info near the bottom whether nmcli is enabled
> or not, like is done for nmcli.  That would be something like:
>
>  echo "  libnm-glib: $with_libnm_glib"
> +echo "  nmcli: $build_nmcli"
>  echo "  nmtui: $build_nmtui"
>  echo
>
> Any chance you could make those changes and resubmit?
>
> Thanks!
> Dan
>
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list