Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: CLNT_CALL with clnt_req

2017-11-03 Thread Matt Benjamin
oh, come on.  not sure what needs to be done to reduce log noise, but
I'm sure we can make a dent.

Matt

On Sat, Nov 4, 2017 at 1:38 AM, William Allen Simpson
 wrote:
> We already discussed this on Tuesday, October 24th.  Malahal agreed
> that a half second was good, 3 seconds was OK, 5 seconds was long.
> And Matt agreed we'd log more than 10 seconds.
>
> Obviously, you have vastly more Internet experience than I, and
> therefore are much better able to decide Internet timing parameters.
>
> Also, your time is so much more valuable than mine, and you need to
> post the weekly maintenance updates late (eastern time) on Friday to
> avoid disrupting your thought processes -- so that I have to work
> weekends, and my commits are stalled by yet another week.
>
> 
>
> Note that I'm currently taking a lot of half-week holiday over the
> next few months, so hopefully this will make it in *early* next week.
> Then maybe, just maybe, my next patch will be ready the week before
> Thanksgiving
>
> On 11/3/17 2:04 PM, GerritHub wrote:
>>
>> Frank Filz *posted comments* on this change.
>>
>> View Change 
>>
>> Patch set 1:
>>
>> I'd like a review by malahal before merging this one
>>
>> I'm really not sure about the 3 second timeouts
>>
>> Can anyone test this in something resembling a real customer environment?
>>
>> To view, visit change 385451 . To
>> unsubscribe, visit settings .
>>
>> Gerrit-Project: ffilz/nfs-ganesha
>> Gerrit-Branch: next
>> Gerrit-MessageType: comment
>> Gerrit-Change-Id: I92b02eca435f4b1f6104b740c6c5b3747c380840
>> Gerrit-Change-Number: 385451
>> Gerrit-PatchSet: 1
>> Gerrit-Owner: william.allen.simp...@gmail.com
>> Gerrit-Reviewer: CEA-HPC 
>> Gerrit-Reviewer: Daniel Gryniewicz 
>> Gerrit-Reviewer: Frank Filz 
>> Gerrit-Reviewer: Gluster Community Jenkins 
>> Gerrit-Reviewer: Malahal 
>> Gerrit-Reviewer: openstack-ci-service+rdo-ci-cen...@redhat.com
>> Gerrit-Comment-Date: Fri, 03 Nov 2017 18:04:27 +
>> Gerrit-HasComments: No
>
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel



-- 

Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103

http://www.redhat.com/en/technologies/storage

tel.  734-821-5101
fax.  734-769-8938
cel.  734-216-5309

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: CLNT_CALL with clnt_req

2017-11-03 Thread William Allen Simpson

We already discussed this on Tuesday, October 24th.  Malahal agreed
that a half second was good, 3 seconds was OK, 5 seconds was long.
And Matt agreed we'd log more than 10 seconds.

Obviously, you have vastly more Internet experience than I, and
therefore are much better able to decide Internet timing parameters.

Also, your time is so much more valuable than mine, and you need to
post the weekly maintenance updates late (eastern time) on Friday to
avoid disrupting your thought processes -- so that I have to work
weekends, and my commits are stalled by yet another week.



Note that I'm currently taking a lot of half-week holiday over the
next few months, so hopefully this will make it in *early* next week.
Then maybe, just maybe, my next patch will be ready the week before
Thanksgiving

On 11/3/17 2:04 PM, GerritHub wrote:

Frank Filz *posted comments* on this change.

View Change 

Patch set 1:

I'd like a review by malahal before merging this one

I'm really not sure about the 3 second timeouts

Can anyone test this in something resembling a real customer environment?

To view, visit change 385451 . To unsubscribe, 
visit settings .

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: comment
Gerrit-Change-Id: I92b02eca435f4b1f6104b740c6c5b3747c380840
Gerrit-Change-Number: 385451
Gerrit-PatchSet: 1
Gerrit-Owner: william.allen.simp...@gmail.com
Gerrit-Reviewer: CEA-HPC 
Gerrit-Reviewer: Daniel Gryniewicz 
Gerrit-Reviewer: Frank Filz 
Gerrit-Reviewer: Gluster Community Jenkins 
Gerrit-Reviewer: Malahal 
Gerrit-Reviewer: openstack-ci-service+rdo-ci-cen...@redhat.com
Gerrit-Comment-Date: Fri, 03 Nov 2017 18:04:27 +
Gerrit-HasComments: No



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: CLNT_CALL with clnt_req

2017-11-03 Thread William Allen Simpson

On 11/3/17 2:06 PM, Frank Filz wrote:

Please respond inside gerrit to keep the conversation in one place.


The discussion of timeouts was always in public on this list, and
was also on the public conference call a week ago.

If Gerrit doesn't record its replies, unlike Github, you should
probably make a request to the maintainers of Gerrit.

But I'm not likely to log into Github to log into Gerrit to make an
email reply that then isn't recorded in my actual email on my machine.

I prefer to keep my conversations in one place.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


Re: [Nfs-ganesha-devel] tirpc warning

2017-11-03 Thread William Allen Simpson

On 11/3/17 7:46 PM, Frank Filz wrote:

Can we tone down this warning:

2017-11-03 16:14:21 [svc_4] :0 :rpc :TIRPC :INFO
:clnt_req_alloc:470 tv_sec 15 > 10

That is spamming the log when at INFO level.


I see that you didn't put in CLNT_CALL with clnt_req, that
eliminated all current examples of the warning.

So no, that's on you

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


[Nfs-ganesha-devel] Announce Push of V2.6-dev.16

2017-11-03 Thread Frank Filz
Branch next

Tag:V2.6-dev.16

Release Highlights

* GLUSTER: Fix upcalls and a memory leak

* MDCACHE: Make sure we don't do cleanup while holding state_lock in
open4_ex

* MDCACHE: Fix attempt to acquire content_lock twice

* Fix updating mtime/atime with nano seconds.

Signed-off-by: Frank S. Filz 

Contents:

1feb192 Frank S. Filz V2.6-dev.16
c4f71be Malahal Naineni Fix updating mtime/atime with nano seconds.
e0235c5 Malahal Naineni Fix attempt to acquire content_lock twice
ac7d434 Soumya Koduri FSAL_GLUSTER: A new option to enable/disable upcalls
bad9a1f Soumya Koduri FSAL_GLUSTER: Fix memory leak while reading dirents
0d67a0b Soumya Koduri FSAL_GLUSTER: Use the APIs to register for upcall
events' callback
d535ecf Frank S. Filz Make sure we don't do cleanup while holding state_lock
in open4_ex


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


[Nfs-ganesha-devel] tirpc warning

2017-11-03 Thread Frank Filz
Bill,

Can we tone down this warning:

2017-11-03 16:14:21 [svc_4] :0 :rpc :TIRPC :INFO
:clnt_req_alloc:470 tv_sec 15 > 10

That is spamming the log when at INFO level.

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: CLNT_CALL with clnt_req

2017-11-03 Thread William Allen Simpson

On 11/2/17 1:01 PM, GerritHub wrote:

Frank Filz *posted comments* on this change.

View Change 

Patch set 1:

(2 comments)

  *

File src/MainNFSD/nfs_rpc_callback.c: 


  o

Patch Set #1, Line 74: 
 
|/* retry timeout default to the moon and back */|

don't these go back to actual clients?

  *

File src/Protocols/NLM/sm_notify.c: 


  o

Patch Set #1, Line 20: |/* retry timeout default to the moon and back 
*/|

This is going to an actual client, shouldn't we have a longer timeout?


If anything, it's too large.  Do we have any clients on the moon?

It takes approximately 1.26 seconds for light to travel to the moon,
so 2.52 seconds RTT.  Leaves 480 ms of terrestrial latency, enough to
circle the earth a few times

AWS Network Latency Map reports 282 ms between data centers in
Virginia and Central Asia.  That's worst case.

Also, 3 seconds will easily handle 1500 byte packets over 300 bps
satellite link to any ship anywhere in the world.  I'm pretty sure
most links are faster than that nowadays

If you have worse links, fix your network.  NFS isn't going to work
well over such links anyway.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel