Re: [Nix-dev] reviewboard
Hi, Florian Friesdorf f...@chaoflow.net skribis: On Sun, 18 Mar 2012 22:07:44 +0100, l...@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) wrote: (..) There’s a Debbugs mode in Emacs that really rocks, because it’s specifically tailored for the job, has a convenient UI, and is well integrated with Gnus. in which role do you see debbugs in a scenario where all nix code is on github? What does the fact that the Nix repo is on GitHub change? In any case I'm interested in getting issues in an offline format - be they from github or debbugs. Aah, then Debbugs won’t really help with this. OTOH, if your email client has an offline mode, then you’re essentially done. Thanks, Ludo’. ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
#secure method=pgpmime mode=sign Hi Ludo’ On Sun, 18 Mar 2012 22:07:44 +0100, l...@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) wrote: (..) There’s a Debbugs mode in Emacs that really rocks, because it’s specifically tailored for the job, has a convenient UI, and is well integrated with Gnus. in which role do you see debbugs in a scenario where all nix code is on github? In any case I'm interested in getting issues in an offline format - be they from github or debbugs. regards florian -- Florian Friesdorf f...@chaoflow.net GPG FPR: 7A13 5EEE 1421 9FC2 108D BAAF 38F8 99A3 0C45 F083 Jabber/XMPP: f...@chaoflow.net IRC: chaoflow on freenode,ircnet,blafasel,OFTC ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
#secure method=pgpmime mode=sign On Sun, 18 Mar 2012 11:55:44 -0700, Corey O'Connor coreyocon...@gmail.com wrote: Now, a web tool is likely to be too tedious for me to use, and I expect other hackers may not like having to jump to a browser to get the work done. :-) xmonad + vimium is my recommendation ;-) Though if you are an emacs guy I really don't know if vimium will suite you. Not sure if there is a emacs-like web interfaces aside from using a web browser from within emacs. There is conkeror - but for me that's not the point: It is the need for being online, that I don't like. Looking forward to a finished git migration. -- Florian Friesdorf f...@chaoflow.net GPG FPR: 7A13 5EEE 1421 9FC2 108D BAAF 38F8 99A3 0C45 F083 Jabber/XMPP: f...@chaoflow.net IRC: chaoflow on freenode,ircnet,blafasel,OFTC ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
Hi, Yury G. Kudryashov urkud.ur...@gmail.com skribis: http://reviewboard.org FWIW, a “web-based code review tool” is never going to be powerful for me: using a web server puts me on the slow path. I would recommend keeping using email for that. In addition, Debbugs could be used to keep track of bugs and patches. It has an email interface, a web interface, and an Emacs interface, which makes it really convenient. Would it be possible to set it up at nixos.org? Thanks, Ludo’. ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
2012/3/18 Ludovic Courtès l...@gnu.org: Hi, Yury G. Kudryashov urkud.ur...@gmail.com skribis: http://reviewboard.org FWIW, a “web-based code review tool” is never going to be powerful for me: using a web server puts me on the slow path. I would recommend keeping using email for that. In addition, Debbugs could be used to keep track of bugs and patches. It has an email interface, a web interface, and an Emacs interface, which makes it really convenient. Patches submitted by email to the list get lost. Which is why I'm pushing for something, anything really, that assures submitted patches do not disappear. Relying only on submission to an email list has never proved effective for me. How a patch appears to get lost: The patch is submitted; No comments occur; The email containing the patch is pushed down by newer emails; Nobody bothers to check for patches in old emails. IMO, use of git avoids some problems just by being distributed. The patches can be recorded to many repositories even if the submitting user does not have access to the master repository. -Corey O'Connor coreyocon...@gmail.com http://corebotllc.com/ ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
Hi, On 18/03/12 18:01, Corey O'Connor wrote: IMO, use of git avoids some problems just by being distributed. The patches can be recorded to many repositories even if the submitting user does not have access to the master repository. And GitHub has pull requests and allows commenting on commits, which may remove the need for reviewboard. -- Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/ ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
Hi, Corey O'Connor coreyocon...@gmail.com skribis: Patches submitted by email to the list get lost. Yes, I understand the problem, and I agree it’s important to fix it. Now, a web tool is likely to be too tedious for me to use, and I expect other hackers may not like having to jump to a browser to get the work done. :-) So I think Debbugs is more likely to be suitable to various sorts of contributors, because it has several interfaces, not just the web one. [...] IMO, use of git avoids some problems just by being distributed. The patches can be recorded to many repositories even if the submitting user does not have access to the master repository. Agreed. Thanks, Ludo’. ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
2012/3/18 Ludovic Courtès l...@gnu.org: Yes, I understand the problem, and I agree it’s important to fix it. Excellent! So long everybody agrees there is a problem then it is only a matter of time before we find a solution. ;-) Now, a web tool is likely to be too tedious for me to use, and I expect other hackers may not like having to jump to a browser to get the work done. :-) xmonad + vimium is my recommendation ;-) Though if you are an emacs guy I really don't know if vimium will suite you. Not sure if there is a emacs-like web interfaces aside from using a web browser from within emacs. So I think Debbugs is more likely to be suitable to various sorts of contributors, because it has several interfaces, not just the web one. I'm trying to find a web page describing the features and requirements of debbugs. Is just the source the best place to look? Reviewboard does have a nice and complete REST API: * http://www.reviewboard.org/docs/manual/dev/webapi/ While it may not already have an emacs interface I bet one could be constructed without trouble. * http://savannah.nongnu.org/projects/http-emacs/ Which is an interesting project idea actually.. Hm. Maybe I'll try this as a way to learn elisp ;-) -Corey O'Connor coreyocon...@gmail.com http://corebotllc.com/ ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
Hi! Corey O'Connor coreyocon...@gmail.com skribis: 2012/3/18 Ludovic Courtès l...@gnu.org: [...] Now, a web tool is likely to be too tedious for me to use, and I expect other hackers may not like having to jump to a browser to get the work done. :-) xmonad + vimium is my recommendation ;-) Though if you are an emacs guy I really don't know if vimium will suite you. Not sure if there is a emacs-like web interfaces aside from using a web browser from within emacs. There’s Emacs-W3M, but it would be suboptimal. There’s a Debbugs mode in Emacs that really rocks, because it’s specifically tailored for the job, has a convenient UI, and is well integrated with Gnus. So I think Debbugs is more likely to be suitable to various sorts of contributors, because it has several interfaces, not just the web one. I'm trying to find a web page describing the features and requirements of debbugs. Is just the source the best place to look? You could look at http://debbugs.gnu.org/Advanced.html, for instance. Reviewboard does have a nice and complete REST API: * http://www.reviewboard.org/docs/manual/dev/webapi/ While it may not already have an emacs interface I bet one could be constructed without trouble. * http://savannah.nongnu.org/projects/http-emacs/ Which is an interesting project idea actually.. Hm. Maybe I'll try this as a way to learn elisp ;-) Interesting project, yes, though that may slightly delay the switch to the tracker. :-) Thanks, Ludo’. ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
Marc Weber wrote: This would - shut up all people (like me :) asking for git all the time - stop people announcing yet another git mirror of nixos/nixpkgs - allow code sharing on github This won't shut up me disliking non-opensource github hosting. What features do you miss in, e.g., gitorious? github provides review boards for free and almost all people have github accounts anyway. In reviewboard I can send a review request to a particular person, not to repository. Is it possible in github? -- Yury G. Kudryashov, mailto: ur...@mccme.ru ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
In reviewboard I can send a review request to a particular person, not to repository. Is it possible in github? Probably no. It looks like comments are sent to all members as email. But I'm not an expert. github has the network tab view which gitorious doesn't have, does it ? github just came to my mind because its used widely, it always worked for me and I like the flat /NAME/REPO naming of repositories. But what is it what I really want? An easy way to share some of my patches. Marc Weber ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard ship it
On Sat, Mar 17, 2012 at 8:00 PM, Shea Levy s...@shealevy.com wrote: On 3/17/12 10:37 PM, Corey O'Connor wrote: Thanks for the info! What happens when we hit Ship It? It adds a review that basically means I don't mind if you commit this. In a 'no-reply-is-no-ok' project like NixOS this kind of feedback is necessary. What happens in terms of process? Who then commits the patches? Are they notified by email or ...? Cheers, Corey ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard ship it
Corey O'Connor wrote: On Sat, Mar 17, 2012 at 8:00 PM, Shea Levy s...@shealevy.com wrote: On 3/17/12 10:37 PM, Corey O'Connor wrote: Thanks for the info! What happens when we hit Ship It? It adds a review that basically means I don't mind if you commit this. In a 'no-reply-is-no-ok' project like NixOS this kind of feedback is necessary. What happens in terms of process? Nothing. Just anybody can see that more than 1 person thinks that this code can be committed. Who then commits the patches? Normally, the one who submitted the patch. If he has no commit access, he can add commit, please comment. Are they notified by email or ...? It seems that this type of notification e-mails was turned off. I've turned it on a minute ago. -- Yury G. Kudryashov, mailto: ur...@mccme.ru ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
Hi, Yury G. Kudryashov urkud.ur...@gmail.com skribis: I've set up a reviewboard at http://reviewboard.loegria.net/ What is it, and what would it be used for? Ludo’. ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
Ludovic Courtès wrote: Hi, Yury G. Kudryashov urkud.ur...@gmail.com skribis: I've set up a reviewboard at http://reviewboard.loegria.net/ What is it, http://reviewboard.org and what would it be used for? Not loosing incoming patches while we're using svn for nixos and nixpkgs. -- Yury G. Kudryashov, mailto: ur...@mccme.ru ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
Cillian de Róiste wrote: Hi, It looks very useful. I just thought I'd mention that I was confused by the form question: Base Directory: The absolute path in the repository the diff was generated in. It is happy with /nixpkgs/trunk for relative patches created in /etc/nixos/nixpkgs I use post-review from pythonPackages.RBTools. -- Yury G. Kudryashov, mailto: ur...@mccme.ru ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
Corey O'Connor wrote: Thanks! Is reviewboard set up to email the list when a patch is posted for review? I think that would be great. No, I made no setup yet. Only registered nix svn repo. Actually, I'm not sure if mailing works at all. It tries to use localhost:25, and I have no idea if it works on dreamhost. -- Yury G. Kudryashov, mailto: ur...@mccme.ru ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] reviewboard
Corey O'Connor wrote: Thanks! Is reviewboard set up to email the list when a patch is posted for review? This will work if someone will add nore...@reviewboard.loegria.net to whitelist. Eelco? I think that would be great. -- Yury G. Kudryashov, mailto: ur...@mccme.ru ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
