[GitHub] [apisix-website] juzhiyuan edited a comment on issue #220: improve Subscribe Mailing-list more clear
juzhiyuan edited a comment on issue #220: URL: https://github.com/apache/apisix-website/issues/220#issuecomment-788694585 How about this workflow? 1. add Subscribe input box; 2. Once users enter their email, our systems (maybe `[Mailchimp](https://mailchimp.com/)`) will send an email about how to subscribe Maling list. cc @moonming @qier222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan edited a comment on issue #220: improve Subscribe Mailing-list more clear
juzhiyuan edited a comment on issue #220: URL: https://github.com/apache/apisix-website/issues/220#issuecomment-788694585 How about this workflow? 1. add Subscribe input box; 2. Once users enter their email, our systems (maybe `mailchimp`) will send an email about how to subscribe Maling list. cc @moonming This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] rockXiaofeng commented on issue #3725: request help: about dubbo proxy
rockXiaofeng commented on issue #3725: URL: https://github.com/apache/apisix/issues/3725#issuecomment-788697180 Why does dubbo proxy do not need to configure the registry to obtain provider metadata information? I am puzzled about the processing of parameter mapping. Can you answer the principle? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] LiteSun commented on a change in pull request #227: docs: added blog `Get Front-End Test Coverage with Cypress`
LiteSun commented on a change in pull request #227: URL: https://github.com/apache/apisix-website/pull/227#discussion_r585328360 ## File path: website/blog/2021-03-02-get-front-end-test-coverage-with-cypress.md ## @@ -0,0 +1,84 @@ +--- +title: "Get Front-End Test Coverage with Cypress" +author: Yi Sun +authorURL: "https://github.com/LiteSun; +authorImageURL: "https://avatars.githubusercontent.com/u/31329157?s=400=e81b4bb4db2be162c1fcac6d188f5b0f82f71920=4; +--- + +> [@LiteSun](https://github.com/LiteSun), Apache APISIX Committer from [Shenzhen Zhiliu Technology Co.](https://www.apiseven.com/) +> +> Source: +> +> - https://github.com/apache/apisix +> - https://github.com/apache/apisix-dashboard + +## Background + +In the article ["Stable Product Delivery with Cypress"](/blog/2021/02/08/stable-product-delivery-with-cypress), we discussed why we chose Cypress as our E2E testing framework. After spending nearly two months refining the test cases, we needed test coverage to quantify whether the test coverage was sufficient. This article will describe how to use Cypress to get E2E coverage on the front end of APISIX Dashboard. + +## What is code coverage? + +Code coverage is a metric in software testing that describes the proportion and extent to which the source code in a program is tested, and the resulting proportion is called code coverage. Test code coverage reflects the health of the code to a certain extent. + +## Installation Dependencies & Configuration + +To collect test coverage data, we need to put some probes in the original business code for Cypress to collect the data. + +Cypress officially recommends two approaches, the first is to generate a temporary directory via `nyc` and run the code that has been written to the probe to collect test coverage data. The second way is to do the code conversion in real time through the code conversion pipeline, which eliminates the hassle of temporary folders and makes collecting test coverage data relatively refreshing. We choose the second way to collect front-end E2E coverage. + +1. Installing Dependencies + +yarn add babel-plugin-istanbul --dev Review comment: ```suggestion ``` yarn add babel-plugin-istanbul --dev ``` ``` ## File path: website/blog/2021-03-02-get-front-end-test-coverage-with-cypress.md ## @@ -0,0 +1,84 @@ +--- +title: "Get Front-End Test Coverage with Cypress" +author: Yi Sun +authorURL: "https://github.com/LiteSun; +authorImageURL: "https://avatars.githubusercontent.com/u/31329157?s=400=e81b4bb4db2be162c1fcac6d188f5b0f82f71920=4; +--- + +> [@LiteSun](https://github.com/LiteSun), Apache APISIX Committer from [Shenzhen Zhiliu Technology Co.](https://www.apiseven.com/) +> +> Source: +> +> - https://github.com/apache/apisix +> - https://github.com/apache/apisix-dashboard + +## Background + +In the article ["Stable Product Delivery with Cypress"](/blog/2021/02/08/stable-product-delivery-with-cypress), we discussed why we chose Cypress as our E2E testing framework. After spending nearly two months refining the test cases, we needed test coverage to quantify whether the test coverage was sufficient. This article will describe how to use Cypress to get E2E coverage on the front end of APISIX Dashboard. + +## What is code coverage? + +Code coverage is a metric in software testing that describes the proportion and extent to which the source code in a program is tested, and the resulting proportion is called code coverage. Test code coverage reflects the health of the code to a certain extent. + +## Installation Dependencies & Configuration + +To collect test coverage data, we need to put some probes in the original business code for Cypress to collect the data. + +Cypress officially recommends two approaches, the first is to generate a temporary directory via `nyc` and run the code that has been written to the probe to collect test coverage data. The second way is to do the code conversion in real time through the code conversion pipeline, which eliminates the hassle of temporary folders and makes collecting test coverage data relatively refreshing. We choose the second way to collect front-end E2E coverage. + +1. Installing Dependencies + +yarn add babel-plugin-istanbul --dev + +2. Install the cypress plug-in + +yarn add @cypress/code-coverage --dev Review comment: ditto. ## File path: website/blog/2021-03-02-get-front-end-test-coverage-with-cypress.md ## @@ -0,0 +1,84 @@ +--- +title: "Get Front-End Test Coverage with Cypress" +author: Yi Sun +authorURL: "https://github.com/LiteSun; +authorImageURL: "https://avatars.githubusercontent.com/u/31329157?s=400=e81b4bb4db2be162c1fcac6d188f5b0f82f71920=4; +--- + +> [@LiteSun](https://github.com/LiteSun), Apache APISIX Committer from [Shenzhen Zhiliu Technology Co.](https://www.apiseven.com/) +> +> Source: +> +> - https://github.com/apache/apisix +> -
[GitHub] [apisix] rockXiaofeng commented on issue #3725: request help: about dubbo proxy
rockXiaofeng commented on issue #3725: URL: https://github.com/apache/apisix/issues/3725#issuecomment-788693781 > What's the **full** output of `openresty -V`? nginx version: openresty/1.19.3.1 built by clang 12.0.0 (clang-1200.0.32.29) built with OpenSSL 1.1.1d 10 Sep 2019 TLS SNI support enabled configure arguments: --prefix=/usr/local/openresty/nginx --with-cc-opt=-O2 --add-module=../ngx_devel_kit-0.3.1 --add-module=../echo-nginx-module-0.62 --add-module=../xss-nginx-module-0.06 --add-module=../ngx_coolkit-0.2 --add-module=../set-misc-nginx-module-0.32 --add-module=../form-input-nginx-module-0.12 --add-module=../encrypted-session-nginx-module-0.08 --add-module=../srcache-nginx-module-0.32 --add-module=../ngx_lua-0.10.19 --add-module=../ngx_lua_upstream-0.07 --add-module=../headers-more-nginx-module-0.33 --add-module=../array-var-nginx-module-0.05 --add-module=../memc-nginx-module-0.19 --add-module=../redis2-nginx-module-0.15 --add-module=../redis-nginx-module-0.3.7 --add-module=../ngx_stream_lua-0.0.9 --with-ld-opt=-Wl,-rpath,/usr/local/openresty/luajit/lib --add-module=/users/james/openresty-1.19.3.1/../mod_dubbo --add-module=/users/james/openresty-1.19.3.1/../ngx_multi_upstream_module --with-openssl=/usr/local/opt/openssl-1.1.1d --with-pcre-jit --with-stream --with-str eam_ssl_module --with-stream_ssl_preread_module --with-http_v2_module --without-mail_pop3_module --without-mail_imap_module --without-mail_smtp_module --with-http_stub_status_module --with-http_realip_module --with-http_addition_module --with-http_auth_request_module --with-http_secure_link_module --with-http_random_index_module --with-http_gzip_static_module --with-http_sub_module --with-http_dav_module --with-http_flv_module --with-http_mp4_module --with-http_gunzip_module --with-threads --with-compat --with-openssl-opt=-g --with-stream --with-http_ssl_module This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #220: improve Subscribe Mailing-list more clear
juzhiyuan commented on issue #220: URL: https://github.com/apache/apisix-website/issues/220#issuecomment-788694585 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3725: request help: about dubbo proxy
spacewander commented on issue #3725: URL: https://github.com/apache/apisix/issues/3725#issuecomment-788688011 What's the **full** output of `openresty -V`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3723: feat: release 2.4
juzhiyuan commented on a change in pull request #3723:
URL: https://github.com/apache/apisix/pull/3723#discussion_r585322522
##
File path: rockspec/apisix-2.4-0.rockspec
##
@@ -0,0 +1,90 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+package = "apisix"
+version = "2.4-0"
+supported_platforms = {"linux", "macosx"}
+
+source = {
+url = "git://github.com/apache/apisix",
+branch = "2.4",
+}
+
+description = {
+summary = "Apache APISIX is a cloud-native microservices API gateway,
delivering the ultimate performance, security, open source and scalable
platform for all your APIs and microservices.",
+homepage = "https://github.com/apache/apisix;,
+license = "Apache License 2.0",
+}
+
+dependencies = {
+"lua-resty-ctxdump = 0.1-0",
+"lua-resty-dns-client = 5.2.0",
+"lua-resty-template = 1.9",
+"lua-resty-etcd = 1.4.3",
+"lua-resty-balancer = 0.02rc5",
+"lua-resty-ngxvar = 0.5.2",
+"lua-resty-jit-uuid = 0.0.7",
+"lua-resty-healthcheck-api7 = 2.2.0",
+"lua-resty-jwt = 0.2.0",
+"lua-resty-hmac-ffi = 0.05",
+"lua-resty-cookie = 0.1.0",
+"lua-resty-session = 2.24",
+"opentracing-openresty = 0.1",
+"lua-resty-radixtree = 2.6.1",
+"lua-protobuf = 0.3.1",
+"lua-resty-openidc = 1.7.2-1",
+"luafilesystem = 1.7.0-2",
+"lua-tinyyaml = 1.0",
+"nginx-lua-prometheus = 0.20201218",
+"jsonschema = 0.9.3",
+"lua-resty-ipmatcher = 0.6",
+"lua-resty-kafka = 0.07",
+"lua-resty-logger-socket = 2.0-0",
+"skywalking-nginx-lua = 0.3-0",
Review comment:
we use 0.3-0 here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] guoqqqi opened a new pull request #227: docs: added blog `Get Front-End Test Coverage with Cypress`
guoqqqi opened a new pull request #227: URL: https://github.com/apache/apisix-website/pull/227 Fixes: #[Add issue number here] Changes: Screenshots of the change: Added a blog "Get Front-End Test Coverage with Cypress". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1539: fix: update sidebar config
juzhiyuan commented on pull request #1539: URL: https://github.com/apache/apisix-dashboard/pull/1539#issuecomment-788684814 no, after this PR gets merged, it will show the sidebar ✌️ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3712: fix: invalid links in markdown files
juzhiyuan commented on a change in pull request #3712: URL: https://github.com/apache/apisix/pull/3712#discussion_r585317050 ## File path: docs/zh/latest/plugins/openid-connect.md ## @@ -59,7 +62,7 @@ OAuth 2 / Open ID Connect（OIDC）插件为 APISIX 提供身份验证和自省  以下是 curl 命令，用于将插件启用到外部服务。 -通过自省请求标头中提供的令牌，此路由将保护 https://httpbin.org/get（echo 服务）。 +通过自省请求标头中提供的令牌，此路由将保护 https://httpbin.org/get (echo 服务）。 Review comment: just updated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch fix-docs-links updated (cd94f1b -> 60b5899)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch fix-docs-links in repository https://gitbox.apache.org/repos/asf/apisix.git. from cd94f1b Merge branch 'fix-docs-links' of github.com:apache/apisix into fix-docs-links add 60b5899 docs: format codes No new revisions were added by this update. Summary of changes: docs/zh/latest/plugin-develop.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3712: fix: invalid links in markdown files
juzhiyuan commented on a change in pull request #3712:
URL: https://github.com/apache/apisix/pull/3712#discussion_r585316947
##
File path: docs/zh/latest/FAQ.md
##
@@ -58,7 +58,7 @@ APISIX 是当前性能最好的 API 网关，单核 QPS 达到 2.3 万，平均
4. 变化通知
5. 高性能
-APISIX 需要一个配置中心，上面提到的很多功能是传统关系型数据库和KV数据库是无法提供的。与 etcd 同类软件还有
Consul、ZooKeeper等，更详细比较可以参考这里：[etcd
why](https://github.com/etcd-io/etcd/blob/master/Documentation/learning/why.md#comparison-chart)，在将来也许会支持其他配置存储方案。
+APISIX 需要一个配置中心，上面提到的很多功能是传统关系型数据库和 KV 数据库是无法提供的。与 etcd 同类软件还有
Consul、ZooKeeper 等，更详细比较可以参考这里：[etcd
why](https://etcd.io/docs/v3.3.12/learning/why/)，在将来也许会支持其他配置存储方案。
Review comment:
updated
##
File path: docs/zh/latest/admin-api.md
##
@@ -23,75 +23,76 @@ title: Admin API
## 目录
-* [Route](#route)
-* [Service](#service)
-* [Consumer](#consumer)
-* [Upstream](#upstream)
-* [SSL](#ssl)
-* [Global Rule](#global-rule)
-* [Plugin Config](#plugin-config)
-* [Plugin Metadata](#plugin-metadata)
-* [Plugin](#plugin)
+- [目录](#目录)
+- [Route](#route)
+- [Service](#service)
+- [Consumer](#consumer)
+- [Upstream](#upstream)
+- [SSL](#ssl)
+- [Global Rule](#global-rule)
+- [Plugin Config](#plugin-config)
+- [Plugin Metadata](#plugin-metadata)
+- [Plugin](#plugin)
## Route
-*地址*：/apisix/admin/routes/{id}?ttl=0
+_地址_：/apisix/admin/routes/{id}?ttl=0
Review comment:
just updated
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix] branch fix-docs-links updated (7936e81 -> cd94f1b)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch fix-docs-links in repository https://gitbox.apache.org/repos/asf/apisix.git. from 7936e81 Update discovery.md add 9fc4472 docs: format codes add cd94f1b Merge branch 'fix-docs-links' of github.com:apache/apisix into fix-docs-links No new revisions were added by this update. Summary of changes: docs/en/latest/plugin-develop.md | 34 +-- docs/en/latest/plugins/hmac-auth.md | 34 +-- docs/zh/latest/FAQ.md| 6 ++--- docs/zh/latest/admin-api.md | 40 docs/zh/latest/health-check.md | 34 +-- docs/zh/latest/plugin-develop.md | 26 ++--- docs/zh/latest/plugins/hmac-auth.md | 32 - docs/zh/latest/plugins/jwt-auth.md | 8 +++ docs/zh/latest/plugins/openid-connect.md | 2 +- docs/zh/latest/plugins/prometheus.md | 14 +-- docs/zh/latest/plugins/udp-logger.md | 2 +- docs/zh/latest/plugins/wolf-rbac.md | 20 12 files changed, 126 insertions(+), 126 deletions(-)
[apisix] branch fix-docs-links updated (37541bb -> 7936e81)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch fix-docs-links in repository https://gitbox.apache.org/repos/asf/apisix.git. from 37541bb Merge branch 'master' into fix-docs-links add 7936e81 Update discovery.md No new revisions were added by this update. Summary of changes: docs/zh/latest/discovery.md | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-)
[GitHub] [apisix] rockXiaofeng opened a new issue #3725: questions about dubbo proxy
rockXiaofeng opened a new issue #3725:
URL: https://github.com/apache/apisix/issues/3725
### Issue description
client: curl
gateway: Apisix/2.3
provider server: helloworld/dubbo/go-server/app
(http://github.com/dubbogo/dubbo-samples)
Refer to this document:
https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/dubbo-proxy.md
to configure upstream and router, the provider configuration is as
follows(test/server.yml):
application:
organization : "ikurento.com"
name : "BDTService"
module : "dubbogo user-info server"
version : "0.0.1"
owner : "ZX"
environment : "test"
registries :
"hangzhouzk":
protocol: "etcdv3"
timeout : "3s"
address: "127.0.0.1:2379"
username: ""
password: ""
services:
"UserProvider":
registry: "hangzhouzk"
protocol : "dubbo"
interface : "com.ikurento.user.UserProvider"
loadbalance: "random"
warmup: "100"
cluster: "failover"
methods:
- name: "GetUser"
retries: 1
loadbalance: "random"
protocols:
"dubbo":
name: "dubbo"
#ip : "127.0.0.1"
port: 2
The configuration of upstream and router is as follows:
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uris": [
"/hello"
],
"plugins": {
"dubbo-proxy": {
"service_name": "UserProvider",
"service_version": "0.0.1",
"method": "GetUser"
}
},
"upstream_id": 1
}'
curl http://127.0.0.1:9080/apisix/admin/upstream/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"nodes": {
"127.0.0.1:2": 1
},
"type": "roundrobin"
}'
Get 500 Internal Server Error after requesting the api (from apisix error
log):
2021/03/02 15:02:10 [error] 11720#143808: *1646577 lua entry thread
aborted: runtime error: .../apisix7/apisix/apisix/plugins/dubbo-proxy.lua:58:
variable "dubbo_service_name" not found for writing; maybe it is a built-in
variable that is not changeable or you forgot to use "set $dubbo_service_name
'';" in the config file to define it first
stack traceback:
coroutine 0:
[C]: in function 'error'
/usr/local/openresty/lualib/resty/core/var.lua:144: in function
'__newindex'
...eng/myCode/apisix7/apisix/apisix/plugins/dubbo-proxy.lua:58: in
function 'phase_func'
.../apisix7/apisix/apisix/plugin.lua:661: in function 'run_plugin'
.../apisix7/apisix/apisix/init.lua:446: in function 'http_access_phase'
access_by_lua(nginx.conf:209):2: in main chunk, client: ::1, server: ,
request: "GET /hello HTTP/1.1", host: "localhost:9080"
### Environment
* apisix version (cmd: `apisix version`): 2.3
* OS (cmd: `uname -a`): Darwin Kernel Version 20.1.0
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
openresty/1.19.3.1
* etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
3.5.0
* apisix-dashboard version, if have: 2.4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander closed pull request #3724: chore: only package this version's rockspec
spacewander closed pull request #3724: URL: https://github.com/apache/apisix/pull/3724 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #3721: chore: update skywalking plugin to v0.4.0
juzhiyuan commented on pull request #3721: URL: https://github.com/apache/apisix/pull/3721#issuecomment-788663129 ok, just wait for SkyWalking to make a new release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1407: i18n: Need more language support
juzhiyuan commented on issue #1407: URL: https://github.com/apache/apisix-dashboard/issues/1407#issuecomment-788662646 ya, due to the Dashboard is still in progress and its documentation will get updated more frequently, how about involing Apache APISIX's documentation? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Yiyiyimu commented on pull request #1539: fix: update sidebar config
Yiyiyimu commented on pull request #1539: URL: https://github.com/apache/apisix-dashboard/pull/1539#issuecomment-788663379 The sidebar seems empty, is that what we expected? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan opened a new issue #226: support algolia search service for website
juzhiyuan opened a new issue #226: URL: https://github.com/apache/apisix-website/issues/226 **Actual Behaviour** Hi, we are using Docusaurus[1] to build our website and added our projects' documentation these days. Due to help users to find docs more quickly, we could use the algolia[1] service here. Here[3] is its usage, just for reference. [1] https://v2.docusaurus.io/ [2] http://algolia.com/ [3] https://v2.docusaurus.io/docs/search#using-algolia-docsearch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qier222 commented on issue #1407: i18n: Need more language support
qier222 commented on issue #1407: URL: https://github.com/apache/apisix-dashboard/issues/1407#issuecomment-788651751 > Hi @juzhiyuan > > Can I create the **zh-TW.ts** and **zh-TW** folder in the locales folder right? Yes, you can. Maybe we should use `zh-tw` instead of `zh-TW` since it will appear on the website URL? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1538: fix Incomplete i18n coverage
juzhiyuan commented on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788650115 cc @guoqqqi to review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #214: fix: additional increase in button size due to #213
juzhiyuan commented on pull request #214: URL: https://github.com/apache/apisix-website/pull/214#issuecomment-788649630  Also, how about making this part align from two sides? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1493: Support More selectors on List page
juzhiyuan commented on issue #1493: URL: https://github.com/apache/apisix-dashboard/issues/1493#issuecomment-788648719  How about this one? as for ant-design, we may wait for their update 樂 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] qier222 commented on pull request #214: fix: additional increase in button size due to #213
qier222 commented on pull request #214: URL: https://github.com/apache/apisix-website/pull/214#issuecomment-788648424 > How about this (initially I was trying not to change too much of the original design as he/she must have had their thoughts behind it, but now I feel you are fine with it. So here we go ) > >  > > I removed the Apisix title, as it looked repeated (written in navbar too), Increased the font size for highest focus, and changed its color to match the color scheme. > > Made the text wrap, as the sub head copywriting is too long, reader might lose his eye position in the middle. > > Also made the buttons a little thinner, for best results > > On mobile - > >  Sorry for the slow response. I designed this page, I was planning to make the logo on the navbar hidden when the logo in the hero section is visible, but I haven't done this. I think you can remove the logo in the hero section now. The "View on GitHub" and "Downloads" buttons are center-aligned inside and left-aligned outside, looks weird to me, I still think make these buttons full-screen wide is a better option. Maybe we can center align the slogan on mobile devices? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1407: i18n: Need more language support
juzhiyuan commented on issue #1407: URL: https://github.com/apache/apisix-dashboard/issues/1407#issuecomment-788647626 樂 This needs @qier222 's confirmation, not sure if it supports this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3724: chore: only package this version's rockspec
spacewander opened a new pull request #3724: URL: https://github.com/apache/apisix/pull/3724 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1539: fix: update sidebar config
juzhiyuan opened a new pull request #1539: URL: https://github.com/apache/apisix-dashboard/pull/1539 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix Update Sidebar Configuration, so we will have a sidebar here[1].  [1] https://apisix.apache.org/docs/dashboard/FAQ/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch juzhiyuan-patch-1 created (now f89fb42)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at f89fb42 fix: update sidebar config This branch includes the following new commits: new f89fb42 fix: update sidebar config The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[apisix-dashboard] 01/01: fix: update sidebar config
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch juzhiyuan-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
commit f89fb42dac33fe2ff98e597bb2053805ca9dbf16
Author: 琚致远
AuthorDate: Tue Mar 2 14:18:13 2021 +0800
fix: update sidebar config
---
docs/en/latest/config.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/en/latest/config.json b/docs/en/latest/config.json
index 70ae9e6..a1466a5 100644
--- a/docs/en/latest/config.json
+++ b/docs/en/latest/config.json
@@ -1,6 +1,6 @@
{
"version": 2.4,
- "docs": [
+ "sidebar": [
{
"type": "category",
"label": "Getting Started",
[apisix-dashboard] branch master updated: feat: add frontend e2e report on pr comment (#1529)
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 2dbd204 feat: add frontend e2e report on pr comment (#1529) 2dbd204 is described below commit 2dbd204d1f42fb9eb425b4cdc7f190adedfc667e Author: litesun AuthorDate: Tue Mar 2 14:07:21 2021 +0800 feat: add frontend e2e report on pr comment (#1529) --- .github/workflows/backend-e2e-test.yml | 9 - .github/workflows/backend-unit-test.yml | 4 ++-- .github/workflows/frontend-e2e-test.yml | 4 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/workflows/backend-e2e-test.yml b/.github/workflows/backend-e2e-test.yml index 4c91dd6..20f31d1 100644 --- a/.github/workflows/backend-e2e-test.yml +++ b/.github/workflows/backend-e2e-test.yml @@ -18,7 +18,7 @@ jobs: - name: setup go uses: actions/setup-go@v2.1.3 with: - go-version: '1.13' + go-version: "1.13" - name: Modify conf.yaml run: | @@ -75,8 +75,7 @@ jobs: - name: upload coverage profile working-directory: ./api/test/testdata run: | - bash <(curl -s https://codecov.io/bash) -f ./integrationcover.out - + bash <(curl -s https://codecov.io/bash) -f ./integrationcover.out -F backend-e2e-test backend-e2e-test-ginkgo: runs-on: ubuntu-latest @@ -87,7 +86,7 @@ jobs: - name: setup go uses: actions/setup-go@v2.1.3 with: - go-version: '1.13' + go-version: "1.13" - name: Modify conf.yaml Configure for use by the manage-api cluster run: | @@ -130,4 +129,4 @@ jobs: - name: upload coverage profile working-directory: ./api/test/testdata run: | - bash <(curl -s https://codecov.io/bash) -f ./integrationcover.out + bash <(curl -s https://codecov.io/bash) -f ./integrationcover.out -F backend-e2e-test-ginkgo diff --git a/.github/workflows/backend-unit-test.yml b/.github/workflows/backend-unit-test.yml index d6303e0..657b0e0 100644 --- a/.github/workflows/backend-unit-test.yml +++ b/.github/workflows/backend-unit-test.yml @@ -27,7 +27,7 @@ jobs: - name: setup go uses: actions/setup-go@v2.1.3 with: - go-version: '1.13' + go-version: "1.13" - name: run test run: | @@ -36,7 +36,7 @@ jobs: - name: upload coverage profile working-directory: ./api run: | - bash <(curl -s https://codecov.io/bash) + bash <(curl -s https://codecov.io/bash) -F backend-unit-test - name: run with custom port working-directory: ./api diff --git a/.github/workflows/frontend-e2e-test.yml b/.github/workflows/frontend-e2e-test.yml index 1167d96..2ba0014 100644 --- a/.github/workflows/frontend-e2e-test.yml +++ b/.github/workflows/frontend-e2e-test.yml @@ -53,3 +53,7 @@ jobs: - name: Report e2e coverage run: npx nyc report --reporter=text-summary + + - name: Upload coverage to Codecov +run: | + bash <(curl -s https://codecov.io/bash) -f ./coverage/coverage-final.json -F frontend-e2e-test
[GitHub] [apisix-dashboard] LiteSun merged pull request #1529: feat: add frontend e2e report on pr comment
LiteSun merged pull request #1529: URL: https://github.com/apache/apisix-dashboard/pull/1529 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3722: request help: How to set path supports regular matching like nginx
Firstsawyou commented on issue #3722:
URL: https://github.com/apache/apisix/issues/3722#issuecomment-788604894
> I don’t understand what you mean, you can post a link to the document or
some demo, thank you very much！
This is an example, you can refer to it:
```
curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri": "/lib/*",
"vars": [
["uri","~*","/lib/([a-fA-F0-9]+)$"]
],
"upstream": {
"nodes": {
"127.0.0.1:1980": 1
},
"type": "roundrobin"
}
}'
```
You can refer to here for the detailed usage of vars:
https://github.com/apache/apisix/blob/master/docs/en/latest/admin-api.md#route
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix Incomplete i18n coverage
codecov-io edited a comment on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) Report > Merging [#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) (3e3d53f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e51323fccf8b7bf5490f3e59319bb1c10ea03c5f?el=desc) (e51323f) will **decrease** coverage by `0.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1538 +/- ## == - Coverage 68.61% 68.57% -0.05% == Files 48 48 Lines3056 3055 -1 == - Hits 2097 2095 -2 - Misses718 720 +2 + Partials 241 240 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `54.05% <0.00%> (-5.41%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `68.20% <0.00%> (-0.68%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `64.91% <0.00%> (ø)` | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.95% <0.00%> (+1.20%)` | :arrow_up: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.27% <0.00%> (+1.81%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer). Last update [e51323f...3e3d53f](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on issue #1407: i18n: Need more language support
stu01509 commented on issue #1407: URL: https://github.com/apache/apisix-dashboard/issues/1407#issuecomment-788592845 Hi @juzhiyuan Can I create the **zh-TW.ts** and **zh-TW** folder in the locales folder right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix Incomplete i18n coverage
codecov-io edited a comment on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) Report > Merging [#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) (3e3d53f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e51323fccf8b7bf5490f3e59319bb1c10ea03c5f?el=desc) (e51323f) will **decrease** coverage by `6.29%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1538 +/- ## == - Coverage 68.61% 62.32% -6.30% == Files 48 48 Lines3056 3055 -1 == - Hits 2097 1904 -193 - Misses718 901 +183 - Partials 241 250 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `30.00% <0.00%> (-20.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `54.08% <0.00%> (-16.33%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `71.12% <0.00%> (-7.12%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `62.56% <0.00%> (-6.71%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer). Last update [e51323f...3e3d53f](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] stu01509 commented on issue #224: The top `version` is not set for phone layout
stu01509 commented on issue #224: URL: https://github.com/apache/apisix-website/issues/224#issuecomment-788591506 Hi @Yiyiyimu I want to try this issue, Please assign this issue to me :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1538: fix Incomplete i18n coverage
codecov-io commented on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) Report > Merging [#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) (3e3d53f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e51323fccf8b7bf5490f3e59319bb1c10ea03c5f?el=desc) (e51323f) will **decrease** coverage by `16.98%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1538 +/- ## === - Coverage 68.61% 51.63% -16.99% === Files 48 39-9 Lines3056 2599 -457 === - Hits 2097 1342 -755 - Misses718 1083 +365 + Partials 241 174 -67 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer). Last update [e51323f...3e3d53f](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop opened a new pull request #1538: fix Incomplete i18n coverage
Baoyuantop opened a new pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues #1514 ___ ### Bugfix - Description fixed Incomplete i18n coverage - How to fix? Upgraded `@ant-design/pro-table` component to the latest version ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Please add the corresponding test cases if necessary. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on issue #1493: Support More selectors on List page
stu01509 commented on issue #1493: URL: https://github.com/apache/apisix-dashboard/issues/1493#issuecomment-788588752 Hi @juzhiyuan I found some issues when the Dropdown contains Popconfirm, the Popconfirm's position will overflow. Here are some related comment, seem like Ant Design Team is not fix yet. Any suggestions or ideas? https://github.com/ant-design/ant-design/issues/22578 https://github.com/ant-design/ant-design/issues/22814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1537: Backport: Update v2.4 rpm link in branch v2.4
juzhiyuan merged pull request #1537: URL: https://github.com/apache/apisix-dashboard/pull/1537 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch v2.4 updated: fix: modify the rpm link for 2.4 (#1497) (#1537)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch v2.4 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/v2.4 by this push: new 623b803 fix: modify the rpm link for 2.4 (#1497) (#1537) 623b803 is described below commit 623b8039f2a4cb7af93a9816531750e0323f0d22 Author: liuxiran AuthorDate: Tue Mar 2 12:35:37 2021 +0800 fix: modify the rpm link for 2.4 (#1497) (#1537) --- docs/deploy-with-rpm.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/deploy-with-rpm.md b/docs/deploy-with-rpm.md index 1b77720..0582d2e 100644 --- a/docs/deploy-with-rpm.md +++ b/docs/deploy-with-rpm.md @@ -24,7 +24,7 @@ ## Install from RPM ```sh -$ sudo yum install -y https://github.com/apache/apisix-dashboard/releases/download/v2.4/apisix-dashboard-v2.4-1.x86_64.rpm +$ sudo yum install -y https://github.com/apache/apisix-dashboard/releases/download/v2.4/apisix-dashboard-2.4-0.x86_64.rpm ``` ## Run
[GitHub] [apisix-website] juzhiyuan merged pull request #225: docs: added dashboard
juzhiyuan merged pull request #225: URL: https://github.com/apache/apisix-website/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: docs: added dashboard (#225)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 7d3064d docs: added dashboard (#225)
7d3064d is described below
commit 7d3064da0047bb2c838ae877866c1d3e1b3fa6ef
Author: 琚致远
AuthorDate: Tue Mar 2 12:34:39 2021 +0800
docs: added dashboard (#225)
---
sync-docs.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sync-docs.js b/sync-docs.js
index 54396de..1d03356 100644
--- a/sync-docs.js
+++ b/sync-docs.js
@@ -3,8 +3,8 @@ console.log("Start sync-docs.js");
const childProcess = require("child_process");
const fs = require("fs");
-// NOTE: disable "apisix-dashboard" "apisix-docker" "apisix-helm-chart"
currently
-const projects = ["apisix-ingress-controller", "apisix"];
+// NOTE: disable "apisix-docker" "apisix-helm-chart" currently
+const projects = ["apisix-ingress-controller", "apisix", "apisix-dashboard"];
const projectPaths = projects.map((project) => {
return {
@@ -77,7 +77,7 @@ const copyDocs = (source, target, projectName, locale) => {
console.log(`[${projectName}] write sidebar.json`);
const sidebar = {
-docs: [...(configLatest.sidebar || {})],
+docs: [...(configLatest.sidebar || [])],
};
fs.writeFileSync(`${target}/sidebars.json`, JSON.stringify(sidebar, null,
2));
};
[GitHub] [apisix] spacewander merged pull request #3716: chore: use the # operator to get the length of the Lua string
spacewander merged pull request #3716: URL: https://github.com/apache/apisix/pull/3716 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: chore: use the # operator to get the length of the Lua string (#3716)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new a82e31d chore: use the # operator to get the length of the Lua string (#3716) a82e31d is described below commit a82e31d7e2df13a4687735b5064b0b56fb04ede1 Author: Yousa AuthorDate: Tue Mar 2 12:30:26 2021 +0800 chore: use the # operator to get the length of the Lua string (#3716) You should always use the # operator to get the length of the Lua string instead of the string.len according to: https://yousali.me/openresty-best-practices/lua/string_library.html --- apisix/plugins/log-rotate.lua | 2 +- apisix/plugins/proxy-cache.lua | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apisix/plugins/log-rotate.lua b/apisix/plugins/log-rotate.lua index 217c2f4..22709c2 100644 --- a/apisix/plugins/log-rotate.lua +++ b/apisix/plugins/log-rotate.lua @@ -61,7 +61,7 @@ local function get_last_index(str, key) local _, idx = str_find(rev, key) local n if idx then -n = string.len(rev) - idx + 1 +n = #rev - idx + 1 end return n diff --git a/apisix/plugins/proxy-cache.lua b/apisix/plugins/proxy-cache.lua index ccfa8a8..b3acbb0 100644 --- a/apisix/plugins/proxy-cache.lua +++ b/apisix/plugins/proxy-cache.lua @@ -194,7 +194,7 @@ local function generate_cache_filename(cache_path, cache_levels, cache_key) local levels = ngx_re.split(cache_levels, ":") local filename = "" -local index = string.len(md5sum) +local index = #md5sum for k, v in pairs(levels) do local length = tonumber(v) index = index - length
[GitHub] [apisix] spacewander closed issue #3709: update Slack invitaion link
spacewander closed issue #3709: URL: https://github.com/apache/apisix/issues/3709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3711: improve screenshots in docs
spacewander closed issue #3711: URL: https://github.com/apache/apisix/issues/3711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3715: docs: updated users image part in README.md
spacewander merged pull request #3715: URL: https://github.com/apache/apisix/pull/3715 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (7686cb4 -> 573b488)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 7686cb4 docs: update the plugin-develop.md doc (#3705) add 573b488 docs: updated users image part in README.md (#3715) No new revisions were added by this update. Summary of changes: README.md| 6 +++--- docs/es/latest/README.md | 2 +- docs/zh/latest/README.md | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)
[apisix] branch release/2.4 updated (31c3707 -> b94d3fc)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch release/2.4
in repository https://gitbox.apache.org/repos/asf/apisix.git.
discard 31c3707 feat: release 2.4
add b94d3fc feat: release 2.4
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (31c3707)
\
N -- N -- N refs/heads/release/2.4 (b94d3fc)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
rockspec/{apisix-master-0.rockspec => apisix-2.4-0.rockspec} | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
copy rockspec/{apisix-master-0.rockspec => apisix-2.4-0.rockspec} (98%)
[GitHub] [apisix-website] juzhiyuan edited a comment on issue #178: Add a bundle of Good first issues links to Homepage
juzhiyuan edited a comment on issue #178: URL: https://github.com/apache/apisix-website/issues/178#issuecomment-788571521 also, we have 7 repos that need Good first issue. Then how do let users know this information?  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #178: Add a bundle of Good first issues links to Homepage
juzhiyuan commented on issue #178: URL: https://github.com/apache/apisix-website/issues/178#issuecomment-788571521 also, we have 7 repos that need Good first issue.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch docs-dashboard updated (fe0d810 -> 4988653)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-dashboard in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from fe0d810 docs: added dashboard add 4988653 fix: sidebar No new revisions were added by this update. Summary of changes: sync-docs.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [apisix] spacewander commented on pull request #3721: chore: update skywalking plugin to v0.4.0
spacewander commented on pull request #3721: URL: https://github.com/apache/apisix/pull/3721#issuecomment-788569218 Look like the library should make a new release: https://github.com/apache/skywalking-nginx-lua/pull/68 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan closed issue #223: The column button takes too much spaces for phone layout
juzhiyuan closed issue #223: URL: https://github.com/apache/apisix-website/issues/223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #223: The column button takes too much spaces for phone layout
juzhiyuan commented on issue #223: URL: https://github.com/apache/apisix-website/issues/223#issuecomment-788568784 just checked and fixed it already This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1529: feat: add frontend e2e report on pr comment
codecov-io edited a comment on pull request #1529: URL: https://github.com/apache/apisix-dashboard/pull/1529#issuecomment-787707234 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=h1) Report > Merging [#1529](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=desc) (ccd477e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/816ba9ec5e37327e151ca095a280ee2d087097f1?el=desc) (816ba9e) will **increase** coverage by `0.82%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1529 +/- ## == + Coverage 68.61% 69.44% +0.82% == Files 48 128 +80 Lines3056 5188+2132 Branches0 534 +534 == + Hits 2097 3603+1506 - Misses718 1345 +627 + Partials 241 240 -1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `55.59% <ø> (?)` | | | backend-e2e-test-ginkgo | `33.83% <ø> (?)` | | | backend-unit-test | `51.69% <ø> (?)` | | | frontend-e2e-test | `70.07% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | `41.37% <0.00%> (ø)` | | | [web/src/components/Upstream/constant.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbnN0YW50LnRz) | `100.00% <0.00%> (ø)` | | | [web/src/pages/SSL/components/Step1/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMS9pbmRleC50c3g=) | `40.74% <0.00%> (ø)` | | | [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `52.94% <0.00%> (ø)` | | | [...components/PluginOrchestration/components/Page.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY29tcG9uZW50cy9QYWdlLnRzeA==) | `100.00% <0.00%> (ø)` | | | [...pages/SSL/components/CertificateUploader/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZVVwbG9hZGVyL2luZGV4LnRzeA==) | `4.16% <0.00%> (ø)` | | | [web/src/pages/Setting/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL3NlcnZpY2UudHM=) | `100.00% <0.00%> (ø)` | | | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | `83.48% <0.00%> (ø)` | | | [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `76.08% <0.00%> (ø)` | | | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | `100.00% <0.00%> (ø)` | | | ... and [73 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=footer). Last update [816ba9e...ccd477e](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:
[GitHub] [apisix-website] juzhiyuan opened a new pull request #225: docs: added dashboard
juzhiyuan opened a new pull request #225: URL: https://github.com/apache/apisix-website/pull/225 added dashboard docs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] 01/01: docs: added dashboard
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch docs-dashboard
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
commit fe0d81050798bb73872eff7931bb06b800eb53eb
Author: juzhiyuan
AuthorDate: Tue Mar 2 12:12:06 2021 +0800
docs: added dashboard
---
sync-docs.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sync-docs.js b/sync-docs.js
index 54396de..65d96f5 100644
--- a/sync-docs.js
+++ b/sync-docs.js
@@ -3,8 +3,8 @@ console.log("Start sync-docs.js");
const childProcess = require("child_process");
const fs = require("fs");
-// NOTE: disable "apisix-dashboard" "apisix-docker" "apisix-helm-chart"
currently
-const projects = ["apisix-ingress-controller", "apisix"];
+// NOTE: disable "apisix-docker" "apisix-helm-chart" currently
+const projects = ["apisix-ingress-controller", "apisix", "apisix-dashboard"];
const projectPaths = projects.map((project) => {
return {
[apisix-website] branch docs-dashboard created (now fe0d810)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-dashboard in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at fe0d810 docs: added dashboard This branch includes the following new commits: new fe0d810 docs: added dashboard The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1529: feat: add frontend e2e report on pr comment
codecov-io edited a comment on pull request #1529: URL: https://github.com/apache/apisix-dashboard/pull/1529#issuecomment-787707234 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=h1) Report > Merging [#1529](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=desc) (ccd477e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/816ba9ec5e37327e151ca095a280ee2d087097f1?el=desc) (816ba9e) will **decrease** coverage by `2.77%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1529 +/- ## == - Coverage 68.61% 65.84% -2.78% == Files 48 128 +80 Lines3056 5188+2132 Branches0 534 +534 == + Hits 2097 3416+1319 - Misses718 1522 +804 - Partials 241 250 +9 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test-ginkgo | `33.83% <ø> (?)` | | | backend-unit-test | `51.69% <ø> (?)` | | | frontend-e2e-test | `70.07% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `30.00% <0.00%> (-20.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `58.16% <0.00%> (-12.25%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `71.12% <0.00%> (-7.12%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `62.56% <0.00%> (-6.71%)` | :arrow_down: | | ... and [85 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1529/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=footer). Last update [816ba9e...ccd477e](https://codecov.io/gh/apache/apisix-dashboard/pull/1529?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3723: feat: release 2.4
spacewander opened a new pull request #3723: URL: https://github.com/apache/apisix/pull/3723 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan closed issue #217: check and fix all broken links
juzhiyuan closed issue #217: URL: https://github.com/apache/apisix-website/issues/217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #219: fix #217(Fixing broken links)
juzhiyuan merged pull request #219: URL: https://github.com/apache/apisix-website/pull/219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: #217 - fixing broken links (#219)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 81d3cb7 #217 - fixing broken links (#219)
81d3cb7 is described below
commit 81d3cb708dc6f63bcb9328e1d23fc97dd4eb68e4
Author: Amit Wani
AuthorDate: Tue Mar 2 09:39:51 2021 +0530
#217 - fixing broken links (#219)
Co-authored-by: Amit Wani
---
website/docs/general/release-guide.md | 2 +-
website/docusaurus.config.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/website/docs/general/release-guide.md
b/website/docs/general/release-guide.md
index 148f2ba..9c6fbba 100644
--- a/website/docs/general/release-guide.md
+++ b/website/docs/general/release-guide.md
@@ -16,7 +16,7 @@ The entire flow is comprised of the following four phases.
This phase will decide if a feature is ready to be released as well as the
release time.
- A new target milestone will be created in Github. (e.g.
[`2.3`](https://github.com/apache/apisix-dashboard/milestone/6)).
-- A discussion will be started on dev mailing list
[d...@apisix.apache.org](d...@apisix.apache.org) for gathering ideas for the
next release.
+- A discussion will be started on dev mailing list d...@apisix.apache.org for
gathering ideas for the next release.
- Maintainer team will then mark the issues and pull requests with the target
milestone.
### Development Phase
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index e3862b3..91f66fb 100644
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -161,7 +161,7 @@ module.exports = {
},
{
label: "APISIX™️ Ingress Controller",
- to: "/docs/ingress-controller/design",
+ to: "https://apisix.apache.org/docs/ingress-controller/design/;,
},
],
},
[GitHub] [apisix-website] juzhiyuan commented on issue #223: The column button takes too much spaces for phone layout
juzhiyuan commented on issue #223: URL: https://github.com/apache/apisix-website/issues/223#issuecomment-788564902 ya, this is just fixed :) ✌️ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] LiteSun merged pull request #222: fix: pull request in place of #214
LiteSun merged pull request #222: URL: https://github.com/apache/apisix-website/pull/222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: fix: pull request in place of #214 (#222)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 164248b fix: pull request in place of #214 (#222)
164248b is described below
commit 164248be0418b30211caa880c180d939a7829c6c
Author: Shivam Singh <57267960+1502shivam-si...@users.noreply.github.com>
AuthorDate: Tue Mar 2 09:37:20 2021 +0530
fix: pull request in place of #214 (#222)
---
website/src/css/customTheme.css | 39 ---
website/src/pages/index.js | 1 -
2 files changed, 28 insertions(+), 12 deletions(-)
diff --git a/website/src/css/customTheme.css b/website/src/css/customTheme.css
index 2dd6559..b681711 100644
--- a/website/src/css/customTheme.css
+++ b/website/src/css/customTheme.css
@@ -69,21 +69,22 @@ header h2 {
}
@media only screen and (min-device-width: 360px) and (max-device-width: 736px)
{
.home-splash {
-/* margin-top: 8px; Original*/
margin-top: -20px;
-margin-bottom: -50px;/*Check*/
+margin-bottom: -50px;
}
}
.home-splash .title {
- font-size: 2.4rem;
- color: black;
+ font-size: 4.0rem;
+ color: #df2d2d;
opacity: 0.92;
}
-
-.home-splash .title.brand {
- font-size: 2.69rem;
- color: #df2d2d;
+@media only screen and (min-device-width: 360px) and (max-device-width: 736px)
{
+ .home-splash .title {
+font-size: 2.9rem;
+color: #df2d2d;
+opacity: 0.92;
+ }
}
.home-splash .title.slogan .feature-word {
@@ -101,6 +102,16 @@ header h2 {
color: #00;
opacity: 0.58;
font-size: 1.2rem;
+ width: 65%;
+}
+@media only screen and (min-device-width: 360px) and (max-device-width: 736px)
{
+ .home-splash .subtitle {
+color: #00;
+opacity: 0.58;
+font-size: 1.2rem;
+width: 100%;
+margin-top: 30px;
+ }
}
.home-splash .button-wrapper {
@@ -274,12 +285,11 @@ header h2 {
/* button */
.button {
margin: 0 10px;
- padding: 18px 18px;
+ padding: 8px 18px;
font-size: 18px;
font-weight: 600;
border-radius: 10px;
border: none;
- width: 224px;
background: #fee2e2;
color: #ef;
transition: all 0.3s;
@@ -294,10 +304,14 @@ header h2 {
display: inline-flex;
align-items: center;
margin-bottom: 15px;
+ padding: 12px;
+ justify-content: center;
+ width: 224px;
+
}
.button.github .github-logo {
height: 24px;
- margin: 0 8px 1px 0px;
+ margin: 0 12px 1px 0px;
}
.button.github:hover {
background: #000;
@@ -311,6 +325,9 @@ header h2 {
border: 1px solid #d1d5db;
box-sizing: border-box;
margin-bottom: 15px;
+ width: 224px;
+ padding: 12px;
+ justify-content: center;
}
.button.secondary:hover {
background: #e5e7eb;
diff --git a/website/src/pages/index.js b/website/src/pages/index.js
index cef385e..70d1917 100644
--- a/website/src/pages/index.js
+++ b/website/src/pages/index.js
@@ -36,7 +36,6 @@ const HomeSplash = () => {
-Apache APISIX™
A
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1526: feat: rewrite e2e test(ssl_test) with ginkgo
nic-chen commented on a change in pull request #1526:
URL: https://github.com/apache/apisix-dashboard/pull/1526#discussion_r585232127
##
File path: api/test/e2enew/ssl/ssl_test.go
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package ssl
+
+import (
+ "context"
+ "crypto/tls"
+ "encoding/json"
+ "io/ioutil"
+ "net"
+ "net/http"
+ "time"
+
+ "github.com/onsi/ginkgo"
+ "github.com/stretchr/testify/assert"
+
+ "e2enew/base"
+)
+
+var _ = ginkgo.Describe("SSL Basic", func() {
+ ginkgo.It("test ssl basic", func() {
+ // build test body
+ t := ginkgo.GinkgoT()
+ testCert, err := ioutil.ReadFile("../../certs/test2.crt")
+ assert.Nil(t, err)
+ testKey, err := ioutil.ReadFile("../../certs/test2.key")
+ assert.Nil(t, err)
+ apisixKey, err := ioutil.ReadFile("../../certs/apisix.key")
+ assert.Nil(t, err)
+ body, err := json.Marshal(map[string]interface{}{
+ "id": "1",
+ "cert": string(testCert),
+ "key": string(testKey),
+ "labels": map[string]string{
+ "build": "16",
+ "env": "production",
+ "version": "v3",
+ },
+ })
+ assert.Nil(t, err)
+ invalidBody, err := json.Marshal(map[string]string{
+ "id": "1",
+ "cert": string(testCert),
+ "key": string(apisixKey),
+ })
+ assert.Nil(t, err)
+ // Before configuring SSL, make a HTTPS request
+ http.DefaultTransport.(*http.Transport).TLSClientConfig =
{InsecureSkipVerify: true}
+ http.DefaultTransport.(*http.Transport).DialContext = func(ctx
context.Context, network, addr string) (net.Conn, error) {
+ if addr == "www.test2.com:9443" {
+ addr = "127.0.0.1:9443"
+ }
+ dialer := {}
+ return dialer.DialContext(ctx, network, addr)
+ }
+ _, err = http.Get("https://www.test2.com:9443;)
+ assert.NotNil(t, err)
+ assert.EqualError(t, err, "Get https://www.test2.com:9443:
remote error: tls: internal error")
+ //create ssl fail - key and cert not match
+ base.RunTestCase(base.HttpTestCase{
Review comment:
we could use table entry for these test cases.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] stu01509 commented on pull request #3721: chore: update skywalking plugin to v0.4.0
stu01509 commented on pull request #3721: URL: https://github.com/apache/apisix/pull/3721#issuecomment-788562712 >  > > Hi, you could use `fix #xx` to auto-close that issue once this PR gets merged. Got it, Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch release/2.4 updated: feat: release 2.4
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch release/2.4
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/release/2.4 by this push:
new 31c3707 feat: release 2.4
31c3707 is described below
commit 31c37077187356ed92bef232aaa7a8003f0bfd0d
Author: spacewander
AuthorDate: Tue Mar 2 12:02:32 2021 +0800
feat: release 2.4
Signed-off-by: spacewander
---
.gitignore | 1 +
CHANGELOG.md | 31 +++
README.md | 8
apisix/core/version.lua| 2 +-
docs/en/latest/config.json | 2 +-
docs/en/latest/how-to-build.md | 16
docs/es/latest/README.md | 8
docs/es/latest/config.json | 2 +-
docs/zh/latest/CHANGELOG.md| 31 +++
docs/zh/latest/README.md | 8
docs/zh/latest/config.json | 2 +-
docs/zh/latest/how-to-build.md | 16
12 files changed, 95 insertions(+), 32 deletions(-)
diff --git a/.gitignore b/.gitignore
index f94b319..691ed4e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -74,3 +74,4 @@ t/lib/dubbo-backend/dubbo-backend-provider/target/
/build-cache/
# release tar package
*.tgz
+release/*
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6b43fba..979ad79 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -23,6 +23,7 @@ title: Changelog
## Table of Contents
+- [2.4.0](#240)
- [2.3.0](#230)
- [2.2.0](#220)
- [2.1.0](#210)
@@ -39,6 +40,36 @@ title: Changelog
- [0.7.0](#070)
- [0.6.0](#060)
+## 2.4.0
+
+### Change
+
+- change: global rules should not be executed on the internal api by default
[#3396](https://github.com/apache/apisix/pull/3396)
+- change: default to cache DNS record according to the TTL
[#3530](https://github.com/apache/apisix/pull/3530)
+
+### Core
+
+- :sunrise: feat: support SRV record
[#3686](https://github.com/apache/apisix/pull/3686)
+- :sunrise: feat: add dns discovery
[#3629](https://github.com/apache/apisix/pull/3629)
+- :sunrise: feat: add consul kv discovery module
[#3615](https://github.com/apache/apisix/pull/3615)
+- :sunrise: feat: support to bind plugin config by `plugin_config_id`
[#3567](https://github.com/apache/apisix/pull/3567)
+- :sunrise: feat: support listen http2 with plaintext
[#3547](https://github.com/apache/apisix/pull/3547)
+- :sunrise: feat: support DNS record
[#3484](https://github.com/apache/apisix/pull/3484)
+
+### Plugin
+
+- :sunrise: feat: the traffic-split plugin supports upstream_id
[#3512](https://github.com/apache/apisix/pull/3512)
+- :sunrise: feat(zipkin): support b3 req header
[#3551](https://github.com/apache/apisix/pull/3551)
+
+### Bugfix
+
+- fix(chash): ensure retry can try every node
[#3651](https://github.com/apache/apisix/pull/3651)
+- fix: script does not work when the route is bound to a service
[#3678](https://github.com/apache/apisix/pull/3678)
+- fix: use openssl111 in openresty dir in precedence
[#3603](https://github.com/apache/apisix/pull/3603)
+- fix(zipkin): don't cache the per-req sample ratio
[#3522](https://github.com/apache/apisix/pull/3522)
+
+For more changes, please refer to
[Milestone](https://github.com/apache/apisix/milestone/13)
+
## 2.3.0
### Change
diff --git a/README.md b/README.md
index 4fe3916..92339f6 100644
--- a/README.md
+++ b/README.md
@@ -153,9 +153,9 @@ There are several ways to install the Apache Release
version of APISIX:
- Download the latest source code release package:
```shell
- $ mkdir apisix-2.3
- $ wget https://downloads.apache.org/apisix/2.3/apache-apisix-2.3-src.tgz
- $ tar zxvf apache-apisix-2.3-src.tgz -C apisix-2.3
+ $ mkdir apisix-2.4
+ $ wget https://downloads.apache.org/apisix/2.4/apache-apisix-2.4-src.tgz
+ $ tar zxvf apache-apisix-2.4-src.tgz -C apisix-2.4
```
- Install the dependencies：
@@ -192,7 +192,7 @@ There are several ways to install the Apache Release
version of APISIX:
- install APISIX：
```shell
- $ sudo yum install -y
https://github.com/apache/apisix/releases/download/2.3/apisix-2.3-0.x86_64.rpm
+ $ sudo yum install -y
https://github.com/apache/apisix/releases/download/2.4/apisix-2.4-0.x86_64.rpm
```
- check version of APISIX:
diff --git a/apisix/core/version.lua b/apisix/core/version.lua
index e419532..8c93638 100644
--- a/apisix/core/version.lua
+++ b/apisix/core/version.lua
@@ -15,5 +15,5 @@
-- limitations under the License.
--
return {
-VERSION = "2.3"
+VERSION = "2.4"
}
diff --git a/docs/en/latest/config.json b/docs/en/latest/config.json
index e217436..1527ab9 100644
--- a/docs/en/latest/config.json
+++ b/docs/en/latest/config.json
@@ -1,5 +1,5 @@
{
- "version": 2.3,
+ "version": 2.4,
"sidebar": [
{
"type": "doc",
diff --git a/docs/en/latest/how-to-build.md b/docs/en/latest/how-to-build.md
index
[apisix-website] branch master updated: docs: added dashboard (#221)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 9f4dcec docs: added dashboard (#221)
9f4dcec is described below
commit 9f4dcecbe14d30439cd1eae5f2913f187dedd038
Author: 琚致远
AuthorDate: Tue Mar 2 12:01:20 2021 +0800
docs: added dashboard (#221)
---
website/docusaurus.config.js | 10 --
website/src/pages/docs.js| 3 ++-
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index 66ae907..e3862b3 100644
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -24,6 +24,7 @@ module.exports = {
githubRepo: "apache/apisix",
version: "2.3",
releaseDate: "2021-02-09",
+firstDocPath: "/architecture-design",
},
{
name: "APISIX™ Dashboard",
@@ -35,6 +36,7 @@ module.exports = {
githubRepo: "apache/apisix-dashboard",
version: "2.4",
releaseDate: "2021-02-12",
+firstDocPath: "/USER_GUIDE",
},
{
name: "APISIX™ Ingress Controller",
@@ -45,6 +47,7 @@ module.exports = {
githubRepo: "apache/apisix-ingress-controller",
version: "0.3.0",
releaseDate: "2021-02-11",
+firstDocPath: "/design",
},
],
team: require("./static/data/team.json"),
@@ -142,7 +145,7 @@ module.exports = {
{
label: "Docs",
position: "right",
- // to: "/docs",
+ to: "/docs",
items: [
{
label: "General",
@@ -154,7 +157,7 @@ module.exports = {
},
{
label: "APISIX™️ Dashboard",
- to: "/docs/dashboard",
+ to: "/docs/dashboard/USER_GUIDE",
},
{
label: "APISIX™️ Ingress Controller",
@@ -274,6 +277,9 @@ module.exports = {
"Apache APISIX is a dynamic, real-time, high-performance
Cloud-Native API gateway, based on the Nginx library and etcd.",
},
],
+gtag: {
+ trackingID: "G-WQLBQL6GY3",
+},
},
stylesheets: [
"https://fonts.googleapis.com/css2?family=Inter:wght@300;400;500;600;700;800=swap;,
diff --git a/website/src/pages/docs.js b/website/src/pages/docs.js
index 18e4ea5..e41b969 100644
--- a/website/src/pages/docs.js
+++ b/website/src/pages/docs.js
@@ -109,6 +109,7 @@ const ProjectCard = (props) => {
color,
version,
releaseDate,
+firstDocPath = "",
} = props;
const shapeComponent =
shape === "triangle" ? (
@@ -120,7 +121,7 @@ const ProjectCard = (props) => {
);
return (
-
+
{shapeComponent}
{name}
[GitHub] [apisix-website] juzhiyuan merged pull request #221: docs: added dashboard
juzhiyuan merged pull request #221: URL: https://github.com/apache/apisix-website/pull/221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on issue #1493: Support More selectors on List page
stu01509 commented on issue #1493: URL: https://github.com/apache/apisix-dashboard/issues/1493#issuecomment-788561998 > > Hi @juzhiyuan and @nic-chen > > I use the dropdown to wrap the buttons, It may look like this, What do you think? > > Can `管理` and `^` be on one line? > And when folded, text looks better than button. **管理** and **^** they are on the one line, just affected by the window size.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1493: Support More selectors on List page
nic-chen commented on issue #1493: URL: https://github.com/apache/apisix-dashboard/issues/1493#issuecomment-788559827 > Hi @juzhiyuan and @nic-chen > > I use the dropdown to wrap the buttons, It may look like this, What do you think? Can `管理` and `^` be on one line? And when folded, text looks better than button. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #3721: chore: update skywalking plugin to v0.4.0
juzhiyuan commented on pull request #3721: URL: https://github.com/apache/apisix/pull/3721#issuecomment-788559814  Hi, you could use `fix #xx` to auto-close that issue once this PR gets merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1531: fix: Add upstream_test respbody error assertion and defer resp.Body.Close ()
juzhiyuan merged pull request #1531: URL: https://github.com/apache/apisix-dashboard/pull/1531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: fix: added respbody error asserton and defer resp.Body.Close () (#1531)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new b1b405e fix: added respbody error asserton and defer resp.Body.Close
() (#1531)
b1b405e is described below
commit b1b405e02132b13d3e748294eb5c9337dfafb674
Author: JinChen <36916582+jayc...@users.noreply.github.com>
AuthorDate: Tue Mar 2 11:52:18 2021 +0800
fix: added respbody error asserton and defer resp.Body.Close () (#1531)
---
api/test/e2enew/upstream/upstream_test.go | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/api/test/e2enew/upstream/upstream_test.go
b/api/test/e2enew/upstream/upstream_test.go
index c0776a0..0707d74 100644
--- a/api/test/e2enew/upstream/upstream_test.go
+++ b/api/test/e2enew/upstream/upstream_test.go
@@ -331,6 +331,7 @@ var _ = ginkgo.Describe("Upstream chash remote addr",
func() {
for i := 0; i < 18; i++ {
resp, err := http.DefaultClient.Do(request)
assert.Nil(t, err)
+ defer resp.Body.Close()
respBody, err := ioutil.ReadAll(resp.Body)
assert.Nil(t, err)
body := string(respBody)
@@ -339,7 +340,6 @@ var _ = ginkgo.Describe("Upstream chash remote addr",
func() {
} else {
res[body]++
}
- resp.Body.Close()
}
assert.Equal(t, 18, res["1982"])
})
@@ -403,11 +403,12 @@ var _ = ginkgo.Describe("Upstream chash remote addr",
func() {
for i := 0; i <= 17; i++ {
resp, err := http.DefaultClient.Do(request)
assert.Nil(t, err)
+ defer resp.Body.Close()
respBody, err := ioutil.ReadAll(resp.Body)
+ assert.Nil(t, err)
if string(respBody) == "1980" {
count++
}
- resp.Body.Close()
}
assert.Equal(t, 18, count)
})
[apisix-website] branch docs-dashboard updated (3f97cc2 -> 9cdbf47)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-dashboard in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 3f97cc2 trigger CI add 9cdbf47 trigger ci No new revisions were added by this update. Summary of changes: website/docusaurus.config.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
[GitHub] [apisix-dashboard] nic-chen commented on issue #1535: support automatic loading of custom plugins to dashboard
nic-chen commented on issue #1535: URL: https://github.com/apache/apisix-dashboard/issues/1535#issuecomment-788558236 > Today I will start a discussion on the mailing list. looking forward to it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1493: Support More selectors on List page
juzhiyuan commented on issue #1493: URL: https://github.com/apache/apisix-dashboard/issues/1493#issuecomment-788557848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch docs-dashboard updated (6827a36 -> 3f97cc2)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-dashboard in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 6827a36 docs: added firstDocPath add 3f97cc2 trigger CI No new revisions were added by this update. Summary of changes: website/docusaurus.config.js | 3 +++ 1 file changed, 3 insertions(+)
[GitHub] [apisix-dashboard] stu01509 commented on issue #1493: Support More selectors on List page
stu01509 commented on issue #1493: URL: https://github.com/apache/apisix-dashboard/issues/1493#issuecomment-788556010 Hi @juzhiyuan and @nic-chen I use the dropdown to wrap the buttons, It may look like this, What do you think?   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu opened a new issue #224: The top `version` is not set for phone layout
Yiyiyimu opened a new issue #224: URL: https://github.com/apache/apisix-website/issues/224 What we got:  What it should be (take chaos mesh website for reference):  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu opened a new issue #223: The column button takes too much spaces for phone layout
Yiyiyimu opened a new issue #223: URL: https://github.com/apache/apisix-website/issues/223 What we got:  What it should be (take chaos mesh website for reference):  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran merged pull request #1536: docs: updated broken docs url
liuxiran merged pull request #1536: URL: https://github.com/apache/apisix-dashboard/pull/1536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: docs: updated broken docs url (#1536)
This is an automated email from the ASF dual-hosted git repository. liuxiran pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new c547e72 docs: updated broken docs url (#1536) c547e72 is described below commit c547e72bbffd3740c798027f8ae10f096990481f Author: Ayush das AuthorDate: Tue Mar 2 09:04:08 2021 +0530 docs: updated broken docs url (#1536) --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 19719d3..f57c5b3 100644 --- a/README.md +++ b/README.md @@ -25,7 +25,7 @@ https://apisix.apache.org/;>Website • - https://github.com/apache/apisix/tree/master/doc;>Docs • + https://github.com/apache/apisix/tree/master/docs;>Docs • https://twitter.com/apacheapisix;>Twitter
[GitHub] [apisix] iamayushdas commented on issue #3711: improve screenshots in docs
iamayushdas commented on issue #3711: URL: https://github.com/apache/apisix/issues/3711#issuecomment-788553667 > Hi @iamayushdas > > > > Are you working on this issue? If not I would like to solve it. Yes i am This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] pengtaochang commented on issue #3722: request help: How to set path supports regular matching like nginx
pengtaochang commented on issue #3722: URL: https://github.com/apache/apisix/issues/3722#issuecomment-788553091 I don’t understand what you mean, you can post a link to the document or some demo, thank you very much！ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] stu01509 commented on issue #3711: improve screenshots in docs
stu01509 commented on issue #3711: URL: https://github.com/apache/apisix/issues/3711#issuecomment-788552954 Hi @iamayushdas Are you working on this issue? If not I would like to solve it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1537: Backport: Update v2.4 rpm link in branch v2.4
liuxiran opened a new pull request #1537: URL: https://github.com/apache/apisix-dashboard/pull/1537 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description origin reported link: https://github.com/apache/apisix-dashboard/pull/1497#issuecomment-783783397 - How to fix? ___ ### Backport patches - Why need to backport? update error rpm link in branch v2.4 - Source branch master - Related commits and pull requests commit: f574fcd07e2d53f088766cb3a7ab1ede37e527b5 - Target branch v2.4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #3397: Update Dashboard's screenshot
juzhiyuan commented on issue #3397: URL: https://github.com/apache/apisix/issues/3397#issuecomment-788551113 @stu01509 Hi, you could take a look at #3711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan closed issue #3397: Update Dashboard's screenshot
juzhiyuan closed issue #3397: URL: https://github.com/apache/apisix/issues/3397 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #3397: Update Dashboard's screenshot
juzhiyuan commented on issue #3397: URL: https://github.com/apache/apisix/issues/3397#issuecomment-788551024 duplicate with https://github.com/apache/apisix/issues/3711#issuecomment-788550616 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #3711: improve screenshots in docs
juzhiyuan commented on issue #3711: URL: https://github.com/apache/apisix/issues/3711#issuecomment-788550616 like this: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/key-auth.md  This screenshot is out of date, we need to take some new screenshots from http://139.217.190.60/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] pioneer-hash opened a new issue #276: bug: Service cannot be dynamically aware of changes to the service when it is deleted and rebuilt again
pioneer-hash opened a new issue #276:
URL: https://github.com/apache/apisix-ingress-controller/issues/276
### Issue description
When there is a problem with upstream resource configuration, delete the
service corresponding to upstream POD and re-expose it.A look at the
Apisix-Ingress log shows that it also monitors old services。
This is deploymen yaml of pod :
`kind: Deployment
metadata:
creationTimestamp: null
labels:
app: web
name: web
spec:
replicas: 1
selector:
matchLabels:
app: web
strategy: {}
template:
metadata:
creationTimestamp: null
labels:
app: web
spec:
containers:
- image: nginx
name: nginx
resources: {}
status: {}
~
`
This is service yaml of pod :
`apiVersion: v1
kind: Service
metadata:
creationTimestamp: "2021-03-02T02:48:52Z"
labels:
app: web
name: web
namespace: default --- there is problematic because my apisix-ingress is
gray-publish of namespace , this servicde can't be found
resourceVersion: "13882151"
selfLink: /api/v1/namespaces/default/services/web
uid: 0d434999-12bb-4dfa-9c93-e69d66290944
spec:
clusterIP: 10.102.85.217
externalTrafficPolicy: Cluster
ports:
- nodePort: 32712
port: 80
protocol: TCP
targetPort: 80
selector:
app: web
sessionAffinity: None
type: NodePort
status:
loadBalancer: {}
`
This is my apisix-upstream.yaml:
`apiVersion: apisix.apache.org/v1
kind: ApisixUpstream
metadata:
name: web
spec:
ports:
- port: 80
loadbalancer:
type: chash
hashOn: cookie
key: sid1
`
when I use kubectl apply -f apisix-upstream.yaml to create upstream
CRD , Appear error ：
E0302 10:59:37.243624 1 apisix_upstream.go:113] error syncing
'default/web': list upstreams failed, err: Get
http://apisix-admin:9180/apisix/admin/upstreams: dial tcp: lookup apisix-admin
on 10.96.0.10:53: server misbehaving。
So I use commamd kubectl delete -f apisix-upstream.yaml and modifi
apisix-upstream.yaml then change the namespace to gray-publish. But the
error log is the same as last time ：
E0302 11:11:37.340643 1 apisix_upstream.go:113] error syncing
'default/web': list upstreams failed, err: Get
http://apisix-admin:9180/apisix/admin/upstreams: dial tcp: lookup apisix-admin
on 10.96.0.10:53: server misbehaving。
### Environment
* your apisix-ingress-controller version (output of
`apisix-ingress-controller version --long`);
* your Kubernetes cluster version (output of `kubectl version`);
* if you run apisix-ingress-controller in Bare-metal environment, also show
your OS version (`uname -a`).
### Minimal test code / Steps to reproduce the issue
1.
2.
3.
### What's the actual result? (including assertion message & call stack if
applicable)
### What's the expected result?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix] branch release/2.4 created (now 7686cb4)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch release/2.4 in repository https://gitbox.apache.org/repos/asf/apisix.git. at 7686cb4 docs: update the plugin-develop.md doc (#3705) No new revisions were added by this update.
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1509: feat: support plugin config
starsz commented on a change in pull request #1509:
URL: https://github.com/apache/apisix-dashboard/pull/1509#discussion_r585216789
##
File path: api/test/e2enew/plugin_config/plugin_config_test.go
##
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package plugin_config
+
+import (
+ "net/http"
+
+ "github.com/onsi/ginkgo"
+ "github.com/onsi/ginkgo/extensions/table"
+
+ "e2enew/base"
+)
+
+var _ = ginkgo.Describe("Plugin Config", func() {
+ table.DescribeTable("test plugin config",
+ func(tc base.HttpTestCase) {
+ base.RunTestCase(tc)
+ },
+ table.Entry("make sure the route doesn't exist",
base.HttpTestCase{
+ Object: base.APISIXExpect(),
+ Method: http.MethodGet,
+ Path: "/hello",
+ ExpectStatus: http.StatusNotFound,
+ ExpectBody: `{"error_msg":"404 Route Not Found"}`,
+ }),
+ table.Entry("create plugin config", base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Path: "/apisix/admin/plugin_configs/1",
+ Method: http.MethodPut,
+ Body: `{
+ "plugins": {
+ "response-rewrite": {
+ "headers": {
+ "X-VERSION":"1.0"
+ }
+ },
+ "uri-blocker": {
+ "block_rules":
["select.+(from|limit)", "(?:(union(.*?)select))"]
+ }
+ }
+ }`,
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ }),
+ table.Entry("create plugin config", base.HttpTestCase{
Review comment:
It seems `create plugin config` => `get plugin config`.
##
File path: api/test/e2enew/plugin_config/plugin_config_test.go
##
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package plugin_config
+
+import (
+ "net/http"
+
+ "github.com/onsi/ginkgo"
+ "github.com/onsi/ginkgo/extensions/table"
+
+ "e2enew/base"
+)
+
+var _ = ginkgo.Describe("Plugin Config", func() {
+ table.DescribeTable("test plugin config",
+ func(tc base.HttpTestCase) {
+ base.RunTestCase(tc)
+ },
+ table.Entry("make sure the route doesn't exist",
base.HttpTestCase{
+ Object: base.APISIXExpect(),
+ Method: http.MethodGet,
+ Path: "/hello",
+ ExpectStatus: http.StatusNotFound,
+ ExpectBody: `{"error_msg":"404 Route Not Found"}`,
+ }),
+ table.Entry("create plugin config", base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Path: "/apisix/admin/plugin_configs/1",
+ Method: http.MethodPut,
+
