[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1605: fix: fix the uptime translation error
codecov-io edited a comment on pull request #1605: URL: https://github.com/apache/apisix-dashboard/pull/1605#issuecomment-803253569 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=h1) Report > Merging [#1605](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=desc) (e7c8c63) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `0.54%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1605 +/- ## == - Coverage 71.69% 71.15% -0.55% == Files 133 47 -86 Lines5469 3113-2356 Branches 5920 -592 == - Hits 3921 2215-1706 + Misses 1305 654 -651 - Partials 243 244 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.86% <ø> (+0.12%)` | :arrow_up: | | backend-e2e-test-ginkgo | `47.73% <ø> (-0.13%)` | :arrow_down: | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | | | [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | | | | [web/src/pages/User/Login.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ2luLnRzeA==) | | | | [web/src/global.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-d2ViL3NyYy9nbG9iYWwudHN4) | | | | [web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==) | | | | [web/src/pages/Setting/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL3NlcnZpY2UudHM=) | | | | [web/src/components/RightContent/AvatarDropdown.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9BdmF0YXJEcm9wZG93bi50c3g=) | | | | [web/src/services/tool.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-d2ViL3NyYy9zZXJ2aWNlcy90b29sLnRz) | | | | [web/src/components/Footer/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0Zvb3Rlci9pbmRleC50c3g=) | | | | [...nts/PluginOrchestration/components/SidebarItem.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY29tcG9uZW50cy9TaWRlYmFySXRlbS50c3g=) | | | | ... and [78 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=footer). Last update [1ba32d9...e7c8c63](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1585: feat: use menu and menu item to wrap buttons
codecov-io commented on pull request #1585: URL: https://github.com/apache/apisix-dashboard/pull/1585#issuecomment-803254276 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1585?src=pr=h1) Report > Merging [#1585](https://codecov.io/gh/apache/apisix-dashboard/pull/1585?src=pr=desc) (bc7e334) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `19.88%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1585?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1585 +/- ## === - Coverage 71.69% 51.81% -19.89% === Files 133 38 -95 Lines5469 2650 -2819 Branches 5920 -592 === - Hits 3921 1373 -2548 + Misses 1305 1089 -216 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1585?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1585/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1585/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1585/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1585/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1585/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1585/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1585/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1585/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1585/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1585/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [118 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1585/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1585?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1585?src=pr=footer). Last update [1ba32d9...bc7e334](https://codecov.io/gh/apache/apisix-dashboard/pull/1585?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1605: fix: fix the uptime translation error
codecov-io edited a comment on pull request #1605: URL: https://github.com/apache/apisix-dashboard/pull/1605#issuecomment-803253569 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=h1) Report > Merging [#1605](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=desc) (e7c8c63) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `4.52%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1605 +/- ## == - Coverage 71.69% 67.16% -4.53% == Files 133 47 -86 Lines5469 3113-2356 Branches 5920 -592 == - Hits 3921 2091-1830 + Misses 1305 778 -527 - Partials 243 244 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `47.73% <ø> (-0.13%)` | :arrow_down: | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `54.05% <0.00%> (-5.41%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | ... and [88 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=footer). Last update [1ba32d9...e7c8c63](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1610: feat: improve the config plugin button enable disable status
codecov-io edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=h1) Report > Merging [#1610](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=desc) (e2060e3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `19.92%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1610 +/- ## === - Coverage 71.69% 51.77% -19.93% === Files 133 38 -95 Lines5469 2650 -2819 Branches 5920 -592 === - Hits 3921 1372 -2549 + Misses 1305 1090 -215 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.77% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [118 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=footer). Last update [1ba32d9...e2060e3](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1610: feat: improve the config plugin button enable disable status
codecov-io commented on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=h1) Report > Merging [#1610](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=desc) (317b69f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `19.88%`. > The diff coverage is `n/a`. > :exclamation: Current head 317b69f differs from pull request most recent head e2060e3. Consider uploading reports for the commit e2060e3 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1610 +/- ## === - Coverage 71.69% 51.81% -19.89% === Files 133 38 -95 Lines5469 2650 -2819 Branches 5920 -592 === - Hits 3921 1373 -2548 + Misses 1305 1089 -216 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [118 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=footer). Last update [1ba32d9...e2060e3](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1605: fix: fix the uptime translation error
codecov-io commented on pull request #1605: URL: https://github.com/apache/apisix-dashboard/pull/1605#issuecomment-803253569 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=h1) Report > Merging [#1605](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=desc) (e7c8c63) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `19.88%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1605 +/- ## === - Coverage 71.69% 51.81% -19.89% === Files 133 38 -95 Lines5469 2650 -2819 Branches 5920 -592 === - Hits 3921 1373 -2548 + Misses 1305 1089 -216 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [119 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1605/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=footer). Last update [1ba32d9...e7c8c63](https://codecov.io/gh/apache/apisix-dashboard/pull/1605?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on pull request #1605: fix: fix the uptime translation error
stu01509 commented on pull request #1605: URL: https://github.com/apache/apisix-dashboard/pull/1605#issuecomment-803253332 Hi @guoqqqi Update the commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1597: test: add the create and delete plugin in drawer
codecov-io edited a comment on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-799889165 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=h1) Report > Merging [#1597](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=desc) (9577f51) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `0.67%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1597 +/- ## == - Coverage 71.69% 71.02% -0.68% == Files 133 47 -86 Lines5469 3113-2356 Branches 5920 -592 == - Hits 3921 2211-1710 + Misses 1305 658 -647 - Partials 243 244 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.74% <ø> (ø)` | | | backend-e2e-test-ginkgo | `47.86% <ø> (ø)` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | | | [web/src/pages/Route/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9zZXJ2aWNlLnRz) | | | | [web/src/pages/Upstream/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9MaXN0LnRzeA==) | | | | [web/src/pages/PluginTemplate/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9DcmVhdGUudHN4) | | | | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | | | | [web/src/pages/Service/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0xpc3QudHN4) | | | | [web/src/pages/Route/components/Step1/MetaView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01ldGFWaWV3LnRzeA==) | | | | [web/src/components/ActionBar/ActionBar.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0FjdGlvbkJhci9BY3Rpb25CYXIudHN4) | | | | [web/src/pages/Consumer/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9zZXJ2aWNlLnRz) | | | | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | | | | ... and [77 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=footer). Last update [1ba32d9...9577f51](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #3871: docs: admin-api.md document adds configuration https example
tokers commented on pull request #3871: URL: https://github.com/apache/apisix/pull/3871#issuecomment-803253112 I cannot capture whether the https is used in client and admin api or the apisix to upstream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1597: test: add the create and delete plugin in drawer
codecov-io edited a comment on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-799889165 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=h1) Report > Merging [#1597](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=desc) (9577f51) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `4.39%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1597 +/- ## == - Coverage 71.69% 67.29% -4.40% == Files 133 47 -86 Lines5469 3113-2356 Branches 5920 -592 == - Hits 3921 2095-1826 + Misses 1305 771 -534 - Partials 243 247 +4 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `47.86% <ø> (ø)` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | | | ... and [86 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=footer). Last update [1ba32d9...9577f51](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1597: test: add the create and delete plugin in drawer
codecov-io edited a comment on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-799889165 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=h1) Report > Merging [#1597](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=desc) (9577f51) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `19.88%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1597 +/- ## === - Coverage 71.69% 51.81% -19.89% === Files 133 38 -95 Lines5469 2650 -2819 Branches 5920 -592 === - Hits 3921 1373 -2548 + Misses 1305 1089 -216 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [119 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=footer). Last update [1ba32d9...9577f51](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on pull request #152: feat: add apisix-dashboard dockerfile & CI
tokers commented on pull request #152: URL: https://github.com/apache/apisix-docker/pull/152#issuecomment-803252343 LGTM in my side. But the CI failed, please fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on pull request #1597: test: add the create and delete plugin in drawer
stu01509 commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803252310 Hi @guoqqqi and @juzhiyuan Update the commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on a change in pull request #152: feat: add apisix-dashboard dockerfile & CI
tokers commented on a change in pull request #152: URL: https://github.com/apache/apisix-docker/pull/152#discussion_r598065541 ## File path: compose/dashboard-compose.yaml ## @@ -0,0 +1,35 @@ +version: "3" Review comment: Got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock
codecov-io edited a comment on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=h1) Report > Merging [#1620](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=desc) (a1ae973) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc) (38cf0ba) will **increase** coverage by `0.92%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1620 +/- ## == + Coverage 71.65% 72.58% +0.92% == Files 133 86 -47 Lines5429 2356-3073 Branches 592 592 == - Hits 3890 1710-2180 + Misses 1296 646 -650 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `72.58% <ø> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `75.38% <0.00%> (-1.54%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | | | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | | | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | | | | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | | | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | | | ... and [38 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=footer). Last update [38cf0ba...a1ae973](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (a82f81a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `9.82%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1558 +/- ## == - Coverage 71.69% 61.86% -9.83% == Files 133 47 -86 Lines5469 3113-2356 Branches 5920 -592 == - Hits 3921 1926-1995 + Misses 1305 874 -431 - Partials 243 313 +70 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.86% <ø> (+0.12%)` | :arrow_up: | | backend-e2e-test-ginkgo | `47.99% <ø> (+0.12%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `47.22% <0.00%> (-30.56%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-29.57%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.43% <0.00%> (-29.52%)` | :arrow_down: | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `64.51% <0.00%> (-19.36%)` | :arrow_down: | | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | `59.57% <0.00%> (-18.09%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `44.82% <0.00%> (-13.80%)` | :arrow_down: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `77.14% <0.00%> (-13.58%)` | :arrow_down: | | ... and [98 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [1ba32d9...a82f81a](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (a82f81a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `23.70%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1558 +/- ## === - Coverage 71.69% 47.99% -23.71% === Files 133 47 -86 Lines5469 3113 -2356 Branches 5920 -592 === - Hits 3921 1494 -2427 - Misses 1305 1334 +29 - Partials 243 285 +42 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `47.99% <ø> (+0.12%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `36.11% <0.00%> (-41.67%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `57.22% <0.00%> (-30.73%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-29.57%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `51.83% <0.00%> (-26.94%)` | :arrow_down: | | ... and [103 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [1ba32d9...a82f81a](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1605: fix: fix the uptime translation error
guoqqqi commented on pull request #1605: URL: https://github.com/apache/apisix-dashboard/pull/1605#issuecomment-803250090 Hi, When you have time, please update the master code to fix the error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi edited a comment on pull request #1610: feat: improve the config plugin button enable disable status
guoqqqi edited a comment on pull request #1610:
URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803249476
The test failed because when the button was clicked, the button became
Disable and the Disable button was not found.
You can fix line 59 by changing
`cy.contains('Enable')` to `cy.get('button')` to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi edited a comment on pull request #1610: feat: improve the config plugin button enable disable status
guoqqqi edited a comment on pull request #1610:
URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803249476
The test failed because when the button was clicked, the button became
Disable and the Disable button was not found.
You can fix line 59 by changing
`cy.contains('Enable')` to `cy.get('button')` to fix it.
[image](https://user-images.githubusercontent.com/72343596/111859357-4fef5600-897b-11eb-87e8-ca1868ee1c45.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1610: feat: improve the config plugin button enable disable status
guoqqqi commented on pull request #1610:
URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803249476
The test failed because when the button was clicked, the button became
Disable and the Disable button was not found.
You can fix line 59 by changing `cy.contains('enable')` to
`cy.contains('Enable')` to `cy.get('button')` to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock
codecov-io edited a comment on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=h1) Report > Merging [#1620](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=desc) (0d63a7c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc) (38cf0ba) will **decrease** coverage by `0.46%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1620 +/- ## == - Coverage 71.65% 71.18% -0.47% == Files 133 47 -86 Lines5429 3113-2316 Branches 5920 -592 == - Hits 3890 2216-1674 + Misses 1296 654 -642 Partials 243 243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.93% <ø> (+0.36%)` | :arrow_up: | | backend-e2e-test-ginkgo | `47.99% <ø> (+0.64%)` | :arrow_up: | | backend-unit-test | `51.77% <ø> (+0.54%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `85.29% <0.00%> (-0.82%)` | :arrow_down: | | [web/src/components/LabelsfDrawer/LabelsDrawer.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0xhYmVsc2ZEcmF3ZXIvTGFiZWxzRHJhd2VyLnRzeA==) | | | | [web/src/components/PluginOrchestration/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vaW5kZXgudHN4) | | | | [web/src/services/user.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-d2ViL3NyYy9zZXJ2aWNlcy91c2VyLnRz) | | | | [web/src/components/PluginOrchestration/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vc2VydmljZS50cw==) | | | | [web/src/pages/PluginTemplate/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9zZXJ2aWNlLnRz) | | | | [...pages/Route/components/CreateStep4/CreateStep4.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0NyZWF0ZVN0ZXA0L0NyZWF0ZVN0ZXA0LnRzeA==) | | | | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [web/src/pages/PluginTemplate/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | | | | ... and [79 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=footer). Last update [38cf0ba...0d63a7c](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean opened a new issue #1624: Discussion: when creating a route, is route name required
Jaycean opened a new issue #1624: URL: https://github.com/apache/apisix-dashboard/issues/1624 ## Issue description - Fe create route `name` field is required. - However, in BE, the `name` field is still optional. PR: #1606 adds the BE judgment on whether the `name` field is repeated when creating a `route`. - When I use BE interface instead of FE to create route I found a problem(`127.0.0.1:9000/apisix/admin/routes POST create route`). - I create a `route` without inserting the `name` field, I can succeed the first time because it is not a required field, but I still do not pass in the name field in the second time, which will trigger the repeated judgment of the `name` field, resulting in the failure to create a route. - So I think there is a problem here. my idea is: 1. The `name` field be is still not required, but the `name` field is empty, so repeated judgment is not required. 2. The `name` field of be `route` is directly changed to a required field. At present, the logic will not have the situation that multiple `name` fields are empty and cannot be added. cc @nic-chen @starsz @tokers @imjoey @gxthrj Do you have any good suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock
codecov-io edited a comment on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=h1) Report > Merging [#1620](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=desc) (0d63a7c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc) (38cf0ba) will **decrease** coverage by `4.25%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1620 +/- ## == - Coverage 71.65% 67.39% -4.26% == Files 133 47 -86 Lines5429 3113-2316 Branches 5920 -592 == - Hits 3890 2098-1792 + Misses 1296 769 -527 - Partials 243 246 +3 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `47.99% <ø> (+0.64%)` | :arrow_up: | | backend-unit-test | `51.77% <ø> (+0.54%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-9.65%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.34% <0.00%> (-1.21%)` | :arrow_down: | | ... and [88 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=footer). Last update [38cf0ba...0d63a7c](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1597: test: add the create and delete plugin in drawer
guoqqqi commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803246224 CI error: https://github.com/apache/apisix-dashboard/pull/1597/checks?check_run_id=2148899222 This CI error has been fixed in #1584. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (8093edb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `0.54%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1558 +/- ## == - Coverage 71.69% 71.15% -0.55% == Files 133 47 -86 Lines5469 3113-2356 Branches 5920 -592 == - Hits 3921 2215-1706 + Misses 1305 654 -651 - Partials 243 244 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.80% <ø> (+0.06%)` | :arrow_up: | | backend-e2e-test-ginkgo | `47.99% <ø> (+0.12%)` | :arrow_up: | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | | | [web/src/services/tool.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9zZXJ2aWNlcy90b29sLnRz) | | | | [.../src/pages/User/components/LoginMethodPassword.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL2NvbXBvbmVudHMvTG9naW5NZXRob2RQYXNzd29yZC50c3g=) | | | | [web/src/global.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9nbG9iYWwudHN4) | | | | [.../components/PluginOrchestration/DrawPluginStyle.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vRHJhd1BsdWdpblN0eWxlLnRz) | | | | [...b/src/pages/User/components/LoginMethodExample.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL2NvbXBvbmVudHMvTG9naW5NZXRob2RFeGFtcGxlLnRzeA==) | | | | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [web/src/pages/Consumer/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9zZXJ2aWNlLnRz) | | | | [...pages/Route/components/CreateStep4/CreateStep4.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0NyZWF0ZVN0ZXA0L0NyZWF0ZVN0ZXA0LnRzeA==) | | | | [web/src/pages/Route/components/Step1/MetaView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01ldGFWaWV3LnRzeA==) | | | | ... and [76 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [1ba32d9...8093edb](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (8093edb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `4.26%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1558 +/- ## == - Coverage 71.69% 67.42% -4.27% == Files 133 47 -86 Lines5469 3113-2356 Branches 5920 -592 == - Hits 3921 2099-1822 + Misses 1305 767 -538 - Partials 243 247 +4 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `47.99% <ø> (+0.12%)` | :arrow_up: | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | | | ... and [85 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [1ba32d9...8093edb](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock
codecov-io edited a comment on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=h1) Report > Merging [#1620](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=desc) (0d63a7c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc) (38cf0ba) will **decrease** coverage by `19.87%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1620 +/- ## === - Coverage 71.65% 51.77% -19.88% === Files 133 38 -95 Lines5429 2650 -2779 Branches 5920 -592 === - Hits 3890 1372 -2518 + Misses 1296 1090 -206 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.77% <ø> (+0.54%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [119 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=footer). Last update [38cf0ba...0d63a7c](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (8093edb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `19.88%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1558 +/- ## === - Coverage 71.69% 51.81% -19.89% === Files 133 38 -95 Lines5469 2650 -2819 Branches 5920 -592 === - Hits 3921 1373 -2548 + Misses 1305 1089 -216 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [117 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [1ba32d9...8093edb](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed pull request #1622: chore: support Netlify
juzhiyuan closed pull request #1622: URL: https://github.com/apache/apisix-dashboard/pull/1622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1622: chore: support Netlify
juzhiyuan commented on pull request #1622: URL: https://github.com/apache/apisix-dashboard/pull/1622#issuecomment-803241104 closed due to https://github.com/apache/apisix-dashboard/pull/1620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] JackLiMEM opened a new issue #1623: create route error
JackLiMEM opened a new issue #1623: URL: https://github.com/apache/apisix-dashboard/issues/1623  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch juzhiyuan-patch-1 updated (35a0483 -> 52d99e3)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 35a0483 chore: support Netlify add 52d99e3 Update netlify.toml No new revisions were added by this update. Summary of changes: netlify.toml | 5 + 1 file changed, 5 insertions(+)
[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1622: chore: support Netlify
juzhiyuan opened a new pull request #1622: URL: https://github.com/apache/apisix-dashboard/pull/1622 Please answer these questions before submitting a pull request **Why submit this pull request?** - [x] New feature provided support Netlify to preview FE PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch juzhiyuan-patch-1 created (now 35a0483)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 35a0483 chore: support Netlify This branch includes the following new commits: new 35a0483 chore: support Netlify The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[apisix-dashboard] 01/01: chore: support Netlify
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch juzhiyuan-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
commit 35a0483d37fda040ec8332931d35f06eb8a64384
Author: 琚致远
AuthorDate: Sat Mar 20 11:46:38 2021 +0800
chore: support Netlify
---
netlify.toml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/netlify.toml b/netlify.toml
new file mode 100644
index 000..e7fc7a7
--- /dev/null
+++ b/netlify.toml
@@ -0,0 +1,6 @@
+[[redirects]]
+ from = "/apisix/admin/*"
+ to = "http://139.217.190.60/apisix/admin/:splat;
+ status = 200
+ force = true
+ headers = {X-From = "Netlify"}
[GitHub] [apisix-dashboard] batman-ezio commented on a change in pull request #1558: feat:Support duplicate one existing Route
batman-ezio commented on a change in pull request #1558:
URL: https://github.com/apache/apisix-dashboard/pull/1558#discussion_r598056887
##
File path: web/config/routes.ts
##
@@ -39,6 +39,10 @@ const routes = [
path: '/routes/:rid/edit',
component: './Route/Create',
},
+ {
+path: '/routes/:rid/duplicate',
Review comment:
@guoqqqi I sync from master after your PR merged, but still failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 edited a comment on pull request #263: feat: broken link checker script
bzp2010 edited a comment on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803233610 > `.lua` to github original file 樂 I need to try. Due to the problem of not copying other files, the correct file location relationship may not be established. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on pull request #263: feat: broken link checker script
bzp2010 commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803233610 > `.lua` to github original file 樂 I need to try. Due to problems other than documents that are not copied, the correct file location relationship may not be established. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander edited a comment on issue #3865: bug: Routing priority matching bug
spacewander edited a comment on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-803232266 The default router (radixtree_uri) is a path first, host second matcher. If you prefer host first, path second, you can switch to `radixtree_host_uri`: https://github.com/apache/apisix/blob/1064e2d4b7edcc6f590ca69dc34a100ae6bbc12c/conf/config-default.yaml#L96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3865: bug: Routing priority matching bug
spacewander commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-803232266 The default router (radixtree_uri) is a path first, host second matcher. If you prefer a host first, path second, you can switch to `radixtree_host_uri`: https://github.com/apache/apisix/blob/1064e2d4b7edcc6f590ca69dc34a100ae6bbc12c/conf/config-default.yaml#L96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #263: feat: broken link checker script
juzhiyuan commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803231601 `.lua` to github original file 樂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3859: request help: Error: Could not satisfy dependency lua-resty-hmac-ffi 0.05: No results matching query were found for Lua 5.3. make: *** [Makefile
Firstsawyou commented on issue #3859: URL: https://github.com/apache/apisix/issues/3859#issuecomment-803231281 The installation of lua-resty-hmac-ffi depends on lua 5.1, try to install lua 5.1 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on pull request #263: feat: broken link checker script
bzp2010 commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803230175 > yes, could we redirect users to the original site? (apisix's GitHub I mean) Redirect no `.md` files to GitHub page? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #263: feat: broken link checker script
juzhiyuan commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803227996 yes, could we redirect users to the original site? (apisix's GitHub I mean) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3873: docs: add more example about how to use the router `radixtree-uri`
membphis commented on issue #3873: URL: https://github.com/apache/apisix/issues/3873#issuecomment-803227176 related issue https://github.com/apache/apisix/issues/3865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis opened a new issue #3873: docs: add more example about how to use the router `radixtree-uri`
membphis opened a new issue #3873: URL: https://github.com/apache/apisix/issues/3873 for examples: > eg: 1. different routes with the same values. 2. different routes with the same URI, eg: `/*`. 3. different routes with different URI, eg: `/test/*`, `/*`. help the user to know how to use APISIX -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 edited a comment on pull request #263: feat: broken link checker script
bzp2010 edited a comment on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803226396 Those `.lua` files were not copied to the document directory, which prevented it from being checked. Therefore, it will be regarded as a broken link. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on pull request #263: feat: broken link checker script
bzp2010 commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803226396 Those `.lua` files were not copied to the document directory, which prevented it from being checked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3865: bug: Routing priority matching bug
membphis commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-803225177 this is not a bug. I confirmed. @ShaoZeMing the router `a`, `b`, `c` have same uri `/*` and `priority`, you'd better to specify a different `priority`. `/test/*` always matches before `/*`. The route `radixtree_uri` matching of apisix is depth-first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] anyforever commented on issue #3859: request help: Error: Could not satisfy dependency lua-resty-hmac-ffi 0.05: No results matching query were found for Lua 5.3. make: *** [Makefile:
anyforever commented on issue #3859: URL: https://github.com/apache/apisix/issues/3859#issuecomment-803224899 我也出现这个问题，Centos 8下编译。 开始装的lua 5.4，提示不行，退回了5.3，然后 $ cd apisix $ make deps 时，出现此报错 ` Error: Could not satisfy dependency lua-resty-hmac-ffi 0.05: No results matching query were found for Lua 5.3. make: *** [Makefile:67: deps] Error 1 ` 我直接安装这个依赖，也是如此 [root@Centos apisix-2.4]# luarocks install lua-resty-hmac-ffi Error: No results matching query were found for Lua 5.3. To check if it is available for other Lua versions, use --check-lua-versions. 搜到了依赖项的页面，标的是lua 5.1 http://luarocks.org/modules/jkeys089/lua-resty-hmac-ffi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1619: fix: (route_online_debug)Change the appended Content-type data to overlay to ensure that the Content-type is unique
liuxiran edited a comment on pull request #1619: URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-803208395 mark fe e2e errors: * search route error: https://github.com/apache/apisix-dashboard/pull/1619/checks?check_run_id=2146696140 * create-edit-delete consumer error: https://github.com/apache/apisix-dashboard/pull/1619/checks?check_run_id=2150934899 fixed by two test commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (fda5d75) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `0.54%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1558 +/- ## == - Coverage 71.69% 71.15% -0.55% == Files 133 47 -86 Lines5469 3113-2356 Branches 5920 -592 == - Hits 3921 2215-1706 + Misses 1305 654 -651 - Partials 243 244 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.86% <ø> (+0.12%)` | :arrow_up: | | backend-e2e-test-ginkgo | `47.99% <ø> (+0.12%)` | :arrow_up: | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | | | [web/src/pages/Upstream/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9zZXJ2aWNlLnRz) | | | | [...eb/src/components/PluginOrchestration/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY29uc3RhbnRzLnRz) | | | | [web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=) | | | | [...eb/src/pages/PluginTemplate/components/Preview.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1ByZXZpZXcudHN4) | | | | [web/src/pages/Upstream/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9DcmVhdGUudHN4) | | | | [web/src/components/Plugin/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9zZXJ2aWNlLnRz) | | | | [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | | | | [...es/Route/components/DebugViews/DebugParamsView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdQYXJhbXNWaWV3LnRzeA==) | | | | [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | | | | ... and [76 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [1ba32d9...fda5d75](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (fda5d75) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `4.26%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1558 +/- ## == - Coverage 71.69% 67.42% -4.27% == Files 133 47 -86 Lines5469 3113-2356 Branches 5920 -592 == - Hits 3921 2099-1822 + Misses 1305 767 -538 - Partials 243 247 +4 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `47.99% <ø> (+0.12%)` | :arrow_up: | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | | | ... and [85 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [1ba32d9...fda5d75](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (fda5d75) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **decrease** coverage by `19.88%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1558 +/- ## === - Coverage 71.69% 51.81% -19.89% === Files 133 38 -95 Lines5469 2650 -2819 Branches 5920 -592 === - Hits 3921 1373 -2548 + Misses 1305 1089 -216 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [117 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [1ba32d9...fda5d75](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1619: fix: (route_online_debug)Change the appended Content-type data to overlay to ensure that the Content-type is unique
liuxiran commented on pull request #1619: URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-803208395 mark fe e2e errors: * search route error: https://github.com/apache/apisix-dashboard/pull/1619/checks?check_run_id=2146696140 * create-edit-delete consumer error: https://github.com/apache/apisix-dashboard/pull/1619/checks?check_run_id=2150934899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on issue #3865: bug: Routing priority matching bug
moonming commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-803185212 @membphis @spacewander please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1303: Doc: a better doc about how to write and run e2e test and unit test for Backend
bisakhmondal commented on issue #1303: URL: https://github.com/apache/apisix-dashboard/issues/1303#issuecomment-802965217 Thank you for addressing this. Sure, I'll definitely put down the information as much elaborative as I can. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1303: Doc: a better doc about how to write and run e2e test and unit test for Backend
nic-chen commented on issue #1303: URL: https://github.com/apache/apisix-dashboard/issues/1303#issuecomment-802948252 hi, @bisakhmondal Thanks for working on this issue! > Currently the environment setup with docker-compose is not elaborative (back-end-e2e.md), I am thinking of updating along with adding a bash script to automate the workflow. that's great. > For unit testing, we are using golang's native testing framework (that includes working with mockInterfaces, I think which needs some explanation) & for e2e, how should we introduce that into docs about the ginkgo stuff for the new? About unit testing, I think mocking and how to run tests are two points that need to be described clearly. About e2e testing, just point out that the ginkgo framework should be used to write cases. Other details, I think you could write according to your thoughts. The more detailed the better, especially you have just participated in the development of the dashboard not long ago, it is easier to consider the content that newcomers want to know more. : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module
codecov-io edited a comment on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-795836615 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=h1) Report > Merging [#1576](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=desc) (72a9b9b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/f4f27d1a7b2f2a712c15dd922a30afd7e5d671db?el=desc) (f4f27d1) will **decrease** coverage by `19.96%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1576 +/- ## === - Coverage 71.77% 51.81% -19.97% === Files 133 38 -95 Lines5471 2650 -2821 Branches 5920 -592 === - Hits 3927 1373 -2554 + Misses 1301 1089 -212 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [113 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=footer). Last update [f4f27d1...72a9b9b](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1576: fix: config proxy-rewrite out of the plugin market in route module
liuxiran commented on a change in pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576#discussion_r597786636
##
File path: web/src/pages/Route/Create.tsx
##
@@ -93,6 +95,10 @@ const Page: React.FC = (props) => {
}
}, []);
+ const getProxyrewriteEnable =() => {
Review comment:
fixed, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1612: add more fe e2e test cases for online debug
liuxiran commented on pull request #1612: URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-802923650 > still failed https://github.com/apache/apisix-dashboard/pull/1612/checks?check_run_id=2146684625 yep, just waiting for #1619, which has another fe e2e test failed, need some time to take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #263: feat: broken link checker script
juzhiyuan commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-802919989 I noticed that there have some files end with `.lua` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1576: fix: config proxy-rewrite out of the plugin market in route module
juzhiyuan commented on a change in pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576#discussion_r597774968
##
File path: web/src/pages/Route/Create.tsx
##
@@ -93,6 +95,10 @@ const Page: React.FC = (props) => {
}
}, []);
+ const getProxyrewriteEnable =() => {
Review comment:
More like a spelling issue 樂 but not hurry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1612: add more fe e2e test cases for online debug
juzhiyuan commented on pull request #1612: URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-802918581 still failed https://github.com/apache/apisix-dashboard/pull/1612/checks?check_run_id=2146684625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou edited a comment on issue #3865: bug: Routing priority matching bug
Firstsawyou edited a comment on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802893821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1303: Doc: a better doc about how to write and run e2e test and unit test for Backend
juzhiyuan commented on issue #1303: URL: https://github.com/apache/apisix-dashboard/issues/1303#issuecomment-802916573 cc @nic-chen @starsz to help @bisakhmondal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1303: Doc: a better doc about how to write and run e2e test and unit test for Backend
bisakhmondal commented on issue #1303: URL: https://github.com/apache/apisix-dashboard/issues/1303#issuecomment-802913757 Hey guys!! Interested in working on this issue. Could you please elaborate, how do we wish to help the newcomer? for eg. 1. Currently the environment setup with docker-compose is not elaborative (`back-end-e2e.md`), I am thinking of updating along with adding a bash script to automate the workflow. 2. For unit testing, we are using golang's native testing framework (that includes working with mockInterfaces, I think which needs some explanation) & for e2e, how should we introduce that into docs about the ginkgo stuff for the new? Please share your thoughts. Thank you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1604: fix: fix the button margin space
codecov-io commented on pull request #1604: URL: https://github.com/apache/apisix-dashboard/pull/1604#issuecomment-802904399 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1604?src=pr=h1) Report > Merging [#1604](https://codecov.io/gh/apache/apisix-dashboard/pull/1604?src=pr=desc) (f6534da) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc) (1ba32d9) will **increase** coverage by `0.97%`. > The diff coverage is `87.50%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1604?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1604 +/- ## == + Coverage 71.69% 72.66% +0.97% == Files 133 86 -47 Lines5469 2356-3113 Branches 592 592 == - Hits 3921 1712-2209 + Misses 1305 644 -661 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `72.66% <87.50%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1604?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/pages/Upstream/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1604/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9MaXN0LnRzeA==) | `90.00% <87.50%> (ø)` | | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1604/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | | | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1604/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1604/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1604/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | | | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1604/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | | | | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1604/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1604/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | | | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1604/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | | | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1604/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | | | ... and [39 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1604/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1604?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1604?src=pr=footer). Last update [1ba32d9...f6534da](https://codecov.io/gh/apache/apisix-dashboard/pull/1604?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3865: bug: Routing priority matching bug
Firstsawyou commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802893821 Hi, @ShaoZeMing Thank you for your report. After testing, I found that there are problems with the use of `hsot + header` and `host` when different routes have the same uri. Assuming that the route response data of `host` is `a`, and the route response data of `hsot + header` is `b`, then there are two situations: 1. When the route id of `host` is greater than the route id of `hsot + header`, the result of the request is normal. 2. When the route id of `host` is less than the route id of `hsot + header`, the result of the request is abnormal, and all response data is `a`. We need to fix this bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1597: test: add the create and delete plugin in drawer
guoqqqi commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-802855150 Hi,you can find it in the Create, Configure Plugin step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on pull request #1597: test: add the create and delete plugin in drawer
stu01509 commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-802847983 > Hi, We need to test the functionality not only on the plug-in page but also on the route page and the service page to make sure it works. Hi Actually, I only found it the plugin page, where could I find in the route page and services page? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3871: docs: admin-api.md document adds configuration https example
moonming commented on a change in pull request #3871: URL: https://github.com/apache/apisix/pull/3871#discussion_r597679185 ## File path: docs/en/latest/admin-api.md ## @@ -657,12 +659,32 @@ After the execution is successful, nodes will not retain the original data, and ``` +Example 2: Create upstream and configure the scheme as `https`. Review comment: This is an example of proxying to upstream https ## File path: docs/en/latest/admin-api.md ## @@ -657,12 +659,32 @@ After the execution is successful, nodes will not retain the original data, and ``` +Example 2: Create upstream and configure the scheme as `https`. + +```shell +# Create upstream and configure the scheme as `https` Review comment: We need a complete example, from apisix configuration to client access -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #1576: fix: config proxy-rewrite out of the plugin market in route module
bzp2010 commented on a change in pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576#discussion_r597677125
##
File path: web/src/pages/Route/Create.tsx
##
@@ -93,6 +95,10 @@ const Page: React.FC = (props) => {
}
}, []);
+ const getProxyrewriteEnable =() => {
Review comment:
This should be `getProxyRewriteEnable` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on pull request #263: feat: broken link checker script
bzp2010 commented on pull request #263:
URL: https://github.com/apache/apisix-website/pull/263#issuecomment-802828050
Updated 2021-3-19
- add local markdown file checking function
Tips
- links starting with `http://` or `https://` and ending with `.md` are
checked
Problem
Is there anything else to add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1584: feat: save Service list page's meta status
codecov-io edited a comment on pull request #1584: URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-797880776 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=h1) Report > Merging [#1584](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=desc) (6422b94) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc) (38cf0ba) will **increase** coverage by `0.98%`. > The diff coverage is `80.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1584 +/- ## == + Coverage 71.65% 72.64% +0.98% == Files 133 86 -47 Lines5429 2405-3024 Branches 592 606 +14 == - Hits 3890 1747-2143 + Misses 1296 658 -638 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `72.64% <80.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==) | `85.18% <71.42%> (-4.82%)` | :arrow_down: | | [web/src/pages/PluginTemplate/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9MaXN0LnRzeA==) | `72.50% <71.42%> (-0.23%)` | :arrow_down: | | [web/src/pages/SSL/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TU0wvTGlzdC50c3g=) | `84.00% <71.42%> (-4.89%)` | :arrow_down: | | [web/src/pages/Upstream/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9MaXN0LnRzeA==) | `85.18% <71.42%> (-4.82%)` | :arrow_down: | | [web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==) | `83.09% <75.00%> (-0.61%)` | :arrow_down: | | [web/src/pages/Plugin/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW4vTGlzdC50c3g=) | `94.23% <100.00%> (+0.89%)` | :arrow_up: | | [web/src/pages/Service/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0xpc3QudHN4) | `96.15% <100.00%> (+1.41%)` | :arrow_up: | | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `77.04% <0.00%> (-3.28%)` | :arrow_down: | | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `75.38% <0.00%> (-1.54%)` | :arrow_down: | | [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | | | ... and [46 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=footer). Last update [38cf0ba...6422b94](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3871: docs: admin-api.md document adds configuration https example
juzhiyuan commented on a change in pull request #3871:
URL: https://github.com/apache/apisix/pull/3871#discussion_r597657304
##
File path: docs/en/latest/admin-api.md
##
@@ -571,12 +571,16 @@ Config Example:
"key": "",
"name": "upstream-for-test",
"desc": "hello world",
+"scheme":"http",# The scheme used when communicating with
upstream, the default is `http`
Review comment:
```suggestion
"scheme": "http",# The scheme used when communicating with
upstream, the default is `http`
```
##
File path: docs/zh/latest/admin-api.md
##
@@ -578,15 +578,18 @@ upstream 对象 json 配置内容：
"checks": {}, # 配置健康检查的参数
"hash_on": "",
"key": "",
-"name": "upstream-xxx", # upstream 名称
+"name": "upstream-xxx", # upstream 名称
"desc": "hello world", # upstream 描述
+"scheme":"http" # 跟上游通信时使用的 scheme，默认是 `http`
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1482: how to delete the historical version of the APISIX node.
juzhiyuan commented on issue #1482: URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802814756 Good design But I'm still concerned if we have necessary to add this API? let's wait for others :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1589: feat: searching upstream by users input while creating new routes
juzhiyuan commented on pull request #1589: URL: https://github.com/apache/apisix-dashboard/pull/1589#issuecomment-802813367 > > LGTM for the code , it would be better to add test case for this nice new feature > > Thanks. Yeah, it's a nice but really minor addition to the codebase. Hey guys what do you think? Agree :) Not urgent IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1601: feat: add rawDataEditor in route
juzhiyuan commented on pull request #1601: URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-802813000 also cc @guoqqqi to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1597: test: add the create and delete plugin in drawer
juzhiyuan commented on a change in pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#discussion_r597654278
##
File path: web/cypress/integration/plugin/create-delete-in-drawer-plugin.spec.js
##
@@ -45,7 +45,6 @@ context('Create and Delete Plugin List', () => {
.then(() => {
cy.get('.ant-drawer-footer').contains('button', 'Delete').click();
cy.contains('button', 'Confirm').click({ force: true });
-cy.get(this.domSelector.empty).should('be.visible');
});
Review comment:
any update here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #3865: bug: Routing priority matching bug
juzhiyuan commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802810667 @ShaoZeMing Thanks for your report, that's the data we need. @Firstsawyou will follow and reply to this issue once he finds out what happened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1620: feat: update yarn.lock
juzhiyuan commented on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802809346 Once this PR merged, Netlify will pass. This PR mainly fixes the wrong download links in yarn.lock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1620: feat: update yarn.lock
juzhiyuan commented on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802808974 @nic-chen @LiteSun Hi, Netlify is not required before merging. Please fix the FE E2E first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] guoqqqi closed pull request #265: feat: added the ApacheCon in APISIX
guoqqqi closed pull request #265: URL: https://github.com/apache/apisix-website/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] guoqqqi opened a new pull request #265: feat: added the ApacheCon in APISIX
guoqqqi opened a new pull request #265: URL: https://github.com/apache/apisix-website/pull/265 Changes: added the ApacheCon in APISIX.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1584: feat: save Service list page's meta status
codecov-io edited a comment on pull request #1584: URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-797880776 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=h1) Report > Merging [#1584](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=desc) (252a92a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc) (38cf0ba) will **decrease** coverage by `19.84%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1584 +/- ## === - Coverage 71.65% 51.81% -19.85% === Files 133 38 -95 Lines5429 2650 -2779 Branches 5920 -592 === - Hits 3890 1373 -2517 + Misses 1296 1089 -207 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (+0.58%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [112 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=footer). Last update [38cf0ba...252a92a](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3848: feat: add dump for consul_kv
spacewander commented on a change in pull request #3848:
URL: https://github.com/apache/apisix/pull/3848#discussion_r597598980
##
File path: apisix/discovery/consul_kv.lua
##
@@ -244,7 +244,7 @@ end
local function read_dump_srvs()
local data, err = util.read_file(dump_params.path)
if not data then
-log.warn("read dump file get error: ", err)
+log.notice("read dump file get error: ", err)
Review comment:
@yongboy
We just add the heavy library in the master branch:
https://github.com/apache/apisix/blob/1064e2d4b7edcc6f590ca69dc34a100ae6bbc12c/rockspec/apisix-master-0.rockspec#L68.
Would be fine if we can find another usage of this library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi opened a new issue #1621: feat: Related
guoqqqi opened a new issue #1621: URL: https://github.com/apache/apisix-dashboard/issues/1621 # Feature request Related #1584 Currently, a paginator has been added to each listing page and it is hoped that this state paginator can be made into a component that can be easily called from each listing page, once it is completed we need to add test cases to it. TODO: - [ ] Making the list page paginator a standalone component - [ ] Adding front-end E2E testing  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3865: bug: Routing priority matching bug
Firstsawyou commented on issue #3865: URL: https://github.com/apache/apisix/issues/3865#issuecomment-802756878 > Hi, Here are the routing rules a, b, c, d @ShaoZeMing Thank you for the information, I will reproduce it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1615: feat: manual deletion of apisix node data
bisakhmondal commented on a change in pull request #1615:
URL: https://github.com/apache/apisix-dashboard/pull/1615#discussion_r597597026
##
File path: api/test/e2e/server_info_delete_test.go
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package e2e
+
+import (
+ "net/http"
+ "testing"
+)
+
Review comment:
Hey @starsz, Thanks for the suggestion but no, sadly it won't make any
difference. Okay, I am trying my best to explain it again. They way ginkgo
works, when we put any `table.Entry` inside `Describe` block, ginkgo
internally reduces it the same as `It` block. ginkgo blocks/holds the execution
of any tests until it has collected all the `It` blocks and formed a parse tree
kind of thing (you can check the behaviour locally by putting a time.Sleep("any
large seconds") just after any `ginkgo.Describe` block, not a single test will
run until all `It`s are available to be executed on that test suite). All `It`
blocks are treated as single individual independent test entities. And then
ginkgo runs all the tests (`It` blocks) in parallel/concurrently (in a
nutshell, all `table.Entry`s will be run in parallel no matter where we keep it
in the test suite).
Hope it helps. Thanks again :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1620: feat: update yarn.lock
LiteSun commented on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802755794 >  > > These checks suddenly appear today and every time it fails. > Could we remove them? @LiteSun ping @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1482: how to delete the historical version of the APISIX node.
nic-chen commented on issue #1482: URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802751148 @bisakhmondal Great! Thanks for sharing your thoughts. I think we can discuss further. But in version 2.5 we could prompt the user first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1584: feat: save Service list page's meta status
guoqqqi commented on a change in pull request #1584:
URL: https://github.com/apache/apisix-dashboard/pull/1584#discussion_r597591311
##
File path: web/cypress/integration/service/save-paginator-status.spec.js
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Save Paginator Status', () => {
+ const timeout = 300;
+ beforeEach(() => {
+cy.login();
+
+cy.fixture('selector.json').as('domSelector');
+cy.fixture('data.json').as('data');
+ });
+
+ it('should create 11 test services', function () {
+cy.visit('/');
+cy.contains('Service').click();
+
+for (let i = 0; i <= 10; i++) {
+ cy.contains('Create').click();
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #3871: docs: admin-api.md document adds configuration https example
Firstsawyou commented on pull request #3871: URL: https://github.com/apache/apisix/pull/3871#issuecomment-802747734 @moonming Please have a look when you are free. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1615: feat: manual deletion of apisix node data
nic-chen commented on a change in pull request #1615: URL: https://github.com/apache/apisix-dashboard/pull/1615#discussion_r597591008 ## File path: api/test/e2e/server_info_delete_test.go ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package e2e + +import ( + "net/http" + "testing" +) + Review comment: In fact, our test cases are not executed parallelly by default. You could refer to other test cases that have been written. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1620: feat: update yarn.lock
nic-chen commented on pull request #1620: URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802739969  These checks suddenly appear today and every time it fails. Could we remove them? @LiteSun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1597: test: add the create and delete plugin in drawer
nic-chen commented on pull request #1597: URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-802733202 ping @stu01509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ShaoZeMing commented on issue #3865: bug: Routing priority matching bug
ShaoZeMing commented on issue #3865:
URL: https://github.com/apache/apisix/issues/3865#issuecomment-802732450
Hi, Here are the routing rules a, b, c, d
router a：
```
{
"code":0,
"message":"",
"data":{
"id":"346524199914832835",
"create_time":1616074118,
"update_time":1616118098,
"uris":[
"/*"
],
"name":"test_host",
"desc":"测试仅只有host",
"methods":[
"GET"
],
"hosts":[
"test-dev-1.apisix.xthktech.cn"
],
"vars":[
],
"plugins":{
"jwt-auth":{
"disable":false
}
},
"upstream_id":"341144078647297023",
"labels":{
"API_VERSION":"v0.0.1"
},
"status":1
},
"request_id":"3db8e16d-0346-4066-9dc9-e81a64d2a750"
}
```
- router b ：
```
{
"code":0,
"message":"",
"data":{
"id":"346524374901195715",
"create_time":1616074222,
"update_time":1616118115,
"uris":[
"/*"
],
"name":"test_host_header",
"desc":"测试同时有host+header(app-name:test-header)",
"methods":[
"GET"
],
"hosts":[
"test-dev-1.apisix.xthktech.cn"
],
"vars":[
[
"http_app-name",
"==",
"test-header"
]
],
"plugins":{
"hmac-auth":{
"disable":false
}
},
"upstream_id":"341144078647297023",
"labels":{
"API_VERSION":"v0.0.1"
},
"status":1
},
"request_id":"c1e232c2-2aa3-4da9-abd0-34a3191c31d9"
}
```
- router c ：
```
{
"code":0,
"message":"",
"data":{
"id":"346525280149439427",
"create_time":1616074762,
"update_time":1616118134,
"uris":[
"/*"
],
"name":"test_header",
"desc":"测试只有header(app-name:test-header) ",
"methods":[
"GET"
],
"vars":[
[
"http_app-name",
"==",
"test-header"
]
],
"plugins":{
"key-auth":{
"disable":false
}
},
"upstream_id":"341144078647297023",
"labels":{
"API_VERSION":"v0.0.1"
},
"status":1
},
"request_id":"f0f019f4-9edb-4457-8e66-ec4feba5aec0"
}
```
- router d :
```
{
"code":0,
"message":"",
"data":{
"id":"346598189450658703",
"create_time":1616118219,
"update_time":1616118237,
"uris":[
"/test/*"
],
"name":"test_path",
"methods":[
"GET"
],
"vars":[
],
"plugins":{
"basic-auth":{
"disable":false
}
},
"upstream_id":"341144078647297023",
"status":1
},
"request_id":"5c2fbd70-0846-47fc-9e81-b3e94373c27c"
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1584: feat: save Service list page's meta status
nic-chen commented on a change in pull request #1584:
URL: https://github.com/apache/apisix-dashboard/pull/1584#discussion_r597570655
##
File path: web/cypress/integration/service/save-paginator-status.spec.js
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Save Paginator Status', () => {
+ const timeout = 300;
+ beforeEach(() => {
+cy.login();
+
+cy.fixture('selector.json').as('domSelector');
+cy.fixture('data.json').as('data');
+ });
+
+ it('should create 11 test services', function () {
+cy.visit('/');
+cy.contains('Service').click();
+
+for (let i = 0; i <= 10; i++) {
+ cy.contains('Create').click();
Review comment:
ping @guoqqqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
