[GitHub] [apisix-dashboard] ericsyh commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
ericsyh commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823798761 ok for close the issue. But i am quite interesting in what scenario that users will create a upstream with empty node list? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] KishaniKandasamy commented on pull request #1807: docs: add correct custom IDs to links
KishaniKandasamy commented on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823797345 > hi @KishaniKandasamy > I am updating api doc and that will be a big update. > I think we don't need to update this file now. Okay:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
liuxiran commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823786050 @juzhiyuan @nic-chen keep the current behavior is also reasonable for me If there is no objection, we will close the issue cc @ericsyh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Firstsawyou commented on issue #1796: 关于路由/*有效，/foo/*无效
Firstsawyou commented on issue #1796: URL: https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823784682 You can also try to configure it like this in Dashboard: https://user-images.githubusercontent.com/52862365/115500683-62272180-a2a4-11eb-96d7-d5789b7e7e46.png;> https://user-images.githubusercontent.com/52862365/115500706-6ce1b680-a2a4-11eb-89a5-2adde9de8d26.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1667](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (57bd49d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bec8f1b) will **decrease** coverage by `0.57%`. > The diff coverage is `68.42%`. > :exclamation: Current head 57bd49d differs from pull request most recent head 27876cf. Consider uploading reports for the commit 27876cf to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1667 +/- ## == - Coverage 72.48% 71.91% -0.58% == Files 133 125 -8 Lines5728 2948-2780 Branches 666 713 +47 == - Hits 4152 2120-2032 + Misses 1332 828 -504 + Partials 2440 -244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `71.91% <68.42%> (-2.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/RightContent/AvatarDropdown.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9BdmF0YXJEcm9wZG93bi50c3g=) | `82.14% <ø> (ø)` | | | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <ø> (-11.48%)` | :arrow_down: | | [web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==) | `90.00% <ø> (ø)` | | | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | `100.00% <ø> (ø)` | | | [web/src/pages/PluginTemplate/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | `39.13% <ø> (-2.54%)` | :arrow_down: | | [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | | | [web/src/pages/Route/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9zZXJ2aWNlLnRz) | `88.23% <ø> (-0.66%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1788: feat: embed assets in api binary
bisakhmondal commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-823779141 > hi @bisakhmondal > I think we should also embed `dag-to-lua`, see: > https://github.com/apache/apisix-dashboard/blob/master/api/build.sh#L38-L42 Okay. Let me have a look. I'll update it accordingly. Thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] hzbd closed issue #1811: The manager-api and apache apisix are mismatched?
hzbd closed issue #1811: URL: https://github.com/apache/apisix-dashboard/issues/1811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1667](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (27876cf) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bec8f1b) will **decrease** coverage by `1.90%`. > The diff coverage is `42.30%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1667 +/- ## == - Coverage 72.48% 70.58% -1.91% == Files 133 48 -85 Lines5728 3233-2495 Branches 6660 -666 == - Hits 4152 2282-1870 + Misses 1332 699 -633 - Partials 244 252 +8 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.11% <42.30%> (-2.41%)` | :arrow_down: | | backend-e2e-test-ginkgo | `48.65% <42.30%> (+0.61%)` | :arrow_up: | | backend-unit-test | `52.40% <ø> (+0.59%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/cmd/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zZXJ2aWNlLmdv) | `13.51% <13.51%> (ø)` | | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `52.54% <53.76%> (-6.92%)` | :arrow_down: | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <0.00%> (-2.82%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `91.07% <0.00%> (-0.42%)` | :arrow_down: | | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | | | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | | | | [...rc/components/PluginOrchestration/customConfig.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY3VzdG9tQ29uZmlnLnRzeA==) | | | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1705: fix: detailed error for store init failure and deferred execution of closers
codecov-commenter edited a comment on pull request #1705: URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-821808163 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1705](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8c21565) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.02%`. > The diff coverage is `76.92%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1705 +/- ## == + Coverage 71.78% 71.81% +0.02% == Files 172 172 Lines6100 6106 +6 Branches 713 713 == + Hits 4379 4385 +6 + Misses 1478 1477 -1 - Partials 243 244 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.70% <53.84%> (+0.13%)` | :arrow_up: | | backend-e2e-test-ginkgo | `49.17% <53.84%> (+0.06%)` | :arrow_up: | | backend-unit-test | `52.42% <100.00%> (+0.01%)` | :arrow_up: | | frontend-e2e-test | `71.98% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `59.49% <70.00%> (+0.03%)` | :arrow_up: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `88.09% <100.00%> (-1.13%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1705/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.27% <0.00%> (+3.63%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [4590801...8c21565](https://codecov.io/gh/apache/apisix-dashboard/pull/1705?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1667](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (27876cf) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bec8f1b) will **decrease** coverage by `5.70%`. > The diff coverage is `42.30%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1667 +/- ## == - Coverage 72.48% 66.78% -5.71% == Files 133 48 -85 Lines5728 3233-2495 Branches 6660 -666 == - Hits 4152 2159-1993 + Misses 1332 803 -529 - Partials 244 271 +27 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.11% <42.30%> (-2.41%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.40% <ø> (+0.59%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/cmd/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zZXJ2aWNlLmdv) | `13.51% <13.51%> (ø)` | | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `52.54% <53.76%> (-6.92%)` | :arrow_down: | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `56.92% <0.00%> (-19.01%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `81.25% <0.00%> (-18.75%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `40.00% <0.00%> (-10.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1667](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (27876cf) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bec8f1b) will **decrease** coverage by `20.07%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1667 +/- ## === - Coverage 72.48% 52.40% -20.08% === Files 133 39 -94 Lines5728 2740 -2988 Branches 6660 -666 === - Hits 4152 1436 -2716 + Misses 1332 1110 -222 + Partials 244 194 -50 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.40% <ø> (+0.59%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] nic-chen commented on issue #1810: style(fe): how about changing the navigation bar to dark?
nic-chen commented on issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-823775689 I We can directly try to see the modified effect. cc @LiteSun @juzhiyuan @liuxiran @guoqqqi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
netlify[bot] edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614 Deploy preview for *apisix-dashboard* processing. Building with commit 27876cf77506f9a89ea97a5e66ff8b7323c9bc6f https://app.netlify.com/sites/apisix-dashboard/deploys/607fb00c4b33810008bdba9b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1796: 关于路由/*有效，/foo/*无效
nic-chen commented on issue #1796: URL: https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823774884 > My back-end service is http://localhost:8080/api/user/get, I want to add /foo[/api/user/get] via apisix I think you could use the proxy-rewrite plugin to achieve your need: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/proxy-rewrite.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1667: feat: run manager-api as a systemd daemon/service
bisakhmondal commented on a change in pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617198607 ## File path: api/manager-api.service ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +[Unit] +Description=Manager-API service Review comment: Hi, the binary takes care of running itself as a service. Unit file for each platform isn't required anymore. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1667: feat: run manager-api as a systemd daemon/service
bisakhmondal commented on a change in pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617198292 ## File path: api/manager-api.service ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review comment: Hii, nope it's not required anymore. I forgot to clean it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1811: The manager-api and apache apisix are mismatched?
nic-chen commented on issue #1811: URL: https://github.com/apache/apisix-dashboard/issues/1811#issuecomment-823774139 hi @hzbd can't use Dashboard 2.5 with APISIX 2.5, need to wait for Dashboard 2.6. Dashboard 2.5 works with APISIX 2.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1807: docs: add correct custom IDs to links
nic-chen commented on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823771931 hi @KishaniKandasamy I am updating api doc and that will be a big update. I think we don't need to update this file now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] StretchV opened a new issue #4094: request help: How to configure apisix and dashboad if etcd turns on certificate authentication
StretchV opened a new issue #4094: URL: https://github.com/apache/apisix/issues/4094 ### Issue description ### Environment * apisix version (cmd: `apisix version`):2.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1705: fix: detailed error for store init failure and deferred execution of closers
netlify[bot] edited a comment on pull request #1705: URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-818713534 Deploy preview for *apisix-dashboard* processing. Building with commit 8c21565a846016227d47ca8280cfc911d581fe3b https://app.netlify.com/sites/apisix-dashboard/deploys/607facfb15016400084c7125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1788: feat: embed assets in api binary
nic-chen commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-823769178 hi @bisakhmondal I think we should also embed `dag-to-lua`, see: https://github.com/apache/apisix-dashboard/blob/master/api/build.sh#L38-L42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
nic-chen commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823768235 +1 for keeping the current behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on a change in pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617191937 ## File path: api/manager-api.service ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review comment: Do we still need this file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #4092: fix(traffic-split): when the rules array has multiple upstream conditions (weighted_upstreams + match), the request will be confused amon
Firstsawyou commented on pull request #4092: URL: https://github.com/apache/apisix/pull/4092#issuecomment-823762795 Related issues: https://github.com/apache/apisix/issues/4090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] hzbd opened a new issue #1811: The manager-api and apache apisix are mismatched?
hzbd opened a new issue #1811: URL: https://github.com/apache/apisix-dashboard/issues/1811 **Issue description** _Request Error Code: 201 The manager-api and apache apisix are mismatched._  **Environment** **CentOS 7.9** [root@xxx dashboard]# ./manager-api -v **Version : 2.5 GitHash : 5c95d97** [root@xxx dashboard]# apisix version **/usr/local/openresty/luajit/bin/luajit /usr/local/apisix/apisix/cli/apisix.lua version 2.5** [root@xxx dashboard]# openresty -v **nginx version: openresty/1.19.3.1** Is this a bug or is it a problem with my settings？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd closed issue #4093: bug: The manager-api and apache apisix are mismatched?
hzbd closed issue #4093: URL: https://github.com/apache/apisix/issues/4093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd commented on issue #4093: bug: The manager-api and apache apisix are mismatched?
hzbd commented on issue #4093: URL: https://github.com/apache/apisix/issues/4093#issuecomment-823753480 Maybe I should submit it to the apisix-dashboard side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hzbd opened a new issue #4093: bug: The manager-api and apache apisix are mismatched?
hzbd opened a new issue #4093: URL: https://github.com/apache/apisix/issues/4093 ### Issue description Request Error Code: 201 The manager-api and apache apisix are mismatched.  ### Environment **CentOS 7.9** [root@xxx dashboard]# ./manager-api -v **Version : 2.5 GitHash : 5c95d97** [root@xxx dashboard]# apisix version /usr/local/openresty/luajit/bin/luajit /usr/local/apisix/apisix/cli/apisix.lua version 2.5 [root@xxx dashboard]# openresty -v **nginx version: openresty/1.19.3.1** Is this a bug or is it a problem with my settings？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1667: feat: run manager-api as a systemd daemon/service
membphis commented on a change in pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617176088 ## File path: api/manager-api.service ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +[Unit] +Description=Manager-API service + +[Service] +Type=simple +Restart=on-failure +RestartSec=5 +WorkingDirectory=<"Your Directory">/apisix-dashboard/output Review comment: do we have created an issue about this when we build an RPM package? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1667: feat: run manager-api as a systemd daemon/service
membphis commented on a change in pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#discussion_r617175576 ## File path: api/manager-api.service ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +[Unit] +Description=Manager-API service Review comment: I think we should add the keyword "Apache APISIX" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] leon1509 edited a comment on issue #1796: 关于路由/*有效，/foo/*无效
leon1509 edited a comment on issue #1796: URL: https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823750668 My back-end service is http://localhost:8080/api/user/get, I want to add /foo[/api/user/get] via apisix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] leon1509 commented on issue #1796: 关于路由/*有效，/foo/*无效
leon1509 commented on issue #1796: URL: https://github.com/apache/apisix-dashboard/issues/1796#issuecomment-823750668 My back-end service is http://localhost:8080/api/user/get, I want to add /api/user/get via apisix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-823750638 @tokers @starsz please have a look again when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis opened a new issue #1810: style(fe): how about changing the navigation bar to dark?
membphis opened a new issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on pull request #159: feat: automate upload image to Dockerhub
gxthrj commented on pull request #159: URL: https://github.com/apache/apisix-docker/pull/159#issuecomment-823746325 I submitted an INFRA to discuss this matter. If Apache does not allow this, we will roll back this PR, and if allowed, we will continue to apply for secrets. INFRA: https://issues.apache.org/jira/browse/INFRA-21756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4091: feature: support to fetch balancer `ip`/`port` from `ctx.vars`
Firstsawyou commented on issue #4091: URL: https://github.com/apache/apisix/issues/4091#issuecomment-823733774 Assigned to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #385: WIP: fix wrong group version for extensions/v1beta1.Ingress
tokers commented on pull request #385: URL: https://github.com/apache/apisix-ingress-controller/pull/385#issuecomment-823722031 @vincenthcui Ping. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #393: test: add api-breaker plugin e2e test cases
tokers merged pull request #393: URL: https://github.com/apache/apisix-ingress-controller/pull/393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: test: add api-breaker plugin e2e test cases (#393)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new cc67f0f test: add api-breaker plugin e2e test cases (#393)
cc67f0f is described below
commit cc67f0f61fad0d4b7b6c2560d1440f37fc32fcec
Author: Alex Zhang
AuthorDate: Wed Apr 21 10:11:30 2021 +0800
test: add api-breaker plugin e2e test cases (#393)
---
test/e2e/plugins/api_breaker.go | 149
test/e2e/testdata/apisix-gw-config.yaml | 1 +
2 files changed, 150 insertions(+)
diff --git a/test/e2e/plugins/api_breaker.go b/test/e2e/plugins/api_breaker.go
new file mode 100644
index 000..f7a09f4
--- /dev/null
+++ b/test/e2e/plugins/api_breaker.go
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package plugins
+
+import (
+ "fmt"
+ "net/http"
+ "time"
+
+ "github.com/stretchr/testify/assert"
+
+ "github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
+ "github.com/onsi/ginkgo"
+)
+
+var _ = ginkgo.Describe("api-breaker plugin", func() {
+ opts := {
+ Name:"default",
+ Kubeconfig: scaffold.GetKubeconfig(),
+ APISIXConfigPath:"testdata/apisix-gw-config.yaml",
+ APISIXDefaultConfigPath:
"testdata/apisix-gw-config-default.yaml",
+ IngressAPISIXReplicas: 1,
+ HTTPBinServicePort: 80,
+ APISIXRouteVersion: "apisix.apache.org/v2alpha1",
+ }
+ s := scaffold.NewScaffold(opts)
+ ginkgo.It("sanity", func() {
+ backendSvc, backendPorts := s.DefaultHTTPBackend()
+ ar := fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
+ match:
+ hosts:
+ - httpbin.org
+ paths:
+ - /status/*
+ backends:
+ - serviceName: %s
+ servicePort: %d
+ resolveGranularity: service
+ plugins:
+ - name: api-breaker
+ enable: true
+ config:
+ break_response_code: 502
+ unhealthy:
+ http_statuses:
+ - 505
+ failures: 2
+ max_breaker_sec: 3
+ healthy:
+ http_statuses:
+ - 200
+ successes: 2
+`, backendSvc, backendPorts[0])
+
+ assert.Nil(ginkgo.GinkgoT(), s.CreateResourceFromString(ar))
+ err := s.EnsureNumApisixUpstreamsCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of
upstreams")
+ err = s.EnsureNumApisixRoutesCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of routes")
+
+ resp :=
s.NewAPISIXClient().GET("/status/200").WithHeader("Host",
"httpbin.org").Expect()
+ resp.Status(http.StatusOK)
+
+ for i := 0; i < 2; i++ {
+ resp =
s.NewAPISIXClient().GET("/status/505").WithHeader("Host",
"httpbin.org").Expect()
+ resp.Status(505)
+ }
+
+ // Trigger the api-breaker threshold
+ resp =
s.NewAPISIXClient().GET("/status/505").WithHeader("Host",
"httpbin.org").Expect()
+ resp.Status(http.StatusBadGateway)
+
+ time.Sleep(3500 * time.Millisecond)
+ resp =
s.NewAPISIXClient().GET("/status/200").WithHeader("Host",
"httpbin.org").Expect()
+ resp.Status(http.StatusOK)
+ })
+ ginkgo.It("disable plugin", func() {
+ backendSvc, backendPorts := s.DefaultHTTPBackend()
+ ar := fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
+ match:
+ hosts:
+ - httpbin.org
+ paths:
+ - /status/*
+ backends:
+ - serviceName: %s
+ servicePort: %d
+ resolveGranularity: service
+ plugins:
+ - name: api-breaker
+ enable: false
+ config:
+ break_response_code: 502
+ unhealthy:
+ http_statuses:
+
[GitHub] [apisix-ingress-controller] tokers merged pull request #388: test: add e2e test cases for ip-restriction plugin
tokers merged pull request #388: URL: https://github.com/apache/apisix-ingress-controller/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: test: add e2e test cases for ip-restriction plugin (#388)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 783ba62 test: add e2e test cases for ip-restriction plugin (#388)
783ba62 is described below
commit 783ba6257486c29d0c334513765fb9b1280b0424
Author: Alex Zhang
AuthorDate: Wed Apr 21 10:11:14 2021 +0800
test: add e2e test cases for ip-restriction plugin (#388)
---
test/e2e/plugins/ip-restriction.go | 238 +
1 file changed, 238 insertions(+)
diff --git a/test/e2e/plugins/ip-restriction.go
b/test/e2e/plugins/ip-restriction.go
new file mode 100644
index 000..7242ef9
--- /dev/null
+++ b/test/e2e/plugins/ip-restriction.go
@@ -0,0 +1,238 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package plugins
+
+import (
+ "fmt"
+
+ "github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
+ "github.com/onsi/ginkgo"
+ "github.com/stretchr/testify/assert"
+)
+
+var _ = ginkgo.Describe("proxy-rewrite plugin", func() {
+ opts := {
+ Name:"default",
+ Kubeconfig: scaffold.GetKubeconfig(),
+ APISIXConfigPath:"testdata/apisix-gw-config.yaml",
+ APISIXDefaultConfigPath:
"testdata/apisix-gw-config-default.yaml",
+ IngressAPISIXReplicas: 1,
+ HTTPBinServicePort: 80,
+ APISIXRouteVersion: "apisix.apache.org/v2alpha1",
+ }
+ s := scaffold.NewScaffold(opts)
+ ginkgo.It("ip whitelist", func() {
+ backendSvc, backendPorts := s.DefaultHTTPBackend()
+ ar := fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
+ match:
+ hosts:
+ - httpbin.org
+ paths:
+ - /hello
+ backends:
+ - serviceName: %s
+ servicePort: %d
+ weight: 10
+ plugins:
+ - name: ip-restriction
+ enable: true
+ config:
+ whitelist:
+ - "192.168.3.3"
+`, backendSvc, backendPorts[0])
+
+ assert.Nil(ginkgo.GinkgoT(), s.CreateResourceFromString(ar))
+
+ err := s.EnsureNumApisixUpstreamsCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of
upstreams")
+ err = s.EnsureNumApisixRoutesCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of routes")
+
+ // As we use port forwarding so the ip address is 127.0.0.1
+ s.NewAPISIXClient().GET("/hello").WithHeader("Host",
"httpbin.org").
+ Expect().
+ Status(403).
+ Body().
+ Contains("Your IP address is not allowed")
+
+ ar = fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
+ match:
+ hosts:
+ - httpbin.org
+ paths:
+ - /ip
+ backends:
+ - serviceName: %s
+ servicePort: %d
+ weight: 10
+ plugins:
+ - name: ip-restriction
+ enable: true
+ config:
+ whitelist:
+ - "127.0.0.1"
+`, backendSvc, backendPorts[0])
+
+ assert.Nil(ginkgo.GinkgoT(), s.CreateResourceFromString(ar))
+
+ err = s.EnsureNumApisixUpstreamsCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of
upstreams")
+ err = s.EnsureNumApisixRoutesCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of routes")
+
+ // As we use port forwarding so the ip address is 127.0.0.1
+ s.NewAPISIXClient().GET("/ip").WithHeader("Host",
"httpbin.org").
+ Expect().
+ Status(200).
+ Body().
+ Contains("origin")
+ })
+ ginkgo.It("ip blacklist", func() {
+ backendSvc, backendPorts := s.DefaultHTTPBackend()
+ ar := fmt.Sprintf(`
+apiVersion:
[GitHub] [apisix-ingress-controller] wjx8382 commented on issue #356: request help: KubeSphere setup
wjx8382 commented on issue #356:
URL:
https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-823721227
> > > From the configuration snippet the `allow_admin` was rendered
correctly, so it should work, would you like to try the `0.5.0` version, it was
released few days ago.
> >
> >
> > After using the `0.5.0` version,apisix-ingress-controller logs
> > ```
> > 2021-04-20T15:26:34+08:00warncontroller/apisix_route.go:205
sync ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"tools/httpserver-route","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null},
"error": "2 errors occurred:\n\t* object missing primary index\n\t* object
missing primary index\n\n"}
> > ```
> >
> >
> > In addition, why `helm install apisix` will also generate
apisix-ingress-controller, but its version is `0.4.0`, `helm install
apisix-ingress-controller` will generate apisix-ingress-controller which
version is `0.5.0`, which should I use?
>
> The error `object missing primary index` occurred basically due to you
wrote some route on apisix-dashboard. It's **NOT** a recommended way.
>
> > In addition, why helm install apisix will also generate
apisix-ingress-controller, but its version is 0.4.0, helm install
apisix-ingress-controller will generate apisix-ingress-controller which version
is 0.5.0, which should I use?
>
> We recommend you to use the `0.5.0` release.
I did not write anything on apisix-dashboard.After I installed APISIX and
apisix-ingress-controller,i just running `kubectl apply -f httpbin-route.yaml
-n tools`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on pull request #159: feat: automate upload image to Dockerhub
gxthrj commented on pull request #159: URL: https://github.com/apache/apisix-docker/pull/159#issuecomment-823713945 Yes, the secret needed. I will try to set the secrets through infra of Apache. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-control-plane] branch master updated: chore: fix go code styles (#41)
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-control-plane.git
The following commit(s) were added to refs/heads/master by this push:
new 0183669 chore: fix go code styles (#41)
0183669 is described below
commit 0183669db0636559d2387bddaac9650f7770700e
Author: Joey
AuthorDate: Wed Apr 21 09:34:44 2021 +0800
chore: fix go code styles (#41)
Signed-off-by: imjoey
---
pkg/adapter/route.go | 3 ++-
pkg/yml/plugin.go| 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/pkg/adapter/route.go b/pkg/adapter/route.go
index 635573b..4029747 100644
--- a/pkg/adapter/route.go
+++ b/pkg/adapter/route.go
@@ -18,9 +18,10 @@
package adapter
import (
+ "reflect"
+
"github.com/apache/apisix-control-plane/pkg/dp/apisix"
"github.com/apache/apisix-control-plane/pkg/mem"
- "reflect"
)
func ToRoute(r *mem.Route) *apisix.Route {
diff --git a/pkg/yml/plugin.go b/pkg/yml/plugin.go
index 739940a..c8e9074 100644
--- a/pkg/yml/plugin.go
+++ b/pkg/yml/plugin.go
@@ -14,7 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
+
package yml
import "github.com/apache/apisix-control-plane/pkg/mem"
[GitHub] [apisix-control-plane] gxthrj merged pull request #41: chore: fix Go code styles
gxthrj merged pull request #41: URL: https://github.com/apache/apisix-control-plane/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #386: feat: add event & status for ApisixRoute v2
gxthrj commented on pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#issuecomment-823710143 related to : #394 #395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4090: Request help: Correspondence between matched rules and upstreams within one route
Firstsawyou commented on issue #4090:
URL: https://github.com/apache/apisix/issues/4090#issuecomment-823709437
You can try the traffic-split plug-in. Here is an example of configuration:
```shell
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri": "/hello",
"plugins": {
"traffic-split": {
"rules": [
{
"match": [
{
"vars": [
["http_id","==","1"]
]
}
],
"weighted_upstreams": [
{
"upstream": {
"name": "upstream_A",
"type": "roundrobin",
"nodes": {
"127.0.0.1:1981":1
}
},
"weight": 3
}
]
},
{
"match": [
{
"vars": [
["http_id","==","2"]
]
}
],
"weighted_upstreams": [
{
"upstream": {
"name": "upstream_B",
"type": "roundrobin",
"nodes": {
"127.0.0.1:1982":1
}
},
"weight": 3
}
]
}
]
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"127.0.0.1:1980": 1
}
}
}'
```
However, it may not take effect in APISIX 2.5. You can try it in versions
before 2.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-control-plane] gxthrj commented on issue #42: feat:Use curl to encapsulate the Admin API into a script
gxthrj commented on issue #42: URL: https://github.com/apache/apisix-control-plane/issues/42#issuecomment-823709420 @kasini3000 Sorry for the late reply. According to the stated configuration, calling APISIX `admin-api` is already supported, but the command line function still needs to be developed. I will list this in the plan, and I can first expose the functionality through the command line. Because some functions overlap with other projects, I am doing this refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander edited a comment on issue #4090: Request help: Correspondence between matched rules and upstreams within one route
spacewander edited a comment on issue #4090: URL: https://github.com/apache/apisix/issues/4090#issuecomment-823701104 ~~You can write your own plugin like traffic-split.~~ Look like the `rules` in traffic-split is an array, so you can use it with multiple upstream but not just for 2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on pull request #1667: feat: run manager-api as a systemd daemon/service
starsz commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-823705817 > > how about ./manager-api start and ./manager-api stop, > > when run ./manager-api start and the service is not installed, install it ? > > Okay then, I will take care of checking and installing(if required) for `./manager-api start`. > And yes, actual commands instead of flags would look nice, thanks for that. Regarding the commands I think, we could provide install, remove and status too. > > * ./manager-api start > * ./manager-api stop > * ./manager-api status (option to check service status from the binary itself without depending on os specific service manager) > * ./manager-api remove (would be helpful deleting service test file without manually navigating to the filesystem) > * ./manager-api install (reinstalling the service, if the binary location needs to be changed in future, service must be reinstalled. Also in newer releases if we introduce extra flags, that should be passed as arguments for ExecStart of the service unit file i.e. need reinstallation) > > what do you think :) LGTM too!. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #386: feat: add event & status for ApisixRoute v2
gxthrj commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617134653
##
File path: pkg/ingress/apisix_upstream.go
##
@@ -122,6 +133,8 @@ func (c *apisixUpstreamController) sync(ctx
context.Context, ev *types.Event) er
svc, err := c.controller.svcLister.Services(namespace).Get(name)
if err != nil {
log.Errorf("failed to get service %s: %s", key, err)
+ message := fmt.Sprintf(_messageResourceFailed,
_upstreamController, err.Error())
Review comment:
Yes, I will refactor it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #386: feat: add event & status for ApisixRoute v2
gxthrj commented on a change in pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617134124 ## File path: pkg/ingress/apisix_route.go ## @@ -16,30 +16,44 @@ package ingress import ( "context" + "fmt" "time" "go.uber.org/zap" + v1 "k8s.io/api/core/v1" k8serrors "k8s.io/apimachinery/pkg/api/errors" + "k8s.io/apimachinery/pkg/api/meta" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "k8s.io/client-go/kubernetes/scheme" + typedcorev1 "k8s.io/client-go/kubernetes/typed/core/v1" "k8s.io/client-go/tools/cache" + "k8s.io/client-go/tools/record" "k8s.io/client-go/util/workqueue" "github.com/apache/apisix-ingress-controller/pkg/kube" + "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/typed/config/v2alpha1" "github.com/apache/apisix-ingress-controller/pkg/log" "github.com/apache/apisix-ingress-controller/pkg/types" apisixv1 "github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1" ) +const _routeController = "RouteController" Review comment: Do you mean using `ApisixIngress` is better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #386: feat: add event & status for ApisixRoute v2
gxthrj commented on pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#issuecomment-823703348 > @gxthrj The e2e CI failed. It is strange, scale endpoint getting error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #386: feat: add event & status for ApisixRoute v2
gxthrj commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617132857
##
File path: pkg/ingress/endpoint.go
##
@@ -181,8 +181,8 @@ func (c *endpointsController) onAdd(obj interface{}) {
if !c.controller.namespaceWatching(key) {
return
}
- log.Debugw("endpoints add event arrived",
- zap.Any("object", obj))
+ //log.Debugw("endpoints add event arrived",
Review comment:
got error when logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4090: Request help: Correspondence between matched rules and upstreams within one route
spacewander commented on issue #4090: URL: https://github.com/apache/apisix/issues/4090#issuecomment-823701104 You can write your own plugin like traffic-split. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4089: docs: add dynamic contributor over time chart
spacewander merged pull request #4089: URL: https://github.com/apache/apisix/pull/4089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: add dynamic contributor over time chart (#4089)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new b17bb8f docs: add dynamic contributor over time chart (#4089) b17bb8f is described below commit b17bb8fe728583dbb1f41bccc9c22fc8081ce5e0 Author: litesun AuthorDate: Wed Apr 21 08:57:17 2021 +0800 docs: add dynamic contributor over time chart (#4089) --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5e786d9..f2e94f9 100644 --- a/README.md +++ b/README.md @@ -299,7 +299,7 @@ Benchmark comparison test [details data](https://gist.github.com/membphis/137db9 > [visit here](https://www.apiseven.com/contributor-graph) to generate > Contributor Over Time. -[](https://www.apiseven.com/contributor-graph) +[](https://www.apiseven.com/en/contributor-graph?repo=apache/apisix) ## Videos And Articles
[GitHub] [apisix] spacewander merged pull request #4085: docs: the link should be to dashboard instead of APISIX
spacewander merged pull request #4085: URL: https://github.com/apache/apisix/pull/4085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: the link should be to dashboard instead of APISIX (#4085)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 81678a7 docs: the link should be to dashboard instead of APISIX (#4085) 81678a7 is described below commit 81678a7a157697e7bb01c45578c757c57fad1ed2 Author: Kishani Kandasamy <53715187+kishanikandas...@users.noreply.github.com> AuthorDate: Wed Apr 21 06:26:47 2021 +0530 docs: the link should be to dashboard instead of APISIX (#4085) --- docs/en/latest/getting-started.md | 2 +- docs/zh/latest/getting-started.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/en/latest/getting-started.md b/docs/en/latest/getting-started.md index faea360..33001f7 100644 --- a/docs/en/latest/getting-started.md +++ b/docs/en/latest/getting-started.md @@ -262,7 +262,7 @@ $ curl -i -X GET 'http://127.0.0.1:9080/samplePrefix/get?param1=foo=bar' ### APISIX Dashboard -Apache APISIX provides a [Dashboard](https://github.com/apache/apisix) to let us operate Apache APISIX more easier. +Apache APISIX provides a [Dashboard](https://github.com/apache/apisix-dashboard) to let us operate Apache APISIX more easier.  diff --git a/docs/zh/latest/getting-started.md b/docs/zh/latest/getting-started.md index c86e015..1038e5a 100644 --- a/docs/zh/latest/getting-started.md +++ b/docs/zh/latest/getting-started.md @@ -267,7 +267,7 @@ $ curl -i -X GET 'http://127.0.0.1:9080/samplePrefix/get?param1=foo=bar' ### APISIX Dashboard（控制台） -Apache APISIX 提供了一个 [Dashboard](https://github.com/apache/apisix)，让我们的操作更直观更轻松。 +Apache APISIX 提供了一个 [Dashboard](https://github.com/apache/apisix-dashboard)，让我们的操作更直观更轻松。 
[GitHub] [apisix] spacewander closed issue #4079: docs(get-started): the link should be to dashboard instead of APISIX
spacewander closed issue #4079: URL: https://github.com/apache/apisix/issues/4079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #115: feat: Support TCP definition
tokers commented on issue #115: URL: https://github.com/apache/apisix-ingress-controller/issues/115#issuecomment-823697947 Assigned to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #364: ci: add golint workflow
tokers commented on issue #364: URL: https://github.com/apache/apisix-ingress-controller/issues/364#issuecomment-823697779 @batman-ezio Ping, any updates? I will wait for you 3 more days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #386: feat: add event & status for ApisixRoute v2
tokers commented on pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386#issuecomment-823696046 @gxthrj The e2e CI failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #386: feat: add event & status for ApisixRoute v2
tokers commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r617124870
##
File path: pkg/ingress/apisix_route.go
##
@@ -16,30 +16,44 @@ package ingress
import (
"context"
+ "fmt"
"time"
"go.uber.org/zap"
+ v1 "k8s.io/api/core/v1"
k8serrors "k8s.io/apimachinery/pkg/api/errors"
+ "k8s.io/apimachinery/pkg/api/meta"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+ "k8s.io/client-go/kubernetes/scheme"
+ typedcorev1 "k8s.io/client-go/kubernetes/typed/core/v1"
"k8s.io/client-go/tools/cache"
+ "k8s.io/client-go/tools/record"
"k8s.io/client-go/util/workqueue"
"github.com/apache/apisix-ingress-controller/pkg/kube"
+
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/typed/config/v2alpha1"
"github.com/apache/apisix-ingress-controller/pkg/log"
"github.com/apache/apisix-ingress-controller/pkg/types"
apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
)
+const _routeController = "RouteController"
Review comment:
I am wondering whether we need a finer granularity component in
apisix-ingress-controller. The pod events reporters are "kubelet", "scheduler",
it's a whole program, not a module inside it.
##
File path: pkg/ingress/endpoint.go
##
@@ -181,8 +181,8 @@ func (c *endpointsController) onAdd(obj interface{}) {
if !c.controller.namespaceWatching(key) {
return
}
- log.Debugw("endpoints add event arrived",
- zap.Any("object", obj))
+ //log.Debugw("endpoints add event arrived",
Review comment:
Why comment it?
##
File path: pkg/ingress/apisix_upstream.go
##
@@ -122,6 +133,8 @@ func (c *apisixUpstreamController) sync(ctx
context.Context, ev *types.Event) er
svc, err := c.controller.svcLister.Services(namespace).Get(name)
if err != nil {
log.Errorf("failed to get service %s: %s", key, err)
+ message := fmt.Sprintf(_messageResourceFailed,
_upstreamController, err.Error())
Review comment:
Can these two lines be encapsulated into one function? they used in many
places, and once you need to change, you have to change everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #3883: feat: add 5xx error page
tokers commented on pull request #3883: URL: https://github.com/apache/apisix/pull/3883#issuecomment-823692128 @starsz Conflicts should be resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #338: bug: minikube setup
tokers commented on issue #338: URL: https://github.com/apache/apisix-ingress-controller/issues/338#issuecomment-823691506 @bahtou The indent of `backend` is wrong, it should be aligned with `match`, not inside `match`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
juzhiyuan commented on issue #1803: URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823680775 As @liuxiran said, we actually support an empty node list, it will return a 5xx status code to the client. I would prefer keeping the current behaviour, because if users really want to do it, what they can do on the dashboard? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1667](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (612d303) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bec8f1b) will **decrease** coverage by `1.17%`. > The diff coverage is `42.30%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1667 +/- ## == - Coverage 72.48% 71.31% -1.18% == Files 133 173 +40 Lines5728 6181 +453 Branches 666 713 +47 == + Hits 4152 4408 +256 - Misses 1332 1522 +190 - Partials 244 251 +7 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.58% <42.30%> (-1.95%)` | :arrow_down: | | backend-e2e-test-ginkgo | `48.59% <42.30%> (+0.55%)` | :arrow_up: | | backend-unit-test | `52.40% <ø> (+0.59%)` | :arrow_up: | | frontend-e2e-test | `71.98% <ø> (-2.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/cmd/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zZXJ2aWNlLmdv) | `13.51% <13.51%> (ø)` | | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `52.54% <53.76%> (-6.92%)` | :arrow_down: | | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (-8.20%)` | :arrow_down: | | [...pages/Route/components/Step1/RequestConfigView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1JlcXVlc3RDb25maWdWaWV3LnRzeA==) | `81.48% <0.00%> (-5.37%)` | :arrow_down: | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <0.00%> (-2.82%)` | :arrow_down: | | [web/src/pages/PluginTemplate/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | `39.13% <0.00%> (-2.54%)` | :arrow_down: | | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `62.93% <0.00%> (-2.52%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
netlify[bot] edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614 Deploy preview for *apisix-dashboard* ready! Built with commit 612d303a1be6e4790241908f8d252d78b4516f72 https://deploy-preview-1667--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
netlify[bot] edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614 Deploy preview for *apisix-dashboard* processing. Building with commit 612d303a1be6e4790241908f8d252d78b4516f72 https://app.netlify.com/sites/apisix-dashboard/deploys/607f2d1459c9d400084982a3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1807: docs: add correct custom IDs to links
netlify[bot] edited a comment on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427 Deploy preview for *apisix-dashboard* ready! Built with commit d7521563209f779c8ac53860dace190574b6c790 https://deploy-preview-1807--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1807: docs: add correct custom IDs to links
netlify[bot] edited a comment on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427 Deploy preview for *apisix-dashboard* processing. Building with commit d7521563209f779c8ac53860dace190574b6c790 https://app.netlify.com/sites/apisix-dashboard/deploys/607f12032e5a550008d24e47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] KishaniKandasamy opened a new issue #1809: doc: link is broken in deploy-with-docker
KishaniKandasamy opened a new issue #1809: URL: https://github.com/apache/apisix-dashboard/issues/1809 ## Issue description https://apisix.apache.org/docs/api/conf/conf.yaml is broken in deploy-with-docker  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
netlify[bot] edited a comment on pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134 Deploy preview for *apisix-dashboard* ready! Built with commit 61d7078c61539282868f1aaa310a8301777c467b https://deploy-preview-1808--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
netlify[bot] edited a comment on pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
netlify[bot] commented on pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134 Deploy preview for *apisix-dashboard* processing. Building with commit 08b678508fe86065c3c36f2aa3cdb4c942f76994 https://app.netlify.com/sites/apisix-dashboard/deploys/607f04605d14dc000787704d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] KishaniKandasamy opened a new pull request #1808: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
KishaniKandasamy opened a new pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [X] Bugfix **Related issues** fix: #1804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1807: docs: add correct custom IDs to links
netlify[bot] edited a comment on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427 Deploy preview for *apisix-dashboard* ready! Built with commit 0d5d7deb5d82c802159767bcf13e82a9065e18f5 https://deploy-preview-1807--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1807: docs: add correct custom IDs to links
netlify[bot] edited a comment on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427 Deploy preview for *apisix-dashboard* processing. Building with commit 0d5d7deb5d82c802159767bcf13e82a9065e18f5 https://app.netlify.com/sites/apisix-dashboard/deploys/607efcb17f89b80008fbc9c1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou opened a new pull request #4092: fix(traffic-split): when there are multiple weighted_upstreams, the request is confused
Firstsawyou opened a new pull request #4092: URL: https://github.com/apache/apisix/pull/4092 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1807: docs: add correct custom IDs to links
netlify[bot] edited a comment on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427 Deploy preview for *apisix-dashboard* ready! Built with commit cbaf1eb8f8694f68880a496c657be918d3183295 https://deploy-preview-1807--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1805: chore: icons added for auth, security, traffic, serverless
codecov-commenter commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823368734 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1805](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3f20b99) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a476ad7f264a1166290fe0bdb397d2d26cfd23c2?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a476ad7) will **increase** coverage by `0.44%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1805 +/- ## == + Coverage 71.85% 72.29% +0.44% == Files 172 125 -47 Lines6100 2920-3180 Branches 713 701 -12 == - Hits 4383 2111-2272 + Misses 1474 809 -665 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `72.29% <ø> (+0.31%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1805?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <ø> (ø)` | | | [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | `100.00% <ø> (+58.62%)` | :arrow_up: | | [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | | | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | | | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | | | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1805/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | | | |
[GitHub] [apisix-dashboard] KishaniKandasamy opened a new pull request #1807: docs: add correct custom IDs to links
KishaniKandasamy opened a new pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [X] Bugfix **What changes will this PR take into?** fix: #1806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1807: docs: add correct custom IDs to links
netlify[bot] commented on pull request #1807: URL: https://github.com/apache/apisix-dashboard/pull/1807#issuecomment-823368427 Deploy preview for *apisix-dashboard* processing. Building with commit cbaf1eb8f8694f68880a496c657be918d3183295 https://app.netlify.com/sites/apisix-dashboard/deploys/607ef345affb95000776677f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] KishaniKandasamy opened a new issue #1806: docs: add correct custom IDs to links
KishaniKandasamy opened a new issue #1806: URL: https://github.com/apache/apisix-dashboard/issues/1806 Some links aren't directed properly . Ex: https://apisix.apache.org/docs/dashboard/api/api/#ApiError  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1805: chore: icons added for auth, security, traffic, serverless
juzhiyuan commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823357985 **Chinese**  **English**  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1805: chore: icons added for auth, security, traffic, serverless
netlify[bot] edited a comment on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128 Deploy preview for *apisix-dashboard* ready! Built with commit 3f20b9914b49cf7f0ccec2f38784a06a6efe28b6 https://deploy-preview-1805--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1805: chore: icons added for auth, security, traffic, serverless
iamayushdas opened a new pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** New icons added for - authentication - security - traffic - serverless Please update this section with detailed description. Added the icons **Related issues** fix/resolve #1760 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [x] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1805: chore: icons added for auth, security, traffic, serverless
netlify[bot] commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823346128 Deploy preview for *apisix-dashboard* processing. Building with commit 3f20b9914b49cf7f0ccec2f38784a06a6efe28b6 https://app.netlify.com/sites/apisix-dashboard/deploys/607eec964febc2000883ccfa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #4091: feature: support to fetch balancer `ip`/`port` from `ctx.vars`
membphis commented on issue #4091: URL: https://github.com/apache/apisix/issues/4091#issuecomment-823348187 @moonming welcome to take a look at this issue and I think @Firstsawyou should familiar with this feature, welcome to make a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1805: chore: icons added for auth, security, traffic, serverless
iamayushdas commented on pull request #1805: URL: https://github.com/apache/apisix-dashboard/pull/1805#issuecomment-823348141 @juzhiyuan @guoqqqi have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-control-plane] juzhiyuan commented on issue #42: feat:Use curl to encapsulate the Admin API into a script
juzhiyuan commented on issue #42: URL: https://github.com/apache/apisix-control-plane/issues/42#issuecomment-823347833 Please take a look at this one, if we are going to support this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis opened a new issue #4091: feature: support to fetch balancer `ip`/`port` from `ctx.vars`
membphis opened a new issue #4091: URL: https://github.com/apache/apisix/issues/4091 we have stored the upstream ip/port in `ctx` object, here is the link: https://github.com/apache/apisix/blob/master/apisix/balancer.lua#L204-L205 we should support to fetch from `ctx.vars`, here is the example: ```lua local up_ip = ctx.vars["balancer_ip"] local up_port = ctx.vars["balancer_port"] ``` Then we can use this value in plugins(eg: SkyWalking). I think we can use the same way as "consumer_name", which is the code link: https://github.com/apache/apisix/blob/master/apisix/core/ctx.lua#L176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3883: feat: add 5xx error page
moonming commented on pull request #3883: URL: https://github.com/apache/apisix/pull/3883#issuecomment-823336035 > > Then your PR did not solve the issue @starsz > > > > I am confused. This PR can solve the issue. The response I give is before this PR. > > Can you give more details about why this PR can't solve the issue? > > > > By the way, I will fix the CI first. please make sure you read the issue and thread in mailinglist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] bahtou commented on issue #338: bug: minikube setup
bahtou commented on issue #338: URL: https://github.com/apache/apisix-ingress-controller/issues/338#issuecomment-823329241 @tokers Following the documentation here: https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/deployments/minikube.md#install-apisix ``` helm install apisix-ingress-controller apisix/apisix-ingress-controller \ --set image.tag=0.5.0 \ --set config.apisix.baseURL=http://apisix-admin:9180/apisix/admin \ --set config.apisix.adminKey=edd1c9f034335f136f87ad84b625c8f1 \ --namespace ingress-apisix ``` `error: unable to recognize "httpbin-route.yaml": no matches for kind "ApisixRoute" in version "apisix.apache.org/v2alpha1"` yaml file ``` apiVersion: apisix.apache.org/v2alpha1 kind: ApisixRoute metadata: name: httpserver-route spec: http: - name: rule1 match: hosts: - local.httpbin.org paths: - /* backend: - serviceName: httpbin servicePort: 80 ``` I also installed the crds via the `samples/deploy/crd/v1beta1` but then get this error: ```The ApisixRoute "httpserver-route" is invalid: * : Invalid value: "": "spec.http" must validate one and only one schema (oneOf). Found none valid * spec.http.backend: Required value``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] KishaniKandasamy opened a new issue #1804: docs : FAQ in IMPORT_OPENAPI_USER_GUIDE
KishaniKandasamy opened a new issue #1804: URL: https://github.com/apache/apisix-dashboard/issues/1804 ## Issue description Currently we have FAQ section under the sidebar . But there is [an FAQ](https://apisix.apache.org/docs/dashboard/IMPORT_OPENAPI_USER_GUIDE#faq) in the IMPORT_OPENAPI_USER_GUIDE.  What about adding that too under the common FAQ section? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #356: request help: KubeSphere setup
tokers commented on issue #356:
URL:
https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-823299160
> > From the configuration snippet the `allow_admin` was rendered correctly,
so it should work, would you like to try the `0.5.0` version, it was released
few days ago.
>
> After using the `0.5.0` version,apisix-ingress-controller logs
>
> ```
> 2021-04-20T15:26:34+08:00 warncontroller/apisix_route.go:205 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"tools/httpserver-route","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null},
"error": "2 errors occurred:\n\t* object missing primary index\n\t* object
missing primary index\n\n"}
> ```
>
> In addition, why `helm install apisix` will also generate
apisix-ingress-controller, but its version is `0.4.0`, `helm install
apisix-ingress-controller` will generate apisix-ingress-controller which
version is `0.5.0`, which should I use?
The error `object missing primary index` occurred basically due to you wrote
some route on apisix-dashboard. It's **NOT** a recommended way.
> In addition, why helm install apisix will also generate
apisix-ingress-controller, but its version is 0.4.0, helm install
apisix-ingress-controller will generate apisix-ingress-controller which version
is 0.5.0, which should I use?
We recommend you to use the `0.5.0` release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] starsz edited a comment on pull request #3883: feat: add 5xx error page
starsz edited a comment on pull request #3883: URL: https://github.com/apache/apisix/pull/3883#issuecomment-823289321 > Then your PR did not solve the issue @starsz I am confused. This PR can solve the issue. The response I give is before this PR. Can you give more details about why this PR can't solve the issue? By the way, I will fix the CI first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on pull request #3883: feat: add 5xx error page
starsz commented on pull request #3883: URL: https://github.com/apache/apisix/pull/3883#issuecomment-823289321 > Then your PR did not solve the issue @starsz I am confused. This PR can solve the issue. The response I give is before this PR. Can you give more details about why this PR can't solve the issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Yiyiyimu commented on issue #37: doc: need guidelines to deploy apisix without clone this repo
Yiyiyimu commented on issue #37: URL: https://github.com/apache/apisix-helm-chart/issues/37#issuecomment-823278009 > @Yiyiyimu Hi, can't we publish the helm chart into to [artifacthub](https://artifacthub.io/) and install it via the helm command? Hi @BLasan Yes but we still need to clone this repo first, then do helm install, which is kind of annoying, to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
