[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #787: request help: ApisixRoute apiversion Inconsistency
tao12345666333 commented on issue #787: URL: https://github.com/apache/apisix-ingress-controller/issues/787#issuecomment-988578931 I mean you are using * https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/crds/customresourcedefinitions.yaml OR * https://github.com/apache/apisix-ingress-controller/tree/master/samples/deploy/crd/v1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #772: feat: implement pluginconfig clients (#638)
tao12345666333 commented on pull request #772: URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-988576890 #788 has fixed the e2e error. It's green! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] GhangZh commented on issue #787: request help: ApisixRoute apiversion Inconsistency
GhangZh commented on issue #787: URL: https://github.com/apache/apisix-ingress-controller/issues/787#issuecomment-988572975 > And which CRD configuration are you using? 1. Yes, deleted then create. 2.I using apisix.apache.org/v2beta1 ApisixRoute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] qq54903099 commented on pull request #5732: feat: consumer-restriction add reject-message
qq54903099 commented on pull request #5732: URL: https://github.com/apache/apisix/pull/5732#issuecomment-988565449 how to chose reviewers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shaobo322 commented on a change in pull request #5738: feat(plugin): jwt-token plugin allow user defined token parameter name
shaobo322 commented on a change in pull request #5738:
URL: https://github.com/apache/apisix/pull/5738#discussion_r764601380
##
File path: apisix/plugins/jwt-auth.lua
##
@@ -45,6 +45,7 @@ local consumer_schema = {
properties = {
key = {type = "string"},
secret = {type = "string"},
+param = {type = "string", default = "jwt"},
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] GhangZh closed issue #2223: request help :apisix-dashboard Dockerfile and build.sh error
GhangZh closed issue #2223: URL: https://github.com/apache/apisix-dashboard/issues/2223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] GhangZh commented on issue #2223: request help :apisix-dashboard Dockerfile and build.sh error
GhangZh commented on issue #2223: URL: https://github.com/apache/apisix-dashboard/issues/2223#issuecomment-988557283 > Hi @GhangZh, may I know if this issue gets resolved? Yes, thank you both for your help @juzhiyuan @zaunist , then I'll turn off this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on issue #5733: request help: sometimes connection refused while using service ip to connect the upstream
leslie-tsang commented on issue #5733: URL: https://github.com/apache/apisix/issues/5733#issuecomment-988556034 > Hi @leslie-tsang, could you give some ideas on how to debug this issue? Yes for sure. > ### Issue description > **error log** > > ``` > [error] 48#48: *2240177 connect() failed (111: Connection refused) while connecting to upstream > > [lua] balancer.lua:327: run(): failed to pick server: failed to find valid upstream server, all upstream servers tried while connecting to upstream > ``` > > It can work sometimes, I try to increase times of retry for the route, but it can't solve this problem at all. Could you exec `curl` with `-v` to verify the network between apisix and upstream is working as expected ? e.g. ```shell curl -v http://upstream:port/uri ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yxudong opened a new issue #4301: bug: skywalking not work when upsteam timeout
yxudong opened a new issue #4301: URL: https://github.com/apache/apisix/issues/4301 ### Issue description At present, sw_tracer:finish() will be called in body_filter_by_lua phase. But in some case, the http request will not execute body_filter_by_lua phase. so this function will not be called. Detail: https://github.com/apache/skywalking/issues/7004 Is this function should be called in log_by_lua phase? ### What's the actual result? (including assertion message & call stack if applicable) The upsteam timeout case not work with skywalking plugin. ### What's the expected result? The upsteam timeout case could also be work with skywalking plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng closed issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng closed issue #4301: URL: https://github.com/apache/apisix/issues/4301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-988548156  2 fixes are code related. It is 7 months since last release, if you feel you should, please run for it. If you do that, skywalking-kong 0.1.2 should be released with dependency upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5596: request help: customize Nginx variable in the configuration
spacewander commented on issue #5596: URL: https://github.com/apache/apisix/issues/5596#issuecomment-988547683 Just do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout
spacewander commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-988544339 @dmsolr Maybe we can create a new release of skywalking-nginx-lua now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zaunist commented on pull request #5739: docs(global_rule): update global rule description
zaunist commented on pull request #5739: URL: https://github.com/apache/apisix/pull/5739#issuecomment-988544226 cc @juzhiyuan @leslie-tsang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zuiyangqingzhou commented on a change in pull request #5728: refine the ua-restriction plugin configuration checksum logic
zuiyangqingzhou commented on a change in pull request #5728:
URL: https://github.com/apache/apisix/pull/5728#discussion_r764585950
##
File path: apisix/plugins/ua-restriction.lua
##
@@ -34,11 +35,11 @@ local schema = {
type = "boolean",
default = false,
},
-allowlist = {
+allow_list = {
type = "array",
minItems = 1
},
-denylist = {
+deny_list = {
Review comment:
Oh, I just don't think it's in line with the variable naming
specification, and if the scope of the impact is too great, I'll change it back
@juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] JiaoMaMJ commented on pull request #5686: feat: add a tool that can help users quickly try your project
JiaoMaMJ commented on pull request #5686: URL: https://github.com/apache/apisix/pull/5686#issuecomment-988541387 > Yes, It is a manual screenshot, just to demonstrate the entrance effect. You can customize the actual display effect. If your project uses Tin, we will also promote your product on our website, in the Scenario page of document. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2235: chore(deps): bump actions/upload-artifact from 2.2.4 to 2.3.0
codecov-commenter commented on pull request #2235: URL: https://github.com/apache/apisix-dashboard/pull/2235#issuecomment-988537853 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2235?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2235](https://codecov.io/gh/apache/apisix-dashboard/pull/2235?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c640039) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `1.75%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2235?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2235 +/- ## == - Coverage 69.87% 68.12% -1.76% == Files 184 127 -57 Lines7274 3369-3905 Branches 829 829 == - Hits 5083 2295-2788 + Misses 1897 1074 -823 + Partials 2940 -294 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `68.12% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2235?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2235/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | | | [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2235/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | | | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2235/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2235/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2235/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | | | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2235/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2235/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | | | | [api/cmd/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2235/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC92ZXJzaW9uLmdv) | | | |
[GitHub] [apisix] sekfung commented on issue #5733: request help: sometimes connection refused while using service ip to connect the upstream
sekfung commented on issue #5733: URL: https://github.com/apache/apisix/issues/5733#issuecomment-988537861 BTW，it deploy on k8s cluster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5596: request help: customize Nginx variable in the configuration
tzssangglass commented on issue #5596: URL: https://github.com/apache/apisix/issues/5596#issuecomment-988537630 Although this can be done. I'd like @spacewander 's way, do it with a special directive in `config-default.yaml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zaunist commented on issue #4895: docs: https://github.com/apache/apisix/blob/master/docs/zh/latest/architecture-design/global-rule.md
zaunist commented on issue #4895: URL: https://github.com/apache/apisix/issues/4895#issuecomment-988537204 Hi, community. I update the `global-rule` description, please take a look here https://github.com/apache/apisix/pull/5739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5738: feat(plugin): jwt-token plugin allow user defined token parameter name
spacewander commented on a change in pull request #5738:
URL: https://github.com/apache/apisix/pull/5738#discussion_r764580485
##
File path: apisix/plugins/jwt-auth.lua
##
@@ -45,6 +45,7 @@ local consumer_schema = {
properties = {
key = {type = "string"},
secret = {type = "string"},
+param = {type = "string", default = "jwt"},
Review comment:
What about using the name "token_name" instead?
##
File path: apisix/plugins/jwt-auth.lua
##
@@ -159,8 +160,8 @@ local function fetch_jwt_token(ctx)
return token
end
-
-token = ctx.var.arg_jwt
+local token_arg = "arg_" .. (conf.param or "jwt")
Review comment:
There is no need to use `or "jwt"`. We already set up the default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5738: feat(plugin): jwt-token plugin allow user defined token parameter name
juzhiyuan commented on pull request #5738: URL: https://github.com/apache/apisix/pull/5738#issuecomment-988535082 Hi @shaobo322, thanks for your contribution! And please update your PR's checklist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zaunist opened a new pull request #5739: doc: update global rule description
zaunist opened a new pull request #5739: URL: https://github.com/apache/apisix/pull/5739 ### What this PR does / why we need it: Global rule doc mistakenly define the scope of plugin.   resolve #4895 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] SylviaBABY opened a new pull request #797: docs: add APISIX Logger plugin blog
SylviaBABY opened a new pull request #797: URL: https://github.com/apache/apisix-website/pull/797 Changes: add APISIX Logger plugin blog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #788: fix: ingress LB status records
tao12345666333 merged pull request #788: URL: https://github.com/apache/apisix-ingress-controller/pull/788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: fix: ingress LB status records (#788)
This is an automated email from the ASF dual-hosted git repository.
zhangjintao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new fe4a824 fix: ingress LB status records (#788)
fe4a824 is described below
commit fe4a824f4debe3fd4e4a89584df61d2b6cba8ace
Author: Jintao Zhang
AuthorDate: Wed Dec 8 14:19:58 2021 +0800
fix: ingress LB status records (#788)
---
pkg/ingress/status.go | 3 +++
1 file changed, 3 insertions(+)
diff --git a/pkg/ingress/status.go b/pkg/ingress/status.go
index 6cdcadf..7f7fdc7 100644
--- a/pkg/ingress/status.go
+++ b/pkg/ingress/status.go
@@ -182,6 +182,7 @@ func (c *Controller) recordStatus(at interface{}, reason
string, err error, stat
}
+ v.ObjectMeta.Generation = generation
v.Status.LoadBalancer.Ingress = lbips
if _, errRecord :=
kubeClient.NetworkingV1().Ingresses(v.Namespace).UpdateStatus(context.TODO(),
v, metav1.UpdateOptions{}); errRecord != nil {
log.Errorw("failed to record status change for
IngressV1",
@@ -201,6 +202,7 @@ func (c *Controller) recordStatus(at interface{}, reason
string, err error, stat
}
+ v.ObjectMeta.Generation = generation
v.Status.LoadBalancer.Ingress = lbips
if _, errRecord :=
kubeClient.NetworkingV1beta1().Ingresses(v.Namespace).UpdateStatus(context.TODO(),
v, metav1.UpdateOptions{}); errRecord != nil {
log.Errorw("failed to record status change for
IngressV1",
@@ -219,6 +221,7 @@ func (c *Controller) recordStatus(at interface{}, reason
string, err error, stat
}
+ v.ObjectMeta.Generation = generation
v.Status.LoadBalancer.Ingress = lbips
if _, errRecord :=
kubeClient.ExtensionsV1beta1().Ingresses(v.Namespace).UpdateStatus(context.TODO(),
v, metav1.UpdateOptions{}); errRecord != nil {
log.Errorw("failed to record status change for
IngressV1",
[GitHub] [apisix] zaunist commented on a change in pull request #5736: docs(ldap-auth): add consumer parameters for ldap
zaunist commented on a change in pull request #5736: URL: https://github.com/apache/apisix/pull/5736#discussion_r764576788 ## File path: docs/en/latest/plugins/ldap-auth.md ## @@ -41,12 +41,13 @@ This authentication plugin use [lualdap](https://lualdap.github.io/lualdap/) plu ## Attributes -| Name | Type | Requirement | Default | Valid | Description | -| | -- | --- | --- | - | | -| base_dn | string | required| | | the base dn of the `ldap` server (example : `ou=users,dc=example,dc=org`) | -| ldap_uri | string | required| | | the uri of the ldap server | -| use_tls | boolean | optional|`true` | | Boolean flag indicating if Transport Layer Security (TLS) should be used. | -| uid | string | optional| `cn` | | the `uid` attribute | +| Name | Type| Requirement | Default | Valid | |Description | +| | --- | --- | --- | - | | +| base_dn | string | required| | | the base dn of the `ldap` server (example : `ou=users,dc=example,dc=org`) | +| ldap_uri | string | required| | | the uri of the ldap server | +| use_tls | boolean | optional| `true` | | Boolean flag indicating if Transport Layer Security (TLS) should be used. | +| uid | string | optional| `cn`| | the `uid` attribute | +| user_dn | string | required| | | the user dn of the `ladp` client (example: `cn=user01,ou=users,dc=example,dc=org`) | Review comment: thx, I will update later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #781: request help: The route name generated by default is too long
tao12345666333 commented on issue #781: URL: https://github.com/apache/apisix-ingress-controller/issues/781#issuecomment-988531185 You can using ApisixRoute like this one. ``` apiVersion: apisix.apache.org/v2beta3 kind: ApisixRoute metadata: name: httpbin-route spec: http: - name: rule1 match: hosts: - httpbin.org paths: - /ip backends: - serviceName: %s servicePort: %d weight: 10 plugins: - name: echo enable: true config: before_body: "This is the preface" after_body: "This is the epilogue" headers: X-Foo: v1 X-Foo2: v2 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shaobo322 opened a new pull request #5738: feat(plugin): jwt-token plugin allow user defined token parameter name
shaobo322 opened a new pull request #5738: URL: https://github.com/apache/apisix/pull/5738 ### What this PR does / why we need it: fix #5710 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xianshun163 commented on issue #3801: request help: support kubernetes as service discovery
xianshun163 commented on issue #3801: URL: https://github.com/apache/apisix/issues/3801#issuecomment-988529804 when use dns， it is differ as the service discovery, the apisix balancer.lua can not get the pod ip. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #783: request help: possible optimization in the installation documentation
tao12345666333 commented on issue #783: URL: https://github.com/apache/apisix-ingress-controller/issues/783#issuecomment-988529102 #785 has merged. I will close this issue. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #783: request help: possible optimization in the installation documentation
tao12345666333 closed issue #783: URL: https://github.com/apache/apisix-ingress-controller/issues/783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #784: request help: regex_uri in proxy-rewriter
tao12345666333 commented on issue #784: URL: https://github.com/apache/apisix-ingress-controller/issues/784#issuecomment-988528820 And can you check the route record in Apache APISIX ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] dependabot[bot] opened a new pull request #2235: chore(deps): bump actions/upload-artifact from 2.2.4 to 2.3.0
dependabot[bot] opened a new pull request #2235: URL: https://github.com/apache/apisix-dashboard/pull/2235 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2.2.4 to 2.3.0. Release notes Sourced from https://github.com/actions/upload-artifact/releases;>actions/upload-artifact's releases. v2.3.0 Upload Artifact Optimizations for faster uploads of larger files that are already compressed Significantly improved logging when there are chunked uploads Clarifications in logs around the upload size and prohibited characters that aren't allowed in the artifact name or any uploaded files Various other small bugfixes optimizations Commits https://github.com/actions/upload-artifact/commit/da838ae9595ac94171fa2d4de5a2f117b3e7ac32;>da838ae Bump @actions/artifact to version 0.6.0 (https://github-redirect.dependabot.com/actions/upload-artifact/issues/280;>#280) https://github.com/actions/upload-artifact/commit/f4ac36d2052d09212226799b513ca60c91a09bfc;>f4ac36d Improve readme (https://github-redirect.dependabot.com/actions/upload-artifact/issues/278;>#278) https://github.com/actions/upload-artifact/commit/5f375cca4b67e6d6865358725f7b3016adc11dd4;>5f375cc Document how to correctly use environment variables for path input (https://github-redirect.dependabot.com/actions/upload-artifact/issues/274;>#274) https://github.com/actions/upload-artifact/commit/a009a665852a6c3bc5ab565a11a018832fe15091;>a009a66 Create release-new-action-version.yml (https://github-redirect.dependabot.com/actions/upload-artifact/issues/277;>#277) https://github.com/actions/upload-artifact/commit/b9bb65708e7331a369b0937a0897fb742d432b56;>b9bb657 Bump tmpl from 1.0.4 to 1.0.5 (https://github-redirect.dependabot.com/actions/upload-artifact/issues/250;>#250) https://github.com/actions/upload-artifact/commit/0b3de3e43bf7f3b625fa089190db4b56f80bb1d1;>0b3de3e Fix README.md links and some formatting updates (https://github-redirect.dependabot.com/actions/upload-artifact/issues/273;>#273) https://github.com/actions/upload-artifact/commit/54f3f7f0812216756785ff65b2caff7e3b46a054;>54f3f7f Merge pull request https://github-redirect.dependabot.com/actions/upload-artifact/issues/271;>#271 from actions/robherley/dupe-issue-template https://github.com/actions/upload-artifact/commit/f061e61d7533decd8336b3099489e518d23db3e8;>f061e61 rm dupe security vulnerability from issue template https://github.com/actions/upload-artifact/commit/ee82d6a40e9710e2da219e7d8479ee7b51ffa9b7;>ee82d6a Merge pull request https://github-redirect.dependabot.com/actions/upload-artifact/issues/269;>#269 from actions/robherley/update-issue-templates https://github.com/actions/upload-artifact/commit/ecd66f168360fa6af3cd2cfe213a85f7a9d248bf;>ecd66f1 add issue templates Additional commits viewable in https://github.com/actions/upload-artifact/compare/v2.2.4...v2.3.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
[apisix-dashboard] branch dependabot/github_actions/actions/upload-artifact-2.3.0 created (now c640039)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/upload-artifact-2.3.0 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at c640039 chore(deps): bump actions/upload-artifact from 2.2.4 to 2.3.0 No new revisions were added by this update.
[GitHub] [apisix] Horus-K commented on issue #5737: docs: how to traffic service percentage
Horus-K commented on issue #5737: URL: https://github.com/apache/apisix/issues/5737#issuecomment-988526077 We have a very large user base，I need control plugings(response-rewrite.body) change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5736: docs(ldap-auth): add consumer parameters for ldap
juzhiyuan commented on a change in pull request #5736: URL: https://github.com/apache/apisix/pull/5736#discussion_r764570848 ## File path: docs/en/latest/plugins/ldap-auth.md ## @@ -41,12 +41,13 @@ This authentication plugin use [lualdap](https://lualdap.github.io/lualdap/) plu ## Attributes -| Name | Type | Requirement | Default | Valid | Description | -| | -- | --- | --- | - | | -| base_dn | string | required| | | the base dn of the `ldap` server (example : `ou=users,dc=example,dc=org`) | -| ldap_uri | string | required| | | the uri of the ldap server | -| use_tls | boolean | optional|`true` | | Boolean flag indicating if Transport Layer Security (TLS) should be used. | -| uid | string | optional| `cn` | | the `uid` attribute | +| Name | Type| Requirement | Default | Valid | |Description | +| | --- | --- | --- | - | | +| base_dn | string | required| | | the base dn of the `ldap` server (example : `ou=users,dc=example,dc=org`) | +| ldap_uri | string | required| | | the uri of the ldap server | +| use_tls | boolean | optional| `true` | | Boolean flag indicating if Transport Layer Security (TLS) should be used. | +| uid | string | optional| `cn`| | the `uid` attribute | +| user_dn | string | required| | | the user dn of the `ladp` client (example: `cn=user01,ou=users,dc=example,dc=org`) | Review comment: Hi @zaunist, thanks to pick this issue! Here has one sample from https://apisix.apache.org/docs/apisix/plugins/key-auth#attributes , and it splits attributes into 2 parts: For Consumer and For Route/Service, please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Horus-K opened a new issue #5737: docs: how to traffic service percentage
Horus-K opened a new issue #5737: URL: https://github.com/apache/apisix/issues/5737 ### Improved or typo fixed. How do I verify the correctness of the plugins ### Solution I want to be able to use traffic-split similar plug-ins to control the percentage of service traffic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zaunist commented on issue #5668: docs: ldap-auth plugin's doc is missing Consumer parameters
zaunist commented on issue #5668: URL: https://github.com/apache/apisix/issues/5668#issuecomment-988524341 Hi, @juzhiyuan. I just open a pull request to add consumer parameter, https://github.com/apache/apisix/pull/5736. Please take a look.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #787: request help: ApisixRoute apiversion Inconsistency
tao12345666333 commented on issue #787: URL: https://github.com/apache/apisix-ingress-controller/issues/787#issuecomment-988524325 And which CRD configuration are you using? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5573: docs: dont found the usage of etcd in discovery.md
juzhiyuan commented on issue #5573: URL: https://github.com/apache/apisix/issues/5573#issuecomment-988523924 Hi @bzp2010, could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #787: request help: ApisixRoute apiversion Inconsistency
tao12345666333 commented on issue #787: URL: https://github.com/apache/apisix-ingress-controller/issues/787#issuecomment-988523864 `delete` then `create` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zaunist opened a new pull request #5736: docs(ldap-auth): add consumer parameters for ldap
zaunist opened a new pull request #5736: URL: https://github.com/apache/apisix/pull/5736 ### What this PR does / why we need it: Ldap-auth plugin docs are missing parameters when configuring Consumer. see https://apisix.apache.org/docs/apisix/plugins/ldap-auth/ And ldap-auth implementation is here https://github.com/apache/apisix/blob/master/apisix/plugins/ldap-auth.lua#L40-L47 resolve#5668 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a2f3475) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `10.97%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 58.89% -10.98% === Files 184 168 -16 Lines7274 6540 -734 Branches 829 829 === - Hits 5083 3852 -1231 - Misses 1897 2488 +591 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `68.06% <ø> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | |
[GitHub] [apisix] juzhiyuan commented on issue #5733: request help: sometimes connection refused while using service ip to connect the upstream
juzhiyuan commented on issue #5733: URL: https://github.com/apache/apisix/issues/5733#issuecomment-988516590 Hi @leslie-tsang, could you give some ideas on how to debug this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a2f3475) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.71%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.16% -20.72% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1559 -3524 + Misses 1897 1412 -485 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00%
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (93bd438) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.71%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.16% -20.72% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1559 -3524 + Misses 1897 1412 -485 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.16% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00%
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (61a6397) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `20.74%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 49.13% -20.75% === Files 184 41 -143 Lines7274 3171 -4103 Branches 8290 -829 === - Hits 5083 1558 -3525 + Misses 1897 1413 -484 + Partials 294 200 -94 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `49.13% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-72.60%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/proto/proto.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcHJvdG8vcHJvdG8uZ28=) | `0.00% <0.00%> (-67.26%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] zaunist commented on pull request #2200: test: migrate route_export_test e2e
zaunist commented on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-988504604 > Why the PR has too many changes? Sorry, I will fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #785: docs: Optimize installation documentation
tao12345666333 commented on pull request #785: URL: https://github.com/apache/apisix-ingress-controller/pull/785#issuecomment-988503986 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #785: docs: Optimize installation documentation
tao12345666333 merged pull request #785: URL: https://github.com/apache/apisix-ingress-controller/pull/785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: docs: Optimize installation documentation (#785)
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 1b2bc34 docs: Optimize installation documentation (#785) 1b2bc34 is described below commit 1b2bc3418bd2c7a2a085e55d7bf937b5c27f1ddb Author: Baoyuan AuthorDate: Tue Dec 7 23:08:52 2021 -0600 docs: Optimize installation documentation (#785) --- docs/en/latest/deployments/ack.md| 3 +-- docs/en/latest/deployments/aws.md| 3 +-- docs/en/latest/deployments/azure.md | 3 +-- docs/en/latest/deployments/gke.md| 3 +-- docs/en/latest/deployments/k3s-rke.md| 3 +-- docs/en/latest/deployments/kubesphere.md | 3 +-- docs/en/latest/deployments/minikube.md | 3 +-- docs/en/latest/deployments/tke.md| 3 +-- 8 files changed, 8 insertions(+), 16 deletions(-) diff --git a/docs/en/latest/deployments/ack.md b/docs/en/latest/deployments/ack.md index c06185c..3e0966f 100644 --- a/docs/en/latest/deployments/ack.md +++ b/docs/en/latest/deployments/ack.md @@ -28,7 +28,6 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https:// * Create an ACK Service on ali-cloud. * Download the kube config for your ACK, follow the [introduction](https://www.alibabacloud.com/help/zh/doc-detail/86378.html). * Install [Helm](https://helm.sh/). -* **Make sure your target namespace exists**, `kubectl` operations thorough this document will be executed in namespace `ingress-apisix`. ## Install APISIX and apisix-ingress-controller @@ -44,7 +43,7 @@ helm install apisix apisix/apisix \ --set ingress-controller.enabled=true \ --set etcd.persistence.storageClass="alicloud-disk-ssd" \ --set etcd.persistence.size="20Gi" \ - --namespace ingress-apisix + --namespace ingress-apisix \ --set ingress-controller.config.apisix.serviceNamespace=ingress-apisix kubectl get service --namespace ingress-apisix ``` diff --git a/docs/en/latest/deployments/aws.md b/docs/en/latest/deployments/aws.md index 5b5660e..e717a3e 100644 --- a/docs/en/latest/deployments/aws.md +++ b/docs/en/latest/deployments/aws.md @@ -28,7 +28,6 @@ This document explains how to install Ingress APISIX on [Amazon EKS](https://ama * Create an EKS Service on AWS. * Download the kube config for your EKS from [aws cli interface](https://amazonaws-china.com/cli/). * Install [Helm](https://helm.sh/). -* Make sure your target namespace exists, kubectl operations thorough this document will be executed in namespace `ingress-apisix`. ## Install APISIX and apisix-ingress-controller @@ -42,7 +41,7 @@ kubectl create ns ingress-apisix helm install apisix apisix/apisix \ --set gateway.type=LoadBalancer \ --set ingress-controller.enabled=true \ - --namespace ingress-apisix + --namespace ingress-apisix \ --set ingress-controller.config.apisix.serviceNamespace=ingress-apisix kubectl get service --namespace ingress-apisix ``` diff --git a/docs/en/latest/deployments/azure.md b/docs/en/latest/deployments/azure.md index cd6bddc..d9ca438 100644 --- a/docs/en/latest/deployments/azure.md +++ b/docs/en/latest/deployments/azure.md @@ -28,7 +28,6 @@ This document explains how to install Ingress APISIX on [Azure AKS](https://docs * Create an Kubernetes Service on Azure. * Install [Azure CLI](https://docs.microsoft.com/en-us/cli/azure/#:~:text=The%20Azure%20command%2Dline%20interface,with%20an%20emphasis%20on%20automation.) and download the credentials by running `az aks get-credentials`. * Install [Helm](https://helm.sh/). -* Make sure your target namespace exists, kubectl operations thorough this document will be executed in namespace `ingress-apisix`. ## Install APISIX and apisix-ingress-controller @@ -42,7 +41,7 @@ kubectl create ns ingress-apisix helm install apisix apisix/apisix \ --set gateway.type=LoadBalancer \ --set ingress-controller.enabled=true \ - --namespace ingress-apisix + --namespace ingress-apisix \ --set ingress-controller.config.apisix.serviceNamespace=ingress-apisix kubectl get service --namespace ingress-apisix ``` diff --git a/docs/en/latest/deployments/gke.md b/docs/en/latest/deployments/gke.md index 52bb3c1..3a4662e 100644 --- a/docs/en/latest/deployments/gke.md +++ b/docs/en/latest/deployments/gke.md @@ -28,7 +28,6 @@ This document explains how to install Ingress APISIX on [Google Cloud GKE](https * Create an Kubernetes Service on GKE. * Install [Google Cloud SDK](https://cloud.google.com/sdk) and get the credentials or you can just use the [Cloud Shell](https://cloud.google.com/shell). * Install [Helm](https://helm.sh/). -* Make sure your target namespace exists, kubectl operations thorough this document will be executed in namespace `ingress-apisix`. ## Install APISIX and apisix-ingress-controller @@ -42,7 +41,7 @@ kubectl create ns ingress-apisix helm install
[GitHub] [apisix] shuaijinchao opened a new pull request #5735: fix(log-rotate): after enabling compression collect log exceptions
shuaijinchao opened a new pull request #5735: URL: https://github.com/apache/apisix/pull/5735 (cherry picked from commit 139c3972898f1e45c6d5b1f40143c504116b3486) ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] juzhiyuan commented on pull request #785: docs: Optimize installation documentation
juzhiyuan commented on pull request #785: URL: https://github.com/apache/apisix-ingress-controller/pull/785#issuecomment-988475605 LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan closed issue #5709: return 504
juzhiyuan closed issue #5709: URL: https://github.com/apache/apisix/issues/5709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 opened a new pull request #5734: feat: support OPA plugin
bzp2010 opened a new pull request #5734: URL: https://github.com/apache/apisix/pull/5734 ### What this PR does / why we need it: Add OPA plugin to support API access control using OPA services. implement #5714 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] sekfung opened a new issue #5733: request help: sometimes connection refused while using service ip to connect the upstream
sekfung opened a new issue #5733: URL: https://github.com/apache/apisix/issues/5733 ### Issue description **error log** ```log [error] 48#48: *2240177 connect() failed (111: Connection refused) while connecting to upstream [lua] balancer.lua:327: run(): failed to pick server: failed to find valid upstream server, all upstream servers tried while connecting to upstream ``` It can work sometimes, I try to increase times of retry for the route, but it can't solve this problem at all. ### Environment - apisix version (cmd: `apisix version`): 2.10.1 - OS (cmd: `uname -a`): Linux apisix-6df8748bf6-v5hnb 4.14.105-19-0022 - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): openresty/1.19.3.1 - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): etcd Version: 3.4.16 - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on issue #5709: return 504
leslie-tsang commented on issue #5709: URL: https://github.com/apache/apisix/issues/5709#issuecomment-988470685 @juzhiyuan Consider solved. Feel free to reopen it if need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] qq54903099 opened a new pull request #5732: feat: consumer-restriction add reject-message
qq54903099 opened a new pull request #5732: URL: https://github.com/apache/apisix/pull/5732 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] qq54903099 closed pull request #5731: feat: consumer-restriction add reject-message
qq54903099 closed pull request #5731: URL: https://github.com/apache/apisix/pull/5731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] qq54903099 opened a new pull request #5731: feat: consumer-restriction add reject-message
qq54903099 opened a new pull request #5731: URL: https://github.com/apache/apisix/pull/5731 ### What this PR does / why we need it: Custom return message content ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1595: feat: Show route ID at LIST and EDIT views in dashboard
juzhiyuan commented on issue #1595: URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-988460587 Oh btw, we have a meeting today, welcome to join in if you have time see https://github.com/apache/apisix/discussions/5721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1595: feat: Show route ID at LIST and EDIT views in dashboard
juzhiyuan commented on issue #1595: URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-988460167 Hi @mangoGoForward, you could do it if no PR linked to this issue If I'm late to reply you, just @ me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #768: request help: path like /api/*/action
tao12345666333 closed issue #768: URL: https://github.com/apache/apisix-ingress-controller/issues/768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #779: feat: support regex in path
tao12345666333 merged pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: feat: support regex in path (#779)
This is an automated email from the ASF dual-hosted git repository.
zhangjintao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 4e84eb8 feat: support regex in path (#779)
4e84eb8 is described below
commit 4e84eb8c88ff922c130dba225ff80a5f52c6b571
Author: LXM
AuthorDate: Wed Dec 8 11:10:55 2021 +0800
feat: support regex in path (#779)
---
docs/en/latest/concepts/annotations.md| 40 +++
pkg/kube/translation/annotations/cors.go | 8 +-
pkg/kube/translation/annotations/iprestriction.go | 4 +-
pkg/kube/translation/annotations/redirect.go | 2 +-
pkg/kube/translation/annotations/rewrite.go | 6 +-
pkg/kube/translation/annotations/types.go | 5 +
pkg/kube/translation/ingress.go | 169 +
pkg/kube/translation/ingress_test.go | 290 ++
test/e2e/ingress/ingress.go | 131 ++
9 files changed, 596 insertions(+), 59 deletions(-)
diff --git a/docs/en/latest/concepts/annotations.md
b/docs/en/latest/concepts/annotations.md
index 73855be..0216354 100644
--- a/docs/en/latest/concepts/annotations.md
+++ b/docs/en/latest/concepts/annotations.md
@@ -131,3 +131,43 @@ spec:
port:
number: 80
```
+
+Path regular expression
+-
+
+You can use the follow annotations to enable path regular expression
+
+* `k8s.apisix.apache.org/use-regex`
+
+If this annotations set to `true` and the `PathType` set to
`ImplementationSpecific`, the path will be match as regular expression.
+
+For example, the follwing Ingress. Request path with `/api/*/action1` will use
`service1` and `/api/*/action2` will be use `service2`
+
+```yaml
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+ annotations:
+kubernetes.io/ingress.class: apisix
+k8s.apisix.apache.org/use-regex: "true"
+ name: ingress-v1
+spec:
+ rules:
+ - host: httpbin.org
+http:
+ paths:
+ - path: /api/.*/action1
+pathType: ImplementationSpecific
+backend:
+ service:
+name: service1
+port:
+ number: 80
+ - path: /api/.*/action2
+pathType: ImplementationSpecific
+backend:
+ service:
+name: service2
+port:
+ number: 80
+```
diff --git a/pkg/kube/translation/annotations/cors.go
b/pkg/kube/translation/annotations/cors.go
index c2b8628..ee88e6c 100644
--- a/pkg/kube/translation/annotations/cors.go
+++ b/pkg/kube/translation/annotations/cors.go
@@ -19,10 +19,10 @@ import (
)
const (
- _enableCors = "k8s.apisix.apache.org/enable-cors"
- _corsAllowOrigin = "k8s.apisix.apache.org/cors-allow-origin"
- _corsAllowHeaders = "k8s.apisix.apache.org/cors-allow-headers"
- _corsAllowMethods = "k8s.apisix.apache.org/cors-allow-methods"
+ _enableCors = AnnotationsPrefix + "enable-cors"
+ _corsAllowOrigin = AnnotationsPrefix + "cors-allow-origin"
+ _corsAllowHeaders = AnnotationsPrefix + "cors-allow-headers"
+ _corsAllowMethods = AnnotationsPrefix + "cors-allow-methods"
)
type cors struct{}
diff --git a/pkg/kube/translation/annotations/iprestriction.go
b/pkg/kube/translation/annotations/iprestriction.go
index 735b958..1d17957 100644
--- a/pkg/kube/translation/annotations/iprestriction.go
+++ b/pkg/kube/translation/annotations/iprestriction.go
@@ -19,8 +19,8 @@ import (
)
const (
- _allowlistSourceRange = "k8s.apisix.apache.org/allowlist-source-range"
- _blocklistSourceRange = "k8s.apisix.apache.org/blocklist-source-range"
+ _allowlistSourceRange = AnnotationsPrefix + "allowlist-source-range"
+ _blocklistSourceRange = AnnotationsPrefix + "blocklist-source-range"
)
type ipRestriction struct{}
diff --git a/pkg/kube/translation/annotations/redirect.go
b/pkg/kube/translation/annotations/redirect.go
index e10d5f8..c162d84 100644
--- a/pkg/kube/translation/annotations/redirect.go
+++ b/pkg/kube/translation/annotations/redirect.go
@@ -19,7 +19,7 @@ import (
)
const (
- _httpToHttps = "k8s.apisix.apache.org/http-to-https"
+ _httpToHttps = AnnotationsPrefix + "http-to-https"
)
type redirect struct{}
diff --git a/pkg/kube/translation/annotations/rewrite.go
b/pkg/kube/translation/annotations/rewrite.go
index 72e2385..35a0f94 100644
--- a/pkg/kube/translation/annotations/rewrite.go
+++ b/pkg/kube/translation/annotations/rewrite.go
@@ -21,9 +21,9 @@ import (
)
const (
- _rewriteTarget = "k8s.apisix.apache.org/rewrite-target"
- _rewriteTargetRegex =
"k8s.apisix.apache.org/rewrite-target-regex"
- _rewriteTargetRegexTemplate =
"k8s.apisix.apache.org/rewrite-target-regex-template"
+ _rewriteTarget = AnnotationsPrefix + "rewrite-target"
+
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #779: feat: support regex in path
tao12345666333 commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-988457214 ok I understand your situation, I have added it to v1.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2223: request help :apisix-dashboard Dockerfile and build.sh error
juzhiyuan commented on issue #2223: URL: https://github.com/apache/apisix-dashboard/issues/2223#issuecomment-988454236 Hi @GhangZh, may I know if this issue gets resolved? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zlhgo commented on issue #5596: request help: customize Nginx variable in the configuration
zlhgo commented on issue #5596:
URL: https://github.com/apache/apisix/issues/5596#issuecomment-988449351
```
diff --git a/apisix/cli/ngx_tpl.lua b/apisix/cli/ngx_tpl.lua
index f5fa5d6e..523ae4d7 100644
--- a/apisix/cli/ngx_tpl.lua
+++ b/apisix/cli/ngx_tpl.lua
@@ -573,6 +573,12 @@ http {
set $ctx_ref '';
set $from_error_page '';
+# http server location configuration snippet starts
+{% if http_server_location_configuration_snippet then %}
+{* http_server_location_configuration_snippet *}
+{% end %}
+# http server location configuration snippet ends
+
{% if enabled_plugins["dubbo-proxy"] then %}
set $dubbo_service_name '';
set $dubbo_service_version '';
diff --git a/conf/config-default.yaml b/conf/config-default.yaml
index 7be15f92..3d089bdb 100644
--- a/conf/config-default.yaml
+++ b/conf/config-default.yaml
@@ -191,6 +191,9 @@ nginx_config: # config for render
the template to generate n
http_server_configuration_snippet: |
# Add custom Nginx http server configuration to nginx.conf.
# The configuration should be well indented!
+ http_server_location_configuration_snippet: |
+# Add custom Nginx http server location configuration to nginx.conf.
+# The configuration should be well indented!
http_admin_configuration_snippet: |
# Add custom Nginx admin server configuration to nginx.conf.
# The configuration should be well indented!
```
So simple?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zero-create commented on issue #5723: CPU usage gets higher when Apache APISIX is running a long time
zero-create commented on issue #5723: URL: https://github.com/apache/apisix/issues/5723#issuecomment-988434821 > related to: #5692 > > can you provide packet capture data for the network between apisix and etcd? [etcd1.zip](https://github.com/apache/apisix/files/7672833/etcd1.zip) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zero-create commented on issue #5723: CPU usage gets higher when Apache APISIX is running a long time
zero-create commented on issue #5723: URL: https://github.com/apache/apisix/issues/5723#issuecomment-988434211 > 相关： #5692 > > 能否为 apisix 和 etcd 之间的网络提供数据包捕获数据？ [etcd1.zip](https://github.com/apache/apisix/files/7672821/etcd1.zip) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zero-create removed a comment on issue #5723: CPU usage gets higher when Apache APISIX is running a long time
zero-create removed a comment on issue #5723: URL: https://github.com/apache/apisix/issues/5723#issuecomment-988434211 > 相关： #5692 > > 能否为 apisix 和 etcd 之间的网络提供数据包捕获数据？ [etcd1.zip](https://github.com/apache/apisix/files/7672821/etcd1.zip) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xuminwlt commented on issue #5729: request help: module 'toolkit.json' not found when use test-nginx for unit test
xuminwlt commented on issue #5729: URL: https://github.com/apache/apisix/issues/5729#issuecomment-988432810 Problem solved，clone to the t/ path is right，i have copied it to /t/lib, /t/lib is wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xuminwlt closed issue #5729: request help: module 'toolkit.json' not found when use test-nginx for unit test
xuminwlt closed issue #5729: URL: https://github.com/apache/apisix/issues/5729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on pull request #779: feat: support regex in path
lxm commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-988431614 > Thd code LGTM > > I added the label of `do-not-merge/hold` to it because this feature is not planned to be in the v1.4 version. > > Do you have a strong demand for this feature? @lxm right, I want to use apisix-ingress-controller to replace the nginx-ingress-controller without this feature, this can not be done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #779: feat: support regex in path
tao12345666333 commented on pull request #779: URL: https://github.com/apache/apisix-ingress-controller/pull/779#issuecomment-988423022 Thd code LGTM I added the label of `do-not-merge/hold` to it because this feature is not planned to be in the v1.4 version. Do you have a strong demand for this feature? @lxm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xuminwlt commented on issue #5729: request help: module 'toolkit.json' not found when use test-nginx for unit test
xuminwlt commented on issue #5729: URL: https://github.com/apache/apisix/issues/5729#issuecomment-988419811 > 1. it is not recommended that apisix be placed in the `root` directory; > 2. basically my directory structure is similar to yours. Looking at the search path in the error output, it doesn't search for a path under `/root/apisix` at all. root is my example path, the true path is my account path ~/github/apisix The error message should be that I found the file under APIs / T / Toolkit, but the preload failed. I don't know why. Maybe I need to find the answer. Maybe I can be a contribute for these question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2200: test: migrate route_export_test e2e
juzhiyuan commented on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-988412954  Maybe due to the force-push? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #792: Keep the same language in blog
juzhiyuan commented on issue #792: URL: https://github.com/apache/apisix-website/issues/792#issuecomment-988410907 **Update** I noticed our Medium has some images in Chinese 樂 We will improve them **in the future**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan edited a comment on issue #792: Keep the same language in blog
juzhiyuan edited a comment on issue #792: URL: https://github.com/apache/apisix-website/issues/792#issuecomment-988410907 **Update** I noticed our Medium has some images in Chinese 樂 We will improve them **in the future**. http://medium.com/@apacheapisix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #5718: docs: refactor Installation Guide
tokers commented on pull request #5718: URL: https://github.com/apache/apisix/pull/5718#issuecomment-988409981 > > How about doing it in another PR? Because this PR's destination is to refactor only Install part. > > I think so +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5715: fix(log-rotate): after enabling compression collect log exceptions
spacewander merged pull request #5715: URL: https://github.com/apache/apisix/pull/5715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #5658: request help: unable to collect logs when log-rotate plugin is enabled
spacewander closed issue #5658: URL: https://github.com/apache/apisix/issues/5658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: fix(log-rotate): after enabling compression collect log exceptions (#5715)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 139c397 fix(log-rotate): after enabling compression collect log
exceptions (#5715)
139c397 is described below
commit 139c3972898f1e45c6d5b1f40143c504116b3486
Author: 帅进超
AuthorDate: Wed Dec 8 09:28:03 2021 +0800
fix(log-rotate): after enabling compression collect log exceptions (#5715)
---
apisix/plugins/log-rotate.lua | 202 --
t/plugin/log-rotate.t | 59 ++--
t/plugin/log-rotate2.t| 54 +--
3 files changed, 233 insertions(+), 82 deletions(-)
diff --git a/apisix/plugins/log-rotate.lua b/apisix/plugins/log-rotate.lua
index 273dc01..5b711c9 100644
--- a/apisix/plugins/log-rotate.lua
+++ b/apisix/plugins/log-rotate.lua
@@ -22,12 +22,21 @@ local process = require("ngx.process")
local signal = require("resty.signal")
local shell = require("resty.shell")
local ngx = ngx
+local ngx_time = ngx.time
+local ngx_update_time = ngx.update_time
local lfs = require("lfs")
-local io = io
-local os = os
-local table = table
-local string = string
-local str_find = core.string.find
+local type = type
+local io_open = io.open
+local os_date = os.date
+local os_remove = os.remove
+local os_rename = os.rename
+local str_sub = string.sub
+local str_find = string.find
+local str_format = string.format
+local str_reverse = string.reverse
+local tab_insert = table.insert
+local tab_sort = table.sort
+
local local_conf
@@ -35,7 +44,11 @@ local plugin_name = "log-rotate"
local INTERVAL = 60 * 60-- rotate interval (unit: second)
local MAX_KEPT = 24 * 7 -- max number of log files will be kept
local COMPRESSION_FILE_SUFFIX = ".tar.gz" -- compression file suffix
+local rotate_time
+local default_logs
local enable_compression = false
+local DEFAULT_ACCESS_LOG_FILENAME = "access.log"
+local DEFAULT_ERROR_LOG_FILENAME = "error.log"
local schema = {
type = "object",
@@ -53,7 +66,7 @@ local _M = {
local function file_exists(path)
-local file = io.open(path, "r")
+local file = io_open(path, "r")
if file then
file:close()
end
@@ -62,7 +75,7 @@ end
local function get_last_index(str, key)
-local rev = string.reverse(str)
+local rev = str_reverse(str)
local _, idx = str_find(rev, key)
local n
if idx then
@@ -88,15 +101,15 @@ local function get_log_path_info(file_type)
local prefix = ngx.config.prefix()
if conf_path then
-local root = string.sub(conf_path, 1, 1)
+local root = str_sub(conf_path, 1, 1)
-- relative path
if root ~= "/" then
conf_path = prefix .. conf_path
end
local n = get_last_index(conf_path, "/")
if n ~= nil and n ~= #conf_path then
-local dir = string.sub(conf_path, 1, n)
-local name = string.sub(conf_path, n + 1)
+local dir = str_sub(conf_path, 1, n)
+local name = str_sub(conf_path, n + 1)
return dir, name
end
end
@@ -105,50 +118,11 @@ local function get_log_path_info(file_type)
end
-local function rotate_file(date_str, file_type)
-local log_dir, filename = get_log_path_info(file_type)
-
-core.log.info("rotate log_dir:", log_dir)
-core.log.info("rotate filename:", filename)
-
-local new_filename = date_str .. "__" .. filename
-local file_path = log_dir .. new_filename
-if file_exists(file_path) then
-core.log.info("file exist: ", file_path)
-return false
-end
-
-local file_path_org = log_dir .. filename
-local ok, msg = os.rename(file_path_org, file_path)
-core.log.info("move file from ", file_path_org, " to ", file_path,
- " res:", ok, " msg:", msg)
-
-if ok and enable_compression then
-local compression_filename = new_filename .. COMPRESSION_FILE_SUFFIX
-local cmd = string.format("cd %s && tar -zcf %s %s",
-log_dir, compression_filename, new_filename)
-core.log.info("log file compress command: " .. cmd)
-local ok, stdout, stderr, reason, status = shell.run(cmd)
-core.log.info("compress log file from ", new_filename, " to ",
compression_filename,
-" res:", ok)
-
-if ok then
-ok = os.remove(file_path)
-core.log.warn("remove uncompressed log file: ", file_path, " ret:
", ok)
-else
-core.log.error("failed to compress log file: ", new_filename, "
ret: ", ok,
-" stdout: ", stdout, " stderr: ", stderr, " reason: ", reason,
" status: ", status)
-end
-end
-
-return true
-end
-
-
-local function tab_sort(a, b)
+local function tab_sort_comp(a, b)
return a > b
end
+
local function scan_log_folder()
local t = {
[GitHub] [apisix] spacewander closed issue #5663: bug: log-rotate.lua
spacewander closed issue #5663: URL: https://github.com/apache/apisix/issues/5663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5717: test(kafka-logger): reduce duplicate sections
spacewander merged pull request #5717: URL: https://github.com/apache/apisix/pull/5717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: test(kafka-logger): reduce duplicate sections (#5717)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new bc091ad test(kafka-logger): reduce duplicate sections (#5717)
bc091ad is described below
commit bc091ad433be7bf7b13fae3e9356e529657cb0be
Author: 罗泽轩
AuthorDate: Wed Dec 8 09:11:46 2021 +0800
test(kafka-logger): reduce duplicate sections (#5717)
---
t/plugin/kafka-logger.t | 689 +--
t/plugin/kafka-logger2.t | 611 +
2 files changed, 624 insertions(+), 676 deletions(-)
diff --git a/t/plugin/kafka-logger.t b/t/plugin/kafka-logger.t
index 42277c6..0cc68fe 100644
--- a/t/plugin/kafka-logger.t
+++ b/t/plugin/kafka-logger.t
@@ -19,6 +19,19 @@ use t::APISIX 'no_plan';
repeat_each(1);
no_long_string();
no_root_location();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if (!$block->request) {
+$block->set_value("request", "GET /t");
+}
+
+if ((!defined $block->error_log) && (!defined $block->no_error_log)) {
+$block->set_value("no_error_log", "[error]");
+}
+});
+
run_tests;
__DATA__
@@ -41,12 +54,8 @@ __DATA__
ngx.say("done")
}
}
request
-GET /t
--- response_body
done
no_error_log
-[error]
@@ -62,13 +71,9 @@ done
ngx.say("done")
}
}
request
-GET /t
--- response_body
property "broker_list" is required
done
no_error_log
-[error]
@@ -91,13 +96,9 @@ done
ngx.say("done")
}
}
request
-GET /t
--- response_body
property "timeout" validation failed: wrong type: expected integer, got string
done
no_error_log
-[error]
@@ -163,12 +164,8 @@ done
ngx.say(body)
}
}
request
-GET /t
--- response_body
passed
no_error_log
-[error]
@@ -177,8 +174,6 @@ passed
GET /hello
--- response_body
hello world
no_error_log
-[error]
--- wait: 2
@@ -251,8 +246,6 @@ hello world
local res, err = httpc:request_uri(uri, {method = "GET"})
}
}
request
-GET /t
--- error_log
failed to send data to Kafka topic
[error]
@@ -296,12 +289,8 @@ failed to send data to Kafka topic
ngx.say(body)
}
}
request
-GET /t
--- response_body
passed
no_error_log
-[error]
@@ -311,8 +300,6 @@ GET /hello?ab=cd
abcdef
--- response_body
hello world
no_error_log
-[error]
--- error_log
send data to kafka: GET /hello?ab=cd HTTP/1.1
host: localhost
@@ -360,12 +347,8 @@ abcdef
ngx.say(body)
}
}
request
-GET /t
--- response_body
passed
no_error_log
-[error]
@@ -375,8 +358,6 @@ GET /hello?ab=cd
abcdef
--- response_body
hello world
no_error_log
-[error]
--- error_log
send data to kafka: GET /hello?ab=cd HTTP/1.1
host: localhost
@@ -421,12 +402,8 @@ connection: close
ngx.say(body)
}
}
request
-GET /t
--- response_body
passed
no_error_log
-[error]
@@ -436,8 +413,6 @@ GET /hello?ab=cd
abcdef
--- response_body
hello world
no_error_log
-[error]
--- error_log_like eval
qr/send data to kafka: \{.*"upstream":"127.0.0.1:1980"/
--- wait: 2
@@ -504,12 +479,8 @@ qr/send data to kafka: \{.*"upstream":"127.0.0.1:1980"/
ngx.say(body)
}
}
request
-GET /t
--- response_body
passed
no_error_log
-[error]
@@ -518,8 +489,6 @@ passed
GET /hello
--- response_body
hello world
no_error_log
-[error]
--- wait: 2
@@ -558,12 +527,8 @@ hello world
ngx.say(body)
}
}
request
-GET /t
--- response_body
passed
no_error_log
-[error]
@@ -573,8 +538,6 @@ GET /hello?ab=cd
abcdef
--- response_body
hello world
no_error_log
-[error]
--- error_log_like eval
qr/send data to kafka: \{.*"upstream":"127.0.0.1:1980"/
--- wait: 2
@@ -615,12 +578,8 @@ qr/send data to kafka: \{.*"upstream":"127.0.0.1:1980"/
ngx.say(body)
}
}
request
-GET /t
--- response_body
passed
no_error_log
-[error]
@@ -662,12 +621,8 @@ passed
ngx.sleep(0.5)
}
}
request
-GET /t
--- timeout: 5s
--- ignore_response
no_error_log
-[error]
--- error_log eval
[qr/partition_id: 1/,
qr/partition_id: 0/,
@@ -712,627 +667,9 @@ qr/partition_id: 2/]
ngx.sleep(0.5)
}
}
request
-GET /t
--- timeout: 5s
--- ignore_response
no_error_log
-[error]
--- error_log eval
[qr/partition_id: 1/,
qr/partition_id: 0/,
qr/partition_id: 2/]
-
-
-
-=== TEST 20: required_acks, matches none of the enum values
config
-location /t {
-content_by_lua_block {
-local plugin = require("apisix.plugins.kafka-logger")
-local ok, err =
[GitHub] [apisix] membphis merged pull request #5716: chore: delete expired inspiration statements
membphis merged pull request #5716: URL: https://github.com/apache/apisix/pull/5716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: chore: delete expired inspiration statements (#5716)
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 5f50216 chore: delete expired inspiration statements (#5716) 5f50216 is described below commit 5f5021649ead293eaad41ccddc95fa9d3f5006b7 Author: tzssangglass AuthorDate: Tue Dec 7 18:44:31 2021 -0600 chore: delete expired inspiration statements (#5716) --- apisix/core/response.lua | 2 -- 1 file changed, 2 deletions(-) diff --git a/apisix/core/response.lua b/apisix/core/response.lua index 9ce9c40..221c184 100644 --- a/apisix/core/response.lua +++ b/apisix/core/response.lua @@ -164,8 +164,6 @@ end -- final_body = transform(final_body) -- ngx.arg[1] = final_body -- ... --- --- Inspired by kong.response.get_raw_body() function _M.hold_body_chunk(ctx, hold_the_copy) local body_buffer local chunk, eof = arg[1], arg[2]
[GitHub] [apisix] tzssangglass commented on pull request #5718: docs: refactor Installation Guide
tzssangglass commented on pull request #5718: URL: https://github.com/apache/apisix/pull/5718#issuecomment-988098157 > How about doing it in another PR? Because this PR's destination is to refactor only Install part. I think so -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5718: docs: refactor Installation Guide
juzhiyuan commented on pull request #5718: URL: https://github.com/apache/apisix/pull/5718#issuecomment-988046347 > are we going to do it in this PR? How about doing it in another PR? Because this PR's destination is to refactor only Install part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] alex8224 edited a comment on issue #5706: request help: How to route according to the configuration of nacos metadata?
alex8224 edited a comment on issue #5706:
URL: https://github.com/apache/apisix/issues/5706#issuecomment-988023902
@tzssangglass
**If so, that's pretty good**
Generally use the
127.0.0.1:8848/nacos/v1/ns/instance/list?serviceName=xxx=dev
interface to get all service instances under a namespaceId, The output of the
interface call is as follows
```json
{
"allIPs":false,
"cacheMillis":1,
"checksum":"",
"clusters":"",
"groupName":"DEFAULT_GROUP",
"hosts":[
{
"clusterName":"DEFAULT",
"enabled":true,
"ephemeral":true,
"healthy":true,
"instanceHeartBeatInterval":5000,
"instanceHeartBeatTimeOut":15000,
"instanceId":"192.26.0.7#9088#DEFAULT#DEFAULT_GROUP@@xxx",
"ip":"192.26.0.7",
"ipDeleteTimeout":3,
"metadata":{
"app.name":"xxx",
"preserved.register.source":"SPRING_CLOUD",
"startup.time":"1638849194096",
"dept":"HR"
},
"port":9088,
"serviceName":"DEFAULT_GROUP@@xxx",
"weight":1.0
},
{
"clusterName":"DEFAULT",
"enabled":true,
"ephemeral":true,
"healthy":true,
"instanceHeartBeatInterval":5000,
"instanceHeartBeatTimeOut":15000,
"instanceId":"192.26.0.6#9088#DEFAULT#DEFAULT_GROUP@@xxx",
"ip":"192.26.0.6",
"ipDeleteTimeout":3,
"metadata":{
"app.name":"xxx",
"preserved.register.source":"SPRING_CLOUD",
"startup.time":"1638849194096",
"dept":"IT"
},
"port":9088,
"serviceName":"DEFAULT_GROUP@@xxx",
"weight":1.0
},
{
"clusterName":"DEFAULT",
"enabled":true,
"ephemeral":true,
"healthy":true,
"instanceHeartBeatInterval":5000,
"instanceHeartBeatTimeOut":15000,
"instanceId":"192.26.0.9#9088#DEFAULT#DEFAULT_GROUP@@xxx",
"ip":"192.26.0.9",
"ipDeleteTimeout":3,
"metadata":{
"app.name":"xxx",
"preserved.register.source":"SPRING_CLOUD",
"startup.time":"1638849194096",
"dept":"HRP"
},
"port":9088,
"serviceName":"DEFAULT_GROUP@@xxx",
"weight":1.0
}
],
"lastRefTime":1638890095796,
"name":"DEFAULT_GROUP@@bcs-server",
"reachProtectionThreshold":false,
"valid":true
}```
There are several scenarios as follows
route url = /xxx/*
When the client requests /xxx/*
When header ["X-Real-Ip"] between ["192.168.1-192.168.1.10"], the request is
routed to the instance node with metadata field dept == HR, in this case node
192.26.0.7
Other requests that do not match are routed to nodes that do not match, in
this case to 192.26.0.6 and 192.26.0.9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] alex8224 commented on issue #5706: request help: How to route according to the configuration of nacos metadata?
alex8224 commented on issue #5706:
URL: https://github.com/apache/apisix/issues/5706#issuecomment-988023902
@tzssangglass
**If so, that's pretty good**
Generally use the
127.0.0.1:8848/nacos/v1/ns/instance/list?serviceName=xxx=dev
interface to get all service instances under a namespaceId, The output of the
interface call is as follows
`{
"allIPs": false,
"cacheMillis": 1,
"checksum": "",
"clusters": "",
"groupName": "DEFAULT_GROUP",
"hosts": [
{
"clusterName": "DEFAULT",
"enabled": true,
"ephemeral": true,
"healthy": true,
"instanceHeartBeatInterval": 5000,
"instanceHeartBeatTimeOut": 15000,
"instanceId": "192.26.0.7#9088#DEFAULT#DEFAULT_GROUP@@xxx",
"ip": "192.26.0.7",
"ipDeleteTimeout": 3,
"metadata": {
"app.name": "xxxr",
"preserved.register.source": "SPRING_CLOUD",
"startup.time": "1638849194096",
"tag": "gray-feature-v1"
},
"port": 9088,
"serviceName": "DEFAULT_GROUP@@bcs-server",
"weight": 1.0
}
],
"lastRefTime": 1638890095796,
"name": "DEFAULT_GROUP@@bcs-server",
"reachProtectionThreshold": false,
"valid": true } `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #5718: docs: refactor Installation Guide
tzssangglass commented on pull request #5718: URL: https://github.com/apache/apisix/pull/5718#issuecomment-988000493 > It's my understanding that we can prepare two files, the one for installation and the other one for building from the source. agree. are we going to do it in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5718: docs: refactor Installation Guide
tzssangglass commented on a change in pull request #5718: URL: https://github.com/apache/apisix/pull/5718#discussion_r764071076 ## File path: docs/zh/latest/how-to-build.md ## @@ -94,6 +95,23 @@ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-rep make install ``` +## 步骤2：安装 ETCD + +通过 RPM 或者 Docker 安装 Apache APISIX 时，需要执行此步骤。 + +你可以通过 Docker 或者二进制等方式安装 ETCD。以下命令通过二进制方式安装 ETCD。 + +```shell +ETCD_VERSION='3.4.13' Review comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5718: docs: refactor Installation Guide
tzssangglass commented on a change in pull request #5718: URL: https://github.com/apache/apisix/pull/5718#discussion_r764070892 ## File path: docs/en/latest/how-to-build.md ## @@ -94,6 +95,23 @@ Please refer to: [Installing Apache APISIX with Helm Chart](https://github.com/a make install ``` +## Step 2: Install ETCD + +This step is required when installing Apache APISIX via RPM or Docker. Review comment: I didn't find this document, I've changed the expression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5718: docs: refactor Installation Guide
tzssangglass commented on a change in pull request #5718:
URL: https://github.com/apache/apisix/pull/5718#discussion_r764070493
##
File path: docs/en/latest/how-to-build.md
##
@@ -94,6 +95,23 @@ Please refer to: [Installing Apache APISIX with Helm
Chart](https://github.com/a
make install
```
+## Step 2: Install ETCD
+
+This step is required when installing Apache APISIX via RPM or Docker.
+
+You can install ETCD via Docker or binary etc. The following command installs
ETCD via binary.
+
+```shell
+ETCD_VERSION='3.4.13'
+wget
https://github.com/etcd-io/etcd/releases/download/v${ETCD_VERSION}/etcd-v${ETCD_VERSION}-linux-amd64.tar.gz
+tar -xvf etcd-v${ETCD_VERSION}-linux-amd64.tar.gz && \
+cd etcd-v${ETCD_VERSION}-linux-amd64 && \
+sudo cp -a etcd etcdctl /usr/bin/
+nohup etcd &
+```
+
+Note: When ETCD is started with the command `nohup etcd &`, the data in ETCD
is not stored persistently. For more information on ETCD, please refer to the
[ETCD documentation](https://etcd.io/docs/).
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2200: test: migrate route_export_test e2e
codecov-commenter edited a comment on pull request #2200: URL: https://github.com/apache/apisix-dashboard/pull/2200#issuecomment-963965563 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2200](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (81b5006) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b86ff4c4ee7b129cfeda48108fe5d4f5a2e7c6c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6b86ff4) will **decrease** coverage by `16.34%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#2200 +/- ## === - Coverage 69.87% 53.53% -16.35% === Files 184 184 Lines7274 7274 Branches 829 829 === - Hits 5083 3894 -1189 - Misses 1897 3089 +1192 + Partials 294 291-3 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `40.94% <ø> (-3.59%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `68.12% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2200?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: | | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | `20.00% <0.00%> (-80.00%)` | :arrow_down: | | [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | `0.00% <0.00%> (-76.20%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `28.00% <0.00%> (-72.00%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `11.84% <0.00%> (-62.56%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `5.55% <0.00%> (-61.12%)` | :arrow_down: | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2200/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `40.00% <0.00%> (-60.00%)` | :arrow_down: | |
[GitHub] [apisix] tzssangglass commented on issue #5719: bug: when I use the kafka-logger plugin, failed to fetch the time in kafka
tzssangglass commented on issue #5719: URL: https://github.com/apache/apisix/issues/5719#issuecomment-987946660 pls describe it more clearly. From the information you have provided, I do not know what is `failed to fetch the time in kafka` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5729: request help: module 'toolkit.json' not found when use test-nginx for unit test
tzssangglass commented on issue #5729: URL: https://github.com/apache/apisix/issues/5729#issuecomment-987945840 1. it is not recommended that apisix be placed in the `root` directory; 2. basically my directory structure is similar to yours. Looking at the search path in the error output, it doesn't search for a path under `/root/apisix` at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
