[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #816: docs: add weekly report 12.15
netlify[bot] edited a comment on pull request #816: URL: https://github.com/apache/apisix-website/pull/816#issuecomment-997663426 ✔️ Deploy Preview for *apache-apisix* ready! Explore the source changes: 1239680c25bd53023448af74a76a8b8eaf652a80 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61c02fb844b8c80007062431](https://app.netlify.com/sites/apache-apisix/deploys/61c02fb844b8c80007062431) Browse the preview: [https://deploy-preview-816--apache-apisix.netlify.app](https://deploy-preview-816--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] zaunist commented on pull request #805: docs(READEME.md): change image size
zaunist commented on pull request #805: URL: https://github.com/apache/apisix-ingress-controller/pull/805#issuecomment-997663791 cc @gxthrj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] lijing-21 opened a new pull request #816: docs: add weekly report 12.15
lijing-21 opened a new pull request #816: URL: https://github.com/apache/apisix-website/pull/816 add weekly report 12.15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #816: docs: add weekly report 12.15
netlify[bot] commented on pull request #816: URL: https://github.com/apache/apisix-website/pull/816#issuecomment-997663426 Deploy Preview for *apache-apisix* processing. Explore the source changes: 1239680c25bd53023448af74a76a8b8eaf652a80 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61c02fb844b8c80007062431](https://app.netlify.com/sites/apache-apisix/deploys/61c02fb844b8c80007062431) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tisonkun opened a new issue #5860: docs: team page broken
tisonkun opened a new issue #5860: URL: https://github.com/apache/apisix/issues/5860 ### Improved or typo fixed.  https://apisix.apache.org/team/ ### Solution not yet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zjzwjcbj commented on issue #5791: request help: Custom plugin reload but unknown plugin
zjzwjcbj commented on issue #5791: URL: https://github.com/apache/apisix/issues/5791#issuecomment-997647616 > See https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/README.md, and you check focus on the configurations about `apisix.customPlugins`. I add the plugin in plugins in values.yaml It worked.Thanks a lot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] lookhua opened a new issue #197: Error: bad member ID arg (strconv.ParseUint: parsing "": invalid syntax), expecting ID in Hex
lookhua opened a new issue #197: URL: https://github.com/apache/apisix-helm-chart/issues/197 k8s version: 1.20.11-aliyun.1 **first time deploy command:** helm install apisix -n apisix --set apisix.replicaCount=3 --set apisix.resources.requests.cpu=100m --set apisix.resources.requests.memory=1Gi --set apisix.resources.limits.cpu=8 --set apisix.resources.limits.memory=8Gi --set gateway.type=NodePort --set gateway.tls.enabled=true --set gateway.stream.enabled=true --set etcd.replicaCount=3 --set global.storageClass=local-storage --set dashboard.enabled=true --set ingress-controller.enabled=true --set dashboard.config.authentication.users[0].username= --set dashboard.config.authentication.users[0].password=x --set apisix.nodeSelector.node=core --set etcd.nodeSelector.node=core --set dashboard.nodeSelector.node=core --set metrics.enabled=true --set metrics.podMonitor.enabled=true --version=0.7.2 apisix/apisix **then i want to scale it to 5 node:** helm upgrade apisix -n apisix --set apisix.replicaCount=5 --set apisix.resources.requests.cpu=100m --set apisix.resources.requests.memory=1Gi --set apisix.resources.limits.cpu=8 --set apisix.resources.limits.memory=8Gi --set gateway.type=NodePort --set gateway.tls.enabled=true --set gateway.stream.enabled=true --set etcd.replicaCount=5 --set global.storageClass=local-storage --set dashboard.enabled=true --set ingress-controller.enabled=true --set dashboard.config.authentication.users[0].username=--set dashboard.config.authentication.users[0].password= --set apisix.nodeSelector.node=core --set etcd.nodeSelector.node=core --set dashboard.nodeSelector.node=core --set metrics.enabled=true --set metrics.podMonitor.enabled=true --version=0.7.2 apisix/apisix **the pod restart fail ,the log message bellow:** [38;5;6metcd [38;5;5m06:21:39.81 [0m [38;5;6metcd [38;5;5m06:21:39.81 [0m[1mWelcome to the Bitnami etcd container[0m [38;5;6metcd [38;5;5m06:21:39.81 [0mSubscribe to project updates by watching [1mhttps://github.com/bitnami/bitnami-docker-etcd[0m [38;5;6metcd [38;5;5m06:21:39.81 [0mSubmit issues and feature requests at [1mhttps://github.com/bitnami/bitnami-docker-etcd/issues[0m [38;5;6metcd [38;5;5m06:21:39.81 [0m [38;5;6metcd [38;5;5m06:21:39.81 [0m[38;5;2mINFO [0m ==> ** Starting etcd setup ** [38;5;6metcd [38;5;5m06:21:39.82 [0m[38;5;2mINFO [0m ==> Validating settings in ETCD_* env vars.. [38;5;6metcd [38;5;5m06:21:39.83 [0m[38;5;3mWARN [0m ==> You set the environment variable ALLOW_NONE_AUTHENTICATION=yes. For safety reasons, do not use this flag in a production environment. [38;5;6metcd [38;5;5m06:21:39.83 [0m[38;5;2mINFO [0m ==> Initializing etcd [38;5;6metcd [38;5;5m06:21:39.84 [0m[38;5;2mINFO [0m ==> Detected data from previous deployments [38;5;6metcd [38;5;5m06:21:49.95 [0m[38;5;2mINFO [0m ==> Updating member in existing cluster Error: bad member ID arg (strconv.ParseUint: parsing "": invalid syntax), expecting ID in Hex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #815: chore: add bisakhmondal (Bisakh Mondal) with committers in team page
netlify[bot] edited a comment on pull request #815: URL: https://github.com/apache/apisix-website/pull/815#issuecomment-997629225 ✔️ Deploy Preview for *apache-apisix* ready! Explore the source changes: 3d6de97b03bf3099f5174e284f73e09b336c0f76 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61c0219f08ea350007f6da5a](https://app.netlify.com/sites/apache-apisix/deploys/61c0219f08ea350007f6da5a) Browse the preview: [https://deploy-preview-815--apache-apisix.netlify.app](https://deploy-preview-815--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #815: chore: add bisakhmondal (Bisakh Mondal) with committers in team page
netlify[bot] edited a comment on pull request #815: URL: https://github.com/apache/apisix-website/pull/815#issuecomment-997629225 Deploy Preview for *apache-apisix* processing. Explore the source changes: 3d6de97b03bf3099f5174e284f73e09b336c0f76 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61c0219f08ea350007f6da5a](https://app.netlify.com/sites/apache-apisix/deploys/61c0219f08ea350007f6da5a) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #815: chore: add bisakhmondal (Bisakh Mondal) with committers in team page
netlify[bot] edited a comment on pull request #815: URL: https://github.com/apache/apisix-website/pull/815#issuecomment-997629225 ✔️ Deploy Preview for *apache-apisix* ready! Explore the source changes: 5e37f34780bd96bef2c904a7e4a41df6e362ef67 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61c01fead2d473000863626b](https://app.netlify.com/sites/apache-apisix/deploys/61c01fead2d473000863626b) Browse the preview: [https://deploy-preview-815--apache-apisix.netlify.app](https://deploy-preview-815--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #815: chore: add bisakhmondal with committers in team page
netlify[bot] commented on pull request #815: URL: https://github.com/apache/apisix-website/pull/815#issuecomment-997629225 Deploy Preview for *apache-apisix* processing. Explore the source changes: 5e37f34780bd96bef2c904a7e4a41df6e362ef67 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61c01fead2d473000863626b](https://app.netlify.com/sites/apache-apisix/deploys/61c01fead2d473000863626b) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bisakhmondal opened a new pull request #815: chore: add bisakhmondal with committers in team page
bisakhmondal opened a new pull request #815: URL: https://github.com/apache/apisix-website/pull/815 Changes: Add @bisakhmondal in team page : ) Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Horus-K commented on issue #5847: request help: proxy_pass cannot use https
Horus-K commented on issue #5847:
URL: https://github.com/apache/apisix/issues/5847#issuecomment-997625617
location / {
index index.html;
proxy_pass https://xxx.com;
proxy_set_header Host $proxy_host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_ssl_session_reuse off;
proxy_ssl_server_name on;
proxy_ssl_name $proxy_host;
proxy_ssl_protocols TLSv1.2;
} that's it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] lizhouyang commented on issue #5834: request help: how to set redirect_uri, when i use openid-connect
lizhouyang commented on issue #5834:
URL: https://github.com/apache/apisix/issues/5834#issuecomment-997608346
还是不行，贴一下我的思路，您帮我看下：
1. 建一个服务，提供OAuth的访问
```JSON
{
"name": "oauth",
"upstream_id": "386066599586562754",
"plugins": {
"openid-connect": {
"client_id": "login-client",
"client_secret": "{noop}openid-connect",
"disable": false,
"discovery":
"http://auth-server:/.well-known/openid-configuration;,
"redirect_uri": "http://lizhouyang.cn:9080/web1/;
}
}
}
```
2. 新建一个路由，将上面的服务关联到路由上。路由配置如下：
```JSON
{
"uri": "/web1/*",
"name": "web1",
"methods": [
"GET",
"POST",
"PUT",
"DELETE",
"PATCH",
"HEAD",
"OPTIONS",
"CONNECT",
"TRACE"
],
"plugins": {
"proxy-rewrite": {
"regex_uri": [
"^/web1/*",
"/*"
]
}
},
"service_id": "386068954721813186",
"upstream_id": "386066599586562754",
"labels": {
"API_VERSION": "1.0"
},
"status": 1
}
```
3. 浏览器访问`http://lizhouyang.cn:9080/web1/' 出现500错误。不跳转，如下图。域名已经映射到我个人MAC。
https://user-images.githubusercontent.com/6194509/146715410-c59b50c9-526e-40e7-a872-b784d8f2fa2f.png;>
---
PS：补充一些材料
1.
apisix采用docker部署，采用example文件中的docker-compose.yml，只是加了HOSTS域名映射，修改了端口映射，yml如下：
```yml
version: "3"
services:
apisix-dashboard:
image: apache/apisix-dashboard:2.9.0
restart: always
volumes:
- ./dashboard_conf/conf.yaml:/usr/local/apisix-dashboard/conf/conf.yaml
ports:
- "9000:9000"
networks:
apisix:
apisix:
image: apache/apisix:2.10.0-alpine
restart: always
volumes:
- ./apisix_log:/usr/local/apisix/logs
- ./apisix_conf/config.yaml:/usr/local/apisix/conf/config.yaml:ro
depends_on:
- etcd
##network_mode: host
ports:
- "9080:9080/tcp"
- "9081:9091/tcp"
- "9082:9443/tcp"
- "9083:9092/tcp"
extra_hosts:
- "auth-server:192.168.65.2"
networks:
apisix:
etcd:
image: bitnami/etcd:3.4.15
restart: always
volumes:
- etcd_data:/bitnami/etcd
environment:
ETCD_ENABLE_V2: "true"
ALLOW_NONE_AUTHENTICATION: "yes"
ETCD_ADVERTISE_CLIENT_URLS: "http://0.0.0.0:2379;
ETCD_LISTEN_CLIENT_URLS: "http://0.0.0.0:2379;
ports:
- "9084:2379/tcp"
networks:
apisix:
web1:
image: nginx:1.19.0-alpine
restart: always
volumes:
- ./upstream/web1.conf:/etc/nginx/nginx.conf
ports:
- "9085:80/tcp"
environment:
- NGINX_PORT=80
networks:
apisix:
web2:
image: nginx:1.19.0-alpine
restart: always
volumes:
- ./upstream/web2.conf:/etc/nginx/nginx.conf
ports:
- "9086:80/tcp"
environment:
- NGINX_PORT=80
networks:
apisix:
prometheus:
image: prom/prometheus:v2.25.0
restart: always
volumes:
- ./prometheus_conf/prometheus.yml:/etc/prometheus/prometheus.yml
ports:
- "9087:9090"
networks:
apisix:
grafana:
image: grafana/grafana:7.3.7
restart: always
ports:
- "9088:3000"
volumes:
- "./grafana_conf/provisioning:/etc/grafana/provisioning"
- "./grafana_conf/dashboards:/var/lib/grafana/dashboards"
- "./grafana_conf/config/grafana.ini:/etc/grafana/grafana.ini"
networks:
apisix:
networks:
apisix:
driver: bridge
volumes:
etcd_data:
driver: local
```
2. 在容器中可以访问.well-known文件，如下：
https://user-images.githubusercontent.com/6194509/146715780-9dc0d246-bfe4-423c-9dc5-5315b4153676.png;>
2. OpenID服务采用
spring-authorization-server服务，回调地址加了`http://lizhouyang.cn:9080/web1/`。自己写的client端可以正常登录。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] leslie-tsang opened a new pull request #5859: chore: improve insta
leslie-tsang opened a new pull request #5859: URL: https://github.com/apache/apisix/pull/5859 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on pull request #5819: feat(splunk): support splunk hec logging plugin
shuaijinchao commented on pull request #5819: URL: https://github.com/apache/apisix/pull/5819#issuecomment-997579146 > need to update `README.md` done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin
shuaijinchao commented on a change in pull request #5819:
URL: https://github.com/apache/apisix/pull/5819#discussion_r772069719
##
File path: apisix/plugins/splunk-hec-logging.lua
##
@@ -0,0 +1,189 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core= require("apisix.core")
+local ngx = ngx
+local type= type
+local ngx_now = ngx.now
+local ngx_update_time = ngx.update_time
+local http= require("resty.http")
+local log_util= require("apisix.utils.log-util")
+local bp_manager_mod = require("apisix.utils.batch-processor-manager")
+
+
+local DEFAULT_SPLUNK_HEC_ENTRY_SOURCE = "apache-apisix-splunk-hec-logging"
+local DEFAULT_SPLUNK_HEC_ENTRY_TYPE = "_json"
+
+
+local plugin_name = "splunk-hec-logging"
+local batch_processor_manager = bp_manager_mod.new(plugin_name)
+
+
+local schema = {
+type = "object",
+properties = {
+endpoint = {
+type = "object",
+properties = {
+uri = core.schema.uri_def,
+token = {
+type = "string",
+},
+channel = {
+type = "string",
+},
+timeout = {
+type = "integer",
+minimum = 1,
+default = 60
+}
+},
+required = { "uri", "token" }
+},
+ssl_verify = {
+type = "boolean",
+default = true
+},
+max_retry_count = {
+type = "integer",
+minimum = 0,
+default = 0
+},
+retry_delay = {
+type = "integer",
+minimum = 0,
+default = 1
+},
+buffer_duration = {
+type = "integer",
+minimum = 1,
+default = 60
+},
+inactive_timeout = {
+type = "integer",
+minimum = 1,
+default = 10
+},
+batch_max_size = {
+type = "integer",
+minimum = 1,
+default = 100
+},
+},
+required = { "endpoint" },
+}
+
+
+local function get_logger_entry(conf)
+local entry = log_util.get_full_log(ngx, conf)
+ngx_update_time()
+return {
+time = ngx_now(),
+host = entry.server.hostname,
+source = DEFAULT_SPLUNK_HEC_ENTRY_SOURCE,
+sourcetype = DEFAULT_SPLUNK_HEC_ENTRY_TYPE,
+event = {
+request_url = entry.request.url,
+request_method = entry.request.method,
+request_headers = entry.request.headers,
+request_query = entry.request.querystring,
+request_size = entry.request.size,
+response_headers = entry.response.headers,
+response_status = entry.response.status,
+response_size = entry.response.size,
+latency = entry.latency,
+upstream = entry.upstream,
+}
+}
+end
+
+
+local function send_to_splunk(conf, entries)
+if type(conf.endpoint) ~= "table" then
+return nil, "endpoint config invalid"
+end
+
+if not conf.endpoint.uri then
+return nil, "endpoint url undefined"
+end
+
+if not conf.endpoint.token then
+return nil, "endpoint token undefined"
+end
+
+local request_headers = {}
+request_headers["Content-Type"] = "application/json"
+request_headers["Authorization"] = "Splunk " .. conf.endpoint.token
+if conf.endpoint.channel then
+request_headers["X-Splunk-Request-Channel"] = conf.endpoint.channel
+end
+
+local http_new = http.new()
+local res, err = http_new:request_uri(conf.endpoint.uri, {
+ssl_verify = conf.ssl_verify,
+method = "POST",
+body = core.json.encode(entries),
+headers = request_headers,
+})
+
+if err then
+return nil, "failed to write log to splunk, " .. err
+end
+
+local body
+body, err = core.json.decode(res.body)
+if err then
+return nil, "failed to parse splunk response data, " .. err
+end
+
+if res.status ~= 200 then
Review comment:
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin
shuaijinchao commented on a change in pull request #5819: URL: https://github.com/apache/apisix/pull/5819#discussion_r772069626 ## File path: docs/zh/latest/plugins/splunk-hec-logging.md ## @@ -0,0 +1,143 @@ +--- +title: splunk-hec-logging +--- + + + +## 摘要 + +- [**定义**](#定义) +- [**属性列表**](#属性列表) +- [**如何开启**](#如何开启) +- [**测试插件**](#测试插件) +- [**禁用插件**](#禁用插件) + +## 定义 + +`splunk-hec-logging` 插件用于将 `Apache APISIX` 的请求日志转发到 `Splunk HTTP 事件收集器（HEC）` 中进行分析和存储，启用该插件后 `Apache APISIX` 将在 `Log Phase` 获取请求上下文信息并序列化为 [Splunk Event Data 格式](https://docs.splunk.com/Documentation/Splunk/latest/Data/FormateventsforHTTPEventCollector#Event_metadata) 后提交到批处理队列中，当触发批处理队列容量或时间阈值时会将队列中的数据提交到 `Splunk HEC` 中。 Review comment: ok, thx~ updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5840: fix(core.log): log level need to be updated in some scenario
tzssangglass commented on a change in pull request #5840:
URL: https://github.com/apache/apisix/pull/5840#discussion_r772063743
##
File path: apisix/core/log.lua
##
@@ -99,7 +102,10 @@ setmetatable(_M, {__index = function(self, cmd)
-- cache the lazily generated method in our
-- module table
-_M[cmd] = method
+if ngx.get_phase() ~= "init" then
Review comment:
we can add `local get_phase = ngx.get_phase` at header of file, and use
`get_phase()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] gaobo0202 opened a new issue #5858: bug: Using proxy-rewrite to overwrite the request header x-forwarded-proto failed
gaobo0202 opened a new issue #5858: URL: https://github.com/apache/apisix/issues/5858 ### Issue description Our upstream service relies on the parameter of x-forwarded-proto and uses the proxy rewrite plug-in to rewrite the parameter. The upstream service does not get the correct rewritten value 1. When APISIX configures the route, use proxy rewrite to rewrite the x-forwarded-proto parameter to http 2. After calling the domain name, it is found that the x-forwarded-proto obtained upstream is still HTTPS After reading the code and the previous issue about the parameter rewriting, it is found that the proxy rewrite plug-in modification of the parameter will not take effect. I modified the code of APISIX myself to make the proxy rewrite configuration x-forwarded-proto effective. Is this another good repair method?   ### Environment - apisix version (cmd: `apisix version`):2.10.0 - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): ### Steps to reproduce Use proxy-rewrite to overwrite x-forwarded-proto ### Actual result Override does not take effect ### Error log no error log ### Expected result No response -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
shuaijinchao commented on a change in pull request #5839: URL: https://github.com/apache/apisix/pull/5839#discussion_r772058029 ## File path: apisix/plugins/google-cloud-logging.lua ## @@ -136,23 +136,23 @@ local function send_to_google(oauth, entries) end -local function get_auth_config(config) +local function get_auth_config(conf) if auth_config_cache then return auth_config_cache end -if config.auth_config then -auth_config_cache = config.auth_config +if conf.auth_config then +auth_config_cache = conf.auth_config return auth_config_cache end -if not config.auth_file then +if not conf.auth_file then return nil, "configuration is not defined" end Review comment: Using `if ...else`, you also need to judge `conf.auth_file` again in else to determine whether the configuration file is empty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
tzssangglass commented on a change in pull request #5839: URL: https://github.com/apache/apisix/pull/5839#discussion_r772058737 ## File path: apisix/plugins/google-cloud-logging.lua ## @@ -136,23 +136,23 @@ local function send_to_google(oauth, entries) end -local function get_auth_config(config) +local function get_auth_config(conf) if auth_config_cache then return auth_config_cache end -if config.auth_config then -auth_config_cache = config.auth_config +if conf.auth_config then +auth_config_cache = conf.auth_config return auth_config_cache end -if not config.auth_file then +if not conf.auth_file then return nil, "configuration is not defined" end Review comment: sorry…… -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin
tzssangglass commented on a change in pull request #5819: URL: https://github.com/apache/apisix/pull/5819#discussion_r772057171 ## File path: docs/zh/latest/plugins/splunk-hec-logging.md ## @@ -0,0 +1,143 @@ +--- +title: splunk-hec-logging +--- + + + +## 摘要 + +- [**定义**](#定义) +- [**属性列表**](#属性列表) +- [**如何开启**](#如何开启) +- [**测试插件**](#测试插件) +- [**禁用插件**](#禁用插件) + +## 定义 + +`splunk-hec-logging` 插件用于将 `Apache APISIX` 的请求日志转发到 `Splunk HTTP 事件收集器（HEC）` 中进行分析和存储，启用该插件后 `Apache APISIX` 将在 `Log Phase` 获取请求上下文信息并序列化为 [Splunk Event Data 格式](https://docs.splunk.com/Documentation/Splunk/latest/Data/FormateventsforHTTPEventCollector#Event_metadata) 后提交到批处理队列中，当触发批处理队列容量或时间阈值时会将队列中的数据提交到 `Splunk HEC` 中。 Review comment: ```suggestion `splunk-hec-logging` 插件用于将 `Apache APISIX` 的请求日志转发到 `Splunk HTTP 事件收集器（HEC）` 中进行分析和存储，启用该插件后 `Apache APISIX` 将在 `Log Phase` 获取请求上下文信息并序列化为 [Splunk Event Data 格式](https://docs.splunk.com/Documentation/Splunk/latest/Data/FormateventsforHTTPEventCollector#Event_metadata) 后提交到批处理队列中，当触发批处理队列每批次最大处理容量或刷新缓冲区的最大时间时会将队列中的数据提交到 `Splunk HEC` 中。 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
shuaijinchao commented on pull request #5839: URL: https://github.com/apache/apisix/pull/5839#issuecomment-997560020 > We can use `core.lrucache.plugin_ctx` to ensure each rule has its own auth object: > > https://github.com/apache/apisix/blob/4423509680a0c2103ce23b30a0da71735ef73e8f/apisix/plugins/limit-req.lua#L77 > > > Also, it solves the ssl_verify cache problem. good idea, updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
shuaijinchao commented on a change in pull request #5839: URL: https://github.com/apache/apisix/pull/5839#discussion_r772058029 ## File path: apisix/plugins/google-cloud-logging.lua ## @@ -136,23 +136,23 @@ local function send_to_google(oauth, entries) end -local function get_auth_config(config) +local function get_auth_config(conf) if auth_config_cache then return auth_config_cache end -if config.auth_config then -auth_config_cache = config.auth_config +if conf.auth_config then +auth_config_cache = conf.auth_config return auth_config_cache end -if not config.auth_file then +if not conf.auth_file then return nil, "configuration is not defined" end Review comment: `conf.auth_config` and `conf.auth_file` is not the same attribute -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Zhang-Aoqi opened a new issue #5857: request help: Prometheus Apisix
Zhang-Aoqi opened a new issue #5857: URL: https://github.com/apache/apisix/issues/5857 ### Issue description I want to deploy Apisix and Prometheus on K8S through the Helm package, and monitor Apisix using Prometheus to count all requests that go through Apisix. Now how do I deploy integration monitors and how do I configure them?（我想在k8s上通过helm包部署Apisix和Prometheus，同时使用Prometheus监控Apisix，统计所有经过Apisix的请求数量。现在我该怎么部署集成监控他们呢，怎么去配置？） ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #791: feat: add ApisixPluginConfig translator (#638)
codecov-commenter edited a comment on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997183430 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#791](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (26981e4) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/eeb7a49afb7219faaa41e55bef187f3a7ad03f0f?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (eeb7a49) will **increase** coverage by `0.19%`. > The diff coverage is `85.18%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #791 +/- ## == + Coverage 33.14% 33.33% +0.19% == Files 67 68 +1 Lines7142 7157 +15 == + Hits 2367 2386 +19 + Misses 4505 4501 -4 Partials 270 270 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `46.07% <ø> (ø)` | | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `21.74% <66.66%> (+0.71%)` | :arrow_up: | | [pkg/kube/translation/apisix\_pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3BsdWdpbmNvbmZpZy5nbw==) | `100.00% <100.00%> (ø)` | | | [pkg/kube/translation/context.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vY29udGV4dC5nbw==) | `89.47% <100.00%> (+3.75%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [eeb7a49...26981e4](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
tzssangglass commented on a change in pull request #5839: URL: https://github.com/apache/apisix/pull/5839#discussion_r772054988 ## File path: apisix/plugins/google-cloud-logging.lua ## @@ -136,23 +136,23 @@ local function send_to_google(oauth, entries) end -local function get_auth_config(config) +local function get_auth_config(conf) if auth_config_cache then return auth_config_cache end -if config.auth_config then -auth_config_cache = config.auth_config +if conf.auth_config then +auth_config_cache = conf.auth_config return auth_config_cache end -if not config.auth_file then +if not conf.auth_file then return nil, "configuration is not defined" end Review comment: why not use if ... else -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on a change in pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on a change in pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#discussion_r772055047
##
File path: pkg/kube/translation/apisix_pluginconfig_test.go
##
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package translation
+
+import (
+ "testing"
+
+ configv2beta3
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3"
+
+ "github.com/stretchr/testify/assert"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+func TestTranslateApisixPluginConfig(t *testing.T) {
+ apc := {
+ ObjectMeta: metav1.ObjectMeta{
+ Name: "apc",
+ Namespace: "test-ns",
+ },
+ Spec: configv2beta3.ApisixPluginConfigSpec{
+ Plugins: []configv2beta3.ApisixRouteHTTPPluginConfig{
+ {
+ "key-1": 123,
+ "key-2": map[string][]string{
+ "whitelist": {
+ "127.0.0.0/24",
+ "113.74.26.106",
+ },
+ },
+ "key-3": map[string]int{
+ "count": 2,
+ "time_window": 60,
+ "rejected_code": 503,
+ },
+ },
+ {
+ "key-1": 123456,
+ "key-2": map[string][]string{
+ "whitelist": {
+ "1.1.1.1",
+ },
+ },
+ "key-4": map[string]int{
+ "count": 5,
+ "time_window": 60,
+ "rejected_code": 503,
+ },
+ },
+ },
+ },
+ }
+ trans := {}
+ pluginConfig, err := trans.TranslateApisixPluginConfig(apc)
+ assert.NoError(t, err)
+ assert.Len(t, pluginConfig.Plugins, 4)
+ assert.Equal(t, pluginConfig.Plugins["key-1"],
apc.Spec.Plugins[1]["key-1"])
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on a change in pull request #791: feat: add ApisixPluginConfig translator (#638)
neverCase commented on a change in pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#discussion_r772053053 ## File path: pkg/kube/translation/apisix_pluginconfig_test.go ## @@ -0,0 +1,72 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +package translation + +import ( + "testing" + + configv2beta3 "github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3" + + "github.com/stretchr/testify/assert" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" Review comment: ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5850: request help:About use key-auth to control consumer access to different routes
tzssangglass commented on issue #5850: URL: https://github.com/apache/apisix/issues/5850#issuecomment-997549378 > In addition, when you want to give a consumer access to all routes under the service, you need to traverse all routes under the service and then set them one by one through the above method. Is there a better way? you can control the permissions on the service? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5840: fix(core.log): log level need to be updated in some scenario
leslie-tsang commented on a change in pull request #5840:
URL: https://github.com/apache/apisix/pull/5840#discussion_r772047430
##
File path: apisix/core/log.lua
##
@@ -42,17 +43,27 @@ local log_levels = {
}
-local cur_level = ngx.config.subsystem == "http" and
- require "ngx.errlog" .get_sys_filter_level()
+local cur_level
+
local do_nothing = function() end
+local function update_log_level()
+-- Nginx use `notice` level in init phase instead of error_log directive
config
+-- Ref to src/core/ngx_log.c's ngx_log_init
+if ngx.get_phase() ~= "init" then
+cur_level = ngx.config.subsystem == "http" and
ngx_errlog.get_sys_filter_level()
Review comment:
Shall we remove `ngx.config.subsystem == "http"` ? @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5840: fix(core.log): log level need to be updated in some scenario
leslie-tsang commented on a change in pull request #5840:
URL: https://github.com/apache/apisix/pull/5840#discussion_r772047430
##
File path: apisix/core/log.lua
##
@@ -42,17 +43,27 @@ local log_levels = {
}
-local cur_level = ngx.config.subsystem == "http" and
- require "ngx.errlog" .get_sys_filter_level()
+local cur_level
+
local do_nothing = function() end
+local function update_log_level()
+-- Nginx use `notice` level in init phase instead of error_log directive
config
+-- Ref to src/core/ngx_log.c's ngx_log_init
+if ngx.get_phase() ~= "init" then
+cur_level = ngx.config.subsystem == "http" and
ngx_errlog.get_sys_filter_level()
Review comment:
Shall we remove `ngx.config.subsystem == "http"` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5840: fix(core.log): log level need to be updated in some scenario
leslie-tsang commented on a change in pull request #5840:
URL: https://github.com/apache/apisix/pull/5840#discussion_r772046737
##
File path: apisix/core/log.lua
##
@@ -74,8 +85,9 @@ end
setmetatable(_M, {__index = function(self, cmd)
local log_level = log_levels[cmd]
-
local method
+log_level_update()
+
Review comment:
PLTA, now we don't cache the methods generated in the init phase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zjzwjcbj commented on issue #5791: request help: Custom plugin reload but unknown plugin
zjzwjcbj commented on issue #5791: URL: https://github.com/apache/apisix/issues/5791#issuecomment-997539324 > See https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/README.md, and you check focus on the configurations about `apisix.customPlugins`. Can I use like this? Add parameters on helm install. helm install apisix apisix/apisix --set apisix.customPlugins.enabled=true --set apisix.customPlugins.luaPath="/opt/apisix/custom_plugin/?.lua" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Horus-K commented on issue #5847: request help: proxy_pass cannot use https
Horus-K commented on issue #5847: URL: https://github.com/apache/apisix/issues/5847#issuecomment-997537822 > Please describe your architecture elaborately. And I need to know how to use proxy_pass https -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Horus-K commented on issue #5847: request help: proxy_pass cannot use https
Horus-K commented on issue #5847: URL: https://github.com/apache/apisix/issues/5847#issuecomment-997536530 > Please describe your architecture elaborately. We have 5 nginx online servers, we need to use proxy_pass to gray some traffic to apisix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] bzp2010 commented on a change in pull request #254: feat: bump APISIX Dashboard to 2.10
bzp2010 commented on a change in pull request #254: URL: https://github.com/apache/apisix-docker/pull/254#discussion_r772040332 ## File path: .github/workflows/dashboard-docker-test.yaml ## @@ -13,7 +13,7 @@ jobs: name: build dashboard & test runs-on: ubuntu-latest env: - APISIX_DASHBOARD_TAG: 2.9.0 + APISIX_DASHBOARD_TAG: "2.10" Review comment: When PR merges and creates the `apisix-dashboard/2.10` branch, it will push the image. Currently you can find the image currently used for testing on `bzp2010/apisix-dashboard:2.10`, I tested it on a Raspberry Pi 4B ARM64 and found no problems, you can try it again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] zaunist commented on a change in pull request #805: docs(READEME.md): change image size
zaunist commented on a change in pull request #805: URL: https://github.com/apache/apisix-ingress-controller/pull/805#discussion_r772036906 ## File path: README.md ## @@ -55,7 +55,7 @@ This project is currently general availability. ## Internal Architecture - + Review comment: Refered this [file](https://github.com/apache/apisix-ingress-controller/pull/301/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R32), and I think a scaled image is more appropriate than a fixed height and width. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] guoqqqi commented on pull request #5831: feat: add `file-logger` plugin
guoqqqi commented on pull request #5831: URL: https://github.com/apache/apisix/pull/5831#issuecomment-997520694 TODO: - [ ] add control API - [ ] test - [ ] docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5837: request: Expect monitoring metrics to add monitoring of nginx shared memory usage
tzssangglass commented on issue #5837: URL: https://github.com/apache/apisix/issues/5837#issuecomment-997520329 It seems to be quite difficult, and if you use the ngx.shared.DICT API to monitor it, it will lose performance. refer to: https://github.com/openresty/lua-nginx-module#ngxshareddictcapacity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #805: docs(READEME.md): change image size
tokers commented on a change in pull request #805: URL: https://github.com/apache/apisix-ingress-controller/pull/805#discussion_r772035239 ## File path: README.md ## @@ -55,7 +55,7 @@ This project is currently general availability. ## Internal Architecture - + Review comment: May I know why you choose such a ratio? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] zaunist opened a new pull request #805: docs(READEME.md): change image size
zaunist opened a new pull request #805: URL: https://github.com/apache/apisix-ingress-controller/pull/805 ### Type of change: - [ ] Bugfix - [ ] New feature provided - [x] Improve performance - [ ] Backport patches ### What this PR does / why we need it: The [image](https://github.com/apache/apisix-ingress-controller#internal-architecture) is to flat, so I change the changed the ratio of height and width. solved #796 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on a change in pull request #254: feat: bump APISIX Dashboard to 2.10
tokers commented on a change in pull request #254: URL: https://github.com/apache/apisix-docker/pull/254#discussion_r772034352 ## File path: .github/workflows/dashboard-docker-test.yaml ## @@ -13,7 +13,7 @@ jobs: name: build dashboard & test runs-on: ubuntu-latest env: - APISIX_DASHBOARD_TAG: 2.9.0 + APISIX_DASHBOARD_TAG: "2.10" Review comment: Hi, I cannot search the `2.10` tag for this image.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #796: DOC: Adjust the size of the architecture diagram in the README
tokers commented on issue #796: URL: https://github.com/apache/apisix-ingress-controller/issues/796#issuecomment-997516617 > Hi, @gxthrj . I'm pleasure to do this contribution. Thanks! Assigned to you~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5855: bug: unambiguous fully-qualified domain name(FQDN), i.e. ended in a dot.
spacewander commented on issue #5855: URL: https://github.com/apache/apisix/issues/5855#issuecomment-997515503 Thanks for the report. Could you submit a PR for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass closed issue #5851: request help: how to install in ubuntu
tzssangglass closed issue #5851: URL: https://github.com/apache/apisix/issues/5851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5851: request help: how to install in ubuntu
tzssangglass commented on issue #5851: URL: https://github.com/apache/apisix/issues/5851#issuecomment-997510186 consider as solved, feel free to reopen this if you need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
tokers commented on a change in pull request #5839:
URL: https://github.com/apache/apisix/pull/5839#discussion_r772031363
##
File path: apisix/plugins/google-cloud-logging.lua
##
@@ -61,13 +61,13 @@ local schema = {
type = "string",
default = "https://logging.googleapis.com/v2/entries:write;
},
-ssl_verify = {
Review comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #101: chore: upgrade log4j2 version to 2.17.0
tzssangglass commented on pull request #101: URL: https://github.com/apache/apisix-java-plugin-runner/pull/101#issuecomment-997504704 > @tzssangglass please release a new version of this project in mail listing got -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Carson-T commented on issue #2256: docs: invalid URL when clone repo
Carson-T commented on issue #2256: URL: https://github.com/apache/apisix-dashboard/issues/2256#issuecomment-997411161 Thank you!!! @zaunist @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Carson-T removed a comment on issue #5851: request help: how to install in ubuntu
Carson-T removed a comment on issue #5851: URL: https://github.com/apache/apisix/issues/5851#issuecomment-997410144 thank you!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Carson-T commented on issue #5851: request help: how to install in ubuntu
Carson-T commented on issue #5851: URL: https://github.com/apache/apisix/issues/5851#issuecomment-997410198 > Hi, @Carson-T , we have a [repository](https://github.com/api7/apisix-build-tools) to packaging apisix for ubuntu, you can refer to package apisix on your machine. thank you!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Carson-T commented on issue #5851: request help: how to install in ubuntu
Carson-T commented on issue #5851: URL: https://github.com/apache/apisix/issues/5851#issuecomment-997410144 thank you!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2256: docs: invalid URL when clone repo
juzhiyuan commented on issue #2256: URL: https://github.com/apache/apisix-dashboard/issues/2256#issuecomment-997409495 Hi @Carson-T, @zaunist has fixed the issue by https://github.com/apache/apisix-dashboard/pull/2257/files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #2256: docs: invalid URL when clone repo
juzhiyuan closed issue #2256: URL: https://github.com/apache/apisix-dashboard/issues/2256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 edited a comment on issue #5834: request help: how to set redirect_uri, when i use openid-connect
bzp2010 edited a comment on issue #5834: URL: https://github.com/apache/apisix/issues/5834#issuecomment-997328733 Hi, @lizhouyang Enable this plugin on the route, when the user request arrives, APISIX will get the session in the request, if it cannot find it, it will jump to the OIDC authentication address (where the default value of redirect_uri is the path of the current request), when the authentication is completed, it will carry the code and state back to the original request address, then APISIX will send the code and other information to the token endpoint to get the token, after that APISIX will cache the token and expiration time to the memory cache and release the legitimate request. When a user holds a token, but it is not yet cached in APISIX, APISIX will send a request to introspection to get information about the token to confirm its validity. Therefore, you don't need to do anything with the code. After the user returns from the OIDC authentication service, the user will visit such address `xxx.com/xxx?code=xxx=xxx`, and APISIX will automatically handle the subsequent steps, such as exchanging tokens and pass requests, etc. 在路由上开启这个插件后，当用户请求到达时，APISIX会获取请求中的session，如果无法找到，它将会跳转至OIDC认证地址（其中redirect_uri默认值为当前请求的路径），当认证完成后，将会携带code和state回到原有的请求地址，这时APISIX会将code等信息发送至token端点以获取token，之后APISIX会将token和过期时间缓存至内存缓存中，并放行合法请求。 当一个用户持有token，但APISIX中尚未缓存它时，APISIX将会向introspection发送请求以获取token的信息确认其是否有效。 因此，您不需要对code做任何操作，用户从OIDC认证服务返回后，用户将访问这样的地址`xxx.com/xxx?code=xxx=xxx`，而APISIX会自动处理后续步骤，如换取token和放行请求等。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2257: fix(docs): download link of install.md
juzhiyuan merged pull request #2257: URL: https://github.com/apache/apisix-dashboard/pull/2257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch release/2.10 updated: fix(docs): download link of install.md (#2257)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch release/2.10
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/release/2.10 by this push:
new 4a9b101 fix(docs): download link of install.md (#2257)
4a9b101 is described below
commit 4a9b1018c0d188f03057f19f51940ddd60df9afd
Author: Yu.Bozhong
AuthorDate: Sun Dec 19 21:46:25 2021 +0800
fix(docs): download link of install.md (#2257)
---
docs/en/latest/install.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/en/latest/install.md b/docs/en/latest/install.md
index 97ffda9..4bc66e0 100644
--- a/docs/en/latest/install.md
+++ b/docs/en/latest/install.md
@@ -48,7 +48,7 @@ Please replace `` to your configure file path.
```shell
# 1. install RPM package
-sudo yum install -y
https://github.com/apache/apisix-dashboard/releases/download/v2.10.0/apisix-dashboard-2.10.0-0.el7.x86_64.rpm
+sudo yum install -y
https://github.com/apache/apisix-dashboard/releases/download/v2.10/apisix-dashboard-2.10-0.el7.x86_64.rpm
```
### Launch
@@ -91,7 +91,7 @@ For `web`:
### Download {#source-download}
```shell
-git clone -b release/2.10.0 https://github.com/apache/apisix-dashboard.git &&
cd apisix-dashboard
+git clone -b release/2.10 https://github.com/apache/apisix-dashboard.git && cd
apisix-dashboard
```
### Build {#source-build}
[GitHub] [apisix-dashboard] zaunist commented on pull request #2257: fix(docs): download link of install.md
zaunist commented on pull request #2257: URL: https://github.com/apache/apisix-dashboard/pull/2257#issuecomment-997394838 cc @okaybase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 closed issue #2217: request help: Ask how to configure the undefined domain name to point to a service
bzp2010 closed issue #2217: URL: https://github.com/apache/apisix-dashboard/issues/2217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on issue #2217: request help: Ask how to configure the undefined domain name to point to a service
bzp2010 commented on issue #2217: URL: https://github.com/apache/apisix-dashboard/issues/2217#issuecomment-997393560 I will close this issue temporarily, but you can always open it again if you need to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 edited a comment on issue #2217: request help: Ask how to configure the undefined domain name to point to a service
bzp2010 edited a comment on issue #2217: URL: https://github.com/apache/apisix-dashboard/issues/2217#issuecomment-997393459 Hi, @justinmclean. If you want to set up a route for handling unmatched requests, set up a low-priority route that does not contain request information matches, for which you can perform custom actions using the plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on issue #2217: request help: Ask how to configure the undefined domain name to point to a service
bzp2010 commented on issue #2217: URL: https://github.com/apache/apisix-dashboard/issues/2217#issuecomment-997393459 If you want to set up a route for handling unmatched requests, set up a low-priority route that does not contain request information matches, for which you can perform custom actions using the plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #804: fix: some wrong or invalid logs
codecov-commenter edited a comment on pull request #804: URL: https://github.com/apache/apisix-ingress-controller/pull/804#issuecomment-997387269 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#804](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4160007) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/eeb7a49afb7219faaa41e55bef187f3a7ad03f0f?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (eeb7a49) will **not change** coverage. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #804 +/- ## === Coverage 33.14% 33.14% === Files 67 67 Lines7142 7142 === Hits 2367 2367 Misses 4505 4505 Partials 270 270 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `6.89% <0.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [eeb7a49...4160007](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] zaunist commented on issue #796: DOC: Adjust the size of the architecture diagram in the README
zaunist commented on issue #796: URL: https://github.com/apache/apisix-ingress-controller/issues/796#issuecomment-997391428 Hi, @gxthrj . I'm pleasure to do this contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dickens7 commented on issue #5855: bug: unambiguous fully-qualified domain name(FQDN), i.e. ended in a dot.
dickens7 commented on issue #5855: URL: https://github.com/apache/apisix/issues/5855#issuecomment-997390832 Domain names ended in a dot can solve this problem #4874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dickens7 opened a new issue #5855: bug: unambiguous fully-qualified domain name(FQDN), i.e. ended in a dot.
dickens7 opened a new issue #5855: URL: https://github.com/apache/apisix/issues/5855 ### Issue description need to upgrade lua-resty-dns-client >=5.2.2 - https://github.com/Kong/lua-resty-dns-client#522-11-mar-2021 ### Environment - apisix version (cmd: `apisix version`): master ### Steps to reproduce There is no ### Actual result There is no ### Error log There is no ### Expected result _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on issue #2256: wrong command
zaunist commented on issue #2256: URL: https://github.com/apache/apisix-dashboard/issues/2256#issuecomment-997389184 Hi, @Carson-T . I have submitted a PR to fix this issue, please wait for merge to release branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on pull request #2257: fix(docs): download link of install.md
zaunist commented on pull request #2257: URL: https://github.com/apache/apisix-dashboard/pull/2257#issuecomment-997388913 cc @juzhiyuan @bzp2010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist opened a new pull request #2257: fix(docs): download link of install.md
zaunist opened a new pull request #2257: URL: https://github.com/apache/apisix-dashboard/pull/2257 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Fix the download link in install.md. **Related issues** fix/resolve #2256 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [x] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander edited a comment on pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
spacewander edited a comment on pull request #5839: URL: https://github.com/apache/apisix/pull/5839#issuecomment-997388461 Or we can bind the auth_config with the `process` pass to add_entry_to_new_processor, which looks better to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
spacewander commented on pull request #5839: URL: https://github.com/apache/apisix/pull/5839#issuecomment-997388461 Or we can bind the auth_config with the `process` pass to add_entry_to_new_processor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #804: fix: fields in logs do not match variables
codecov-commenter commented on pull request #804: URL: https://github.com/apache/apisix-ingress-controller/pull/804#issuecomment-997387269 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#804](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a24c618) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/eeb7a49afb7219faaa41e55bef187f3a7ad03f0f?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (eeb7a49) will **not change** coverage. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #804 +/- ## === Coverage 33.14% 33.14% === Files 67 67 Lines7142 7142 === Hits 2367 2367 Misses 4505 4505 Partials 270 270 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `6.89% <0.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [eeb7a49...a24c618](https://codecov.io/gh/apache/apisix-ingress-controller/pull/804?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin
spacewander commented on a change in pull request #5819:
URL: https://github.com/apache/apisix/pull/5819#discussion_r771945523
##
File path: apisix/plugins/splunk-hec-logging.lua
##
@@ -0,0 +1,189 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core= require("apisix.core")
+local ngx = ngx
+local type= type
+local ngx_now = ngx.now
+local ngx_update_time = ngx.update_time
+local http= require("resty.http")
+local log_util= require("apisix.utils.log-util")
+local bp_manager_mod = require("apisix.utils.batch-processor-manager")
+
+
+local DEFAULT_SPLUNK_HEC_ENTRY_SOURCE = "apache-apisix-splunk-hec-logging"
+local DEFAULT_SPLUNK_HEC_ENTRY_TYPE = "_json"
+
+
+local plugin_name = "splunk-hec-logging"
+local batch_processor_manager = bp_manager_mod.new(plugin_name)
+
+
+local schema = {
+type = "object",
+properties = {
+endpoint = {
+type = "object",
+properties = {
+uri = core.schema.uri_def,
+token = {
+type = "string",
+},
+channel = {
+type = "string",
+},
+timeout = {
+type = "integer",
+minimum = 1,
+default = 60
+}
+},
+required = { "uri", "token" }
+},
+ssl_verify = {
+type = "boolean",
+default = true
+},
+max_retry_count = {
+type = "integer",
+minimum = 0,
+default = 0
+},
+retry_delay = {
+type = "integer",
+minimum = 0,
+default = 1
+},
+buffer_duration = {
+type = "integer",
+minimum = 1,
+default = 60
+},
+inactive_timeout = {
+type = "integer",
+minimum = 1,
+default = 10
+},
+batch_max_size = {
+type = "integer",
+minimum = 1,
+default = 100
+},
+},
+required = { "endpoint" },
+}
+
+
+local function get_logger_entry(conf)
+local entry = log_util.get_full_log(ngx, conf)
+ngx_update_time()
+return {
+time = ngx_now(),
+host = entry.server.hostname,
+source = DEFAULT_SPLUNK_HEC_ENTRY_SOURCE,
+sourcetype = DEFAULT_SPLUNK_HEC_ENTRY_TYPE,
+event = {
+request_url = entry.request.url,
+request_method = entry.request.method,
+request_headers = entry.request.headers,
+request_query = entry.request.querystring,
+request_size = entry.request.size,
+response_headers = entry.response.headers,
+response_status = entry.response.status,
+response_size = entry.response.size,
+latency = entry.latency,
+upstream = entry.upstream,
+}
+}
+end
+
+
+local function send_to_splunk(conf, entries)
+if type(conf.endpoint) ~= "table" then
+return nil, "endpoint config invalid"
+end
+
+if not conf.endpoint.uri then
+return nil, "endpoint url undefined"
+end
+
+if not conf.endpoint.token then
+return nil, "endpoint token undefined"
+end
+
+local request_headers = {}
+request_headers["Content-Type"] = "application/json"
+request_headers["Authorization"] = "Splunk " .. conf.endpoint.token
+if conf.endpoint.channel then
+request_headers["X-Splunk-Request-Channel"] = conf.endpoint.channel
+end
+
+local http_new = http.new()
+local res, err = http_new:request_uri(conf.endpoint.uri, {
+ssl_verify = conf.ssl_verify,
+method = "POST",
+body = core.json.encode(entries),
+headers = request_headers,
+})
+
+if err then
+return nil, "failed to write log to splunk, " .. err
+end
+
+local body
+body, err = core.json.decode(res.body)
+if err then
+return nil, "failed to parse splunk response data, " .. err
+end
+
+if res.status ~= 200 then
Review comment:
The
[GitHub] [apisix-ingress-controller] nic-6443 opened a new pull request #804: fix: fields in logs do not match variables
nic-6443 opened a new pull request #804: URL: https://github.com/apache/apisix-ingress-controller/pull/804 ### Type of change: - [x] Bugfix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #791: feat: add ApisixPluginConfig translator (#638)
gxthrj commented on a change in pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#discussion_r771944347
##
File path: pkg/kube/translation/apisix_pluginconfig.go
##
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package translation
+
+import (
+ configv2beta3
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3"
+ apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+func (t *translator) TranslateApisixPluginConfig(apc
*configv2beta3.ApisixPluginConfig) (*apisixv1.PluginConfig, error) {
+ pluginMap := make(apisixv1.Plugins)
+ if len(apc.Spec.Plugins) > 0 {
Review comment:
I think `apc.Spec` will not be nil as it is not a point :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #791: feat: add ApisixPluginConfig translator (#638)
gxthrj commented on a change in pull request #791:
URL:
https://github.com/apache/apisix-ingress-controller/pull/791#discussion_r771944230
##
File path: pkg/kube/translation/apisix_pluginconfig.go
##
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package translation
+
+import (
+ configv2beta3
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3"
+ apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+func (t *translator) TranslateApisixPluginConfig(apc
*configv2beta3.ApisixPluginConfig) (*apisixv1.PluginConfig, error) {
+ pluginMap := make(apisixv1.Plugins)
+ if len(apc.Spec.Plugins) > 0 {
Review comment:
I think `apc.Spec` will not be nil, as it is not a point :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
spacewander commented on pull request #5839: URL: https://github.com/apache/apisix/pull/5839#issuecomment-997385527 We can use `core.lrucache.plugin_ctx` to ensure each rule has its own auth object: https://github.com/apache/apisix/blob/4423509680a0c2103ce23b30a0da71735ef73e8f/apisix/plugins/limit-req.lua#L77 Also, it solves the ssl_verify cache problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
spacewander commented on pull request #5839: URL: https://github.com/apache/apisix/pull/5839#issuecomment-997384916 Look like there is another issue: `auth_config_cache` is not updated even the auth_config has changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
spacewander commented on a change in pull request #5839: URL: https://github.com/apache/apisix/pull/5839#discussion_r771942631 ## File path: apisix/plugins/google-cloud-logging/oauth.lua ## @@ -111,10 +111,10 @@ function _M:new(config) access_token_expire_time = 0, } -if config.ssl_verify == false then -oauth.ssl_verify = config.ssl_verify -else +if ssl_verify == true then oauth.ssl_verify = true Review comment: Why not `oauth.ssl_verify = ssl_verify` directly? The ssl_verify can't be nil. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #254: feat: bump APISIX Dashboard to 2.10
gxthrj commented on a change in pull request #254: URL: https://github.com/apache/apisix-docker/pull/254#discussion_r771943158 ## File path: Makefile ## @@ -160,6 +160,21 @@ push-dashboard: @$(call func_echo_success_status, "$@ -> [ Done ]") +### push-multiarch-dashbaord : Build and push multiarch apache/dashboard:tag image +.PHONY: push-multiarch-dashbaord +push-multiarch-dashbaord: + @$(call func_echo_status, "$@ -> [ Start ]") + $(ENV_DOCKER) buildx build --push \ + -t $(APISIX_DASHBOARD_IMAGE_NAME):$(APISIX_DASHBOARD_VERSION) \ Review comment: I suggest to add `multiarch` to `image name`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] spacewander commented on issue #255: bug: wrong APISIX ARM64 image
spacewander commented on issue #255: URL: https://github.com/apache/apisix-docker/issues/255#issuecomment-997380667 Good catch! Is it urgent to fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: fix(ua-restriction): refine plugin configuration check logic (#5728)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 4423509 fix(ua-restriction): refine plugin configuration check logic
(#5728)
4423509 is described below
commit 4423509680a0c2103ce23b30a0da71735ef73e8f
Author: jackfu
AuthorDate: Sun Dec 19 19:51:32 2021 +0800
fix(ua-restriction): refine plugin configuration check logic (#5728)
Co-authored-by: jack.fu
---
apisix/plugins/ua-restriction.lua | 31 --
t/plugin/ua-restriction.t | 54 +++
2 files changed, 83 insertions(+), 2 deletions(-)
diff --git a/apisix/plugins/ua-restriction.lua
b/apisix/plugins/ua-restriction.lua
index 3683a15..ec74e75 100644
--- a/apisix/plugins/ua-restriction.lua
+++ b/apisix/plugins/ua-restriction.lua
@@ -16,6 +16,7 @@
--
local ipairs = ipairs
local core = require("apisix.core")
+local re_compile = require("resty.core.regex").re_match_compile
local stringx = require('pl.stringx')
local type = type
local str_strip = stringx.strip
@@ -36,11 +37,19 @@ local schema = {
},
allowlist = {
type = "array",
-minItems = 1
+minItems = 1,
+items = {
+type = "string",
+minLength = 1,
+}
},
denylist = {
type = "array",
-minItems = 1
+minItems = 1,
+items = {
+type = "string",
+minLength = 1,
+}
},
message = {
type = "string",
@@ -88,6 +97,24 @@ function _M.check_schema(conf)
return false, err
end
+if conf.allowlist then
+for _, re_rule in ipairs(conf.allowlist) do
+ok, err = re_compile(re_rule, "j")
+if not ok then
+return false, err
+end
+end
+end
+
+if conf.denylist then
+for _, re_rule in ipairs(conf.denylist) do
+ok, err = re_compile(re_rule, "j")
+if not ok then
+return false, err
+end
+end
+end
+
return true
end
diff --git a/t/plugin/ua-restriction.t b/t/plugin/ua-restriction.t
index 77c6874..82e6658 100644
--- a/t/plugin/ua-restriction.t
+++ b/t/plugin/ua-restriction.t
@@ -739,3 +739,57 @@ hello world
}
--- response_body
passed
+
+
+
+=== TEST 33: the element in allowlist is null
+--- config
+location /t {
+content_by_lua_block {
+local plugin = require("apisix.plugins.ua-restriction")
+local conf = {
+allowlist = {
+"userdata: NULL",
+null,
+nil,
+""
+},
+}
+local ok, err = plugin.check_schema(conf)
+if not ok then
+ngx.say(err)
+end
+
+ngx.say("done")
+}
+}
+--- response_body
+property "allowlist" validation failed: wrong type: expected array, got table
+done
+
+
+
+=== TEST 34: the element in denylist is null
+--- config
+location /t {
+content_by_lua_block {
+local plugin = require("apisix.plugins.ua-restriction")
+local conf = {
+denylist = {
+"userdata: NULL",
+null,
+nil,
+""
+},
+}
+local ok, err = plugin.check_schema(conf)
+if not ok then
+ngx.say(err)
+end
+
+ngx.say("done")
+}
+}
+--- response_body
+property "denylist" validation failed: wrong type: expected array, got table
+done
[GitHub] [apisix] spacewander merged pull request #5728: fix(ua-restriction): refine plugin configuration check logic
spacewander merged pull request #5728: URL: https://github.com/apache/apisix/pull/5728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #5724: bug: regular matches have bugs in specific scenarios
spacewander closed issue #5724: URL: https://github.com/apache/apisix/issues/5724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Carson-T opened a new issue #2256: wrong command
Carson-T opened a new issue #2256: URL: https://github.com/apache/apisix-dashboard/issues/2256 ### Issue description wrong command ### Expected behavior The install.md file has a wrong command git clone -b release/2.10.0 https://github.com/apache/apisix-dashboard.git && cd apisix-dashboard there is no branch release/2.10.0 ### How to Reproduce What I found in this repository is release/2.10 ### Screenshots _No response_ ### Environment _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] chanjet1213 opened a new issue #2255: request help: dashboard认证登录
chanjet1213 opened a new issue #2255: URL: https://github.com/apache/apisix-dashboard/issues/2255 ### Issue description dashboard何时支持认证登录？比如支持openLDAP。 ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (5cde5ae -> a11c2d1)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 5cde5ae feat: upgrade luarocks to 3.8.0 which converts git:// to https:// (#5825) add a11c2d1 docs: sync stream proxy Chinese version (#5793) No new revisions were added by this update. Summary of changes: docs/zh/latest/admin-api.md| 10 --- docs/zh/latest/stream-proxy.md | 68 +- 2 files changed, 73 insertions(+), 5 deletions(-)
[GitHub] [apisix] spacewander merged pull request #5793: docs: sync stream proxy Chinese version
spacewander merged pull request #5793: URL: https://github.com/apache/apisix/pull/5793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] moonming commented on pull request #101: chore: upgrade log4j2 version to 2.17.0
moonming commented on pull request #101: URL: https://github.com/apache/apisix-java-plugin-runner/pull/101#issuecomment-997373026 @tzssangglass please release a new version of this project in mail listing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] membphis merged pull request #101: chore: upgrade log4j2 version to 2.17.0
membphis merged pull request #101: URL: https://github.com/apache/apisix-java-plugin-runner/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-java-plugin-runner] branch main updated (d5adbe0 -> 4e3279f)
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git. from d5adbe0 docs: add zh Quick Start (#95) add 4e3279f chore: upgrade log4j2 to 2.17.0 (#101) No new revisions were added by this update. Summary of changes: pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [apisix] membphis commented on pull request #5728: fix(ua-restriction): refine the ua-restriction plugin configuration checksum logic
membphis commented on pull request #5728: URL: https://github.com/apache/apisix/pull/5728#issuecomment-997370246 I rerun the CI right now. one of the ci failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on issue #2217: request help: Ask how to configure the undefined domain name to point to a service
github-actions[bot] commented on issue #2217: URL: https://github.com/apache/apisix-dashboard/issues/2217#issuecomment-997362732 This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] bzp2010 commented on pull request #254: feat: bump APISIX Dashboard to 2.10
bzp2010 commented on pull request #254: URL: https://github.com/apache/apisix-docker/pull/254#issuecomment-997357433 ## Update I've done a local test of multi-architecture packaging and it completes in about 10 minutes or so [[demo]](https://github.com/bzp2010/apisix-docker/runs/4573474776?check_suite_focus=true), outputting `linux/amd64` and `linux/arm64` images. ## Other cc @gxthrj @nic-chen @starsz I'm sorry for making some more changes after the review, I fixed the build taking too long, please take a look again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zuiyangqingzhou commented on a change in pull request #5728: fix(ua-restriction): refine the ua-restriction plugin configuration checksum logic
zuiyangqingzhou commented on a change in pull request #5728:
URL: https://github.com/apache/apisix/pull/5728#discussion_r771922260
##
File path: t/plugin/ua-restriction.t
##
@@ -783,5 +790,7 @@ load_full_data(): failed to check item data of
[/apisix/routes] err:failed to ch
ngx.say("done")
}
}
error_log
-load_full_data(): failed to check item data of [/apisix/routes] err:failed to
check the configuration of plugin ua-restriction
+--- response_body
+property "denylist" validation failed: wrong type: expected array, got table
+done
+--- ONLY
Review comment:
yes, it has been deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
