[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout
spacewander commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-988544339 @dmsolr Maybe we can create a new release of skywalking-nginx-lua now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout
spacewander commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-847909777 > In addition, sw_tracer:finish should be called in header_filter_by_lua phase logically, because header_filter_by_lua phase is before body_filter_by_lua phase. Calling the `finish` in header_filter_by_lua in a non-head-only response will result in a too-short trace span. Consider the server is serving a 1 GB file, the time when the response finish generating header is quite earlier than generating all the body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout
spacewander commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-847574701 My opinion: 1. normal response: keep the current behavior 2. without response (the timed out case pointed by @yxudong): add `finish` call if we haven't called it yet 3. header only response (`HEAD` request, 204 or 304 response): add `finish` call in the header filter phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4301: bug: skywalking not work when upsteam timeout
spacewander commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-847493355 Response without body also causes this problem, like HEAD request's response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
