[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-1002896435 Should APISIX upgrade the dependency for the next release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996378124 @dmsolr Any update about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-988548156  2 fixes are code related. It is 7 months since last release, if you feel you should, please run for it. If you do that, skywalking-kong 0.1.2 should be released with dependency upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-853027025 https://github.com/apache/skywalking-nginx-lua/pull/85 merged. We will need skywalking's next release for APISIX fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-847842853 You should know, in other SkyWalking agents, there is a config to control collecting HTTP request and response bodies when necessary. It is better to keep `body_filter_by_lua` works in normal cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-847842189 Does `header_filter_by_lua` work for timeout? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-847576227 > My opinion: > > 1. normal response: keep the current behavior > 2. without response (the timed out case pointed by @yxudong): add `finish` call if we haven't called it yet > 3. header only response (`HEAD` request, 204 or 304 response): add `finish` call in the header filter phase. @yxudong Would you work on a patch to SkyWalking nginx agent to do that? We need some code changes rather than only doc change. cc @dmsolr I think after this, we need to adjust Kong plugin. @spacewander we need to adopt this fix in APISIX too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-847536953 > Response without body also causes this problem, like HEAD request's response. Thanks for sharing more cases. What is the recommended fix? Do we have to move this into the `log_by` with a recheck? We have to face an inaccurate end time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-847469523 > We may add a flag to check whether the `sw_tracer:finish` was called in the `body_by_lua_filter*` phase, if not, just calling it in `log_by_lua*` phase. `log` method should not provide accurate endtime, as far as I know. If the timeout really could cause the issue, then I think we have to make a flag for the status. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-847112213 Hi @apache/apisix-committers SkyWalking community needs verification of whether this is the right description, and a correct way to fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
