Change in asterixdb[master]: RangeGenerator aggfunc for the numeric/asciiString datatype ...

2016-06-16 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: RangeGenerator aggfunc for the numeric/asciiString datatype 
based on parallel streaming histogram.
..


Patch Set 27:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/806
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I450d0962fbeacfb2b6ab9fae0750f025ef17ba01
Gerrit-PatchSet: 27
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: RangeGenerator aggfunc for the numeric/asciiString datatype ...

2016-06-16 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: RangeGenerator aggfunc for the numeric/asciiString datatype 
based on parallel streaming histogram.
..


Patch Set 27:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1667/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/806
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I450d0962fbeacfb2b6ab9fae0750f025ef17ba01
Gerrit-PatchSet: 27
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: RangeGenerator aggfunc for the numeric/asciiString datatype ...

2016-06-16 Thread Wenhai Li (Code Review) 
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/806

to look at the new patch set (#27).

Change subject: RangeGenerator aggfunc for the numeric/asciiString datatype 
based on parallel streaming histogram.
..

RangeGenerator aggfunc for the numeric/asciiString datatype based on parallel 
streaming histogram.

The following commits from your working branch will be included:

Extract and review for the streaming histogram based parallel sort.
1. Add the streaming histogram for hyracks datatype.
2. Include the ASCII histogram.
3. Inline the rangegenerator inside the AggFuncs.
4. Add the testcases including the random, zipfan, gaussian 
int/short/long/double/string.
5. Support the null omittion.
Change-Id: I450d0962fbeacfb2b6ab9fae0750f025ef17ba01
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java
A asterixdb/asterix-app/data/skew/zipfan1.tbl
A asterixdb/asterix-app/data/skew/zipfan2.tbl
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/avg_float/avg_float.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/avg_int16/avg_int16.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/avg_int32/avg_int32.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/avg_int64/avg_int64.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/avg_int8/avg_int8.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/count_01/count_01.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/global-avg_01/global-avg_01.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/global-rg/global-rg.1.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_double/local-avg_double.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_float/local-avg_float.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_int16/local-avg_int16.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_int16/local-avg_int16.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_int32/local-avg_int32.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_int64/local-avg_int64.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_int8/local-avg_int8.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-rg/local-rg.1.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double-null/rg-double-null.1.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double/rg-double.1.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_double/rg_double.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_double/rg_double.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_double/rg_double.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int16/rg_int16.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int16/rg_int16.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int16/rg_int16.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int32/rg_int32.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int32/rg_int32.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int32/rg_int32.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int64/rg_int64.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int64/rg_int64.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int64/rg_int64.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_string/rg_string.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_string/rg_string.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_string/rg_string.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/sum_double/sum_double.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/sum_float/sum_float.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/sum_int16/sum_int16.3.query.aql
M

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

2016-06-16 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix Indexing on Open fields and Meta fields
..


Patch Set 3:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/930
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6195149940f150250a65f2515e9ac9d6de2a33f9
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

2016-06-16 Thread abdullah alamoudi (Code Review) 
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/930

to look at the new patch set (#3).

Change subject: Fix Indexing on Open fields and Meta fields
..

Fix Indexing on Open fields and Meta fields

This change fix the following cases:
1. Build a secondary index on a meta field: success
2. Build an open index on a meta field: failure
3. Build a secondary index on an open field in record part: success

Testing ingestion and querying are working correctly for these cases.

Change-Id: I6195149940f150250a65f2515e9ac9d6de2a33f9
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/IndexOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryInvertedIndexOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-open-index-in-meta/change-feed-with-meta-open-index-in-meta.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-open-index-in-meta/change-feed-with-meta-open-index-in-meta.2.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.3.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.4.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.5.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-in-meta/change-feed-with-meta-pk-in-meta-index-in-meta.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-in-meta/change-feed-with-meta-pk-in-meta-index-in-meta.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-in-meta/change-feed-with-meta-pk-in-meta-index-in-meta.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-in-meta/change-feed-with-meta-pk-in-meta-index-in-meta.4.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-open-index-in-value/change-feed-with-meta-pk-in-meta-open-index-in-value.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-open-index-in-value/change-feed-with-meta-pk-in-meta-open-index-in-value.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-open-index-in-value/change-feed-with-meta-pk-in-meta-open-index-in-value.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-open-index-in-value/change-feed-with-meta-pk-in-meta-open-index-in-value.4.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-meta-pk-in-meta-index-in-meta/change-feed-with-meta-pk-in-meta-index-in-meta.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-meta-pk-in-meta-open-index-in-value/change-feed-with-meta-pk-in-meta-open-index-in-value.4.adm
M

Change in asterixdb[master]: More ASTERIXDB-1475

2016-06-16 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: More ASTERIXDB-1475
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1665/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/933
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87f8ac08d1c78d0539607efa43f82ec2aba16b1b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: More ASTERIXDB-1475

2016-06-16 Thread Michael Blow (Code Review) 
Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/933

Change subject: More ASTERIXDB-1475
..

More ASTERIXDB-1475

Ensure external-data test jar is on classpath for integration runtime
tests.  Also, isolate downstream tests from upstream failures by manually
forcing existing instance to shutdown / delete prior to creating the
server for recovery tests.

Change-Id: I87f8ac08d1c78d0539607efa43f82ec2aba16b1b
---
M 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AbstractExecutionIT.java
M 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixLifecycleIT.java
M 
asterixdb/asterix-installer/src/test/resources/transactionts/scripts/dml_recovery/create_and_start.sh
M 
asterixdb/asterix-installer/src/test/resources/transactionts/scripts/query_after_restart/big_object_20M/create_and_start.sh
M 
asterixdb/asterix-installer/src/test/resources/transactionts/scripts/query_after_restart/dataset-with-meta-record/create_and_start.sh
M 
asterixdb/asterix-installer/src/test/resources/transactionts/scripts/query_after_restart/external_index/create_and_start.sh
6 files changed, 24 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/33/933/1

diff --git 
a/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AbstractExecutionIT.java
 
b/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AbstractExecutionIT.java
index f24be40..1c3c3da 100644
--- 
a/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AbstractExecutionIT.java
+++ 
b/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AbstractExecutionIT.java
@@ -76,6 +76,17 @@
 
 AsterixLifecycleIT.setUp();
 
+File externalTestsJar = new File(StringUtils.join(
+new String[] { "..", "asterix-external-data", "target" } , 
File.separator)).listFiles(
+(dir, name) -> 
name.matches("asterix-external-data-.*-tests.jar"))[0];
+
+FileUtils.copyFile(externalTestsJar, new File(
+AsterixInstallerIntegrationUtil.getManagixHome() + 
"/clusters/local/working_dir/asterix/repo/",
+externalTestsJar.getName()));
+
+AsterixLifecycleIT.restartInstance();
+
+
 FileUtils.copyDirectoryStructure(
 new File(StringUtils.join(new String[] { "..", "asterix-app", 
"data" }, File.separator)),
 new File(AsterixInstallerIntegrationUtil.getManagixHome() + 
"/clusters/local/working_dir/data"));
diff --git 
a/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixLifecycleIT.java
 
b/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixLifecycleIT.java
index 302275d..117751f 100644
--- 
a/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixLifecycleIT.java
+++ 
b/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixLifecycleIT.java
@@ -76,6 +76,11 @@
 return testArgs;
 }
 
+public static void restartInstance() throws Exception {
+
AsterixInstallerIntegrationUtil.transformIntoRequiredState(State.INACTIVE);
+
AsterixInstallerIntegrationUtil.transformIntoRequiredState(State.ACTIVE);
+}
+
 @Test
 public void test_1_StopActiveInstance() throws Exception {
 try {
diff --git 
a/asterixdb/asterix-installer/src/test/resources/transactionts/scripts/dml_recovery/create_and_start.sh
 
b/asterixdb/asterix-installer/src/test/resources/transactionts/scripts/dml_recovery/create_and_start.sh
index 789914b..3af1095 100755
--- 
a/asterixdb/asterix-installer/src/test/resources/transactionts/scripts/dml_recovery/create_and_start.sh
+++ 
b/asterixdb/asterix-installer/src/test/resources/transactionts/scripts/dml_recovery/create_and_start.sh
@@ -15,4 +15,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+$MANAGIX_HOME/bin/managix stop -n asterix 1>/dev/null 2>&1;
+$MANAGIX_HOME/bin/managix delete -n asterix 1>/dev/null 2>&1;
 $MANAGIX_HOME/bin/managix create -n asterix -c 
$MANAGIX_HOME/clusters/local/local.xml;
diff --git 
a/asterixdb/asterix-installer/src/test/resources/transactionts/scripts/query_after_restart/big_object_20M/create_and_start.sh
 
b/asterixdb/asterix-installer/src/test/resources/transactionts/scripts/query_after_restart/big_object_20M/create_and_start.sh
index 37bc7b0..d3c75b2 100755
--- 
a/asterixdb/asterix-installer/src/test/resources/transactionts/scripts/query_after_restart/big_object_20M/create_and_start.sh
+++ 
b/asterixdb/asterix-installer/src/test/resources/transactionts/scripts/query_after_restart/big_object_20M/create_and_start.sh
@@ -1,2 +1,4 @@
 jps | awk '{if ($2 == "NCDriver" || $2 == "CCDriver")

Change in asterixdb[master]: Don't Start Stop Hyracks Cluster When -DskipTests

2016-06-16 Thread abdullah alamoudi (Code Review) 
abdullah alamoudi has posted comments on this change.

Change subject: Don't Start Stop Hyracks Cluster When -DskipTests
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/931
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdde6b78fe1b0e9ac76b91a32bff279a1814db51
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

2016-06-16 Thread abdullah alamoudi (Code Review) 
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/930

to look at the new patch set (#2).

Change subject: Fix Indexing on Open fields and Meta fields
..

Fix Indexing on Open fields and Meta fields

This change fix the following cases:
1. Build a secondary index on a meta field: success
2. Build an open index on a meta field: failure
3. Build a secondary index on an open field in record part: success

Testing ingestion and querying are working correctly for these cases.

Change-Id: I6195149940f150250a65f2515e9ac9d6de2a33f9
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/IndexOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryInvertedIndexOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-open-index-in-meta/change-feed-with-meta-open-index-in-meta.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-open-index-in-meta/change-feed-with-meta-open-index-in-meta.2.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.3.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.4.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.5.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-in-meta/change-feed-with-meta-pk-in-meta-index-in-meta.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-in-meta/change-feed-with-meta-pk-in-meta-index-in-meta.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-in-meta/change-feed-with-meta-pk-in-meta-index-in-meta.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-in-meta/change-feed-with-meta-pk-in-meta-index-in-meta.4.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-open-index-in-value/change-feed-with-meta-pk-in-meta-open-index-in-value.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-open-index-in-value/change-feed-with-meta-pk-in-meta-open-index-in-value.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-open-index-in-value/change-feed-with-meta-pk-in-meta-open-index-in-value.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-open-index-in-value/change-feed-with-meta-pk-in-meta-open-index-in-value.4.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-meta-pk-in-meta-index-in-meta/change-feed-with-meta-pk-in-meta-index-in-meta.4.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/change-feed-with-meta-pk-in-meta-open-index-in-value/change-feed-with-meta-pk-in-meta-open-index-in-value.4.adm
M

Change in asterixdb[master]: Update adm.grammar and printers for double/float

2016-06-16 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Update adm.grammar and printers for double/float
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1663/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/932
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6164d74f6c286fa160a30cff9ad47e97a30e0770
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Update adm.grammar and printers for double/float

2016-06-16 Thread Ian Maxon (Code Review) 
Ian Maxon has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/932

Change subject: Update adm.grammar and printers for double/float
..

Update adm.grammar and printers for double/float

adm.grammar was not accepting suffixed doubles. This was breaking
a lot of round-trip ADM cases. I also changed the default print for
float and double to not have a suffix, because this makes the output
very odd (NaNd, NaNf, -Infinityf).

Change-Id: I6164d74f6c286fa160a30cff9ad47e97a30e0770
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/float_01/float_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/caret0/caret0.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling2/ceiling2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling3/ceiling3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor2/floor2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor3/floor3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even2/round-half-to-even2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even22/round-half-to-even22.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even23/round-half-to-even23.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even3/round-half-to-even3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_double_02/unary-minus_double_02.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_float_02/unary-minus_float_02.1.adm
M asterixdb/asterix-external-data/src/main/resources/adm.grammar
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinterFactory.java
18 files changed, 26 insertions(+), 17 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/932/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
index 30da9ee..0e90fe0 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
@@ -1 +1 @@
-{ "double1": NaNd, "double2": Infinityd, "double3": -Infinityd, "double4": 
-80.2d, "double5": -2.056E-29d, "double6": -2.056E-299d }
+{ "double1": NaN, "double2": Infinity, "double3": -Infinity, "double4": -80.2, 
"double5": -2.056E-29, "double6": -2.056E-299 }
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/float_01/float_01.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/float_01/float_01.1.adm
index 16ba1f3..9dfb94a 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/float_01/float_01.1.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/float_01/float_01.1.adm
@@ -1 +1 @@
-{ "float1": NaNf, "float2": Infinityf, "float3": -Infinityf, "float4": -80.2f, 
"float5": -2.056E-29f }
+{ "float1": NaN, "float2": Infinity, "float3": -Infinity, "float4": -80.2, 
"float5": -2.056E-29 }
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
index a4bcbe8..22e50da 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
@@ -1 +1 @@
-{ "f0": 20.1f, "f1": 2.056E-29f, "f2": NaNf, "f3": Infinityf, "f4": Infinityf, 
"f5": 0.0f, "f6": 0.0f }
+{ "f0": 20.1, "f1": 2.056E-29, "f2": NaN, "f3": Infinity, "f4": Infinity, 
"f5": 0.0, "f6": 0.0 }
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
index 4da3272..f938327 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
@@ -1 +1 @@
-{ "d0": 20.1d, "d1": 2.056E-29d, "d2":

Change in asterixdb[master]: Don't Start Stop Hyracks Cluster When -DskipTests

2016-06-16 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Don't Start Stop Hyracks Cluster When -DskipTests
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1662/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/931
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdde6b78fe1b0e9ac76b91a32bff279a1814db51
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Don't Start Stop Hyracks Cluster When -DskipTests

2016-06-16 Thread Michael Blow (Code Review) 
Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/931

Change subject: Don't Start Stop Hyracks Cluster When -DskipTests
..

Don't Start Stop Hyracks Cluster When -DskipTests

Wrap starting / stopping Hyracks cluster in profile which is disabled
when 'skipTests' is set.

Change-Id: Ifdde6b78fe1b0e9ac76b91a32bff279a1814db51
---
M hyracks-fullstack/hyracks/hyracks-examples/hyracks-shutdown-test/pom.xml
M hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/pom.xml
2 files changed, 161 insertions(+), 133 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/31/931/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-examples/hyracks-shutdown-test/pom.xml 
b/hyracks-fullstack/hyracks/hyracks-examples/hyracks-shutdown-test/pom.xml
index b69b280..63d01ad 100644
--- a/hyracks-fullstack/hyracks/hyracks-examples/hyracks-shutdown-test/pom.xml
+++ b/hyracks-fullstack/hyracks/hyracks-examples/hyracks-shutdown-test/pom.xml
@@ -81,69 +81,6 @@
   
 
   
-org.apache.hyracks
-hyracks-virtualcluster-maven-plugin
-0.2.18-SNAPSHOT
-
-  
${basedir}/target/hyracks-shutdown-test-${project.version}-binary-assembly
-  ${jvm.extraargs}
-
-
-  
-hyracks-cc-start
-pre-integration-test
-
-  start-cc
-
-  
-  
-hyracks-nc1-start
-pre-integration-test
-
-  start-nc
-
-
-  NC1
-  127.0.0.1
-  localhost
-
-  
-  
-hyracks-nc2-start
-pre-integration-test
-
-  start-nc
-
-
-  NC2
-  127.0.0.1
-  localhost
-
-  
-  
-stop-services
-post-integration-test
-
-  stop-services
-
-  
-
-  
-  
-org.apache.maven.plugins
-maven-failsafe-plugin
-2.8.1
-
-  
-it
-integration-test
-
-  integration-test
-
-  
-
-  
-  
 org.apache.maven.plugins
 maven-deploy-plugin
 
@@ -152,6 +89,83 @@
   
 
   
+  
+
+  run-tests
+  
+
+  !skipTests
+
+  
+  
+
+  
+org.apache.hyracks
+hyracks-virtualcluster-maven-plugin
+0.2.18-SNAPSHOT
+
+  
${basedir}/target/hyracks-shutdown-test-${project.version}-binary-assembly
+  ${jvm.extraargs}
+
+
+  
+hyracks-cc-start
+pre-integration-test
+
+  start-cc
+
+  
+  
+hyracks-nc1-start
+pre-integration-test
+
+  start-nc
+
+
+  NC1
+  127.0.0.1
+  localhost
+
+  
+  
+hyracks-nc2-start
+pre-integration-test
+
+  start-nc
+
+
+  NC2
+  127.0.0.1
+  localhost
+
+  
+  
+stop-services
+post-integration-test
+
+  stop-services
+
+  
+
+  
+  
+org.apache.maven.plugins
+maven-failsafe-plugin
+2.8.1
+
+  
+it
+integration-test
+
+  integration-test
+
+  
+
+  
+
+  
+
+  
   
 
   junit
diff --git 
a/hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/pom.xml 
b/hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/pom.xml
index f9dc917..babc01e 100644
--- a/hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/pom.xml
+++ b/hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/pom.xml
@@ -79,78 +79,92 @@
   
 
   
-  
-org.apache.hyracks
-hyracks-virtualcluster-maven-plugin
-0.2.18-SNAPSHOT
-
-  
${basedir}/target/textserver-${project.version}-binary-assembly
-  ${jvm.extraargs}
-
-
-  
-hyracks-cc-start
-pre-integration-test
-
-  start-cc
-
-  
-  
-

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

2016-06-16 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix Indexing on Open fields and Meta fields
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/930
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6195149940f150250a65f2515e9ac9d6de2a33f9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

2016-06-16 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix Indexing on Open fields and Meta fields
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1661/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/930
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6195149940f150250a65f2515e9ac9d6de2a33f9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1486) NCService installation: Some asterix properties are not read

2016-06-16 Thread Chris Hillery (JIRA) 

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335085#comment-15335085
 ] 

Chris Hillery commented on ASTERIXDB-1486:
--

Yingyi - when I added the following to my cc.conf:

[asterix]
storage.metadata.memorycomponent.numpages=167

and set a breakpoint in my debugger at DatasetLifecycleManager.java line 734, I 
confirmed that numPages was set to 167. So I think this is working correctly, 
at least as far as getting values from the configuration to the code.

Can you confirm, or else provide some more info about what should work but 
seems not to be?

> NCService installation: Some asterix properties are not read
> 
>
> Key: ASTERIXDB-1486
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1486
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Chris Hillery
>Assignee: Yingyi Bu
>
> e.g., storage.metadata.memorycomponent.numpages



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1486) NCService installation: Some asterix properties are not read

2016-06-16 Thread Chris Hillery (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Hillery updated ASTERIXDB-1486:
-
Assignee: Yingyi Bu  (was: Chris Hillery)

> NCService installation: Some asterix properties are not read
> 
>
> Key: ASTERIXDB-1486
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1486
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Chris Hillery
>Assignee: Yingyi Bu
>
> e.g., storage.metadata.memorycomponent.numpages



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Use Maven Enforcer Plugin

2016-06-16 Thread Ian Maxon (Code Review) 
Ian Maxon has posted comments on this change.

Change subject: Use Maven Enforcer Plugin
..


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/929/2/hyracks-fullstack/pom.xml
File hyracks-fullstack/pom.xml:

Line 29: org.apache
Making the asterixdb POM dependent on the parent POM is OK, but we shouldn't do 
that for Hyracks. It needs to be able to be built independently.


https://asterix-gerrit.ics.uci.edu/#/c/929/2/pom.xml
File pom.xml:

Line 83:   3.3.9
Can we make the constraint a lower bound? I'm not sure enforcing down to minor 
revision is a good idea.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/929
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c0042a3317b41c351c44d998141ea14e72971f5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-HasComments: Yes

Change in asterixdb[master]: some code reduction/cleanup

2016-06-16 Thread Michael Blow (Code Review) 
Michael Blow has posted comments on this change.

Change subject: some code reduction/cleanup
..


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/916/4/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java:

Line 338: default:
> MAJOR SonarQube violation:
I've updated the exception pattern to match on both upper and lower case 
"fall", so next patch should not see this.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I179a16fc183bd50d5d58cc12321234df1615abfd
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-06-16 Thread Ian Maxon (Code Review) 
Ian Maxon has posted comments on this change.

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..


Patch Set 8:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/919/8/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java:

Line 475: return (long)(metadataPageNum * 
bufferCache.getPageSize()) + LIFOMetaDataFrame.LSN_OFF;
> Yes, the addition would be a long operation, but I believe the multiplicati
They can definitely exceed 2GB. I'll move the cast inside the parens, then.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-06-16 Thread Ian Maxon (Code Review) 
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/919

to look at the new patch set (#10).

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..

ASTERIXDB-1479: Change storage valid int and add explicit version

This change will stop old versions from possibly corrupting data written
by newer versions of Hyracks. It also adds an explicit version to the
tree metadata that must match the version at runtime.

Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
---
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java
4 files changed, 82 insertions(+), 50 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/19/919/10
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi

Change in asterixdb[master]: Use Maven Enforcer Plugin

2016-06-16 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Use Maven Enforcer Plugin
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/929
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c0042a3317b41c351c44d998141ea14e72971f5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Use Maven Enforcer Plugin

2016-06-16 Thread Michael Blow (Code Review) 
Michael Blow has uploaded a new patch set (#2).

Change subject: Use Maven Enforcer Plugin
..

Use Maven Enforcer Plugin

1. Ensure correct version of Maven is being used to avoid strange errors
2. Refactor pom hierarchy to enable cross-project settings

Change-Id: I9c0042a3317b41c351c44d998141ea14e72971f5
---
M asterixdb/pom.xml
M hyracks-fullstack/pom.xml
M pom.xml
3 files changed, 62 insertions(+), 57 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/29/929/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/929
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c0042a3317b41c351c44d998141ea14e72971f5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins

Change in asterixdb[master]: Use Maven Enforcer Plugin

2016-06-16 Thread Michael Blow (Code Review) 
Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/929

Change subject: Use Maven Enforcer Plugin
..

Use Maven Enforcer Plugin

1. Ensure correct version of Maven is being used to avoid strange errors
2. Refactor pom hierarchy to enable cross-project settings

Change-Id: I9c0042a3317b41c351c44d998141ea14e72971f5
---
M asterixdb/pom.xml
M hyracks-fullstack/pom.xml
M pom.xml
3 files changed, 91 insertions(+), 57 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/29/929/1

diff --git a/asterixdb/pom.xml b/asterixdb/pom.xml
index 7c5e3e7..7fce2ec 100644
--- a/asterixdb/pom.xml
+++ b/asterixdb/pom.xml
@@ -26,9 +26,8 @@
 
   
 org.apache
-apache
-16
-
+apache-asterixdb-fullstack
+0.8.9-SNAPSHOT
   
 
   
@@ -215,31 +214,6 @@
   
 org.apache.maven.plugins
 maven-resources-plugin
-  
-  
-org.apache.maven.plugins
-maven-checkstyle-plugin
-2.17
-
-  
-verify-style
-process-classes
-
-  check
-
-  
-
-
-  true
-  
-
-  
-  
-  
-
-  
-  
${project.build.sourceDirectory},${project.build.testSourceDirectory}
-
   
 
 
diff --git a/hyracks-fullstack/pom.xml b/hyracks-fullstack/pom.xml
index 8fd0502..d57f6b1 100644
--- a/hyracks-fullstack/pom.xml
+++ b/hyracks-fullstack/pom.xml
@@ -27,9 +27,8 @@
 
   
 org.apache
-apache
-LATEST
-
+apache-asterixdb-fullstack
+0.8.9-SNAPSHOT
   
 
   
@@ -280,31 +279,6 @@
 
   
 
-  
-  
-org.apache.maven.plugins
-maven-checkstyle-plugin
-2.17
-
-  
-verify-style
-process-classes
-
-  check
-
-  
-
-
-  true
-  
-
-  
-  
-  
-
-  
-  
${project.build.sourceDirectory},${project.build.testSourceDirectory}
-
   
 
 
diff --git a/pom.xml b/pom.xml
index b5676ba..0a10867 100644
--- a/pom.xml
+++ b/pom.xml
@@ -20,9 +20,16 @@
   4.0.0
   org.apache
   apache-asterixdb-fullstack
-  0.8.9
+  0.8.9-SNAPSHOT
   pom
   hyracks-asterix
+
+  
+org.apache
+apache
+16
+
+  
 
   
 
@@ -33,6 +40,85 @@
 
   
 
+  
+
+  
+org.apache.maven.plugins
+maven-checkstyle-plugin
+2.17
+
+  
+verify-style
+process-classes
+
+  check
+
+  
+
+
+  true
+  
+
+  
+  
+  
+
+  
+  
${project.build.sourceDirectory},${project.build.testSourceDirectory}
+
+  
+  
+org.apache.maven.plugins
+maven-enforcer-plugin
+1.4.1
+
+  
+enforce-versions
+
+  enforce
+
+
+  
+
+  3.3.9
+
+  
+
+  
+
+  
+
+
+  
+
+
+  org.eclipse.m2e
+  lifecycle-mapping
+  1.0.0
+  
+
+  
+
+  
+org.apache.rat
+apache-rat-plugin
+[0.11,)
+
+  check
+
+  
+  
+
+  
+
+  
+
+  
+
+  
+
+  
+
   
 hyracks-fullstack
 asterixdb

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/929
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c0042a3317b41c351c44d998141ea14e72971f5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow

Change in asterixdb[master]: Use Maven Enforcer Plugin

2016-06-16 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Use Maven Enforcer Plugin
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1658/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/929
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c0042a3317b41c351c44d998141ea14e72971f5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB- 1479: Change storage valid int and add explicit v...

2016-06-16 Thread Michael Blow (Code Review) 
Michael Blow has posted comments on this change.

Change subject: ASTERIXDB- 1479: Change storage valid int and add explicit 
version
..


Patch Set 9:

Let me know your thoughts; will give +2 if you think we can't ever have > 2 GB 
files.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB- 1479: Change storage valid int and add explicit v...

2016-06-16 Thread Michael Blow (Code Review) 
Michael Blow has posted comments on this change.

Change subject: ASTERIXDB- 1479: Change storage valid int and add explicit 
version
..


Patch Set 8:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/919/8/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java:

Line 475: return (long)(metadataPageNum * 
bufferCache.getPageSize()) + LIFOMetaDataFrame.LSN_OFF;
> Well it's fixed as far as sonarQube is concerned :P it did complain at firs
Yes, the addition would be a long operation, but I believe the multiplication 
are ints.  If we ever have files that exceed 2GB, I think we can have an issue.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes