date:20160621

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

2016-06-21 Thread Yingyi Bu (Code Review)

Yingyi Bu has posted comments on this change.

Change subject: Fix Indexing on Open fields and Meta fields
..


Patch Set 10: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/930
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6195149940f150250a65f2515e9ac9d6de2a33f9
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1150: Update adm.grammar and printers for double/f...

2016-06-21 Thread Michael Blow (Code Review)

Michael Blow has posted comments on this change.

Change subject: ASTERIXDB-1150: Update adm.grammar and printers for double/float
..


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/932/4/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
File 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java:

Line 61: import org.apache.commons.io.FileUtils;
revert?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/932
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6164d74f6c286fa160a30cff9ad47e97a30e0770
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix Decoding of byte[] Records

2016-06-21 Thread abdullah alamoudi (Code Review)

abdullah alamoudi has posted comments on this change.

Change subject: Fix Decoding of byte[] Records
..


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/951/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java:

Line 116: bytes.compact();
> Oh, I see.  There is a if-block before that.  Therefore, the compact() is c
Yingyi,
I just looked at the implementation details for the compact() and I think I 
better do a check here myself.

Will push a new patch. compact() should only be called for records which have 
non-english unicode characters and which the decoder failed to decode completely


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/951
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71c3d8b8dfa5a98123725f139247d2b5ce10012e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1375 - New Query UI implementation

2016-06-21 Thread Michael Blow (Code Review)

Michael Blow has posted comments on this change.

Change subject: ASTERIXDB-1375 - New Query UI implementation
..


Patch Set 7:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/935/7/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java:

Line 32: private static int QUERY_WEBPORT_DEFAULT = 19006;
These private static _DEFAULT fields should all be made final.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/935
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Kaveen Rodrigo 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1473: Sporadic test failure in big_ob...

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1473: Sporadic test failure in big_ob...
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1704/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/952
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f932a148dc06bf6ee5142a876f28fa518f34560
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1473: Sporadic test failure in big_ob...

2016-06-21 Thread Michael Blow (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/952

to look at the new patch set (#2).

Change subject: ASTERIXDB-1473: Sporadic test failure in big_ob...
..

ASTERIXDB-1473: Sporadic test failure in big_ob...

...ject_load_20M

On unsuccessful confiscate cycle, ensure FIFO queue is flushed

Change-Id: I4f932a148dc06bf6ee5142a876f28fa518f34560
---
M 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/AsyncFIFOPageQueueManager.java
M 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
M 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/ClockPageReplacementStrategy.java
3 files changed, 20 insertions(+), 10 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/52/952/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/952
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f932a148dc06bf6ee5142a876f28fa518f34560
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins

Change in asterixdb[master]: Index-only plan

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 10:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* algebricks
* asterix-app
* asterix-common
* asterix-external-data
* asterix-fuzzyjoin
* asterix-lang-aql
* asterix-lang-sqlpp
* asterix-om
* asterix-test-framework
* asterix-transactions
* asterixdb
* hyracks
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/744
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-only plan

2016-06-21 Thread Taewoo Kim (Code Review)

Taewoo Kim has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 9:

(238 comments)

https://asterix-gerrit.ics.uci.edu/#/c/744/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:

Line 457: protected boolean findIndexAndFillExprs(List 
datasetIndexes, List fieldName, IAType fieldType,
> MAJOR SonarQube violation:
Done


Line 646: if (subTreePKs.contains(dsVar) && dsVarIndex 
<= subTreePKs.size() - 1) {
> CRITICAL SonarQube violation:
Done


Line 737: List primaryKeyVarList = new 
ArrayList();
> MAJOR SonarQube violation:
Done


Line 922: if (optFuncExpr.getFuncExpr().getFunctionIdentifier() == 
AsterixBuiltinFunctions.EDIT_DISTANCE_CHECK) {
> MAJOR SonarQube violation:
Done


Line 984: if (unnestExpr.getExpressionTag() != 
LogicalExpressionTag.FUNCTION_CALL) {
> BLOCKER SonarQube violation:
Done


Line 1009: ArrayList idxFuncArgs = new 
ArrayList();
> MAJOR SonarQube violation:
Done


Line 1032: boolean isInnerJoin) throws AlgebricksException {
> MAJOR SonarQube violation:
Done


Line 1032: boolean isInnerJoin) throws AlgebricksException {
> MAJOR SonarQube violation:
Done


Line 1057: if (subTree.selectRefs != null && 
subTree.selectRefs.size() > 0) {
> MAJOR SonarQube violation:
Done


Line 1098: if (subTree.selectRefs != null && 
subTree.selectRefs.size() > 0) {
> MAJOR SonarQube violation:
Done


Line 1147: // secondary-index search in non-index only 
plan can keep the original attribute order from the search
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/744/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodAnalysisContext.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodAnalysisContext.java:

Line 59: private boolean isIndexOnlyPlan = false;
> MAJOR SonarQube violation:
Done


Line 72: private Quintuple 
indexOnlyPlanInfo = new Quintuple(
> MAJOR SonarQube violation:
Done


Line 72: private Quintuple 
indexOnlyPlanInfo = new Quintuple(
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/744/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodJobGenParams.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodJobGenParams.java:

Line 53: private final int NUM_PARAMS = 8;
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/744/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java:

Line 253: int numOutputVars = (primaryKeysOnly) ? numPrimaryKeys : 
numPrimaryKeys + numSecondaryKeys;
> MAJOR SonarQube violation:
Done


Line 257: // If not, add one more variables to put the result of 
instantTryLock - whether this lock can be granted on a primary key
> MAJOR SonarQube violation:
Done


Line 259: // If it is not granted, then we need to do a secondary index 
lookup, sort PKs, do a primary index lookup, and select.
> MAJOR SonarQube violation:
Done


Line 333: List keyVars = new 
ArrayList();
> MAJOR SonarQube violation:
Done


Line 334: List sourceVars = null;
> MAJOR SonarQube violation:
Done


Line 346: switch (keyType) {
> MAJOR SonarQube violation:
Done


Line 387:  * If we are optimizing a selection query then this method 
returns a ConstantExpression from the first constant value
> MAJOR SonarQube violation:
Done


Line 440: // we need to check a corner case 
where two real values are located between an INT value.
> MAJOR SonarQube violation:
Done


Line 447: // It should generate a result if 
there is a tuple that satisfies the condition, which is 3,
> MAJOR SonarQube violation:
Done


Line 449: // fail after truncating the fraction 
part (there is no INT whose value is greater than 2 and less than 3.)
> MAJOR SonarQube violation:
Done


Line 467: // IntVar = 4.3 ==> round-down and 
round-up: IntVar = 4 and IntVar = 5 (eventually - false)
> MAJOR SonarQube violation:
Done


Line 468: // IntVar = 4.0 ==> round-down and 
round-up:

Change in asterixdb[master]: Index-only plan

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Index-only plan
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1703/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/744
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixed the nested loop join algorithm to use join memory para...

2016-06-21 Thread Preston Carman (Code Review)

Preston Carman has submitted this change and it was merged.

Change subject: Fixed the nested loop join algorithm to use join memory 
parameter.
..


Fixed the nested loop join algorithm to use join memory parameter.

Change-Id: I50e24ea023c9ae9aa043698716e5021d4dafc327
Reviewed-on: https://asterix-gerrit.ics.uci.edu/953
Reviewed-by: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Ian Maxon 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
3 files changed, 30 insertions(+), 34 deletions(-)

Approvals:
  Ian Maxon: Looks good to me, approved
  Jenkins: Looks good to me, but someone else must approve; Verified



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
index f07fb76..68fbba4 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
@@ -242,7 +242,7 @@
 
OptimizationConfUtil.getPhysicalOptimizationConfig().setFrameSize(frameSize);
 
OptimizationConfUtil.getPhysicalOptimizationConfig().setMaxFramesExternalSort(sortFrameLimit);
 
OptimizationConfUtil.getPhysicalOptimizationConfig().setMaxFramesExternalGroupBy(groupFrameLimit);
-
OptimizationConfUtil.getPhysicalOptimizationConfig().setMaxFramesHybridHash(joinFrameLimit);
+
OptimizationConfUtil.getPhysicalOptimizationConfig().setMaxFramesForJoin(joinFrameLimit);
 
 HeuristicCompilerFactoryBuilder builder = new 
HeuristicCompilerFactoryBuilder(
 AqlOptimizationContextFactory.INSTANCE);
diff --git 
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
 
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
index f0f858d..7340882 100644
--- 
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
+++ 
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
@@ -26,8 +26,8 @@
 private static final String FRAMESIZE = "FRAMESIZE";
 private static final String MAX_FRAMES_EXTERNAL_SORT = 
"MAX_FRAMES_EXTERNAL_SORT";
 private static final String MAX_FRAMES_EXTERNAL_GROUP_BY = 
"MAX_FRAMES_EXTERNAL_GROUP_BY";
-private static final String MAX_FRAMES_LEFT_INPUT_HYBRID_HASH = 
"MAX_FRAMES_LEFT_INPUT_HYBRID_HASH";
-private static final String MAX_FRAMES_HYBRID_HASH = 
"MAX_FRAMES_HYBRID_HASH";
+private static final String MAX_FRAMES_FOR_JOIN_LEFT_INPUT = 
"MAX_FRAMES_FOR_JOIN_LEFT_INPUT";
+private static final String MAX_FRAMES_FOR_JOIN = "MAX_FRAMES_FOR_JOIN";
 private static final String FUDGE_FACTOR = "FUDGE_FACTOR";
 private static final String MAX_RECORDS_PER_FRAME = 
"MAX_RECORDS_PER_FRAME";
 
@@ -73,22 +73,22 @@
 setInt(MAX_RECORDS_PER_FRAME, maxRecords);
 }
 
-public int getMaxFramesLeftInputHybridHash() {
+public int getMaxFramesForJoinLeftInput() {
 int frameSize = getFrameSize();
-return getInt(MAX_FRAMES_LEFT_INPUT_HYBRID_HASH, (int) (140L * 1024 * 
MB / frameSize));
+return getInt(MAX_FRAMES_FOR_JOIN_LEFT_INPUT, (int) (140L * 1024 * MB 
/ frameSize));
 }
 
-public void setMaxFramesLeftInputHybridHash(int frameLimit) {
-setInt(MAX_FRAMES_LEFT_INPUT_HYBRID_HASH, frameLimit);
+public void setMaxFramesForJoinLeftInput(int frameLimit) {
+setInt(MAX_FRAMES_FOR_JOIN_LEFT_INPUT, frameLimit);
 }
 
-public int getMaxFramesHybridHash() {
+public int getMaxFramesForJoin() {
 int frameSize = getFrameSize();
-return getInt(MAX_FRAMES_HYBRID_HASH, (int) (64L * MB / frameSize));
+return getInt(MAX_FRAMES_FOR_JOIN, (int) (64L * MB / frameSize));
 }
 
-public void setMaxFramesHybridHash(int frameLimit) {
-setInt(MAX_FRAMES_HYBRID_HASH, frameLimit);
+public void setMaxFramesForJoin(int frameLimit) {
+setInt(MAX_FRAMES_FOR_JOIN, frameLimit);
 }
 
 public int getMaxFramesExternalGroupBy() {
diff --git 
a/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java

Change in asterixdb[master]: Fixed the nested loop join algorithm to use join memory para...

2016-06-21 Thread Ian Maxon (Code Review)

Ian Maxon has posted comments on this change.

Change subject: Fixed the nested loop join algorithm to use join memory 
parameter.
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/953
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50e24ea023c9ae9aa043698716e5021d4dafc327
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Support implicit variable name and column name.

2016-06-21 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/950

to look at the new patch set (#3).

Change subject: Support implicit variable name and column name.
..

Support implicit variable name and column name.

1. Fixed open/closed type optimization;
2. Fixed scoping for nested aggregations;
3. Support WITH clauses in general cases.

Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/disjunction-to-join-delete-3.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/scan-insert-secondary-index.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/scan-insert.plan
M asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/2.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias2.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias3.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/nestedFLWOGR3.ast
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-2/q2-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-2/q2-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-2/q2-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-3/q2-3.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-3/q2-3.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-3/q2-3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-4/q2-4.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-4/q2-4.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-4/q2-4.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-5/q2-5.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-5/q2-5.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-5/q2-5.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/varlen-encoding/varlen-encoding.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/distinct_by/distinct_by.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/distinct_by/distinct_by.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/distinct_by/distinct_by.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/group_no_agg/group_no_agg.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/group_no_agg/group_no_agg.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/group_no_agg/group_no_agg.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate/nest_aggregate.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate/nest_aggregate.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate/nest_aggregate.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate2/nest_aggregate2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate2/nest_aggregate2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate2/nest_aggregate2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q01_pricing_summary_report_nt/q01_pricing_summary_report_nt.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q01_pricing_summary_report_nt/q01_pricing_summary_report_nt.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q01_pricing_summary_report_nt/q01_pricing_summary_report_nt.3.query.sqlpp
A

Change in asterixdb[master]: Support implicit variable name and column name.

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Support implicit variable name and column name.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1702/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/950
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1150: Update adm.grammar and printers for double/f...

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1150: Update adm.grammar and printers for double/float
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1701/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/932
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6164d74f6c286fa160a30cff9ad47e97a30e0770
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Update adm.grammar and printers for double/float

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Update adm.grammar and printers for double/float
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1700/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/932
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6164d74f6c286fa160a30cff9ad47e97a30e0770
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Update adm.grammar and printers for double/float

2016-06-21 Thread Ian Maxon (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/932

to look at the new patch set (#3).

Change subject: Update adm.grammar and printers for double/float
..

Update adm.grammar and printers for double/float

adm.grammar was not accepting suffixed doubles. This was breaking
a lot of round-trip ADM cases. I also changed the default print for
float and double to not have a suffix, because this makes the output
very odd (NaNd, NaNf, -Infinityf). The print mode for integers
has also been changed to omit the suffix, but, similarly the old
format is still accepted.

Change-Id: I6164d74f6c286fa160a30cff9ad47e97a30e0770
---
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-6/dataset_with_meta-6.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-7/dataset_with_meta-7.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta01/meta01.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta05/meta05.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta12/meta12.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta16/meta16.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta17/meta17.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse/metadata_dataverse.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_index/metadata_index.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_subsequent_no_execution/verify_failure_subsequent_no_execution.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/agg_null_rec/agg_null_rec.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/agg_null_rec_1/agg_null_rec.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/agg_number/agg_number.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/agg_number_rec/agg_number_rec.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/avg_double/avg_double.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/avg_double_null/avg_double_null.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/avg_float/avg_float.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/avg_float_null/avg_float_null.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/avg_int16/avg_int16.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/avg_int16_null/avg_int16_null.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/avg_int32/avg_int32.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/avg_int32_null/avg_int32_null.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/avg_int64/avg_int64.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/avg_int64_null/avg_int64_null.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/avg_int8/avg_int8.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/avg_int8_null/avg_int8_null.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/issue412_1/issue412_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate-sql/issue425_min_hetero_list_1/issue425_min_hetero_list_1.1.adm
M

Change in asterixdb[master]: Fixed the nested loop join algorithm to use join memory para...

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Fixed the nested loop join algorithm to use join memory 
parameter.
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/953
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50e24ea023c9ae9aa043698716e5021d4dafc327
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixed the nested loop join algorithm to use join memory para...

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Fixed the nested loop join algorithm to use join memory 
parameter.
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1699/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/953
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50e24ea023c9ae9aa043698716e5021d4dafc327
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Fixed the nested loop join algorithm to use join memory para...

2016-06-21 Thread Preston Carman (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/953

to look at the new patch set (#2).

Change subject: Fixed the nested loop join algorithm to use join memory 
parameter.
..

Fixed the nested loop join algorithm to use join memory parameter.

Change-Id: I50e24ea023c9ae9aa043698716e5021d4dafc327
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
3 files changed, 30 insertions(+), 34 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/53/953/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/953
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50e24ea023c9ae9aa043698716e5021d4dafc327
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann

[jira] [Created] (ASTERIXDB-1490) NPE for negative expression

2016-06-21 Thread Yingyi Bu (JIRA)

Yingyi Bu created ASTERIXDB-1490:


 Summary: NPE for negative expression
 Key: ASTERIXDB-1490
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1490
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: Optimizer
Reporter: Yingyi Bu
Assignee: Yingyi Bu


Query:

{noformat}
SELECT VALUE COUNT(1)
FROM (
   SELECT DISTINCT VALUE -n.foo
   FROM Bar n 
) tmp;
{noformat}

Exception trace:
{noformat}
java.lang.NullPointerException
at 
org.apache.asterix.om.typecomputer.impl.ListConstructorTypeComputer.computeTypeFromItems(ListConstructorTypeComputer.java:59)
at 
org.apache.asterix.om.typecomputer.impl.ListConstructorTypeComputer.computeType(ListConstructorTypeComputer.java:50)
at 
org.apache.asterix.dataflow.data.common.AqlExpressionTypeComputer.getTypeForFunction(AqlExpressionTypeComputer.java:75)
at 
org.apache.asterix.dataflow.data.common.AqlExpressionTypeComputer.getType(AqlExpressionTypeComputer.java:53)
at 
org.apache.hyracks.algebricks.core.algebra.operators.logical.AggregateOperator.computeOutputTypeEnvironment(AggregateOperator.java:106)
at 
org.apache.hyracks.algebricks.core.rewriter.base.AlgebricksOptimizationContext.computeAndSetTypeEnvironmentForOperator(AlgebricksOptimizationContext.java:295)
at 
org.apache.hyracks.algebricks.rewriter.rules.InferTypesRule.rewritePost(InferTypesRule.java:42)
at 
org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:125)
at 
org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:111)
at 
org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:99)
at 
org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:99)
at 
org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:99)
at 
org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:99)
at 
org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:99)
at 
org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:99)
at 
org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController.rewriteOperatorRef(AbstractRuleController.java:99)
at 
org.apache.hyracks.algebricks.compiler.rewriter.rulecontrollers.SequentialOnceRuleController.rewriteWithRuleCollection(SequentialOnceRuleController.java:44)
at 
org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer.runOptimizationSets(HeuristicOptimizer.java:95)
at 
org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer.optimize(HeuristicOptimizer.java:82)
at 
org.apache.hyracks.algebricks.compiler.api.HeuristicCompilerFactoryBuilder$1$1.optimize(HeuristicCompilerFactoryBuilder.java:88)
at 
org.apache.asterix.api.common.APIFramework.compileQuery(APIFramework.java:263)
at 
org.apache.asterix.aql.translator.QueryTranslator.rewriteCompileQuery(QueryTranslator.java:1959)
at 
org.apache.asterix.aql.translator.QueryTranslator.handleQuery(QueryTranslator.java:2521)
at 
org.apache.asterix.aql.translator.QueryTranslator.compileAndExecute(QueryTranslator.java:389)
at 
org.apache.asterix.aql.translator.QueryTranslator.compileAndExecute(QueryTranslator.java:253)
at 
org.apache.asterix.api.http.servlet.APIServlet.doPost(APIServlet.java:148)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:754)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:847)
at 
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:546)
at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:483)
at 
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:970)
at 
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:411)
at 
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:192)
at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:904)
at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117)
at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:110)
at org.eclipse.jetty.server.Server.handle(Server.java:347)
at

Change in asterixdb[master]: ASTERIXDB-1375 - New Query UI implementation

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1375 - New Query UI implementation
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1695/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/935
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Kaveen Rodrigo 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: PLEASE EDIT to provide a meaningful commit message!

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: PLEASE EDIT to provide a meaningful commit message!
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1694/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/935
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Kaveen Rodrigo 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1375 - New Query UI implementation

2016-06-21 Thread Kaveen Rodrigo (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/935

to look at the new patch set (#7).

Change subject: ASTERIXDB-1375 - New Query UI implementation
..

ASTERIXDB-1375 - New Query UI implementation

Implemented UI using bootstrap according to specification
Wrote the client side logic using Angular JS 
Using CodeMirror and custom mode to do syntax highlighting.
Modified HTTP API to support CORS.
Custom servlet to host new Web Ui on port 19006.

Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689
---
M .gitignore
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
A asterixdb/asterix-app/src/main/resources/newui/css/bootstrap-theme.min.css
A asterixdb/asterix-app/src/main/resources/newui/css/bootstrap.min.css
A asterixdb/asterix-app/src/main/resources/newui/css/codemirror.css
A asterixdb/asterix-app/src/main/resources/newui/css/json-formatter.min.css
A asterixdb/asterix-app/src/main/resources/newui/css/master.css
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.eot
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.svg
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.ttf
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.woff
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.woff2
A asterixdb/asterix-app/src/main/resources/newui/img/finalasterixlogo.png
A asterixdb/asterix-app/src/main/resources/newui/js/angular.min.js
A asterixdb/asterix-app/src/main/resources/newui/js/aql-mode.js
A asterixdb/asterix-app/src/main/resources/newui/js/bootstrap.min.js
A asterixdb/asterix-app/src/main/resources/newui/js/codemirror.js
A asterixdb/asterix-app/src/main/resources/newui/js/javascript.js
A asterixdb/asterix-app/src/main/resources/newui/js/jquery-1.12.4.min.js
A asterixdb/asterix-app/src/main/resources/newui/js/json-formatter.min.js
A asterixdb/asterix-app/src/main/resources/newui/js/main.js
A asterixdb/asterix-app/src/main/resources/newui/js/ui-codemirror.js
A asterixdb/asterix-app/src/main/resources/newui/queryui.html
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
M asterixdb/asterix-installer/src/main/resources/conf/asterix-configuration.xml
27 files changed, 11,524 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/935/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/935
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Kaveen Rodrigo 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins

Change in asterixdb[master]: PLEASE EDIT to provide a meaningful commit message!

2016-06-21 Thread Kaveen Rodrigo (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/935

to look at the new patch set (#6).

Change subject: PLEASE EDIT to provide a meaningful commit message!
..

PLEASE EDIT to provide a meaningful commit message!

The following commits from your working branch will be included:

commit 4536658e613caa36afe33eff0fe3fc686c88b75a
Author: Kaveen Rodrigo 
Date:   Fri Jun 17 02:17:13 2016 +0530

fixed typos

commit e41f70d07c588b5f20addd8cdb0151d4ba0ec962
Author: Kaveen Rodrigo 
Date:   Thu Jun 16 22:57:16 2016 +0530

support a result array with values

commit 487309f1a6e5dbfafb35a87c32b43df379e4c1b0
Author: Kaveen Rodrigo 
Date:   Tue Jun 14 18:48:11 2016 +0530

reversed history tab order

commit a5d0582e862cca92287ac8f6a249be1ce2b6b135
Author: Kaveen Rodrigo 
Date:   Tue Jun 14 18:22:51 2016 +0530

added 'or' and 'and' as keywords

commit 722734e504518b0c1f33ca4d5910a632db19606d
Author: Kaveen Rodrigo 
Date:   Tue Jun 14 08:21:45 2016 +0530

fixed logo sizing issues using vh

commit 720d33a252d75c08dd394c244a5d8f7fc57b50da
Author: Kaveen Rodrigo 
Date:   Tue Jun 14 08:06:44 2016 +0530

disabled line wrapping on input window

commit 5cb840c5fd648c8bae003f4e5f14e365857e37fd
Author: Kaveen Rodrigo 
Date:   Tue Jun 14 07:22:45 2016 +0530

used bootstrap grids to scale AsterixDB logo

commit e1428c1e58c7b7f3dc3a6d4cd59f6323f0020249
Author: Kaveen Rodrigo 
Date:   Tue Jun 14 07:14:54 2016 +0530

added javascript mode for CodeMirror and integrated into record preview 
window

commit cc30b5bd31b1a6577931b1d22ca3e01ad99c53b5
Author: Kaveen Rodrigo 
Date:   Sun Jun 12 14:13:17 2016 +0530

minor cosmetic change, added top padding to the maximum button

commit 60f84da1878dfca51587f2d8d371796381b0bf33
Author: Kaveen Rodrigo 
Date:   Sun Jun 12 13:01:36 2016 +0530

auto select first dataverse in AsterixDB for using field

commit a9036ac880c983c9c2a6c4c56fee54ded52c8d26
Author: Kaveen Rodrigo 
Date:   Sun Jun 12 12:54:01 2016 +0530

made the code window scrollable

commit ff77d2adef48f2b3f5c54bc6904ec2e39f399935
Author: Kaveen Rodrigo 
Date:   Sun Jun 12 12:53:34 2016 +0530

added pattern to match the dot operator, added 'dataset' into keywords

commit 5901859d1404083b9bd3d9ff7d489232813aef4b
Author: Kaveen Rodrigo 
Date:   Sun Jun 12 12:31:37 2016 +0530

Fixed highlighting bug, added new line detection

commit 77adcf373422cf9a1cc3ce4734108a75f764995b
Author: Kaveen Rodrigo 
Date:   Sat Jun 11 22:57:20 2016 +0530

integrated CodeMirror

commit 32dbbb00ddaa771c3deb62b6a96829514702abdd
Author: Kaveen Rodrigo 
Date:   Sat Jun 11 22:56:21 2016 +0530

custom mode for CodeMirror to allow AQL syntax highlighting
TODO : only match complete words

commit c1226352d70030e452b4a61b8f8095f6ca91e3bd
Author: Kaveen Rodrigo 
Date:   Sat Jun 11 22:54:37 2016 +0530

Dependencies needed for syntax highlighting

commit 46199f79b8d42dea97fcb16002d8f1fbf68b9a68
Author: Kaveen Rodrigo 
Date:   Sat Jun 11 14:48:33 2016 +0530

Typo on isNested function, that dismisses counting Objects

commit b9bb32ebef65193a9ea3ddabc3088464296cc101
Author: Kaveen Rodrigo 
Date:   Sat Jun 11 12:20:46 2016 +0530

fixed bug, objects not formatted as nested

commit 23a832ae4a6cd8184768cd5c0f0459d82e58d6e3
Author: Kaveen Rodrigo 
Date:   Fri Jun 10 17:51:18 2016 +0530

support for multiple MIME/filetypes, used IOUtils instead of an 
Stringbuilder buffer solving file corrupting issues.

commit 4418006d2560019ce2d9e607bf25c2a891652155
Author: Kaveen Rodrigo 
Date:   Fri Jun 10 00:42:53 2016 +0530

enable cross-origin resource sharing in the HTTP API

commit 9149f0b5600c7adb44b43bb1a6e605a2867bcbff
Author: Kaveen Rodrigo 
Date:   Thu Jun 9 23:04:31 2016 +0530

added linebreaks to the stringbuilder (http body) to avoid angular 
controller code errors

commit 98ef33e340d48158c1e5d42d7b780034e875170d
Author: Kaveen Rodrigo 
Date:   Thu Jun 9 20:29:54 2016 +0530

refactored external files in relation to resources

commit 79dc9c1bb318477b3252d1235669076ab5f75744
Author: Kaveen Rodrigo 
Date:   Tue Jun 7 10:58:20 2016 +0530

used location.hostname insted of location.host to fix connection problem

commit 814c2960a5938be0705e2ff37ba3c1b5e1970204
Author: Kaveen Rodrigo

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-06-21 Thread Michael Blow (Code Review)

Michael Blow has posted comments on this change.

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..


Patch Set 11: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix Decoding of byte[] Records

2016-06-21 Thread Yingyi Bu (Code Review)

Yingyi Bu has posted comments on this change.

Change subject: Fix Decoding of byte[] Records
..


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/951/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java:

Line 116: bytes.compact();
> That's going to be a lot of copies if I understand correctly...  You end up
Oh, I see.  There is a if-block before that.  Therefore, the compact() is 
called not that frequently and is called only for boundary records?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/951
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71c3d8b8dfa5a98123725f139247d2b5ce10012e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix Decoding of byte[] Records

2016-06-21 Thread Yingyi Bu (Code Review)

Yingyi Bu has posted comments on this change.

Change subject: Fix Decoding of byte[] Records
..


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/951/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java:

Line 116: bytes.compact();
> Once per record. However, this is mostly a no op. it is only an op if the d
That's going to be a lot of copies if I understand correctly...  You end up 
copying half of frame k times, where k is the number of records within that 
frame.   "half-of-frame" is the mathematical expectation.

For example, you have 100 records for a 32KB frame, you'll copy 1.6MB data for 
each frame:  100 * (32KB/2).  Am I correct?

How many frames will flow through this set call?  Is it proportional to the 
data volume?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/951
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71c3d8b8dfa5a98123725f139247d2b5ce10012e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1375 - New Query UI implementation

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1375 - New Query UI implementation
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1693/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/935
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Kaveen Rodrigo 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1375 - New Query UI implementation

2016-06-21 Thread Kaveen Rodrigo (Code Review)

Kaveen Rodrigo has uploaded a new patch set (#5).

Change subject: ASTERIXDB-1375 - New Query UI implementation
..

ASTERIXDB-1375 - New Query UI implementation

Implemented UI using bootstrap according to specification
Wrote the client side logic using Angular JS 
Using CodeMirror and custom mode to do syntax highlighting.
Modified HTTP API to support CORS.
Custom servlet to host new Web Ui on port 19006.

Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689
---
M .gitignore
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
A asterixdb/asterix-app/src/main/resources/newui/css/bootstrap-theme.min.css
A asterixdb/asterix-app/src/main/resources/newui/css/bootstrap.min.css
A asterixdb/asterix-app/src/main/resources/newui/css/codemirror.css
A asterixdb/asterix-app/src/main/resources/newui/css/json-formatter.min.css
A asterixdb/asterix-app/src/main/resources/newui/css/master.css
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.eot
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.svg
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.ttf
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.woff
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.woff2
A asterixdb/asterix-app/src/main/resources/newui/img/finalasterixlogo.png
A asterixdb/asterix-app/src/main/resources/newui/js/angular.min.js
A asterixdb/asterix-app/src/main/resources/newui/js/aql-mode.js
A asterixdb/asterix-app/src/main/resources/newui/js/bootstrap.min.js
A asterixdb/asterix-app/src/main/resources/newui/js/codemirror.js
A asterixdb/asterix-app/src/main/resources/newui/js/javascript.js
A asterixdb/asterix-app/src/main/resources/newui/js/jquery-1.12.4.min.js
A asterixdb/asterix-app/src/main/resources/newui/js/json-formatter.min.js
A asterixdb/asterix-app/src/main/resources/newui/js/main.js
A asterixdb/asterix-app/src/main/resources/newui/js/ui-codemirror.js
A asterixdb/asterix-app/src/main/resources/newui/queryui.html
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
M asterixdb/asterix-installer/src/main/resources/conf/asterix-configuration.xml
27 files changed, 11,527 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/935/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/935
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Kaveen Rodrigo 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins

Change in asterixdb[master]: PLEASE EDIT to provide a meaningful commit message!

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: PLEASE EDIT to provide a meaningful commit message!
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1692/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/935
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Kaveen Rodrigo 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: PLEASE EDIT to provide a meaningful commit message!

2016-06-21 Thread Kaveen Rodrigo (Code Review)

Kaveen Rodrigo has uploaded a new patch set (#4).

Change subject: PLEASE EDIT to provide a meaningful commit message!
..

PLEASE EDIT to provide a meaningful commit message!

The following commits from your working branch will be included:

commit 4536658e613caa36afe33eff0fe3fc686c88b75a
Author: Kaveen Rodrigo 
Date:   Fri Jun 17 02:17:13 2016 +0530

fixed typos

commit e41f70d07c588b5f20addd8cdb0151d4ba0ec962
Author: Kaveen Rodrigo 
Date:   Thu Jun 16 22:57:16 2016 +0530

support a result array with values

commit 487309f1a6e5dbfafb35a87c32b43df379e4c1b0
Author: Kaveen Rodrigo 
Date:   Tue Jun 14 18:48:11 2016 +0530

reversed history tab order

commit a5d0582e862cca92287ac8f6a249be1ce2b6b135
Author: Kaveen Rodrigo 
Date:   Tue Jun 14 18:22:51 2016 +0530

added 'or' and 'and' as keywords

commit 722734e504518b0c1f33ca4d5910a632db19606d
Author: Kaveen Rodrigo 
Date:   Tue Jun 14 08:21:45 2016 +0530

fixed logo sizing issues using vh

commit 720d33a252d75c08dd394c244a5d8f7fc57b50da
Author: Kaveen Rodrigo 
Date:   Tue Jun 14 08:06:44 2016 +0530

disabled line wrapping on input window

commit 5cb840c5fd648c8bae003f4e5f14e365857e37fd
Author: Kaveen Rodrigo 
Date:   Tue Jun 14 07:22:45 2016 +0530

used bootstrap grids to scale AsterixDB logo

commit e1428c1e58c7b7f3dc3a6d4cd59f6323f0020249
Author: Kaveen Rodrigo 
Date:   Tue Jun 14 07:14:54 2016 +0530

added javascript mode for CodeMirror and integrated into record preview 
window

commit cc30b5bd31b1a6577931b1d22ca3e01ad99c53b5
Author: Kaveen Rodrigo 
Date:   Sun Jun 12 14:13:17 2016 +0530

minor cosmetic change, added top padding to the maximum button

commit 60f84da1878dfca51587f2d8d371796381b0bf33
Author: Kaveen Rodrigo 
Date:   Sun Jun 12 13:01:36 2016 +0530

auto select first dataverse in AsterixDB for using field

commit a9036ac880c983c9c2a6c4c56fee54ded52c8d26
Author: Kaveen Rodrigo 
Date:   Sun Jun 12 12:54:01 2016 +0530

made the code window scrollable

commit ff77d2adef48f2b3f5c54bc6904ec2e39f399935
Author: Kaveen Rodrigo 
Date:   Sun Jun 12 12:53:34 2016 +0530

added pattern to match the dot operator, added 'dataset' into keywords

commit 5901859d1404083b9bd3d9ff7d489232813aef4b
Author: Kaveen Rodrigo 
Date:   Sun Jun 12 12:31:37 2016 +0530

Fixed highlighting bug, added new line detection

commit 77adcf373422cf9a1cc3ce4734108a75f764995b
Author: Kaveen Rodrigo 
Date:   Sat Jun 11 22:57:20 2016 +0530

integrated CodeMirror

commit 32dbbb00ddaa771c3deb62b6a96829514702abdd
Author: Kaveen Rodrigo 
Date:   Sat Jun 11 22:56:21 2016 +0530

custom mode for CodeMirror to allow AQL syntax highlighting
TODO : only match complete words

commit c1226352d70030e452b4a61b8f8095f6ca91e3bd
Author: Kaveen Rodrigo 
Date:   Sat Jun 11 22:54:37 2016 +0530

Dependencies needed for syntax highlighting

commit 46199f79b8d42dea97fcb16002d8f1fbf68b9a68
Author: Kaveen Rodrigo 
Date:   Sat Jun 11 14:48:33 2016 +0530

Typo on isNested function, that dismisses counting Objects

commit b9bb32ebef65193a9ea3ddabc3088464296cc101
Author: Kaveen Rodrigo 
Date:   Sat Jun 11 12:20:46 2016 +0530

fixed bug, objects not formatted as nested

commit 23a832ae4a6cd8184768cd5c0f0459d82e58d6e3
Author: Kaveen Rodrigo 
Date:   Fri Jun 10 17:51:18 2016 +0530

support for multiple MIME/filetypes, used IOUtils instead of an 
Stringbuilder buffer solving file corrupting issues.

commit 4418006d2560019ce2d9e607bf25c2a891652155
Author: Kaveen Rodrigo 
Date:   Fri Jun 10 00:42:53 2016 +0530

enable cross-origin resource sharing in the HTTP API

commit 9149f0b5600c7adb44b43bb1a6e605a2867bcbff
Author: Kaveen Rodrigo 
Date:   Thu Jun 9 23:04:31 2016 +0530

added linebreaks to the stringbuilder (http body) to avoid angular 
controller code errors

commit 98ef33e340d48158c1e5d42d7b780034e875170d
Author: Kaveen Rodrigo 
Date:   Thu Jun 9 20:29:54 2016 +0530

refactored external files in relation to resources

commit 79dc9c1bb318477b3252d1235669076ab5f75744
Author: Kaveen Rodrigo 
Date:   Tue Jun 7 10:58:20 2016 +0530

used location.hostname insted of location.host to fix connection problem

commit 814c2960a5938be0705e2ff37ba3c1b5e1970204
Author: Kaveen Rodrigo 
Date:   Tue Jun 7 02:15:46 2016 +0530

wrong method signature, updated with correct signature

Change in asterixdb[master]: Fix Decoding of byte[] Records

2016-06-21 Thread abdullah alamoudi (Code Review)

abdullah alamoudi has posted comments on this change.

Change subject: Fix Decoding of byte[] Records
..


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/951/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java:

Line 116: bytes.compact();
> How many copies are done for each buffer, roughly?
Once per record. However, this is mostly a no op. it is only an op if the 
decoder couldn't decode all the bytes and so we need to move the leftover to 
the beginning of the buffer and correct the position. which is what compact 
does for you.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/951
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71c3d8b8dfa5a98123725f139247d2b5ce10012e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Fix Indexing on Open fields and Meta fields
..


Patch Set 10:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/930
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6195149940f150250a65f2515e9ac9d6de2a33f9
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

2016-06-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Fix Indexing on Open fields and Meta fields
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1691/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/930
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6195149940f150250a65f2515e9ac9d6de2a33f9
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

2016-06-21 Thread abdullah alamoudi (Code Review)

abdullah alamoudi has posted comments on this change.

Change subject: Fix Indexing on Open fields and Meta fields
..


Patch Set 9:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/930/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:

Line 486: } else {
> Introducing these methods is really nice! Would be even nicer, if they got 
Done


https://asterix-gerrit.ics.uci.edu/#/c/930/9/asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/secondary_index-nljoin_with_meta-2.plan
File 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/secondary_index-nljoin_with_meta-2.plan:

Line 18:   -- ASSIGN  |PARTITIONED|
> Why does this plan use hybrid hash join instead of index join?
Done


https://asterix-gerrit.ics.uci.edu/#/c/930/9/asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/secondary_index-nljoin_with_meta-4.plan
File 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/secondary_index-nljoin_with_meta-4.plan:

Line 15: -- EMPTY_TUPLE_SOURCE  |PARTITIONED|
> Why does this query use hybrid hash join instead of index join?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/930
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6195149940f150250a65f2515e9ac9d6de2a33f9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

2016-06-21 Thread abdullah alamoudi (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/930

to look at the new patch set (#10).

Change subject: Fix Indexing on Open fields and Meta fields
..

Fix Indexing on Open fields and Meta fields

This change fix the following cases:
1. Build a secondary index on a meta field: success
2. Build an open index on a meta field: failure
3. Build a secondary index on an open field in record part: success

Testing ingestion and querying are working correctly for these cases.

Change-Id: I6195149940f150250a65f2515e9ac9d6de2a33f9
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/IndexOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryIndexOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryInvertedIndexOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-lojoin_with_meta-1.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-nljoin_with_meta-1.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-nljoin_with_meta-2.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-nljoin_with_meta-3.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-nljoin_with_meta-4.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index_with_meta-1.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index_with_meta-2.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/secondary_index-lojoin_with_meta-1.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/secondary_index-nljoin_with_meta-1.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/secondary_index-nljoin_with_meta-2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/secondary_index-nljoin_with_meta-3.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/secondary_index-nljoin_with_meta-4.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/secondary_index_with_meta-1.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/meta/secondary_index_with_meta-2.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-open-index-in-meta/change-feed-with-meta-open-index-in-meta.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-open-index-in-meta/change-feed-with-meta-open-index-in-meta.2.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.3.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.4.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.5.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-in-meta/change-feed-with-meta-pk-in-meta-index-in-meta.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-in-meta/change-feed-with-meta-pk-in-meta-index-in-meta.2.update.aql
A

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

Change in asterixdb[master]: ASTERIXDB-1150: Update adm.grammar and printers for double/f...

Change in asterixdb[master]: Fix Decoding of byte[] Records

Change in asterixdb[master]: ASTERIXDB-1375 - New Query UI implementation

Change in asterixdb[master]: ASTERIXDB-1473: Sporadic test failure in big_ob...

Change in asterixdb[master]: ASTERIXDB-1473: Sporadic test failure in big_ob...

Change in asterixdb[master]: Index-only plan

Change in asterixdb[master]: Index-only plan

Change in asterixdb[master]: Index-only plan

Change in asterixdb[master]: Fixed the nested loop join algorithm to use join memory para...

Change in asterixdb[master]: Fixed the nested loop join algorithm to use join memory para...

Change in asterixdb[master]: Support implicit variable name and column name.

Change in asterixdb[master]: Support implicit variable name and column name.

Change in asterixdb[master]: ASTERIXDB-1150: Update adm.grammar and printers for double/f...

Change in asterixdb[master]: Update adm.grammar and printers for double/float

Change in asterixdb[master]: Update adm.grammar and printers for double/float

Change in asterixdb[master]: Fixed the nested loop join algorithm to use join memory para...

Change in asterixdb[master]: Fixed the nested loop join algorithm to use join memory para...

Change in asterixdb[master]: Fixed the nested loop join algorithm to use join memory para...

[jira] [Created] (ASTERIXDB-1490) NPE for negative expression

Change in asterixdb[master]: ASTERIXDB-1375 - New Query UI implementation

Change in asterixdb[master]: PLEASE EDIT to provide a meaningful commit message!

Change in asterixdb[master]: ASTERIXDB-1375 - New Query UI implementation

Change in asterixdb[master]: PLEASE EDIT to provide a meaningful commit message!

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

Change in asterixdb[master]: Fix Decoding of byte[] Records

Change in asterixdb[master]: Fix Decoding of byte[] Records

Change in asterixdb[master]: ASTERIXDB-1375 - New Query UI implementation

Change in asterixdb[master]: ASTERIXDB-1375 - New Query UI implementation

Change in asterixdb[master]: PLEASE EDIT to provide a meaningful commit message!

Change in asterixdb[master]: PLEASE EDIT to provide a meaningful commit message!

Change in asterixdb[master]: Fix Decoding of byte[] Records

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

36 matches

Site Navigation

Mail list logo

Footer information