date:20160630

Change in asterixdb[master]: Fix the binary documentation

2016-06-30 Thread Jianfeng Jia (Code Review)

Jianfeng Jia has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/970

Change subject: Fix the binary documentation
..

Fix the binary documentation

Change-Id: I509f0d4bc4b228d85226a85fe68d6ae97b52f5bd
---
M asterixdb/asterix-doc/src/site/markdown/aql/functions.md
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/70/970/1

diff --git a/asterixdb/asterix-doc/src/site/markdown/aql/functions.md 
b/asterixdb/asterix-doc/src/site/markdown/aql/functions.md
index 89dc311..b6f5538 100644
--- a/asterixdb/asterix-doc/src/site/markdown/aql/functions.md
+++ b/asterixdb/asterix-doc/src/site/markdown/aql/functions.md
@@ -591,7 +591,7 @@
 " the voice-command is bad:("
 " the voicemail-service is awesome"
 
-## String Functions [Back to TOC] ##
+## Binary Functions [Back to TOC] ##
 ### parse-binary ###
   * Syntax:
 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/970
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I509f0d4bc4b228d85226a85fe68d6ae97b52f5bd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia

Change in asterixdb[master]: Fix the binary documentation

2016-06-30 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Fix the binary documentation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1783/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/970
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I509f0d4bc4b228d85226a85fe68d6ae97b52f5bd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Support implicit variable name and column name.

2016-06-30 Thread Yingyi Bu (Code Review)

Yingyi Bu has posted comments on this change.

Change subject: Support implicit variable name and column name.
..


Patch Set 13:

(11 comments)

https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java:

Line 224: if (mdp.findDataset(mdp.getDefaultDataverseName(), name) != 
null) {
> Why do we check the default dataverse before the fully qualified name?
Done


Line 261: if (argFuncExpr.getExpressionTag() != 
LogicalExpressionTag.FUNCTION_CALL) {
> This check was already done 4 lines above.
Done


https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/VariableCheckAndRewriteVisitor.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/VariableCheckAndRewriteVisitor.java:

Line 67: "Inside limit clauses, it is disallowed to 
reference a variable having the same name as any variable bound in the same 
scope as the limit clause.");
> Reduce line length?
Done


Line 102: FunctionSignature signature = new 
FunctionSignature(MetadataConstants.METADATA_DATAVERSE_NAME, "dataset", 1);
> Here we have a "dataset" function in the metadata dataverse and one in the 
FunctionSignature is only used by the parser, and FunctionIdentifier is used in 
the compiler.  

The translator translates a function signature to function identifier.  During 
the translation, it modifies/changes name spaces if necessary. Because in the 
parsing time, the function is not aware whether a function is a user defined 
function or a builtin function.

Fundamentally, they don't have much difference and should be unified.


https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/ISqlppVisitor.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/ISqlppVisitor.java:

Line 66: R visit(IndependentSubquery independentSubquery, T arg) throws 
AsterixException;
> Generic question: Should all these visitors throw AlgebricksExceptions? If 
Right now, they all throw AlgebricksException -- AsterixException is a subclass 
of AlgebricksException.


https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj:

Line 2322: expr= Expression() (()? name = Identifier())?
> 'expr ='?
Done


Line 2327: if(name==null){
> formatting?
Done


https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java:

Line 1049: addFunction(RESOLVE, AnyTypeComputer.INSTANCE, false);
> What do these functions do?
Done. Removed, no longer needed.


https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/OpenRecordConstructorResultType.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/OpenRecordConstructorResultType.java:

Line 64: Set allPossibleAdditionalFieldNames = new HashSet<>();
> What are these field names?
Done


https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java:

Line 85: Set allPossibleAdditionalFieldNames) {
> Why would a record type know about filed names that are not part of the typ
Done


https://asterix-gerrit.ics.uci.edu/#/c/950/13/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/StructuralPropertiesVector.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/StructuralPropertiesVector.java:

Line 92: }
> How about 
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/950
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Support implicit variable name and column name.

2016-06-30 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Support implicit variable name and column name.
..


Patch Set 15:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1782/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/950
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Support implicit variable name and column name.

2016-06-30 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/950

to look at the new patch set (#15).

Change subject: Support implicit variable name and column name.
..

Support implicit variable name and column name.

1. Support WITH clause for general cases;
2. Fixed open/closed type optimization;
3. Fixed scoping for nested aggregations;
4. Fixed side effects during partition property analysis;
5. Fixed type propagation policy for Subplan operator.

Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/disjunction-to-join-delete-3.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/scan-insert-secondary-index.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/scan-insert.plan
M asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/2.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias2.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias3.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/nestedFLWOGR3.ast
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-2/q2-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-2/q2-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-2/q2-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-3/q2-3.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-3/q2-3.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-3/q2-3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-4/q2-4.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-4/q2-4.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-4/q2-4.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-5/q2-5.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-5/q2-5.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-5/q2-5.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/varlen-encoding/varlen-encoding.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/distinct_by/distinct_by.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/distinct_by/distinct_by.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/distinct_by/distinct_by.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/group_no_agg/group_no_agg.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/group_no_agg/group_no_agg.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/group_no_agg/group_no_agg.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate/nest_aggregate.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate/nest_aggregate.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate/nest_aggregate.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate2/nest_aggregate2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate2/nest_aggregate2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate2/nest_aggregate2.3.query.sqlpp
A

Change in asterixdb[master]: Support implicit variable name and column name.

2016-06-30 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Support implicit variable name and column name.
..


Patch Set 14:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/950
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Support implicit variable name and column name.

2016-06-30 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/950

to look at the new patch set (#14).

Change subject: Support implicit variable name and column name.
..

Support implicit variable name and column name.

1. Support WITH clause for general cases;
2. Fixed open/closed type optimization;
3. Fixed scoping for nested aggregations;
4. Fixed side effects during partition property analysis;
5. Fixed type propagation policy for Subplan operator.

Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/disjunction-to-join-delete-3.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/scan-insert-secondary-index.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/scan-insert.plan
M asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/2.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias2.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias3.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/nestedFLWOGR3.ast
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-2/q2-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-2/q2-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-2/q2-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-3/q2-3.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-3/q2-3.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-3/q2-3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-4/q2-4.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-4/q2-4.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-4/q2-4.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-5/q2-5.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-5/q2-5.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-5/q2-5.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/varlen-encoding/varlen-encoding.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/distinct_by/distinct_by.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/distinct_by/distinct_by.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/distinct_by/distinct_by.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/group_no_agg/group_no_agg.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/group_no_agg/group_no_agg.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/group_no_agg/group_no_agg.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate/nest_aggregate.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate/nest_aggregate.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate/nest_aggregate.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate2/nest_aggregate2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate2/nest_aggregate2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate2/nest_aggregate2.3.query.sqlpp
A

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-06-30 Thread Michael Blow (Code Review)

Michael Blow has posted comments on this change.

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..


Patch Set 13:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/919/13/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java:

Line 116: buf.putInt(FREE_SPACE_OFF, LSN_OFF + 8);
This doesn't account for the storage version, does it?  i.e. shouldn't this be 
STORAGE_VERSION_OFF + 4?


Line 162: if (buf.getInt(VALID_OFF) == OBSOLETE_MAGIC_VALID_INT){
space before { ?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Cleanup Test Dependencies

2016-06-30 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Cleanup Test Dependencies
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/969
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f53ef310b1f6702e1605524f0718340e9178f5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-06-30 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..


Patch Set 13: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Cleanup Test Dependencies

2016-06-30 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Cleanup Test Dependencies
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1780/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/969
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f53ef310b1f6702e1605524f0718340e9178f5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-06-30 Thread Ian Maxon (Code Review)

Hello Michael Blow, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/919

to look at the new patch set (#12).

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..

ASTERIXDB-1479: Change storage valid int and add explicit version

This change will stop old versions from possibly corrupting data written
by newer versions of Hyracks. It also adds an explicit version to the
tree metadata that must match the version at runtime.

Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
---
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java
4 files changed, 91 insertions(+), 50 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/19/919/12
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-06-30 Thread Ian Maxon (Code Review)

Hello Michael Blow, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/919

to look at the new patch set (#13).

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..

ASTERIXDB-1479: Change storage valid int and add explicit version

This change will stop old versions from possibly corrupting data written
by newer versions of Hyracks. It also adds an explicit version to the
tree metadata that must match the version at runtime.

Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
---
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java
4 files changed, 91 insertions(+), 50 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/19/919/13
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

2016-06-30 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1779/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Test NodeController and Test Data Generator

2016-06-30 Thread Till Westmann (Code Review)

Till Westmann has posted comments on this change.

Change subject: Add Test NodeController and Test Data Generator
..


Patch Set 7:

(19 comments)

Mostly structural comments (I assume that the functionality works just fine).

https://asterix-gerrit.ics.uci.edu/#/c/962/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java:

Line 91: logRecord = new LogRecord(index == null ? null
It seems strange to pass an IndexAccessor in here? Can we pass a smaller 
interface in the just provides what is needed here?


https://asterix-gerrit.ics.uci.edu/#/c/962/7/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java:

Line 81: logRecord = new LogRecord(null);
Can we have an additional constructor and keep this file unmodified?


https://asterix-gerrit.ics.uci.edu/#/c/962/7/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java:

Line 124: LogRecord logRecord = new LogRecord(null);
Can we have an additional constructor and keep this file unmodified?


https://asterix-gerrit.ics.uci.edu/#/c/962/7/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java:

Line 175: public long getPreviousMarkerLSN();
These 2 last methods look strangely asymmetric, also it is strange to have the 
LogRecord set something somewhere else.


https://asterix-gerrit.ics.uci.edu/#/c/962/7/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/CreateDataverseStatement.java
File 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/CreateDataverseStatement.java:

Line 39: }
How about

this.format = format == null ? NonTaggedDataFormat.class.getName() : format;

?


https://asterix-gerrit.ics.uci.edu/#/c/962/7/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java
File 
asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java:

Line 212: remoteLog = new LogRecord(null);
Can we have an additional constructor and keep this file unmodified?


https://asterix-gerrit.ics.uci.edu/#/c/962/7/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/AbstractIndexModificationOperationCallback.java
File 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/AbstractIndexModificationOperationCallback.java:

Line 53: logRecord = new LogRecord(null);
Can we have an additional constructor and keep this file unmodified?


https://asterix-gerrit.ics.uci.edu/#/c/962/7/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/LockThenSearchOperationCallback.java
File 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/LockThenSearchOperationCallback.java:

Line 51: this.logRecord = new LogRecord(null);
Can we have an additional constructor and keep this file unmodified?


https://asterix-gerrit.ics.uci.edu/#/c/962/7/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBufferTailReader.java
File 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBufferTailReader.java:

Line 34: logRecord = new LogRecord(null);
Can we have an additional constructor and keep this file unmodified?


https://asterix-gerrit.ics.uci.edu/#/c/962/7/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java
File 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java:

Line 67: this.logRecord = new LogRecord(null);
Can we have an additional constructor and keep this file unmodified?


https://asterix-gerrit.ics.uci.edu/#/c/962/7/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionContext.java
File 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionContext.java:

Line 112: logRecord = new LogRecord(null);
Can we have an additional constructor and keep this file unmodified?

Change in asterixdb[master]: Support implicit variable name and column name.

2016-06-30 Thread Till Westmann (Code Review)

Till Westmann has posted comments on this change.

Change subject: Support implicit variable name and column name.
..


Patch Set 13:

(11 comments)

Mostly questions and very few comments.

https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java:

Line 224: if (mdp.findDataset(mdp.getDefaultDataverseName(), name) != 
null) {
Why do we check the default dataverse before the fully qualified name?


Line 261: if (argFuncExpr.getExpressionTag() != 
LogicalExpressionTag.FUNCTION_CALL) {
This check was already done 4 lines above.


https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/VariableCheckAndRewriteVisitor.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/VariableCheckAndRewriteVisitor.java:

Line 67: "Inside limit clauses, it is disallowed to 
reference a variable having the same name as any variable bound in the same 
scope as the limit clause.");
Reduce line length?


Line 102: FunctionSignature signature = new 
FunctionSignature(MetadataConstants.METADATA_DATAVERSE_NAME, "dataset", 1);
Here we have a "dataset" function in the metadata dataverse and one in the  
"asterix" namespace. What is the relationship between them? (Same seems to be 
true for "resolve" functions).

Also, should we have constants for these FunctionSignatures?

Related: What's the difference between an

org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier

and an

org.apache.asterix.common.functions.FunctionSignature

?


https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/ISqlppVisitor.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/base/ISqlppVisitor.java:

Line 66: R visit(IndependentSubquery independentSubquery, T arg) throws 
AsterixException;
Generic question: Should all these visitors throw AlgebricksExceptions? If so, 
could we file an issue for that?


https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj:

Line 2322: expr= Expression() (()? name = Identifier())?
'expr ='?


Line 2327: if(name==null){
formatting?


https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java:

Line 1049: addFunction(RESOLVE, AnyTypeComputer.INSTANCE, false);
What do these functions do?


https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/OpenRecordConstructorResultType.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/OpenRecordConstructorResultType.java:

Line 64: Set allPossibleAdditionalFieldNames = new HashSet<>();
What are these field names?


https://asterix-gerrit.ics.uci.edu/#/c/950/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java:

Line 85: Set allPossibleAdditionalFieldNames) {
Why would a record type know about filed names that are not part of the type? 
This is confusing ...


https://asterix-gerrit.ics.uci.edu/#/c/950/13/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/StructuralPropertiesVector.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/StructuralPropertiesVector.java:

Line 92: }
How about 

IPartitioningProperty normalizedReqPart =
reqdPart.normalize(equivalenceClasses, 
mayExpandProperties ? fds : null);


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/950
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

[jira] [Commented] (ASTERIXDB-1509) Managix Configure Demands clusters/demo/demo.xml Exist

2016-06-30 Thread Aidan Macdonald (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357816#comment-15357816
 ] 

Aidan Macdonald commented on ASTERIXDB-1509:


If I move the clusters/local directory to something like cluster/not-local 
(equivalent for clusters/demo), then I get,

{code}
$ docker exec master /opt/asterixdb/bin/managix configure
ERROR:
javax.xml.bind.UnmarshalException
 - with linked exception:
[java.io.FileNotFoundException: /opt/asterixdb/clusters/local/local.xml (No 
such file or directory)]
at 
com.sun.xml.internal.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal0(UnmarshallerImpl.java:206)
at 
com.sun.xml.internal.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal(UnmarshallerImpl.java:175)
at 
javax.xml.bind.helpers.AbstractUnmarshallerImpl.unmarshal(AbstractUnmarshallerImpl.java:157)
at 
javax.xml.bind.helpers.AbstractUnmarshallerImpl.unmarshal(AbstractUnmarshallerImpl.java:162)
at 
javax.xml.bind.helpers.AbstractUnmarshallerImpl.unmarshal(AbstractUnmarshallerImpl.java:171)
at 
javax.xml.bind.helpers.AbstractUnmarshallerImpl.unmarshal(AbstractUnmarshallerImpl.java:189)
at 
org.apache.asterix.event.management.EventUtil.getCluster(EventUtil.java:59)
at 
org.apache.asterix.installer.command.ConfigureCommand.configureCluster(ConfigureCommand.java:69)
at 
org.apache.asterix.installer.command.ConfigureCommand.execCommand(ConfigureCommand.java:44)
at 
org.apache.asterix.installer.command.AbstractCommand.execute(AbstractCommand.java:38)
at 
org.apache.asterix.installer.command.CommandHandler.processCommand(CommandHandler.java:86)
at 
org.apache.asterix.installer.driver.InstallerDriver.main(InstallerDriver.java:91)
Caused by: java.io.FileNotFoundException: 
/opt/asterixdb/clusters/local/local.xml (No such file or directory)
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.(FileInputStream.java:146)
at java.io.FileInputStream.(FileInputStream.java:101)
at 
sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90)
at 
sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188)
at 
com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEntity(XMLEntityManager.java:622)
at 
com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDocVersion(XMLVersionDetector.java:189)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:812)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:777)
at 
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
at 
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:642)
at 
com.sun.xml.internal.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal0(UnmarshallerImpl.java:203)
... 11 more
{code}

> Managix Configure Demands clusters/demo/demo.xml Exist
> --
>
> Key: ASTERIXDB-1509
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1509
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Configuration
> Environment: Docker kevincoakley/asterixdb
>Reporter: Aidan Macdonald
>
> $ /opt/asterixdb/bin/managix configure
> will fail if /opt/asterixdb/clusters/{local/local.xml,demo/demo.xml} do not 
> exist. Fails with a Java exception



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Attempt To Fix Checkstyle Plugin In Eclipse

2016-06-30 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Attempt To Fix Checkstyle Plugin In Eclipse
..


Patch Set 2:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/968
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86b7695c754af6780696dc7debc3bb95aacf6c31
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Attempt To Fix Checkstyle Plugin In Eclipse

2016-06-30 Thread Michael Blow (Code Review)

Michael Blow has submitted this change and it was merged.

Change subject: Attempt To Fix Checkstyle Plugin In Eclipse
..


Attempt To Fix Checkstyle Plugin In Eclipse

Relocate Eclipse directives into asterix & hyracks root poms to ignore 
checkstyle plugin.

Change-Id: I86b7695c754af6780696dc7debc3bb95aacf6c31
Reviewed-on: https://asterix-gerrit.ics.uci.edu/968
Reviewed-by: Taewoo Kim 
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
---
M asterixdb/pom.xml
M hyracks-fullstack/pom.xml
M pom.xml
3 files changed, 27 insertions(+), 31 deletions(-)

Approvals:
  Taewoo Kim: Looks good to me, approved
  Jenkins: Verified; No violations found



diff --git a/asterixdb/pom.xml b/asterixdb/pom.xml
index a50b62b..4d372d5 100644
--- a/asterixdb/pom.xml
+++ b/asterixdb/pom.xml
@@ -339,6 +339,19 @@
 
   
 
+
+  
+org.apache.maven.plugins
+maven-checkstyle-plugin
+[2.17,)
+
+  check
+
+  
+  
+
+  
+
   
 
   
diff --git a/hyracks-fullstack/pom.xml b/hyracks-fullstack/pom.xml
index 7fd34b5..8ea61dc 100644
--- a/hyracks-fullstack/pom.xml
+++ b/hyracks-fullstack/pom.xml
@@ -352,6 +352,19 @@
 
   
 
+
+  
+org.apache.maven.plugins
+maven-checkstyle-plugin
+[2.17,)
+
+  check
+
+  
+  
+
+  
+
   
 
   
diff --git a/pom.xml b/pom.xml
index 786ce46..44ecd1b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -44,35 +44,5 @@
 hyracks-fullstack
 asterixdb
   
-  
-  
-  
-  
-  
-  org.eclipse.m2e
-  lifecycle-mapping
-  1.0.0
-  
-  
-  
-  
-  
-  
org.apache.maven.plugins
-  
maven-checkstyle-plugin
-  [2.17,)
-  
-  check
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
+
 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/968
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86b7695c754af6780696dc7debc3bb95aacf6c31
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: abdullah alamoudi

Change in asterixdb[master]: Attempt To Fix Checkstyle Plugin In Eclipse

2016-06-30 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Attempt To Fix Checkstyle Plugin In Eclipse
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/968
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86b7695c754af6780696dc7debc3bb95aacf6c31
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Attempt To Fix Checkstyle Plugin In Eclipse

2016-06-30 Thread Taewoo Kim (Code Review)

Taewoo Kim has posted comments on this change.

Change subject: Attempt To Fix Checkstyle Plugin In Eclipse
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/968
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86b7695c754af6780696dc7debc3bb95aacf6c31
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Attempt To Fix Checkstyle Plugin In Eclipse

2016-06-30 Thread Michael Blow (Code Review)

Hello Taewoo Kim, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/968

to look at the new patch set (#2).

Change subject: Attempt To Fix Checkstyle Plugin In Eclipse
..

Attempt To Fix Checkstyle Plugin In Eclipse

Relocate Eclipse directives into asterix & hyracks root poms to ignore 
checkstyle plugin.

Change-Id: I86b7695c754af6780696dc7debc3bb95aacf6c31
---
M asterixdb/pom.xml
M hyracks-fullstack/pom.xml
M pom.xml
3 files changed, 27 insertions(+), 31 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/68/968/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/968
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I86b7695c754af6780696dc7debc3bb95aacf6c31
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: abdullah alamoudi

Change in asterixdb[master]: Inline variable

2016-06-30 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Inline variable
..


Patch Set 6: Integration-Tests+1

Integration tests succeeded - 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/848
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Hard Tabs++

2016-06-30 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Hard Tabs++
..


Patch Set 3:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/967
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f78fc6705bc79a21cfa97fdfcad30998ab1058
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Hard Tabs++

2016-06-30 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Hard Tabs++
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1777/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/967
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3f78fc6705bc79a21cfa97fdfcad30998ab1058
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Hard Tabs++

2016-06-30 Thread Michael Blow (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/967

to look at the new patch set (#3).

Change subject: Hard Tabs++
..

Hard Tabs++

Eliminate more hard tabs, widen scope of checkstyle rules to prevent 
regressions.
Relax whitespace expectations in polygon ctor

Change-Id: Ia3f78fc6705bc79a21cfa97fdfcad30998ab1058
---
M asterixdb/asterix-algebra/pom.xml
M asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
M asterixdb/asterix-app/scripts/idefix/startcc.sh
M asterixdb/asterix-app/src/main/scripts/run.sh
M asterixdb/asterix-app/src/test/resources/dapd/q2.aql
M asterixdb/asterix-app/src/test/resources/nontagged/custord/local/cust-load.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index/btree-datetime-01.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index/btree-datetime-02.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index/btree-datetime-03.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index/btree-datetime-04.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/distinct_aggregate.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/insert-and-scan-dataset-with-index.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/insert-and-scan-dataset.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/insert-and-scan-joined-datasets.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/issue741.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/leftouterjoin-probe-pidx-with-join-edit-distance-check-idx_01.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/leftouterjoin-probe-pidx-with-join-jaccard-check-idx_01.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/word-jaccard-check-after-btree-access.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/limit-issue353.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-join/leftouterjoin-probe-pidx-with-join-edit-distance-check-idx_01.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-join/leftouterjoin-probe-pidx-with-join-jaccard-check-idx_01.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-join/word-jaccard-check-after-btree-access.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/rtree-index-join/leftouterjoin-probe-pidx-with-join-rtree-sidx_01.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/rtree-index-join/leftouterjoin-probe-pidx-with-join-rtree-sidx_02.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01_1.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01_2.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02_1.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02_2.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-join/leftouterjoin-probe-pidx-with-join-edit-distance-check-idx_01.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-join/word-jaccard-check-after-btree-access.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/rtree-index-join/leftouterjoin-probe-pidx-with-join-rtree-sidx_01.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/rtree-index-join/leftouterjoin-probe-pidx-with-join-rtree-sidx_02.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/open-index-enforced/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01_1.aql
M

Change in asterixdb[master]: Fix the binary documentation

Change in asterixdb[master]: Fix the binary documentation

Change in asterixdb[master]: Support implicit variable name and column name.

Change in asterixdb[master]: Support implicit variable name and column name.

Change in asterixdb[master]: Support implicit variable name and column name.

Change in asterixdb[master]: Support implicit variable name and column name.

Change in asterixdb[master]: Support implicit variable name and column name.

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

Change in asterixdb[master]: Cleanup Test Dependencies

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

Change in asterixdb[master]: Cleanup Test Dependencies

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

Change in asterixdb[master]: Add Test NodeController and Test Data Generator

Change in asterixdb[master]: Support implicit variable name and column name.

[jira] [Commented] (ASTERIXDB-1509) Managix Configure Demands clusters/demo/demo.xml Exist

Change in asterixdb[master]: Attempt To Fix Checkstyle Plugin In Eclipse

Change in asterixdb[master]: Attempt To Fix Checkstyle Plugin In Eclipse

Change in asterixdb[master]: Attempt To Fix Checkstyle Plugin In Eclipse

Change in asterixdb[master]: Attempt To Fix Checkstyle Plugin In Eclipse

Change in asterixdb[master]: Attempt To Fix Checkstyle Plugin In Eclipse

Change in asterixdb[master]: Inline variable

Change in asterixdb[master]: Hard Tabs++

Change in asterixdb[master]: Hard Tabs++

Change in asterixdb[master]: Hard Tabs++

26 matches

Site Navigation

Mail list logo

Footer information