Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1: Contrib-1

Analytics Compatibility Tests Failed Build 2759
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1943/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1943/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4274/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4273/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1893/
 (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2: Contrib+1

Analytics Compatibility Tests Successful Build 2758
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4274/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4273/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4272/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1931/ 
(8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1215/ 
(4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1552/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1892/
 (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6768/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1831/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2114/ (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5272/ (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Murtadha Hubail (Code Review)]

Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2072

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..

[NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecoveryManager

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Perform global recovery on a different thread to prevent
  possible deadlocks in ClusterStateManager.
- Shutdown the system in case of global recovery failure
  since the system will be in inconsistent state.

Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IGlobalRecoveryManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCShutdownHook.java
3 files changed, 31 insertions(+), 30 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/72/2072/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
index 13f3afa..d6854b1 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java
@@ -48,6 +48,8 @@
 import org.apache.hyracks.api.exceptions.HyracksDataException;
 import org.apache.hyracks.api.job.JobId;
 import org.apache.hyracks.api.job.JobSpecification;
+import org.apache.hyracks.control.nc.NCShutdownHook;
+import org.apache.hyracks.util.ExitUtil;
 
 public class GlobalRecoveryManager implements IGlobalRecoveryManager {
 
@@ -56,6 +58,7 @@
 protected final ICCServiceContext serviceCtx;
 protected IHyracksClientConnection hcc;
 protected volatile boolean recoveryCompleted;
+protected volatile boolean recovering;
 
 public GlobalRecoveryManager(ICCServiceContext serviceCtx, 
IHyracksClientConnection hcc,
 IStorageComponentProvider componentProvider) {
@@ -81,41 +84,42 @@
 }
 
 @Override
-public void startGlobalRecovery(ICcApplicationContext appCtx) throws 
HyracksDataException {
-if (!recoveryCompleted) {
-recover(appCtx);
+public void startGlobalRecovery(ICcApplicationContext appCtx) {
+if (!recoveryCompleted && !recovering) {
+synchronized (this) {
+if (!recovering) {
+recovering = true;
+/**
+ * Perform recovery on a different thread to avoid 
deadlocks in
+ * {@link 
org.apache.asterix.common.cluster.IClusterStateManager}
+ */
+serviceCtx.getControllerService().getExecutor().submit(() 
-> {
+try {
+recover(appCtx);
+} catch (HyracksDataException e) {
+LOGGER.log(Level.SEVERE, "Global recovery failed. 
Shutting down...", e);
+
ExitUtil.exit(NCShutdownHook.FAILED_TO_RECOVER_EXIT_CODE);
+}
+});
+}
+}
 }
 }
 
 protected void recover(ICcApplicationContext appCtx) throws 
HyracksDataException {
-LOGGER.info("Starting Global Recovery");
-MetadataTransactionContext mdTxnCtx = null;
 try {
+LOGGER.info("Starting Global Recovery");
 MetadataManager.INSTANCE.init();
-mdTxnCtx = MetadataManager.INSTANCE.beginTransaction();
+MetadataTransactionContext mdTxnCtx = 
MetadataManager.INSTANCE.beginTransaction();
 mdTxnCtx = doRecovery(appCtx, mdTxnCtx);
 MetadataManager.INSTANCE.commitTransaction(mdTxnCtx);
+recoveryCompleted = true;
+recovering = false;
+LOGGER.info("Global Recovery Completed. Refreshing cluster 
state...");
+appCtx.getClusterStateManager().refreshState();
 } catch (Exception e) {
-// This needs to be fixed <-- Needs to shutdown the system -->
-/*
- * Note: Throwing this illegal state exception will terminate this 
thread
- * and feeds listeners will not be notified.
- */
-LOGGER.log(Level.SEVERE, "Global recovery was not completed 
successfully: ", e);
-if (mdTxnCtx != null) {
-try {
-MetadataManager.INSTANCE.abortTransaction(mdTxnCtx);
-} catch (Exception e1) {
-LOGGER.log(Level.SEVERE, "Exception aborting metadata 
transaction", e1);
-

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1223/
 (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1224/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1942/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1942/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2128] Fix bloomfilter bug for primary index search

[Luo Chen (Code Review)]

Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-2128] Fix bloomfilter bug for primary index search
..


Patch Set 1:

> Interesting, and a good catch. I think maybe we need to consider
 > carefully how we integrate the BloomFilters into the indices, since
 > it seems fairly apparent what's in master right now isn't correct
 > at all. Right now it's supposed to be part of the cursor but
 > apparently that doesn't work at all. Pulling it into the LSM
 > wrapped part seems straight forward enough, but I am still a bit
 > uncertain of the consequence of this even after considering it for
 > a while.

I think we need to somehow distinguish the normal index (BTree/RTree) and LSM 
index (LSMBTree/LSMTree etc) in the storage layer. Clearly, bloomfilter is a 
such case, since it belongs to LSM not BTree. Blindly mixing bloomfilter into 
the BTree index already causes the hidden bug...

Another reason for doing this is the performance. Specific optimizations, e.g., 
filters, component Ids etc, can be used to improve LSM index access paths.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2070
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia065f73ae0c783dca70cd6cc9c6f0af8422bfcf2
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34: Contrib+1

Analytics Compatibility Tests Successful Build 2757
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4272/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Murtadha Hubail (Code Review)]

Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 1:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2071/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java:

PS1, Line 61: abortMetadataTxn
> This test is not checking whether the node group was added or not.
Done


PS1, Line 114: / ensure original dataset can be dropped after rebalance failure
> also check the node group associated with the dataset?
We drop the node group by default if all datasets created on it are dropped. I 
added the check that the node group was dropped too.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1214/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1830/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1930/ 
(7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1551/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5271/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6767/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2113/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1222/
 (6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1223/ 
(8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1891/
 (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Murtadha Hubail (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2071

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..

[ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Metadata Txn

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Do not reset the primary index operation tracker active operations
  count if the metadata transaction was aborted.
- Add test cases.

Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionContext.java
4 files changed, 152 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/71/2071/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: [ASTERIXDB-2128] Fix bloomfilter bug for primary index search

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-2128] Fix bloomfilter bug for primary index search
..


Patch Set 1:

Interesting, and a good catch. I think maybe we need to consider carefully how 
we integrate the BloomFilters into the indices, since it seems fairly apparent 
what's in master right now isn't correct at all. Right now it's supposed to be 
part of the cursor but apparently that doesn't work at all. Pulling it into the 
LSM wrapped part seems straight forward enough, but I am still a bit uncertain 
of the consequence of this even after considering it for a while.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2070
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia065f73ae0c783dca70cd6cc9c6f0af8422bfcf2
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1941/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1941/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2112/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4271/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4270/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1940/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1940/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4271/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2111/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1929/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1890/
 (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 22:

(9 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java:

Line 64: fmtString =
> MAJOR SonarQube violation:
+1


Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> MAJOR SonarQube violation:
+1


Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> MAJOR SonarQube violation:
+1


https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 115: private static final String lplan = "Logical plan";
> MAJOR SonarQube violation:
+1


Line 116: private static final String oplan = "Optimized logical plan";
> MAJOR SonarQube violation:
+1


https://asterix-gerrit.ics.uci.edu/#/c/1885/22/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java:

PS22, Line 26: import org.apache.commons.lang3.mutable.Mutable;
Can you revert this file? It's not part of the change, really.


https://asterix-gerrit.ics.uci.edu/#/c/1885/22/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java:

Line 24: import org.apache.commons.lang3.mutable.Mutable;
Same here.


https://asterix-gerrit.ics.uci.edu/#/c/1885/22/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java:

Line 118: stringPrefix = (stringPrefix.isEmpty()) ? 
val.toString() : stringPrefix + "." + val.toString();
> MAJOR SonarQube violation:
+1


Line 121: String opId = (stringPrefix.isEmpty()) ? "" + (++id) 
: stringPrefix + "." + (++id);
> MAJOR SonarQube violation:
+1


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 22
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1550/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5270/ (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Ildar Absalyamov (Code Review)]

Hello Luo Chen, Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2014

to look at the new patch set (#34).

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..

[NO ISSUE][STO][IDX] LSM storage cleanup

- user model changes: no
- storage format changes: no
- interface changes: yes

- Replaced component lifecycle-related fabric methods in AbstractLSMIndex
  with direct method calls of lsmComponent functions.
- Extracted common lifecycle-related functionality from index-specific
  disk/memory lsmComponents to interfaces.
- Introduced composable disk component bulkloader design which assembles the
  proper bulkload pipeline from individual elements populating lsmFilters,
  bloomFilters, buddyBTrees\deletedKeysBTrees, bTress\rTrees\invIndexes.
- Changed methods to return index-specific versions of objects (accessors,
  components, index instances) to avoid nasty downcasting.

Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
---
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallback.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallback.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallback.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallback.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexBulkLoadNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTree.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponent.java
D 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentBulkLoader.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeMemoryComponent.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeOpContext.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
A 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBloomFilterDiskComponent.java
A 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBloomFilterDiskComponentFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyAbstractCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponent.java
D 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponentBulkLoader.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponentFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyMemoryComponent.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBuddyBTreeMergeCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java
A 

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6766/ (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1222/ 
(4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1213/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 34:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1829/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

Looks good to me. some files were removed by mistake. When this builds 
successfully, I will +2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 1:

(2 comments)

This is a good start.

https://asterix-gerrit.ics.uci.edu/#/c/2071/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java:

PS1, Line 61: abortMetadataTxn
This test is not checking whether the node group was added or not.


PS1, Line 114: / ensure original dataset can be dropped after rebalance failure
also check the node group associated with the dataset?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4270/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1212/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Ian Maxon (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1857

to look at the new patch set (#16).

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..

[ASTERIXDB-1952][TX][IDX]Filter logs pt.2

- user model changes: no
- storage format changes: yes
- interface changes: no

Details:

- Add a log type specifically for filters. This doesn't propagate the change
  to the rest of the filter logging code at the moment, it is simlply used
  in the case of Upsert where right now the filter log info is inadequate.
- Parts 3 and 4 of this change should propagate this method of filter logging
  to the rest of the index code in lieu of using UPDATE, and then use it to
  avoid logging updates to the filter that don't cause it to widen

Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogType.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/AbstractIndexModificationOperationCallback.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexModificationOperationCallback.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/NoOpOperationCallback.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/ophelpers/IndexOperation.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMHarness.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIndexAccessor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMTreeIndexAccessor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexAccessor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IModificationOperationCallback.java
M 
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/AbstractModificationOperationCallbackTest.java
M 
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/TestOperationCallback.java
M 
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-btree-test/src/test/java/org/apache/hyracks/storage/am/lsm/btree/LSMBTreeUpdateInPlaceTest.java
18 files changed, 232 insertions(+), 70 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/57/1857/16
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5269/ (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1889/
 (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1221/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1828/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2110/ (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1220/
 (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1549/ 
(8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6765/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1928/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 22: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4268/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 22
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4269/ 
: FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4269/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Ildar Absalyamov (Code Review)]

Ildar Absalyamov has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 29:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2014/29/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponent.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponent.java:

PS29, Line 124: 
  : IChainedComponentBulkLoader createFilterBulkLoader() throws 
HyracksDataException;
  : 
  : IChainedComponentBulkLoader createIndexBulkLoader(float 
fillFactor, boolean verifyInput, long numElementsHint,
  : boolean checkIfEmptyIndex) throws 
HyracksDataException;
  : 
  : ChainedLSMDiskComponentBulkLoader createBulkLoader
> we still need clear javadocs for those calls
Done.
Added comments to other interface methods. Let me know if I missed something


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 29
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1219/
 (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1827/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1888/
 (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1548/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2109/ (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Ildar Absalyamov (Code Review)]

Hello Luo Chen, Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2014

to look at the new patch set (#33).

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..

[NO ISSUE][STO][IDX] LSM storage cleanup

- user model changes: no
- storage format changes: no
- interface changes: yes

- Replaced component lifecycle-related fabric methods in AbstractLSMIndex
  with direct method calls of lsmComponent functions.
- Extracted common lifecycle-related functionality from index-specific
  disk/memory lsmComponents to interfaces.
- Introduced composable disk component bulkloader design which assembles the
  proper bulkload pipeline from individual elements populating lsmFilters,
  bloomFilters, buddyBTrees\deletedKeysBTrees, bTress\rTrees\invIndexes.
- Changed methods to return index-specific versions of objects (accessors,
  components, index instances) to avoid nasty downcasting.

Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
---
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallback.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallback.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallback.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallback.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexBulkLoadNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTree.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponent.java
D 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentBulkLoader.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeMemoryComponent.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeOpContext.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
A 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBloomFilterDiskComponent.java
A 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBloomFilterDiskComponentFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyAbstractCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponent.java
D 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponentBulkLoader.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponentFactory.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyMemoryComponent.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBuddyBTreeMergeCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java
M 

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1220/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6764/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5268/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1211/ 
(1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1927/ 
(7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 22: Contrib+1

Analytics Compatibility Tests Successful Build 2755
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 22
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful Build 2754
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 22: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1939/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 22
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 22: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4268/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 22
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 22:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1939/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 22
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1938/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][STO][IDX] LSM storage cleanup

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
..


Patch Set 32:

Ildar, see my last comment
We should add javadocs to the new/changed interfaces. This will make clear what 
those interface/calls means and may reveal some design issues...

Please, do that before we merge? I can point out those places if desired...

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 32
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1938/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No