Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/yjsm3WBaxaM8Lo34A : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 05:40:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8608/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 05:45:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1007/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8606/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:49:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 1: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/hNng9H4EGoBLum336 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:33:45 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11321/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:56 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1197/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:41:16 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/E1dRQVyVnpnSdjgS6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:40:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5746/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3841/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8608/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:34:07 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5745/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:44 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9787/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3412 to look at the new patch set (#2). Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. [ASTERIXDB-2577] One frame per spilled partitions - user model changes: no - storage format changes: no - interface changes: no Details: During the probe phase there should be one frame per each spilled partition otherwise the whole memory may be used to store in memory partitions. In this case, every record that is matching with a spilled partition from build phase will be flushed directly to the disk. This change will fix this issue by making sure that when we spill a partition or read a partition back during making space for hash table, we consider that 1 frame for the corresponding partition. Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c --- M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/12/3412/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/770/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:51 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6202/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5829/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:53 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5810/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:57 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6412/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9788/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:43 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1196/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:31 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1008/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1106/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:46 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5997/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:41 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5847/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/611/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:49 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577] One frame per spilled partitions .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6052/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 2 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:32:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Contrib-2 BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4454/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:31:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4454/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:30:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8607/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:29:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Shiva Jahangiri has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3412 Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. [ASTERIXDB-2577]One frame per spilled partitions - user model changes: no - storage format changes: no - interface changes: no Details: During the probe phase there should be one frame per each spilled partition otherwise the whole memory may be used to store in memory partitions. In this case, every record that is matching with a spilled partition from build phase will be flushed directly to the disk. This change will fix this issue by making sure that when we spill a partition or read a partition back during making space for hash table, we consider that 1 frame for the corresponding partition. Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c --- M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/12/3412/1 diff --git a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java index c78e0dc..ff61368 100644 --- a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java +++ b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java @@ -310,7 +310,8 @@ long hashTableSizeDecrease = -SerializableHashTable.calculateByteSizeDeltaForTableSizeChange(inMemTupCount, -buildPSizeInTups[pidToSpill], frameSize); -freeSpace = freeSpace + bufferManager.getPhysicalSize(pidToSpill) + hashTableSizeDecrease; +// -1 because we need to keep one frame for each spilled partition. +freeSpace = freeSpace + bufferManager.getPhysicalSize(pidToSpill) + hashTableSizeDecrease - 1; inMemTupCount -= buildPSizeInTups[pidToSpill]; spillPartition(pidToSpill); closeBuildPartition(pidToSpill); @@ -334,7 +335,8 @@ long expectedHashTableSizeDecrease = -SerializableHashTable.calculateByteSizeDeltaForTableSizeChange(inMemTupCount, -numberOfTuplesToBeSpilled, frameSize); -freeSpace = freeSpace + spaceToBeReturned + expectedHashTableSizeDecrease; +// -1 because we need to keep one frame for each spilled partition. +freeSpace = freeSpace + spaceToBeReturned + expectedHashTableSizeDecrease - 1; // Adjusts the hash table size inMemTupCount -= numberOfTuplesToBeSpilled; if (freeSpace >= 0) { @@ -358,10 +360,15 @@ } long expectedHashTableByteSizeIncrease = SerializableHashTable .calculateByteSizeDeltaForTableSizeChange(inMemTupCount, buildPSizeInTups[pid], frameSize); -freeSpace = freeSpace - bufferManager.getPhysicalSize(pid) - expectedHashTableByteSizeIncrease; +// +1 because we need to keep one frame for each spilled partition, but when that partition is read back in +// we can release its one frame. +freeSpace = freeSpace - bufferManager.getPhysicalSize(pid) - expectedHashTableByteSizeIncrease + 1; inMemTupCount += buildPSizeInTups[pid]; // Adjusts the hash table size hashTableByteSizeForInMemTuples += expectedHashTableByteSizeIncrease; +} +if (memSizeInFrames * ctx.getInitialFrameSize() - freeSpace < spilledStatus.cardinality()) { +throw new HyracksDataException("After build finishes, there should be at least one frame for each spilled partition."); } return inMemTupCount; @@ -383,8 +390,10 @@ continue; } // We put minus since the method returns a negative value to represent a newly reclaimed space. +// -1 because we need to keep one frame for each spilled partition. spaceAfterSpill = currentFreeSpace + bufferManager.getPhysicalSize(p) + (-SerializableHashTable - .calculateByteSizeDeltaForTableSizeChange(currentInMemTupCount, -buildPSizeInTups[p], frameSize)); + .calculateByteSizeDeltaForTableSizeChange(currentInMemTupCount, -buildPSizeInTups[p], frameSize)) +- 1; if (spaceAfterSpill == 0) { // Found the perfect one. Just returns this partition.
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5809/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3840/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:33 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5846/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/610/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5996/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:30 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1105/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5828/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:41 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/769/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11320/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6051/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6411/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:25 + Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6201/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3412 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c Gerrit-Change-Number: 3412 Gerrit-PatchSet: 1 Gerrit-Owner: Shiva Jahangiri Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 04:27:31 + Gerrit-HasComments: No
[jira] [Updated] (ASTERIXDB-2577) Not keeping one frame for each spilled partition before starting the probe phase in hybrid hash join
[ https://issues.apache.org/jira/browse/ASTERIXDB-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shiva Jahangiri updated ASTERIXDB-2577: --- Summary: Not keeping one frame for each spilled partition before starting the probe phase in hybrid hash join (was: Not keeping one frame for each spilled partition during probe phase) > Not keeping one frame for each spilled partition before starting the probe > phase in hybrid hash join > > > Key: ASTERIXDB-2577 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2577 > Project: Apache AsterixDB > Issue Type: Bug > Components: *DB - AsterixDB >Affects Versions: 0.9.4.1 >Reporter: Shiva Jahangiri >Priority: Major > > In probe() method in optimized hybrid hash join, if insertion fails on the > current spilled partition, we try to find the biggest spilled partition and > flush it as a victim. If we could not find any spilled partition with size > > 0, then we ASSUME that the record is large and flush it as a big object. By > running customerOrderCIDHybridHashJoin_Case3() test in > TPCHCustomerOrderHashJoinTest, it can be seen that the record size is 206 > bytes (so it is smaller than a frame), but neither the spilled partitions nor > the buffer manager has any frame (This is the problem, there should be 1 > frame for each spilled partition). In this case, we flush the record as a > large object. This means that every single record that is supposed to get > inserted to a spilled partition during the probe, will get flushed > separately. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ASTERIXDB-2577) Not keeping one frame for each spilled partition during probe phase
[ https://issues.apache.org/jira/browse/ASTERIXDB-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shiva Jahangiri updated ASTERIXDB-2577: --- Summary: Not keeping one frame for each spilled partition during probe phase (was: Flushing small records during the probe in optimized hhj as large objects) > Not keeping one frame for each spilled partition during probe phase > --- > > Key: ASTERIXDB-2577 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2577 > Project: Apache AsterixDB > Issue Type: Bug > Components: *DB - AsterixDB >Affects Versions: 0.9.4.1 >Reporter: Shiva Jahangiri >Priority: Major > > In probe() method in optimized hybrid hash join, if insertion fails on the > current spilled partition, we try to find the biggest spilled partition and > flush it as a victim. If we could not find any spilled partition with size > > 0, then we ASSUME that the record is large and flush it as a big object. By > running customerOrderCIDHybridHashJoin_Case3() test in > TPCHCustomerOrderHashJoinTest, it can be seen that the record size is 206 > bytes (so it is smaller than a frame), but neither the spilled partitions nor > the buffer manager has any frame (This is the problem, there should be 1 > frame for each spilled partition). In this case, we flush the record as a > large object. This means that every single record that is supposed to get > inserted to a spilled partition during the probe, will get flushed > separately. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4453/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:55:45 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/E7Ur1Ckz55vUzL1dA : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:43:34 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4453/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:39:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3839/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:39 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/609/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:48 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1195/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:36:02 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6200/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:41 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8606/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:37:37 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Hello Anon. E. Moose (1000171), Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3410 to look at the new patch set (#3). Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. [NO ISSUE][OTH] Introduce ResponsePrinter - user model changes: no - storage format changes: no - interface changes: yes Details: - Introduce ResponsePrinter that is responsible for printing the returned response from query service. - Make ResponsePrinter responsible for adding separators between fields in the returned response. - Introduce IResponseFieldPrinter and encapsulate each response field in its own printer. - Introduce ICodedMessage and use it for any object that has code<->message (e.g errors and warnings). Change-Id: I797e6615a72c886391fed26281fc648b38fa748f --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionOutput.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ResultUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionError.java R asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionWarning.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponseMertics.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponsePrinter.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultHandle.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/AbstractCodedMessagePrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ClientContextIdPrinter.java C asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ErrorsPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ExplainOnlyResultsPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/NcResultPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ParseOnlyResultPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/PlansPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/RequestIdPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ResultHandlePrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ResultsPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/SignaturePrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/StatusPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/TypePrinter.java C asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/WarningsPrinter.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/DefaultStatementExecutorFactory.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/app/result/ResultPrinterTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/active/ActiveStatsTest.java C asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ICodedMessage.java C asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IResponseFieldPrinter.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IResponsePrinter.java 41 files changed, 1,356 insertions(+), 420 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/10/3410/3 -- To view,
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9786/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:57 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6410/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:55 + Gerrit-HasComments: No
[jira] [Updated] (ASTERIXDB-2577) Flushing small records during the probe in optimized hhj as large objects
[ https://issues.apache.org/jira/browse/ASTERIXDB-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shiva Jahangiri updated ASTERIXDB-2577: --- Description: In probe() method in optimized hybrid hash join, if insertion fails on the current spilled partition, we try to find the biggest spilled partition and flush it as a victim. If we could not find any spilled partition with size > 0, then we ASSUME that the record is large and flush it as a big object. By running customerOrderCIDHybridHashJoin_Case3() test in TPCHCustomerOrderHashJoinTest, it can be seen that the record size is 206 bytes (so it is smaller than a frame), but neither the spilled partitions nor the buffer manager has any frame (This is the problem, there should be 1 frame for each spilled partition). In this case, we flush the record as a large object. This means that every single record that is supposed to get inserted to a spilled partition during the probe, will get flushed separately. was: In probe() method in optimized hybrid hash join, if insertion fails on the current spilled partition, we try to find the biggest spilled partition and flush it as a victim. If we could not find any spilled partition with size > 0, then we ASSUME that the record is large and flush it as a big object. By running customerOrderCIDHybridHashJoin_Case3() test in TPCHCustomerOrderHashJoinTest, it can be seen that the record size is 206 bytes (so it is smaller than a frame), but neither the spilled partitions nor the buffer manager has any frame (This is the problem, there should be 1 frame for each spilled partition). In this case, we flush the record(without checking if it is large or not) as a large object. This means that every single record that is supposed to get inserted to a spilled partition during the probe, will get flushed separately. > Flushing small records during the probe in optimized hhj as large objects > -- > > Key: ASTERIXDB-2577 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2577 > Project: Apache AsterixDB > Issue Type: Bug > Components: *DB - AsterixDB >Affects Versions: 0.9.4.1 >Reporter: Shiva Jahangiri >Priority: Major > > In probe() method in optimized hybrid hash join, if insertion fails on the > current spilled partition, we try to find the biggest spilled partition and > flush it as a victim. If we could not find any spilled partition with size > > 0, then we ASSUME that the record is large and flush it as a big object. By > running customerOrderCIDHybridHashJoin_Case3() test in > TPCHCustomerOrderHashJoinTest, it can be seen that the record size is 206 > bytes (so it is smaller than a frame), but neither the spilled partitions nor > the buffer manager has any frame (This is the problem, there should be 1 > frame for each spilled partition). In this case, we flush the record as a > large object. This means that every single record that is supposed to get > inserted to a spilled partition during the probe, will get flushed > separately. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5845/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:50 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1104/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:54 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6050/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:52 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5827/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:44 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/768/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:47 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5995/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:42 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11319/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:45 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1006/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:40 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5744/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:38 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5808/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:35:39 + Gerrit-HasComments: No
Change in asterixdb-bad[master]: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3411 to look at the new patch set (#4). Change subject: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter .. [NO ISSUE][BAD] Coordinated Change for ResponsePrinter - user model changes: no - storage format changes: no - interface changes: no Details: - Coordinated change for ResponsePrinter. Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java M asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java 4 files changed, 20 insertions(+), 12 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/11/3411/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/3411 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 Gerrit-Change-Number: 3411 Gerrit-PatchSet: 4 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins
Change in asterixdb-bad[master]: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3411 ) Change subject: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/391/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3411 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 Gerrit-Change-Number: 3411 Gerrit-PatchSet: 4 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:19:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Contrib-2 BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4452/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:09:13 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1005/ (8/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:14 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/767/ (11/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:19 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3838/ (2/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:08 + Gerrit-HasComments: No
Change in asterixdb-bad[master]: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3411 ) Change subject: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/390/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3411 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 Gerrit-Change-Number: 3411 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:32 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/HQD68R4mS2s6xFnc8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 03:00:28 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8605/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:59:41 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4452/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:59:36 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/608/ (13/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:24 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5844/ (14/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:26 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Hello Anon. E. Moose (1000171), Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3410 to look at the new patch set (#2). Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. [NO ISSUE][OTH] Introduce ResponsePrinter - user model changes: no - storage format changes: no - interface changes: yes Details: - Introduce ResponsePrinter that is responsible for printing the returned response from query service. - Make ResponsePrinter responsible for adding separators between fields in the returned response. - Introduce IResponseFieldPrinter and encapsulate each response field in its own printer. - Introduce ICodedMessage and use it for any object that has code<->message (e.g errors and warnings). Change-Id: I797e6615a72c886391fed26281fc648b38fa748f --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionOutput.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ResultUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionError.java R asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionWarning.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponseMertics.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponsePrinter.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultHandle.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/AbstractCodedMessagePrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ClientContextIdPrinter.java C asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ErrorsPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ExplainOnlyResultsPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/NcResultPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ParseOnlyResultPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/PlansPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/RequestIdPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ResultHandlePrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ResultsPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/SignaturePrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/StatusPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/TypePrinter.java C asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/WarningsPrinter.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/DefaultStatementExecutorFactory.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/app/result/ResultPrinterTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/active/ActiveStatsTest.java C asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ICodedMessage.java C asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IResponseFieldPrinter.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IResponsePrinter.java 41 files changed, 1,354 insertions(+), 421 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/10/3410/2 -- To view,
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5826/ (12/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:21 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5807/ (16/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:29 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11318/ (15/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:27 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6049/ (3/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:08 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9785/ (5/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:10 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1194/ (6/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:11 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6199/ (9/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:16 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1103/ (4/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:09 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5994/ (10/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:18 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6409/ (7/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:12 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5743/ (1/16) -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:56:08 + Gerrit-HasComments: No
Change in asterixdb-bad[master]: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3411 ) Change subject: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/389/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3411 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 Gerrit-Change-Number: 3411 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:29:28 + Gerrit-HasComments: No
Change in asterixdb-bad[master]: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3411 to look at the new patch set (#3). Change subject: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter .. [NO ISSUE][BAD] Coordinated Change for ResponsePrinter - user model changes: no - storage format changes: no - interface changes: no Details: - Coordinated change for ResponsePrinter. Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 --- M asterix-bad/src/main/java/org/apache/asterix/bad/BADJobService.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java M asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java 4 files changed, 20 insertions(+), 12 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/11/3411/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/3411 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 Gerrit-Change-Number: 3411 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/3EgJ6urkvkvaNVWR6 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 02:20:45 + Gerrit-HasComments: No
Change in asterixdb-bad[master]: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3411 ) Change subject: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/387/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3411 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 Gerrit-Change-Number: 3411 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 01:02:58 + Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8604/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 01:50:19 + Gerrit-HasComments: No
Change in asterixdb-bad[master]: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3411 to look at the new patch set (#2). Change subject: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter .. [NO ISSUE][BAD] Coordinated Change for ResponsePrinter - user model changes: no - storage format changes: no - interface changes: no Details: - Coordinated change for ResponsePrinter. Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 --- M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java M asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java 3 files changed, 14 insertions(+), 8 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/11/3411/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3411 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 Gerrit-Change-Number: 3411 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins
Change in asterixdb-bad[master]: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3411 ) Change subject: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/388/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3411 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 Gerrit-Change-Number: 3411 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 01:05:13 + Gerrit-HasComments: No
Change in asterixdb-bad[master]: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter
Murtadha Hubail has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3411 Change subject: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter .. [NO ISSUE][BAD] Coordinated Change for ResponsePrinter - user model changes: no - storage format changes: no - interface changes: no Details: - Coordinated change for ResponsePrinter. Change-Id: I9255ef88ea03df629ffe3ca2f1d9b08504459f06 --- M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java M asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java M asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java 3 files changed, 13 insertions(+), 7 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/11/3411/1 diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java index 8f5d520..ab5a96e 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java @@ -22,6 +22,7 @@ import org.apache.asterix.app.translator.DefaultStatementExecutorFactory; import org.apache.asterix.app.translator.QueryTranslator; +import org.apache.asterix.common.api.IResponsePrinter; import org.apache.asterix.common.context.IStorageComponentProvider; import org.apache.asterix.common.dataflow.ICcApplicationContext; import org.apache.asterix.compiler.provider.ILangCompilationProvider; @@ -32,7 +33,8 @@ @Override public QueryTranslator create(ICcApplicationContext appCtx, List statements, SessionOutput output, -ILangCompilationProvider compilationProvider, IStorageComponentProvider storageComponentProvider) { -return new BADStatementExecutor(appCtx, statements, output, compilationProvider, executorService); +ILangCompilationProvider compilationProvider, IStorageComponentProvider storageComponentProvider, +IResponsePrinter printer) { +return new BADStatementExecutor(appCtx, statements, output, compilationProvider, executorService, printer); } } diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java index 9cb57e1..e57a2e5 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java @@ -32,6 +32,7 @@ import org.apache.asterix.bad.metadata.Channel; import org.apache.asterix.bad.metadata.DeployedJobSpecEventListener; import org.apache.asterix.bad.metadata.Procedure; +import org.apache.asterix.common.api.IResponsePrinter; import org.apache.asterix.common.dataflow.ICcApplicationContext; import org.apache.asterix.common.exceptions.CompilationException; import org.apache.asterix.common.functions.FunctionSignature; @@ -57,8 +58,8 @@ public class BADStatementExecutor extends QueryTranslator { public BADStatementExecutor(ICcApplicationContext appCtx, List statements, SessionOutput output, -ILangCompilationProvider compliationProvider, ExecutorService executorService) { -super(appCtx, statements, output, compliationProvider, executorService); +ILangCompilationProvider compliationProvider, ExecutorService executorService, IResponsePrinter printer) { +super(appCtx, statements, output, compliationProvider, executorService, printer); } //TODO: Most of this file could go away if we had metadata dependencies diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java b/asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java index 38dc16d..0cc59e5 100644 --- a/asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java +++ b/asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java @@ -30,6 +30,7 @@ import org.apache.asterix.active.EntityId; import org.apache.asterix.active.IActiveEntityEventsListener; import org.apache.asterix.app.active.ActiveNotificationHandler; +import org.apache.asterix.app.result.ResponsePrinter; import org.apache.asterix.app.result.ResultReader; import org.apache.asterix.app.translator.DefaultStatementExecutorFactory; import org.apache.asterix.app.translator.RequestParameters; @@ -94,10 +95,12 @@ throws Exception { SessionConfig sessionConfig = new SessionConfig(SessionConfig.OutputFormat.ADM, true, true, true, SessionConfig.PlanFormat.STRING); - +final SessionOutput sessionOutput = new SessionOutput(sessionConfig, null);
Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 1: Contrib-2 BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4451/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins Gerrit-Comment-Date: Mon, 27 May 2019 00:47:42 + Gerrit-HasComments: No