Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
Attention is currently required from: Vijay Sarathy. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 ) Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/XDsPbgXHp9taQLxd7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 2 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Vijay Sarathy Gerrit-Comment-Date: Tue, 27 Feb 2024 03:57:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[neo]: [NO ISSUE][HYR][MISC] += ReflectionUtils.getAccessibleMethod
>From Michael Blow : Attention is currently required from: Hussain Towaileb. Michael Blow has removed a vote from this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18180 ) Change subject: [NO ISSUE][HYR][MISC] += ReflectionUtils.getAccessibleMethod .. Removed Integration-Tests-1 by Jenkins -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18180 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I8d58abaacc81a65f35dbc6f7dc8d1b3daaa3ad01 Gerrit-Change-Number: 18180 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Attention: Hussain Towaileb Gerrit-MessageType: deleteVote
Change in asterixdb[neo]: [NO ISSUE][HYR][MISC] += ReflectionUtils.getAccessibleMethod
>From Michael Blow : Attention is currently required from: Hussain Towaileb. Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18180 ) Change subject: [NO ISSUE][HYR][MISC] += ReflectionUtils.getAccessibleMethod .. Patch Set 1: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18180 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I8d58abaacc81a65f35dbc6f7dc8d1b3daaa3ad01 Gerrit-Change-Number: 18180 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Attention: Hussain Towaileb Gerrit-Comment-Date: Tue, 27 Feb 2024 02:52:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[neo]: [NO ISSUE][HYR][STO] BufferCache lock fixes
Attention is currently required from: Michael Blow. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18181 ) Change subject: [NO ISSUE][HYR][STO] BufferCache lock fixes .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/YzA15CQwggdJnYGA6 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18181 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I37f06163bbf1c34392d83a8ccd27e777552eeac7 Gerrit-Change-Number: 18181 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Michael Blow Gerrit-Comment-Date: Tue, 27 Feb 2024 02:36:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
>From Jenkins : Attention is currently required from: Vijay Sarathy. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 ) Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/165/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 2 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Vijay Sarathy Gerrit-Comment-Date: Tue, 27 Feb 2024 02:34:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
Attention is currently required from: Vijay Sarathy. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 ) Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. Patch Set 2: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/Yr2X7XzimE6H7YPT9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 2 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Vijay Sarathy Gerrit-Comment-Date: Tue, 27 Feb 2024 01:29:21 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
>From Vijay Sarathy : Attention is currently required from: Vijay Sarathy. Hello Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 to look at the new patch set (#2). Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java 3 files changed, 87 insertions(+), 3 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/77/18177/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 2 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Vijay Sarathy Gerrit-MessageType: newpatchset
Change in asterixdb[neo]: [NO ISSUE][HYR][STO] BufferCache lock fixes
>From Jenkins : Attention is currently required from: Michael Blow. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18181 ) Change subject: [NO ISSUE][HYR][STO] BufferCache lock fixes .. Patch Set 2: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/164/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18181 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I37f06163bbf1c34392d83a8ccd27e777552eeac7 Gerrit-Change-Number: 18181 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-CC: Anon. E. Moose #1000171 Gerrit-Attention: Michael Blow Gerrit-Comment-Date: Tue, 27 Feb 2024 01:02:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[neo]: [NO ISSUE][HYR][STO] BufferCache lock fixes
Attention is currently required from: Michael Blow. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18181 ) Change subject: [NO ISSUE][HYR][STO] BufferCache lock fixes .. Patch Set 2: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/xHvmCMyjePryLURg7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18181 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I37f06163bbf1c34392d83a8ccd27e777552eeac7 Gerrit-Change-Number: 18181 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-CC: Anon. E. Moose #1000171 Gerrit-Attention: Michael Blow Gerrit-Comment-Date: Tue, 27 Feb 2024 00:34:09 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[neo]: [NO ISSUE][HYR][STO] BufferCache lock fixes
>From Michael Blow : Michael Blow has uploaded a new patch set (#2). ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18181 ) Change subject: [NO ISSUE][HYR][STO] BufferCache lock fixes .. [NO ISSUE][HYR][STO] BufferCache lock fixes Change-Id: I37f06163bbf1c34392d83a8ccd27e777552eeac7 --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/freepage/VirtualFreePageManager.java M hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeCountingSearchCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeRangeSearchCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java M hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/DiskBTree.java 5 files changed, 56 insertions(+), 54 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/81/18181/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18181 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I37f06163bbf1c34392d83a8ccd27e777552eeac7 Gerrit-Change-Number: 18181 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Blow Gerrit-CC: Jenkins Gerrit-MessageType: newpatchset
Change in asterixdb[neo]: [NO ISSUE][HYR][STO] BufferCache lock fixes
>From Michael Blow :
Michael Blow has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18181 )
Change subject: [NO ISSUE][HYR][STO] BufferCache lock fixes
..
[NO ISSUE][HYR][STO] BufferCache lock fixes
Change-Id: I37f06163bbf1c34392d83a8ccd27e777552eeac7
---
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/freepage/VirtualFreePageManager.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeCountingSearchCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeRangeSearchCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/DiskBTree.java
5 files changed, 70 insertions(+), 67 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/81/18181/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
index 78faaff..d33fd38 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
@@ -105,7 +105,7 @@
RangePredicate diskOrderScanPred = new RangePredicate(null, null,
true, true, ctx.getCmp(), ctx.getCmp());
int maxPageId = freePageManager.getMaxPageId(ctx.getMetaFrame());
int currentPageId = bulkloadLeafStart;
-ICachedPage page =
bufferCache.pin(BufferedFileHandle.getDiskPageId(getFileId(), currentPageId),
false);
+final ICachedPage page =
bufferCache.pin(BufferedFileHandle.getDiskPageId(getFileId(), currentPageId),
false);
page.acquireReadLatch();
try {
cursor.setBufferCache(bufferCache);
@@ -116,7 +116,7 @@
ctx.getCursorInitialState().setSearchOperationCallback(ctx.getSearchCallback());
ctx.getCursorInitialState().setOriginialKeyComparator(ctx.getCmp());
cursor.open(ctx.getCursorInitialState(), diskOrderScanPred);
-} catch (Exception e) {
+} catch (Throwable e) {
page.releaseReadLatch();
bufferCache.unpin(page);
throw HyracksDataException.create(e);
@@ -202,8 +202,7 @@
}
// we use this loop to deal with possibly multiple operation restarts
// due to ongoing structure modifications during the descent
-boolean repeatOp = true;
-while (repeatOp && ctx.getOpRestarts() < MAX_RESTARTS) {
+while (true) {
performOp(rootPage, null, true, ctx);
// if we reach this stage then we need to restart from the
(possibly
// new) root
@@ -211,7 +210,7 @@
ctx.getPageLsns().removeLast(); // pop the restart op indicator
continue;
}
-repeatOp = false;
+break;
}
cursor.setBufferCache(bufferCache);
cursor.setFileId(getFileId());
@@ -221,8 +220,8 @@
ICachedPage originalPage = ctx.getInteriorFrame().getPage();
for (int i = 0; i < ctx.getSmPages().size(); i++) {
int pageId = ctx.getSmPages().get(i);
-ICachedPage smPage =
bufferCache.pin(BufferedFileHandle.getDiskPageId(getFileId(), pageId), false);
-smPage.acquireWriteLatch();
+final ICachedPage smPage =
bufferCache.pin(BufferedFileHandle.getDiskPageId(getFileId(), pageId), false);
+smPage.acquireWriteLatch(); // MDB: safe
try {
ctx.getInteriorFrame().setPage(smPage);
ctx.getInteriorFrame().setSmFlag(false);
@@ -231,12 +230,8 @@
bufferCache.unpin(smPage);
}
}
-if (ctx.getSmPages().size() > 0) {
-if (ctx.getSmoCount() == Integer.MAX_VALUE) {
-smoCounter.set(0);
-} else {
-smoCounter.incrementAndGet();
-}
+if (!ctx.getSmPages().isEmpty()) {
+smoCounter.updateAndGet(i -> i == Integer.MAX_VALUE ? 0 : i + 1);
treeLatch.writeLock().unlock();
ctx.getSmPages().clear();
}
@@ -245,13 +240,14 @@
private void createNewRoot(BTreeOpContext ctx) throws HyracksDataException
{
// Make sure the root is always in the same page.
-ICachedPage leftNode =
+final ICachedPage leftNode =
Change in asterixdb[master]: [ASTERIXDB-3353][EXT] Fixing avro data parser for union types , addin...
>From Wail Alkowaileet :
Attention is currently required from: Murtadha Hubail, Ayush Tripathi, Hussain
Towaileb.
Wail Alkowaileet has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18178 )
Change subject: [ASTERIXDB-3353][EXT] Fixing avro data parser for union types ,
adding testcases.
..
Patch Set 1:
(3 comments)
Patchset:
PS1:
All pushdown tests are not necessary as Avro doesn't support any type of
projection. Remove those.
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18178/comment/ca49aed4_25e5ebcb
PS1, Line 420:
Remove
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/AvroDataParser.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18178/comment/6a0eeb84_897bc138
PS1, Line 91: private final void parseUnion(Schema unionSchema, Object value,
DataOutput out) throws IOException {
: List possibleTypes = unionSchema.getTypes();
: for (Schema possibleType : possibleTypes) {
: if (possibleType.getType() != NULL) {
: parseValue(possibleType, value, out);
: }
: }
: }
How many types a UNION could have?
You need to investigate if a union could have more than two types. If that the
case, then this should be determined by the value type and not the possible
types of the union.
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18178
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I7bdaec92c4a69e807017d355023d4d46d92a3b95
Gerrit-Change-Number: 18178
Gerrit-PatchSet: 1
Gerrit-Owner: Ayush Tripathi
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Wail Alkowaileet
Gerrit-Attention: Murtadha Hubail
Gerrit-Attention: Ayush Tripathi
Gerrit-Attention: Hussain Towaileb
Gerrit-Comment-Date: Mon, 26 Feb 2024 17:18:44 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
