Change in asterixdb[master]: [NO ISSUE]: Support Reading Single Depth Files/Folder from S3 Container
>From Michael Blow :
Michael Blow has submitted this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206 )
Change subject: [NO ISSUE]: Support Reading Single Depth Files/Folder from S3
Container
..
[NO ISSUE]: Support Reading Single Depth Files/Folder from S3 Container
Change-Id: Iae9d85eb9899419e63c86322cd8da2273adf89c6
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206
Reviewed-by: Utsav Singh
Reviewed-by: Hussain Towaileb
Integration-Tests: Jenkins
Tested-by: Jenkins
---
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/aws/AwsS3ExternalDatasetTest.java
3 files changed, 110 insertions(+), 0 deletions(-)
Approvals:
Hussain Towaileb: Looks good to me, approved
Utsav Singh: Looks good to me, but someone else must approve
Jenkins: Verified; Verified
diff --git
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java
index 55a515c..34d209e 100644
---
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java
+++
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java
@@ -20,6 +20,7 @@
import static
org.apache.asterix.test.external_dataset.avro.AvroFileConverterUtil.AVRO_GEN_BASEDIR;
import static
org.apache.asterix.test.external_dataset.aws.AwsS3ExternalDatasetTest.BOM_FILE_CONTAINER;
+import static
org.apache.asterix.test.external_dataset.aws.AwsS3ExternalDatasetTest.BROWSE_CONTAINER;
import static
org.apache.asterix.test.external_dataset.aws.AwsS3ExternalDatasetTest.DYNAMIC_PREFIX_AT_START_CONTAINER;
import static
org.apache.asterix.test.external_dataset.aws.AwsS3ExternalDatasetTest.FIXED_DATA_CONTAINER;
import static
org.apache.asterix.test.external_dataset.parquet.BinaryFileConverterUtil.BINARY_GEN_BASEDIR;
@@ -78,6 +79,7 @@
private static Uploader fixedDataLoader;
private static Uploader mixedDataLoader;
private static Uploader bomFileLoader;
+private static Uploader browseDataLoader;
protected TestCaseContext tcCtx;
@@ -148,6 +150,16 @@
ExternalDatasetTestUtils.bomFileLoader = bomFileLoader;
}
+public static void setUploaders(Uploader playgroundDataLoader, Uploader
dynamicPrefixAtStartDataLoader,
+Uploader fixedDataLoader, Uploader mixedDataLoader, Uploader
bomFileLoader, Uploader browseDataLoader) {
+ExternalDatasetTestUtils.playgroundDataLoader = playgroundDataLoader;
+ExternalDatasetTestUtils.dynamicPrefixAtStartDataLoader =
dynamicPrefixAtStartDataLoader;
+ExternalDatasetTestUtils.fixedDataLoader = fixedDataLoader;
+ExternalDatasetTestUtils.mixedDataLoader = mixedDataLoader;
+ExternalDatasetTestUtils.bomFileLoader = bomFileLoader;
+ExternalDatasetTestUtils.browseDataLoader = browseDataLoader;
+}
+
/**
* Creates a bucket and fills it with some files for testing purpose.
*/
@@ -183,6 +195,32 @@
LOGGER.info("Files added successfully");
}
+public static void prepareBrowseContainer() {
+/*
+file hierarchy inside browse container
+browse/1.json
+browse/2.json
+browse/level1/3.json
+browse/level1/4.json
+browse/level1/level2/5.json
+browse/level2/level3/6.json
+ */
+// -- todo:Utsav add a test for Browse S3 path which returns multiple
folders, skipped for now as S3 mock server does not support this.
+LOGGER.info("Adding JSON files to " + BROWSE_CONTAINER);
+browseDataLoader.upload("1.json", "{\"id\":" + 1 + "}");
+browseDataLoader.upload("2.json", "{\"id\":" + 2 + "}");
+browseDataLoader.upload("level1/3.json", "{\"id\":" + 3 + "}");
+browseDataLoader.upload("level1/4.json", "{\"id\":" + 4 + "}");
+browseDataLoader.upload("level1/level2/5.json", "{\"id\":" + 5 + "}");
+browseDataLoader.upload("level2/level3/6.json", "{\"id\":" + 6 + "}");
+
+//Adding 1000+ files
+for (int i = 1; i <= 1500; i++) {
+browseDataLoader.upload("level3/" + i + ".json", "{\"id\":" + i +
"}");
+}
+LOGGER.info("JSON Files added successfully");
+}
+
/**
* Special container where dynamic prefix is the first segment
*/
diff --git
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/aws/AwsS3ExternalDatasetTest.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/aws/AwsS3ExternalDatasetTest.java
index
Change in asterixdb[master]: [NO ISSUE]: Support Reading Single Depth Files/Folder from S3 Container
>From Hussain Towaileb : Attention is currently required from: Hussain Towaileb, Utsav Singh. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206 ) Change subject: [NO ISSUE]: Support Reading Single Depth Files/Folder from S3 Container .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iae9d85eb9899419e63c86322cd8da2273adf89c6 Gerrit-Change-Number: 18206 Gerrit-PatchSet: 4 Gerrit-Owner: Utsav Singh Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Utsav Singh Gerrit-Attention: Hussain Towaileb Gerrit-Attention: Utsav Singh Gerrit-Comment-Date: Fri, 29 Mar 2024 17:27:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[jira] [Updated] (ASTERIXDB-3370) Collect accessed objects during compilation
[ https://issues.apache.org/jira/browse/ASTERIXDB-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Maxon updated ASTERIXDB-3370: - Labels: triaged (was: ) > Collect accessed objects during compilation > --- > > Key: ASTERIXDB-3370 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-3370 > Project: Apache AsterixDB > Issue Type: Improvement > Components: COMP - Compiler >Reporter: Murtadha Makki Al Hubail >Priority: Major > Labels: triaged > > During compilation, we should extract all types of access objects. This can > be used later to perform operation such as authorization. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ASTERIXDB-3371) Add median as supported function in tableau dialect
[ https://issues.apache.org/jira/browse/ASTERIXDB-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Maxon updated ASTERIXDB-3371: - Labels: triaged (was: ) > Add median as supported function in tableau dialect > --- > > Key: ASTERIXDB-3371 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-3371 > Project: Apache AsterixDB > Issue Type: Improvement >Reporter: Peeyush Gupta >Priority: Major > Labels: triaged > > With > [ASTERIXDB-3369|https://issues.apache.org/jira/projects/ASTERIXDB/issues/ASTERIXDB-3369] > , median aggregate function will be supported in AsterixDB. We need to > update the tableau dialect file to add median as supported function. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ASTERIXDB-3369) Implement SQL Median() function
[ https://issues.apache.org/jira/browse/ASTERIXDB-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Maxon updated ASTERIXDB-3369: - Labels: triaged (was: ) > Implement SQL Median() function > --- > > Key: ASTERIXDB-3369 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-3369 > Project: Apache AsterixDB > Issue Type: Improvement > Components: FUN - Functions >Reporter: Ali Alsuliman >Assignee: Ali Alsuliman >Priority: Major > Labels: triaged > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ASTERIXDB-3368) Closing S3 streams early still reads the file to the end
[ https://issues.apache.org/jira/browse/ASTERIXDB-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Maxon updated ASTERIXDB-3368: - Labels: triaged (was: ) > Closing S3 streams early still reads the file to the end > > > Key: ASTERIXDB-3368 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-3368 > Project: Apache AsterixDB > Issue Type: Bug > Components: EXT - External data >Affects Versions: 0.9.9 >Reporter: Murtadha Makki Al Hubail >Assignee: Murtadha Makki Al Hubail >Priority: Major > Labels: triaged > Fix For: 0.9.9 > > > When an S3 file stream is closed early (e.g., due to a limit query), the > stream is still being read until the end. We should abort the stream to > indicate that we shouldn't be read to the end. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Change in asterixdb-clients[master]: [ASTERIXDB-3371][TACO] Add median as supported function in tableau di...
>From Peeyush Gupta : Peeyush Gupta has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/18213 ) Change subject: [ASTERIXDB-3371][TACO] Add median as supported function in tableau dialect .. [ASTERIXDB-3371][TACO] Add median as supported function in tableau dialect Change-Id: I75f8d5b2a98e3d0ce89d266199d810e6c94b0f5c Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/18213 Tested-by: Jenkins Reviewed-by: Peeyush Gupta Reviewed-by: Murtadha Hubail --- M asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Murtadha Hubail: Looks good to me, approved Peeyush Gupta: Looks good to me, but someone else must approve Jenkins: Verified diff --git a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd index bef055e..cff91e3 100644 --- a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd +++ b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd @@ -619,6 +619,11 @@ %1 + + MEDIAN(%1) + %1 + + COUNT(%1) (CASE WHEN %1 IS UNKNOWN THEN 0 ELSE 1 END) @@ -1386,6 +1391,7 @@ + -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/18213 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb-clients Gerrit-Branch: master Gerrit-Change-Id: I75f8d5b2a98e3d0ce89d266199d810e6c94b0f5c Gerrit-Change-Number: 18213 Gerrit-PatchSet: 2 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-MessageType: merged
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
>From Ali Alsuliman :
Attention is currently required from: Vijay Sarathy.
Ali Alsuliman has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 )
Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not
working correctly
..
Patch Set 6:
(6 comments)
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/d48e6f66_db40a0db
PS6, Line 378: // Used to keep track of applicable indexes for each expression.
Since index hints
: // are specific to an expression, it is useful to have
this mapping to validate
: // index hints against the applicable indexes for each
expression.
: Map>
exprAndApplicableIndexes = new HashMap<>();
It feels like this should be done after instead of doing it inside the while
loop with every key fields and then having to keep track of when an index is
removed to remove from this map.
You could do it in fetchSecondaryIndexPreferences.
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/d0186444_8a8ce2b6
PS6, Line 413:
Remove added empty line (always remove not needed changes like these to make
the review easier).
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/5b4d7f53_3a45cb3b
PS6, Line 582: || (annotationRemoved && (this instanceof
IntroduceJoinAccessMethodRule))
I am not sure I understand what this means.
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/d7e64e36_ef7b696a
PS6, Line 641: private Class inapplicableHintWarning(
: IOptimizableFuncExpr optFuncExpr,
IOptimizationContext context) {
Change IAccessMethod.getSecondaryIndexPreferences() to return the annotation
directly. Using something like "instanceof IntroduceSelectAccessMethodRule" is
not accurate.
Also, use the "HINT_STRING" from the subclasses of
"AbstractExpressionAnnotationWithIndexNames" for your "param1".
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/29d0411b_b42b938b
PS6, Line 654:
warningCollector.warn(Warning.of(optFuncExpr.getFuncExpr().getSourceLocation(),
:
org.apache.hyracks.api.exceptions.ErrorCode.INAPPLICABLE_HINT, param1,
"ignored"));
Always check first if you should warn:
if (warningCollector.shouldWarn()) {
//warn
}
Also change "ignored" to "inapplicable"
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/ee14bfe4_496ad7b5
PS6, Line 683: && (preferredIndexNames == null ||
!preferredIndexNames.contains(index.getIndexName()))
"preferredIndexNames" is becoming more like "applicableIndexNames", correct?
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 6
Gerrit-Owner: Vijay Sarathy
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Vijay Sarathy
Gerrit-CC: Ali Alsuliman
Gerrit-Attention: Vijay Sarathy
Gerrit-Comment-Date: Fri, 29 Mar 2024 15:05:48 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in asterixdb-clients[master]: [ASTERIXDB-3371][TACO] Add median as supported function in tableau di...
>From Murtadha Hubail : Attention is currently required from: Peeyush Gupta, Ali Alsuliman. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/18213 ) Change subject: [ASTERIXDB-3371][TACO] Add median as supported function in tableau dialect .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/18213 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb-clients Gerrit-Branch: master Gerrit-Change-Id: I75f8d5b2a98e3d0ce89d266199d810e6c94b0f5c Gerrit-Change-Number: 18213 Gerrit-PatchSet: 1 Gerrit-Owner: Peeyush Gupta Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ali Alsuliman Gerrit-Comment-Date: Fri, 29 Mar 2024 14:19:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE]: Support Reading Single Depth Files/Folder from S3 Container
>From Jenkins : Attention is currently required from: Hussain Towaileb. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206 ) Change subject: [NO ISSUE]: Support Reading Single Depth Files/Folder from S3 Container .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/247/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iae9d85eb9899419e63c86322cd8da2273adf89c6 Gerrit-Change-Number: 18206 Gerrit-PatchSet: 4 Gerrit-Owner: Utsav Singh Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Utsav Singh Gerrit-CC: Hussain Towaileb Gerrit-Attention: Hussain Towaileb Gerrit-Attention: Hussain Towaileb Gerrit-Comment-Date: Fri, 29 Mar 2024 07:49:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE]: Support Reading Single Depth Files/Folder from S3 Container
>From Utsav Singh :
Attention is currently required from: Hussain Towaileb.
Utsav Singh has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206 )
Change subject: [NO ISSUE]: Support Reading Single Depth Files/Folder from S3
Container
..
Patch Set 4: Code-Review+1
(5 comments)
File
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206/comment/a0452d4b_62ad87da
PS2, Line 200: file hierarchy inside browse container
> Let's also have a test that adds 1500 folders and 1500 files, we need to make
> sure that we are retur […]
Ack
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206/comment/e9e228c2_8eb0f978
PS2, Line 522: Map> allObjects =
listS3ObjectsOfSingleDepth(s3Client, container, prefix);
: return allObjects;
> You can just return the result directly: […]
Ack
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206/comment/466c9b11_55a40bd3
PS2, Line 543: Boolean
> boolean
Ack
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206/comment/efbc7e07_b49e7a97
PS2, Line 546: for (S3Object object : listObjectsInterable.contents()) {
> I'm not sure if this is handling the 1000+ folders/files correctly, check the
> comment I added for ad […]
Ack
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206/comment/d3695ab2_963db211
PS2, Line 560: for (CommonPrefix object :
listObjectsInterable.commonPrefixes()) {
> Same as above.
Ack
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iae9d85eb9899419e63c86322cd8da2273adf89c6
Gerrit-Change-Number: 18206
Gerrit-PatchSet: 4
Gerrit-Owner: Utsav Singh
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Utsav Singh
Gerrit-CC: Hussain Towaileb
Gerrit-Attention: Hussain Towaileb
Gerrit-Attention: Hussain Towaileb
Gerrit-Comment-Date: Fri, 29 Mar 2024 07:08:39 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hussain Towaileb
Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE]: Support Reading Single Depth Files/Folder from S3 Container
>From Utsav Singh : Attention is currently required from: Hussain Towaileb, Utsav Singh. Hello Jenkins, Hussain Towaileb, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206 to look at the new patch set (#4). Change subject: [NO ISSUE]: Support Reading Single Depth Files/Folder from S3 Container .. [NO ISSUE]: Support Reading Single Depth Files/Folder from S3 Container Change-Id: Iae9d85eb9899419e63c86322cd8da2273adf89c6 --- M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/ExternalDatasetTestUtils.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/aws/AwsS3ExternalDatasetTest.java 3 files changed, 105 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/06/18206/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18206 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iae9d85eb9899419e63c86322cd8da2273adf89c6 Gerrit-Change-Number: 18206 Gerrit-PatchSet: 4 Gerrit-Owner: Utsav Singh Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Utsav Singh Gerrit-CC: Hussain Towaileb Gerrit-Attention: Hussain Towaileb Gerrit-Attention: Utsav Singh Gerrit-MessageType: newpatchset
