[jira] [Created] (ASTERIXDB-3392) Add parquet format for COPY TO

2024-04-29 Thread Preetham (Jira)
Preetham created ASTERIXDB-3392:
---

 Summary: Add parquet format for COPY TO 
 Key: ASTERIXDB-3392
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-3392
 Project: Apache AsterixDB
  Issue Type: Improvement
  Components: EXT - External data
Affects Versions: 0.9.10
Reporter: Preetham
 Fix For: 0.9.10






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..


Patch Set 18: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/411/ : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I87813c761f5024742fb8658360166613d01f127d
Gerrit-Change-Number: 17620
Gerrit-PatchSet: 18
Gerrit-Owner: Sushrut Borkar 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Ian Maxon 
Gerrit-Attention: Sushrut Borkar 
Gerrit-Attention: Glenn Galvizo 
Gerrit-Comment-Date: Tue, 30 Apr 2024 03:45:16 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are m...

2024-04-29 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Vijay Sarathy.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196 )

Change subject: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there 
are multiple join predicates
..


Patch Set 7: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/410/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 7
Gerrit-Owner: Vijay Sarathy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Vijay Sarathy 
Gerrit-Comment-Date: Tue, 30 Apr 2024 03:06:11 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: WIP: make dmls cancellable

2024-04-29 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Peeyush Gupta.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 )

Change subject: WIP: make dmls cancellable
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/409/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0
Gerrit-Change-Number: 18257
Gerrit-PatchSet: 2
Gerrit-Owner: Peeyush Gupta 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Peeyush Gupta 
Gerrit-Comment-Date: Tue, 30 Apr 2024 02:37:27 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are m...

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Vijay Sarathy.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196 )

Change subject: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there 
are multiple join predicates
..


Patch Set 7: Contrib+1

Analytics Compatibility Tests Successful
https://cbjenkins.page.link/Cz81NaKf6DmXWfHM8 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 7
Gerrit-Owner: Vijay Sarathy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Vijay Sarathy 
Gerrit-Comment-Date: Tue, 30 Apr 2024 02:32:23 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [WIP] Refactor Cloud writer

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Wail Alkowaileet.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18259 )

Change subject: [WIP] Refactor Cloud writer
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/rCoq27ziUr118oYK8 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18259
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I52124696b50d6dcc1f3c65b7e0fe251df1579ac5
Gerrit-Change-Number: 18259
Gerrit-PatchSet: 1
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Wail Alkowaileet 
Gerrit-Comment-Date: Tue, 30 Apr 2024 02:25:17 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..


Patch Set 18: Contrib-2

Analytics Compatibility Compilation Failed
https://cbjenkins.page.link/e82ifDM8u71GXTqA9 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I87813c761f5024742fb8658360166613d01f127d
Gerrit-Change-Number: 17620
Gerrit-PatchSet: 18
Gerrit-Owner: Sushrut Borkar 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Ian Maxon 
Gerrit-Attention: Sushrut Borkar 
Gerrit-Attention: Glenn Galvizo 
Gerrit-Comment-Date: Tue, 30 Apr 2024 01:52:51 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: WIP: make dmls cancellable

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Peeyush Gupta.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 )

Change subject: WIP: make dmls cancellable
..


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/VNMuyQyrsocpLSbs7 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0
Gerrit-Change-Number: 18257
Gerrit-PatchSet: 2
Gerrit-Owner: Peeyush Gupta 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Peeyush Gupta 
Gerrit-Comment-Date: Tue, 30 Apr 2024 01:51:42 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [WIP] Refactor Cloud writer

2024-04-29 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Wail Alkowaileet.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18259 )

Change subject: [WIP] Refactor Cloud writer
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/408/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18259
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I52124696b50d6dcc1f3c65b7e0fe251df1579ac5
Gerrit-Change-Number: 18259
Gerrit-PatchSet: 1
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Attention: Wail Alkowaileet 
Gerrit-Comment-Date: Tue, 30 Apr 2024 01:41:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
>From Glenn Galvizo :

Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Glenn Galvizo has uploaded a new patch set (#18) to the change originally 
created by Sushrut Borkar. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..

[ASTERIXDB-3183][COMP] Add query plan cache

- user model changes: yes
- storage format changes: no
- interface changes: yes

Details:

The query plan cache reduces compile times by storing job specs for
old queries. This allows skipping the rewriting and compilation
stages of repeated queries.

Change-Id: I87813c761f5024742fb8658360166613d01f127d
---
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheKey.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheValue.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.08.regexadm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/annotation/ExcludeFromSelectStarAnnotation.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.001.regexjson
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.06.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql-sugar/avg_mixed/avg_mixed.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCacheTest.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.004.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.03.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cache-residency/cache-residency.001.regexjson
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.04.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.006.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.003.post.http
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCache.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/request-param-validation-400-BAD/request-param-validation-400-BAD.01.regexjson
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CcApplicationContext.java
M 
asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestCaseContext.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.05.regexadm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppAstPrintVisitor.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/ExternalSubpathAnnotation.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponseMetrics.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.004.delete.http
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/clear/ClearCachePredicate.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cache-residency/cache-residency.002.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.006.delete.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.04.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.007.delete.http
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
A 

Change in asterixdb[master]: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are m...

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Vijay Sarathy.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196 )

Change subject: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there 
are multiple join predicates
..


Patch Set 7:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/X5pvaPZQNzengYuZ6 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 7
Gerrit-Owner: Vijay Sarathy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Vijay Sarathy 
Gerrit-Comment-Date: Tue, 30 Apr 2024 00:22:29 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are m...

2024-04-29 Thread AsterixDB Code Review
>From Vijay Sarathy :

Attention is currently required from: Vijay Sarathy.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196

to look at the new patch set (#7).

Change subject: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there 
are multiple join predicates
..

[ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are multiple 
join predicates

Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/join/hash-join-with-redundant-variable/hash-join-with-redundant-variable.06.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/open-index-enforced/inverted-index-join/ngram-contains_01_ps.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-join/hints-indexnl-params/hints-indexnl-params-4.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/nested-open-index/inverted-index-join/ngram-contains_02_ps.plan
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/nested-open-index/inverted-index-join/ngram-contains_01_ps.plan
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java
7 files changed, 229 insertions(+), 60 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/18196/7
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 7
Gerrit-Owner: Vijay Sarathy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Vijay Sarathy 
Gerrit-MessageType: newpatchset


Change in asterixdb[neo]: [NO ISSUE][ING] Set Active Entity as Running on recovery

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Ali Alsuliman.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18258 )

Change subject: [NO ISSUE][ING] Set Active Entity as Running on recovery
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/VNf26fL8PHPe5YMx9 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18258
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I7764287ea48b56a815657cb159582e2118d6bcd8
Gerrit-Change-Number: 18258
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Ali Alsuliman 
Gerrit-Comment-Date: Tue, 30 Apr 2024 00:08:26 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[neo]: [NO ISSUE][OTH] Logging improvements for job failure events

2024-04-29 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Murtadha Hubail, Ali Alsuliman.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18237 )

Change subject: [NO ISSUE][OTH] Logging improvements for job failure events
..


Patch Set 6: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/407/ : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18237
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ib1c99f00cde31224b0bcb86357c64d9c5404d2e7
Gerrit-Change-Number: 18237
Gerrit-PatchSet: 6
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Attention: Murtadha Hubail 
Gerrit-Attention: Ali Alsuliman 
Gerrit-Comment-Date: Tue, 30 Apr 2024 00:05:53 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[neo]: [NO ISSUE][OTH] Logging improvements for job failure events

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Murtadha Hubail, Ali Alsuliman.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18237 )

Change subject: [NO ISSUE][OTH] Logging improvements for job failure events
..


Patch Set 6: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/SAh5x9aU1drhJ9HK7 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18237
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ib1c99f00cde31224b0bcb86357c64d9c5404d2e7
Gerrit-Change-Number: 18237
Gerrit-PatchSet: 6
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Attention: Murtadha Hubail 
Gerrit-Attention: Ali Alsuliman 
Gerrit-Comment-Date: Tue, 30 Apr 2024 00:04:48 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[neo]: [NO ISSUE][ING] Set Active Entity as Running on recovery

2024-04-29 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Ali Alsuliman.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18258 )

Change subject: [NO ISSUE][ING] Set Active Entity as Running on recovery
..


Patch Set 1: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/406/ : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18258
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I7764287ea48b56a815657cb159582e2118d6bcd8
Gerrit-Change-Number: 18258
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Attention: Ali Alsuliman 
Gerrit-Comment-Date: Mon, 29 Apr 2024 23:51:42 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..


Patch Set 17: Contrib-2

Analytics Compatibility Compilation Failed
https://cbjenkins.page.link/zHTvZykh3Vy9jbhg6 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I87813c761f5024742fb8658360166613d01f127d
Gerrit-Change-Number: 17620
Gerrit-PatchSet: 17
Gerrit-Owner: Sushrut Borkar 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Ian Maxon 
Gerrit-Attention: Sushrut Borkar 
Gerrit-Attention: Glenn Galvizo 
Gerrit-Comment-Date: Mon, 29 Apr 2024 23:44:17 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: WIP: make dmls cancellable

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Peeyush Gupta.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 )

Change subject: WIP: make dmls cancellable
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/NyHhV5Gxhq9YKdhi7 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0
Gerrit-Change-Number: 18257
Gerrit-PatchSet: 2
Gerrit-Owner: Peeyush Gupta 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Peeyush Gupta 
Gerrit-Comment-Date: Mon, 29 Apr 2024 23:42:22 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in asterixdb[master]: [WIP] Refactor Cloud writer

2024-04-29 Thread AsterixDB Code Review
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18259 )

Change subject: [WIP] Refactor Cloud writer
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/pdPn5MuiH4PxLy2o9 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18259
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I52124696b50d6dcc1f3c65b7e0fe251df1579ac5
Gerrit-Change-Number: 18259
Gerrit-PatchSet: 1
Gerrit-Owner: Wail Alkowaileet 
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins 
Gerrit-Comment-Date: Mon, 29 Apr 2024 23:38:39 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
>From Glenn Galvizo :

Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Glenn Galvizo has uploaded a new patch set (#17) to the change originally 
created by Sushrut Borkar. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..

[ASTERIXDB-3183][COMP] Add query plan cache

- user model changes: yes
- storage format changes: no
- interface changes: yes

Details:

The query plan cache reduces compile times by storing job specs for
old queries. This allows skipping the rewriting and compilation
stages of repeated queries.

Change-Id: I87813c761f5024742fb8658360166613d01f127d
---
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheKey.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheValue.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.08.regexadm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/annotation/ExcludeFromSelectStarAnnotation.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.001.regexjson
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.06.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql-sugar/avg_mixed/avg_mixed.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCacheTest.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.004.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.03.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cache-residency/cache-residency.001.regexjson
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.04.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.006.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.003.post.http
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCache.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/request-param-validation-400-BAD/request-param-validation-400-BAD.01.regexjson
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CcApplicationContext.java
M 
asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestCaseContext.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.05.regexadm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppAstPrintVisitor.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/ExternalSubpathAnnotation.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponseMetrics.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.004.delete.http
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/clear/ClearCachePredicate.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cache-residency/cache-residency.002.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.006.delete.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.04.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.007.delete.http
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
A 

Change in asterixdb[master]: WIP: make dmls cancellable

2024-04-29 Thread AsterixDB Code Review
>From Peeyush Gupta :

Attention is currently required from: Peeyush Gupta.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257

to look at the new patch set (#2).

Change subject: WIP: make dmls cancellable
..

WIP: make dmls cancellable

Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/atomic_statements/AtomicStatementsCancellationTest.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
6 files changed, 155 insertions(+), 7 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/57/18257/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0
Gerrit-Change-Number: 18257
Gerrit-PatchSet: 2
Gerrit-Owner: Peeyush Gupta 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Peeyush Gupta 
Gerrit-MessageType: newpatchset


Change in asterixdb[master]: [WIP] Refactor Cloud writer

2024-04-29 Thread AsterixDB Code Review
>From Wail Alkowaileet :

Wail Alkowaileet has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18259 )


Change subject: [WIP] Refactor Cloud writer
..

[WIP] Refactor Cloud writer

Change-Id: I52124696b50d6dcc1f3c65b7e0fe251df1579ac5
---
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/LazyCloudIOManager.java
R 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/CloudResettableInputStream.java
A 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/ICloudWriter.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/accessor/ILazyAccessor.java
R 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/write/S3BufferedWriter.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/accessor/ReplaceableCloudAccessor.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/CloudOutputStream.java
R 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/write/WriterSingleBufferProvider.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/EagerCloudIOManager.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/CloudFileHandle.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/S3ExternalFileWriterFactory.java
R 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/write/IWriteBufferProvider.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/AbstractCloudExternalFileWriter.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/ICloudClient.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3CloudClient.java
R 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/write/WriteBufferProvider.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/CloudClientProvider.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/accessor/LocalAccessor.java
M asterixdb/asterix-cloud/src/test/java/org/apache/asterix/cloud/LSMTest.java
M 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/AbstractCloudIOManager.java
A 
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/NoOpCloudWriter.java
22 files changed, 307 insertions(+), 118 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/59/18259/1

diff --git 
a/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/AbstractCloudIOManager.java
 
b/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/AbstractCloudIOManager.java
index 368be26..966e311 100644
--- 
a/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/AbstractCloudIOManager.java
+++ 
b/asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/AbstractCloudIOManager.java
@@ -34,6 +34,10 @@
 import org.apache.asterix.cloud.bulk.NoOpDeleteBulkCallBack;
 import org.apache.asterix.cloud.clients.CloudClientProvider;
 import org.apache.asterix.cloud.clients.ICloudClient;
+import org.apache.asterix.cloud.clients.ICloudWriter;
+import org.apache.asterix.cloud.clients.NoOpCloudWriter;
+import org.apache.asterix.cloud.clients.aws.s3.write.IWriteBufferProvider;
+import org.apache.asterix.cloud.clients.aws.s3.write.WriteBufferProvider;
 import org.apache.asterix.cloud.util.CloudFileUtil;
 import org.apache.asterix.common.api.INamespacePathResolver;
 import org.apache.asterix.common.cloud.IPartitionBootstrapper;
@@ -71,7 +75,7 @@
 this.bucket = cloudProperties.getStorageBucket();
 cloudClient = CloudClientProvider.getClient(cloudProperties);
 int numOfThreads = getIODevices().size() * getIOParallelism();
-writeBufferProvider = new WriteBufferProvider(numOfThreads);
+writeBufferProvider = new WriteBufferProvider(numOfThreads, 
cloudClient.getWriteBufferSize());
 partitions = new HashSet<>();
 partitionPaths = new ArrayList<>();
 this.localIoManager = ioManager;
@@ -165,8 +169,10 @@
 @Override
 public final IFileHandle open(FileReference fileRef, FileReadWriteMode 
rwMode, FileSyncMode syncMode)
 throws HyracksDataException {
-CloudFileHandle fHandle = new CloudFileHandle(cloudClient, bucket, 
fileRef, writeBufferProvider);
-onOpen(fHandle, rwMode, syncMode);
+ICloudWriter cloudWriter = exists(fileRef) ? NoOpCloudWriter.INSTANCE
+: cloudClient.createdWriter(bucket, fileRef.getRelativePath(), 
writeBufferProvider);
+CloudFileHandle fHandle = new CloudFileHandle(fileRef, cloudWriter);
+onOpen(fHandle);
 try {
 fHandle.open(rwMode, syncMode);
 } catch (IOException e) {
@@ -180,18 

[jira] [Created] (ASTERIXDB-3391) Make DML statements cancellable

2024-04-29 Thread Peeyush Gupta (Jira)
Peeyush Gupta created ASTERIXDB-3391:


 Summary: Make DML statements cancellable
 Key: ASTERIXDB-3391
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-3391
 Project: Apache AsterixDB
  Issue Type: Improvement
Reporter: Peeyush Gupta


Currently insert/upsert/delete and copy statements are non-cancellable. We need 
to make them cancellable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..


Patch Set 16: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/405/ : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I87813c761f5024742fb8658360166613d01f127d
Gerrit-Change-Number: 17620
Gerrit-PatchSet: 16
Gerrit-Owner: Sushrut Borkar 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Ian Maxon 
Gerrit-Attention: Sushrut Borkar 
Gerrit-Attention: Glenn Galvizo 
Gerrit-Comment-Date: Mon, 29 Apr 2024 22:38:58 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[neo]: [NO ISSUE][OTH] Logging improvements for job failure events

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Murtadha Hubail.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18237 )

Change subject: [NO ISSUE][OTH] Logging improvements for job failure events
..


Patch Set 6:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/ksDCkNkUtMS7p43V9 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18237
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ib1c99f00cde31224b0bcb86357c64d9c5404d2e7
Gerrit-Change-Number: 18237
Gerrit-PatchSet: 6
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Attention: Murtadha Hubail 
Gerrit-Comment-Date: Mon, 29 Apr 2024 22:16:03 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in asterixdb[neo]: [NO ISSUE][ING] Set Active Entity as Running on recovery

2024-04-29 Thread AsterixDB Code Review
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18258 )

Change subject: [NO ISSUE][ING] Set Active Entity as Running on recovery
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/5UfS9wyBMBVHd8TM7 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18258
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I7764287ea48b56a815657cb159582e2118d6bcd8
Gerrit-Change-Number: 18258
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins 
Gerrit-Comment-Date: Mon, 29 Apr 2024 22:14:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


[jira] [Commented] (ASTERIXDB-3375) Introduce local disk caching APIs for cloud deployment

2024-04-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842177#comment-17842177
 ] 

ASF subversion and git services commented on ASTERIXDB-3375:


Commit ebde8c9f20297b8c958c33457ad64d3bbfcff722 in asterixdb's branch 
refs/heads/master from Wail Alkowaileet
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=ebde8c9f20 ]

[ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching

- user model changes: no
- storage format changes: yes
- interface changes: yes

Details:
- Several modifications in columnar APIs to accommodate
  disk caching
- Pass read/write buffer cache context to LSMColumnBTree
  bulkloader and cursors
- Some refactoring in hyracks-cloud API (ASTERIXDB-3375)

Storage changes:
- Store the length (in bytes) of the mega leaf node in
  Page0 instead of the of the number of pages

Change-Id: Iababcc5fc1d4e5e2de36f9b26c3f86ffabfb4e54
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Wail Alkowaileet 
Reviewed-by: Murtadha Hubail 


> Introduce local disk caching APIs for cloud deployment
> --
>
> Key: ASTERIXDB-3375
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-3375
> Project: Apache AsterixDB
>  Issue Type: Improvement
>  Components: HYR - Hyracks, STO - Storage
>Affects Versions: 0.9.10
>Reporter: Wail Y. Alkowaileet
>Assignee: Wail Y. Alkowaileet
>Priority: Major
>  Labels: triaged
> Fix For: 0.9.10
>
>
> Introduce hyracks-cloud module along with local disk caching APIs



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ASTERIXDB-3389) Allow caching and evicting pages of columnar collection in cloud deployment

2024-04-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842176#comment-17842176
 ] 

ASF subversion and git services commented on ASTERIXDB-3389:


Commit ebde8c9f20297b8c958c33457ad64d3bbfcff722 in asterixdb's branch 
refs/heads/master from Wail Alkowaileet
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=ebde8c9f20 ]

[ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching

- user model changes: no
- storage format changes: yes
- interface changes: yes

Details:
- Several modifications in columnar APIs to accommodate
  disk caching
- Pass read/write buffer cache context to LSMColumnBTree
  bulkloader and cursors
- Some refactoring in hyracks-cloud API (ASTERIXDB-3375)

Storage changes:
- Store the length (in bytes) of the mega leaf node in
  Page0 instead of the of the number of pages

Change-Id: Iababcc5fc1d4e5e2de36f9b26c3f86ffabfb4e54
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Wail Alkowaileet 
Reviewed-by: Murtadha Hubail 


> Allow caching and evicting pages of columnar collection in cloud deployment
> ---
>
> Key: ASTERIXDB-3389
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-3389
> Project: Apache AsterixDB
>  Issue Type: Improvement
>  Components: STO - Storage
>Affects Versions: 0.9.10
>Reporter: Wail Y. Alkowaileet
>Assignee: Wail Y. Alkowaileet
>Priority: Major
>  Labels: triaged
> Fix For: 0.9.10
>
>
> In a cloud deployment, columnar collections will not be downloaded as we 
> currently do. Instead, only pages of the requested columns will be brought up 
> from the cloud. On disk pressure, those pages can be evicted (given some 
> eviction policy/criteria).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Change in asterixdb[neo]: [NO ISSUE][ING] Set Active Entity as Running on recovery

2024-04-29 Thread AsterixDB Code Review
>From Ali Alsuliman :

Ali Alsuliman has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18258 )


Change subject: [NO ISSUE][ING] Set Active Entity as Running on recovery
..

[NO ISSUE][ING] Set Active Entity as Running on recovery

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
When recovery of an active entity is successful, set it
as running.

Change-Id: I7764287ea48b56a815657cb159582e2118d6bcd8
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java
1 file changed, 18 insertions(+), 0 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/58/18258/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java
index 34a54d1..e4e7b36 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java
@@ -140,6 +140,7 @@
 if (!cancelRecovery && listener.getState() == 
ActivityState.TEMPORARILY_FAILED) {
 listener.setState(ActivityState.RECOVERING);
 listener.doRecover(metadataProvider);
+listener.setRunning(metadataProvider, true);
 }
 LOGGER.log(level, "Recovery completed successfully");
 return null;

--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18258
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: I7764287ea48b56a815657cb159582e2118d6bcd8
Gerrit-Change-Number: 18258
Gerrit-PatchSet: 1
Gerrit-Owner: Ali Alsuliman 
Gerrit-MessageType: newchange


Change in asterixdb[master]: [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching

2024-04-29 Thread AsterixDB Code Review
>From Murtadha Hubail :

Attention is currently required from: Wail Alkowaileet.
Murtadha Hubail has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255 )

Change subject: [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching
..


Patch Set 2: Code-Review+2


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iababcc5fc1d4e5e2de36f9b26c3f86ffabfb4e54
Gerrit-Change-Number: 18255
Gerrit-PatchSet: 2
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Attention: Wail Alkowaileet 
Gerrit-Comment-Date: Mon, 29 Apr 2024 21:52:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are m...

2024-04-29 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Vijay Sarathy.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196 )

Change subject: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there 
are multiple join predicates
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/404/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 6
Gerrit-Owner: Vijay Sarathy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Vijay Sarathy 
Gerrit-Comment-Date: Mon, 29 Apr 2024 21:50:30 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..


Patch Set 16: Contrib-2

Analytics Compatibility Compilation Failed
https://cbjenkins.page.link/w3gryt2EVLCBTDto8 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I87813c761f5024742fb8658360166613d01f127d
Gerrit-Change-Number: 17620
Gerrit-PatchSet: 16
Gerrit-Owner: Sushrut Borkar 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Ian Maxon 
Gerrit-Attention: Sushrut Borkar 
Gerrit-Attention: Glenn Galvizo 
Gerrit-Comment-Date: Mon, 29 Apr 2024 20:50:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
>From Glenn Galvizo :

Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Glenn Galvizo has uploaded a new patch set (#16) to the change originally 
created by Sushrut Borkar. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..

[ASTERIXDB-3183][COMP] Add query plan cache

- user model changes: yes
- storage format changes: no
- interface changes: yes

Details:

The query plan cache reduces compile times by storing job specs for
old queries. This allows skipping the rewriting and compilation
stages of repeated queries.

Change-Id: I87813c761f5024742fb8658360166613d01f127d
---
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheKey.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheValue.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.08.regexadm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/annotation/ExcludeFromSelectStarAnnotation.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.001.regexjson
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.06.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql-sugar/avg_mixed/avg_mixed.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCacheTest.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.004.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.03.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cache-residency/cache-residency.001.regexjson
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.04.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.006.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.003.post.http
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCache.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/request-param-validation-400-BAD/request-param-validation-400-BAD.01.regexjson
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CcApplicationContext.java
M 
asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestCaseContext.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.05.regexadm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppAstPrintVisitor.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/ExternalSubpathAnnotation.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponseMetrics.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.004.delete.http
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/clear/ClearCachePredicate.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cache-residency/cache-residency.002.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.006.delete.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.04.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.007.delete.http
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
A 

Change in asterixdb[master]: WIP: make dmls cancellable

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Peeyush Gupta.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 )

Change subject: WIP: make dmls cancellable
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/DyPEgzU76v2L9mTW9 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0
Gerrit-Change-Number: 18257
Gerrit-PatchSet: 1
Gerrit-Owner: Peeyush Gupta 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Peeyush Gupta 
Gerrit-Comment-Date: Mon, 29 Apr 2024 20:27:48 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are m...

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Vijay Sarathy.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196 )

Change subject: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there 
are multiple join predicates
..


Patch Set 6:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/4UG2655HMUMGwir86 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 6
Gerrit-Owner: Vijay Sarathy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Vijay Sarathy 
Gerrit-Comment-Date: Mon, 29 Apr 2024 20:12:23 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are m...

2024-04-29 Thread AsterixDB Code Review
>From Vijay Sarathy :

Attention is currently required from: Vijay Sarathy.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196

to look at the new patch set (#6).

Change subject: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there 
are multiple join predicates
..

[ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are multiple 
join predicates

Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-join/hints-indexnl-params/hints-indexnl-params-4.plan
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java
3 files changed, 68 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/18196/6
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 6
Gerrit-Owner: Vijay Sarathy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Vijay Sarathy 
Gerrit-MessageType: newpatchset


Change in asterixdb[master]: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are m...

2024-04-29 Thread AsterixDB Code Review
>From Vijay Sarathy :

Attention is currently required from: Vijay Sarathy.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196

to look at the new patch set (#4).

Change subject: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there 
are multiple join predicates. Change-Id: 
Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
..

[ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are multiple 
join predicates.
Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-join/hints-indexnl-params/hints-indexnl-params-4.plan
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java
3 files changed, 68 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/18196/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 4
Gerrit-Owner: Vijay Sarathy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Vijay Sarathy 
Gerrit-MessageType: newpatchset


Change in asterixdb[master]: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are m...

2024-04-29 Thread AsterixDB Code Review
>From Vijay Sarathy :

Attention is currently required from: Vijay Sarathy.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196

to look at the new patch set (#5).

Change subject: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there 
are multiple join predicates.
..

[ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are multiple 
join predicates.

Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-join/hints-indexnl-params/hints-indexnl-params-4.plan
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java
3 files changed, 69 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/18196/5
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 5
Gerrit-Owner: Vijay Sarathy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Vijay Sarathy 
Gerrit-MessageType: newpatchset


Change in asterixdb[master]: [WIP] Support COPY TO in parquet

2024-04-29 Thread AsterixDB Code Review
>From Wail Alkowaileet :

Attention is currently required from: preetham.polupar...@couchbase.com.
Wail Alkowaileet has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209 )

Change subject: [WIP] Support COPY TO in parquet
..


Patch Set 30:

(1 comment)

Commit Message:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/99cc63c4_3d50de4a
PS30, Line 7: WIP
Reference the ticket.

See an example of a commit msg:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I40dc16969e66af09cde04b460f441af666b39d51
Gerrit-Change-Number: 18209
Gerrit-PatchSet: 30
Gerrit-Owner: preetham.polupar...@couchbase.com
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: preetham.polupar...@couchbase.com
Gerrit-CC: Wail Alkowaileet 
Gerrit-Attention: preetham.polupar...@couchbase.com
Gerrit-Comment-Date: Mon, 29 Apr 2024 19:57:32 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..


Patch Set 15: Contrib-2

Analytics Compatibility Compilation Failed
https://cbjenkins.page.link/UuorYsUsmKpdxTQJ7 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I87813c761f5024742fb8658360166613d01f127d
Gerrit-Change-Number: 17620
Gerrit-PatchSet: 15
Gerrit-Owner: Sushrut Borkar 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Ian Maxon 
Gerrit-Attention: Sushrut Borkar 
Gerrit-Attention: Glenn Galvizo 
Gerrit-Comment-Date: Mon, 29 Apr 2024 19:57:11 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [WIP] Support COPY TO in parquet

2024-04-29 Thread AsterixDB Code Review
>From Wail Alkowaileet :

Attention is currently required from: preetham.polupar...@couchbase.com.
Wail Alkowaileet has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209 )

Change subject: [WIP] Support COPY TO in parquet
..


Patch Set 30:

(19 comments)

File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/53d9e4de_ddeb6f11
PS30, Line 307: Units
unit


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/db93f1b0_788f5ae5
PS30, Line 307: , given
. Provided


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/d535f847_8ea27207
PS30, Line 308: Unsupported compression scheme
Remove and use 1096


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/32ef9cae_a4fd7021
PS30, Line 87: 1MB
Something could be off here. Both page size and row group size are the same?


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/6739fe02_2b9a9121
PS30, Line 315: public static final String KEY_COMPRESSION_LZO = "lzo";
  : public static final String KEY_COMPRESSION_LZ4_RAW = 
"lz4_raw";
  : public static final String KEY_COMPRESSION_BROTLI = 
"brotli";
Can you do a simple benchmark that compares both the size and write throughput? 
If I remember correctly, zstd and snappy give the best compression and time.

*Can be done later


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/05282866_728771bb
PS30, Line 331: JSON_WRITER_SUPPORTED_COMPRESSION
TEXTUAL_WRITER_SUPPORTED_COMPRESSION
'Those' will be used for CSV as well


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/WriterValidationUtil.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/4eb4c84a_5f2e0393
PS30, Line 115: validateJSONCompression
validateTextualCompression


File asterixdb/asterix-om/pom.xml:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/367fa1de_01cb992b
PS30, Line 163:   
Fix indentation


File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/ParquetRecordLazyVisitor.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/c154fefa_39728e4c
PS30, Line 55: ARecordType
This will fail if it is ANY. Because ANY isn't of type ARecordType
https://github.com/apache/asterixdb/blob/6d124481c4238b59b754eec83811c28596bb6d29/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/BuiltinType.java#L970


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/7d257cdf_73fe1cbd
PS30, Line 82: throw new 
HyracksDataException(ErrorCode.TUPLE_DOES_NOT_AGREE_WITH_GIVEN_SCHEMA
You cannot assume any exception is a typing error. For example, what if 
getOrCreateFieldNameIndex() is the one that throws an exception? Also, the 
message does not tell me anything (I have no clue what's the offending type). 
As a user, I would need more information about the offending type and what the 
actual data type is.

You need to make sure 'Type type' is a group type and it corresponds to an 
object. Take a look at line 90. It is exactly the same as this line (i.e., 67). 
How do you know if 'type' corresponds to an object or an array? You need to 
more digging in 'type' to ensure that the type is an array or object

See:
https://github.com/apache/asterixdb/blob/6d124481c4238b59b754eec83811c28596bb6d29/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/hdfs/parquet/AsterixTypeToParquetTypeVisitor.java#L195


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/94d36201_2a7b01e5
PS30, Line 90: asGroupType
See the comment above


File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/ParquetRecordVisitorUtils.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/ecb8211d_4b436765
PS30, Line 60: case BOOLEAN:
 : case BINARY:
 : case FIXED_LEN_BYTE_ARRAY:
 : case INT96:
remove. 'default' suffices.


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/a31913e3_e807657d
PS30, Line 65: HyracksDataException
throw RuntimeDataException.create(ErrorCode.TYPE_MISMATCH_GENERIC, ATypeTag, 
primitiveTypeName)


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/331bff3c_9e30dc57
PS30, Line 176:switch (primitiveTypeName) {
  : case BOOLEAN:
  : recordConsumer.addBoolean(booleanValue);
  : break;
  : case BINARY:
  : case INT32:
  : case INT64:
  :  

Change in asterixdb[master]: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are m...

2024-04-29 Thread AsterixDB Code Review
>From Vijay Sarathy :

Attention is currently required from: Vijay Sarathy.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196

to look at the new patch set (#3).

Change subject: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there 
are multiple join predicates
..

[ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are multiple 
join predicates

Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-join/hints-indexnl-params/hints-indexnl-params-4.plan
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java
3 files changed, 69 insertions(+), 19 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/18196/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 3
Gerrit-Owner: Vijay Sarathy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Vijay Sarathy 
Gerrit-MessageType: newpatchset


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
>From Glenn Galvizo :

Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Glenn Galvizo has uploaded a new patch set (#15) to the change originally 
created by Sushrut Borkar. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..

[ASTERIXDB-3183][COMP] Add query plan cache

- user model changes: yes
- storage format changes: no
- interface changes: yes

Details:

The query plan cache reduces compile times by storing job specs for
old queries. This allows skipping the rewriting and compilation
stages of repeated queries.

Change-Id: I87813c761f5024742fb8658360166613d01f127d
---
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheKey.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheValue.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.08.regexadm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/annotation/ExcludeFromSelectStarAnnotation.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.001.regexjson
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.06.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql-sugar/avg_mixed/avg_mixed.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCacheTest.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.004.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.03.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cache-residency/cache-residency.001.regexjson
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.04.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.006.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.003.post.http
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCache.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/request-param-validation-400-BAD/request-param-validation-400-BAD.01.regexjson
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CcApplicationContext.java
M 
asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestCaseContext.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.05.regexadm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppAstPrintVisitor.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/ExternalSubpathAnnotation.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponseMetrics.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.004.delete.http
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/clear/ClearCachePredicate.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cache-residency/cache-residency.002.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.006.delete.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.04.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.007.delete.http
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
A 

Change in asterixdb[master]: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are m...

2024-04-29 Thread AsterixDB Code Review
>From Vijay Sarathy :

Attention is currently required from: Vijay Sarathy.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196

to look at the new patch set (#2).

Change subject: [ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there 
are multiple join predicates
..

[ASTERIXDB-3363][COMP] CBO not choosing indexnl join when there are multiple 
join predicates

Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-join/hints-indexnl-params/hints-indexnl-params-4.plan
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java
3 files changed, 70 insertions(+), 20 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/18196/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18196
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic32b6a5d7b3c7b336d0f8aa2ee5add5d6cda59b8
Gerrit-Change-Number: 18196
Gerrit-PatchSet: 2
Gerrit-Owner: Vijay Sarathy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Vijay Sarathy 
Gerrit-MessageType: newpatchset


Change in asterixdb[master]: WIP: make dmls cancellable

2024-04-29 Thread AsterixDB Code Review
>From Jenkins :

Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 )

Change subject: WIP: make dmls cancellable
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/397/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0
Gerrit-Change-Number: 18257
Gerrit-PatchSet: 1
Gerrit-Owner: Peeyush Gupta 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Comment-Date: Mon, 29 Apr 2024 19:27:42 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


[jira] [Commented] (ASTERIXDB-3358) Indexnl hint with index names not working correctly

2024-04-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842135#comment-17842135
 ] 

ASF subversion and git services commented on ASTERIXDB-3358:


Commit 6d124481c4238b59b754eec83811c28596bb6d29 in asterixdb's branch 
refs/heads/master from Vijay Sarathy
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=6d124481c4 ]

[ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly

Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Vijay Sarathy 
Reviewed-by: Ali Alsuliman 


> Indexnl hint with index names not working correctly
> ---
>
> Key: ASTERIXDB-3358
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-3358
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: COMP - Compiler
>Reporter: Vijay Sarathy
>Assignee: Vijay Sarathy
>Priority: Minor
>  Labels: triaged
>
> For the following queries, no warning is issued when an invalid index is 
> specified with the indexnl hint. The correct behavior is that a warning 
> should be issued, the hint should be ignored, and all possible join methods 
> should be explored.
> Create the following indexes.
> Create index R_idx_a on R(a:int);
> Create index R_idx_b on R(b:int);
> The following queries (with an invalid index in the indexnl hint) do not 
> issue a warning about the invalid index and the hint is honored.
> select * from R, S where R.a /*+ indexnl (idx_c) */ = tobigint(S.a)
> select * from R, S where R.a /*+ indexnl (idx_a, idx_c) */ = tobigint(S.a)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...

2024-04-29 Thread AsterixDB Code Review
>From Ali Alsuliman :

Attention is currently required from: Vijay Sarathy.
Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 )

Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not 
working correctly
..


Patch Set 16: Code-Review+2


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 16
Gerrit-Owner: Vijay Sarathy 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Vijay Sarathy 
Gerrit-Attention: Vijay Sarathy 
Gerrit-Comment-Date: Mon, 29 Apr 2024 18:40:42 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..


Patch Set 14: Contrib-2

Analytics Compatibility Compilation Failed
https://cbjenkins.page.link/mQHBHZqvKdY5kgXJA : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I87813c761f5024742fb8658360166613d01f127d
Gerrit-Change-Number: 17620
Gerrit-PatchSet: 14
Gerrit-Owner: Sushrut Borkar 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Ian Maxon 
Gerrit-Attention: Sushrut Borkar 
Gerrit-Attention: Glenn Galvizo 
Gerrit-Comment-Date: Mon, 29 Apr 2024 18:36:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
>From Glenn Galvizo :

Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Glenn Galvizo has uploaded a new patch set (#14) to the change originally 
created by Sushrut Borkar. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..

[ASTERIXDB-3183][COMP] Add query plan cache

- user model changes: yes
- storage format changes: no
- interface changes: yes

Details:

The query plan cache reduces compile times by storing job specs for
old queries. This allows skipping the rewriting and compilation
stages of repeated queries.

Change-Id: I87813c761f5024742fb8658360166613d01f127d
---
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheKey.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheValue.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.08.regexadm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/annotation/ExcludeFromSelectStarAnnotation.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.001.regexjson
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.06.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql-sugar/avg_mixed/avg_mixed.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCacheTest.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.004.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.03.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cache-residency/cache-residency.001.regexjson
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.04.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.006.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.003.post.http
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCache.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/request-param-validation-400-BAD/request-param-validation-400-BAD.01.regexjson
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CcApplicationContext.java
M 
asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestCaseContext.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.05.regexadm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppAstPrintVisitor.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/ExternalSubpathAnnotation.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponseMetrics.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.004.delete.http
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/clear/ClearCachePredicate.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cache-residency/cache-residency.002.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.006.delete.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.04.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.007.delete.http
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
A 

Change in asterixdb[master]: WIP: make dmls cancellable

2024-04-29 Thread AsterixDB Code Review
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 )

Change subject: WIP: make dmls cancellable
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/Q9EiHiQNXoKiKWHe7 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0
Gerrit-Change-Number: 18257
Gerrit-PatchSet: 1
Gerrit-Owner: Peeyush Gupta 
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins 
Gerrit-Comment-Date: Mon, 29 Apr 2024 18:18:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in asterixdb[master]: WIP: make dmls cancellable

2024-04-29 Thread AsterixDB Code Review
>From Peeyush Gupta :

Peeyush Gupta has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18257 )


Change subject: WIP: make dmls cancellable
..

WIP: make dmls cancellable

Change-Id: I16410ab9353c24597f77ab38ce06996fc5dfacd0
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/atomic_statements/AtomicStatementsCancellationTest.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
5 files changed, 164 insertions(+), 7 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/57/18257/1

diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
index 0436ea8..84a6488 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/BaseClientRequest.java
@@ -54,9 +54,9 @@
 if (complete) {
 return;
 }
-complete();
-state = State.CANCELLED;
 if (cancellable) {
+complete();
+state = State.CANCELLED;
 doCancel(appCtx);
 }
 }
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
index 165cc75..c5c4822 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
@@ -476,7 +476,7 @@
 return;
 }
 }
-LOGGER.warn(() -> "handleException: unexpected exception: " + 
param.toString(), t);
+LOGGER.warn(() -> "handleException: unexpected exception: " + "error", 
t);
 executionState.setStatus(ResultStatus.FATAL, 
HttpResponseStatus.INTERNAL_SERVER_ERROR);
 }

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
index 34648dd..8e0a176 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
@@ -4009,10 +4009,12 @@
 final ClientRequest clientRequest =
 (ClientRequest) 
requestTracker.get(requestParameters.getRequestReference().getUuid());
 clientRequest.setJobId(jobId);
+clientRequest.markCancellable();
 String nameBefore = Thread.currentThread().getName();
 try {
 Thread.currentThread().setName(nameBefore + " : 
WaitForCompletionForJobId: " + jobId);
 hcc.waitForCompletion(jobId);
+ensureNotCancelled(clientRequest);
 } finally {
 Thread.currentThread().setName(nameBefore);
 }
@@ -4151,7 +4153,7 @@
 ClientRequest clientRequest = (ClientRequest) 
requestTracker.get(reqParams.getRequestReference().getUuid());
 if (stmtInsertUpsert.getReturnExpression() != null) {
 deliverResult(hcc, resultSet, compiler, metadataProvider, locker, 
resultDelivery, outMetadata, stats,
-reqParams, false, stmt, clientRequest);
+reqParams, true, stmt, clientRequest);
 } else {
 locker.lock();
 JobId jobId = null;
@@ -4176,6 +4178,7 @@
 }
 jobId = JobUtils.runJob(hcc, jobSpec, jobFlags, false);
 clientRequest.setJobId(jobId);
+clientRequest.markCancellable();
 String nameBefore = Thread.currentThread().getName();
 try {
 Thread.currentThread().setName(nameBefore + " : 
WaitForCompletionForJobId: " + jobId);
diff --git 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/atomic_statements/AtomicStatementsCancellationTest.java
 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/atomic_statements/AtomicStatementsCancellationTest.java
new file mode 100644
index 000..ce0a24d
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/atomic_statements/AtomicStatementsCancellationTest.java
@@ -0,0 +1,145 @@

Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..


Patch Set 13: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/396/ : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I87813c761f5024742fb8658360166613d01f127d
Gerrit-Change-Number: 17620
Gerrit-PatchSet: 13
Gerrit-Owner: Sushrut Borkar 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Ian Maxon 
Gerrit-Attention: Sushrut Borkar 
Gerrit-Attention: Glenn Galvizo 
Gerrit-Comment-Date: Mon, 29 Apr 2024 17:15:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..


Patch Set 13: Contrib-2

Analytics Compatibility Compilation Failed
https://cbjenkins.page.link/Wbgp8a2mH2eYdRNQ8 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I87813c761f5024742fb8658360166613d01f127d
Gerrit-Change-Number: 17620
Gerrit-PatchSet: 13
Gerrit-Owner: Sushrut Borkar 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Ian Maxon 
Gerrit-Attention: Sushrut Borkar 
Gerrit-Attention: Glenn Galvizo 
Gerrit-Comment-Date: Mon, 29 Apr 2024 16:36:30 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [WIP] Support COPY TO in parquet

2024-04-29 Thread AsterixDB Code Review
>From :

Attention is currently required from: Wail Alkowaileet.
preetham.polupar...@couchbase.com has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209 )

Change subject: [WIP] Support COPY TO in parquet
..


Patch Set 30: Code-Review+1

(9 comments)

File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/TextualExternalFileParquetPrinter.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/cef9fa21_84ee7652
PS19, Line 56: TextualExternalFileParquetPrinter
> Not Textual. […]
Done


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/TextualExternalFileParquetPrinterFactory.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/66faa736_908e7b05
PS19, Line 26: TextualExternalFileParquetPrinterFactory
> Rename to ParquetExternalFilePrinterFactory
Done


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/0869cd9e_18178b29
PS19, Line 32: Object
> Change it to IAType and make it private and final, Do the same whenever the 
> typeInfo is Object.
Done


File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/provider/ExternalWriterProvider.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/2fa552da_da260feb
PS19, Line 132: sourceType
> Cast to IAType
Done


File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/FieldNamesDictionary.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/7a5d3f32_0eaa401e
PS19, Line 42: getOrCreateFieldNameIndex
> Similar to the original implementation, we might have collision. […]
Done


File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/ParquetRecordLazyVisitor.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/4e90fb28_12646301
PS4, Line 78: switch (parentType) {
> Parent should prepare the consumer. […]
Done


File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/ParquetRecordLazyVisitor.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/f3f3614f_98ff1b30
PS19, Line 52:if (type.getTypeTag() != ATypeTag.OBJECT) {
 : throw new RuntimeException("Type Unsupported for 
parquet printing");
 : }
> This should be done at ExternalWriterProvider to fail early. […]
129 = Some of the tuples do not agree with the given schema
Errors out with this message.


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/343aef6f_3014f21a
PS19, Line 67: GroupType groupType = (GroupType) type
> What if type is not a group type? This could happen if the declared schema 
> does not conform the actu […]
129 = Some of the tuples do not agree with the given schema
Errors out with this message.


File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/ParquetRecordVisitorUtils.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209/comment/a99d0134_caa6ff18
PS19, Line 139: switch (primitiveTypeName) {
  : case INT64:
  : recordConsumer.addLong(bigIntValue);
  : break;
  : case FLOAT:
  : recordConsumer.addFloat(bigIntValue);
  : break;
  : case DOUBLE:
  : recordConsumer.addDouble(bigIntValue);
  : break;
  : case INT32:
  : case BOOLEAN:
  : case BINARY:
  : case FIXED_LEN_BYTE_ARRAY:
  : case INT96:
  : default:
  : throw new HyracksDataException(
  : "Typecast impossible from " + 
typeTag + " to " + primitiveTypeName);
  : }
> Let's extract this to a function and use for all integer variants (byte, 
> short, int, and long) […]
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I40dc16969e66af09cde04b460f441af666b39d51
Gerrit-Change-Number: 18209
Gerrit-PatchSet: 30
Gerrit-Owner: preetham.polupar...@couchbase.com
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: preetham.polupar...@couchbase.com
Gerrit-CC: Wail Alkowaileet 
Gerrit-Attention: Wail Alkowaileet 
Gerrit-Comment-Date: Mon, 29 Apr 2024 16:31:39 +
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-3183][COMP] Add query plan cache

2024-04-29 Thread AsterixDB Code Review
>From Glenn Galvizo :

Attention is currently required from: Sushrut Borkar, Glenn Galvizo.
Glenn Galvizo has uploaded a new patch set (#13) to the change originally 
created by Sushrut Borkar. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )

Change subject: [ASTERIXDB-3183][COMP] Add query plan cache
..

[ASTERIXDB-3183][COMP] Add query plan cache

- user model changes: yes
- storage format changes: no
- interface changes: yes

Details:

The query plan cache reduces compile times by storing job specs for
old queries. This allows skipping the rewriting and compilation
stages of repeated queries.

Change-Id: I87813c761f5024742fb8658360166613d01f127d
---
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheKey.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCacheValue.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.08.regexadm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/annotation/ExcludeFromSelectStarAnnotation.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.001.regexjson
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.06.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql-sugar/avg_mixed/avg_mixed.5.query.sqlpp
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCacheTest.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.004.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.03.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cache-residency/cache-residency.001.regexjson
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/warnings/warnings-limit/warnings-limit.04.regexadm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/plan_cache_clear/plan_cache_clear.006.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.003.post.http
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCache.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/request-param-validation-400-BAD/request-param-validation-400-BAD.01.regexjson
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CcApplicationContext.java
M 
asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestCaseContext.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.05.regexadm
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppAstPrintVisitor.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/ExternalSubpathAnnotation.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponseMetrics.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.004.delete.http
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/clear/ClearCachePredicate.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cache-residency/cache-residency.002.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.006.delete.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/warnings/warnings-limit/warnings-limit.04.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/plan_cache_clear/plan_cache_clear.007.delete.http
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
A 

Change in asterixdb[master]: [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching

2024-04-29 Thread AsterixDB Code Review
>From Wail Alkowaileet :

Attention is currently required from: Murtadha Hubail.
Wail Alkowaileet has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255 )

Change subject: [ASTERIXDB-3389][STO] Prep. columnar datasets for disk caching
..


Patch Set 2: Code-Review+1


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18255
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iababcc5fc1d4e5e2de36f9b26c3f86ffabfb4e54
Gerrit-Change-Number: 18255
Gerrit-PatchSet: 2
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-Attention: Murtadha Hubail 
Gerrit-Comment-Date: Mon, 29 Apr 2024 16:02:56 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [WIP] Support COPY TO in parquet

2024-04-29 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: preetham.polupar...@couchbase.com.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209 )

Change subject: [WIP] Support COPY TO in parquet
..


Patch Set 30: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/395/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I40dc16969e66af09cde04b460f441af666b39d51
Gerrit-Change-Number: 18209
Gerrit-PatchSet: 30
Gerrit-Owner: preetham.polupar...@couchbase.com
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Wail Alkowaileet 
Gerrit-Attention: preetham.polupar...@couchbase.com
Gerrit-Comment-Date: Mon, 29 Apr 2024 12:33:09 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [WIP] Support COPY TO in parquet

2024-04-29 Thread AsterixDB Code Review
>From :

Attention is currently required from: preetham.polupar...@couchbase.com.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209

to look at the new patch set (#30).

Change subject: [WIP] Support COPY TO in parquet
..

[WIP] Support COPY TO in parquet

Change-Id: I40dc16969e66af09cde04b460f441af666b39d51
---
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinter.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/ObjectWriteSupport.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/provider/ExternalWriterProvider.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-tweet/parquet-tweet.02.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-tweet/parquet-tweet.03.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-tweet/parquet-tweet.04.ddl.sqlpp
M asterixdb/asterix-om/pom.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-simple/parquet-simple.03.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/copy-to/parquet-cover-data-types/parquet-cover-data-types.05.adm
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/ParquetRecordVisitorUtils.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-simple/parquet-simple.01.ddl.sqlpp
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/HDFSUtils.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/WriterValidationUtil.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/negative/parquet-error-checks/parquet-error-checks.02.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-tweet/parquet-tweet.01.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/negative/parquet-error-checks/parquet-error-checks.03.update.sqlpp
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/FieldNamesDictionary.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-cover-data-types/parquet-cover-data-types.01.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-cover-data-types/parquet-cover-data-types.02.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-cover-data-types/parquet-cover-data-types.03.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/testsuite_external_dataset_s3.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/negative/parquet-error-checks/parquet-error-checks.05.update.sqlpp
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/negative/parquet-error-checks/parquet-error-checks.04.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/negative/parquet-error-checks/parquet-error-checks.06.update.sqlpp
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/AsterixParquetWriter.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/negative/parquet-error-checks/parquet-error-checks.01.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-simple/parquet-simple.04.query.sqlpp
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-cover-data-types/parquet-cover-data-types.04.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/copy-to/parquet-simple/parquet-simple.04.adm
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-simple/parquet-simple.02.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/copy-to/parquet-tweet/parquet-tweet.05.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-cover-data-types/parquet-cover-data-types.05.query.sqlpp
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinterFactory.java
A 

Change in asterixdb[master]: [WIP] Support COPY TO in parquet

2024-04-29 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: preetham.polupar...@couchbase.com.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209 )

Change subject: [WIP] Support COPY TO in parquet
..


Patch Set 29: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/394/ : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I40dc16969e66af09cde04b460f441af666b39d51
Gerrit-Change-Number: 18209
Gerrit-PatchSet: 29
Gerrit-Owner: preetham.polupar...@couchbase.com
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Wail Alkowaileet 
Gerrit-Attention: preetham.polupar...@couchbase.com
Gerrit-Comment-Date: Mon, 29 Apr 2024 11:35:40 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [WIP] Support COPY TO in parquet

2024-04-29 Thread AsterixDB Code Review
>From :

Attention is currently required from: preetham.polupar...@couchbase.com.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18209

to look at the new patch set (#29).

Change subject: [WIP] Support COPY TO in parquet
..

[WIP] Support COPY TO in parquet

Change-Id: I40dc16969e66af09cde04b460f441af666b39d51
---
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinter.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/ObjectWriteSupport.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/provider/ExternalWriterProvider.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-tweet/parquet-tweet.02.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-tweet/parquet-tweet.03.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-tweet/parquet-tweet.04.ddl.sqlpp
M asterixdb/asterix-om/pom.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-simple/parquet-simple.03.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/copy-to/parquet-cover-data-types/parquet-cover-data-types.05.adm
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/ParquetRecordVisitorUtils.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-simple/parquet-simple.01.ddl.sqlpp
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/HDFSUtils.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/WriterValidationUtil.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/negative/parquet-error-checks/parquet-error-checks.02.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-tweet/parquet-tweet.01.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/negative/parquet-error-checks/parquet-error-checks.03.update.sqlpp
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/FieldNamesDictionary.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-cover-data-types/parquet-cover-data-types.01.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-cover-data-types/parquet-cover-data-types.02.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-cover-data-types/parquet-cover-data-types.03.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/testsuite_external_dataset_s3.xml
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/negative/parquet-error-checks/parquet-error-checks.05.update.sqlpp
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/negative/parquet-error-checks/parquet-error-checks.04.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/negative/parquet-error-checks/parquet-error-checks.06.update.sqlpp
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/parquet/AsterixParquetWriter.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/negative/parquet-error-checks/parquet-error-checks.01.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-simple/parquet-simple.04.query.sqlpp
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-cover-data-types/parquet-cover-data-types.04.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/copy-to/parquet-simple/parquet-simple.04.adm
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-simple/parquet-simple.02.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/copy-to/parquet-tweet/parquet-tweet.05.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/copy-to/parquet-cover-data-types/parquet-cover-data-types.05.query.sqlpp
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
A 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/ParquetExternalFilePrinterFactory.java
A