Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Taewoo Kim has submitted this change and it was merged.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it extends
   AQLExpressionToPlanTranslator. This makes this class now follows
   the current translation logic and it doesn't have to manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1434
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
10 files changed, 307 insertions(+), 3,059 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified

Objections:
  Jenkins: Violations found



diff --git a/asterixdb/asterix-algebra/pom.xml 
b/asterixdb/asterix-algebra/pom.xml
index 5a723b3..aa0ea27 100644
--- a/asterixdb/asterix-algebra/pom.xml
+++ b/asterixdb/asterix-algebra/pom.xml
@@ -40,6 +40,28 @@
   
 
   
+org.apache.asterix
+asterix-grammar-extension-maven-plugin
+${project.version}
+
+  ${project.basedir}
+  ../asterix-lang-aql/src/main/javacc/AQL.jj
+  src/main/javacc/AQLPlusExtension.jj
+  target/generated-resources/javacc/AQLPlus.jj
+  public
+  AQLPlusParser
+  org.apache.asterix.aqlplus.parser
+
+
+  
+generate-sources
+
+  grammarix
+
+  
+
+  
+  
 org.codehaus.mojo
 javacc-maven-plugin
 2.6
@@ -51,6 +73,26 @@
 
 
   false
+  
target/generated-resources/javacc
+
+  
+
+  
+  
+org.codehaus.mojo
+build-helper-maven-plugin
+1.9
+
+  
+add-source
+generate-sources
+
+  add-source
+
+
+  
+target/generated-sources/javacc/
+  
 
   
 
diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
index 67c33d4..f3f5581 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
@@ -261,8 +261,7 @@
 }
 // The translator will compile metadata internally. Run this 
compilation
 // under the same transaction id as the "outer" compilation.
-AqlPlusExpressionToPlanTranslator translator = new 
AqlPlusExpressionToPlanTranslator(
-metadataProvider.getJobId(), metadataProvider, counter, null, 
null);
+AqlPlusExpressionToPlanTranslator translator = new 
AqlPlusExpressionToPlanTranslator(metadataProvider, counter);
 context.setVarCounter(counter.get());
 
 LogicalOperatorDeepCopyWithNewVariablesVisitor deepCopyVisitor = new 
LogicalOperatorDeepCopyWithNewVariablesVisitor(
diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
index 110c2b7..62b71df 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
@@ -40,6 +40,7 @@
 import 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 17: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 17:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1434/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java:

PS17, Line 187: .
> Why do you need this new constructor?
In FuzzyJoinRule file, it has its counter and increases it after creating this 
PlanTranslator. So, the PlanTranslator should be able to see the new counter 
value. So, either we need to create setVarCounter() or declare a new 
constructor. I think this new constructor might be better.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 17:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1434/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java:

PS17, Line 187: .
Why do you need this new constructor?

The existing constructor + getVarCounter() cannot serve your need?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 17: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1867/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 17: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/525/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 17:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1867/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 17:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/525/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4265/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 15: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1850/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 15:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1850/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 15:

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1844/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 15:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1844/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 15:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1821/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 15: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/489/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 15:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/489/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 14: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/454/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 14:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/454/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 14: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1776/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 14:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1776/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 14: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/443/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 14:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/443/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 14:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4148/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1434

to look at the new patch set (#14).

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..

AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it extends
   AQLExpressionToPlanTranslator. This makes this class now follows
   the current translation logic and it doesn't have to manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
10 files changed, 307 insertions(+), 3,059 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1434/14
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 13: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1744/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 13: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/414/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 13:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1744/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4107/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 12: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1738/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 12: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/409/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 12:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/409/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 12:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1738/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 12:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4096/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1434

to look at the new patch set (#12).

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..

AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it now extends
   AQLExpressionToPlanTranslator. This class now follows
   the current translation logic and it doesn't have to be manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
10 files changed, 307 insertions(+), 3,059 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1434/12
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 11: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1731/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 11: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/402/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 11:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/402/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 11:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1731/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4075/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1434

to look at the new patch set (#11).

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..

AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it now extends
   AQLExpressionToPlanTranslator. This class now follows
   the current translation logic and it doesn't have to be manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
10 files changed, 307 insertions(+), 3,059 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1434/11
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 10: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1721/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 10:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/395/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 10:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1721/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4068/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1434

to look at the new patch set (#10).

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..

AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it now extends
   AQLExpressionToPlanTranslator. This class now follows
   the current translation logic and it doesn't have to be manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
10 files changed, 307 insertions(+), 3,059 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1434/10
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 9: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1703/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 9: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/380/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1703/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 9:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/380/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4043/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1434

to look at the new patch set (#9).

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..

AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it now extends
   AQLExpressionToPlanTranslator. This class now follows
   the current translation logic and it doesn't have to be manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
10 files changed, 307 insertions(+), 3,059 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1434/9
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 8: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1681/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 8:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1681/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 8: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/358/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 8:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/358/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4014/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1434

to look at the new patch set (#8).

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..

AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it now extends
   AQLExpressionToPlanTranslator. This class now follows
   the current translation logic and it doesn't have to be manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
10 files changed, 307 insertions(+), 3,059 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1434/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 7: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1660/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 7:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1660/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 7: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1658/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 7: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/341/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 7:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1658/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 7:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/341/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3992/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1434

to look at the new patch set (#7).

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..

AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it now extends
   AQLExpressionToPlanTranslator. This class now follows
   the current translation logic and it doesn't have to be manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
10 files changed, 307 insertions(+), 3,059 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1434/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1434

to look at the new patch set (#6).

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..

AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it now extends
   AQLExpressionToPlanTranslator. This class now follows
   the current translation logic and it doesn't have to be manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
10 files changed, 307 insertions(+), 3,059 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1434/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1640/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 5: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/325/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1640/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 5:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/325/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3969/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1434

to look at the new patch set (#5).

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..

AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it extends
   AQLExpressionToPlanTranslator. This makes this class now follows
   the current translation logic and it doesn't have to manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
10 files changed, 307 insertions(+), 3,059 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1434/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1634/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 4:

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1630/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 4: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1626/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1627/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1627/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1626/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 4: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1623/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 4: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/314/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1623/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/314/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3955/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1434

to look at the new patch set (#4).

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..

AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it extends
   AQLExpressionToPlanTranslator. This makes this class now follows
   the current translation logic and it doesn't have to manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
10 files changed, 307 insertions(+), 3,059 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1434/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 3: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/301/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1608/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3941/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1434

to look at the new patch set (#3).

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..

AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it extends
   AQLExpressionToPlanTranslator. This makes this class now follows
   the current translation logic and it doesn't have to manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
8 files changed, 302 insertions(+), 3,060 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1434/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1590/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 2: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1588/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1588/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 2: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/284/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/284/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1434

to look at the new patch set (#2).

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..

AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator

 - Apply a systematic way of generating AQL+ grammar from AQL grammar instead of
   having a separate grammar file and updating it by hand.
 - Refactor AQLPlusExpressionToPlanTranslator so that it extends
   AQLExpressionToPlanTranslator. This makes this class now follows
   the current translation logic and it doesn't have to manually updated for
   AQL expressions.

Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
---
M asterixdb/asterix-algebra/pom.xml
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
D asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
A asterixdb/asterix-algebra/src/main/javacc/AQLPlusExtension.jj
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
8 files changed, 302 insertions(+), 3,060 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/34/1434/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3914/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 1: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/276/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1578/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/276/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1578/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 2: AQL+ grammar generation and AQLPlusEx...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 2: AQL+ grammar generation and 
AQLPlusExpressionToPlanTranslator
..


Patch Set 1: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1573/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1434
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444dbf4f615c23ccd69a5e4bb1ead300d0a81451
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No