Change in asterixdb[master]: Modularize feed adaptors

[Xikui Wang (Code Review)]

Xikui Wang has abandoned this change.

Change subject: Modularize feed adaptors
..


Abandoned

useful parts are picked up in another patch. The separate package for 
twitter/rss feeds is delayed for future better ideas.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 

Change in asterixdb[master]: Modularize feed adaptors

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 9: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 9: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1714/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 9: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/390/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 9:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/390/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1714/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Xikui Wang (Code Review)]

Xikui Wang has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 9:

@Mike B, The further modularization comment turns out to be very useful! Quite 
some knowledge about Maven is gained from this process.. The quirky part about 
this patch is, I can't really have adaptor related dependencies resides at the 
villain module, because that will cause unused lib issue for the villain test 
framework part. So I duplicated some of them in each of the twitter-adaptor 
module and rss-adaptor module.

I guess the right answer would be use the AQLTestExcution load scripts from 
villain package and add villain-module as its dependency. Currently, These 
executionTests are included in asterix-app which will cause recursive 
dependency issue... I guess there is no better solution for that now?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4058/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1430

to look at the new patch set (#9).

Change subject: Modularize feed adaptors
..

Modularize feed adaptors

1. Load adaptors from class-path.
2. Move rss adaptors/parsers to the new module, as well as related test
cases. All future parsers/adaptors that depend on various libraries should
be placed in this new module.

Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
---
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java
M 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/DatasourceFactoryProviderTest.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/RecordWithPKTestReaderFactory.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/kv/KVTestReaderFactory.java
D 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserFactoryProviderLoadParserTest.java
A asterixdb/asterix-villain/adaptor-rss/pom.xml
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/parser/RSSParser.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/parser/RSSParserFactory.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/reader/RSSRecordReader.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/reader/RSSRecordReaderFactory.java
A 
asterixdb/asterix-villain/adaptor-rss/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-villain/adaptor-rss/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A asterixdb/asterix-villain/adaptor-twitter/pom.xml
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/parser/TweetParser.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/parser/TweetParserFactory.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterPullRecordReader.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterPushRecordReader.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterRecordReaderFactory.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/util/TwitterUtil.java
A 
asterixdb/asterix-villain/adaptor-twitter/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-villain/adaptor-twitter/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A asterixdb/asterix-villain/pom.xml
A asterixdb/asterix-villain/villain-test-framework/pom.xml
A 
asterixdb/asterix-villain/villain-test-framework/src/test/java/org/apache/asterix/villain/test/VillainExecutionTest.java
A 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/only.xml
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.1.ddl.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.2.update.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/twitter-feed/twitter-feed.1.ddl.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/twitter-feed/twitter-feed.2.update.aql
A 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/testsuite.xml
M 

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 8: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1710/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 8:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1710/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 8: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/386/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 8:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/386/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4052/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1430

to look at the new patch set (#8).

Change subject: Modularize feed adaptors
..

Modularize feed adaptors

1. Load adaptors from class-path.
2. Move rss adaptors/parsers to the new module, as well as related test
cases. All future parsers/adaptors that depend on various libraries should
be placed in this new module.

Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
---
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java
M 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/DatasourceFactoryProviderTest.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/RecordWithPKTestReaderFactory.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/kv/KVTestReaderFactory.java
D 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserFactoryProviderLoadParserTest.java
A asterixdb/asterix-villain/adaptor-rss/pom.xml
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/parser/RSSParser.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/parser/RSSParserFactory.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/reader/RSSRecordReader.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/reader/RSSRecordReaderFactory.java
A 
asterixdb/asterix-villain/adaptor-rss/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-villain/adaptor-rss/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A asterixdb/asterix-villain/adaptor-twitter/pom.xml
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/parser/TweetParser.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/parser/TweetParserFactory.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterPullRecordReader.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterPushRecordReader.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterRecordReaderFactory.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/util/TwitterUtil.java
A 
asterixdb/asterix-villain/adaptor-twitter/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-villain/adaptor-twitter/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A asterixdb/asterix-villain/pom.xml
A asterixdb/asterix-villain/villain-test-framework/pom.xml
A 
asterixdb/asterix-villain/villain-test-framework/src/test/java/org/apache/asterix/villain/test/VillainExecutionTest.java
A 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/only.xml
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.1.ddl.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.2.update.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/twitter-feed/twitter-feed.1.ddl.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/twitter-feed/twitter-feed.2.update.aql
A 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/testsuite.xml
M 

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4051/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1430

to look at the new patch set (#7).

Change subject: Modularize feed adaptors
..

Modularize feed adaptors

1. Load adaptors from class-path.
2. Move rss adaptors/parsers to the new module, as well as related test
cases. All future parsers/adaptors that depend on various libraries should
be placed in this new module.

Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
---
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java
M 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/DatasourceFactoryProviderTest.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/RecordWithPKTestReaderFactory.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/kv/KVTestReaderFactory.java
D 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserFactoryProviderLoadParserTest.java
A asterixdb/asterix-villain/adaptor-rss/pom.xml
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/parser/RSSParser.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/parser/RSSParserFactory.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/reader/RSSRecordReader.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/reader/RSSRecordReaderFactory.java
A 
asterixdb/asterix-villain/adaptor-rss/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-villain/adaptor-rss/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A asterixdb/asterix-villain/adaptor-twitter/pom.xml
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/parser/TweetParser.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/parser/TweetParserFactory.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterPullRecordReader.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterPushRecordReader.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterRecordReaderFactory.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/util/TwitterUtil.java
A 
asterixdb/asterix-villain/adaptor-twitter/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-villain/adaptor-twitter/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A asterixdb/asterix-villain/pom.xml
A asterixdb/asterix-villain/villain-test-framework/pom.xml
A 
asterixdb/asterix-villain/villain-test-framework/src/test/java/org/apache/asterix/villain/test/VillainExecutionTest.java
A 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/only.xml
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.1.ddl.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.2.update.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/twitter-feed/twitter-feed.1.ddl.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/twitter-feed/twitter-feed.2.update.aql
A 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/testsuite.xml
M 

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4050/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1430

to look at the new patch set (#6).

Change subject: Modularize feed adaptors
..

Modularize feed adaptors

1. Load adaptors from class-path.
2. Move rss adaptors/parsers to the new module, as well as related test
cases. All future parsers/adaptors that depend on various libraries should
be placed in this new module.

Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
---
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java
M 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/DatasourceFactoryProviderTest.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/RecordWithPKTestReaderFactory.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/kv/KVTestReaderFactory.java
D 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserFactoryProviderLoadParserTest.java
A asterixdb/asterix-villain/adaptor-rss/pom.xml
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/parser/RSSParser.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/parser/RSSParserFactory.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/reader/RSSRecordReader.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/reader/RSSRecordReaderFactory.java
A 
asterixdb/asterix-villain/adaptor-rss/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-villain/adaptor-rss/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A asterixdb/asterix-villain/adaptor-twitter/pom.xml
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/parser/TweetParser.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/parser/TweetParserFactory.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterPullRecordReader.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterPushRecordReader.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterRecordReaderFactory.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/util/TwitterUtil.java
A 
asterixdb/asterix-villain/adaptor-twitter/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-villain/adaptor-twitter/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A asterixdb/asterix-villain/pom.xml
A asterixdb/asterix-villain/villain-test-framework/pom.xml
A 
asterixdb/asterix-villain/villain-test-framework/src/test/java/org/apache/asterix/villain/test/VillainExecutionTest.java
A 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/only.xml
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.1.ddl.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.2.update.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/twitter-feed/twitter-feed.1.ddl.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/twitter-feed/twitter-feed.2.update.aql
A 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/testsuite.xml
M 

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4049/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1430

to look at the new patch set (#5).

Change subject: Modularize feed adaptors
..

Modularize feed adaptors

1. Load adaptors from class-path.
2. Move rss adaptors/parsers to the new module, as well as related test
cases. All future parsers/adaptors that depend on various libraries should
be placed in this new module.

Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
---
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java
M 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/DatasourceFactoryProviderTest.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/RecordWithPKTestReaderFactory.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/kv/KVTestReaderFactory.java
D 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserFactoryProviderLoadParserTest.java
A asterixdb/asterix-villain/adaptor-rss/pom.xml
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/parser/RSSParser.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/parser/RSSParserFactory.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/reader/RSSRecordReader.java
R 
asterixdb/asterix-villain/adaptor-rss/src/main/java/org/apache/asterix/villain/external/reader/RSSRecordReaderFactory.java
A 
asterixdb/asterix-villain/adaptor-rss/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-villain/adaptor-rss/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A asterixdb/asterix-villain/adaptor-twitter/pom.xml
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/parser/TweetParser.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/parser/TweetParserFactory.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterPullRecordReader.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterPushRecordReader.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/reader/TwitterRecordReaderFactory.java
R 
asterixdb/asterix-villain/adaptor-twitter/src/main/java/org/apache/asterix/villain/external/util/TwitterUtil.java
A 
asterixdb/asterix-villain/adaptor-twitter/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-villain/adaptor-twitter/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A asterixdb/asterix-villain/pom.xml
A asterixdb/asterix-villain/villain-test-framework/pom.xml
A 
asterixdb/asterix-villain/villain-test-framework/src/test/java/org/apache/asterix/villain/test/VillainExecutionTest.java
A 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/only.xml
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.1.ddl.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.2.update.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/twitter-feed/twitter-feed.1.ddl.aql
R 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/queries/feeds/twitter-feed/twitter-feed.2.update.aql
A 
asterixdb/asterix-villain/villain-test-framework/src/test/resources/runtimets/testsuite.xml
M 

Change in asterixdb[master]: Modularize feed adaptors

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 4:

(7 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1430/4/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java:

Line 235: return 
Collections.unmodifiableList(Arrays.asList(recordReaderNames));
Comments which apply to all of the impls:
- Should we just store the collection instead of the array, to avoid rebuilding 
it each time?
- Make it static final?
- Should this be a Set<> instead of a List<>?  Seems these are unique, if order 
matters, could use SortedSet<>?


https://asterix-gerrit.ics.uci.edu/#/c/1430/4/asterixdb/asterix-villain/pom.xml
File asterixdb/asterix-villain/pom.xml:

Line 84: 0.8.9-SNAPSHOT
Use ${project.version} here (same as other 0.8.9-SNAPSHOTs below)


Line 126: 0.2.18-SNAPSHOT
Use ${hyracks.version} here (same as other 0.2.18-SNAPSHOTs below)


Line 141: 1.2.17
I believe this version is already defined in depdendencyManagement, and should 
not be redefined here.  Please check the other deps with versions for the same. 
 (Not sure about Eclipse, but IDEA indicates in the IDE for this pom when the 
definition is being overridden)


https://asterix-gerrit.ics.uci.edu/#/c/1430/4/asterixdb/asterix-villain/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
File 
asterixdb/asterix-villain/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory:

Line 2: org.apache.asterix.villain.external.parser.rss.RSSParserFactory
These are both nice to make modular, but probably should each be in their own 
module, not combined into one.


https://asterix-gerrit.ics.uci.edu/#/c/1430/4/asterixdb/asterix-villain/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
File 
asterixdb/asterix-villain/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory:

Line 2: org.apache.asterix.villain.external.reader.rss.RSSRecordReaderFactory
These are both nice to make modular, but probably should each be in their own 
module, not combined into one.


https://asterix-gerrit.ics.uci.edu/#/c/1430/4/asterixdb/asterix-villain/src/test/resources/runtimets/testsuite.xml
File asterixdb/asterix-villain/src/test/resources/runtimets/testsuite.xml:

Line 26:  
All of these entity decls are unused here and should be removed.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1665/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 4: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/346/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/346/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1665/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3998/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Modularize feed adaptors
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3965/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Modularize feed adaptors

[Xikui Wang (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1430

to look at the new patch set (#3).

Change subject: Modularize feed adaptors
..

Modularize feed adaptors

1. Load adaptors from class-path.
2. Move rss adaptors/parsers to the new module, as well as related test
cases. All future parsers/adaptors that depend on various libraries should
be placed in this new module.

Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
---
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
M asterixdb/asterix-external-data/pom.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/Datatypes.java
M 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-external-data/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/DatasourceFactoryProviderTest.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/RecordWithPKTestReaderFactory.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/input/record/reader/kv/KVTestReaderFactory.java
D 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/ParserFactoryProviderLoadParserTest.java
A asterixdb/asterix-villain/pom.xml
R 
asterixdb/asterix-villain/src/main/java/org/apache/asterix/villain/external/parser/rss/RSSParser.java
R 
asterixdb/asterix-villain/src/main/java/org/apache/asterix/villain/external/parser/rss/RSSParserFactory.java
R 
asterixdb/asterix-villain/src/main/java/org/apache/asterix/villain/external/parser/twitter/TweetParser.java
R 
asterixdb/asterix-villain/src/main/java/org/apache/asterix/villain/external/parser/twitter/TweetParserFactory.java
R 
asterixdb/asterix-villain/src/main/java/org/apache/asterix/villain/external/reader/rss/RSSRecordReader.java
R 
asterixdb/asterix-villain/src/main/java/org/apache/asterix/villain/external/reader/rss/RSSRecordReaderFactory.java
R 
asterixdb/asterix-villain/src/main/java/org/apache/asterix/villain/external/reader/twitter/TwitterPullRecordReader.java
R 
asterixdb/asterix-villain/src/main/java/org/apache/asterix/villain/external/reader/twitter/TwitterPushRecordReader.java
R 
asterixdb/asterix-villain/src/main/java/org/apache/asterix/villain/external/reader/twitter/TwitterRecordReaderFactory.java
R 
asterixdb/asterix-villain/src/main/java/org/apache/asterix/villain/external/util/TwitterUtil.java
A 
asterixdb/asterix-villain/src/main/resources/META-INF/services/org.apache.asterix.external.api.IDataParserFactory
A 
asterixdb/asterix-villain/src/main/resources/META-INF/services/org.apache.asterix.external.api.IRecordReaderFactory
A 
asterixdb/asterix-villain/src/test/java/org/apache/asterix/villain/test/VillainExecutionTest.java
A asterixdb/asterix-villain/src/test/resources/runtimets/only.xml
R 
asterixdb/asterix-villain/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.1.ddl.aql
R 
asterixdb/asterix-villain/src/test/resources/runtimets/queries/feeds/revised-tweet-parser/revised-tweet-parser.2.update.aql
R 
asterixdb/asterix-villain/src/test/resources/runtimets/queries/feeds/twitter-feed/twitter-feed.1.ddl.aql
R 
asterixdb/asterix-villain/src/test/resources/runtimets/queries/feeds/twitter-feed/twitter-feed.2.update.aql
A asterixdb/asterix-villain/src/test/resources/runtimets/testsuite.xml
M asterixdb/pom.xml
36 files changed, 519 insertions(+), 193 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/1430/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1430
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang