date:20161019

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3083/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1057
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1573 Allow Extension of Rewrite Rules

Steven Jacobs has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1304

Change subject: ASTERIXDB-1573 Allow Extension of Rewrite Rules
..

ASTERIXDB-1573 Allow Extension of Rewrite Rules

Add IRuleSetFactory which builds rewrite Rule Set
Can be extended by Asterix Extensions

Change-Id: I7f59dea86b0ef4ee9d31b56766a97bd2b34ec02c
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/AqlCompilationProvider.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/ILangCompilationProvider.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/IRuleSetFactory.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/SqlppCompilationProvider.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
10 files changed, 153 insertions(+), 72 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/04/1304/1

diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/AqlCompilationProvider.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/AqlCompilationProvider.java
index 00affa8..af0ba73 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/AqlCompilationProvider.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/AqlCompilationProvider.java
@@ -49,4 +49,9 @@
 return new AqlExpressionToPlanTranslatorFactory();
 }
 
+@Override
+public IRuleSetFactory getRuleSetFactory() {
+return new DefaultRuleSetFactory();
+}
+
 }
diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
new file mode 100644
index 000..ccae63c
--- /dev/null
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.compiler.provider;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.asterix.optimizer.base.RuleCollections;
+import org.apache.hyracks.algebricks.common.utils.Pair;
+import 
org.apache.hyracks.algebricks.compiler.rewriter.rulecontrollers.SequentialFixpointRuleController;
+import 
org.apache.hyracks.algebricks.compiler.rewriter.rulecontrollers.SequentialOnceRuleController;
+import org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController;
+import org.apache.hyracks.algebricks.core.rewriter.base.IAlgebraicRewriteRule;
+
+public class DefaultRuleSetFactory implements IRuleSetFactory {
+
+@Override
+public List>> 
buildLogicalRewrites() {
+return buildLogical();
+}
+
+@Override
+public List>> 
buildPhysicalRewrites() {
+return buildPhysical();
+}
+
+public static List>> buildLogical() {
+List>> 
defaultLogicalRewrites = new ArrayList<>();
+SequentialFixpointRuleController seqCtrlNoDfs = new 
SequentialFixpointRuleController(false);
+SequentialFixpointRuleController seqCtrlFullDfs = new 
SequentialFixpointRuleController(true);
+SequentialOnceRuleController seqOnceCtrl = new 
SequentialOnceRuleController(true);
+defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl, 
RuleCollections.buildInitialTranslationRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl, 
RuleCollections.buildTypeInferenceRuleCollect

[jira] [Commented] (ASTERIXDB-1698) Secondary index doesn't follow the compaction policy


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589408#comment-15589408
 ] 

Jianfeng Jia commented on ASTERIXDB-1698:
-

Is there any way that I can align the 2nd indexes with the primary indexes by 
using the same filter? Since I'm using the filter feature, I would expect that 
(primary index, 2nd-index) share the same range which will be much efficient. 

The newly bulk-load one don't even have a filter on it...

> Secondary index doesn't follow the compaction policy
> 
>
> Key: ASTERIXDB-1698
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1698
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Storage
> Environment: master : 4819ea44723b87a68406d248782861cf6e5d3305
>Reporter: Jianfeng Jia
>Assignee: Ian Maxon
>
> Here is the ddl for the dataset:
> {code}
> create dataset ds_tweet(typeTweet) if not exists primary key id using 
> compaction policy prefix 
> (("max-mergable-component-size"="134217728"),("max-tolerance-component-count"="10"))
>  with filter on create_at ;
> create index text_idx if not exists on ds_tweet("text") type keyword;
> {code}
> In this case, I want to create a smaller component around 128M. During the 
> data ingestion phase, it works well, and the size of each text_idx component 
> is also small (~80M each). I assume it also followed the component size 
> constraint? 
> After ingestion, I found that I needed to build another index, 
> {code}
> create index time_idx if not exists on ds_tweet(create_at) type btree;
> {code}
> When it finished, I found that this time_idx didn't follow the constraint and 
> ended up with one giant 1.2G component on each partition. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1573 Allow Extension of Rewrite Rules

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1573 Allow Extension of Rewrite Rules
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3084/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1304
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f59dea86b0ef4ee9d31b56766a97bd2b34ec02c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#7).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
R asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorFactory.java
A asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
R asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.2.ddl.aql

Change in asterixdb-bad[master]: Updated to match code changes to asterix

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 7:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/26/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...

Hello Michael Blow, Preston Carman, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1057

to look at the new patch set (#17).

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
..

ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure function calls

This fix makes it so that nonpure functions are called in
the same place and with the same number of executions
as specified by the user in the query. This also means
that indexes cannot be used for queries that compare
with a nonpure call that is made on a per-record basis.
Added optimizer tests
Change-Id: I2dec322b30835625430c06acd7626d902bada137
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IOptimizableFuncExpr.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableFuncExpr.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/RTreeAccessMethod.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/global-datetime-no-index.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/global-datetime-use-index-return-time.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/global-datetime-use-index.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/keep-datetime-local.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/local-datetime-ignore-index.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/local-datetime-no-index.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/maintain-nonpure-location-in-join-cannot-index.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/query-ASTERIXDB-1608.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index/btree-datetime-02.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/global-datetime-no-index.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/global-datetime-use-index-return-time.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/global-datetime-use-index.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/keep-datetime-local.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/local-datetime-ignore-index.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/local-datetime-no-index.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/maintain-nonpure-location-in-join-cannot-index.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/query-ASTERIXDB-1608.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/nonpure/global-datetime-use-index/global-datetime-use-index.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/nonpure/global-datetime-use-index/global-datetime-use-index.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/nonpure/global-datetime-use-index/global-datetime-use-index.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/nonpure/local-datetime-ignore-index/local-datetime-ignore-index.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/nonpure/local-datetime-ignore-index/local-datetime-ignore-index.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/nonpure/local-datetime-ignore-index/local-datetime-ignore-index.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/nonpure/global-datetime-use-index/global-datetime-use-index.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/nonpure/local-datetim

[jira] [Commented] (ASTERIXDB-1695) More entities in the default dataverse

2016-10-19 Thread Steven Jacobs (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589421#comment-15589421
 ] 

Steven Jacobs commented on ASTERIXDB-1695:
--

I think we have seen a similar bug in the BAD extension. Can you make sure this 
covers extension metadata as well?

> More entities in the default dataverse
> --
>
> Key: ASTERIXDB-1695
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1695
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Yingyi Bu
>Assignee: Abdullah Alamoudi
>
> The following query works fine.
> {noformat}
> DROP function foo if exists;
> CREATE function foo(){
>   1
> }
> SELECT Default.foo();
> {noformat}
> But the next one doesn't work:
> {noformat}
> DROP function foo if exists;
> CREATE function foo(){
>   1
> }
> SELECT foo();
> {noformat}
> I got this error message:
> "msg": "function null.foo@0 is not defined",
> I'm guessing that it is related to the default dataverse change.
> I guess we need to verify all metadata entities can work under the default 
> dataverse.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
..


Patch Set 17:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1057
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3085/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1057
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1573 Allow Extension of Rewrite Rules

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1573 Allow Extension of Rewrite Rules
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/978/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1304
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f59dea86b0ef4ee9d31b56766a97bd2b34ec02c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

[jira] [Created] (ASTERIXDB-1699) Inverted Index fail to match the keyword

Jianfeng Jia created ASTERIXDB-1699:
---

 Summary: Inverted Index fail to match the keyword
 Key: ASTERIXDB-1699
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1699
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: Storage
 Environment: master : 4819ea44723b87a68406d248782861cf6e5d3305
Reporter: Jianfeng Jia
Assignee: Ian Maxon


Not very clear how to reproduce it on a smaller dataset. Here is the symptom: 

If I run the following query
{code}
for $t in dataset twitter.ds_tweet

where $t.'create_at' >= datetime('2016-10-19T00:00:47.473Z') and $t.'create_at' 
< datetime('2016-10-19T00:01:47.473Z') 
and  /* +skip-index */ similarity-jaccard(word-tokens($t.'text'), 
word-tokens('sleep')) > 0.0
return $t.text

{code}

It will return some results
{code}
"No point in going to sleep now lol"
"Can't sleep"
"TL Sleep ��"
"i can't sleep man"
"Blazed and I still can't sleep fac.."
"When you're proud of yourself for going to bed in time to get 6 hours of sleep 
#CollegeLyfeAmIRightIAmIt'sSoCrazyLol"
"I would be sleep rn but have to lurk bc I'm no sucka & bc the fan isn't 
working��"
"Since I can't sleep �� https://t.co/ALZE4psIqP";
"Wish I Could Sleep"
"Of course when I go to lay down finally, I am not tired. To sleep or not to 
sleep?? That's the real question."
{code}

If I'm using index

{code}
for $t in dataset twitter.ds_tweet

where $t.'create_at' >= datetime('2016-10-19T00:00:47.473Z') and $t.'create_at' 
< datetime('2016-10-19T00:01:47.473Z') 
and  similarity-jaccard(word-tokens($t.'text'), word-tokens('sleep')) > 0.0
return $t.text

{code}

It returns empty. 

The debug port is on 8001 on each cloudberry nuc nc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1573 Allow Extension of Rewrite Rules

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1304

to look at the new patch set (#2).

Change subject: ASTERIXDB-1573 Allow Extension of Rewrite Rules
..

ASTERIXDB-1573 Allow Extension of Rewrite Rules

Add IRuleSetFactory which builds rewrite Rule Set
Can be extended by Asterix Extensions

Removed some obsolete extension code
Change-Id: I7f59dea86b0ef4ee9d31b56766a97bd2b34ec02c
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/AqlCompilationProvider.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/ILangCompilationProvider.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/IRuleSetFactory.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/SqlppCompilationProvider.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CompilerExtensionManager.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedWorkCollection.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/DefaultStatementExecutorFactory.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixCLI.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixWebServer.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/aql/translator/QueryTranslatorTest.java
M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dml/DmlTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java
19 files changed, 163 insertions(+), 93 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/04/1304/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1304
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f59dea86b0ef4ee9d31b56766a97bd2b34ec02c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi

[jira] [Assigned] (ASTERIXDB-1573) Refactor extensibility of re-write rules

2016-10-19 Thread Steven Jacobs (JIRA)


 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steven Jacobs reassigned ASTERIXDB-1573:


Assignee: Steven Jacobs  (was: Yingyi Bu)

> Refactor extensibility of re-write rules
> 
>
> Key: ASTERIXDB-1573
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1573
> Project: Apache AsterixDB
>  Issue Type: Improvement
>Reporter: Abdullah Alamoudi
>Assignee: Steven Jacobs
>
> Currently, extension mechanism doesn't provide a good generic way of 
> extending re-write rules.
> A provider should be introduced to improve this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
..


Patch Set 17:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/979/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1057
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1573 Allow Extension of Rewrite Rules

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1573 Allow Extension of Rewrite Rules
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3086/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1304
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f59dea86b0ef4ee9d31b56766a97bd2b34ec02c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1227

to look at the new patch set (#8).

Change subject: Updated to match code changes to asterix
..

Updated to match code changes to asterix

Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
---
M .gitignore
A asterix-bad/pom.xml
R asterix-bad/src/main/java/org/apache/asterix/bad/BADConstants.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobInfo.java
R asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADCompilationProvider.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADLangExtension.java
R asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADParserFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADQueryTranslatorExtension.java
A asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataExtension.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataRecordTypes.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Broker.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BrokerTupleTranslator.java
R asterix-bad/src/main/java/org/apache/asterix/bad/metadata/Channel.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelEventsListener.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelSearchKey.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/ChannelTupleTranslator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerPOperator.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntimeFactory.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorDescriptor.java
R 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/RepetitiveChannelOperatorNodePushable.java
R asterix-bad/src/main/resources/lang-extension/lang.txt
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADExecutionTest.java
R asterix-bad/src/test/java/org/apache/asterix/bad/test/BADOptimizerTest.java
R asterix-bad/src/test/resources/conf/asterix-build-configuration.xml
R asterix-bad/src/test/resources/conf/cluster.xml
R asterix-bad/src/test/resources/conf/hyracks-deployment.properties
R asterix-bad/src/test/resources/conf/test.properties
R asterix-bad/src/test/resources/optimizerts/queries/channel/channel-create.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-subscribe.aql
R 
asterix-bad/src/test/resources/optimizerts/queries/channel/channel-unsubscribe.aql
R asterix-bad/src/test/resources/optimizerts/results/channel/channel-create.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-subscribe.plan
R 
asterix-bad/src/test/resources/optimizerts/results/channel/channel-unsubscribe.plan
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_datasets/create_channel_check_datasets.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/create_channel_check_metadata/create_channel_check_metadata.3.query.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.1.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/drop_channel_check_datasets.2.ddl.aql
R 
asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_datasets/

Change in asterixdb[master]: ASTERIXDB-1573 Allow Extension of Rewrite Rules

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1573 Allow Extension of Rewrite Rules
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/980/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1304
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f59dea86b0ef4ee9d31b56766a97bd2b34ec02c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb-bad[master]: Updated to match code changes to asterix

Jenkins has posted comments on this change.

Change subject: Updated to match code changes to asterix
..


Patch Set 8:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/27/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1227
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

Hello Jianfeng Jia, Till Westmann, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1303

to look at the new patch set (#4).

Change subject: Make Lock Manager Statistics at FINE granularity
..

Make Lock Manager Statistics at FINE granularity

It seems like in some scenarios the Lock manager can output a large volume
of logs and this can get excessive quickly. Our default level is at INFO
so I thought FINE might be more appropriate.

I also made the Managix Log append rather than clobber the old logs.

Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
---
M asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
M asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
3 files changed, 17 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/03/1303/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

Ian Maxon has posted comments on this change.

Change subject: Make Lock Manager Statistics at FINE granularity
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1303/3/asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
File asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh:

Line 72: echo " 
"
 >> $LOG_DIR/cc.log
> would it be a little cleaner by using cat? 
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

Jenkins has posted comments on this change.

Change subject: Make Lock Manager Statistics at FINE granularity
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3087/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
..


Patch Set 17: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/979/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1057
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

2016-10-19 Thread Jianfeng Jia (Code Review)

Jianfeng Jia has posted comments on this change.

Change subject: Make Lock Manager Statistics at FINE granularity
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

Jenkins has posted comments on this change.

Change subject: Make Lock Manager Statistics at FINE granularity
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/981/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

Hello Jianfeng Jia, Till Westmann, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1303

to look at the new patch set (#5).

Change subject: Make Lock Manager Statistics at FINE granularity
..

Make Lock Manager Statistics at FINE granularity

It seems like in some scenarios the Lock manager can output a large volume
of logs and this can get excessive quickly. Our default level is at INFO
so I thought FINE might be more appropriate.

I also made the Managix Log append rather than clobber the old logs.

Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
---
M asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
M asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
3 files changed, 17 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/03/1303/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

Jenkins has posted comments on this change.

Change subject: Make Lock Manager Statistics at FINE granularity
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3088/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

Ian Maxon has posted comments on this change.

Change subject: Make Lock Manager Statistics at FINE granularity
..


Patch Set 5:

The heredoc had quotes in it which was messing up the date variable being 
evaluated rather than interpreted as a literal.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1573 Allow Extension of Rewrite Rules

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1573 Allow Extension of Rewrite Rules
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/980/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1304
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f59dea86b0ef4ee9d31b56766a97bd2b34ec02c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Introduce XML Reader & Parser

2016-10-19 Thread Xikui Wang (Code Review)

Xikui Wang has posted comments on this change.

Change subject: Introduce XML Reader & Parser
..

Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1269/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/XMLFileParser.java
File
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/XMLFileParser.java:

Line 48: JSONObject xmlObj = XML.toJSONObject(record.toString());
> "Some information may be lost" doesn't sound ideal :) Is this aiming to be
I guess this means it can only maintain those information that can be stored in
JSON, as they are two different format. Thus it says 'Comments, prologs, DTDs,
and <[ [ ]]> are ignored'.

This was designed for CAPS message which each of the document is a small XML
document with simple elements. Later Taewoo come to me with a application
scenario that he needs to load xml documents into AsterixDB. So I extended this
a little bit to fit his need.

After meeting with Taewoo today, It turns out he has a slightly different
application scenario that he needs to map a nested element in XML document
(e.g. in ... ... ...
into a record. One possible change is to allow user specify the
level they want to do mapping, but I am not sure that's general enough.

Generally, IMO there are needs for processing XML in AsterixDB, and probably
something working (may not be perfect) can ease the pain.

--
To view, visit https://asterix-gerrit.ics.uci.edu/1269
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Taewoo Kim
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: Xikui Wang
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

Jenkins has posted comments on this change.

Change subject: Make Lock Manager Statistics at FINE granularity
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/982/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1699) Inverted Index fail to match the keyword


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589762#comment-15589762
 ] 

Jianfeng Jia commented on ASTERIXDB-1699:
-

It seems that the inverted index was somehow stopped growing. Here is the files 
in the inverted index folder:
{code}
-rw-r--r-- 1 jianfeng 129K Oct 17 00:04 
2016-10-17-00-03-11-062_2016-10-16-22-51-44-465_f
-rw-r--r-- 1 jianfeng  82M Oct 17 00:05 
2016-10-17-00-03-11-062_2016-10-16-22-51-44-465_i
-rw-r--r-- 1 jianfeng  48M Oct 17 00:05 
2016-10-17-00-03-11-062_2016-10-16-22-51-44-465_b
-rw-r--r-- 1 jianfeng 257K Oct 17 00:05 
2016-10-17-00-03-11-062_2016-10-16-22-51-44-465_d
-rw-r--r-- 1 jianfeng 129K Oct 17 00:45 
2016-10-17-00-45-00-338_2016-10-17-00-04-01-056_f
-rw-r--r-- 1 jianfeng  83M Oct 17 00:46 
2016-10-17-00-45-00-338_2016-10-17-00-04-01-056_i
-rw-r--r-- 1 jianfeng  49M Oct 17 00:46 
2016-10-17-00-45-00-338_2016-10-17-00-04-01-056_b
-rw-r--r-- 1 jianfeng 257K Oct 17 00:46 
2016-10-17-00-45-00-338_2016-10-17-00-04-01-056_d
-rw-r--r-- 1 jianfeng 129K Oct 17 13:23 
2016-10-17-13-23-38-232_2016-10-17-00-45-55-667_f
-rw-r--r-- 1 jianfeng  81M Oct 17 13:24 
2016-10-17-13-23-38-232_2016-10-17-00-45-55-667_i
-rw-r--r-- 1 jianfeng  48M Oct 17 13:24 
2016-10-17-13-23-38-232_2016-10-17-00-45-55-667_b
-rw-r--r-- 1 jianfeng 257K Oct 17 13:24 
2016-10-17-13-23-38-232_2016-10-17-00-45-55-667_d
-rw-r--r-- 1 jianfeng 129K Oct 18 23:43 
2016-10-18-23-43-45-771_2016-10-17-13-25-38-229_f
-rw-r--r-- 1 jianfeng 2.3M Oct 18 23:43 
2016-10-18-23-43-45-771_2016-10-17-13-25-38-229_i
-rw-r--r-- 1 jianfeng 3.3M Oct 18 23:43 
2016-10-18-23-43-45-771_2016-10-17-13-25-38-229_b
-rw-r--r-- 1 jianfeng 257K Oct 18 23:43 
2016-10-18-23-43-45-771_2016-10-17-13-25-38-229_d
-rw-r--r-- 1 jianfeng 129K Oct 19 00:33 
2016-10-19-00-33-24-890_2016-10-19-00-33-24-890_i
-rw-r--r-- 1 jianfeng 129K Oct 19 00:33 
2016-10-19-00-33-24-890_2016-10-19-00-33-24-890_f
-rw-r--r-- 1 jianfeng 385K Oct 19 00:33 
2016-10-19-00-33-24-890_2016-10-19-00-33-24-890_b
-rw-r--r-- 1 jianfeng 257K Oct 19 00:33 
2016-10-19-00-33-24-890_2016-10-19-00-33-24-890_d
-rw-r--r-- 1 jianfeng 129K Oct 19 06:24 
2016-10-19-06-24-55-819_2016-10-19-06-24-55-819_i
-rw-r--r-- 1 jianfeng 129K Oct 19 06:24 
2016-10-19-06-24-55-819_2016-10-19-06-24-55-819_f
-rw-r--r-- 1 jianfeng 385K Oct 19 06:24 
2016-10-19-06-24-55-819_2016-10-19-06-24-55-819_b
-rw-r--r-- 1 jianfeng 257K Oct 19 06:24 
2016-10-19-06-24-55-819_2016-10-19-06-24-55-819_d
-rw-r--r-- 1 jianfeng 129K Oct 19 06:26 
2016-10-19-06-26-55-822_2016-10-19-06-26-55-822_i
-rw-r--r-- 1 jianfeng 129K Oct 19 06:26 
2016-10-19-06-26-55-822_2016-10-19-06-26-55-822_f
-rw-r--r-- 1 jianfeng 385K Oct 19 06:26 
2016-10-19-06-26-55-822_2016-10-19-06-26-55-822_b
-rw-r--r-- 1 jianfeng 257K Oct 19 06:26 
2016-10-19-06-26-55-822_2016-10-19-06-26-55-822_d
-rw-r--r-- 1 jianfeng 129K Oct 19 08:48 
2016-10-19-08-48-43-924_2016-10-19-08-48-43-924_i
-rw-r--r-- 1 jianfeng 129K Oct 19 08:48 
2016-10-19-08-48-43-924_2016-10-19-08-48-43-924_f
-rw-r--r-- 1 jianfeng 385K Oct 19 08:48 
2016-10-19-08-48-43-924_2016-10-19-08-48-43-924_b
-rw-r--r-- 1 jianfeng 257K Oct 19 08:48 
2016-10-19-08-48-43-924_2016-10-19-08-48-43-924_d
-rw-r--r-- 1 jianfeng 129K Oct 19 09:03 
2016-10-19-09-03-08-416_2016-10-19-09-03-08-416_i
-rw-r--r-- 1 jianfeng 129K Oct 19 09:03 
2016-10-19-09-03-08-416_2016-10-19-09-03-08-416_f
-rw-r--r-- 1 jianfeng 385K Oct 19 09:03 
2016-10-19-09-03-08-416_2016-10-19-09-03-08-416_b
-rw-r--r-- 1 jianfeng 257K Oct 19 09:03 
2016-10-19-09-03-08-416_2016-10-19-09-03-08-416_d
-rw-r--r-- 1 jianfeng 129K Oct 19 10:52 
2016-10-19-10-52-55-837_2016-10-19-10-52-55-837_i
-rw-r--r-- 1 jianfeng 129K Oct 19 10:52 
2016-10-19-10-52-55-837_2016-10-19-10-52-55-837_f
-rw-r--r-- 1 jianfeng 385K Oct 19 10:52 
2016-10-19-10-52-55-837_2016-10-19-10-52-55-837_b
-rw-r--r-- 1 jianfeng 257K Oct 19 10:52 
2016-10-19-10-52-55-837_2016-10-19-10-52-55-837_d
-rw-r--r-- 1 jianfeng 129K Oct 19 10:54 
2016-10-19-10-54-55-839_2016-10-19-10-54-55-839_i
-rw-r--r-- 1 jianfeng 129K Oct 19 10:54 
2016-10-19-10-54-55-839_2016-10-19-10-54-55-839_f
-rw-r--r-- 1 jianfeng 385K Oct 19 10:54 
2016-10-19-10-54-55-839_2016-10-19-10-54-55-839_b
-rw-r--r-- 1 jianfeng 257K Oct 19 10:54 
2016-10-19-10-54-55-839_2016-10-19-10-54-55-839_d
{code}

For example, the total index size for 10-17 was 3 * 83M, but in 10-18 there was 
only 2.3M. 

> Inverted Index fail to match the keyword
> 
>
> Key: ASTERIXDB-1699
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1699
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Storage
> Environment: master : 4819ea44723b87a68406d248782861cf6e5d3305
>Reporter: Jianfeng Jia
>Assignee: Ian Maxon
>
> Not very clear how to reproduce it on a smaller dataset. Here is

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

Jenkins has posted comments on this change.

Change subject: Make Lock Manager Statistics at FINE granularity
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/982/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

Ian Maxon has posted comments on this change.

Change subject: Make Lock Manager Statistics at FINE granularity
..


Patch Set 5:

I'll take that +2 now if either of you are in a mood to give it ;)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

2016-10-19 Thread Till Westmann (Code Review)

Till Westmann has posted comments on this change.

Change subject: Make Lock Manager Statistics at FINE granularity
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Lock Manager Statistics at FINE granularity

Ian Maxon has submitted this change and it was merged.

Change subject: Make Lock Manager Statistics at FINE granularity
..


Make Lock Manager Statistics at FINE granularity

It seems like in some scenarios the Lock manager can output a large volume
of logs and this can get excessive quickly. Our default level is at INFO
so I thought FINE might be more appropriate.

I also made the Managix Log append rather than clobber the old logs.

Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1303
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Till Westmann 
---
M asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
M asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
3 files changed, 17 insertions(+), 4 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh 
b/asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
index b7481e9..c761744 100644
--- a/asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
+++ b/asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
@@ -67,4 +67,11 @@
 ccArgs=$ccArgs' -cc-root '$CC_ROOT
 fi
 cd $WORKING_DIR
-$ASTERIX_HOME/bin/asterixcc echo $ccArgs &> $LOG_DIR/cc.log
\ No newline at end of file
+DATE=`date`
+
+cat <> $LOG_DIR/cc.log
+
+LOG START: $DATE
+
+EOF
+$ASTERIX_HOME/bin/asterixcc echo $ccArgs &>> $LOG_DIR/cc.log
\ No newline at end of file
diff --git 
a/asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh 
b/asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
index 4884872..1a3de9a 100644
--- a/asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
+++ b/asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
@@ -28,4 +28,10 @@
 
 cd $WORKING_DIR
 
-$ASTERIX_HOME/bin/asterixnc -node-id $NC_ID -cc-host $CC_HOST -cc-port 
$CLUSTER_NET_PORT  -cluster-net-ip-address $IP_LOCATION  -data-ip-address 
$IP_LOCATION -iodevices $IO_DEVICES -result-ip-address $IP_LOCATION -- 
$INITIAL_RUN_FLAG &> $LOG_DIR/${NC_ID}.log
+DATE=`date`
+cat <> $LOG_DIR/${NC_ID}.log
+
+LOG START: $DATE
+
+EOF
+$ASTERIX_HOME/bin/asterixnc -node-id $NC_ID -cc-host $CC_HOST -cc-port 
$CLUSTER_NET_PORT  -cluster-net-ip-address $IP_LOCATION  -data-ip-address 
$IP_LOCATION -iodevices $IO_DEVICES -result-ip-address $IP_LOCATION -- 
$INITIAL_RUN_FLAG &>> $LOG_DIR/${NC_ID}.log
diff --git 
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
 
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
index 8dcc1be..faec2ed 100644
--- 
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
+++ 
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
@@ -555,7 +555,7 @@
 LOGGER.finer("del job slot " + TypeUtil.Global.toString(jobSlot));
 jobArenaMgr.deallocate(jobSlot);
 jobId2JobSlotMap.remove(jobId);
-stats.logCounters(LOGGER, Level.INFO, true);
+stats.logCounters(LOGGER, Level.FINE, true);
 }
 
 private long findOrAllocJobSlot(int jobId) {
@@ -662,7 +662,7 @@
 }
 
 private long findResourceInGroup(ResourceGroup group, int dsId, int 
entityHashValue) {
-stats.logCounters(LOGGER, Level.INFO, false);
+stats.logCounters(LOGGER, Level.FINE, false);
 long resSlot = group.firstResourceIndex.get();
 while (resSlot != NILL) {
 // either we already have a lock on this resource or we have a

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1303
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id26ac346a5fa1410e1b74a4fa88ae9f45f791be2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann

Change in asterixdb[master]: Full-text implementation step 1

Ian Maxon has posted comments on this change.

Change subject: Full-text implementation step 1
..


Patch Set 11:

(12 comments)

More thoughts/questions...

https://asterix-gerrit.ics.uci.edu/#/c/1228/11/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckRule.java:

Line 131: && 
ConstantExpressionUtil.getConstantIaObjectType(firstExpr) != ATypeTag.STRING) {
"The first expression should be a string"


Line 144: default:
"The second expression should be a string, unordered list, or ordered list."


Line 167: if (openRecConsExpr.getArguments().size() > 
FullTextContainsDescriptor.paramTypeMap.size() * 2) {
Why is it * 2? Because opRecConsExpr.getArguments() is like 
[expr,val,expr,val...] ?


Line 176: throw new AlgebricksException(
"Options must be in the form of constant strings. Check that the option at " + 
(i%2+1) + " is indeed a constant string"


Line 181: if 
(!FullTextContainsDescriptor.paramTypeMap.containsKey(option)) {
The English here is not right, it might be something like "The given option " + 
option + " is not a valid argument to ftcontains()"


Line 206: throw new AlgebricksException(
"The given value for option " + option + " was not of the expected type"


Line 225: boolean checkSearchModeOption(String optionVal) throws 
AlgebricksException {
Why's this a boolean when the value is never used?


Line 229: } else {
"The given value for the search mode ("+optionVal+") is not valid. Valid modes 
are " + FullTextContainsDescriptor.CONJUNCTIVE_SEARCH_MODE_OPTION + " or " + 
FullTextContainsDescriptor.DISJUNCTIVE_SEARCH_MODE_OPTION +"."


https://asterix-gerrit.ics.uci.edu/#/c/1228/11/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/FullTextContainsEvaluator.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/FullTextContainsEvaluator.java:

Line 177:  */
This method is really, really long, and quite nested. If it could be broken up 
more, say betwen the init, right, and left parts, that might help legibility.


Line 313: // array that contains the key (this array will be set 
later.)
What is the meaning behind 101 and 32768? Can those be static final variables 
if they are supposed to be?


Line 394: protected boolean checkArgTypes(ATypeTag typeTag1, ATypeTag 
typeTag2) throws AlgebricksException {
The if/else here is superfluous.


Line 398: 
Likewise here.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1228
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If00a871a8241d6aa6931f97b694d65f164d3ab8c
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Heri Ramampiaro 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add user-stream for Twitter Adaptor

2016-10-19 Thread Xikui Wang (Code Review)

Xikui Wang has posted comments on this change.

Change subject: Add user-stream for Twitter Adaptor
..


Patch Set 2:

(1 comment)

The user whose access token is used in the feed creation, is the one that we 
are monitoring.

https://asterix-gerrit.ics.uci.edu/#/c/1272/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java:

Line 68: }
> Can we extract the common code from these three constructors and move it to
Yeah. Basically the only part that could be shrunk is the 
tweetListener.setInputQ(inputQ). But the tweetListener(s) are not the same in 
them, should I cast all to be tweetListener?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1272
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99cdd4cb667306d378317616f9811dfce3e6d838
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Ignore analyze-only plugin on Eclipse

Jenkins has posted comments on this change.

Change subject: Ignore analyze-only plugin on Eclipse
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3089/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1305
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9a9df0bb67acb207cd0be2724b1e34974a1323
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Ignore analyze-only plugin on Eclipse

2016-10-19 Thread Taewoo Kim (Code Review)

Taewoo Kim has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1305

Change subject: Ignore analyze-only plugin on Eclipse
..

Ignore analyze-only plugin on Eclipse

 - Let the Eclipse ignore analyze-only plugin since
   there is no m2e connector for this.

Change-Id: I3f9a9df0bb67acb207cd0be2724b1e34974a1323
---
M asterixdb/pom.xml
M hyracks-fullstack/pom.xml
2 files changed, 26 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/05/1305/1

diff --git a/asterixdb/pom.xml b/asterixdb/pom.xml
index 161a625..503c44c 100644
--- a/asterixdb/pom.xml
+++ b/asterixdb/pom.xml
@@ -369,6 +369,19 @@
 
   
 
+
+  
+org.apache.maven.plugins
+maven-dependency-plugin
+[2.10,)
+
+  analyze-only
+
+  
+  
+
+  
+
   
 
   
diff --git a/hyracks-fullstack/pom.xml b/hyracks-fullstack/pom.xml
index af536e1..cf618f7 100644
--- a/hyracks-fullstack/pom.xml
+++ b/hyracks-fullstack/pom.xml
@@ -388,6 +388,19 @@
 
   
 
+
+  
+org.apache.maven.plugins
+maven-dependency-plugin
+[2.10,)
+
+  analyze-only
+
+  
+  
+
+  
+
   
 
   

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1305
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f9a9df0bb67acb207cd0be2724b1e34974a1323
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim

Change in asterixdb[master]: Ignore analyze-only plugin on Eclipse

Jenkins has posted comments on this change.

Change subject: Ignore analyze-only plugin on Eclipse
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1305
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9a9df0bb67acb207cd0be2724b1e34974a1323
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1573 Allow Extension of Rewrite Rules

2016-10-19 Thread Yingyi Bu (Code Review)

Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1573 Allow Extension of Rewrite Rules
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1304
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f59dea86b0ef4ee9d31b56766a97bd2b34ec02c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Ignore analyze-only plugin on Eclipse

Jenkins has posted comments on this change.

Change subject: Ignore analyze-only plugin on Eclipse
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/983/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1305
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9a9df0bb67acb207cd0be2724b1e34974a1323
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Ignore analyze-only plugin on Eclipse

Ian Maxon has posted comments on this change.

Change subject: Ignore analyze-only plugin on Eclipse
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1305
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9a9df0bb67acb207cd0be2724b1e34974a1323
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Ignore analyze-only plugin on Eclipse

2016-10-19 Thread Taewoo Kim (Code Review)

Taewoo Kim has submitted this change and it was merged.

Change subject: Ignore analyze-only plugin on Eclipse
..


Ignore analyze-only plugin on Eclipse

 - Let the Eclipse ignore analyze-only plugin since
   there is no m2e connector for this.

Change-Id: I3f9a9df0bb67acb207cd0be2724b1e34974a1323
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1305
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Ian Maxon 
---
M asterixdb/pom.xml
M hyracks-fullstack/pom.xml
2 files changed, 26 insertions(+), 0 deletions(-)

Approvals:
  Ian Maxon: Looks good to me, approved
  Jenkins: Verified; No violations found



diff --git a/asterixdb/pom.xml b/asterixdb/pom.xml
index 161a625..503c44c 100644
--- a/asterixdb/pom.xml
+++ b/asterixdb/pom.xml
@@ -369,6 +369,19 @@
 
   
 
+
+  
+org.apache.maven.plugins
+maven-dependency-plugin
+[2.10,)
+
+  analyze-only
+
+  
+  
+
+  
+
   
 
   
diff --git a/hyracks-fullstack/pom.xml b/hyracks-fullstack/pom.xml
index af536e1..cf618f7 100644
--- a/hyracks-fullstack/pom.xml
+++ b/hyracks-fullstack/pom.xml
@@ -388,6 +388,19 @@
 
   
 
+
+  
+org.apache.maven.plugins
+maven-dependency-plugin
+[2.10,)
+
+  analyze-only
+
+  
+  
+
+  
+
   
 
   

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1305
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f9a9df0bb67acb207cd0be2724b1e34974a1323
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim

Change in asterixdb[master]: Add Checkpoint Test

Jenkins has posted comments on this change.

Change subject: Add Checkpoint Test
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3090/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1270
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Checkpoint Test

2016-10-19 Thread Murtadha Hubail (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1270

to look at the new patch set (#2).

Change subject: Add Checkpoint Test
..

Add Checkpoint Test

This change adds a unit test case which validates that
checkpoints do not delete log files that are still required
for recovery, and delete those that are no longer needed.

Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e
---
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixTransactionProperties.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
6 files changed, 282 insertions(+), 44 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/70/1270/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1270
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi

Change in asterixdb[master]: Ignore analyze-only plugin on Eclipse

Jenkins has posted comments on this change.

Change subject: Ignore analyze-only plugin on Eclipse
..


Patch Set 1:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/983/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1305
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9a9df0bb67acb207cd0be2724b1e34974a1323
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Checkpoint Test

Ian Maxon has posted comments on this change.

Change subject: Add Checkpoint Test
..


Patch Set 2: Code-Review+1

(2 comments)

Just a couple questions, otherwise looks great to me.

https://asterix-gerrit.ics.uci.edu/#/c/1270/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java:

Line 129: ExecutionTestUtil.setUp(cleanupOnStart,
Is this just to speed things up (i.e. allowing HDFS test cluster to be skipped)?


https://asterix-gerrit.ics.uci.edu/#/c/1270/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java:

Line 149: if (initialLowWaterMarkFileId == 
currentLowWaterMarkLogFileId) {
What should happen here if the condition is not true? Isn't it expected as a 
consequence of not having a checkpoint yet?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1270
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add Checkpoint Test

2016-10-19 Thread Murtadha Hubail (Code Review)

Murtadha Hubail has posted comments on this change.

Change subject: Add Checkpoint Test
..


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1270/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java:

Line 129: ExecutionTestUtil.setUp(cleanupOnStart,
> Is this just to speed things up (i.e. allowing HDFS test cluster to be skip
Yes.


https://asterix-gerrit.ics.uci.edu/#/c/1270/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java:

Line 149: if (initialLowWaterMarkFileId == 
currentLowWaterMarkLogFileId) {
> What should happen here if the condition is not true? Isn't it expected as 
Even though there is no checkpoint yet, there is a tiny chance (depending on 
the dataset memory budget configuration) that the dataset is flushed right at 
the beginning of the second log file, so the lowWaterMarkLSN would be in the 
second log file. In that case, this part of the test case will be skipped but 
the log file deletion part will still be tested.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1270
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add Checkpoint Test

Ian Maxon has posted comments on this change.

Change subject: Add Checkpoint Test
..


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1270/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java:

Line 149: if (initialLowWaterMarkFileId == 
currentLowWaterMarkLogFileId) {
> Even though there is no checkpoint yet, there is a tiny chance (depending o
I see, so it's to assure that it does indeed happen, either by flush or (more 
likely) by what's in this condition. What about the second part after this 
then, the next while loop? It would go something like the checkpoint would be 
done even though it isn't necessary to cause the low water mark to move to the 
2nd file, and then the deletion is checked?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1270
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cb4743fe488deb5ad10f65604adc2231948795e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

[jira] [Updated] (ASTERIXDB-1700) edit-distance-check on the fields with the 2-gram and the 3-gram index generates a null pointer exception.

2016-10-19 Thread Taewoo Kim (JIRA)


 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Taewoo Kim updated ASTERIXDB-1700:
--
Description: 
If there multiple indexes on the same field, we use intersect operator to 
integrate the result from each index. In the following AQL query, we have two 
n-gram indexes on the same field. And, the null pointer exception happens.

{code}
java.lang.NullPointerException
at 
org.apache.hyracks.api.job.JobSpecification.getInputConnectorDescriptor(JobSpecification.java:192)
at 
org.apache.hyracks.api.job.JobSpecification.getInputConnectorDescriptor(JobSpecification.java:188)
at 
org.apache.hyracks.api.client.impl.JobActivityGraphBuilder.addSourceEdge(JobActivityGraphBuilder.java:81)
at 
org.apache.hyracks.dataflow.std.base.AbstractSingleActivityOperatorDescriptor.contributeActivities(AbstractSingleActivityOperatorDescriptor.java:54)
at 
org.apache.hyracks.api.client.impl.JobSpecificationActivityClusterGraphGeneratorFactory$2.visit(JobSpecificationActivityClusterGraphGeneratorFactory.java:67)
at 
org.apache.hyracks.api.client.impl.PlanUtils.visitOperator(PlanUtils.java:41)
at org.apache.hyracks.api.client.impl.PlanUtils.visit(PlanUtils.java:34)
at 
org.apache.hyracks.api.client.impl.JobSpecificationActivityClusterGraphGeneratorFactory.createActivityClusterGraphGenerator(JobSpecificationActivityClusterGraphGeneratorFactory.java:64)
at 
org.apache.hyracks.control.cc.work.JobStartWork.doRun(JobStartWork.java:61)
at 
org.apache.hyracks.control.common.work.SynchronizableWork.run(SynchronizableWork.java:39)
at 
org.apache.hyracks.control.common.work.WorkQueue$WorkerThread.run(WorkQueue.java:127)
Oct 19, 2016 7:10:22 PM org.apache.asterix.app.translator.QueryTranslator 
handleQuery
{code}

{code}
create type DBLPType as closed {
  id: int64,
  dblpid: string,
  title: string,
  authors: string,
  misc: string
}

create dataset DBLP(DBLPType)
  primary key id on group1;

create index ngram2_index on DBLP(authors) type ngram(2);
create index ngram3_index on DBLP(authors) type ngram(3);

for $o in dataset('DBLP')
let $ed := edit-distance-check($o.authors, "Amihay Motro", 1)
where $ed[0]
return $o
{code}

{code}
-- DISTRIBUTE_RESULT  |PARTITIONED|
  exchange
  -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
select (function-call: asterix:get-item, Args:[function-call: 
asterix:edit-distance-check, Args:[function-call: 
asterix:field-access-by-index, Args:[%0->$$0, AInt32: {3}], AString: {Amihay 
Motro}, AInt64: {1}], AInt64: {0}])
-- STREAM_SELECT  |PARTITIONED|
  project ([$$0])
  -- STREAM_PROJECT  |PARTITIONED|
exchange
-- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
  unnest-map [$$6, $$0] <- function-call: asterix:index-search, 
Args:[AString: {DBLP}, AInt32: {0}, AString: {test}, AString: {DBLP}, ABoolean: 
{false}, ABoolean: {false}, AInt32: {1}, %0->$$9, AInt32: {1}, %0->$$9, TRUE, 
TRUE, TRUE]
  -- BTREE_SEARCH  |PARTITIONED|
exchange
-- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
  intersect ([$$9] <- [[$$9], [$$11]])
  -- INTERSECT  |PARTITIONED|
exchange
-- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
  order (ASC, %0->$$9) 
  -- STABLE_SORT [$$9(ASC)]  |PARTITIONED|
exchange
-- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
  unnest-map [$$9] <- function-call: asterix:index-search, 
Args:[AString: {ngram2_index}, AInt32: {5}, AString: {test}, AString: {DBLP}, 
ABoolean: {false}, ABoolean: {false}, AInt32: {2}, AInt64: {1}, AInt32: {12}, 
AInt32: {1}, %0->$$8]
  -- LENGTH_PARTITIONED_INVERTED_INDEX_SEARCH  |PARTITIONED|
project ([$$8])
-- STREAM_PROJECT  |PARTITIONED|
  assign [$$8] <- [%0->$$10]
  -- ASSIGN  |PARTITIONED|
exchange
-- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
  replicate
  -- REPLICATE  |PARTITIONED|
exchange
-- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
  assign [$$10] <- [AString: {Amihay Motro}]
  -- ASSIGN  |PARTITIONED|
empty-tuple-source
-- EMPTY_TUPLE_SOURCE  |PARTITIONED|
exchange
-- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
  order (ASC, %0->$$11) 
  -- STABLE_SORT [$$11(ASC)]  |PARTITIONED|
exchange
-- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
  unnest-map [$$11] <- function-call: asterix:index-search, 
A

[jira] [Commented] (ASTERIXDB-1700) edit-distance-check on the fields with the 2-gram and the 3-gram index generates a null pointer exception.