Change in asterixdb[master]: [NO ISSUE][STO] Ensure IFrameTupleProcessor Finish is Called

2017-10-20 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][STO] Ensure IFrameTupleProcessor Finish is Called
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2083/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java:

PS1, Line 684: processor
> But if processFrame throws, then processor.finish() won't be called.
I believe you are referring to Abdullah's comment. I discussed it with him and 
raised the same concern as yours and we agreed to keep the initial change the 
way it is and just log the exception to ensure that it won't be lost due to 
propagation.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2083
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f4188fa3de3c91f5f6aae95716db016a315ddd6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [NO ISSUE][STO] Ensure IFrameTupleProcessor Finish is Called

2017-10-20 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has submitted this change and it was merged.

Change subject: [NO ISSUE][STO] Ensure IFrameTupleProcessor Finish is Called
..


[NO ISSUE][STO] Ensure IFrameTupleProcessor Finish is Called

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Currently when an exception is encountered while processing the frame
in LSMHarness, IFrameTupleProcessor finish is not called which results
in "Operation already has access to components of index" exception.

Change-Id: I5f4188fa3de3c91f5f6aae95716db016a315ddd6
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2083
Reviewed-by: abdullah alamoudi 
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
---
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
1 file changed, 23 insertions(+), 12 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  abdullah alamoudi: Looks good to me, approved
  Jenkins: Verified; No violations found; ; Verified



diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
index c8be9b9..ac38cba 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
@@ -643,9 +643,9 @@
 exitComponents(ctx, LSMOperationType.REPLICATE, null, false);
 }
 
-protected void 
validateOperationEnterComponentsState(ILSMIndexOperationContext ctx) throws 
HyracksDataException {
+protected void 
validateOperationEnterComponentsState(ILSMIndexOperationContext ctx) {
 if (ctx.isAccessingComponents()) {
-throw new HyracksDataException("Opeartion already has access to 
components of index " + lsmIndex);
+throw new IllegalStateException("Operation already has access to 
components of index " + lsmIndex);
 }
 }
 
@@ -684,17 +684,17 @@
 processor.start();
 enter(ctx);
 try {
-int tupleCount = accessor.getTupleCount();
-int i = 0;
-while (i < tupleCount) {
-tuple.reset(accessor, i);
-processor.process(tuple, i);
-i++;
+try {
+processFrame(accessor, tuple, processor);
+frameOpCallback.frameCompleted();
+} finally {
+processor.finish();
 }
-frameOpCallback.frameCompleted();
-processor.finish();
-} catch (Exception e) {
-throw HyracksDataException.create(e);
+} catch (HyracksDataException e) {
+if (LOGGER.isLoggable(Level.SEVERE)) {
+LOGGER.log(Level.SEVERE, "Failed to process frame", e);
+}
+throw e;
 } finally {
 exit(ctx);
 }
@@ -853,6 +853,17 @@
 return false;
 }
 
+private static void processFrame(FrameTupleAccessor accessor, 
FrameTupleReference tuple,
+IFrameTupleProcessor processor) throws HyracksDataException {
+int tupleCount = accessor.getTupleCount();
+int i = 0;
+while (i < tupleCount) {
+tuple.reset(accessor, i);
+processor.process(tuple, i);
+i++;
+}
+}
+
 @Override
 public String toString() {
 return getClass().getSimpleName() + ":" + lsmIndex;

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2083
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5f4188fa3de3c91f5f6aae95716db016a315ddd6
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Shiva Jahangiri (Code Review)
Shiva Jahangiri has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 23:

(30 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java:

Line 64: fmtString =
> MAJOR SonarQube violation:
Done


Line 64: fmtString =
> +1
Done


Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> +1
Done


Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> MAJOR SonarQube violation:
Done


Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> MAJOR SonarQube violation:
Done


Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> +1
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/23/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java:

Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> MAJOR SonarQube violation:
Done


Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 115: private static final String lplan = "Logical plan";
> +1
I cannot change it cause this is what we write in 


Line 116: private static final String oplan = "Optimized logical plan";
> +1
I cannot change it cause this is what we write in 


https://asterix-gerrit.ics.uci.edu/#/c/1885/23/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java:

PS23, Line 68: private
> remove?
Done


PS23, Line 73: setId
> remove?
Done


PS23, Line 77: getId
> remove?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/22/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java:

PS22, Line 26: import org.apache.commons.lang3.mutable.Mutable;
> Can you revert this file? It's not part of the change, really.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/23/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java:

PS23, Line 26: import
> revert file?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/22/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java:

Line 24: import org.apache.commons.lang3.mutable.Mutable;
> Same here.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/23/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java:

PS23, Line 24: apache
> revert file?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/22/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java:

Line 97: private Stack prefix;
> MAJOR SonarQube violation:
Done


Line 118: stringPrefix = (stringPrefix.isEmpty()) ? 
val.toString() : stringPrefix + "." + val.toString();
> MAJOR SonarQube violation:
Done


Line 118:   

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1258/
 (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6803/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1587/ 
(7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1250/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1259/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2148/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Anon. E. Moose (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1885

to look at the new patch set (#24).

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..

[UI] Allow logical plan to be viewed as JSON / formatted JSON

- user model changes: no
- storage format changes: no
- interface changes: enhancements to the web interface

details:
Added drop-down menu for printing logical plan and optimized
logical plan in string,json, and clean-json.

Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
M asterixdb/asterix-app/pom.xml
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java
M asterixdb/asterix-app/src/main/resources/webui/querytemplate.html
M asterixdb/asterix-app/src/main/resources/webui/static/css/style.css
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonOptimizedLogicalPlanTest.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
A 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/AbstractLogicalOperatorPrettyPrintVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
A 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/visitors/ILogicalOperatorVisitor.java
18 files changed, 1,320 insertions(+), 217 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/85/1885/24
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5307/ (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1866/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1927/
 (6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1963/ 
(8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4311/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1971/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1971/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Ensure IFrameTupleProcessor Finish is Called

2017-10-20 Thread Luo Chen (Code Review)
Luo Chen has posted comments on this change.

Change subject: [NO ISSUE][STO] Ensure IFrameTupleProcessor Finish is Called
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2083/3/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java:

PS3, Line 699: exit
Hi, I was implementing something similar, but a bit confused about the logic 
here. Why in exit we have to grab the memory component again and exit (is there 
any specific reason for doing this)?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2083
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f4188fa3de3c91f5f6aae95716db016a315ddd6
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4311/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24: Contrib+1

Analytics Compatibility Tests Successful Build 2789
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][RT] Add more startup debug logs

2017-10-20 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][RT] Add more startup debug logs
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2084/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/AbstractCheckpointManager.java
File 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/AbstractCheckpointManager.java:

PS1, Line 91:   LOGGER.log(Level.INFO, "Getting latest checkpoint");
> Wrap this one too?
This one doesn't create objects so it is okay to leave it like this.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2084
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25e5c6423f3160c4becbfe682edccc49613e371c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [NO ISSUE][RT] Add more startup debug logs

2017-10-20 Thread Ian Maxon (Code Review)
Ian Maxon has posted comments on this change.

Change subject: [NO ISSUE][RT] Add more startup debug logs
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2084
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25e5c6423f3160c4becbfe682edccc49613e371c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Ian Maxon (Code Review)
Ian Maxon has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 22:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 115: private static final String lplan = "Logical plan";
> I cannot change it cause this is what we write in 
Wait, what? We write the variable name?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 22
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Shiva Jahangiri (Code Review)
Shiva Jahangiri has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 22:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 115: private static final String lplan = "Logical plan";
> Wait, what? We write the variable name?
in line 161, we are printing the plan name that is either "Logical plan" or 
"Optimized logical plan" to the web interface and I needed to know which plan 
it is (logical/optimized logical) so I can set the correct class name in . 
what I was doing previously was: "Logical plan".equalsIgnoreCare(planName) 
which in a code review there was a suggestion to make this string finalized.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 22
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1588/ 
(7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1251/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6804/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1964/ 
(8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Wenhai Li (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1238

to look at the new patch set (#33).

Change subject: Add the forward for ParallelSort.
..

Add the forward for ParallelSort.

Based on the aggFuncs, enable the parallel sort by:
1. Maintaining the rangeMap within the HyracksJobletConext
2. Setup forward operator to connect the partitioning and sorting operators.
3. Add the unit test for parallel histogram based on construction-merge.
4. Add the delimited parser to inline the tags onto file scan.
5. Add four partitioners for the schema-driven assigner/rgAgg in asterixTest.

Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAggFuncIntoStandaloneAggregateRule.java
A asterixdb/asterix-app/data/skew/zipfian.tbl
A asterixdb/asterix-app/data/skew/zipfian1.tbl
A asterixdb/asterix-app/data/skew/zipfian2.tbl
A asterixdb/asterix-app/data/skew/zipfianmissing_1.tbl
A asterixdb/asterix-app/data/skew/zipfianmissing_2.tbl
A asterixdb/asterix-app/data/skew/zipfiannull_1.tbl
A asterixdb/asterix-app/data/skew/zipfiannull_2.tbl
A asterixdb/asterix-app/data/tpch0.001/lineitem-part1.tbl
A asterixdb/asterix-app/data/tpch0.001/lineitem-part2.tbl
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/AsterixAlgebricksHyracksIntegrationUtil.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/ParallelSortRuntimeTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestPartitionComputerFactory.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/avg_float/avg_float.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/avg_int16/avg_int16.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/avg_int32/avg_int32.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/avg_int64/avg_int64.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/avg_int8/avg_int8.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/count_01/count_01.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/global-avg_01/global-avg_01.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/global-rg/global-rg.1.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_double/local-avg_double.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_float/local-avg_float.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_int16/local-avg_int16.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_int16/local-avg_int16.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_int32/local-avg_int32.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_int64/local-avg_int64.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-avg_int8/local-avg_int8.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-rg/local-rg.1.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double-null/rg-double-null.1.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double/rg-double.1.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_double/rg_double.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_double/rg_double.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_double/rg_double.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_double_missing/rg_double_missing.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_double_missing/rg_double_missing.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_double_missing/rg_double_missing.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int16/rg_int16.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int16/rg_int16.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int16/rg_int16.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int16_missing/rg_int16_missing.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int16_missing/rg_int16_missing.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg_int16_missing/rg_int16_missing.3.query.aql
A 
asterixdb/asterix-app/src/test/r

Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2149/ (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5308/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1867/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1928/
 (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1260/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1259/
 (6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4312/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

2017-10-20 Thread Ian Maxon (Code Review)
Ian Maxon has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 22:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 115: private static final String lplan = "Logical plan";
> in line 161, we are printing the plan name that is either "Logical plan" or
Right, that's all fine, but I don't see how it follows from what the sonarqube 
comment is saying. Unless I am misunderstanding, it is just saying that the 
name of the variable doesn't conform to what a static final variable should be 
(e.g. LPLAN instead of lplan).


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 22
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Xikui Wang (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2085

to look at the new patch set (#3).

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..

[ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped feeds

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
1. Due to the ActiveEventListener change, current implementation will
try to issue stats request to stopped feed and never get back. This is
fixed.
2. Now we only request stats for active feeds.
3. When feed stopped, the cached stats will be reinitialized. This is to
prevent users see the previous active stats after immediate start after
stop.

Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ActiveStatsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
2 files changed, 14 insertions(+), 6 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/85/2085/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6805/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5309/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2150/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1260/
 (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1868/ (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1589/ 
(4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1252/ 
(7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1929/
 (6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1965/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1261/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1253/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1869/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Xikui Wang (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2078

to look at the new patch set (#3).

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..

[NO ISSUE][*DB] Enable loading external UDF for AsterixHyracksIntegrationUtil

- user model changes: no
- storage format changes: no
- interface changes: no

Add external UDF support for AsterixHyracksIntegrationUtil. Developer
may use following system properties to install external UDF for local
environment.
"external.lib" : udf package path.
"external.lib.dataverse": dataverse name (default: test).
"external.lib.libname": library name (default: testlib).

Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
R 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalUDFLibrarian.java
R 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/IExternalUDFLibrarian.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
7 files changed, 41 insertions(+), 20 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/78/2078/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 


[jira] [Created] (ASTERIXDB-2138) Check whether we are connecting a change feed to a non-meta dataset

2017-10-20 Thread Xikui Wang (JIRA)
Xikui Wang created ASTERIXDB-2138:
-

 Summary: Check whether we are connecting a change feed to a 
non-meta dataset
 Key: ASTERIXDB-2138
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2138
 Project: Apache AsterixDB
  Issue Type: Bug
Reporter: Xikui Wang


This needs to be done when connecting feed to a dataset.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Xikui Wang (Code Review)
Xikui Wang has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 8:

(5 comments)

comments from abdullah.

https://asterix-gerrit.ics.uci.edu/#/c/2059/8//COMMIT_MSG
Commit Message:

Line 15: very well, and there is a overhead for parsign the query everytime.
an, parsing


Line 26: 5. Change the default behavior of feed to be upsert instead of upsert.
instead of insert


https://asterix-gerrit.ics.uci.edu/#/c/2059/8/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

PS8, Line 2161: TODO: Chec
create issue too


https://asterix-gerrit.ics.uci.edu/#/c/2059/8/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java:

PS8, Line 182: List addArgs(Object... args) {
 : List argExprs = new ArrayList<>();
 : for (Object arg : args) {
 : if (arg instanceof Integer) {
 : argExprs.add(new LiteralExpr(new 
IntegerLiteral((Integer) arg)));
 : } else if (arg instanceof String) {
 : argExprs.add(new LiteralExpr(new 
StringLiteral((String) arg)));
 : } else if (arg instanceof VariableExpr) {
 : argExprs.add((VariableExpr) arg);
 : }
 : }
 : return argExprs;
 : }
double check if we already have util method for this


https://asterix-gerrit.ics.uci.edu/#/c/2059/8/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedConstants.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedConstants.java:

PS8, Line 26: SIGN
--> signature


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6806/ (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4313/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1262/ 
(4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5310/ (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1590/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1261/
 (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1930/
 (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1972/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1966/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1972/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2151/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Add the forward for ParallelSort.

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Add the forward for ParallelSort.
..


Patch Set 33: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4312/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1238
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc3ca935f569d33bda81e4c3bcf7daad8749d84c
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4314/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1973/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1967/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1591/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1254/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1931/
 (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1870/ (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6807/ (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Xikui Wang (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2059

to look at the new patch set (#9).

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..

[ASTERIXDB-1983] Feed pipeline refactoring for SQL++

- user model changes: no
- storage format changes: no
- interface changes: no

Current implementation of feed uses handcraft AQL queries for creating
feed pipeline. This causes a lot of issues and does not support SQL++
very well. Also, there is an overhead for parsing the query everytime.
In this patch, it's replaced with compiled statement in SQL++ which
provides support for attaching UDF to feed as well.

Details:
1. Remove SubscribeFeedStatement.
2. Remove SubscribeFeed related query compilation code, and reuse the
upsert dataflow.
3. Added SQL++ User Defined Function support for feed, including adding
multiple functions to one feed.
4. Related test cases added.
5. Change the default behavior of feed to be upsert instead of upsert.
'insert-feed' option is provided for experiment uses.
6. This patch also fixes several feed related bugs: [ASTERIXDB-2085]
[ASTERIXDB-2124].

Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/CompiledStatements.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/FeedEventsListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv15/cross-dv15.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed-with-aql-function/connect-feed-with-aql-function.5.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed-with-aql-function/connect-feed-with-aql-function.6.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed-with-aql-function/connect-feed-with-aql-function.7.server.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed-with-aql-function/connect-feed-with-aql-function.8.ddl.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed-with-function/connect-feed-with-function.1.ddl.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed-with-function/connect-feed-with-function.2.update.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/connect-feed-with-function/connect-feed-with-function.3.ddl.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/insert-feed/insert-feed.1.ddl.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/insert-feed/insert-feed.2.update.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/insert-feed/insert-feed.3.server.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/insert-feed/insert-feed.4.sleep.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/insert-feed/insert-feed.5.update.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/insert-feed/insert-feed.6.query.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/insert-feed/insert-feed.7.server.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/insert-feed/insert-feed.8.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/user-defined-functions/single-line-definition/single-line-definition.2.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/user-defined-functions/udf28/udf28.2.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv15/cross-dv15.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/connect-feed-with-function/connect-feed-with-function.1.ddl.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/connect-feed-with-function/connect-feed-with-function.2.update.sqlpp
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/connect-feed-with-function/connect-feed-with-function.3.server.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/connect-feed-with-function/connect-feed-with-function.4.sleep.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/connect-feed-with-function/connect-feed-with-function.5.update.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/connect-feed-with-function/connect-feed-with-function.

Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5311/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1262/
 (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1263/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2152/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1973/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1974/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][*DB] Enable loading external UDF for AsterixHyrac...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][*DB] Enable loading external UDF for 
AsterixHyracksIntegrationUtil
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1974/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2078
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I333238b944b1c6d48a2b80b87a25f600522e0cc4
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4315/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1975/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1983] Feed pipeline refactoring for SQL++
..


Patch Set 9: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1975/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2059
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped ...

2017-10-20 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2137][ING][API] Prevent REST API hang on stopped 
feeds
..


Patch Set 3: Contrib+1

Analytics Compatibility Tests Successful Build 2791
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2085
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd35ba0e61ac73086c6ba276e1f25a0cd094cf8c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1592/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1263/
 (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1968/ 
(4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1932/
 (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1264/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5312/ (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2086

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..

[NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- changed SqlppDistinctAggregationSugarVisitor superclass to
  AbstractSqlppSimpleExpressionVisitor
- Added documentation for distinct aggregates

Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppDistinctAggregationSugarVisitor.java
2 files changed, 17 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/86/2086/1

diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
index 5d94ea4..67c1ca3 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
@@ -1128,6 +1128,16 @@
 The query then uses the collection aggregate function ARRAY_COUNT to get the 
cardinality of each
 group of messages.
 
+Each aggregation function in SQL++ supports DISTINCT modifier which removes 
duplicate values from the input collection.
+
+# Example
+
+ARRAY_SUM(DISTINCT [1, 1, 2, 2, 3])
+ 
+This query returns:
+
+6
+
 ### SQL-92 Aggregation Functions
 For compatibility with the traditional SQL aggregation functions, SQL++ also 
offers SQL-92's
 aggregation function symbols (`COUNT`, `SUM`, `MAX`, `MIN`, and `AVG`) as 
supported syntactic sugar.
@@ -1155,6 +1165,8 @@
 In contrast to the SQL++ collection aggregate functions, these special SQL-92 
function symbols
 can only be used in the same way they are in standard SQL (i.e., with the same 
restrictions).
 
+DISTINCT modifier is also supported for these aggregate functions.
+
 ### SQL-92 Compliant GROUP BY Aggregations
 SQL++ provides full support for SQL-92 `GROUP BY` aggregation queries.
 The following query is such an example:
diff --git 
a/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppDistinctAggregationSugarVisitor.java
 
b/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppDistinctAggregationSugarVisitor.java
index e9b8334..c56bb9d 100644
--- 
a/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppDistinctAggregationSugarVisitor.java
+++ 
b/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppDistinctAggregationSugarVisitor.java
@@ -39,7 +39,7 @@
 import org.apache.asterix.lang.sqlpp.clause.SelectSetOperation;
 import org.apache.asterix.lang.sqlpp.expression.SelectExpression;
 import org.apache.asterix.lang.sqlpp.struct.SetOperationInput;
-import 
org.apache.asterix.lang.sqlpp.visitor.base.AbstractSqlppExpressionScopingVisitor;
+import 
org.apache.asterix.lang.sqlpp.visitor.base.AbstractSqlppSimpleExpressionVisitor;
 import org.apache.asterix.om.functions.BuiltinFunctions;
 import org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier;
 import org.apache.hyracks.algebricks.core.algebra.functions.IFunctionInfo;
@@ -49,9 +49,11 @@
  * {@code agg-distinct(expr) -> agg((FROM expr AS i SELECT DISTINCT VALUE i))} 

  * where {@code agg-distinct} is a distinct aggregate function, {@code agg} - 
a regular aggregate function
  */
-public class SqlppDistinctAggregationSugarVisitor extends 
AbstractSqlppExpressionScopingVisitor {
+public class SqlppDistinctAggregationSugarVisitor extends 
AbstractSqlppSimpleExpressionVisitor {
+protected final LangRewritingContext context;
+
 public SqlppDistinctAggregationSugarVisitor(LangRewritingContext context) {
-super(context);
+this.context = context;
 }
 
 @Override

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1255/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1871/ (6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6808/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6809/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1256/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documenta...

2017-10-20 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][COMP][DOC] Distinct aggregates cleanup, documentation
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1264/
 (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2086
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f974a0c1adb7eca492a6011401cc54fea74cd8e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


  1   2   >