[GitHub] couchdb-chttpd pull request: Add support for single_max_doc

[tonysun83]

Github user tonysun83 commented on the pull request:

https://github.com/apache/couchdb-chttpd/pull/114#issuecomment-211732349
  
Sounds, good, I also like the use_max_document_size.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2834) Server sends connection: close too early

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247192#comment-15247192
 ] 

ASF GitHub Bot commented on COUCHDB-2834:
-

GitHub user nickva opened a pull request:

https://github.com/apache/couchdb-couch/pull/164

When reading attachments, avoid closing connections too early

Signal mochiweb to not send connection:close headers
in order for the socket to be reused.

Before this commit, this signaling was done too late.

COUCHDB-2834

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-couch couchdb-2834

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-couch/pull/164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #164


commit c4624d95e45ec4b45f7c6ddfbc4cd61413ee1d63
Author: Nick Vatamaniuc 
Date:   2016-04-19T04:59:30Z

When reading attachments, avoid closing connections too early

Signal mochiweb to not send connection:close headers
in order for the socket to be reused.

Before this commit, this signaling was done too late.

COUCHDB-2834




> Server sends connection: close too early
> 
>
> Key: COUCHDB-2834
> URL: https://issues.apache.org/jira/browse/COUCHDB-2834
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Nick Vatamaniuc
>Priority: Blocker
>  Labels: has-pr
> Fix For: 2.0.0
>
>
> This is related COUCHDB-2833.
> This was found investigating the failure of replication tests. Specifically 
> couch_replicator_large_atts_tests, the {local, remote} sub-case.
> The test sets up push replications from local to remote.
> Replication workers  have more than 1 document larger than 
> MAX_BULK_ATT_SIZE=64K.  They start pushing them to the target, using a 
> keep-alive connection (default  for HTTP 1.1), the first few pipelined 
> requests will go through using the same connection, then server will accept 
> the first PUT to …/docid?edits=false, then return Connection:close and close 
> the connection after the 201 Created result.  
> Server should not close request too early and instead keep it open longer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-couch pull request: When reading attachments, avoid closin...

[nickva]

GitHub user nickva opened a pull request:

https://github.com/apache/couchdb-couch/pull/164

When reading attachments, avoid closing connections too early

Signal mochiweb to not send connection:close headers
in order for the socket to be reused.

Before this commit, this signaling was done too late.

COUCHDB-2834

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-couch couchdb-2834

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-couch/pull/164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #164


commit c4624d95e45ec4b45f7c6ddfbc4cd61413ee1d63
Author: Nick Vatamaniuc 
Date:   2016-04-19T04:59:30Z

When reading attachments, avoid closing connections too early

Signal mochiweb to not send connection:close headers
in order for the socket to be reused.

Before this commit, this signaling was done too late.

COUCHDB-2834




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2834) Server sends connection: close too early

[Nick Vatamaniuc (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247182#comment-15247182
 ] 

Nick Vatamaniuc commented on COUCHDB-2834:
--

Just noticed email from JIRA. Will have PR ready by tomorrow.

> Server sends connection: close too early
> 
>
> Key: COUCHDB-2834
> URL: https://issues.apache.org/jira/browse/COUCHDB-2834
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Nick Vatamaniuc
>Priority: Blocker
>  Labels: has-pr
> Fix For: 2.0.0
>
>
> This is related COUCHDB-2833.
> This was found investigating the failure of replication tests. Specifically 
> couch_replicator_large_atts_tests, the {local, remote} sub-case.
> The test sets up push replications from local to remote.
> Replication workers  have more than 1 document larger than 
> MAX_BULK_ATT_SIZE=64K.  They start pushing them to the target, using a 
> keep-alive connection (default  for HTTP 1.1), the first few pipelined 
> requests will go through using the same connection, then server will accept 
> the first PUT to …/docid?edits=false, then return Connection:close and close 
> the connection after the 201 Created result.  
> Server should not close request too early and instead keep it open longer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-couch pull request: Extend rename_on_delete behaviour on c...

[davisp]

Github user davisp commented on the pull request:

https://github.com/apache/couchdb-couch/pull/161#issuecomment-211596768
  
So thinking through this I think we may be conflating two different 
features that while similar are serving different purposes.

Specifically, there's one feature where we rename things into the .delete 
directory so that we can get rid of them quickly as well as manage cleanup when 
the server crashes during deletions. This feature has been in CouchDB for a 
long time dating back years.

The second feature was a small thing that Cloudant added to help manage 
recovering from accidental deletions. This feature was implemented by just 
changing the delete to rename a .couch file to a version that includes the 
deletion timestamp. This allowed operators to recover a "deleted" database for 
clients.

This PR appears to attempt to flatten both of these features by renaming 
files into the .delete directory with useful names and makes the actual 
deletion a bit subtler in that the various renames are munged and so its not 
100% obvious which feature we're handling in the various functions named 
delete/nuke_dir/delete_file/etc.

As a follow on, the renaming here also tries to move away from using a UUID 
in the .delete directory and instead uses a URL encoded path of the deleted 
file (relative to the root database directory). On first glance this seemed 
like a good idea, but researching filename length limits it'd be very easy to 
break this as a user only needs to create a database with > 255 characters on 
extX filesystems (and shorter on others).

What I think we should consider is that all of our deletions move the file 
to the .delete directory mirroring the original filesystem hierarchy. Then our 
existing "rename_on_delete" feature is relabeled as "delete_after_rename" with 
a default of true. This allows us to enable a sysadmin approach to recovering 
deleted databases as well as enables sysadmins to institute their own policies 
for actual deletion.

As a last note, I'd also like to see all of the file system/deletion logic 
moved to couch_file. Its quite awkward to have it split between couch_server 
and couch_file. I'd work on structuring the commits to have one that moves the 
existing logic to couch_file and then a subsequent commits to do the filesystem 
hierarchy mirroring.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2834) Server sends connection: close too early

[Robert Newson (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246617#comment-15246617
 ] 

Robert Newson commented on COUCHDB-2834:


noting that this should not prevent replication working.

> Server sends connection: close too early
> 
>
> Key: COUCHDB-2834
> URL: https://issues.apache.org/jira/browse/COUCHDB-2834
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Nick Vatamaniuc
>Priority: Blocker
>  Labels: has-pr
> Fix For: 2.0.0
>
>
> This is related COUCHDB-2833.
> This was found investigating the failure of replication tests. Specifically 
> couch_replicator_large_atts_tests, the {local, remote} sub-case.
> The test sets up push replications from local to remote.
> Replication workers  have more than 1 document larger than 
> MAX_BULK_ATT_SIZE=64K.  They start pushing them to the target, using a 
> keep-alive connection (default  for HTTP 1.1), the first few pipelined 
> requests will go through using the same connection, then server will accept 
> the first PUT to …/docid?edits=false, then return Connection:close and close 
> the connection after the 201 Created result.  
> Server should not close request too early and instead keep it open longer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-couch pull request: Extend rename_on_delete behaviour on c...

[davisp]

Github user davisp commented on a diff in the pull request:

https://github.com/apache/couchdb-couch/pull/161#discussion_r60137566
  
--- Diff: src/couch_file.erl ---
@@ -252,14 +252,23 @@ deleted_filename_suffix() ->
 [Y, Mon, D, H, Min, S, couch_uuids:random()]).
 
 nuke_dir(RootDelDir, Dir) ->
+case config:get_boolean("couchdb", "rename_on_delete", false) of
+true -> couch_server:delete_file(RootDelDir, Dir, []);
+false -> delete_dir(RootDelDir, Dir)
+end.
+
+delete_dir(RootDelDir, Dir) ->
 FoldFun = fun(File) ->
 Path = Dir ++ "/" ++ File,
 case filelib:is_dir(Path) of
 true ->
-ok = nuke_dir(RootDelDir, Path),
+ok = delete_dir(RootDelDir, Path),
 file:del_dir(Path);
 false ->
-delete(RootDelDir, Path, false)
+UUID = couch_uuids:random(),
+TmpFile = filename:join([RootDelDir, ".delete", UUID]),
+file:rename(Path, TmpFile),
+file:delete(TmpFile)
--- End diff --

I agree. The rename and delete isn't very useful here. I'd do what @rnewson 
suggests and just rename in nuke_dir, and then do a similar test as above in 
couch_file:delete that if rename_on_delete is true then we just don't do the 
recursion similar to what exists currently.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Minor text/btn changes

[benkeen]

Github user benkeen closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/661


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Minor text/btn changes

[benkeen]

Github user benkeen commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/661#issuecomment-211577372
  
Merged as bd7205f45c2c2448da7e8e06f743f2d0444177f9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2990) admins not honored in _security

[Sebastian Rothbucher (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246494#comment-15246494
 ] 

Sebastian Rothbucher commented on COUCHDB-2990:
---

could be a timing issue. reader_acl suffers, too (waiting 1s after _security 
changes helps), ditto replication. This needs some more investigation 
unfortunately

> admins not honored in _security
> ---
>
> Key: COUCHDB-2990
> URL: https://issues.apache.org/jira/browse/COUCHDB-2990
> Project: CouchDB
>  Issue Type: Bug
>  Components: BigCouch
>Reporter: Sebastian Rothbucher
>Priority: Minor
>
> Setting a user as admin (by name) and invoking a command (giving credentials 
> via Basic Auth) comes back saying the user is no DB admin. 
> Certainly minor thing for 2.1+ but 2 keep in mind; steps 2 reproduce:
> {noformat}
> # curl -X GET 'http://localhost:15984/play/_security'
> {"_rev":"2-dfe4d0fbab9b154d2100a95cefa66a92","admins":{"names":["jerry"]}}
> # curl -X PUT 'http://localhost:15984/play/'
> # curl -X PUT 'http://localhost:15984/play/_security' -d '{"admins": 
> {"names": ["jerry"]}}'
> # curl -X PUT 'http://localhost:15984/play/test' -d '{}' -u jerry:mouseee
> {"error":"unauthorized","reason":"Name or password is incorrect."}
> # curl -X PUT 'http://localhost:15984/play/test' -d '{}' -u jerry:mouse
> {"ok":true,"id":"test","rev":"1-967a00dff5e02add41819138abb3284d"}
> # curl -X PUT 'http://localhost:15984/play/_design/test' -d '{}' -u 
> jerry:mouse
> {"error":"forbidden","reason":"You are not a db or server admin."}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-chttpd pull request: Add support for single_max_doc

[tonysun83]

Github user tonysun83 commented on the pull request:

https://github.com/apache/couchdb-chttpd/pull/114#issuecomment-211556932
  
@kxepal : The reason behind adding single_doc_max_size was because 
max_document_size was for all POST/PUT requests. For bulk_docs, it would look 
at the whole docs array and count that as a single document size rather than 
individual documents. If we only remove the limitation for all POST/PUT 
requests and move that logic over to the updates only, then having 
max_document_size should be sufficient.

Even though users SHOULD input content-length in their headers, I feel it 
might be a little restrictive in the general case. I think we should continue 
with parsing the payload as we normally do.

As for multi-parts, what do you think about using the same logic as update 
and not counting the attachments (normal and inline) at all? This still doesn't 
solve your replication example. I don't know enough about replication scenarios 
yet. ServerA is 2 MB max document size, ServerB contains a 3 MB document. We 
send it over and ServerA denies the update. Will replication still continue if 
we throw some error in this case? 

For now, if we're going to continue with the original max_document_size, I 
am okay not having it at DB  level. We can keep the default very high, and let 
the admin decide what he or she wants to do with the cluster.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2988) Allow query selector as changes and replication filter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246103#comment-15246103
 ] 

ASF GitHub Bot commented on COUCHDB-2988:
-

Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-couch-replicator/pull/36


> Allow query selector as changes and replication filter
> --
>
> Key: COUCHDB-2988
> URL: https://issues.apache.org/jira/browse/COUCHDB-2988
> Project: CouchDB
>  Issue Type: Improvement
>  Components: Database Core, Mango
>Reporter: Nick Vatamaniuc
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (COUCHDB-2988) Allow query selector as changes and replication filter

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246102#comment-15246102
 ] 

ASF subversion and git services commented on COUCHDB-2988:
--

Commit 986549984be44c7e5cd66f3773d2bdd94f506e5c in couchdb-couch-replicator's 
branch refs/heads/master from [~kzx]
[ 
https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=9865499
 ]

Implement Mango selectors for replication

Replication document should have a "selector"
field with a Mango selector JSON object
as the value.

For example:
```
{
"_id": "r",
"continuous": true,
"selector": {
"_id": {
"$gte": "d2"
}
},
"source": "http://adm:pass@localhost:15984/a;,
"target": "http://adm:pass@localhost:15984/b;
}
```

This feature underneath uses the _changes feed
Mango selectors capability.

Replicator docs js validation function has been
updated to return an error if it notices user has
specified both `doc_ids` and `selector`. Or
they specified `filter` and either of the other
two.

Replication options parsing also checks for those
mutually exclusive fields, as replications can be
started from the `_replicate` endpoint not just
via the docs in `*_replicator` dbs.

When generating a replication id, Mango selector
object is normalized and sorted (JSON fields
are sorted inside objects only). That is done in order
to reduce the chance of creating two different
replication checkpoints for same Mango selector.

Jira: COUCHDB-2988


> Allow query selector as changes and replication filter
> --
>
> Key: COUCHDB-2988
> URL: https://issues.apache.org/jira/browse/COUCHDB-2988
> Project: CouchDB
>  Issue Type: Improvement
>  Components: Database Core, Mango
>Reporter: Nick Vatamaniuc
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-couch-replicator pull request: Implement Mango selectors f...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-couch-replicator/pull/36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Implement Mango selectors f...

[davisp]

Github user davisp commented on the pull request:


https://github.com/apache/couchdb-couch-replicator/pull/36#issuecomment-211477644
  
LGTM, +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: list node/npm dependency, needed to build fa...

[jo]

Github user jo commented on the pull request:

https://github.com/apache/couchdb/pull/406#issuecomment-211441930
  
updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: add sphinx-common to apt-get command

[jo]

Github user jo closed the pull request at:

https://github.com/apache/couchdb/pull/407


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: add sphinx-common to apt-get command

[jo]

Github user jo commented on the pull request:

https://github.com/apache/couchdb/pull/407#issuecomment-211437842
  
This is already in README-DEV.md, so I'm closing this. Thanks for pointing 
out!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: list node/npm dependency, needed to build fa...

[jo]

Github user jo commented on the pull request:

https://github.com/apache/couchdb/pull/406#issuecomment-211437559
  
OK will update this pr, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: list node/npm dependency, needed to build fa...

[kxepal]

Github user kxepal commented on the pull request:

https://github.com/apache/couchdb/pull/406#issuecomment-211436622
  
This is dev only command, it should be in README-DEV.md. To install CouchDB 
release you don't need in nodejs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: add sphinx-common to apt-get command

[jo]

GitHub user jo opened a pull request:

https://github.com/apache/couchdb/pull/407

add sphinx-common to apt-get command



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jo/couchdb patch-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb/pull/407.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #407


commit 9c3fd2e170327c447f85396f8fc169920b872e45
Author: Johannes Jörg Schmidt 
Date:   2016-04-18T15:37:09Z

add sphinx-common to apt-get command




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: list node/npm dependency, needed to build fa...

[jo]

GitHub user jo opened a pull request:

https://github.com/apache/couchdb/pull/406

list node/npm dependency, needed to build fauxton



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jo/couchdb patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb/pull/406.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #406


commit 3730f366510e3e316ff332fa7e8a0bcb317bd48f
Author: Johannes Jörg Schmidt 
Date:   2016-04-18T15:30:52Z

list node/npm dependency, needed to build fauxton




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Extend rename_on_delete behaviour on c...

[rnewson]

Github user rnewson commented on a diff in the pull request:

https://github.com/apache/couchdb-couch/pull/161#discussion_r60072419
  
--- Diff: src/couch_file.erl ---
@@ -252,14 +252,23 @@ deleted_filename_suffix() ->
 [Y, Mon, D, H, Min, S, couch_uuids:random()]).
 
 nuke_dir(RootDelDir, Dir) ->
+case config:get_boolean("couchdb", "rename_on_delete", false) of
+true -> couch_server:delete_file(RootDelDir, Dir, []);
+false -> delete_dir(RootDelDir, Dir)
+end.
+
+delete_dir(RootDelDir, Dir) ->
 FoldFun = fun(File) ->
 Path = Dir ++ "/" ++ File,
 case filelib:is_dir(Path) of
 true ->
-ok = nuke_dir(RootDelDir, Path),
+ok = delete_dir(RootDelDir, Path),
 file:del_dir(Path);
 false ->
-delete(RootDelDir, Path, false)
+UUID = couch_uuids:random(),
+TmpFile = filename:join([RootDelDir, ".delete", UUID]),
+file:rename(Path, TmpFile),
+file:delete(TmpFile)
--- End diff --

this still does seem a bit pointless in this context. The original context 
was deleting a database which, at the time, was a single file. When we're 
deleting all views, renaming each filed them immediately deleting it doesn't 
seem to do much beyond complicate things.

@davisp thoughts here pls?

I suggest that nuke_dir renames the top level Dir to .delete first and then 
recursively deletes it. That gives us the behaviour we want (making it easier 
to clean if we crash and restart during the time-consuming file:delete calls)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Extend rename_on_delete behaviour on c...

[rnewson]

Github user rnewson commented on a diff in the pull request:

https://github.com/apache/couchdb-couch/pull/161#discussion_r60071188
  
--- Diff: src/couch_file.erl ---
@@ -223,19 +223,33 @@ delete(RootDir, Filepath) ->
 
 
 delete(RootDir, Filepath, Async) ->
-DelFile = filename:join([RootDir,".delete", 
?b2l(couch_uuids:random())]),
+DelFile = deleted_filename(RootDir, Filepath),
+RenameOnDelete = config:get_boolean("couchdb", "rename_on_delete", 
false),
 case file:rename(Filepath, DelFile) of
-ok ->
-if (Async) ->
+ok when RenameOnDelete ->
+ok;
+ok when Async ->
 spawn(file, delete, [DelFile]),
 ok;
-true ->
-file:delete(DelFile)
-end;
-Error ->
-Error
+ok ->
--- End diff --

diff would have been clearer if you hadn't mixed whitespace changes with 
functional changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Extend rename_on_delete behaviour on c...

[rnewson]

Github user rnewson commented on the pull request:

https://github.com/apache/couchdb-couch/pull/161#issuecomment-211406820
  
(noting that ionice doesn't apply to delete operations anyway)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2988) Allow query selector as changes and replication filter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245759#comment-15245759
 ] 

ASF GitHub Bot commented on COUCHDB-2988:
-

Github user asfgit closed the pull request at:

https://github.com/apache/couchdb/pull/405


> Allow query selector as changes and replication filter
> --
>
> Key: COUCHDB-2988
> URL: https://issues.apache.org/jira/browse/COUCHDB-2988
> Project: CouchDB
>  Issue Type: Improvement
>  Components: Database Core, Mango
>Reporter: Nick Vatamaniuc
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb pull request: Mango Selectors for _changes feeds

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/couchdb/pull/405


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2988) Allow query selector as changes and replication filter

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245758#comment-15245758
 ] 

ASF subversion and git services commented on COUCHDB-2988:
--

Commit 76e9510c4cb0ebd653e0a6c3f996bf43aa4a2b77 in couchdb's branch 
refs/heads/master from [~kzx]
[ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=76e9510 ]

Mango Selectors for _changes feeds

Jira: COUCHDB-2988


> Allow query selector as changes and replication filter
> --
>
> Key: COUCHDB-2988
> URL: https://issues.apache.org/jira/browse/COUCHDB-2988
> Project: CouchDB
>  Issue Type: Improvement
>  Components: Database Core, Mango
>Reporter: Nick Vatamaniuc
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb pull request: Mango Selectors for _changes feeds

[nickva]

Github user nickva commented on the pull request:

https://github.com/apache/couchdb/pull/405#issuecomment-211378462
  
@kxepal agreed, updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2988) Allow query selector as changes and replication filter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245644#comment-15245644
 ] 

ASF GitHub Bot commented on COUCHDB-2988:
-

Github user kxepal commented on the pull request:

https://github.com/apache/couchdb/pull/405#issuecomment-211376662
  
May be a more human friendly commit message? Just:
```
Mango Selectors for _changes feeds

COUCHDB-2988
```


> Allow query selector as changes and replication filter
> --
>
> Key: COUCHDB-2988
> URL: https://issues.apache.org/jira/browse/COUCHDB-2988
> Project: CouchDB
>  Issue Type: Improvement
>  Components: Database Core, Mango
>Reporter: Nick Vatamaniuc
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb pull request: [deps] couch=bf9cd2b1c36909b41fc3db40f4a2c35...

[kxepal]

Github user kxepal commented on the pull request:

https://github.com/apache/couchdb/pull/405#issuecomment-211376662
  
May be a more human friendly commit message? Just:
```
Mango Selectors for _changes feeds

COUCHDB-2988
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2988) Allow query selector as changes and replication filter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245641#comment-15245641
 ] 

ASF GitHub Bot commented on COUCHDB-2988:
-

GitHub user nickva opened a pull request:

https://github.com/apache/couchdb/pull/405

[deps] couch=bf9cd2b1c36909b41fc3db40f4a2c351e2e43182

 Jira: COUCHDB-2988 (Mango Selectors for _changes feeds).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb couchdb-2988

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb/pull/405.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #405


commit 814109829f540d61e3eba906cc51cb5e8bb9cea9
Author: Nick Vatamaniuc 
Date:   2016-04-18T13:19:43Z

[deps] couch=bf9cd2b1c36909b41fc3db40f4a2c351e2e43182

 Jira: COUCHDB-2988 (Mango Selectors for _changes feeds).




> Allow query selector as changes and replication filter
> --
>
> Key: COUCHDB-2988
> URL: https://issues.apache.org/jira/browse/COUCHDB-2988
> Project: CouchDB
>  Issue Type: Improvement
>  Components: Database Core, Mango
>Reporter: Nick Vatamaniuc
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb pull request: [deps] couch=bf9cd2b1c36909b41fc3db40f4a2c35...

[nickva]

GitHub user nickva opened a pull request:

https://github.com/apache/couchdb/pull/405

[deps] couch=bf9cd2b1c36909b41fc3db40f4a2c351e2e43182

 Jira: COUCHDB-2988 (Mango Selectors for _changes feeds).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb couchdb-2988

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb/pull/405.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #405


commit 814109829f540d61e3eba906cc51cb5e8bb9cea9
Author: Nick Vatamaniuc 
Date:   2016-04-18T13:19:43Z

[deps] couch=bf9cd2b1c36909b41fc3db40f4a2c351e2e43182

 Jira: COUCHDB-2988 (Mango Selectors for _changes feeds).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Implement Mango selectors f...

[kxepal]

Github user kxepal commented on the pull request:


https://github.com/apache/couchdb-couch-replicator/pull/36#issuecomment-211373980
  
Nice!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2988) Allow query selector as changes and replication filter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245620#comment-15245620
 ] 

ASF GitHub Bot commented on COUCHDB-2988:
-

GitHub user nickva opened a pull request:

https://github.com/apache/couchdb-couch-replicator/pull/36

Implement Mango selectors for replication

Replication document should have a "selector"
field with a Mango selector JSON object
as the value.

Example:
```
{
"_id": "r",
"continuous": true,
"selector": {
"_id": {
"$gte": "d2"
}
},
"source": "http://adm:pass@localhost:15984/a;,
"target": "http://adm:pass@localhost:15984/b;
}
```

This feature underneath uses the _changes feed
Mango selectors capability.

Replicator docs js validation function has been
updated to return an error if it notices user has
specified both `doc_ids` and `selector`. Or
they specified `filter` and either of the other
two.

Replication options parsing also checks for those
mutually exclusive fields, as replications can be
started from the `_replicate` endpoint not just
via the docs in `*_replicator` dbs.

When generating a replication id, Mango selector
object is normalized and sorted (JSON fields
are sorted inside objects only). That is done in order
to reduce the chance of creating two different
replication checkpoints for same Mango selector.

Jira: COUCHDB-2988

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-couch-replicator couchdb-2988

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-couch-replicator/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 46be859d8b6f7638ce67130878a3bb5c1a1644b4
Author: Nick Vatamaniuc 
Date:   2016-04-15T22:04:17Z

Implement Mango selectors for replication

Replication document should have a "selector"
field with a Mango selector JSON object
as the value.

Example:
```
{
"_id": "r",
"continuous": true,
"selector": {
"_id": {
"$gte": "d2"
}
},
"source": "http://adm:pass@localhost:15984/a;,
"target": "http://adm:pass@localhost:15984/b;
}
```

This feature underneath uses the _changes feed
Mango selectors capability.

Replicator docs js validation function has been
updated to return an error if it notices user has
specified both `doc_ids` and `selector`. Or
they specified `filter` and either of the other
two.

Replication options parsing also checks for those
mutually exclusive fields, as replications can be
started from the `_replicate` endpoint not just
via the docs in `*_replicator` dbs.

When generating a replication id, Mango selector
object is normalized and sorted (JSON fields
are sorted inside objects only). That is done in order
to reduce the chance of creating two different
replication checkpoints for same Mango selector.

Jira: COUCHDB-2988




> Allow query selector as changes and replication filter
> --
>
> Key: COUCHDB-2988
> URL: https://issues.apache.org/jira/browse/COUCHDB-2988
> Project: CouchDB
>  Issue Type: Improvement
>  Components: Database Core, Mango
>Reporter: Nick Vatamaniuc
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-couch-replicator pull request: Implement Mango selectors f...

[nickva]

GitHub user nickva opened a pull request:

https://github.com/apache/couchdb-couch-replicator/pull/36

Implement Mango selectors for replication

Replication document should have a "selector"
field with a Mango selector JSON object
as the value.

Example:
```
{
"_id": "r",
"continuous": true,
"selector": {
"_id": {
"$gte": "d2"
}
},
"source": "http://adm:pass@localhost:15984/a;,
"target": "http://adm:pass@localhost:15984/b;
}
```

This feature underneath uses the _changes feed
Mango selectors capability.

Replicator docs js validation function has been
updated to return an error if it notices user has
specified both `doc_ids` and `selector`. Or
they specified `filter` and either of the other
two.

Replication options parsing also checks for those
mutually exclusive fields, as replications can be
started from the `_replicate` endpoint not just
via the docs in `*_replicator` dbs.

When generating a replication id, Mango selector
object is normalized and sorted (JSON fields
are sorted inside objects only). That is done in order
to reduce the chance of creating two different
replication checkpoints for same Mango selector.

Jira: COUCHDB-2988

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-couch-replicator couchdb-2988

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-couch-replicator/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 46be859d8b6f7638ce67130878a3bb5c1a1644b4
Author: Nick Vatamaniuc 
Date:   2016-04-15T22:04:17Z

Implement Mango selectors for replication

Replication document should have a "selector"
field with a Mango selector JSON object
as the value.

Example:
```
{
"_id": "r",
"continuous": true,
"selector": {
"_id": {
"$gte": "d2"
}
},
"source": "http://adm:pass@localhost:15984/a;,
"target": "http://adm:pass@localhost:15984/b;
}
```

This feature underneath uses the _changes feed
Mango selectors capability.

Replicator docs js validation function has been
updated to return an error if it notices user has
specified both `doc_ids` and `selector`. Or
they specified `filter` and either of the other
two.

Replication options parsing also checks for those
mutually exclusive fields, as replications can be
started from the `_replicate` endpoint not just
via the docs in `*_replicator` dbs.

When generating a replication id, Mango selector
object is normalized and sorted (JSON fields
are sorted inside objects only). That is done in order
to reduce the chance of creating two different
replication checkpoints for same Mango selector.

Jira: COUCHDB-2988




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-mem3 pull request: Improve mem3_sync event listener perfor...

[mikewallace1979]

Github user mikewallace1979 commented on the pull request:

https://github.com/apache/couchdb-mem3/pull/19#issuecomment-211353645
  
@banjiewen Ah that makes sense and I agree that "delay" fits better with 
operator's understanding of the system than "bucket count".

+1 from me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2252) Digest for attachments is calculated from compressed data.

[Johannes J. Schmidt (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245414#comment-15245414
 ] 

Johannes J. Schmidt commented on COUCHDB-2252:
--

This seems to be not a problem in 1.6.1 anymore, as shown with this curl 
session:

{code}
$ curl http://localhost:5984
{"couchdb":"Welcome","uuid":"f92d783dc25255c843f4a68942ab1a16","version":"1.6.1","vendor":{"name":"The
 Apache Software Foundation","version":"1.6.1"}}
$ curl http://localhost:5984/_config/couchdb/file_compression
"snappy"
$ curl http://localhost:5984/_config/attachments/compressible_types
"text/*, application/javascript, application/json, application/xml"

$ curl -XPUT http://localhost:5984/test-2252
{"ok":true}

$ curl -XPUT http://localhost:5984/test-2252/snappy/data.json -d...@data.json 
-H'Content-Type:application/json'
{"ok":true,"id":"snappy","rev":"1-21b4756f366eb6c17a161b44960911c2"}

$ curl -XPUT http://localhost:5984/_config/couchdb/file_compression -d'"none"'
"snappy"

$ curl -XPUT http://localhost:5984/test-2252/none/data.json -d...@data.json 
-H'Content-Type:application/json'
{"ok":true,"id":"none","rev":"1-21b4756f366eb6c17a161b44960911c2"}

$ curl http://localhost:5984/test-2252/snappy
{"_id":"snappy","_rev":"1-21b4756f366eb6c17a161b44960911c2","_attachments":{"data.json":{"content_type":"application/json","revpos":1,"digest":"md5-tZARHgBFd0PpmG0sebe1fg==","length":216259,"stub":true}}}
$ curl http://localhost:5984/test-2252/none
{"_id":"none","_rev":"1-21b4756f366eb6c17a161b44960911c2","_attachments":{"data.json":{"content_type":"application/json","revpos":1,"digest":"md5-tZARHgBFd0PpmG0sebe1fg==","length":216259,"stub":true}}}
{code}

Here we created two documents with the same attachment. For the second one we 
changed compression from {{snappy}} to {{none}} before we created it. Than we 
can compare the {{digest}} of both attachments. They are the same.

> Digest for attachments is calculated from compressed data. 
> ---
>
> Key: COUCHDB-2252
> URL: https://issues.apache.org/jira/browse/COUCHDB-2252
> Project: CouchDB
>  Issue Type: Bug
>  Components: Database Core
>Reporter: Alexander Fedorenchik
>
> Actual behaviour:
> CouchDB returns digest calculated from compressed data for attachments with 
> MIME types listed in config. 
> http://docs.couchdb.org/en/latest/config/misc.html#attachments
> Expected behaviour:
> CouchDB should return digest calculated from raw data to be able to compare 
> it with local one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-couch pull request: headers specified in a JS rewrite can ...

[janl]

Github user janl commented on the pull request:

https://github.com/apache/couchdb-couch/pull/163#issuecomment-211306569
  
merged, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: headers specified in a JS rewrite can ...

[janl]

Github user janl closed the pull request at:

https://github.com/apache/couchdb-couch/pull/163


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: headers specified in a JS rewrite can ...

[kxepal]

Github user kxepal commented on the pull request:

https://github.com/apache/couchdb-couch/pull/163#issuecomment-211304040
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: scrap make install, build full couch into re...

[janl]

Github user janl commented on the pull request:

https://github.com/apache/couchdb/pull/402#issuecomment-211303842
  
@kxepal https://pony-poc.apache.org/list.html?d...@couchdb.apache.org


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: scrap make install, build full couch into re...

[janl]

Github user janl commented on the pull request:

https://github.com/apache/couchdb/pull/402#issuecomment-211296364
  
`make install` doesn’t exist :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd pull request: Add support for single_max_doc

[janl]

Github user janl commented on the pull request:

https://github.com/apache/couchdb-chttpd/pull/114#issuecomment-211254601
  
I like the idea here, but am also weary about adding a new config parameter 
that appears to be close to what we already have. Looking forward to what you 
come up with @tonysun83!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: scrap make install, build full couch into re...

[janl]

Github user janl commented on the pull request:

https://github.com/apache/couchdb/pull/402#issuecomment-211247246
  
Renamed to `make build` and made `make install` print a notice.





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Upgrade fauxton to 1.1.2

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/couchdb/pull/404


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: scrap make install, build full couch into re...

[janl]

Github user janl commented on the pull request:

https://github.com/apache/couchdb/pull/402#issuecomment-211242739
  
confirmed



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Upgrade fauxton to 1.1.2

[janl]

Github user janl commented on the pull request:

https://github.com/apache/couchdb/pull/404#issuecomment-211240822
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: scrap make install, build full couch into re...

[garrensmith]

Github user garrensmith commented on the pull request:

https://github.com/apache/couchdb/pull/402#issuecomment-211229739
  
PR #404 will fix the fauxton issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Upgrade fauxton to 1.1.2

[garrensmith]

GitHub user garrensmith opened a pull request:

https://github.com/apache/couchdb/pull/404

Upgrade fauxton to 1.1.2

This adds the fix that fauxton will be correctly built with CouchDB

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/couchdb fauxton-1.1.2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb/pull/404.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #404


commit 5330184cd9405de78e1ba46079ba26098ddcb2f3
Author: Garren Smith 
Date:   2016-04-18T06:42:35Z

Upgrade fauxton to 1.1.2

This adds the fix that fauxton will be correctly built with CouchDB




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Add recommended docs section

[garrensmith]

Github user garrensmith commented on the pull request:

https://github.com/apache/couchdb/pull/403#issuecomment-211224658
  
I really like this idea. I think a mixture of general distributed systems 
reading and CouchDB reading would be cool. I would keep the info you have here 
already and then add some CouchDB related docs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---