[GitHub] mayya-sharipova commented on a change in pull request #635: Stop indexing activity on ddoc update
mayya-sharipova commented on a change in pull request #635: Stop indexing
activity on ddoc update
URL: https://github.com/apache/couchdb/pull/635#discussion_r127536910
##
File path: src/couch_index/src/couch_index_server.erl
##
@@ -257,6 +257,12 @@ handle_db_event(<<"shards/", _/binary>> = DbName,
{ddoc_updated,
couch_db:open_doc(Db, DDocId, [ejson_body, ?ADMIN_CTX])
end),
DbShards = [mem3:name(Sh) || Sh <- mem3:local_shards(mem3:dbname(DbName))],
+% Send ddoc_updated message to all couch_index processes for this DDoc,
+% with the intention to close them.
+% There can be other DDocs with the same Signature, served by the
+% same couch_index processes, but the possibility for it is low,
+% the negative effect is minor, and the check itself is expensive,
+% => this check is skipped.
Review comment:
@davisp thanks Paul for the review, will work on this change
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] nickva commented on issue #622: Allow keep_sending_changes to use hot code upgrade
nickva commented on issue #622: Allow keep_sending_changes to use hot code upgrade URL: https://github.com/apache/couchdb/pull/622#issuecomment-315442131 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[Jenkins] SUCCESS: CouchDB » master #95
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/95/
[Jenkins] FAILURE: CouchDB » master #94
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/94/
[GitHub] tonysun83 commented on a change in pull request #606: Use Ejson Body Instead of Compressed Body for External size
tonysun83 commented on a change in pull request #606: Use Ejson Body Instead of
Compressed Body for External size
URL: https://github.com/apache/couchdb/pull/606#discussion_r127500827
##
File path: src/couch/src/couch_db_updater.erl
##
@@ -1467,6 +1474,16 @@ make_doc_summary(#db{compression = Comp}, {Body0,
Atts0}) ->
SummaryBin = ?term_to_bin({Body, Atts}),
couch_file:assemble_file_chunk(SummaryBin, couch_crypto:hash(md5,
SummaryBin)).
+
+get_meta_body_size(Meta, Summary) ->
+case lists:keyfind(ejson_size, 1, Meta) of
+{ejson_size, ExternalSize} ->
+ExternalSize;
+false ->
+couch_compress:decompress(Summary)
Review comment:
wups, I was looking at the other place
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] nickva closed pull request #679: Fix flaky os daemons tests
nickva closed pull request #679: Fix flaky os daemons tests URL: https://github.com/apache/couchdb/pull/679 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davisp commented on issue #679: Fix flaky os daemons tests
davisp commented on issue #679: Fix flaky os daemons tests URL: https://github.com/apache/couchdb/pull/679#issuecomment-315406016 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nickva opened a new pull request #679: Fix flaky os daemons tests
nickva opened a new pull request #679: Fix flaky os daemons tests URL: https://github.com/apache/couchdb/pull/679 Fix flaky os daemons tests The "should die" test was close to the edge of timing out. Daemon started up, slept for 1 second then died. However max_retries is 3 so the whole thing was happening 3 times in a row. The total wait was 4 seconds, but on slow machines 1 extra second was not enough for the overhead of forking the 3 processes and other setup stuff. Set restart times to 2. Hopefully 4 seconds should be enough overhead for 2 restarts. Also adjust sleep time for the "die quickly" test. 1 second there might not be enough for both restarts, so made it 2 just to be safe. Also in a separate commit, remove unused TIMEOUT macro from os daemons module This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davisp opened a new pull request #678: TMP: Add debug logging for failed assertion
davisp opened a new pull request #678: TMP: Add debug logging for failed assertion URL: https://github.com/apache/couchdb/pull/678 Opening this as a PR so that it gets built by CI to try and diagnose #674. This isn't intended to actually be merged (unless I can't get a failure then maybe I will so it'll be around when that test eventually does fail again). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davisp commented on issue #674: Flaky compaction daemon test
davisp commented on issue #674: Flaky compaction daemon test URL: https://github.com/apache/couchdb/issues/674#issuecomment-315401626 I'm gonna add a log message when the assertion fails to try and figure out what it is exactly that's causing this to fail. Hopefully that'll shed some light on who it is causing us issues. PR incoming. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nickva closed pull request #676: Fix replication Javascript test
nickva closed pull request #676: Fix replication Javascript test URL: https://github.com/apache/couchdb/pull/676 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nickva closed pull request #677: Make replication filter fetch error for _replicate return a 404
nickva closed pull request #677: Make replication filter fetch error for _replicate return a 404 URL: https://github.com/apache/couchdb/pull/677 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davisp commented on a change in pull request #635: Stop indexing activity on ddoc update
davisp commented on a change in pull request #635: Stop indexing activity on
ddoc update
URL: https://github.com/apache/couchdb/pull/635#discussion_r127492345
##
File path: src/couch_index/src/couch_index_server.erl
##
@@ -257,6 +257,12 @@ handle_db_event(<<"shards/", _/binary>> = DbName,
{ddoc_updated,
couch_db:open_doc(Db, DDocId, [ejson_body, ?ADMIN_CTX])
end),
DbShards = [mem3:name(Sh) || Sh <- mem3:local_shards(mem3:dbname(DbName))],
+% Send ddoc_updated message to all couch_index processes for this DDoc,
+% with the intention to close them.
+% There can be other DDocs with the same Signature, served by the
+% same couch_index processes, but the possibility for it is low,
+% the negative effect is minor, and the check itself is expensive,
+% => this check is skipped.
Review comment:
This is slightly worrisome as we have an established pattern of creating
identical design docs to create views in the background without disrupting
production. When we go to swap the design docs (ie, update old design doc to
contents of new version, and then delete the old version) this would cause a
non trivial amount of interruption to requests in progress.
I assume when you say that the check is expensive you're referring to the
cost of looking up every design document and calculating signatures to see if
we have duplicates. I wonder if a slight modification to just keep track of
alternate design document names when opening the index would be useful here.
That sort of "alias list" would have been useful a number of times that I can
remember when debugging various customer issues. Then that makes the check
something more along the lines of "if length(alias_list) == 1" which would be
sufficiently cheap.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] davisp commented on issue #677: Make replication filter fetch error for _replicate return a 404
davisp commented on issue #677: Make replication filter fetch error for _replicate return a 404 URL: https://github.com/apache/couchdb/pull/677#issuecomment-315398095 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davisp commented on issue #676: Fix replication Javascript test
davisp commented on issue #676: Fix replication Javascript test URL: https://github.com/apache/couchdb/pull/676#issuecomment-315397858 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nickva commented on issue #676: Fix replication Javascript test
nickva commented on issue #676: Fix replication Javascript test
URL: https://github.com/apache/couchdb/pull/676#issuecomment-315384435
Tested on a CPU and disk resource constrained VM
CPU resources slowed down to 9% and disk throughput limit set at 100KB/sec
```VBoxManage bandwidthctl ${VM} set Limit --limit 100KB```
Seems to pass when before it failed:
```
test/javascript/run replication.js
test/javascript/tests/replication.js pass
===
JavaScript tests complete.
Failed: 0. Skipped or passed: 1.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] nickva opened a new pull request #677: Make replication filter fetch error for _replicate return a 404
nickva opened a new pull request #677: Make replication filter fetch error for _replicate return a 404 URL: https://github.com/apache/couchdb/pull/677 Previously it returned a 500 error. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nickva opened a new pull request #676: Fix replication Javascript test
nickva opened a new pull request #676: Fix replication Javascript test URL: https://github.com/apache/couchdb/pull/676 The test was flaky for a variety of reasons: * waitForSeq only waited for 3 seconds and on failure it never explitly indicated an error and just waited for the comparison below to fail. So made it wait for 30 seconds and also throw an exception right away if it fails. * Last waitForSeq was used after task was canceled. So it just wasted time waiting until timeout as the task was null. So created a function to wait for task to be null. * waitForSeq spun in a tight do/while loop querying _active_tasks. In some test environment with minimal CPU resources that's not the greatest thing to do. So made it wait for 0.5 seconds between retries. * waitForSeq waited for replication task's through_seq value to match source update sequence from source db info. Those don't necessarily match. Instead made waitForSeq use the changes feed last sequence since that's what the replication task uses to update through_seq. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl commented on issue #144: Update confusing note on dd copy operation
janl commented on issue #144: Update confusing note on dd copy operation URL: https://github.com/apache/couchdb-documentation/pull/144#issuecomment-315343033 Just needs trailing whitespace removed before we can merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] calonso opened a new pull request #144: Update confusing note on dd copy operation
calonso opened a new pull request #144: Update confusing note on dd copy operation URL: https://github.com/apache/couchdb-documentation/pull/144 ## Overview Just replace a misleading note regarding `COPY` operation on Design documents. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[Jenkins] FAILURE: CouchDB » jenkins-build-packages #19
Boo, we failed. https://builds.apache.org/job/CouchDB/job/jenkins-build-packages/19/
[Jenkins] FAILURE: CouchDB » jenkins-build-packages #18
Boo, we failed. https://builds.apache.org/job/CouchDB/job/jenkins-build-packages/18/
[Jenkins] FAILURE: CouchDB » jenkins-build-packages #16
Boo, we failed. https://builds.apache.org/job/CouchDB/job/jenkins-build-packages/16/
[Jenkins] FAILURE: CouchDB » jenkins-build-packages #15
Boo, we failed. https://builds.apache.org/job/CouchDB/job/jenkins-build-packages/15/
