[GitHub] couchdb-documentation issue #83: Describe selector objects as part of a repl...

2016-10-18 Thread nickva
Github user nickva commented on the issue:

https://github.com/apache/couchdb-documentation/pull/83
  
Look great, @warmana 

Merged.

Thank  you again, for your contribution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-documentation issue #83: Describe selector objects as part of a repl...

2016-10-18 Thread warmana
Github user warmana commented on the issue:

https://github.com/apache/couchdb-documentation/pull/83
  
Aha, apologies for both of those. I can and will fix them...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-documentation issue #83: Describe selector objects as part of a repl...

2016-10-18 Thread nickva
Github user nickva commented on the issue:

https://github.com/apache/couchdb-documentation/pull/83
  
Looks good @warmana . Thank you.  One minor thing is some lines are two 
long and the make lint check target for documentation is failing (if you clink 
on the red X it shows some of the failing lines).

Here is one example line:

```
python ext/linter.py src/

/home/travis/build/apache/couchdb-documentation/src/json-structure.rst

  line 246 : too long (86 > 80) line


++---+

  line 247 : too long (86 > 80) line

| Field  | Description  
 |

```

Also I see this for the main check:

```
/Users/nvatama/asf/couchdb/src/docs/src/replication/replicator.rst
  line 437 : too many empty lines
  line 437 : no empty last lines please
```

Would it be possible to make the lines shorter or it is part of the table, 
it would completely break the layout? If it is too hard, we can look at perhaps 
disabling the warning for that file. Let me know if you need help, I can try to 
do some of these cleanups if setting up the doc compilation chain is too tricky.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---